Re: KASAN: invalid-free in p9stat_free

2018-08-26 Thread Dominique Martinet
syzbot wrote on Sun, Aug 26, 2018: > HEAD commit:e27bc174c9c6 Add linux-next specific files for 20180824 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=15dc19a640 > kernel config: https://syzkaller.appspot.com/x/.config?x=28446088176757ea >

Re: oops with ip6_rt_cache_alloc

2018-08-26 Thread Yonghong Song
On 8/24/18 4:04 PM, David Ahern wrote: On 8/24/18 4:26 PM, Yonghong Song wrote: Hi, We got a kernel oops with the following stack trace: CPU: 24 PID: 0 Comm: swapper/24 Not tainted 4.16.0-10_fbk1_1183_g7e4ee4c8171c #10 "Hardware name: Quanta Leopard-DDR3/Leopard-DDR3, BIOS F06_3A16.DDR3

Re: [RFC v3 net-next 3/5] ebpf: fix bpf_msg_pull_data

2018-08-26 Thread Tushar Dave
On 08/24/2018 06:02 PM, John Fastabend wrote: On 08/17/2018 04:08 PM, Tushar Dave wrote: Like sockmap (sk_msg), socksg also deals with struct scatterlist therefore socksg programs can use existing bpf helper bpf_msg_pull_data to access packet data contained in struct scatterlist. While doing

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Julia Lawall
On Mon, 27 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 11:35:17PM -0400, Julia Lawall wrote: > > > * x = \(kmalloc\|kzalloc\|devm_kmalloc\|devm_kzalloc\)(...) > > I can name several you've missed right off the top of my head - > vmalloc, kvmalloc, kmem_cache_alloc, kmem_cache_zalloc,

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Al Viro
On Sun, Aug 26, 2018 at 11:35:17PM -0400, Julia Lawall wrote: > * x = \(kmalloc\|kzalloc\|devm_kmalloc\|devm_kzalloc\)(...) I can name several you've missed right off the top of my head - vmalloc, kvmalloc, kmem_cache_alloc, kmem_cache_zalloc, variants with _trace slapped on, and that is not to

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Julia Lawall
On Mon, 27 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 10:00:46PM -0400, Julia Lawall wrote: > > > > > > On Sun, 26 Aug 2018, Al Viro wrote: > > > > > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > > > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > > > > On Sun,

[PATCH v2 iproute2-next 0/3] support delivering packets in

2018-08-26 Thread Yousuk Seung
This series adds support for the new "slot" netem parameter for slotting. Slotting is an approximation of shared media that gather up packets within a varying delay window before delivering them nearly at once. Dave Taht (2): tc: support conversions to or from 64 bit nanosecond-based time

[PATCH v2 iproute2-next 1/3] tc: support conversions to or from 64 bit nanosecond-based time

2018-08-26 Thread Yousuk Seung
From: Dave Taht Using a 32 bit field to represent time in nanoseconds results in a maximum value of about 4.3 seconds, which is well below many observed delays in WiFi and LTE, and barely in the ballpark for a trip past the Earth's moon, Luna. Using 64 bit time fields in nanoseconds allows us

[PATCH v2 iproute2-next 2/3] q_netem: support delivering packets in delayed time slots

2018-08-26 Thread Yousuk Seung
From: Dave Taht Slotting is a crude approximation of the behaviors of shared media such as cable, wifi, and LTE, which gather up a bunch of packets within a varying delay window and deliver them, relative to that, nearly all at once. It works within the existing loss, duplication, jitter and

[PATCH v2 iproute2-next 3/3] q_netem: slotting with non-uniform distribution

2018-08-26 Thread Yousuk Seung
Extend slotting with support for non-uniform distributions. This is similar to netem's non-uniform distribution delay feature. Syntax: slot distribution DISTRIBUTION DELAY JITTER [packets MAX_PACKETS] \ [bytes MAX_BYTES] The syntax and use of the distribution table is the same as in the

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Al Viro
On Sun, Aug 26, 2018 at 10:00:46PM -0400, Julia Lawall wrote: > > > On Sun, 26 Aug 2018, Al Viro wrote: > > > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote:

[PATCH RFC net-next] net/fib: Poptrie based FIB lookup

2018-08-26 Thread Md. Islam
This patch implements Poptrie [1] based FIB lookup. It exhibits pretty impressive lookup performance compared to LC-trie. This poptrie implementation however somewhat deviates from the original implementation [2]. I tested this patch very rigorously with several FIB tables containing half a

[PATCH RFC net-next] net: Poptrie based FIB lookup

2018-08-26 Thread Md. Islam
This patch implements Poptrie [1] based FIB lookup. It exhibits pretty impressive lookup performance compared to LC-trie. This poptrie implementation however somewhat deviates from the original implementation [2]. I tested this patch very rigorously with several FIB tables containing half a

[V2][PATCH net] tipc: fix the big/little endian issue in tipc_dest

2018-08-26 Thread Haiqing Bai
In function tipc_dest_push, the 32bit variables 'node' and 'port' are stored separately in uppper and lower part of 64bit 'value'. Then this value is assigned to dst->value which is a union like: union { struct { u32 port; u32 node; }; u64 value; } This works on little-endian

RE: [PATCH net] tipc: fix the big/little endian issue in tipc_dest

2018-08-26 Thread Bai, Haiqing
Thanks, V2 will be send out. -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: 2018年8月26日 8:37 To: Bai, Haiqing Cc: netdev@vger.kernel.org; jon.ma...@ericsson.com; Xue, Ying; Gao, Zhenbo; linux-ker...@vger.kernel.org Subject: Re: [PATCH net] tipc: fix the

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Julia Lawall
On Sun, 26 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote: > > > > > > > > That, BTW, is why I hate the use of sizeof(*p) in kmalloc,

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Julia Lawall
On Sun, 26 Aug 2018, Joe Perches wrote: > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote: > > > > > > That, BTW, is why I hate the use of sizeof(*p) in kmalloc, etc. > > > > arguments. typeof is even worse in that respect. > >

[PATCH V2 net 0/2] net: hns: fix some bugs about speed and duplex change

2018-08-26 Thread Peng Li
If there are packets in hardware when changing the spped or duplex, it may cause hardware hang up. This patchset adds the code for waiting chip to clean the all pkts(TX & RX) in chip when the driver uses the function named "adjust link". This patchset cleans the pkts as follows: 1) close rx of

[PATCH V2 net 2/2] net: hns: add netif_carrier_off before change speed and duplex

2018-08-26 Thread Peng Li
If there are packets in hardware when changing the speed or duplex, it may cause hardware hang up. This patch adds netif_carrier_off before change speed and duplex in ethtool_ops.set_link_ksettings, and adds netif_carrier_on after complete the change. Signed-off-by: Peng Li ---

[PATCH V2 net 1/2] net: hns: add the code for cleaning pkt in chip

2018-08-26 Thread Peng Li
If there are packets in hardware when changing the speed or duplex, it may cause hardware hang up. This patch adds the code for waiting chip to clean the all pkts(TX & RX) in chip when the driver uses the function named "adjust link". This patch cleans the pkts as follows: 1) close rx of chip,

Urgent,

2018-08-26 Thread Juliet Muhammad
i have been trying to contact you

Re: [PATCH] net: dsa: Drop GPIO includes

2018-08-26 Thread Andrew Lunn
On Mon, Aug 27, 2018 at 12:20:11AM +0200, Linus Walleij wrote: > Commit 52638f71fcff ("dsa: Move gpio reset into switch driver") > moved the GPIO handling into the switch drivers but forgot > to remove the GPIO header includes. > > Signed-off-by: Linus Walleij Reviewed-by: Andrew Lunn

[PATCH] net: dsa: Drop GPIO includes

2018-08-26 Thread Linus Walleij
Commit 52638f71fcff ("dsa: Move gpio reset into switch driver") moved the GPIO handling into the switch drivers but forgot to remove the GPIO header includes. Signed-off-by: Linus Walleij --- net/dsa/dsa.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Stephen Hemminger
On Sun, 26 Aug 2018 15:20:24 -0400 (EDT) "Robert P. J. Day" wrote: > On Sun, 26 Aug 2018, Andrew Lunn wrote: > > > > i ask since, in my testing, when the interface should have been > > > up, the attribute file "operstate" for that interface showed > > > "unknown", and i wondered how worried i

Re: followup: what's responsible for setting netdev->operstate to IF_OPER_DOWN?

2018-08-26 Thread Stephen Hemminger
On Sun, 26 Aug 2018 11:14:33 -0400 (EDT) "Robert P. J. Day" wrote: > apologies for the constant pleas for assistance, but i think i'm > zeroing in on the problem that started all this. recap: custom > FPGA-based linux box with multiple ports, where the current symptom is > that there is no

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Robert P. J. Day
On Sun, 26 Aug 2018, Andrew Lunn wrote: > On Sun, Aug 26, 2018 at 03:20:24PM -0400, Robert P. J. Day wrote: > > On Sun, 26 Aug 2018, Andrew Lunn wrote: > > > > > > i ask since, in my testing, when the interface should have been > > > > up, the attribute file "operstate" for that interface

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Andrew Lunn
On Sun, Aug 26, 2018 at 03:20:24PM -0400, Robert P. J. Day wrote: > On Sun, 26 Aug 2018, Andrew Lunn wrote: > > > > i ask since, in my testing, when the interface should have been > > > up, the attribute file "operstate" for that interface showed > > > "unknown", and i wondered how worried i

Re: followup: what's responsible for setting netdev->operstate to IF_OPER_DOWN?

2018-08-26 Thread Robert P. J. Day
On Sun, 26 Aug 2018, Andrew Lunn wrote: > On Sun, Aug 26, 2018 at 11:14:33AM -0400, Robert P. J. Day wrote: > > > > apologies for the constant pleas for assistance, but i think i'm > > zeroing in on the problem that started all this. recap: custom > > FPGA-based linux box with multiple ports,

Re: followup: what's responsible for setting netdev->operstate to IF_OPER_DOWN?

2018-08-26 Thread Andrew Lunn
On Sun, Aug 26, 2018 at 11:14:33AM -0400, Robert P. J. Day wrote: > > apologies for the constant pleas for assistance, but i think i'm > zeroing in on the problem that started all this. recap: custom > FPGA-based linux box with multiple ports, where the current symptom is > that there is no

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Robert P. J. Day
On Sun, 26 Aug 2018, Andrew Lunn wrote: > > i ask since, in my testing, when the interface should have been > > up, the attribute file "operstate" for that interface showed > > "unknown", and i wondered how worried i should be about that. > > Hi Robert > > You should probably post the driver

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Andrew Lunn
> i ask since, in my testing, when the interface should have been up, > the attribute file "operstate" for that interface showed "unknown", > and i wondered how worried i should be about that. Hi Robert You should probably post the driver for review. A well written driver should not even need

Re: broken behaviour of TC filter delete

2018-08-26 Thread Jamal Hadi Salim
On 2018-08-25 9:02 a.m., Jiri Pirko wrote: Fri, Aug 24, 2018 at 08:11:07PM CEST, xiyou.wangc...@gmail.com wrote: ENOENT seems to be more logical to return when there's no more filter to delete. Yeah, at least we should keep ENOENT for compatibility. The bug here is chain 0 is gone after the

bpfilter causes a leftover kernel process

2018-08-26 Thread Olivier Brunel
Hi, (Please cc me as I'm not subscribed to the list, thanks.) I'm running an Arch Linux x86_64 system, and recently updated to a 3.18 kernel, which led me to encounter what I believe to be a kernel bug related to the bpfilter framework. What happens is that upon boot, there's a "leftover kernel

followup: what's responsible for setting netdev->operstate to IF_OPER_DOWN?

2018-08-26 Thread Robert P. J. Day
apologies for the constant pleas for assistance, but i think i'm zeroing in on the problem that started all this. recap: custom FPGA-based linux box with multiple ports, where the current symptom is that there is no userspace notification when someone simply unplugs one of the ports

[PATCH] r8169: set RxConfig after tx/rx is enabled for RTL8169sb/8110sb devices

2018-08-26 Thread Azat Khuzhin
I have two Ethernet adapters: r8169 :03:01.0 eth0: RTL8169sb/8110sb, 00:14:d1:14:2d:49, XID 1000, IRQ 18 r8169 :01:00.0 eth0: RTL8168e/8111e, 64:66:b3:11:14:5d, XID 2c20, IRQ 30 And after upgrading from linux 4.15 [1] to linux 4.18+ [2] RTL8169sb failed to receive any

Re: [PATCH net] net: sungem: fix rx checksum support

2018-08-26 Thread mroos
> BTW, removing the FCS also means GRO is going to work, finally on this NIC ;) > > GRO does not like packets with padding. As a follow-up, I am seeing hw csum failures on Sun V440 that has onboard Sun Cassini with sungem driver. First tested version was 4.18 (it happened there once) and now

confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Robert P. J. Day
more annoying pedantry ... from include/uapi/linux/if.h: * @IFF_RUNNING: interface RFC2863 OPER_UP. Volatile. however, both the code in net/core/dev.c: /** * netif_oper_up - test if device is operational * @dev: network device * * Check if carrier is operational */ static

want to clarify understanding of IFF_{UP,RUNNING} and "volatile"

2018-08-26 Thread Robert P. J. Day
if you can tolerate another question on the topic, based on an earlier post by stephen hemminger, i wrote a userspace program that opened a netlink socket to track the status changes for an interface, and i just want to clarify how the up/running status of an interface is determined, as i