Re: [Patch net-nnext] net_sched: add missing tcf_lock for act_connmark

2018-08-31 Thread David Miller
From: Cong Wang Date: Wed, 29 Aug 2018 10:15:36 -0700 > According to the new locking rule, we have to take tcf_lock > for both ->init() and ->dump(), as RTNL will be removed. > However, it is missing for act_connmark. > > Cc: Vlad Buslov > Signed-off-by: Cong Wang Applied.

Re: [Patch net-nnext] Revert "net: sched: act: add extack for lookup callback"

2018-08-31 Thread David Miller
From: Cong Wang Date: Wed, 29 Aug 2018 10:15:35 -0700 > This reverts commit 331a9295de23 ("net: sched: act: add extack for lookup > callback"). > > This extack is never used after 6 months... In fact, it can be just > set in the caller, right after ->lookup(). > > Cc: Alexander Aring >

[PATCH net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-08-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] There should check the validity of 'slave_dev'. Fixes:

Re: [PATCH net-next] failover: remove set but not used variable 'primary_dev'

2018-08-31 Thread YueHaibing
On 2018/9/1 0:39, Samudrala, Sridhar wrote: > On 8/30/2018 8:46 PM, YueHaibing wrote: >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/net_failover.c: In function 'net_failover_slave_unregister': >> drivers/net/net_failover.c:598:35: warning: >> variable 'primary_dev' set

Re: [PATCH net-next 0/5] rtnetlink: add IFA_IF_NETNSID for RTM_GETADDR

2018-08-31 Thread Christian Brauner
On Thu, Aug 30, 2018 at 04:45:45PM +0200, Christian Brauner wrote: > On Thu, Aug 30, 2018 at 11:49:31AM +0300, Kirill Tkhai wrote: > > On 29.08.2018 21:13, Christian Brauner wrote: > > > Hi Kirill, > > > > > > Thanks for the question! > > > > > > On Wed, Aug 29, 2018 at 11:30:37AM +0300, Kirill

Re: pull-request: bpf-next 2018-09-01

2018-08-31 Thread David Miller
From: Daniel Borkmann Date: Sat, 1 Sep 2018 02:05:06 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: > > 1) Add AF_XDP zero-copy support for i40e driver (!), from Björn and Magnus. W00t! > 2) BPF verifier improvements by giving

[PATCH net-next] liquidio: Added delayed work for periodically updating the link statistics.

2018-08-31 Thread Felix Manlunas
From: Pradeep Nalla Signed-off-by: Pradeep Nalla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 24 +++--- drivers/net/ethernet/cavium/liquidio/lio_main.c| 9 +++- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 8 +++-

[PATCH RFC net-next 16/18] net/ipv6: Allow routes to use nexthop objects

2018-08-31 Thread dsahern
From: David Ahern Allow users to specify a nexthop id to use with a route. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 4 +++ include/net/nexthop.h | 3 ++ net/ipv4/nexthop.c| 5 +++ net/ipv6/addrconf.c | 3 ++ net/ipv6/ip6_fib.c| 17 --- net/ipv6/ndisc.c

[PATCH RFC net-next 11/18] net: Initial nexthop code

2018-08-31 Thread dsahern
From: David Ahern Initial import of nexthop code. - Add new RTM commands for nexthop objects. - Add new uapi attributes for creating nexthops. Attributes are similar to the current nexthop attributes for routes. - Add basic helpers for ipv4 and ipv6 references to nexthop data Similar to

[PATCH RFC net-next 08/18] net/ipv4: Move device validation to helper

2018-08-31 Thread dsahern
From: David Ahern Move the device matching check in __fib_validate_source to a helper. Code move only; no functional change intended. Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-)

[PATCH RFC net-next 03/18] net/ipv4: export fib_info_update_nh_saddr

2018-08-31 Thread dsahern
From: David Ahern Add scope as input argument versus relying on fib_info reference in fib_nh and export fib_info_update_nh_saddr. Signed-off-by: David Ahern --- include/net/ip_fib.h | 5 +++-- net/ipv4/fib_semantics.c | 9 - 2 files changed, 7 insertions(+), 7 deletions(-) diff

Re: [PATCH net-next v1] selftests/tls: Add test for recv(PEEK) spanning across multiple records

2018-08-31 Thread David Miller
From: Vakul Garg Date: Wed, 29 Aug 2018 15:30:14 +0530 > Added test case to receive multiple records with a single recvmsg() > operation with a MSG_PEEK set. Applied.

[PATCH RFC net-next 12/18] net/ipv4: Add nexthop helpers for ipv4 integration

2018-08-31 Thread dsahern
From: David Ahern Add nexthop reference to fib_info along with a list_head for tracking the association of nexthop back to the fib_info. Add helpers to take a fib_info and return a fib_nh, a nexthop device and nexthop gateway. Add helper to validate a nexthop works with a fib_info.

[PATCH RFC net-next 10/18] net/ipv6: Make fib6_nh optional at the end of fib6_info

2018-08-31 Thread dsahern
From: David Ahern Move fib6_nh to the end of fib6_info and make an array of size 0. Pass a flag to fib6_info_alloc indicating if the allocation needs to add space for a fib6_nh. The current code path always has a fib6_nh allocated; with nexthop objects they will not. Signed-off-by: David Ahern

[PATCH RFC net-next 07/18] net: ipv4: Add fib_nh to fib_result

2018-08-31 Thread dsahern
From: David Ahern Add nexthop selection to fib_result and update FIB_RES macros to use it. Right now, fib_nh in fib_result will point to a nexthop within a fib_info. Later, fib_nh can point to data with a nexthop. Signed-off-by: David Ahern --- include/net/ip_fib.h | 21

[PATCH RFC net-next 04/18] net/ipv4: export fib_check_nh

2018-08-31 Thread dsahern
From: David Ahern Change fib_check_nh to take net, table and scope as input arguments over struct fib_config and export for use by nexthop code. Signed-off-by: David Ahern --- include/net/ip_fib.h | 2 ++ net/ipv4/fib_semantics.c | 18 +- 2 files changed, 11

[PATCH RFC net-next 17/18] net: Add support for nexthop groups

2018-08-31 Thread dsahern
From: David Ahern Allow the creation of nexthop groups which reference other nexthop objects to create multipath routes. TO-DO: Add mpath support to IPv6 Signed-off-by: David Ahern --- include/net/nexthop.h| 77 +-- net/ipv4/fib_semantics.c | 5 +- net/ipv4/nexthop.c | 511

[PATCH RFC net-next 06/18] net/ipv4: Create init and release helpers for fib_nh

2018-08-31 Thread dsahern
From: David Ahern Consolidate the fib_nh initialization which is duplicated between fib_create_info for single path and fib_get_nhs for multipath. Move the fib_nh cleanup code from free_fib_info_rcu into a new helper, fib_nh_release. Move classid accounting into fib_nh_release which is called

Re: [PATCH net-next v2] net/tls: Add support for async decryption of tls records

2018-08-31 Thread David Miller
From: Vakul Garg Date: Wed, 29 Aug 2018 15:26:55 +0530 > When tls records are decrypted using asynchronous acclerators such as > NXP CAAM engine, the crypto apis return -EINPROGRESS. Presently, on > getting -EINPROGRESS, the tls record processing stops till the time the > crypto accelerator

[PATCH RFC net-next 13/18] net/ipv4: Convert existing use of fib_info to new helpers

2018-08-31 Thread dsahern
From: David Ahern Remove direct accesses to fi->fib_nh in favor of the helpers added in the previous patch. Signed-off-by: David Ahern --- .../net/ethernet/mellanox/mlxsw/spectrum_router.c| 4 +++- drivers/net/ethernet/rocker/rocker_ofdpa.c | 20 ++--

[PATCH RFC net-next 01/18] net: Rename net/nexthop.h net/rtnh.h

2018-08-31 Thread dsahern
From: David Ahern The header contains rtnh_ macros so rename the file accordingly. Allows next patch to use the nexthop.h name. Signed-off-by: David Ahern --- include/net/{nexthop.h => rtnh.h} | 4 ++-- net/core/lwtunnel.c | 2 +- net/decnet/dn_fib.c | 2 +-

[PATCH RFC net-next 09/18] net/ipv6: Create init and release helpers for fib6_nh

2018-08-31 Thread dsahern
From: David Ahern Refactor initialization and cleanup of fib6_nh to helpers similar to what was done for IPv4. Add fib6_nh_init to the ipv6 stubs for use by core code when ipv6 is built as a module. The replace helper is small enough, so make an inline rather than requiring it to go through

[PATCH RFC net-next 02/18] net: ipv4: export fib_good_nh and fib_flush

2018-08-31 Thread dsahern
From: David Ahern Export fib_good_nh for use by the nexthop code when selecting a path within a multipath nexthop. As nexthops are deleted, fib entries referencing it are marked dead. Export fib_flush so those entries can be removed in a timely manner. Signed-off-by: David Ahern ---

[PATCH RFC net-next 05/18] net/ipv4: Define fib_get_nhs when CONFIG_IP_ROUTE_MULTIPATH is disabled

2018-08-31 Thread dsahern
From: David Ahern Define fib_get_nhs to return EINVAL when CONFIG_IP_ROUTE_MULTIPATH is not enabled and remove the ifdef check for CONFIG_IP_ROUTE_MULTIPATH. Signed-off-by: David Ahern --- net/ipv4/fib_semantics.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff

[PATCH RFC net-next 18/18] net/ipv4: Optimization for fib_info lookup

2018-08-31 Thread dsahern
From: David Ahern Be optimistic about re-using a fib_info when nexthop id is given and the route does not use metrics. Avoids a memory allocation which in most cases is expected to be freed anyways. Signed-off-by: David Ahern --- net/ipv4/fib_semantics.c | 48

[PATCH RFC net-next 15/18] net/ipv6: Use helpers to access fib6_nh data

2018-08-31 Thread dsahern
From: David Ahern Similar to ipv4, add helpers for accessing fib6_nh data and convert existing users. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 11 -- include/net/ip6_route.h | 2 ++ include/net/nexthop.h | 40 +++

[PATCH iproute2-next] ip: Add support for nexthop objects

2018-08-31 Thread dsahern
From: David Ahern Signed-off-by: David Ahern --- include/uapi/linux/nexthop.h | 56 include/uapi/linux/rtnetlink.h | 8 + ip/Makefile| 3 +- ip/ip.c| 3 +- ip/ip_common.h | 7 +- ip/ipmonitor.c | 6 +

[PATCH RFC net-next 14/18] net/ipv4: Allow routes to use nexthop objects

2018-08-31 Thread dsahern
From: David Ahern Add new RTA attribute to allow a user to specify a nexthop id to use with a route instead of the current nexthop specification. Signed-off-by: David Ahern --- include/net/ip_fib.h | 1 + include/uapi/linux/rtnetlink.h | 1 + net/ipv4/fib_frontend.c| 7

[PATCH RFC net-next 00/18] net: Improve route scalability via support for nexthop objects

2018-08-31 Thread dsahern
From: David Ahern As mentioned at netconf in Seoul, we would like to introduce nexthops as independent objects from the routes to better align with both routing daemons and hardware and to improve route insertion times into the kernel. This series adds nexthop objects with their own lifecycle.

pull-request: bpf-next 2018-09-01

2018-08-31 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Add AF_XDP zero-copy support for i40e driver (!), from Björn and Magnus. 2) BPF verifier improvements by giving each register its own liveness chain which allows to simplify and

Re: [PATCH bpf-next v2 0/2] xsk: misc code cleanup

2018-08-31 Thread Daniel Borkmann
On 08/31/2018 01:40 PM, Magnus Karlsson wrote: > This patch set cleans up two code style issues with the xsk zero-copy > code. The resulting code is smaller and simpler. > > Changes from v1: > > * Fixed bisecatbility problem reported by Daniel Borkmann by squashing > the two last patches into

Re: [PATCH bpf-next] adding selftest for bpf's (set|get)_sockopt for SAVE_SYN

2018-08-31 Thread Daniel Borkmann
On 08/31/2018 06:43 PM, Nikita V. Shirokov wrote: > adding selftest for feature, introduced in > commit 9452048c79404 ("bpf: add TCP_SAVE_SYN/TCP_SAVED_SYN options for > bpf_(set|get)sockopt") > > Signed-off-by: Nikita V. Shirokov Applied to bpf-next. Nikita, please also add a proper subsystem

[RFC PATCH bpf-next v2 3/4] Sync uapi/bpf.h to tools/include

2018-08-31 Thread Mauricio Vasquez B
Sync both files. Signed-off-by: Mauricio Vasquez B --- tools/include/uapi/linux/bpf.h | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 66917a4eba27..0a5b904ba42f

[RFC PATCH bpf-next v2 4/4] selftests/bpf: add test cases for queue and stack maps

2018-08-31 Thread Mauricio Vasquez B
Two types of tests are done: - test_maps: only userspace api. - test_progs: userspace api and ebpf helpers. Signed-off-by: Mauricio Vasquez B --- tools/lib/bpf/bpf.c| 12 ++ tools/lib/bpf/bpf.h|1

[PATCH net] bpf: Fix bpf_msg_pull_data()

2018-08-31 Thread Tushar Dave
Helper bpf_msg_pull_data() mistakenly reuses variable 'offset' while linearizing multiple scatterlist elements. Variable 'offset' is used to find first starting scatterlist element i.e. msg->data = sg_virt([first_sg]) + start - offset" Use different variable name while linearizing multiple

Re: [PATCH net] ebpf: fix bpf_msg_pull_data

2018-08-31 Thread Tushar Dave
On 08/31/2018 05:15 AM, Daniel Borkmann wrote: On 08/31/2018 10:37 AM, Tushar Dave wrote: On 08/30/2018 12:20 AM, Daniel Borkmann wrote: On 08/30/2018 02:21 AM, Tushar Dave wrote: On 08/29/2018 05:07 PM, Tushar Dave wrote: While doing some preliminary testing it is found that bpf helper

[RFC PATCH bpf-next v2 1/4] bpf: add bpf queue and stack maps

2018-08-31 Thread Mauricio Vasquez B
Implement two new kind of maps that support the peek, push and pop operations. A use case for this is to keep track of a pool of elements, like network ports in a SNAT. Signed-off-by: Mauricio Vasquez B --- include/linux/bpf.h |8 + include/linux/bpf_types.h |2

[RFC PATCH bpf-next v2 2/4] bpf: restrict use of peek/push/pop

2018-08-31 Thread Mauricio Vasquez B
Restrict the use of peek, push and pop helpers only to queue and stack maps. Signed-off-by: Mauricio Vasquez B --- kernel/bpf/verifier.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 5bd67feb2f07..9e177ff4a3b9 100644

[RFC PATCH bpf-next v2 0/4] Implement bpf queue/stack maps

2018-08-31 Thread Mauricio Vasquez B
In some applications this is needed have a pool of free elements, like for example the list of free L4 ports in a SNAT. None of the current maps allow to do it as it is not possibleto get an any element without having they key it is associated to. This patchset implements two new kind of eBPF

Re: [net-next v2 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2018-08-30

2018-08-31 Thread David Miller
From: Jeff Kirsher Date: Thu, 30 Aug 2018 14:11:32 -0700 > This series contains updates to i40e, i40evf and virtchnl. Pulled, thanks Jeff.

Re: [PATCH v2 1/2] IB/ipoib: Use dev_port to expose network interface port numbers

2018-08-31 Thread Doug Ledford
On Fri, 2018-08-31 at 11:57 +0300, Arseny Maslennikov wrote: > On Thu, Aug 30, 2018 at 04:17:58PM -0400, Doug Ledford wrote: > > On Thu, 2018-08-30 at 21:22 +0300, Arseny Maslennikov wrote: > > > Some InfiniBand network devices have multiple ports on the same PCI > > > function. This initializes

Re: [PATCH v2 net-next] liquidio: remove set but not used variable 'irh'

2018-08-31 Thread Felix Manlunas
On Fri, Aug 31, 2018 at 12:03:56PM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cavium/liquidio/request_manager.c: In function > 'lio_process_iq_request_list': > drivers/net/ethernet/cavium/liquidio/request_manager.c:383:27: warning: >

Re: phys_port_id in switchdev mode?

2018-08-31 Thread Marcelo Ricardo Leitner
On Tue, Aug 28, 2018 at 08:43:51PM +0200, Jakub Kicinski wrote: > Ugh, CC: netdev.. > > On Tue, 28 Aug 2018 20:05:39 +0200, Jakub Kicinski wrote: > > Hi! > > > > I wonder if we can use phys_port_id in switchdev to group together > > interfaces of a single PCI PF? Here is the problem: On

[PATCH] cxgb4: fix abort_req_rss6 struct

2018-08-31 Thread Steve Wise
Remove the incorrect WR_HDR field which can cause a misinterpretation of this CPL by ULDs. Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues") Signed-off-by: Steve Wise --- Dave, Doug, and Jason, I request this merge through the rdma repo since the only user of this

Re: [bpf-next PATCH 3/3] xdp: split code for map vs non-map redirect

2018-08-31 Thread Daniel Borkmann
On 08/31/2018 05:26 PM, Jesper Dangaard Brouer wrote: > The compiler does an efficient job of inlining static C functions. > Perf top clearly shows that almost everything gets inlined into the > function call xdp_do_redirect. > > The function xdp_do_redirect end-up containing and interleaving the

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

2018-08-31 Thread Lorenzo Bianconi
> On 8/31/18 10:19 AM, Lorenzo Bianconi wrote: > >> On 8/31/18 5:43 AM, Lorenzo Bianconi wrote: > >>> When moving a veth device to another namespace, userspace receives a > >>> RTM_DELLINK message indicating the device has been removed from current > >>> netns. However, the other peer does not

[PATCH bpf-next] adding selftest for bpf's (set|get)_sockopt for SAVE_SYN

2018-08-31 Thread Nikita V. Shirokov
adding selftest for feature, introduced in commit 9452048c79404 ("bpf: add TCP_SAVE_SYN/TCP_SAVED_SYN options for bpf_(set|get)sockopt") Signed-off-by: Nikita V. Shirokov --- .../testing/selftests/bpf/test_tcpbpf_kern.c | 38 +-- .../testing/selftests/bpf/test_tcpbpf_user.c |

Re: [PATCH net-next] failover: remove set but not used variable 'primary_dev'

2018-08-31 Thread Samudrala, Sridhar
On 8/30/2018 8:46 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] Actually this gcc

Re: [PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

2018-08-31 Thread Roopa Prabhu
On Fri, Aug 31, 2018 at 4:20 AM, Patrick Ruddy wrote: > Some userspace applications need to know about IGMP joins from the kernel > for 2 reasons > 1. To allow the programming of multicast MAC filters in hardware > 2. To form a multicast FORUS list for non link-local multicast >groups to be

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

2018-08-31 Thread David Ahern
On 8/31/18 10:19 AM, Lorenzo Bianconi wrote: >> On 8/31/18 5:43 AM, Lorenzo Bianconi wrote: >>> When moving a veth device to another namespace, userspace receives a >>> RTM_DELLINK message indicating the device has been removed from current >>> netns. However, the other peer does not receive a

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

2018-08-31 Thread Lorenzo Bianconi
> On 8/31/18 5:43 AM, Lorenzo Bianconi wrote: > > When moving a veth device to another namespace, userspace receives a > > RTM_DELLINK message indicating the device has been removed from current > > netns. However, the other peer does not receive a netlink event > > containing new values for

Re: [RFC PATCH v2 bpf-next 0/2] verifier liveness simplification

2018-08-31 Thread Edward Cree
On 30/08/18 03:18, Alexei Starovoitov wrote: > I think it's a better base to continue debugging. > In particular: > 1. we have instability issue in the verifier. > from time to time the verifier goes to process extra 7 instructions on one > of the cilium tests. This was happening before and

[bpf-next PATCH 3/3] xdp: split code for map vs non-map redirect

2018-08-31 Thread Jesper Dangaard Brouer
The compiler does an efficient job of inlining static C functions. Perf top clearly shows that almost everything gets inlined into the function call xdp_do_redirect. The function xdp_do_redirect end-up containing and interleaving the map and non-map redirect code. This is sub-optimal, as it

[bpf-next PATCH 2/3] xdp: explicit inline __xdp_map_lookup_elem

2018-08-31 Thread Jesper Dangaard Brouer
The compiler chooses to not-inline the function __xdp_map_lookup_elem, because it can see that it is used by both Generic-XDP and native-XDP do redirect calls (xdp_do_generic_redirect_map and xdp_do_redirect_map). The compiler cannot know that this is a bad choice, as it cannot know that a net

[bpf-next PATCH 1/3] xdp: unlikely instrumentation for xdp map redirect

2018-08-31 Thread Jesper Dangaard Brouer
Notice the compiler generated ASM code layout was suboptimal. It assumed map enqueue errors as the likely case, which is shouldn't. It assumed that xdp_do_flush_map() was a likely case, due to maps changing between packets, which should be very unlikely. Signed-off-by: Jesper Dangaard Brouer

[bpf-next PATCH 0/3] XDP micro optimizations for redirect

2018-08-31 Thread Jesper Dangaard Brouer
This patchset contains XDP micro optimizations for the redirect core. These are not functional changes. The optimizations revolve around getting the compiler to layout the code in a way that reflect how XDP redirect is used. Today the compiler chooses to inline and uninline (static C functions)

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

2018-08-31 Thread David Ahern
On 8/31/18 5:43 AM, Lorenzo Bianconi wrote: > When moving a veth device to another namespace, userspace receives a > RTM_DELLINK message indicating the device has been removed from current > netns. However, the other peer does not receive a netlink event > containing new values for

Re: [PATCH RFC net-next 00/11] udp gso

2018-08-31 Thread Willem de Bruijn
On Fri, Aug 31, 2018 at 9:44 AM Paolo Abeni wrote: > > On Fri, 2018-08-31 at 09:08 -0400, Willem de Bruijn wrote: > > On Fri, Aug 31, 2018 at 5:09 AM Paolo Abeni wrote: > > > > > > Hi, > > > > > > On Tue, 2018-04-17 at 17:07 -0400, Willem de Bruijn wrote: > > > > That said, for negotiated flows

IPv6 neighbor discovery issues on 4.18

2018-08-31 Thread Brian Rak
We've upgraded a few machines to a 4.18.3 kernel and we're running into weird IPv6 neighbor discovery issues.  Basically, the machines stop responding to inbound IPv6 neighbor solicitation requests, which very quickly breaks all IPv6 connectivity. It seems like the routing table gets

Re: [PATCH RFC net-next 00/11] udp gso

2018-08-31 Thread Paolo Abeni
On Fri, 2018-08-31 at 09:08 -0400, Willem de Bruijn wrote: > On Fri, Aug 31, 2018 at 5:09 AM Paolo Abeni wrote: > > > > Hi, > > > > On Tue, 2018-04-17 at 17:07 -0400, Willem de Bruijn wrote: > > > That said, for negotiated flows an inverse GRO feature could > > > conceivably be implemented to

Re: [PATCH net] ipv6: don't get lwtstate twice in ip6_rt_copy_init()

2018-08-31 Thread Alexey Kodanev
On 30.08.2018 19:10, David Ahern wrote: > On 8/30/18 10:11 AM, Alexey Kodanev wrote: ... >> unreferenced object 0x880b6aaa14e0 (size 64): >> comm "ip", pid 10577, jiffies 4295149341 (age 1273.903s) >> hex dump (first 32 bytes): >> 01 00 04 00 04 00 00 00 10 00 00 00 00 00 00 00

Re: [PATCH RFC net-next 00/11] udp gso

2018-08-31 Thread Willem de Bruijn
On Fri, Aug 31, 2018 at 5:09 AM Paolo Abeni wrote: > > Hi, > > On Tue, 2018-04-17 at 17:07 -0400, Willem de Bruijn wrote: > > That said, for negotiated flows an inverse GRO feature could > > conceivably be implemented to reduce rx stack traversal, too. > > Though due to interleaving of packets on

[PATCH net-next] cxgb4: collect hardware queue descriptors

2018-08-31 Thread Rahul Lakkireddy
Collect descriptors of all ULD and LLD hardware queues managed by LLD. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 42 +++ drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 3 +-

Re: [PATCH net] ebpf: fix bpf_msg_pull_data

2018-08-31 Thread Daniel Borkmann
On 08/31/2018 10:37 AM, Tushar Dave wrote: > On 08/30/2018 12:20 AM, Daniel Borkmann wrote: >> On 08/30/2018 02:21 AM, Tushar Dave wrote: >>> On 08/29/2018 05:07 PM, Tushar Dave wrote: While doing some preliminary testing it is found that bpf helper bpf_msg_pull_data does not calculate

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_transport_get_next

2018-08-31 Thread Neil Horman
On Fri, Aug 31, 2018 at 03:09:05PM +0800, Xin Long wrote: > On Wed, Aug 29, 2018 at 7:36 PM Neil Horman wrote: > > > > On Wed, Aug 29, 2018 at 12:08:40AM +0800, Xin Long wrote: > > > On Mon, Aug 27, 2018 at 9:08 PM Neil Horman wrote: > > > > > > > > On Mon, Aug 27, 2018 at 06:38:31PM +0800, Xin

[PATCH v2 net-next] liquidio: remove set but not used variable 'irh'

2018-08-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/cavium/liquidio/request_manager.c: In function 'lio_process_iq_request_list': drivers/net/ethernet/cavium/liquidio/request_manager.c:383:27: warning: variable 'irh' set but not used [-Wunused-but-set-variable] Signed-off-by:

Re: [PATCH net-next] liquidio: cHECK-remove set but not used variable 'irh'

2018-08-31 Thread YueHaibing
sorry, patch description is messy, will fix it in V2. On 2018/8/31 19:53, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cavium/liquidio/request_manager.c: In function > 'lio_process_iq_request_list': >

[PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

2018-08-31 Thread Lorenzo Bianconi
When moving a veth device to another namespace, userspace receives a RTM_DELLINK message indicating the device has been removed from current netns. However, the other peer does not receive a netlink event containing new values for IFLA_LINK_NETNSID and IFLA_LINK veth attributes. Fix that behaviour

[PATCH net-next] liquidio: cHECK-remove set but not used variable 'irh'

2018-08-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/cavium/liquidio/request_manager.c: In function 'lio_process_iq_request_list': drivers/net/ethernet/cavium/liquidio/request_manager.c:383:27: warning: variable 'irh' set but not used [-Wunused-but-set-variable] Signed-off-by:

[PATCH bpf-next v2 2/2] xsk: i40e: get rid of useless struct xdp_umem_props

2018-08-31 Thread Magnus Karlsson
This commit gets rid of the structure xdp_umem_props. It was there to be able to break a dependency at one point, but this is no longer needed. The values in the struct are instead stored directly in the xdp_umem structure. This simplifies the xsk code as well as af_xdp zero-copy drivers and as a

[PATCH bpf-next v2 1/2] i40e: fix possible compiler warning in xsk TX path

2018-08-31 Thread Magnus Karlsson
With certain gcc versions, it was possible to get the warning "'tx_desc' may be used uninitialized in this function" for the i40e_xmit_zc. This was not possible, however this commit simplifies the code path so that this warning is no longer emitted. Signed-off-by: Magnus Karlsson ---

[PATCH bpf-next v2 0/2] xsk: misc code cleanup

2018-08-31 Thread Magnus Karlsson
This patch set cleans up two code style issues with the xsk zero-copy code. The resulting code is smaller and simpler. Changes from v1: * Fixed bisecatbility problem reported by Daniel Borkmann by squashing the two last patches into one. Patch 1: Removes a potential compiler warning reported

[PATCH v2] xfrm6: call kfree_skb when skb is toobig

2018-08-31 Thread Thadeu Lima de Souza Cascardo
After commit d6990976af7c5d8f55903bfb4289b6fb030bf754 ("vti6: fix PMTU caching and reporting on xmit"), some too big skbs might be potentially passed down to __xfrm6_output, causing it to fail to transmit but not free the skb, causing a leak of skb, and consequentially a leak of dst references.

[PATCH RFC] net/mlx5_en: switch to Toeplitz RSS hash by default

2018-08-31 Thread Konstantin Khlebnikov
XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits. It seems not enough for RFS. All other drivers use toeplitz. Driver mlx4_en uses Toeplitz by default and warns if hash XOR is used together with NETIF_F_RXHASH (enabled by default too): "Enabling both XOR Hash function and RX Hashing can

[PATCH net-next v2 2/2] netlink: ipv6 MLD join notifications

2018-08-31 Thread Patrick Ruddy
Some userspace applications need to know about MLD joins from the kernel for 2 reasons: 1. To allow the programming of multicast MAC filters in hardware 2. To form a multicast FORUS list for non link-local multicast groups to be sent to the kernel and from there to the interested party. (1)

[PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

2018-08-31 Thread Patrick Ruddy
Some userspace applications need to know about IGMP joins from the kernel for 2 reasons 1. To allow the programming of multicast MAC filters in hardware 2. To form a multicast FORUS list for non link-local multicast groups to be sent to the kernel and from there to the interested party. (1)

Re: [PATCH bpf-next] samples/bpf: xdpsock, minor fixes

2018-08-31 Thread Daniel Borkmann
On 08/31/2018 03:00 AM, Prashant Bhole wrote: > - xsks_map size was fixed to 4, changed it MAX_SOCKS > - Remove redundant definition of MAX_SOCKS in xdpsock_user.c > - In dump_stats(), add NULL check for xsks[i] > > Signed-off-by: Prashant Bhole Applied, thanks Prashant!

Re: [PATCH bpf-next] xsk: remove unnecessary assignment

2018-08-31 Thread Daniel Borkmann
On 08/31/2018 02:59 AM, Prashant Bhole wrote: > Since xdp_umem_query() was added one assignment of bpf.command was > missed from cleanup. Removing the assignment statement. > > Fixes: 84c6b86875e01a0 ("xsk: don't allow umem replace at stack level") > Signed-off-by: Prashant Bhole Applied,

[PATCH net-next 1/1] qed: Lower the severity of a dcbx log message.

2018-08-31 Thread Sudarsana Reddy Kalluru
Driver displays an error message for each unrecognized dcbx TLV that's received from the peer or configured on the device. It is observed that syslog will be flooded with such messages in certain scenarios e.g., frequent link-flaps/lldp-transactions. Changing the severity of this message to

Re: [PATCH bpf-next 3/3] i40e: adapt driver to new xdp_umem structure

2018-08-31 Thread Daniel Borkmann
On 08/30/2018 03:56 PM, Magnus Karlsson wrote: > The struct xdp_umem_props was removed in the xsk code and this commit > adapts the i40e af_xdp zero-copy driver code to the new xdp_umem > structure. > > Signed-off-by: Magnus Karlsson > --- > drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 ++-- >

Re: [PATCH RFC net-next 00/11] udp gso

2018-08-31 Thread Eric Dumazet
On 08/31/2018 02:09 AM, Paolo Abeni wrote: > I hope quic can leverage such scenario, but I > really know nothing about the protocol. > Most QUIC receivers are mobile phones, laptops, with wifi without GRO anyway... Even if they had GRO, the inter-packet delay would be too high for GRO to be

Re: [PATCH RFC net-next 00/11] udp gso

2018-08-31 Thread Paolo Abeni
Hi, On Tue, 2018-04-17 at 17:07 -0400, Willem de Bruijn wrote: > That said, for negotiated flows an inverse GRO feature could > conceivably be implemented to reduce rx stack traversal, too. > Though due to interleaving of packets on the wire, it aggregation > would be best effort, similar to TCP

Re: [PATCH v2 1/2] IB/ipoib: Use dev_port to expose network interface port numbers

2018-08-31 Thread Arseny Maslennikov
On Thu, Aug 30, 2018 at 04:17:58PM -0400, Doug Ledford wrote: > On Thu, 2018-08-30 at 21:22 +0300, Arseny Maslennikov wrote: > > Some InfiniBand network devices have multiple ports on the same PCI > > function. This initializes the `dev_port' sysfs field of those > > network interfaces with their

[PATCH net] ip6_tunnel: respect ttl inherit for ip6tnl

2018-08-31 Thread Hangbin Liu
man ip-tunnel ttl section says: 0 is a special value meaning that packets inherit the TTL value. IPv4 tunnel respect this in ip_tunnel_xmit(), but IPv6 tunnel has not implement it yet. To make IPv6 behave consistently with IP tunnel, add ipv6 tunnel inherit support. Signed-off-by: Hangbin Liu

Re: [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types

2018-08-31 Thread Jakub Kicinski
On Fri, 31 Aug 2018 15:32:42 +0900, Prashant Bhole wrote: > When listed all maps, bpftool currently shows (null) for xskmap. > Added xskmap type in map_type_name[] to show correct type. > > Signed-off-by: Prashant Bhole Acked-by: Jakub Kicinski Thank you! I feel tempted to suggest

Re: [PATCH net] ebpf: fix bpf_msg_pull_data

2018-08-31 Thread Tushar Dave
On 08/30/2018 12:20 AM, Daniel Borkmann wrote: On 08/30/2018 02:21 AM, Tushar Dave wrote: On 08/29/2018 05:07 PM, Tushar Dave wrote: While doing some preliminary testing it is found that bpf helper bpf_msg_pull_data does not calculate the data and data_end offset correctly. Fix it! Fixes:

Re: [RFC] net: xsk: add a simple buffer reuse queue

2018-08-31 Thread Björn Töpel
On 2018-08-29 21:19, Jakub Kicinski wrote: XSK UMEM is strongly single producer single consumer so reuse of frames is challenging. Add a simple "stash" of FILL packets to reuse for drivers to optionally make use of. This is useful when driver has to free (ndo_stop) or resize a ring with an

Re: [PATCH bpf-next 08/11] i40e: add AF_XDP zero-copy Rx support

2018-08-31 Thread Jakub Kicinski
On Thu, 30 Aug 2018 14:06:24 +0200, Björn Töpel wrote: > On 2018-08-29 21:14, Jakub Kicinski wrote: > > On Tue, 28 Aug 2018 14:44:32 +0200, Björn Töpel wrote: > >> From: Björn Töpel > >> > >> This patch adds zero-copy Rx support for AF_XDP sockets. Instead of > >> allocating buffers of

Re: [PATCH bpf-next] samples/bpf: xdpsock, minor fixes

2018-08-31 Thread Björn Töpel
Den fre 31 aug. 2018 kl 03:04 skrev Prashant Bhole : > > - xsks_map size was fixed to 4, changed it MAX_SOCKS > - Remove redundant definition of MAX_SOCKS in xdpsock_user.c > - In dump_stats(), add NULL check for xsks[i] > Thanks for the cleanup! Acked-by: Björn Töpel > Signed-off-by: Prashant

Re: [PATCH bpf-next] xsk: remove unnecessary assignment

2018-08-31 Thread Björn Töpel
Den fre 31 aug. 2018 kl 03:02 skrev Prashant Bhole : > > Since xdp_umem_query() was added one assignment of bpf.command was > missed from cleanup. Removing the assignment statement. > Good catch! Acked-by: Björn Töpel > Fixes: 84c6b86875e01a0 ("xsk: don't allow umem replace at stack level") >

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_transport_get_next

2018-08-31 Thread Xin Long
On Wed, Aug 29, 2018 at 7:36 PM Neil Horman wrote: > > On Wed, Aug 29, 2018 at 12:08:40AM +0800, Xin Long wrote: > > On Mon, Aug 27, 2018 at 9:08 PM Neil Horman wrote: > > > > > > On Mon, Aug 27, 2018 at 06:38:31PM +0800, Xin Long wrote: > > > > As Marcelo noticed, in sctp_transport_get_next, it

Re: kernels > v4.12 oops/crash with ipsec-traffic: bisected to b838d5e1c5b6e57b10ec8af2268824041e3ea911: ipv4: mark DST_NOGC and remove the operation of dst_free()

2018-08-31 Thread Steffen Klassert
On Thu, Aug 30, 2018 at 08:53:50PM +0200, Wolfgang Walter wrote: > Hello, > > kernels > 4.12 do not work on one of our main routers. They crash as soon > as ipsec-tunnels are configured and ipsec-traffic actually flows. Can you please send the backtrace of this crash? Thanks!

Re: [PATCH 1/2] xfrm6: call kfree_skb when skb is toobig

2018-08-31 Thread Steffen Klassert
On Thu, Aug 30, 2018 at 03:23:11PM +0200, Sabrina Dubroca wrote: > 2018-08-30, 09:58:16 -0300, Thadeu Lima de Souza Cascardo wrote: > > After commit d6990976af7c5d8f55903bfb4289b6fb030bf754 ("vti6: fix PMTU > > caching > > and reporting on xmit"), some too big skbs might be potentially passed

Re: [PATCH 2/2] vti6: do not check for ignore_df in order to update pmtu

2018-08-31 Thread Steffen Klassert
On Thu, Aug 30, 2018 at 09:58:17AM -0300, Thadeu Lima de Souza Cascardo wrote: > Before commit d6990976af7c5d8f55903bfb4289b6fb030bf754 ("vti6: fix PMTU > caching > and reporting on xmit"), skb was scrubbed before checking for ignore_df. The > scrubbing meant ignore_df was false, making the check

[PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types

2018-08-31 Thread Prashant Bhole
When listed all maps, bpftool currently shows (null) for xskmap. Added xskmap type in map_type_name[] to show correct type. Signed-off-by: Prashant Bhole --- tools/bpf/bpftool/map.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c index