Re: [PATCH RFC net-next] net: Poptrie based routing table lookup

2018-09-04 Thread Jesper Dangaard Brouer
On Tue, 4 Sep 2018 16:34:36 -0400 "Md. Islam" wrote: > On Tue, Sep 4, 2018 at 12:14 PM, Md. Islam wrote: > > > > On Tue, Sep 4, 2018, 6:53 AM Jesper Dangaard Brouer > > wrote: > >> > >> Hi Md. Islam, > >> > >> People will start to ignore you, when you don't interact appropriately > >> with

[GIT] net merged into net-next

2018-09-04 Thread David Miller
Just FYI...

Re: [PATCH rdma-next v1 12/15] RDMA/mlx5: Add a new flow action verb - modify header

2018-09-04 Thread Leon Romanovsky
On Tue, Sep 04, 2018 at 03:58:23PM -0600, Jason Gunthorpe wrote: > On Tue, Aug 28, 2018 at 02:18:51PM +0300, Leon Romanovsky wrote: > > > +static int UVERBS_HANDLER(MLX5_IB_METHOD_FLOW_ACTION_CREATE_MODIFY_HEADER)( > > + struct ib_uverbs_file *file, > > + struct uverbs_attr_bundle *attrs) > >

Re: [PATCH rdma-next v1 00/15] Flow actions to mutate packets

2018-09-04 Thread Leon Romanovsky
On Tue, Sep 04, 2018 at 04:12:05PM -0600, Jason Gunthorpe wrote: > On Tue, Aug 28, 2018 at 02:18:39PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > >From Mark, > > > > This series exposes the ability to create flow actions which can > > mutate packet headers. We do that by

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-09-04 Thread Leon Romanovsky
On Tue, Sep 04, 2018 at 04:02:42PM -0600, Jason Gunthorpe wrote: > On Tue, Aug 28, 2018 at 02:18:44PM +0300, Leon Romanovsky wrote: > > From: Mark Bloch > > > > Today we are able to attach encap and decap actions only to the FDB. In > > preparation to enable those actions on the NIC flow tables,

[PATCH iproute2] bridge/mdb: fix missing new line when show bridge mdb

2018-09-04 Thread Hangbin Liu
The bridge mdb show is broken on current iproute2. e.g. ]# bridge mdb show 34: br0 veth0_br 224.1.1.2 temp 34: br0 veth0_br 224.1.1.1 temp After fix: ]# bridge mdb show 34: br0 veth0_br 224.1.1.2 temp 34: br0 veth0_br 224.1.1.1 temp Reported-by: Ying Xu Fixes: c7c1a1ef51aea

Re: [PATCH bpf-next] bpf/verifier: properly clear union members after a ctx read

2018-09-04 Thread Alexei Starovoitov
On Tue, Sep 04, 2018 at 03:19:52PM +0100, Edward Cree wrote: > In check_mem_access(), for the PTR_TO_CTX case, after check_ctx_access() > has supplied a reg_type, the other members of the register state are set > appropriately. Previously reg.range was set to 0, but as it is in a > union with

I wait for your prompt response.

2018-09-04 Thread Aziz Dake
Good day, I am Mr. Aziz Dake, from Burkina Faso a Minister confide on me to look for foreign partner who will assist him to invest the sum of Thirty Million Dollars ($30,000,000) in your country. He has investment interest in mining, exotic properties for commercial resident, development

Re: Why not use all the syn queues? in the function "tcp_conn_request", I have some questions.

2018-09-04 Thread Ttttabcd
Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On 4 September 2018 9:06 PM, Neal Cardwell wrote: > On Tue, Sep 4, 2018 at 1:48 AM Ttttabcd a...@protonmail.com wrote: > > > Hello everyone,recently I am looking at the source code for handling TCP > > three-way

Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Andrew Lunn
On Tue, Sep 04, 2018 at 04:55:26PM -0700, Florian Fainelli wrote: > On 09/04/2018 04:32 PM, Andrew Lunn wrote: > > > > > >> +void b53_serdes_phylink_validate(struct b53_device *dev, int port, > >> + unsigned long *supported, > >> + struct

Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Florian Fainelli
On 09/04/2018 04:15 PM, Andrew Lunn wrote: > On Tue, Sep 04, 2018 at 03:11:20PM -0700, Florian Fainelli wrote: >> Add support for the Northstar Plus SerDes which is accessed through a >> special page of the switch. Since this is something that most people >> probably will not want to use, make it

Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Florian Fainelli
On 09/04/2018 04:32 PM, Andrew Lunn wrote: > > >> +void b53_serdes_phylink_validate(struct b53_device *dev, int port, >> + unsigned long *supported, >> + struct phylink_link_state *state) >> +{ >> +u8 lane = b53_serdes_map_lane(dev,

Re: [PATCH net-next 2/5] net: dsa: b53: Make SRAB driver manage port interrupts

2018-09-04 Thread Florian Fainelli
On 09/04/2018 03:59 PM, Andrew Lunn wrote: >> +static irqreturn_t b53_srab_port_isr(int irq, void *dev_id) >> +{ >> +struct b53_srab_port_priv *port = dev_id; >> +struct b53_device *dev = port->dev; >> +struct b53_srab_priv *priv = dev->priv; >> + >> +/* Acknowledge the interrupt

Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Andrew Lunn
> +void b53_serdes_phylink_validate(struct b53_device *dev, int port, > + unsigned long *supported, > + struct phylink_link_state *state) > +{ > + u8 lane = b53_serdes_map_lane(dev, port); > + > + if (lane == B53_INVALID_LANE) >

Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Andrew Lunn
On Tue, Sep 04, 2018 at 03:11:20PM -0700, Florian Fainelli wrote: > Add support for the Northstar Plus SerDes which is accessed through a > special page of the switch. Since this is something that most people > probably will not want to use, make it a configurable option. > > The SerDes supports

Re: [PATCH net-next 2/5] net: dsa: b53: Make SRAB driver manage port interrupts

2018-09-04 Thread Andrew Lunn
> +static irqreturn_t b53_srab_port_isr(int irq, void *dev_id) > +{ > + struct b53_srab_port_priv *port = dev_id; > + struct b53_device *dev = port->dev; > + struct b53_srab_priv *priv = dev->priv; > + > + /* Acknowledge the interrupt */ > + writel(BIT(port->num), priv->regs +

Re: [PATCH net-next] net: sched: change tcf_del_walker() to use concurrent-safe delete

2018-09-04 Thread Cong Wang
On Mon, Sep 3, 2018 at 1:33 PM Vlad Buslov wrote: > > > On Mon 03 Sep 2018 at 18:50, Cong Wang wrote: > > On Mon, Sep 3, 2018 at 12:06 AM Vlad Buslov wrote: > >> > >> Action API was changed to work with actions and action_idr in concurrency > >> safe manner, however tcf_del_walker() still uses

[PATCH net-next v2] openvswitch: Derive IP protocol number for IPv6 later frags

2018-09-04 Thread Yi-Hung Wei
Currently, OVS only parses the IP protocol number for the first IPv6 fragment, but sets the IP protocol number for the later fragments to be NEXTHDF_FRAGMENT. This patch tries to derive the IP protocol number for the IPV6 later frags so that we can match that. Signed-off-by: Yi-Hung Wei ---

[PATCH net-next 0/5] net: dsa: b53: SerDes support

2018-09-04 Thread Florian Fainelli
Hi all, This patch series adds support for the SerDes found on NorthStar Plus (NSP) which allows us to use the SFP port on the BCM958625HR board (and other similar designs). Florian Fainelli (5): net: dsa: b53: Add ability to enable/disable port interrupts net: dsa: b53: Make SRAB driver

Re: [PATCH rdma-next v1 00/15] Flow actions to mutate packets

2018-09-04 Thread Jason Gunthorpe
On Tue, Aug 28, 2018 at 02:18:39PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > >From Mark, > > This series exposes the ability to create flow actions which can > mutate packet headers. We do that by exposing two new verbs: > * modify header - can change existing packet headers.

[PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Florian Fainelli
Add support for the Northstar Plus SerDes which is accessed through a special page of the switch. Since this is something that most people probably will not want to use, make it a configurable option. The SerDes supports both SGMII and 1000baseX modes, and is internally looking like a seemingly

[PATCH net-next 4/5] net: dsa: b53: Add PHYLINK support

2018-09-04 Thread Florian Fainelli
Add support for PHYLINK, things are reasonably straight forward since we do not yet support SerDes interfaces, that leaves us with just MLO_AN_PHY and MLO_AN_FIXED to deal with. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 120 +++

[PATCH net-next 1/5] net: dsa: b53: Add ability to enable/disable port interrupts

2018-09-04 Thread Florian Fainelli
Some switches expose individual interrupt line(s) for port specific event(s), allow configuring these interrupts at an appropriate time during port_enable/disable callbacks where all port specific resources are known to be set-up and ready for use. Signed-off-by: Florian Fainelli ---

[PATCH net-next 3/5] net: dsa: b53: Add helper to set link parameters

2018-09-04 Thread Florian Fainelli
Extract the logic from b53_adjust_link() responsible for overriding a given port's link, speed, duplex and pause settings and make two helper functions to set the port's configuration and the port's link settings. We will make use of both, as separate functions while adding PHYLINK support next.

[PATCH net-next 2/5] net: dsa: b53: Make SRAB driver manage port interrupts

2018-09-04 Thread Florian Fainelli
Update the SRAB driver to manage per-port interrupts. Since we cannot sleep during b53_io_ops, schedule a workqueue whenever we get a port specific interrupt. We will later make use of this to call back into PHYLINK when there is e.g: a link state change. Signed-off-by: Florian Fainelli ---

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

2018-09-04 Thread Jason Gunthorpe
On Tue, Aug 28, 2018 at 02:18:44PM +0300, Leon Romanovsky wrote: > From: Mark Bloch > > Today we are able to attach encap and decap actions only to the FDB. In > preparation to enable those actions on the NIC flow tables, break the > single flag into two. Those flags control whatever a decap or

Re: [PATCH rdma-next v1 12/15] RDMA/mlx5: Add a new flow action verb - modify header

2018-09-04 Thread Jason Gunthorpe
On Tue, Aug 28, 2018 at 02:18:51PM +0300, Leon Romanovsky wrote: > +static int UVERBS_HANDLER(MLX5_IB_METHOD_FLOW_ACTION_CREATE_MODIFY_HEADER)( > + struct ib_uverbs_file *file, > + struct uverbs_attr_bundle *attrs) > +{ > + struct ib_uobject *uobj = uverbs_attr_get_uobject( > +

Re: [PATCH v2 net-next 4/7] dt-bindings: net: Add lantiq,xrx200-net DT bindings

2018-09-04 Thread Hauke Mehrtens
On 09/03/2018 09:46 PM, Florian Fainelli wrote: > > > On 9/1/2018 5:04 AM, Hauke Mehrtens wrote: >> This adds the binding for the PMAC core between the CPU and the GSWIP >> switch found on the xrx200 / VR9 Lantiq / Intel SoC. >> >> Signed-off-by: Hauke Mehrtens >> Cc: devicet...@vger.kernel.org

Re: [PATCH v2 net-next 5/7] net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver

2018-09-04 Thread Hauke Mehrtens
Hi Florian, Thanks for the review. On 09/03/2018 09:24 PM, Florian Fainelli wrote: > > > On 9/1/2018 5:04 AM, Hauke Mehrtens wrote: >> This drives the PMAC between the GSWIP Switch and the CPU in the VRX200 >> SoC. This is currently only the very basic version of the Ethernet >> driver. >> >>

Re: phys_port_id in switchdev mode?

2018-09-04 Thread Or Gerlitz
On Tue, Sep 4, 2018 at 1:20 PM, Jakub Kicinski wrote: > On Mon, 3 Sep 2018 12:40:22 +0300, Or Gerlitz wrote: >> On Tue, Aug 28, 2018 at 9:05 PM, Jakub Kicinski wrote: >> > Hi! >> >> Hi Jakub and sorry for the late reply, this crazigly hot summer refuses to >> die, >> >> Note I replied couple of

Re: [PATCH RFC net-next] net: Poptrie based routing table lookup

2018-09-04 Thread Md. Islam
On Tue, Sep 4, 2018 at 12:14 PM, Md. Islam wrote: > > On Tue, Sep 4, 2018, 6:53 AM Jesper Dangaard Brouer > wrote: >> >> Hi Md. Islam, >> >> People will start to ignore you, when you don't interact appropriately >> with the community, and you ignore their advice, especially when it is >> about

Motorcycle Owners List

2018-09-04 Thread Audrey Tyler
Hi, Would you are interested in acquiring an email list of "Motorcycle Owners" from USA. We also having data of Harley Davidson Owners, Car Owners List, BMW Owners List, RV Owners, Pick Up Truck Owners, Boat Owners, RV Owners List and many more... Each record we will provide you with:

Re: [PATCH net] net: phy: sfp: Handle unimplemented hwmon limits and alarms

2018-09-04 Thread David Miller
From: Andrew Lunn Date: Tue, 4 Sep 2018 04:23:56 +0200 > Not all SFPs implement the registers containing sensor limits and > alarms. Luckily, there is a bit indicating if they are implemented or > not. Add checking for this bit, when deciding if the hwmon attributes > should be visible. > >

Re: [PATCH net-next v2] net: sched: action_ife: take reference to meta module

2018-09-04 Thread David Miller
From: Vlad Buslov Date: Tue, 4 Sep 2018 00:44:42 +0300 > Recent refactoring of add_metainfo() caused use_all_metadata() to add > metainfo to ife action metalist without taking reference to module. This > causes warning in module_put called from ife action cleanup function. > > Implement

Re: [Patch net] act_ife: fix a potential use-after-free

2018-09-04 Thread David Miller
From: Cong Wang Date: Mon, 3 Sep 2018 11:08:15 -0700 > Immediately after module_put(), user could delete this > module, so e->ops could be already freed before we call > e->ops->release(). > > Fix this by moving module_put() after ops->release(). > > Fixes: ef6980b6becb ("introduce IFE

Re: [PATCH net] net/mlx5: Fix SQ offset in QPs with small RQ

2018-09-04 Thread David Miller
From: Tariq Toukan Date: Mon, 3 Sep 2018 18:06:24 +0300 > Correct the formula for calculating the RQ page remainder, > which should be in byte granularity. The result will be > non-zero only for RQs smaller than PAGE_SIZE, as an RQ size > is a power of 2. > > Divide this by the SQ stride

Re: [PATCH] neighbour: confirm neigh entries when ARP packet is received

2018-09-04 Thread David Miller
From: Ihar Hrachyshka Date: Tue, 4 Sep 2018 11:31:23 -0700 > Of course, I also agree that the comment will need some adjustment to > reflect the fact that now a single timestamp is being updated. Perhaps > while at it, Vasily could also explicitly describe in a comment which > scenario the "if"

Re: [PATCH net-next v2] net: sched: action_ife: take reference to meta module

2018-09-04 Thread Cong Wang
On Mon, Sep 3, 2018 at 2:44 PM Vlad Buslov wrote: > > Recent refactoring of add_metainfo() caused use_all_metadata() to add > metainfo to ife action metalist without taking reference to module. This > causes warning in module_put called from ife action cleanup function. > > Implement

Re: [PATCH] neighbour: confirm neigh entries when ARP packet is received

2018-09-04 Thread Ihar Hrachyshka
On Sat, Sep 1, 2018 at 4:51 PM, David Miller wrote: > From: Vasily Khoruzhick > Date: Tue, 28 Aug 2018 19:48:25 -0700 > >> Update 'confirmed' timestamp when ARP packet is received. It shouldn't >> affect locktime logic and anyway entry can be confirmed by any higher-layer >> protocol. Thus it

Re: [PATCH net] net/sched: fix memory leak in act_tunnel_key_init()

2018-09-04 Thread Cong Wang
On Tue, Sep 4, 2018 at 10:00 AM Davide Caratti wrote: > > If users try to install act_tunnel_key 'set' rules with duplicate values > of 'index', the tunnel metadata are allocated, but never released. Then, > kmemleak complains as follows: Acked-by: Cong Wang

[PATCH bpf-next 4/4] i40e: disallow changing the number of descriptors when AF_XDP is on

2018-09-04 Thread Björn Töpel
From: Björn Töpel When an AF_XDP UMEM is attached to any of the Rx rings, we disallow a user to change the number of descriptors via e.g. "ethtool -G IFNAME". Otherwise, the size of the stash/reuse queue can grow unbounded, which would result in OOM or leaking userspace buffers. Signed-off-by:

[PATCH bpf-next 3/4] i40e: clean zero-copy XDP Rx ring on shutdown/reset

2018-09-04 Thread Björn Töpel
From: Björn Töpel Outstanding Rx descriptors are temporarily stored on a stash/reuse queue. When/if the HW rings comes up again, entries from the stash are used to re-populate the ring. The latter required some restructuring of the allocation scheme for the AF_XDP zero-copy implementation.

[PATCH bpf-next 1/4] i40e: clean zero-copy XDP Tx ring on shutdown/reset

2018-09-04 Thread Björn Töpel
From: Björn Töpel When the zero-copy enabled XDP Tx ring is torn down, due to configuration changes, outstandning frames on the hardware descriptor ring are queued on the completion ring. The completion ring has a back-pressure mechanism that will guarantee that there is sufficient space on the

[PATCH bpf-next 2/4] net: xsk: add a simple buffer reuse queue

2018-09-04 Thread Björn Töpel
From: Jakub Kicinski XSK UMEM is strongly single producer single consumer so reuse of frames is challenging. Add a simple "stash" of FILL packets to reuse for drivers to optionally make use of. This is useful when driver has to free (ndo_stop) or resize a ring with an active AF_XDP ZC socket.

[PATCH bpf-next 0/4] i40e AF_XDP zero-copy buffer leak fixes

2018-09-04 Thread Björn Töpel
From: Björn Töpel This series addresses an AF_XDP zero-copy issue that buffers passed from userspace to the kernel was leaked when the hardware descriptor ring was torn down. The patches fixes the i40e AF_XDP zero-copy implementation. Thanks to Jakub Kicinski for pointing this out! Some

[iproute PATCH] ip-route: Fix segfault with many nexthops

2018-09-04 Thread Phil Sutter
It was possible to crash ip-route by adding an IPv6 route with 37 nexthop statements. A simple reproducer is: | for i in `seq 37`; do | nhs="nexthop via ::$i "$nhs | done | ip -6 route add ::/64 $nhs The related code was broken in multiple ways: * parse_one_nh() assumed that rta

[PATCH net] net/sched: fix memory leak in act_tunnel_key_init()

2018-09-04 Thread Davide Caratti
If users try to install act_tunnel_key 'set' rules with duplicate values of 'index', the tunnel metadata are allocated, but never released. Then, kmemleak complains as follows: # tc a a a tunnel_key set src_ip 1.1.1.1 dst_ip 2.2.2.2 id 42 index 111 # echo clear > /sys/kernel/debug/kmemleak #

Re: [oss-drivers] Re: [RFC bpf-next PATCH] samples/bpf: xdp1 add XDP hardware offload option

2018-09-04 Thread Jakub Kicinski
On Tue, 4 Sep 2018 18:49:33 +0200, Jesper Dangaard Brouer wrote: > On Tue, 4 Sep 2018 17:09:12 +0200 > Jakub Kicinski wrote: > > > On Tue, 04 Sep 2018 16:59:19 +0200, Jesper Dangaard Brouer wrote: > > > Trying to use XDP hardware offloading via XDP_FLAGS_HW_MODE > > > and setting the ifindex

Re: [bpf-next PATCH 3/3] xdp: split code for map vs non-map redirect

2018-09-04 Thread Jesper Dangaard Brouer
On Tue, 4 Sep 2018 23:39:45 +0800 kbuild test robot wrote: > Hi Jesper, > > Thank you for the patch! Perhaps something to improve: Daniel is faster than kbuild test-robot, and have already pointed this out, and it should be fixed in V2. -- Best regards, Jesper Dangaard Brouer MSc.CS,

Re: [RFC bpf-next PATCH] samples/bpf: xdp1 add XDP hardware offload option

2018-09-04 Thread Jesper Dangaard Brouer
On Tue, 4 Sep 2018 17:09:12 +0200 Jakub Kicinski wrote: > On Tue, 04 Sep 2018 16:59:19 +0200, Jesper Dangaard Brouer wrote: > > Trying to use XDP hardware offloading via XDP_FLAGS_HW_MODE > > and setting the ifindex in prog_load_attr.ifindex before > > loading the BPF code via

Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-09-04 Thread Samudrala, Sridhar
On 9/3/2018 7:56 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] There should check

Re: [PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

2018-09-04 Thread Patrick Ruddy
On Mon, 2018-09-03 at 16:12 -0700, Roopa Prabhu wrote: > On Sun, Sep 2, 2018 at 4:18 AM, Patrick Ruddy > wrote: > > Hi Roopa > > > > inline > > > > thx > > > > -pr > > > > On Fri, 2018-08-31 at 09:29 -0700, Roopa Prabhu wrote: > > > On Fri, Aug 31, 2018 at 4:20 AM, Patrick Ruddy > > > wrote:

Re: [PATCH RFC net-next 00/18] net: Improve route scalability via support for nexthop objects

2018-09-04 Thread David Ahern
On 9/2/18 11:34 AM, David Miller wrote: > From: dsah...@kernel.org > Date: Fri, 31 Aug 2018 17:49:35 -0700 > >> Examples >> 1. Single path >> $ ip nexthop add id 1 via 10.99.1.2 dev veth1 >> $ ip route add 10.1.1.0/24 nhid 1 >> >> $ ip next ls >> id 1 via 10.99.1.2 src 10.99.1.1

[net-next:master 13/40] drivers/net/ethernet/altera/altera_tse_main.c:1628: undefined reference to `of_phy_is_fixed_link'

2018-09-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 42220b77495d20eff5880336faff7bca1c111ee3 commit: 7e8d5755be0e6c92d3b86a85e54c6a550b1910c5 [13/40] net: nixge: Add support for 64-bit platforms config: i386-randconfig-b0-09021507 (attached as .config)

Re: [PATCH iproute2-next] ip: Add support for nexthop objects

2018-09-04 Thread David Ahern
On 9/1/18 2:37 PM, Stephen Hemminger wrote: >> diff --git a/include/uapi/linux/nexthop.h b/include/uapi/linux/nexthop.h >> new file mode 100644 >> index ..335182e8229a >> --- /dev/null >> +++ b/include/uapi/linux/nexthop.h >> @@ -0,0 +1,56 @@ >> +#ifndef __LINUX_NEXTHOP_H >> +#define

[PATCH net-next] nfp: separate VXLAN and GRE feature handling

2018-09-04 Thread Jakub Kicinski
VXLAN and GRE FW features have to currently be both advertised for the driver to enable them. Separate the handling. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- .../net/ethernet/netronome/nfp/nfp_net_common.c | 17 ++--- 1 file changed, 10 insertions(+), 7

Re: [bpf-next PATCH 3/3] xdp: split code for map vs non-map redirect

2018-09-04 Thread kbuild test robot
Hi Jesper, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/XDP-micro-optimizations-for-redirect/20180903-121606 base:

Re: [PATCH RFC net-next 18/18] net/ipv4: Optimization for fib_info lookup

2018-09-04 Thread David Ahern
On 9/1/18 2:43 PM, Stephen Hemminger wrote: > On Fri, 31 Aug 2018 17:49:53 -0700 > dsah...@kernel.org wrote: > >> +static inline unsigned int fib_info_hashfn_cfg(const struct fib_config *cfg) >> +{ >> +unsigned int mask = (fib_info_hash_size - 1); >> +unsigned int val = 0; >> + >> +

[RFC PATCH] xdp: xdp_do_redirect_slow() can be static

2018-09-04 Thread kbuild test robot
Fixes: 974efdb08a35 ("xdp: split code for map vs non-map redirect") Signed-off-by: kbuild test robot --- filter.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index 45ea00b..95454f3 100644 --- a/net/core/filter.c +++

Re: [RFC bpf-next PATCH] samples/bpf: xdp1 add XDP hardware offload option

2018-09-04 Thread Jakub Kicinski
On Tue, 04 Sep 2018 16:59:19 +0200, Jesper Dangaard Brouer wrote: > Trying to use XDP hardware offloading via XDP_FLAGS_HW_MODE > and setting the ifindex in prog_load_attr.ifindex before > loading the BPF code via bpf_prog_load_xattr(). > > This unfortunately does not seem to work... > - Am I

[RFC bpf-next PATCH] samples/bpf: xdp1 add XDP hardware offload option

2018-09-04 Thread Jesper Dangaard Brouer
Trying to use XDP hardware offloading via XDP_FLAGS_HW_MODE and setting the ifindex in prog_load_attr.ifindex before loading the BPF code via bpf_prog_load_xattr(). This unfortunately does not seem to work... - Am I doing something wrong? Notice, I also disable the map BPF_MAP_TYPE_PERCPU_ARRAY

bnxt_en fails to initialize MAC address in Oracle cloud

2018-09-04 Thread Seth Forshee
We got a bug report against Ubuntu about networking failing to come up in the Oracle cloud: https://bugs.launchpad.net/bugs/1790652 This is with a kernel based on 4.18.5, and it has also been seen with a 4.17-based kernel. I'm not currently aware of any working kernel version. The driver seems

[PATCH net-next 1/3] nfp: fix readq on absolute RTsyms

2018-09-04 Thread Jakub Kicinski
Return the error and report value through the output param. Fixes: 640917dd81b6 ("nfp: support access to absolute RTsyms") Reported-by: Dan Carpenter Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c | 6 -- 1 file

[PATCH net-next 2/3] nfp: prefix rtsym error messages with symbol name

2018-09-04 Thread Jakub Kicinski
For ease of debug preface all error messages with the name of the symbol which caused them. Use the same message format for existing messages while at it. Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron --- .../netronome/nfp/nfpcore/nfp_rtsym.c | 21 ++-

[PATCH net-next 0/3] nfp: improve the new rtsym helpers

2018-09-04 Thread Jakub Kicinski
Hi! This set fixes a bug in ABS rtsym handling I added in net-next, it expands the error checking and reporting on the rtsym accesses. Jakub Kicinski (3): nfp: fix readq on absolute RTsyms nfp: prefix rtsym error messages with symbol name nfp: validate rtsym accesses fall within the symbol

[PATCH net-next 3/3] nfp: validate rtsym accesses fall within the symbol

2018-09-04 Thread Jakub Kicinski
With the accesses to rtsyms now all going via special helpers we can easily make sure the driver is not reading past the end of the symbol. Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron --- .../netronome/nfp/nfpcore/nfp_rtsym.c | 48 +-- 1 file changed,

Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jose Abreu
Hi Jerome, On 04-09-2018 13:27, Jerome Brunet wrote: > On Tue, 2018-09-04 at 10:57 +0100, Jose Abreu wrote: >> Hi Jerome, >> >> On 03-09-2018 17:22, Jerome Brunet wrote: >>> Situation is even worse with this. >>> I'm using an NFS root filesystem. With your fixup, I'm not reaching the >>> prompt

[PATCH bpf-next] bpf/verifier: properly clear union members after a ctx read

2018-09-04 Thread Edward Cree
In check_mem_access(), for the PTR_TO_CTX case, after check_ctx_access() has supplied a reg_type, the other members of the register state are set appropriately. Previously reg.range was set to 0, but as it is in a union with reg.map_ptr, which is larger, upper bytes of the latter were left in

Re: Why not use all the syn queues? in the function "tcp_conn_request", I have some questions.

2018-09-04 Thread Neal Cardwell
On Tue, Sep 4, 2018 at 1:48 AM Ttttabcd wrote: > > Hello everyone,recently I am looking at the source code for handling TCP > three-way handshake(Linux Kernel version 4.18.5). > > I found some strange places in the source code for handling syn messages. > > in the function "tcp_conn_request" > >

Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jerome Brunet
On Tue, 2018-09-04 at 10:57 +0100, Jose Abreu wrote: > Hi Jerome, > > On 03-09-2018 17:22, Jerome Brunet wrote: > > > > Situation is even worse with this. > > I'm using an NFS root filesystem. With your fixup, I'm not reaching the > > prompt > > anymore. Looks like a the same kind of network

Re: [PATCH mlx5-next] net/mlx5: Add memic command opcode to command checker

2018-09-04 Thread Leon Romanovsky
On Mon, Sep 03, 2018 at 08:19:48PM +0300, Leon Romanovsky wrote: > From: Ariel Levkovich > > Adding the alloc/dealloc memic FW command opcodes to > avoid "unknown command" prints in the command string > converter and internal error status handler. > > Signed-off-by: Ariel Levkovich >

Re: [PATCH mlx5-next] net/mlx5: Fix atomic_mode enum values

2018-09-04 Thread Leon Romanovsky
On Mon, Sep 03, 2018 at 08:19:28PM +0300, Leon Romanovsky wrote: > From: Moni Shoua > > The field atomic_mode is 4 bits wide and therefore can hold values > from 0x0 to 0xf. Remove the unnecessary 20 bit shift that made the values > be incorrect. While that, remove unused enum values. > > Fixes:

Re: [PATCH RFC net-next] net: Poptrie based routing table lookup

2018-09-04 Thread Jesper Dangaard Brouer
Hi Md. Islam, People will start to ignore you, when you don't interact appropriately with the community, and you ignore their advice, especially when it is about how to interact with the community[1]. You have not addressed any of my feedback on your patch in [1]. [1]

Re: phys_port_id in switchdev mode?

2018-09-04 Thread Jakub Kicinski
On Mon, 3 Sep 2018 12:40:22 +0300, Or Gerlitz wrote: > On Tue, Aug 28, 2018 at 9:05 PM, Jakub Kicinski wrote: > > Hi! > > Hi Jakub and sorry for the late reply, this crazigly hot summer refuses to > die, > > Note I replied couple of minutes ago but it didn't get to the list, so > lets take it

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jose Abreu
On 04-09-2018 10:16, Jerome Brunet wrote: > On Mon, 2018-09-03 at 16:47 +0100, Jose Abreu wrote: >> On 03-09-2018 16:38, Jerome Brunet wrote: >>> On Mon, 2018-09-03 at 16:22 +0100, Jose Abreu wrote: On 03-09-2018 15:10, Jerome Brunet wrote: > On Mon, 2018-09-03 at 12:47 +0100, Jose

Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jose Abreu
Hi Jerome, On 03-09-2018 17:22, Jerome Brunet wrote: > > Situation is even worse with this. > I'm using an NFS root filesystem. With your fixup, I'm not reaching the prompt > anymore. Looks like a the same kind of network breakdown we had previously > I was able to reproduce your problem and the

Re: [Patch net] tipc: fix a missing rhashtable_walk_exit()

2018-09-04 Thread Ying Xue
On 08/24/2018 07:19 AM, Cong Wang wrote: > rhashtable_walk_exit() must be paired with rhashtable_walk_enter(). > > Fixes: 40f9f4397060 ("tipc: Fix tipc_sk_reinit race conditions") > Cc: Herbert Xu > Cc: Ying Xue > Signed-off-by: Cong Wang Acked-by: Ying Xue > --- > net/tipc/socket.c | 2 ++

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jerome Brunet
On Mon, 2018-09-03 at 16:47 +0100, Jose Abreu wrote: > On 03-09-2018 16:38, Jerome Brunet wrote: > > On Mon, 2018-09-03 at 16:22 +0100, Jose Abreu wrote: > > > On 03-09-2018 15:10, Jerome Brunet wrote: > > > > On Mon, 2018-09-03 at 12:47 +0100, Jose Abreu wrote: > > > > > On 03-09-2018 11:16,

Re: [PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

2018-09-04 Thread Patrick Ruddy
On Mon, 2018-09-03 at 16:12 -0700, Roopa Prabhu wrote: > On Sun, Sep 2, 2018 at 4:18 AM, Patrick Ruddy > wrote: > > Hi Roopa > > > > inline > > > > thx > > > > -pr > > > > On Fri, 2018-08-31 at 09:29 -0700, Roopa Prabhu wrote: > > > On Fri, Aug 31, 2018 at 4:20 AM, Patrick Ruddy > > > wrote:

Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-09-04 Thread Liran Alon
- yuehaib...@huawei.com wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/net_failover.c: In function > 'net_failover_slave_unregister': > drivers/net/net_failover.c:598:35: warning: > variable 'primary_dev' set but not used [-Wunused-but-set-variable] > > There

Re: Why not use all the syn queues? in the function "tcp_conn_request", I have some questions.

2018-09-04 Thread Eric Dumazet
On 09/03/2018 10:31 PM, Ttttabcd wrote: > Hello everyone,recently I am looking at the source code for handling TCP > three-way handshake(Linux Kernel version 4.18.5). > > I found some strange places in the source code for handling syn messages. > > in the function "tcp_conn_request" > >

RE: [net-next 02/15] i40e: move ethtool stats boiler plate code to i40e_ethtool_stats.h

2018-09-04 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of David Miller > Sent: Wednesday, August 29, 2018 8:05 PM > To: Kirsher, Jeffrey T > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com;

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

2018-09-04 Thread Michael Chan
On Mon, Sep 3, 2018 at 10:50 PM, Michael Chan wrote: > On Mon, Sep 3, 2018 at 10:01 PM, David Miller wrote: >> >> From: Michael Chan >> Date: Mon, 3 Sep 2018 04:23:16 -0400 >> >> > This short series fixes resource related logic in the driver, mostly >> > affecting the RDMA driver under corner