[PATCH net-next] liquidio: Add the features to show FEC settings and set FEC settings

2018-09-16 Thread Felix Manlunas
From: Weilin Chang 1. Add functions for get_fecparam and set_fecparam. 2. Modify lio_get_link_ksettings to display FEC setting. Signed-off-by: Weilin Chang Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 148

Re: [PATCH net-next v4 18/20] crypto: port ChaCha20 to Zinc

2018-09-16 Thread Jason A. Donenfeld
Hey Martin, Thanks for running these and pointing this out. I've replicated the results with tcrypt and fixed some issues, and the next patch series should be a lot closer to what you'd expect, instead of the regression you noticed. Most of the slowdown happened as a result of over-eager XSAVEs,

Re: [PATCH net-next v3 02/17] zinc: introduce minimal cryptography library

2018-09-16 Thread David Miller
From: Andy Lutomirski Date: Sun, 16 Sep 2018 21:09:11 -0700 > CRYPTO API > M: Herbert Xu > M: "David S. Miller" > L: linux-cry...@vger.kernel.org > > Herbert hasn't replied to any of these submissions. You're the other > maintainer :) Herbert is the primary crypto maintainer,

Re: [PATCH net] netfilter: bridge: Don't sabotage nf_hook calls from an l3mdev

2018-09-16 Thread David Ahern
Pablo: DaveM has this marked as waiting for upstream. Any comment on this patch? Thanks, David On 9/7/18 3:08 PM, dsah...@kernel.org wrote: > From: David Ahern > > For starters, the bridge netfilter code registers operations that > are invoked any time nh_hook is called. Specifically,

Re: [PATCH net-next v3 02/17] zinc: introduce minimal cryptography library

2018-09-16 Thread Andy Lutomirski
On Tue, Sep 11, 2018 at 4:57 PM David Miller wrote: > > From: Andrew Lunn > Date: Wed, 12 Sep 2018 01:30:15 +0200 > > > Just as an FYI: > > > > 1) I don't think anybody in netdev has taken a serious look at the > > network code yet. There is little point until the controversial part > > of the

Re: [PATCH net-next] net/smc: cast sizeof to int for comparison

2018-09-16 Thread YueHaibing
On 2018/9/15 19:35, Andreas Schwab wrote: > On Sep 15 2018, YueHaibing wrote: > >> Comparing an int to a size, which is unsigned, causes the int to become >> unsigned, giving the wrong result. kernel_sendmsg can return a negative >> error code. >> >> Signed-off-by: YueHaibing >> --- >>

Re: [PATCH iproute2] libnetlink: fix leak and using unused memory on error

2018-09-16 Thread David Ahern
On 9/14/18 10:48 AM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Sep 13, 2018 at 12:33 PM, Stephen Hemminger > wrote: >> If an error happens in multi-segment message (tc only) >> then report the error and stop processing further responses. >> This also fixes refering to the buffer after free.

Re: pull-request: bpf 2018-09-16

2018-09-16 Thread David Miller
From: Daniel Borkmann Date: Sun, 16 Sep 2018 02:36:45 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix end boundary calculation in BTF for the type section, from Martin. > > 2) Fix and revert subtraction of pointers that was

[PATCHv2 net-next 1/1] net: rds: use memset to optimize the recv

2018-09-16 Thread Zhu Yanjun
The function rds_inc_init is in recv process. To use memset can optimize the function rds_inc_init. The test result: Before: 1) + 24.950 us |rds_inc_init [rds](); After: 1) + 10.990 us |rds_inc_init [rds](); Acked-by: Santosh Shilimkar Signed-off-by: Zhu

[net-next:master 13/125] drivers/net//ethernet/ni/nixge.c:254:9: warning: cast to pointer from integer of different size

2018-09-16 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: c3ec8bcceb07ab81e4ff017b4ebbacc137a5a15e commit: 7e8d5755be0e6c92d3b86a85e54c6a550b1910c5 [13/125] net: nixge: Add support for 64-bit platforms config: i386-randconfig-i1-09170930 (attached as .config)

Re: [PATCH 1/1] net: rds: use memset to optimize the recv

2018-09-16 Thread zhuyj
OK. I will send V2 for net-next very soon. Zhu Yanjun On Mon, Sep 17, 2018 at 6:38 AM David Miller wrote: > > From: Zhu Yanjun > Date: Fri, 14 Sep 2018 04:45:38 -0400 > > > The function rds_inc_init is in recv process. To use memset can optimize > > the function rds_inc_init. > > The test

Re: [PATCH 1/1] net: rds: use memset to optimize the recv

2018-09-16 Thread David Miller
From: Zhu Yanjun Date: Fri, 14 Sep 2018 04:45:38 -0400 > The function rds_inc_init is in recv process. To use memset can optimize > the function rds_inc_init. > The test result: > > Before: > 1) + 24.950 us |rds_inc_init [rds](); > After: > 1) + 10.990 us |

Re: [PATCH net] veth: Orphan skb before GRO

2018-09-16 Thread David Miller
From: Toshiaki Makita Date: Fri, 14 Sep 2018 13:33:44 +0900 > GRO expects skbs not to be owned by sockets, but when XDP is enabled veth > passed skbs owned by sockets. It caused corrupted sk_wmem_alloc. > > Paolo Abeni reported the following splat: ... > In order to avoid this, orphan the skb

Re: [PATCH net-next 0/2] net/sched: act_police: lockless data path

2018-09-16 Thread David Miller
From: Davide Caratti Date: Thu, 13 Sep 2018 19:29:11 +0200 > the data path of 'police' action can be faster if we avoid using spinlocks: > - patch 1 converts act_police to use per-cpu counters > - patch 2 lets act_police use RCU to access its configuration data. > > test procedure (using

Re: [PATCH net 0/2] udp: add missing check on edumx rx path

2018-09-16 Thread David Miller
From: Paolo Abeni Date: Thu, 13 Sep 2018 16:27:19 +0200 > The early demux RX path for the UDP protocol is currently missing > some checks. Both ipv4 and ipv6 implementations lack checksum conversion > and the ipv6 implementation additionally lack the zero checksum > validation. > > The first

Oddities with connmark

2018-09-16 Thread Алексей Болдырев
Actually, there is a suricata with the following rules: #pass tls any any -> any any (pcre: "/play.google.com/i"; tls_sni;nfq_set_mark:0x8/0x; sid:2466;) #pass tls any any -> any any (pcre: "/google.com/i"; tls_sni;nfq_set_mark:0x8/0x; sid:2465;) #pass tls any any -> any any

Re: [RFC PATCH iproute2-next] System specification health API

2018-09-16 Thread Andrew Lunn
> Why is this going under iproute rather than using one of the existing sensor > API's. > For example Intel NIC's have thermal sensors etc. Hi Stephen These are not that sort of sensors. This is part of the naming problem here. It is not really to do with health, it is about exceptions and

Re: [RFC PATCH iproute2-next] System specification health API

2018-09-16 Thread Stephen Hemminger
On Thu, 13 Sep 2018 10:36:04 -0700 Jakub Kicinski wrote: > On Thu, 13 Sep 2018 11:18:15 +0300, Eran Ben Elisha wrote: > > The health spec is targeted for Real Time Alerting, in order to know when > > something bad had happened to a PCI device > > By spec you mean some standards body spec you

Re: [PATH RFC net-next 1/8] net: phy: Move linkmode helpers to somewhere public

2018-09-16 Thread Andrew Lunn
> Good idea, I wonder if we should create a more specific directory within > include/linux/ that can host a variety of PHYLIB, PHYLINK and what not > header files, but this could be solved later on. I'm leaving it for later. We would also need to figure out a name for this directory. phy is

Re: [RFC PATCH 2/4] net: enable UDP gro on demand.

2018-09-16 Thread Willem de Bruijn
On Fri, Sep 14, 2018 at 1:16 PM Willem de Bruijn wrote: > > On Fri, Sep 14, 2018 at 11:47 AM Paolo Abeni wrote: > > > > Currently, the UDP GRO callback is always invoked, regardless of > > the existence of any actual user (e.g. a UDP tunnel). With retpoline > > enabled, this causes measurable

Re: [PATCH net-next RFC 5/8] net: deconstify net_offload

2018-09-16 Thread Willem de Bruijn
On Fri, Sep 14, 2018 at 11:30 PM Subash Abhinov Kasiviswanathan wrote: > > On 2018-09-14 11:59, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > With configurable gro, the flags field in net_offloads may be changed. > > > > Remove the const keyword. This is a noop otherwise. > > > >

Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-16 Thread Willem de Bruijn
On Fri, Sep 14, 2018 at 11:37 PM Subash Abhinov Kasiviswanathan wrote: > > On 2018-09-14 11:59, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Avoid the socket lookup cost in udp_gro_receive if no socket has a > > gro callback configured. > > > > Signed-off-by: Willem de Bruijn > >

Re: [PATH RFC net-next 7/8] net: phy: Replace phy driver features u32 with link_mode bitmap

2018-09-16 Thread Andrew Lunn
> By that you mean having to determine whether you overflow the > capacity of an unsigned long storage type and having to put the bits > in either unsigned long [0] or [1]? Being able to eliminate the > duplication would also be nice, but I cannot think about a smart > solution at compile time

[PATCH iproute2-next] rdma: Fix representation of PortInfo CapabilityMask

2018-09-16 Thread Leon Romanovsky
From: Leon Romanovsky The port capability mask represents IBTA PortInfo specification, but as it is written in description of kernel commit 2f944c0fbf58 ("RDMA: Fix storage of PortInfo CapabilityMask in the kernel"), the bit 26 was mistakenly overwritten. The rdmatool followed it too and

Re: [PATH RFC net-next 7/8] net: phy: Replace phy driver features u32 with link_mode bitmap

2018-09-16 Thread Florian Fainelli
Hi Andrew, On September 15, 2018 3:30:53 PM PDT, Andrew Lunn wrote: >On Sat, Sep 15, 2018 at 02:31:14PM -0700, Florian Fainelli wrote: >> >> >> On 09/14/18 14:38, Andrew Lunn wrote: >> > This is one step in allowing phylib to make use of link_mode >bitmaps, >> > instead of u32 for supported

Re: [RFC PATCH iproute2-next] System specification health API

2018-09-16 Thread Eran Ben Elisha
On 9/13/2018 8:36 PM, Jakub Kicinski wrote: On Thu, 13 Sep 2018 11:18:15 +0300, Eran Ben Elisha wrote: The health spec is targeted for Real Time Alerting, in order to know when something bad had happened to a PCI device By spec you mean some standards body spec you implement or this

Re: [RFC PATCH iproute2-next] man: Add devlink health man page

2018-09-16 Thread Eran Ben Elisha
On 9/13/2018 6:12 PM, Andrew Lunn wrote: devlink health sensor set pci/:01:00.0 name TX_COMP_ERROR action reset off action dump on Sets TX_COMP_ERROR sensor parameters for a specific device. This is what I had in mind: 1. command interface error 2. command