Re: [PATCH net-next 0/5] vrf: allow simultaneous service instances in default and other VRFs

2018-09-20 Thread David Ahern
On 9/20/18 1:58 AM, Mike Manning wrote: > Services currently have to be VRF-aware if they are using an unbound > socket. One cannot have multiple service instances running in the > default and other VRFs for services that are not VRF-aware and listen > on an unbound socket. This is because there

[PATCH net-next v2] net/tls: Add support for async encryption of records for performance

2018-09-20 Thread Vakul Garg
In current implementation, tls records are encrypted & transmitted serially. Till the time the previously submitted user data is encrypted, the implementation waits and on finish starts transmitting the record. This approach of encrypt-one record at a time is inefficient when asynchronous crypto

答复: [PATCH][next-next][v2] netlink: avoid to allocate full skb when sending to many devices

2018-09-20 Thread Li,Rongqing
: Re: [PATCH][next-next][v2] netlink: avoid to allocate full skb when > sending to many devices > > > > On 09/20/2018 06:43 AM, Eric Dumazet wrote: > > > Sorry, I should cc to you. > > And lastly this patch looks way too complicated to me. > > You probably can write something much simpler. >

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-20 Thread Alexei Starovoitov
On Thu, Sep 20, 2018 at 03:56:51PM +0200, Peter Zijlstra wrote: > On Thu, Sep 20, 2018 at 10:25:45AM -0300, Arnaldo Carvalho de Melo wrote: > > PeterZ provided a patch introducing PERF_RECORD_MUNMAP, went nowhere due > > to having to cope with munmapping parts of existing mmaps, etc. > > > > I'm

Re: [PATCH net] r8169: fix autoneg issue on resume with RTL8168E

2018-09-20 Thread David Miller
From: Heiner Kallweit Date: Thu, 20 Sep 2018 22:47:09 +0200 > It was reported that chip version 33 (RTL8168E) ends up with > 10MBit/Half on a 1GBit link after resuming from S3 (with different > link partners). For whatever reason the PHY on this chip doesn't > properly start a renegotiation when

[PATCH RESEND] PCI: hv: Fix return value check in hv_pci_assign_slots()

2018-09-20 Thread Wei Yongjun
In case of error, the function pci_create_slot() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot information") Signed-off-by: Wei Yongjun --- Since the orig

RE: [PATCH net-next] net/tls: Add support for async encryption of records for performance

2018-09-20 Thread Vakul Garg
> -Original Message- > From: David Miller > Sent: Thursday, September 20, 2018 11:49 PM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com > Subject: Re: [PATCH net-next] net/tls: Add support for async

Re: [PATCH iproute2-next] iplink: add ipvtap support

2018-09-20 Thread David Ahern
On 9/18/18 8:03 PM, Hangbin Liu wrote: > IPVLAN and IPVTAP are using the same functions and parameters. So we can > just add a new link_util with id ipvtap. Others are the same. > > Signed-off-by: Hangbin Liu > --- > ip/iplink.c | 4 ++-- > ip/iplink_ipvlan.c| 28

[PATCH net] net/ipv6: Display all addresses in output of /proc/net/if_inet6

2018-09-20 Thread Jeff Barnhill
The backend handling for /proc/net/if_inet6 in addrconf.c doesn't properly handle starting/stopping the iteration. The problem is that at some point during the iteration, an overflow is detected and the process is subsequently stopped. The item being shown via seq_printf() when the overflow

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Eric Dumazet
On 09/20/2018 04:43 PM, Song Liu wrote: > > I tried to totally skip ndo_poll_controller() here. It did avoid hitting > the issue. However, netpoll will drop (fail to send) more packets. > Why is it failing ? If you are under high memory pressure, then maybe if you absolutely want memory

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Song Liu
> On Sep 20, 2018, at 4:22 PM, Eric Dumazet wrote: > > > > On 09/20/2018 03:42 PM, Song Liu wrote: >> >> >>> On Sep 20, 2018, at 2:01 PM, Jeff Kirsher >>> wrote: >>> >>> On Thu, 2018-09-20 at 13:35 -0700, Eric Dumazet wrote: On 09/20/2018 12:01 PM, Song Liu wrote: > The NIC

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Eric Dumazet
On 09/20/2018 03:42 PM, Song Liu wrote: > > >> On Sep 20, 2018, at 2:01 PM, Jeff Kirsher >> wrote: >> >> On Thu, 2018-09-20 at 13:35 -0700, Eric Dumazet wrote: >>> On 09/20/2018 12:01 PM, Song Liu wrote: The NIC driver should only enable interrupts when napi_complete_done()

Re: array bounds warning in xfrm_output_resume

2018-09-20 Thread David Ahern
On 9/20/18 7:06 AM, Florian Westphal wrote: > David Ahern wrote: >>> $ make O=kbuild/perf -j 24 -s >>> In file included from /home/dsa/kernel-3.git/include/linux/kernel.h:10:0, >>> from /home/dsa/kernel-3.git/include/linux/list.h:9, >>> from

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Song Liu
> On Sep 20, 2018, at 2:01 PM, Jeff Kirsher wrote: > > On Thu, 2018-09-20 at 13:35 -0700, Eric Dumazet wrote: >> On 09/20/2018 12:01 PM, Song Liu wrote: >>> The NIC driver should only enable interrupts when napi_complete_done() >>> returns true. This patch adds the check for ixgbe. >>> >>>

Re: [PATCH net] af_key: free SKBs under RCU protection

2018-09-20 Thread Eric Dumazet
On 09/20/2018 03:10 PM, Eric Dumazet wrote: > > > On 09/20/2018 12:25 PM, stran...@codeaurora.org wrote: >>> >>> I do not believe the changelog or the patch makes sense. >>> >>> Having skb still referencing a socket prevents this socket being released. >>> >>> If you think about it, what

Re: [PATCH net] af_key: free SKBs under RCU protection

2018-09-20 Thread Eric Dumazet
On 09/20/2018 12:25 PM, stran...@codeaurora.org wrote: >> >> I do not believe the changelog or the patch makes sense. >> >> Having skb still referencing a socket prevents this socket being released. >> >> If you think about it, what would prevent the freeing happening >> _before_ the

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Jeff Kirsher
On Thu, 2018-09-20 at 13:35 -0700, Eric Dumazet wrote: > On 09/20/2018 12:01 PM, Song Liu wrote: > > The NIC driver should only enable interrupts when napi_complete_done() > > returns true. This patch adds the check for ixgbe. > > > > Cc: sta...@vger.kernel.org # 4.10+ > > Cc: Jeff Kirsher > >

[PATCH net] r8169: fix autoneg issue on resume with RTL8168E

2018-09-20 Thread Heiner Kallweit
It was reported that chip version 33 (RTL8168E) ends up with 10MBit/Half on a 1GBit link after resuming from S3 (with different link partners). For whatever reason the PHY on this chip doesn't properly start a renegotiation when soft-reset. Explicitly requesting a renegotiation fixes this.

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Eric Dumazet
On 09/20/2018 12:01 PM, Song Liu wrote: > The NIC driver should only enable interrupts when napi_complete_done() > returns true. This patch adds the check for ixgbe. > > Cc: sta...@vger.kernel.org # 4.10+ > Cc: Jeff Kirsher > Suggested-by: Eric Dumazet > Signed-off-by: Song Liu > ---

[PATCH net-next v2] net: phy: don't reschedule state machine when PHY is halted

2018-09-20 Thread Heiner Kallweit
When being in state PHY_HALTED we don't have to reschedule the state machine, phy_start() will start it again. Signed-off-by: Heiner Kallweit --- v2: - added comment --- drivers/net/phy/phy.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy.c

[PATCH net] netlabel: check for IPV4MASK in addrinfo_get

2018-09-20 Thread Sean Tranchetti
netlbl_unlabel_addrinfo_get() assumes that if it finds the NLBL_UNLABEL_A_IPV4ADDR attribute, it must also have the NLBL_UNLABEL_A_IPV4MASK attribute as well. However, this is not necessarily the case as the current checks in netlbl_unlabel_staticadd() and friends are not sufficent to enforce

Re: [PATCH rdma-next v1 0/7] Preparation to DevX extension series

2018-09-20 Thread Or Gerlitz
On Thu, Sep 20, 2018 at 9:35 PM, Leon Romanovsky wrote: > From: Leon Romanovsky > Set uid as part of various IB commands so that the firmware can manage > the IB object in a secured way. This series deals with FS core and commands used by the Ethernet driver > net/mlx5: Update mlx5_ifc with

Re: [PATCH mlx5-next v1 7/7] net/mlx5: Update mlx5_ifc with DEVX UID bits

2018-09-20 Thread Or Gerlitz
On Thu, Sep 20, 2018 at 9:35 PM, Leon Romanovsky wrote: > Add DEVX information to WQ, SRQ, CQ, TRI, TIS, QP, > RQ, XRCD, PD, MKEY and MCG. typo - TRI --> TIR "DEVX information" is a bit cryptic - what does xxx_valid means for the devx use case (fw command is issued by devx process) - and what

Re: [PATCH mlx5-next v1 7/7] net/mlx5: Update mlx5_ifc with DEVX UID bits

2018-09-20 Thread Or Gerlitz
On Thu, Sep 20, 2018 at 9:35 PM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Add DEVX information to WQ, SRQ, CQ, TRI, TIS, QP, > RQ, XRCD, PD, MKEY and MCG. > > Signed-off-by: Leon Romanovsky > --- > include/linux/mlx5/mlx5_ifc.h | 67 > +++ > 1

IT Decision Makers Across the Globe

2018-09-20 Thread beverly . bruce
Hello, Hope all is well! We are a database organization. We provide business executives' contact information. Below, I've included a few examples: Industry-Specific Lists: Agriculture, Business Services, Chambers of Commerce, Cities, Towns & Municipalities, Construction, Consumer

Re: [PATCH net] af_key: free SKBs under RCU protection

2018-09-20 Thread stranche
I do not believe the changelog or the patch makes sense. Having skb still referencing a socket prevents this socket being released. If you think about it, what would prevent the freeing happening _before_ the rcu_read_lock() in pfkey_broadcast() ? Maybe the correct fix is that

[PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Song Liu
The NIC driver should only enable interrupts when napi_complete_done() returns true. This patch adds the check for ixgbe. Cc: sta...@vger.kernel.org # 4.10+ Cc: Jeff Kirsher Suggested-by: Eric Dumazet Signed-off-by: Song Liu --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 +++-

[PATCH mlx5-next v1 6/7] net/mlx5: Set uid as part of DCT commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of DCT commands so that the firmware can manage the DCT object in a secured way. That will enable using a DCT that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon

[PATCH mlx5-next v1 7/7] net/mlx5: Update mlx5_ifc with DEVX UID bits

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Add DEVX information to WQ, SRQ, CQ, TRI, TIS, QP, RQ, XRCD, PD, MKEY and MCG. Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 67 +++ 1 file changed, 43 insertions(+), 24 deletions(-) diff --git

[PATCH mlx5-next v1 5/7] net/mlx5: Set uid as part of SRQ commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of SRQ commands so that the firmware can manage the SRQ object in a secured way. That will enable using an SRQ that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon

[PATCH mlx5-next v1 2/7] net/mlx5: Set uid as part of QP commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of QP commands so that the firmware can manage the QP object in a secured way. That will enable using a QP that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky

[PATCH rdma-next v1 0/7] Preparation to DevX extension series

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Changelog v0->v1: * Update commit messages * Split DevX series to small sub-series. * Change static initialization from {0} to be {} --- From Yishai, Set uid as part of various IB commands so that the firmware can manage the IB object in a secured way. The

[PATCH mlx5-next v1 1/7] net/mlx5: Set uid as part of CQ commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of CQ commands so that the firmware can manage the CQ object in a secured way. The firmware should mark this CQ with the given uid so that it can be used later on only by objects with the same uid. Upon DEVX flows that use this CQ (e.g. create QP command),

[PATCH mlx5-next v1 3/7] net/mlx5: Set uid as part of RQ commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of RQ commands so that the firmware can manage the RQ object in a secured way. That will enable using an RQ that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky

[PATCH mlx5-next v1 4/7] net/mlx5: Set uid as part of SQ commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of SQ commands so that the firmware can manage the SQ object in a secured way. That will enable using an SQ that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky

Re: [PATCH net] sctp: update dst pmtu with the correct daddr

2018-09-20 Thread David Miller
From: Xin Long Date: Thu, 20 Sep 2018 17:27:28 +0800 > When processing pmtu update from an icmp packet, it calls .update_pmtu > with sk instead of skb in sctp_transport_update_pmtu. > > However for sctp, the daddr in the transport might be different from > inet_sock->inet_daddr or

[PATCH net-next 0/3] bnx2x: enhancements

2018-09-20 Thread Shahed Shaikh
From: Shahed Shaikh Hi Dave, This series adds below changes - - support for VF spoof-check configuration through .ndo_set_vf_spoofchk. - workaround for MFW bug regarding unexpected bandwidth notifcation in single function mode. - supply VF link status as part of get VF config handling.

[PATCH net-next 1/3] bnx2x: Add VF spoof-checking configuration

2018-09-20 Thread Shahed Shaikh
Add support for `ndo_set_vf_spoofchk' to allow PF control over its VF spoof-checking configuration. Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 1 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +

[PATCH net-next 2/3] bnx2x: Ignore bandwidth attention in single function mode

2018-09-20 Thread Shahed Shaikh
From: Shahed Shaikh This is a workaround for FW bug - MFW generates bandwidth attention in single function mode, which is only expected to be generated in multi function mode. This undesired attention in SF mode results in incorrect HW configuration and resulting into Tx timeout. Signed-off-by:

[PATCH net-next 3/3] bnx2x: Provide VF link status in ndo_get_vf_config

2018-09-20 Thread Shahed Shaikh
From: Shahed Shaikh Provide current link status of VF in ndo_get_vf_config handler. Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH net-next] net/tls: Add support for async encryption of records for performance

2018-09-20 Thread David Miller
From: Vakul Garg Date: Wed, 19 Sep 2018 20:51:35 +0530 > This patch enables encryption of multiple records in parallel when an > async capable crypto accelerator is present in system. This seems to be trading off zero copy with async support. Async crypto device support is not the common case

Re: [PATCH bpf-next] samples/bpf: fix compilation failure

2018-09-20 Thread Song Liu
On Thu, Sep 20, 2018 at 12:53 AM Prashant Bhole wrote: > > following commit: > commit d58e468b1112 ("flow_dissector: implements flow dissector BPF hook") > added struct bpf_flow_keys which conflicts with the struct with > same name in sockex2_kern.c and sockex3_kern.c > > similar to commit: >

Re: [RFC 4/5] netlink: prepare validate extack setting for recursion

2018-09-20 Thread Marcelo Ricardo Leitner
On Thu, Sep 20, 2018 at 10:14:10AM +0200, Johannes Berg wrote: > Anyway - we got into this discussion because of all the extra recursion > stuff I was adding. With the change suggested by David we don't need > that now at all, so I guess it'd be better to propose a patch if you (or > perhaps I

Re: [Patch net-next] ipv4: initialize ra_mutex in inet_init_net()

2018-09-20 Thread Cong Wang
On Thu, Sep 20, 2018 at 2:04 AM Kirill Tkhai wrote: > > On 20.09.2018 0:28, Cong Wang wrote: > You added me to CC, so you probably want to know my opinion about this. > Since it's not a real problem fix, but just a refactoring, I say you > my opinion, how this refactoring may be made better. If

Re: [PATCH 2/3] net: Register af_inet_ops earlier

2018-09-20 Thread Cong Wang
On Thu, Sep 20, 2018 at 2:12 AM Kirill Tkhai wrote: > > This function just initializes locks and defaults. > Let register it before other pernet operation, > since some of them potentially may relay on that. > > Signed-off-by: Kirill Tkhai It adds no benefits but potential risks on error path

Re: [PATCH 3/3] ipv4: initialize ra_mutex in inet_init_net()

2018-09-20 Thread Cong Wang
On Thu, Sep 20, 2018 at 2:12 AM Kirill Tkhai wrote: > > From: Cong Wang > > ra_mutex is a IPv4 specific mutex, it is inside struct netns_ipv4, > but its initialization is in the generic netns code, setup_net(). > > Move it to IPv4 specific net init code, inet_init_net(). > > Fixes: d9ff3049739e

Re: [PATCH net-next 4/5] ipv6: do not drop vrf udp multicast packets

2018-09-20 Thread Mike Manning
On 20/09/2018 14:02, Paolo Abeni wrote: > Hi, > > On Thu, 2018-09-20 at 09:58 +0100, Mike Manning wrote: >> diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c >> index 108f5f88ec98..fc60f297d95b 100644 >> --- a/net/ipv6/ip6_input.c >> +++ b/net/ipv6/ip6_input.c >> @@ -325,9 +325,12 @@ static

Re: [PATCH v2 0/2] hv_netvsc: associate VF and PV device by serial number

2018-09-20 Thread Stephen Hemminger
On Thu, 20 Sep 2018 15:18:20 +0100 Lorenzo Pieralisi wrote: > On Fri, Sep 14, 2018 at 12:54:55PM -0700, Stephen Hemminger wrote: > > The Hyper-V implementation of PCI controller has concept of 32 bit serial > > number > > (not to be confused with PCI-E serial number). This value is sent in the

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

2018-09-20 Thread Jason Gunthorpe
On Thu, Sep 20, 2018 at 07:40:39PM +0300, Leon Romanovsky wrote: > > > The protection is done with global device_lock because it is used in > > > allocation and deallocation phases. At this stage, this lock is not > > > busy and easily can be moved to be per-device, once it will be needed. > > >

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

2018-09-20 Thread Leon Romanovsky
On Thu, Sep 20, 2018 at 09:15:41AM -0600, Jason Gunthorpe wrote: > On Thu, Sep 20, 2018 at 02:21:58PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Prepare IB device name field to rename operation by ensuring that all > > accesses to it are protected with lock and users don't

Re: [RFC bpf-next 4/4] tools/bpf: handle EOPNOTSUPP when map lookup is failed

2018-09-20 Thread Jakub Kicinski
On Thu, 20 Sep 2018 14:04:19 +0900, Prashant Bhole wrote: > On 9/20/2018 12:29 AM, Jakub Kicinski wrote: > > On Wed, 19 Sep 2018 16:51:43 +0900, Prashant Bhole wrote: > >> Let's add a check for EOPNOTSUPP error when map lookup is failed. > >> Also in case map doesn't support lookup, the output

Re: [PATCH] PCI: hv: Fix return value check in hv_pci_assign_slots()

2018-09-20 Thread Lorenzo Pieralisi
[+DaveM, netdev] Removed erroneously added disclaimer, apologies. On Thu, Sep 20, 2018 at 06:40:31AM +, Wei Yongjun wrote: > In case of error, the function pci_create_slot() returns ERR_PTR() and > never returns NULL. The NULL test in the return value check should be > replaced with

Re: [PATCH] PCI: hv: Fix return value check in hv_pci_assign_slots()

2018-09-20 Thread Lorenzo Pieralisi
[+DaveM, netdev] On Thu, Sep 20, 2018 at 06:40:31AM +, Wei Yongjun wrote: > In case of error, the function pci_create_slot() returns ERR_PTR() and > never returns NULL. The NULL test in the return value check should be > replaced with IS_ERR(). > > Fixes: a15f2c08c708 ("PCI: hv: support

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

2018-09-20 Thread Jason Gunthorpe
On Thu, Sep 20, 2018 at 02:21:58PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Prepare IB device name field to rename operation by ensuring that all > accesses to it are protected with lock and users don't see part of name. Oh dear, no, that isn't going to work, there is too much

RE: [PATCH v2 1/5] netlink: remove NLA_NESTED_COMPAT

2018-09-20 Thread David Laight
From: Johannes Berg > Sent: 19 September 2018 20:49 > This isn't used anywhere, so we might as well get rid of it. > > Reviewed-by: David Ahern > Signed-off-by: Johannes Berg > --- > include/net/netlink.h | 2 -- > lib/nlattr.c | 11 --- > 2 files changed, 13 deletions(-) >

Re: [PATCH RFT net-next 0/2] net: phy: Eliminate unnecessary soft

2018-09-20 Thread Andrew Lunn
On Tue, Sep 18, 2018 at 06:35:03PM -0700, Florian Fainelli wrote: > Hi all, > > This patch series eliminates unnecessary software resets of the PHY. > This should hopefully not break anybody's hardware; but I would > appreciate testing to make sure this is is the case. > > Sorry for this long

Re: [PATCH] smc: generic netlink family should be __ro_after_init

2018-09-20 Thread David Miller
From: Johannes Berg Date: Thu, 20 Sep 2018 09:27:30 +0200 > From: Johannes Berg > > The generic netlink family is only initialized during module init, > so it should be __ro_after_init like all other generic netlink > families. > > Signed-off-by: Johannes Berg Looks good, applied.

Re: [PATCH net] mlxsw: spectrum: Bump required firmware version

2018-09-20 Thread David Miller
From: Ido Schimmel Date: Thu, 20 Sep 2018 09:31:45 +0300 > From: Petr Machata > > MC-aware mode was introduced to mlxsw in commit 7b8195306694 ("mlxsw: > spectrum: > Configure MC-aware mode on mlxsw ports") and fixed up later in commit > 3a3539cd3632 ("mlxsw: spectrum_buffers: Set up a

Re: [PATCH net-next 00/13] mlxsw: Further MC-awareness configuration

2018-09-20 Thread David Miller
From: Ido Schimmel Date: Thu, 20 Sep 2018 09:21:23 +0300 > Petr says: > > Due to an issue in Spectrum chips, when unicast traffic shares the same > queue as BUM traffic, and there is congestion, the BUM traffic is > admitted to the queue anyway, thus pushing out all UC traffic. In order > to

Re: [PATCH bpf-next 2/2] xsk: fix bug when trying to use both copy and zero-copy on one queue id

2018-09-20 Thread Jakub Kicinski
On Thu, 20 Sep 2018 11:17:17 +0200, Magnus Karlsson wrote: > On Wed, Sep 19, 2018 at 9:18 AM Magnus Karlsson wrote: > > On Wed, Sep 19, 2018 at 3:58 AM Jakub Kicinski wrote: > > > > > > On Tue, 18 Sep 2018 10:22:11 -0700, Y Song wrote: > > > > > +/* The umem is stored both in the _rx struct

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

2018-09-20 Thread Steve Wise
On 9/20/2018 6:21 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Prepare IB device name field to rename operation by ensuring that all > accesses to it are protected with lock and users don't see part of name. > > The protection is done with global device_lock because it is used in >

Re: [PATCH 00/21] SMMU enablement for NXP LS1043A and LS1046A

2018-09-20 Thread Laurentiu Tudor
On 20.09.2018 14:49, Robin Murphy wrote: > On 20/09/18 11:38, Laurentiu Tudor wrote: >> >> >> On 19.09.2018 17:37, Robin Murphy wrote: >>> On 19/09/18 15:18, Laurentiu Tudor wrote: Hi Robin, On 19.09.2018 16:25, Robin Murphy wrote: > Hi Laurentiu, > > On 19/09/18

Re: [PATCH v2 0/2] hv_netvsc: associate VF and PV device by serial number

2018-09-20 Thread Lorenzo Pieralisi
On Fri, Sep 14, 2018 at 12:54:55PM -0700, Stephen Hemminger wrote: > The Hyper-V implementation of PCI controller has concept of 32 bit serial > number > (not to be confused with PCI-E serial number). This value is sent in the > protocol > from the host to indicate SR-IOV VF device is attached

Re: [PATCH net] sctp: update dst pmtu with the correct daddr

2018-09-20 Thread Marcelo Ricardo Leitner
On Thu, Sep 20, 2018 at 05:27:28PM +0800, Xin Long wrote: > When processing pmtu update from an icmp packet, it calls .update_pmtu > with sk instead of skb in sctp_transport_update_pmtu. > > However for sctp, the daddr in the transport might be different from > inet_sock->inet_daddr or

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-09-20 Thread Jakub Kicinski
On Thu, 20 Sep 2018 09:14:08 +0200, Eelco Chaudron wrote: > Is there anything else blocking from getting this into net-next? > > I still think this patch is beneficial for the full user experience, and > I’ve got requests from QA and others for this. Not from my perspective, the numbers look

Re: array bounds warning in xfrm_output_resume

2018-09-20 Thread Florian Westphal
David Ahern wrote: > > $ make O=kbuild/perf -j 24 -s > > In file included from /home/dsa/kernel-3.git/include/linux/kernel.h:10:0, > > from /home/dsa/kernel-3.git/include/linux/list.h:9, > > from /home/dsa/kernel-3.git/include/linux/module.h:9, > >

Re: [PATCH perf 3/3] tools/perf: recognize and process RECORD_MMAP events for bpf progs

2018-09-20 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 20, 2018 at 10:36:17AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Sep 19, 2018 at 03:39:35PM -0700, Alexei Starovoitov escreveu: > > Recognize JITed bpf prog load/unload events. > > Add/remove kernel symbols accordingly. > > > > Signed-off-by: Alexei Starovoitov > > --- > >

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-20 Thread Peter Zijlstra
On Thu, Sep 20, 2018 at 10:25:45AM -0300, Arnaldo Carvalho de Melo wrote: > PeterZ provided a patch introducing PERF_RECORD_MUNMAP, went nowhere due > to having to cope with munmapping parts of existing mmaps, etc. > > I'm still more in favour of introduce PERF_RECORD_MUNMAP, even if for > now it

Re: [PATCH][next-next][v2] netlink: avoid to allocate full skb when sending to many devices

2018-09-20 Thread Eric Dumazet
On 09/20/2018 06:43 AM, Eric Dumazet wrote: > > And lastly this patch looks way too complicated to me. > You probably can write something much simpler. Something like : diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-09-20 Thread Michal Kubecek
On Wed, Sep 19, 2018 at 05:06:25PM +0100, Edward Cree wrote: > Instead of commas, just have them as separate argvs. > > The parsing state machine might look heavyweight, but it makes it easy to add > more parameters later and distinguish parameter names from encoding names. > > Suggested-by:

Re: [PATCH][next-next][v2] netlink: avoid to allocate full skb when sending to many devices

2018-09-20 Thread Eric Dumazet
On 09/20/2018 01:54 AM, Li RongQing wrote: > if skb->head is vmalloc address, when this skb is delivered, full > allocation for this skb is required, if there are many devices, > the full allocation will be called for every devices > > now if it is vmalloc, allocate a new skb, whose data is

Re: [PATCH v2 2/2] hv_netvsc: pair VF based on serial number

2018-09-20 Thread Lorenzo Pieralisi
On Fri, Sep 14, 2018 at 12:54:57PM -0700, Stephen Hemminger wrote: > Matching network device based on MAC address is problematic > since a non VF network device can be creted with a duplicate MAC > address causing confusion and problems. The VMBus API does provide > a serial number that is a

Re: [PATCH v2 2/4] dt-bindings: net: qcom: Add binding for shared mdio bus

2018-09-20 Thread Timur Tabi
On 9/19/18 10:20 AM, Andrew Lunn wrote: I suspect that is not going to be easy. Last time i looked, the ACPI standard had nothing about MDIO busses or PHYs. Marcin Wojtas did some work in this area a while back for the mvpp2, but if i remember correctly, he worked around this by simply not

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-20 Thread Peter Zijlstra
On Thu, Sep 20, 2018 at 10:44:24AM +0200, Peter Zijlstra wrote: > On Wed, Sep 19, 2018 at 03:39:34PM -0700, Alexei Starovoitov wrote: > > void bpf_prog_kallsyms_del(struct bpf_prog *fp) > > { > > + unsigned long symbol_start, symbol_end; > > + /* mmap_record.filename cannot be NULL and has

Re: [PATCH perf 3/3] tools/perf: recognize and process RECORD_MMAP events for bpf progs

2018-09-20 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 19, 2018 at 03:39:35PM -0700, Alexei Starovoitov escreveu: > Recognize JITed bpf prog load/unload events. > Add/remove kernel symbols accordingly. > > Signed-off-by: Alexei Starovoitov > --- > tools/perf/util/machine.c | 27 +++ > tools/perf/util/symbol.c |

Re: [PATCH net] af_key: free SKBs under RCU protection

2018-09-20 Thread Eric Dumazet
On 09/19/2018 05:18 PM, Sean Tranchetti wrote: > pfkey_broadcast() can make calls to pfkey_broadcast_one() which > will clone or copy the passed in SKB. This new SKB will be assigned > the sock_rfree() function as its destructor, which requires that > the socket reference the SKB contains is

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-20 Thread Andrew Lunn
> 1. net-next: cf7d97e1e54d ("net: mdio: remove duplicated include from > mdio_bus.c") > > # mii-tool -vv eth0 > Using SIOCGMIIPHY=0x8947 > eth0: no link > registers for MII PHY 0: > 1140 7949 0022 1622 0d81 c1e1 000f > 0300 3000 >

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-20 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 20, 2018 at 10:44:24AM +0200, Peter Zijlstra escreveu: > On Wed, Sep 19, 2018 at 03:39:34PM -0700, Alexei Starovoitov wrote: > > void bpf_prog_kallsyms_del(struct bpf_prog *fp) > > { > > + unsigned long symbol_start, symbol_end; > > + /* mmap_record.filename cannot be NULL and

Re: [PATCH net-next 4/5] ipv6: do not drop vrf udp multicast packets

2018-09-20 Thread Paolo Abeni
Hi, On Thu, 2018-09-20 at 09:58 +0100, Mike Manning wrote: > diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c > index 108f5f88ec98..fc60f297d95b 100644 > --- a/net/ipv6/ip6_input.c > +++ b/net/ipv6/ip6_input.c > @@ -325,9 +325,12 @@ static int ip6_input_finish(struct net *net, struct sock

[RFC PATCH iproute2-next 2/3] rdma: Introduce command execution helper with required device name

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky In contradiction to various show commands, the set command explicitly requires to use device name as an argument. Provide new command execution helper which enforces it. Signed-off-by: Leon Romanovsky --- rdma/rdma.h | 1 + rdma/utils.c | 10 ++ 2 files

[RFC PATCH iproute2-next 1/3] rdma: Update kernel include file to support IB device renaming

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Bring kernel header file changes upto commit 908b44308eda ("RDMA/nldev: Allow IB device rename through RDMA netlink") Signed-off-by: Leon Romanovsky --- rdma/include/uapi/rdma/rdma_netlink.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[RFC PATCH iproute2-next 3/3] rdma: Add an option to rename IB device interface

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Enrich rdmatool with an option to rename IB devices, the command interface follows Iproute2 convention: "rdma dev set [OLD-DEVNAME] name NEW-DEVNAME" Signed-off-by: Leon Romanovsky --- rdma/dev.c | 35 +++ 1 file changed, 35 insertions(+)

[RFC PATCH iproute2-next 0/3] rdma: IB device rename

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is comprehensive part of kernel series posted earlier. The kernel part is not accepted yet, so first patch will have different commit message with different commit SHA1. This is why it is marked as RFC. An example: [leonro@server /]$ lspci |grep -i Ether 00:08.0

[PATCH rdma-next 3/5] RDMA: Convert IB drivers to name allocation routine

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Move internal implementation of device name to the IB/core. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/device.c | 5 - drivers/infiniband/hw/bnxt_re/main.c | 6 +- drivers/infiniband/hw/cxgb3/iwch_provider.c| 5 -

[PATCH rdma-next 2/5] net/smc: Use IB device index instead of name

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky IB device name is not stable and will be possible to rename in the following patches, update SMC code to use IB index as a stable identification. Signed-off-by: Leon Romanovsky --- net/smc/smc_diag.c | 6 +++--- net/smc/smc_pnet.c | 27 --- 2

[PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Prepare IB device name field to rename operation by ensuring that all accesses to it are protected with lock and users don't see part of name. The protection is done with global device_lock because it is used in allocation and deallocation phases. At this stage, this lock

[PATCH rdma-next 4/5] RDMA/core: Implement IB device rename function

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Generic implementation of IB device rename function. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/core_priv.h | 1 + drivers/infiniband/core/device.c| 23 +++ 2 files changed, 24 insertions(+) diff --git

[PATCH rdma-next 5/5] RDMA/nldev: Allow IB device rename through RDMA netlink

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Provide an option to rename IB device name through RDMA netlink and limit it to users with ADMIN capability only. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 33 + include/uapi/rdma/rdma_netlink.h | 3 ++- 2

[PATCH rdma-next 0/5] IB device rename support

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series introduce long-waiting feature - "IB device rename". Such feature gives and option to rename user visible IB device name from vendor specific name (e.g. mlx5_0) to anything else. The user space component through rdmatool will follow this series.

Re: [PATCH iproute2 v2 0/3] testsuite: make alltests fixes

2018-09-20 Thread Luca Boccassi
On Thu, 2018-09-20 at 01:36 +0200, Petr Vorel wrote: > Hi, > > here are simply fixes to restore 'make alltests'. > Currently it does not run. > > Kind regards, > Petr > > Petr Vorel (3): >   testsuite: Fix missing generate_nlmsg >   testsuite: Generate generate_nlmsg when needed >   testsuite:

[PATCH net] sctp: update dst pmtu with the correct daddr

2018-09-20 Thread Xin Long
When processing pmtu update from an icmp packet, it calls .update_pmtu with sk instead of skb in sctp_transport_update_pmtu. However for sctp, the daddr in the transport might be different from inet_sock->inet_daddr or sk->sk_v6_daddr, which is used to update or create the route cache. The

Re: [PATCH bpf-next 2/2] xsk: fix bug when trying to use both copy and zero-copy on one queue id

2018-09-20 Thread Magnus Karlsson
On Wed, Sep 19, 2018 at 9:18 AM Magnus Karlsson wrote: > > On Wed, Sep 19, 2018 at 3:58 AM Jakub Kicinski > wrote: > > > > On Tue, 18 Sep 2018 10:22:11 -0700, Y Song wrote: > > > > +/* The umem is stored both in the _rx struct and the _tx struct as we > > > > do > > > > + * not know if the

[PATCH net-next 0/3] Refactorings on af_inet pernet initialization

2018-09-20 Thread Kirill Tkhai
This patch set makes several cleanups around inet_init_net(). --- Cong Wang (1): ipv4: initialize ra_mutex in inet_init_net() Kirill Tkhai (2): net: Remove inet_exit_net() net: Register af_inet_ops earlier net/core/net_namespace.c |1 - net/ipv4/af_inet.c | 13

[PATCH 2/3] net: Register af_inet_ops earlier

2018-09-20 Thread Kirill Tkhai
This function just initializes locks and defaults. Let register it before other pernet operation, since some of them potentially may relay on that. Signed-off-by: Kirill Tkhai --- net/ipv4/af_inet.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4/af_inet.c

[PATCH 3/3] ipv4: initialize ra_mutex in inet_init_net()

2018-09-20 Thread Kirill Tkhai
From: Cong Wang ra_mutex is a IPv4 specific mutex, it is inside struct netns_ipv4, but its initialization is in the generic netns code, setup_net(). Move it to IPv4 specific net init code, inet_init_net(). Fixes: d9ff3049739e ("net: Replace ip_ra_lock with per-net mutex") Signed-off-by: Cong

[PATCH 1/3] net: Remove inet_exit_net()

2018-09-20 Thread Kirill Tkhai
This function does nothing, and since ops_exit_list() checks for NULL ->exit method, we do not need stub here. Signed-off-by: Kirill Tkhai --- net/ipv4/af_inet.c |5 - 1 file changed, 5 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 1fbe2f815474..f4ecbe0aaf1a

Re: [Patch net-next] ipv4: initialize ra_mutex in inet_init_net()

2018-09-20 Thread Kirill Tkhai
On 20.09.2018 0:28, Cong Wang wrote: > On Wed, Sep 19, 2018 at 1:25 AM Kirill Tkhai wrote: >> >> On 18.09.2018 23:17, Cong Wang wrote: >>> On Mon, Sep 17, 2018 at 12:25 AM Kirill Tkhai wrote: In inet_init() the order of registration is: ip_mr_init();

CONGRATULATIONS:

2018-09-20 Thread WINNING AWARD
This is to inform you that you are among the Ten lucky winners of Category A. Hence we do believe with your winning prize, you will continue to be active to the Google search engine/ ancillary services. Google is now the biggest search engine worldwide and in an effort to make sure that it

[PATCH net-next 0/5] vrf: allow simultaneous service instances in default and other VRFs

2018-09-20 Thread Mike Manning
Services currently have to be VRF-aware if they are using an unbound socket. One cannot have multiple service instances running in the default and other VRFs for services that are not VRF-aware and listen on an unbound socket. This is because there is no way of isolating packets received in the

[PATCH net-next 2/5] ipv6: allow link-local and multicast packets inside vrf

2018-09-20 Thread Mike Manning
Packets that are multicast or to link-local addresses are not enslaved to the vrf of the socket that they are received on. This is needed for NDISC, but breaks applications that rely on receiving such packets when in a VRF. Also to make IPv6 consistent with IPv4 which does handle multicast packets

  1   2   >