Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On 9/27/18 3:36 PM, Cong Wang wrote: > On Thu, Sep 27, 2018 at 2:16 PM Eric Dumazet wrote: >> >> >> >> On 09/27/2018 01:42 PM, Cong Wang wrote: >>> It is clearly a copy-n-paste. >>> >>> Signed-off-by: Cong Wang >>> --- >>> net/sched/cls_api.c | 2 +- >>> 1 file changed, 1 insertion(+), 1

Re: [PATCH net] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

On Thu, 2018-09-27 at 21:08 +, justin.l...@dell.com wrote: > The new command (NCSI_CMD_SEND_CMD) is added to allow user space application > to send NC-SI command to the network card. > Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and > response. > > The work flow is

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

On Thu, Sep 27, 2018 at 11:35:39PM +0200, Jason A. Donenfeld wrote: > Hi Eric, > > On Thu, Sep 27, 2018 at 8:29 PM Eric Biggers wrote: > > Why is Herbert Xu's existing crypto tree being circumvented, especially for > > future patches (the initial merge isn't quite as important as that's a > >

[PATCH net-next] geneve: fix ttl inherit type

Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit. We should define it as a flag and use nla_put_flag to export this opiton. Fixes: 52d0d404d39dd ("geneve: add ttl inherit support") Reported-by: Phil Sutter Signed-off-by: Hangbin Liu --- drivers/net/geneve.c | 6

Re: [PATCH net-next v6 23/23] net: WireGuard secure network tunnel

On Fri, Sep 28, 2018 at 12:37 AM Jason A. Donenfeld wrote: > Will do. v7 will include the wg_ prefix. $ nm *.o | while read a b c; do [[ $b == T ]] && echo $c; done | grep -v ^wg_ cleanup_module init_module Success.

[PATCH net] vxlan: use nla_put_flag for ttl inherit

Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit. We should define it as a flag and use nla_put_flag to export this opiton. Fixes: 8fd780698745b ("vxlan: fill ttl inherit info") Reported-by: Phil Sutter Signed-off-by: Hangbin Liu --- drivers/net/vxlan.c | 8

Re: [PATCH iproute2-next] geneve: fix ttl inherit behavior

On Thu, Sep 27, 2018 at 11:08:36AM +0200, Phil Sutter wrote: > On Thu, Sep 27, 2018 at 03:27:37PM +0800, Hangbin Liu wrote: > > Currently when we add geneve with "ttl inherit", we set ttl to 0, which > > is actually use whatever default value instead of inherit the inner > > protocol's ttl value.

Re: [PATCH resend] can: rcar_can: convert to SPDX identifiers

Hi Marc > > From: Kuninori Morimoto > > > > This patch updates license to use SPDX-License-Identifier > > instead of verbose license text. > > > > Signed-off-by: Kuninori Morimoto > > Reviewed-by: Simon Horman > > Wolfram Sang has already supplied a similar patch, but not for Makefile >

Re: WARN_ON in TLP causing RT throttling

On 09/27/2018 05:16 PM, stran...@codeaurora.org wrote: > Hi Yuchung, > > Based on the dumps we were able to get, it appears that TFO was not used in > this case. > We also tried some local experiments where we dropped incoming SYN packets > after already > successful TFO connections on the

Re: WARN_ON in TLP causing RT throttling

On 2018-09-27 13:14, Yuchung Cheng wrote: On Wed, Sep 26, 2018 at 5:09 PM, Eric Dumazet wrote: On 09/26/2018 04:46 PM, stran...@codeaurora.org wrote: > Hi Eric, > > Someone recently reported a crash to us on the 4.14.62 kernel where excessive > WARNING prints were spamming the logs and

Re: [PATCH net V2] vhost-vsock: fix use after free

On Fri, Sep 28, 2018 at 07:37:37AM +0800, Jason Wang wrote: > > > On 2018年09月28日 01:04, Michael S. Tsirkin wrote: > > On Thu, Sep 27, 2018 at 08:22:04PM +0800, Jason Wang wrote: > > > The access of vsock is not protected by vhost_vsock_lock. This may > > > lead to use after free since

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

On 2018年09月27日 21:53, Willem de Bruijn wrote: On Thu, Sep 27, 2018 at 4:51 AM Jason Wang wrote: On 2018年09月14日 12:46, Willem de Bruijn wrote: I'm not sure I get this. If we don't enable tx napi, we tend to delay TX interrupt if we found the ring is about to full to avoid interrupt storm,

Re: [PATCH net V2] vhost-vsock: fix use after free

On 2018年09月28日 01:04, Michael S. Tsirkin wrote: On Thu, Sep 27, 2018 at 08:22:04PM +0800, Jason Wang wrote: The access of vsock is not protected by vhost_vsock_lock. This may lead to use after free since vhost_vsock_dev_release() may free the pointer at the same time. Fix this by holding

[PATCHv3 bpf-next 00/12] Add socket lookup support

This series proposes a new helper for the BPF API which allows BPF programs to perform lookups for sockets in a network namespace. This would allow programs to determine early on in processing whether the stack is expecting to receive the packet, and perform some action (eg drop, forward

[PATCHv3 bpf-next 04/12] bpf: Add PTR_TO_SOCKET verifier type

Teach the verifier a little bit about a new type of pointer, a PTR_TO_SOCKET. This pointer type is accessed from BPF through the 'struct bpf_sock' structure. Signed-off-by: Joe Stringer --- v2: Reuse reg_type_mismatch() in more places Reduce the number of passes at convert_ctx_access() v3:

[PATCHv3 bpf-next 08/12] selftests/bpf: Generalize dummy program types

Don't hardcode the dummy program types to SOCKET_FILTER type, as this prevents testing bpf_tail_call in conjunction with other program types. Instead, use the program type specified in the test case. Signed-off-by: Joe Stringer --- tools/testing/selftests/bpf/test_verifier.c | 31

[PATCHv3 bpf-next 02/12] bpf: Simplify ptr_min_max_vals adjustment

An upcoming commit will add another two pointer types that need very similar behaviour, so generalise this function now. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- kernel/bpf/verifier.c | 22 ++---

[PATCHv3 bpf-next 05/12] bpf: Macrofy stack state copy

An upcoming commit will need very similar copy/realloc boilerplate, so refactor the existing stack copy/realloc functions into macros to simplify it. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- kernel/bpf/verifier.c | 106 -- 1 file

[PATCHv3 bpf-next 01/12] bpf: Add iterator for spilled registers

Add this iterator for spilled registers, it concentrates the details of how to get the current frame's spilled registers into a single macro while clarifying the intention of the code which is calling the macro. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov ---

[PATCHv3 bpf-next 11/12] selftests/bpf: Add C tests for reference tracking

Add some tests that demonstrate and test the balanced lookup/free nature of socket lookup. Section names that start with "fail" represent programs that are expected to fail verification; all others should succeed. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- v3: Rebase against

[PATCHv3 bpf-next 12/12] Documentation: Describe bpf reference tracking

Document the new pointer types in the verifier and how the pointer ID tracking works to ensure that references which are taken are later released. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- Documentation/networking/filter.txt | 64 + 1 file

[PATCHv3 bpf-next 07/12] bpf: Add helper to retrieve socket in BPF

This patch adds new BPF helper functions, bpf_sk_lookup_tcp() and bpf_sk_lookup_udp() which allows BPF programs to find out if there is a socket listening on this host, and returns a socket pointer which the BPF program can then access to determine, for instance, whether to forward or drop

[PATCHv3 bpf-next 03/12] bpf: Generalize ptr_or_null regs check

This check will be reused by an upcoming commit for conditional jump checks for sockets. Refactor it a bit to simplify the later commit. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- kernel/bpf/verifier.c | 43 +-- 1 file changed, 25

[PATCHv3 bpf-next 09/12] selftests/bpf: Add tests for reference tracking

reference tracking: leak potential reference reference tracking: leak potential reference on stack reference tracking: leak potential reference on stack 2 reference tracking: zero potential reference reference tracking: copy and zero potential references reference tracking: release reference

[PATCHv3 bpf-next 06/12] bpf: Add reference tracking to verifier

Allow helper functions to acquire a reference and return it into a register. Specific pointer types such as the PTR_TO_SOCKET will implicitly represent such a reference. The verifier must ensure that these references are released exactly once in each path through the program. To achieve this,

[PATCHv3 bpf-next 10/12] libbpf: Support loading individual progs

Allow the individual program load to be invoked. This will help with testing, where a single ELF may contain several sections, some of which denote subprograms that are expected to fail verification, along with some which are expected to pass verification. By allowing programs to be iterated and

Re: KMSAN: uninit-value in __dev_mc_add

Hello, Eric, all, > I dunno, your patch looks quite not the right fix. I agree, it looks more like a dirty hack. Unfortunately, I lack the deep expertise in the network stack subsystem, so I've posted the patch to, sort of, start a discussion and probably get some hints. > If TUN is able to

Re: [PATCH] netfilter: check if the socket netns is correct.

On Thu, Sep 27, 2018 at 07:58:24PM -0300, Flavio Leitner wrote: > On Thu, Sep 27, 2018 at 01:46:29PM -0700, Guenter Roeck wrote: > > Hi Flavio, > > > > On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote: > > > Netfilter assumes that if the socket is present in the skb, then > > > it

[PATCH] cfg80211: fix use-after-free in reg_process_hint()

reg_process_hint_country_ie() can free regulatory_request and return REG_REQ_ALREADY_SET. We shouldn't use regulatory_request after it's called. KASAN error was observed when this happens. BUG: KASAN: use-after-free in reg_process_hint+0x839/0x8aa [cfg80211] Read of size 4 at addr

[PATCH 07/11] net: remove 1 always zero parameter from ip6_redirect_no_header()

From: Maciej Żenczykowski (the parameter in question is mark) Signed-off-by: Maciej Żenczykowski --- include/net/ip6_route.h | 3 +-- net/ipv6/ndisc.c| 2 +- net/ipv6/route.c| 4 +--- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/include/net/ip6_route.h

[PATCH 05/11] net: ip6_redirect() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 9cb024451fc5..e148d197d628 100644 ---

[PATCH 11/11] net: inet6_rtm_getroute() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 9aca81772c93..aca6a84de794 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -4819,7 +4819,7

[PATCH 06/11] net: ip6_redirect_no_header() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index e148d197d628..dd8c04f253d5 100644 ---

[PATCH 08/11] net: ip6_update_pmtu() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 27f1260e053a..a87b79574a91 100644 ---

[PATCH 09/11] net: rtmsg_to_fib6_config() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index

[PATCH 10/11] net: rtm_to_fib6_config() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index b8fece1d6021..9aca81772c93 100644

[PATCH 04/11] net: ip6_multipath_l3_keys() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index d28f83e01593..9cb024451fc5 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1981,12

[PATCH 03/11] net: fib_multipath_hash() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv4/route.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 048919713f4e..17953a52fbd0 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1821,12

[PATCH 01/11] net: ip_rt_get_source() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv4/route.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index dce2ed66ebe1..02482b71498b 100644

[PATCH 02/11] net: inet_rtm_getroute() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv4/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 02482b71498b..048919713f4e 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2780,7 +2780,7

Re: [PATCH] netfilter: check if the socket netns is correct.

On Thu, Sep 27, 2018 at 01:46:29PM -0700, Guenter Roeck wrote: > Hi Flavio, > > On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote: > > Netfilter assumes that if the socket is present in the skb, then > > it can be used because that reference is cleaned up while the skb > > is

[PATCH net-next 4/5] net: systemport: Be drop monitor friendly while re-allocating headroom

During bcm_sysport_insert_tsb() make sure we differentiate a SKB headroom re-allocation failure from the normal swap and replace path. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 2/5] net: systemport: Utilize bcm_sysport_set_features() during resume/open

During driver resume and open, the HW may have lost its context/state, utilize bcm_sysport_set_features() to make sure we do restore the correct set of features that were previously configured. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 14 +++--- 1

[PATCH net-next 1/5] net: systemport: Refactor bcm_sysport_set_features()

In preparation for unconditionally enabling TX and RX checksum offloads, refactor bcm_sysport_set_features() a bit such that __netdev_update_features() during register_netdev() can make sure that features are correctly programmed during network device registration. Since we can now be called

[PATCH net-next 5/5] net: systemport: Add software counters to track reallocations

When inserting the TSB, keep track of how many times we had to do it and if there was a failure in doing so, this helps profile the driver for possibly incorrect headroom settings. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 5 +

[PATCH net-next 3/5] net: systemport: Turn on offloads by default

We can turn on the RX/TX checksum offloads by default and make sure that those are properly reflected back to e.g: stacked devices such as VLAN or DSA. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH net-next 0/5] net: systemport: Turn on offloads by

Hi David, Up until now, we had added all the code necessary to turn on RX/TX checksum offloads at runtime, but there is no reason why they have to be disabled by default given that this gives a slight performance improvement. Florian Fainelli (5): net: systemport: Refactor

Re: [PATCH net-next v6 23/23] net: WireGuard secure network tunnel

Hi Andrew, Thanks for following up with this. On Thu, Sep 27, 2018 at 3:15 AM Andrew Lunn wrote: > I know you have been concentrating on the crypto code, so i'm not > expecting too many changes at the moment in the network code. I should be addressing things in parallel, actually, so I'm happy

Re: KMSAN: uninit-value in __dev_mc_add

On Thu, Sep 27, 2018 at 2:30 PM Vladis Dronov wrote: > > Hello, > > This report is actually for the same bug which was reported in: > > https://syzkaller.appspot.com/bug?id=088efeac32fdde781038a777a63e436c0d4d7036 > > The note there that the bug was fixed by "Commits: net: fix uninit-value in >

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On 09/27/2018 02:36 PM, Cong Wang wrote: > I don't understand what you mean by changing ip command, you must > mean tc command, but still, I have no idea about how restarting failed > syscall could be related to my patch and why we need to restart anything > here. If the refcnt goes to 0, it

[PATCH bpf-next] bpf: permit CGROUP_DEVICE programs accessing helper bpf_get_current_cgroup_id()

Currently, helper bpf_get_current_cgroup_id() is not permitted for CGROUP_DEVICE type of programs. If the helper is used in such cases, the verifier will log the following error: 0: (bf) r6 = r1 1: (69) r7 = *(u16 *)(r6 +0) 2: (85) call bpf_get_current_cgroup_id#80 unknown func

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On Thu, Sep 27, 2018 at 2:16 PM Eric Dumazet wrote: > > > > On 09/27/2018 01:42 PM, Cong Wang wrote: > > It is clearly a copy-n-paste. > > > > Signed-off-by: Cong Wang > > --- > > net/sched/cls_api.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

Hi Eric, On Thu, Sep 27, 2018 at 8:29 PM Eric Biggers wrote: > Why is Herbert Xu's existing crypto tree being circumvented, especially for > future patches (the initial merge isn't quite as important as that's a > one-time > event)? I like being able to check out cryptodev to test upcoming

Re: KMSAN: uninit-value in __dev_mc_add

Hello, This report is actually for the same bug which was reported in: https://syzkaller.appspot.com/bug?id=088efeac32fdde781038a777a63e436c0d4d7036 The note there that the bug was fixed by "Commits: net: fix uninit-value in __hw_addr_add_ex()" is wrong. A C-reproducer from the 2nd syzkaller

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On 09/27/2018 01:42 PM, Cong Wang wrote: > It is clearly a copy-n-paste. > > Signed-off-by: Cong Wang > --- > net/sched/cls_api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 3de47e99b788..8dd7f8af6d54 100644 >

Re: [PATCH v3 bpf-next 00/10] bpf: per-cpu cgroup local storage

On 09/26/2018 01:33 PM, Roman Gushchin wrote: > This patchset implements per-cpu cgroup local storage and provides > an example how per-cpu and shared cgroup local storage can be used > for efficient accounting of network traffic. > > v3->v2: > 1) incorporated Song's feedback > 2) rebased on

[PATCH net] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface (msg)

Re: [PATCH v3] PCI: Reprogram bridge prefetch registers on resume

[+cc LKML] On Tue, Sep 18, 2018 at 04:32:44PM -0500, Bjorn Helgaas wrote: > On Thu, Sep 13, 2018 at 11:37:45AM +0800, Daniel Drake wrote: > > On 38+ Intel-based Asus products, the nvidia GPU becomes unusable > > after S3 suspend/resume. The affected products include multiple > > generations of

Re: [PATCH] netfilter: check if the socket netns is correct.

Hi Flavio, On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote: > Netfilter assumes that if the socket is present in the skb, then > it can be used because that reference is cleaned up while the skb > is crossing netns. > > We want to change that to preserve the socket reference in a

[Patch net-next] net_sched: fix a crash in tc_new_tfilter()

When tcf_block_find() fails, it already rollbacks the qdisc refcnt, so its caller doesn't need to clean up this again. Avoid calling qdisc_put() again by resetting qdisc to NULL for callers. Reported-by: syzbot+37b8770e6d5a8220a...@syzkaller.appspotmail.com Fixes: e368fdb61d8e ("net: sched: use

[Patch net-next] net_sched: fix an extack message in tcf_block_find()

It is clearly a copy-n-paste. Signed-off-by: Cong Wang --- net/sched/cls_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 3de47e99b788..8dd7f8af6d54 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -655,7

Re: [PATCH v2 07/22] soc/fsl/bman_portals: defer probe after bman's probe

On Wed, Sep 26, 2018 at 8:26 AM wrote: > > From: Laurentiu Tudor > > A crash in bman portal probing could not be triggered (as is the case > with qman portals) but it does make calls [1] into the bman driver so > lets make sure the bman portal probing happens after bman's. > > [1]

Re: [PATCH v2 06/22] soc/fsl/qman_portals: defer probe after qman's probe

On Wed, Sep 26, 2018 at 8:26 AM wrote: > > From: Laurentiu Tudor > > Defer probe of qman portals after qman probing. This fixes the crash > below, seen on NXP LS1043A SoCs: > > Unable to handle kernel NULL pointer dereference at virtual address > 0004 > Mem abort info: > ESR =

Re: [PATCH v2 05/22] soc/fsl/qbman: add APIs to retrieve the probing status

On Wed, Sep 26, 2018 at 8:26 AM wrote: > > From: Laurentiu Tudor > > Add a couple of new APIs to check the probing status of qman and bman: > 'int bman_is_probed()' and 'int qman_is_probed()'. > They return the following values. > * 1 if qman/bman were probed correctly > * 0 if qman/bman

Re: [PATCH net-next 0/7] rtnetlink: add RTM_GETADDR2

On September 27, 2018 10:24:36 PM GMT+02:00, David Ahern wrote: >On 9/27/18 11:58 AM, Christian Brauner wrote: >> Various userspace programs (e.g. iproute2) have sent RTM_GETADDR >> requests with struct ifinfomsg. This is wrong and should have been >> struct ifaddrmsg all along as mandated by

Re: [PATCH net-next 0/7] rtnetlink: add RTM_GETADDR2

On 9/27/18 11:58 AM, Christian Brauner wrote: > Various userspace programs (e.g. iproute2) have sent RTM_GETADDR > requests with struct ifinfomsg. This is wrong and should have been > struct ifaddrmsg all along as mandated by the manpages. However, dump > requests so far didn't parse the netlink

RE: bug: 'ethtool -m' reports spurious alarm & warning threshold values for QSFP28 transceivers

Update for posterity- Mellanox support provided a work-around of using mlxcables instead of ethtool to read alarm/warning info for an installed transceiver. I was told that a couple of their engineers are currently looking into the discrepancy between threshold reporting by mlxcables and

Re: [PATCH v2 08/22] soc/fsl/qbman_portals: add APIs to retrieve the probing status

On Wed, Sep 26, 2018 at 8:26 AM wrote: > > From: Laurentiu Tudor > > Add a couple of new APIs to check the probing status of the required > cpu bound qman and bman portals: > 'int bman_portals_probed()' and 'int qman_portals_probed()'. > They return the following values. > * 1 if qman/bman

[PATCH net-next] net: nixge: Address compiler warnings when building for i386

Address compiler warning reported by kbuild autobuilders when building for i386 as a result of dma_addr_t size on different architectures. warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Fixes: 7e8d5755be0e ("net: nixge: Add support for 64-bit platforms")

Re: [PATCH v2 net-next 2/2] dt-bindings: net: add support for Microchip KSZ9131 Ethernet PHY

On Thu, Sep 27, 2018 at 04:16:55PM -0400, Yuiko Oshino wrote: > Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY > > Signed-off-by: Yuiko Oshino > --- > .../devicetree/bindings/net/micrel-ksz90x1.txt | 29 > +- > 1 file changed, 28 insertions(+), 1

Re: [PATCH net-next] tcp: up initial rmem to 128KB and SYN rwin to around 64KB

On Thu, Sep 27, 2018 at 11:21 AM, Yuchung Cheng wrote: > Previously TCP initial receive buffer is ~87KB by default and > the initial receive window is ~29KB (20 MSS). This patch changes > the two numbers to 128KB and ~64KB (rounding down to the multiples > of MSS) respectively. The patch also

Re: kernel 4.18.5 Realtek 8111G network adapter stops responding under high system load

Hi, Heiner Kallweit's patch seems to resolve the problem. The machine was under high disk and network io pressure today and networking was perfectly stable. Bye, David Arendt On 9/25/18 11:03 PM, Heiner Kallweit wrote: > On 19.09.2018 06:12, David Arendt wrote: >> Hi, >> >> Thanks for the

Re: [PATCH v2 net-next 0/2] Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY

On 09/27/2018 01:15 PM, Yuiko Oshino wrote: > This is the initial driver for Microchip KSZ9131 10/100/1000 Ethernet PHY > > v2: > - Creating a series from two related patches. When people give you Acked-by or Reviewed-by tags in prior versions, it is usually a good practice to add them to your

[PATCH v2 net-next 2/2] dt-bindings: net: add support for Microchip KSZ9131 Ethernet PHY

Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY Signed-off-by: Yuiko Oshino --- .../devicetree/bindings/net/micrel-ksz90x1.txt | 29 +- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git

[PATCH v2 net-next 1/2] net: phy: micrel: add Microchip KSZ9131 inital driver

Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY Signed-off-by: Yuiko Oshino --- drivers/net/phy/micrel.c | 32 +--- include/linux/micrel_phy.h | 1 + 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/micrel.c

[PATCH v2 net-next 0/2] Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY

This is the initial driver for Microchip KSZ9131 10/100/1000 Ethernet PHY v2: - Creating a series from two related patches. Yuiko Oshino (2): net: phy: micrel: add Microchip KSZ9131 inital driver dt-bindings: net: add support for Microchip KSZ9131 Ethernet PHY

Re: [PATCH bpf-next 0/5] Introduce libbpf_attach_type_by_name

On 09/27/2018 12:24 AM, Andrey Ignatov wrote: > This patch set introduces libbpf_attach_type_by_name function in libbpf to > identify attach type by section name. > > This is useful to avoid writing same logic over and over again in user > space applications that leverage libbpf. > > Patch 1 has

Re: WARN_ON in TLP causing RT throttling

On Wed, Sep 26, 2018 at 5:09 PM, Eric Dumazet wrote: > > > > On 09/26/2018 04:46 PM, stran...@codeaurora.org wrote: > > Hi Eric, > > > > Someone recently reported a crash to us on the 4.14.62 kernel where > > excessive > > WARNING prints were spamming the logs and causing watchdog bites. The

Re: [PATCH v2 bpf-next] bpf: test_bpf: add init_net to dev for flow_dissector

On 09/27/2018 06:42 PM, Willem de Bruijn wrote: > On Thu, Sep 27, 2018 at 12:40 PM Eric Dumazet wrote: >> On 09/27/2018 09:34 AM, Song Liu wrote: >>> Latest changes in __skb_flow_dissect() assume skb->dev has valid nd_net. >>> However, this is not true for test_bpf. As a result, test_bpf.ko

Re: [PATCH net-next] net: dsa: b53: Fix build with B53_SRAB enabled and B53_SERDES=m

On 09/27/2018 03:02 AM, Arnd Bergmann wrote: > When B53_SERDES is a loadable module, a built-in srab driver still > cannot reach it, so the previous fix is incomplete: > > b53_srab.c:(.text+0x3f4): undefined reference to `b53_serdes_init' > drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe64):

RE: bug: 'ethtool -m' reports spurious alarm & warning threshold values for QSFP28 transceivers

I greatly appreciate everyone's work on this. Thank you to all. I've had Mellanox support case # 00508027 open for this issue, and just now requested an updated driver from them to resolve, explaining that really smart ethtool developers figured out this was due to the Mellanox driver not

Re: [PATCH net 01/11] netpoll: do not test NAPI_STATE_SCHED in poll_one_napi()

> On Sep 27, 2018, at 11:25 AM, Michael Chan wrote: > > On Thu, Sep 27, 2018 at 9:32 AM Eric Dumazet wrote: >> >> Since we do no longer require NAPI drivers to provide >> an ndo_poll_controller(), napi_schedule() has not been done >> before poll_one_napi() invocation. >> >> So testing

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

On Tue, Sep 25, 2018 at 04:55:59PM +0200, Jason A. Donenfeld wrote: > > It is intended that this entire patch series enter the kernel through > DaveM's net-next tree. Subsequently, WireGuard patches will go through > DaveM's net-next tree, while Zinc patches will go through Greg KH's tree. >

pull request: bluetooth 2018-09-27

Hi Dave, Here's one more Bluetooth fix for 4.19, fixing the handling of an attempt to unpair a device while pairing is in progress. Let me know if there are any issues pulling. Thanks. Johan --- The following changes since commit 3f32d0be6c16b902b687453c962d17eea5b8ea19: tipc: lock wakeup &

Re: [PATCH net 01/11] netpoll: do not test NAPI_STATE_SCHED in poll_one_napi()

On Thu, Sep 27, 2018 at 9:32 AM Eric Dumazet wrote: > > Since we do no longer require NAPI drivers to provide > an ndo_poll_controller(), napi_schedule() has not been done > before poll_one_napi() invocation. > > So testing NAPI_STATE_SCHED is likely to cause early returns. > > While we are at

[PATCH net-next] tcp: up initial rmem to 128KB and SYN rwin to around 64KB

Previously TCP initial receive buffer is ~87KB by default and the initial receive window is ~29KB (20 MSS). This patch changes the two numbers to 128KB and ~64KB (rounding down to the multiples of MSS) respectively. The patch also simplifies the calculations s.t. the two numbers are directly

Re: KASAN: use-after-free Read in tcf_block_find

On Thu, Sep 27, 2018 at 7:50 PM, Cong Wang wrote: > On Thu, Sep 27, 2018 at 1:11 AM Dmitry Vyukov wrote: >> >> Would a stack trace for call_rcu be helpful here? I have this idea for >> a long time, but never get around to implementing it: >> https://bugzilla.kernel.org/show_bug.cgi?id=198437 > >

[PATCH net-next 0/7] rtnetlink: add RTM_GETADDR2

Various userspace programs (e.g. iproute2) have sent RTM_GETADDR requests with struct ifinfomsg. This is wrong and should have been struct ifaddrmsg all along as mandated by the manpages. However, dump requests so far didn't parse the netlink message that was sent and succeeded even when a wrong

[PATCH net-next 1/7] rtnetlink: add RTM_GETADDR2

Various userspace programs (e.g. iproute2) have sent RTM_GETADDR requests with struct ifinfomsg. This is wrong and should have been struct ifaddrmsg all along as mandated by the manpages. However, dump requests so far didn't parse the netlink message that was sent and succeeded even when a wrong

[PATCH net-next 2/7] ipv4: add RTM_GETADDR2

Various userspace programs (e.g. iproute2) have sent RTM_GETADDR requests with struct ifinfomsg. This is wrong and should have been struct ifaddrmsg all along as mandated by the manpages. However, dump requests so far didn't parse the netlink message that was sent and succeeded even when a wrong

[PATCH net-next 5/7] phonet: add RTM_GETADDR2

Various userspace programs (e.g. iproute2) have sent RTM_GETADDR requests with struct ifinfomsg. This is wrong and should have been struct ifaddrmsg all along as mandated by the manpages. However, dump requests so far didn't parse the netlink message that was sent and succeeded even when a wrong

[PATCH net-next 6/7] selinux: add RTM_GETADDR2

Various userspace programs (e.g. iproute2) have sent RTM_GETADDR requests with struct ifinfomsg. This is wrong and should have been struct ifaddrmsg all along as mandated by the manpages. However, dump requests so far didn't parse the netlink message that was sent and succeeded even when a wrong

[PATCH net-next 3/7] ipv6: add RTM_GETADDR2

Various userspace programs (e.g. iproute2) have sent RTM_GETADDR requests with struct ifinfomsg. This is wrong and should have been struct ifaddrmsg all along as mandated by the manpages. However, dump requests so far didn't parse the netlink message that was sent and succeeded even when a wrong

[PATCH net-next 7/7] rtnetlink: enable RTM_GETADDR2

Various userspace programs (e.g. iproute2) have sent RTM_GETADDR requests with struct ifinfomsg. This is wrong and should have been struct ifaddrmsg all along as mandated by the manpages. However, dump requests so far didn't parse the netlink message that was sent and succeeded even when a wrong

[PATCH net-next 4/7] decnet: add RTM_GETADDR2

Various userspace programs (e.g. iproute2) have sent RTM_GETADDR requests with struct ifinfomsg. This is wrong and should have been struct ifaddrmsg all along as mandated by the manpages. However, dump requests so far didn't parse the netlink message that was sent and succeeded even when a wrong

Re: KASAN: use-after-free Read in tcf_block_find

On Thu, Sep 27, 2018 at 1:11 AM Dmitry Vyukov wrote: > > Would a stack trace for call_rcu be helpful here? I have this idea for > a long time, but never get around to implementing it: > https://bugzilla.kernel.org/show_bug.cgi?id=198437 Yes. Generally speaking, showing backtrace of call_rcu() or

RE: [PATCH] net/ncsi: Add NCSI OEM command for FB Tiogapass

> Thanks for the overview. We look forward to your patches; please > include the same cc list as this series. > I think it makes sense to have some OEM NCSI handing purely in the > kenrel. This would allow eg. the MAC address of an interface to be > correct at boot, without requiring userspace

Re: [PATCH net-next v6 07/23] zinc: ChaCha20 ARM and ARM64 implementations

On Thu, Sep 27, 2018 at 6:27 PM Andy Lutomirski wrote: > I would add another consideration: if you can get better latency with > negligible overhead (0.1%? 0.05%), then that might make sense too. For > example, it seems plausible that checking need_resched() every few blocks > adds basically

Re: [PATCH net V2] vhost-vsock: fix use after free

On Thu, Sep 27, 2018 at 08:22:04PM +0800, Jason Wang wrote: > The access of vsock is not protected by vhost_vsock_lock. This may > lead to use after free since vhost_vsock_dev_release() may free the > pointer at the same time. > > Fix this by holding the lock during the access. > > Reported-by:

[PATCH] qed: fix spelling mistake "b_cb_registred" -> "b_cb_registered"

From: Colin Ian King Trivial fix to spelling mistake struct field name, rename it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 12 ++-- drivers/net/ethernet/qlogic/qed/qed_ll2.h | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

  1   2   >