Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread David Miller
From: Al Viro Date: Mon, 8 Oct 2018 06:45:15 +0100 > Er... Both are due to missing in the very beginning of the series (well, on > top of "net: sched: cls_u32: fix hnode refcounting") commit All dependencies like this must be explicitly stated. And in such situations you actually should wait

Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread Al Viro
On Sun, Oct 07, 2018 at 09:25:01PM -0700, David Miller wrote: > From: Jamal Hadi Salim > Date: Sun, 7 Oct 2018 12:38:00 -0400 > > > Various improvements from Al. > > Please submit changes that actually are compile tested: > > CC [M] net/sched/cls_u32.o > net/sched/cls_u32.c: In function

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Richard Cochran
On Sun, Oct 07, 2018 at 02:20:33PM -0700, Richard Cochran wrote: > On Sun, Oct 07, 2018 at 11:14:05PM +0200, Andrew Lunn wrote: > > I'm currently thinking register_mii_timestamper() should take a netdev > > argument, and the net_device structure should gain a struct > > mii_timestamper. We are

Re: [PATCH] net: vhost: remove bad code line

2018-10-07 Thread David Miller
From: xiangxia.m@gmail.com Date: Sun, 7 Oct 2018 18:41:50 -0700 > From: Tonghao Zhang > > Signed-off-by: Tonghao Zhang Applied.

Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 7 Oct 2018 12:38:00 -0400 > Various improvements from Al. Please submit changes that actually are compile tested: CC [M] net/sched/cls_u32.o net/sched/cls_u32.c: In function ‘u32_delete’: net/sched/cls_u32.c:674:6: error: ‘root_ht’ undeclared (first use in

Re: [PATCH v8 05/15] octeontx2-af: Add mailbox IRQ and msg handlers

2018-10-07 Thread David Miller
From: sunil.kovv...@gmail.com Date: Sun, 7 Oct 2018 20:29:14 +0530 > + req_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start); I commented in the previous patch series version, for patch #4, that such casts are unnecessary and should be removed. You are in for a very long review

Re: [PATCH net 1/1] net: sched: cls_u32: fix hnode refcounting

2018-10-07 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 7 Oct 2018 07:40:17 -0400 > From: Al Viro > > cls_u32.c misuses refcounts for struct tc_u_hnode - it counts references > via ->hlist and via ->tp_root together. u32_destroy() drops the former > and, in case when there had been links, leaves the sucker on the

[PATCH v2 net-next 17/23] net/namespace: Update rtnl_net_dumpid for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update rtnl_net_dumpid for strict data checking. If the flag is set, the dump request is expected to have an rtgenmsg struct as the header which has the family as the only element. No data may be appended. Signed-off-by: David Ahern --- net/core/net_namespace.c | 6 ++ 1

[PATCH v2 net-next 06/23] netlink: Add new socket option to enable strict checking on dumps

2018-10-07 Thread David Ahern
From: David Ahern Add a new socket option, NETLINK_DUMP_STRICT_CHK, that userspace can use via setsockopt to request strict checking of headers and attributes on dump requests. To get dump features such as kernel side filtering based on data in the header or attributes appended to the dump

[PATCH v2 net-next 08/23] net/ipv6: Update inet6_dump_addr for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update inet6_dump_addr for strict data checking. If the flag is set, the dump request is expected to have an ifaddrmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the

[PATCH v2 net-next 13/23] rtnetlink: Update ipmr_rtm_dumplink for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update ipmr_rtm_dumplink for strict data checking. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/ipv4/ipmr.c |

[PATCH v2 net-next 01/23] netlink: Pass extack to dump handlers

2018-10-07 Thread David Ahern
From: David Ahern Declare extack in netlink_dump and pass to dump handlers via netlink_callback. Add any extack message after the dump_done_errno allowing error messages to be returned. This will be useful when strict checking is done on dump requests, returning why the dump fails EINVAL.

[PATCH v2 net-next 04/23] netlink: Add strict version of nlmsg_parse and nla_parse

2018-10-07 Thread David Ahern
From: David Ahern nla_parse is currently lenient on message parsing, allowing type to be 0 or greater than max expected and only logging a message "netlink: %d bytes leftover after parsing attributes in process `%s'." if the netlink message has unknown data at the end after parsing. What

[PATCH v2 net-next 02/23] netlink: Add extack message to nlmsg_parse for invalid header length

2018-10-07 Thread David Ahern
From: David Ahern Give a user a reason why EINVAL is returned in nlmsg_parse. Signed-off-by: David Ahern Acked-by: Christian Brauner --- include/net/netlink.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/net/netlink.h b/include/net/netlink.h index

[PATCH v2 net-next 07/23] net/ipv4: Update inet_dump_ifaddr for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update inet_dump_ifaddr for strict data checking. If the flag is set, the dump request is expected to have an ifaddrmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the

[PATCH v2 net-next 21/23] net/bridge: Update br_mdb_dump for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update br_mdb_dump for strict data checking. If the flag is set, the dump request is expected to have a br_port_msg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/bridge/br_mdb.c |

[PATCH v2 net-next 15/23] net/neighbor: Update neigh_dump_info for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update neigh_dump_info for strict data checking. If the flag is set, the dump request is expected to have an ndmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the data

[PATCH v2 net-next 00/23] rtnetlink: Add support for rigid checking of data in dump request

2018-10-07 Thread David Ahern
From: David Ahern There are many use cases where a user wants to influence what is returned in a dump for some rtnetlink command: one is wanting data for a different namespace than the one the request is received and another is limiting the amount of data returned in the dump to a specific set

[PATCH v2 net-next 20/23] net: Update netconf dump handlers for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update inet_netconf_dump_devconf, inet6_netconf_dump_devconf, and mpls_netconf_dump_devconf for strict data checking. If the flag is set, the dump request is expected to have an netconfmsg struct as the header. The struct only has the family member and no attributes can be

[PATCH v2 net-next 03/23] net: Add extack to nlmsg_parse

2018-10-07 Thread David Ahern
From: David Ahern Make sure extack is passed to nlmsg_parse where easy to do so. Most of these are dump handlers and leveraging the extack in the netlink_callback. Signed-off-by: David Ahern Acked-by: Christian Brauner --- net/core/devlink.c | 2 +- net/core/neighbour.c

[PATCH v2 net-next 11/23] rtnetlink: Update rtnl_stats_dump for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update rtnl_stats_dump for strict data checking. If the flag is set, the dump request is expected to have an if_stats_msg struct as the header. All elements of the struct are expected to be 0 except filter_mask which must be non-0 (legacy behavior). No attributes are supported.

[PATCH v2 net-next 09/23] rtnetlink: Update rtnl_dump_ifinfo for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update rtnl_dump_ifinfo for strict data checking. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the

[PATCH v2 net-next 18/23] net/fib_rules: Update fib_nl_dumprule for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update fib_nl_dumprule for strict data checking. If the flag is set, the dump request is expected to have fib_rule_hdr struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/core/fib_rules.c

[PATCH v2 net-next 16/23] net/neighbor: Update neightbl_dump_info for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update neightbl_dump_info for strict data checking. If the flag is set, the dump request is expected to have an ndtmsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/core/neighbour.c

[PATCH v2 net-next 10/23] rtnetlink: Update rtnl_bridge_getlink for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update rtnl_bridge_getlink for strict data checking. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence

[PATCH v2 net-next 05/23] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-07 Thread David Ahern
From: David Ahern Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid into it. Signed-off-by: David Ahern Acked-by: Christian Brauner --- net/ipv6/addrconf.c | 57 - 1 file changed, 30 insertions(+), 27 deletions(-) diff

[PATCH v2 net-next 12/23] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update inet6_dump_ifinfo for strict data checking. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern ---

[PATCH v2 net-next 14/23] rtnetlink: Update fib dumps for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Add helper to check netlink message for route dumps. If the strict flag is set the dump request is expected to have an rtmsg struct as the header. All elements of the struct are expected to be 0 with the exception of rtm_flags (which is used by both ipv4 and ipv6 dumps) and no

[PATCH v2 net-next 19/23] net/ipv6: Update ip6addrlbl_dump for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update ip6addrlbl_dump for strict data checking. If the flag is set, the dump request is expected to have an ifaddrlblmsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern ---

[PATCH v2 net-next 22/23] rtnetlink: Move input checking for rtnl_fdb_dump to helper

2018-10-07 Thread David Ahern
From: David Ahern Move the existing input checking for rtnl_fdb_dump into a helper, valid_fdb_dump_legacy. This function will retain the current logic that works around the 2 headers that userspace has been allowed to send up to this point. Signed-off-by: David Ahern --- net/core/rtnetlink.c

[PATCH v2 net-next 23/23] rtnetlink: Update rtnl_fdb_dump for strict data checking

2018-10-07 Thread David Ahern
From: David Ahern Update rtnl_fdb_dump for strict data checking. If the flag is set, the dump request is expected to have an ndmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is taken as a request to influence the data

Re: [RFC PATCH bpf-next v4 4/7] bpf: add bpf queue and stack maps

2018-10-07 Thread Mauricio Vasquez
On 10/04/2018 10:40 PM, Mauricio Vasquez wrote: On 10/04/2018 06:57 PM, Alexei Starovoitov wrote: On Thu, Oct 04, 2018 at 07:12:44PM +0200, Mauricio Vasquez B wrote: Implement two new kind of maps that support the peek, push and pop operations. A use case for this is to keep track of a

Re: [PATCH] net/packet: fix packet drop as of virtio gso

2018-10-07 Thread Jason Wang
On 2018年09月29日 23:41, Jianfeng Tan wrote: When we use raw socket as the vhost backend, a packet from virito with gso offloading information, cannot be sent out in later validaton at xmit path, as we did not set correct skb->protocol which is further used for looking up the gso function. Hi:

can not sync master interface when bond1 box connected with another bond1 box

2018-10-07 Thread Yi Li
Hi guys, I encountered this problem when using bonding with mode1. I have two linux box, they both have two nics, and i setup these two nics with bond1 mode on each linux box. And then I connected these two linux box with each other. And then , I found , sometimes, Box A

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Richard Cochran
On Sun, Oct 07, 2018 at 09:54:00PM +0200, Andrew Lunn wrote: > Sure, but things have moved on since then. I was curious about this. Based on your uses cases, I guess that you mean phylib? But not much has changed AFAICT. (There is one new global function and two were removed, but that doesn't

[PATCH] net: vhost: remove bad code line

2018-10-07 Thread xiangxia . m . yue
From: Tonghao Zhang Signed-off-by: Tonghao Zhang --- drivers/vhost/net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 015abf3..ab11b2b 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -562,7 +562,6 @@ static int

Re: [PATCH net-next 19/20] net: Update netconf dump handlers for strict data checking

2018-10-07 Thread David Ahern
On 10/7/18 4:53 AM, Christian Brauner wrote: >> @@ -2076,6 +2077,21 @@ static int inet_netconf_dump_devconf(struct sk_buff >> *skb, >> struct in_device *in_dev; >> struct hlist_head *head; >> >> +if (cb->strict_check) { >> +struct netlink_ext_ack *extack = cb->extack;

Re: [PATCH net-next 15/20] net/neighbor: Update neightbl_dump_info for strict data checking

2018-10-07 Thread David Ahern
On 10/7/18 4:48 AM, Christian Brauner wrote: >> + >> static int neightbl_dump_info(struct sk_buff *skb, struct netlink_callback >> *cb) >> { >> +const struct nlmsghdr *nlh = cb->nlh; >> struct net *net = sock_net(skb->sk); >> int family, tidx, nidx = 0; >> int tbl_skip =

Re: [PATCH net-next 12/20] rtnetlink: Update ipmr_rtm_dumplink for strict data checking

2018-10-07 Thread David Ahern
On 10/7/18 4:40 AM, Christian Brauner wrote: >> @@ -2718,6 +2743,13 @@ static int ipmr_rtm_dumplink(struct sk_buff *skb, >> struct netlink_callback *cb) >> unsigned int e = 0, s_e; >> struct mr_table *mrt; >> >> +if (cb->strict_check) { >> +int err =

Re: [PATCH net-next 09/20] rtnetlink: Update rtnl_bridge_getlink for strict data checking

2018-10-07 Thread David Ahern
On 10/7/18 4:36 AM, Christian Brauner wrote: >> +if (cb->strict_check) { >> +struct ifinfomsg *ifm; >> >> -extfilt = nlmsg_find_attr(cb->nlh, sizeof(struct ifinfomsg), >> - IFLA_EXT_MASK); >> -if (extfilt) { >> -

Re: [PATCH net-next 08/20] rtnetlink: Update rtnl_dump_ifinfo for strict data checking

2018-10-07 Thread David Ahern
On 10/7/18 4:29 AM, Christian Brauner wrote: >> I thought about that, but there is so much overlap - they are mostly >> common. Besides, ifinfomsg is the header for link dumps, and ifinfomsg >> is the one that has been (ab)used for other message types, so strict >> versus lenient does not really

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Andrew Lunn
On Sun, Oct 07, 2018 at 02:07:28PM -0700, Richard Cochran wrote: > On Sun, Oct 07, 2018 at 01:59:06PM -0700, Richard Cochran wrote: > > On Sun, Oct 07, 2018 at 09:54:00PM +0200, Andrew Lunn wrote: > > > 1) phylink, not phdev. We have been pushing some MAC drivers towards > > > phylink, especially

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Richard Cochran
On Sun, Oct 07, 2018 at 11:14:05PM +0200, Andrew Lunn wrote: > The problem is you depend on skbuf->dev->phydev. phydev will be NULL. > net_device does not currently have a phylink member. Even if it did, > you end up add more and more tests looking every place a > mii_timestamper could be placed.

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Andrew Lunn
On Sun, Oct 07, 2018 at 01:59:06PM -0700, Richard Cochran wrote: > On Sun, Oct 07, 2018 at 09:54:00PM +0200, Andrew Lunn wrote: > > Sure, but things have moved on since then. > > If you have a specific suggestion on how to better implement this, > please tell us what it is. > > > I can think

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Richard Cochran
On Sun, Oct 07, 2018 at 01:59:06PM -0700, Richard Cochran wrote: > On Sun, Oct 07, 2018 at 09:54:00PM +0200, Andrew Lunn wrote: > > 1) phylink, not phdev. We have been pushing some MAC drivers towards > > phylink, especially those which support >1Gbp. > > If a phylink device appears that wants

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Richard Cochran
On Sun, Oct 07, 2018 at 09:54:00PM +0200, Andrew Lunn wrote: > Sure, but things have moved on since then. If you have a specific suggestion on how to better implement this, please tell us what it is. > I can think of three obvious use cases where this does not work: > > 1) phylink, not phdev.

Re: [PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII time stampers.

2018-10-07 Thread Andrew Lunn
On Sun, Oct 07, 2018 at 12:26:27PM -0700, Richard Cochran wrote: > On Sun, Oct 07, 2018 at 08:17:54PM +0200, Andrew Lunn wrote: > > > > + if (err == -ENOENT) > > > > + return NULL; > > > > + else if (err) > > > > + return ERR_PTR(err); > > > > + > > > > +

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Andrew Lunn
On Sun, Oct 07, 2018 at 12:15:51PM -0700, Richard Cochran wrote: > On Sun, Oct 07, 2018 at 08:27:51PM +0200, Andrew Lunn wrote: > > The mii_timestamper is generic, in the same why hwmon is generic. It > > does not matter where the time stamper is. So i'm wondering if we > > should remove the

Re: [PATCH V2 net-next 0/5] Peer to Peer One-Step time stamping

2018-10-07 Thread Richard Cochran
On Sun, Oct 07, 2018 at 10:38:18AM -0700, Richard Cochran wrote: > Changed in v2: > ~~ > - Per the v1 review, changed the modeling of MII time stamping > devices. They are no longer a kind of mdio device. Forgot to add: - Added method to callback into the driver after changes in

Re: [PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII time stampers.

2018-10-07 Thread Richard Cochran
On Sun, Oct 07, 2018 at 08:17:54PM +0200, Andrew Lunn wrote: > > > + if (err == -ENOENT) > > > + return NULL; > > > + else if (err) > > > + return ERR_PTR(err); > > > + > > > + if (args.args_count >= 1) > > > + port = args.args[0]; > > > > If it's greater than one, than it

Re: [PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII time stampers.

2018-10-07 Thread Richard Cochran
On Sun, Oct 07, 2018 at 11:14:38AM -0700, Florian Fainelli wrote: > There appears to be a binding document missing to describe what a > timerstamper provider is. Using a more specific name than > "#phandle-cells" is preferred when dealing with specific devices, e.g: > >

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Richard Cochran
On Sun, Oct 07, 2018 at 08:27:51PM +0200, Andrew Lunn wrote: > The mii_timestamper is generic, in the same why hwmon is generic. It > does not matter where the time stamper is. So i'm wondering if we > should remove the special case for a PHY timestamper, remove all the > phylib support, etc.

Re: [PATCH rdma-next 3/4] IB/mlx5: Verify that driver supports user flags

2018-10-07 Thread Jason Gunthorpe
On Sun, Oct 07, 2018 at 12:03:36PM +0300, Leon Romanovsky wrote: > From: Yonatan Cohen > > Flags sent down from user might not be supported by > running driver. > This might lead to unwanted bugs. > To solve this, added macro to test for unsupported flags. > > Signed-off-by: Yonatan Cohen >

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Florian Fainelli
On 10/7/2018 11:27 AM, Andrew Lunn wrote: On Sun, Oct 07, 2018 at 10:38:20AM -0700, Richard Cochran wrote: Currently the stack supports time stamping in PHY devices. However, there are newer, non-PHY devices that can snoop an MII bus and provide time stamps. In order to support such

Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Andrew Lunn
On Sun, Oct 07, 2018 at 10:38:20AM -0700, Richard Cochran wrote: > Currently the stack supports time stamping in PHY devices. However, > there are newer, non-PHY devices that can snoop an MII bus and provide > time stamps. In order to support such devices, this patch introduces > a new interface

Re: [PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII time stampers.

2018-10-07 Thread Andrew Lunn
On Sun, Oct 07, 2018 at 10:38:22AM -0700, Richard Cochran wrote: > When parsing a PHY node, register its time stamper, if any, and attach > the instance to the PHY device. Hi Richard This does look a lot better. Thanks for making the changes. Andrew

Re: [PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII time stampers.

2018-10-07 Thread Andrew Lunn
> > + if (err == -ENOENT) > > + return NULL; > > + else if (err) > > + return ERR_PTR(err); > > + > > + if (args.args_count >= 1) > > + port = args.args[0]; > > If it's greater than one, than it is an error, and it should be flagged > as such. > > The idea

Re: [PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII time stampers.

2018-10-07 Thread Florian Fainelli

Re: [PATCH v2 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap

2018-10-07 Thread Florian Fainelli
On 10/07/18 11:24, Pankaj Bansal wrote: > Add support for an MDIO bus multiplexer controlled by a regmap > device, like an FPGA. > > Tested on a NXP LX2160AQDS board which uses the "QIXIS" FPGA > attached to the i2c bus. > > Signed-off-by: Pankaj Bansal > --- > > Notes: > V2: > -

Re: [PATCH v2 1/2] dt-bindings: net: add MDIO bus multiplexer driven by a regmap device

2018-10-07 Thread Florian Fainelli
On 10/07/18 11:24, Pankaj Bansal wrote: > Add support for an MDIO bus multiplexer controlled by a regmap > device, like an FPGA. > > Tested on a NXP LX2160AQDS board which uses the "QIXIS" FPGA > attached to the i2c bus. > > Signed-off-by: Pankaj Bansal > --- > > Notes: > V2: > -

Re: [PATCH iproute2 net-next v3 0/6] Introduce the taprio scheduler

2018-10-07 Thread David Ahern
On 10/5/18 5:25 PM, Vinicius Costa Gomes wrote: > Hi, > ... > This is the iproute2 side of the taprio v1 series. > > Please see the kernel side cover letter for more information about how > to test this. > > Cheers, > -- > Vinicius > > Jesus Sanchez-Palencia (1): > libnetlink: Add helper

[PATCH V2 net-next 0/5] Peer to Peer One-Step time stamping

2018-10-07 Thread Richard Cochran
Changed in v2: ~~ - Per the v1 review, changed the modeling of MII time stamping devices. They are no longer a kind of mdio device. This series adds support for PTP (IEEE 1588) P2P one-step time stamping along with a driver for a hardware device that supports this. If the hardware

[PATCH V2 net-next 1/5] net: Introduce peer to peer one step PTP time stamping.

2018-10-07 Thread Richard Cochran
The 1588 standard defines one step operation for both Sync and PDelay_Resp messages. Up until now, hardware with P2P one step has been rare, and kernel support was lacking. This patch adds support of the mode in anticipation of new hardware developments. Signed-off-by: Richard Cochran ---

[PATCH V2 net-next 5/5] ptp: Add a driver for InES time stamping IP core.

2018-10-07 Thread Richard Cochran
The InES at the ZHAW offers a PTP time stamping IP core. The FPGA logic recognizes and time stamps PTP frames on the MII bus. This patch adds a driver for the core along with a device tree binding to allow hooking the driver to MII buses. Signed-off-by: Richard Cochran ---

[PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII time stampers.

2018-10-07 Thread Richard Cochran
When parsing a PHY node, register its time stamper, if any, and attach the instance to the PHY device. Signed-off-by: Richard Cochran --- drivers/net/phy/phy_device.c | 3 +++ drivers/of/of_mdio.c | 26 ++ 2 files changed, 29 insertions(+) diff --git

[PATCH V2 net-next 3/5] net: Add a layer for non-PHY MII time stamping drivers.

2018-10-07 Thread Richard Cochran
While PHY time stamping drivers can simply attach their interface directly to the PHY instance, stand alone drivers require support in order to manage their services. Non-PHY MII time stamping drivers have a control interface over another bus like I2C, SPI, UART, or via a memory mapped

[PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.

2018-10-07 Thread Richard Cochran
Currently the stack supports time stamping in PHY devices. However, there are newer, non-PHY devices that can snoop an MII bus and provide time stamps. In order to support such devices, this patch introduces a new interface to be used by both PHY and non-PHY devices. In addition, the one and

Re: [PATCH iproute2-next v2] tc: flower: expose hardware offload count

2018-10-07 Thread David Ahern
On 10/3/18 2:44 PM, Vlad Buslov wrote: > Recently flower classifier was updated to expose count of devices that > filter is offloaded to. Add support to print this counter as 'in_hw_count'. > > Signed-off-by: Vlad Buslov > Acked-by: Jiri Pirko > --- > Changes from V1 to V2: > - Change print

[PATCH net-next 08/11] net: sched: cls_u32: the tp_c argument of u32_set_parms() is always tp->data

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro It must be tc_u_common associated with that tp (i.e. tp->data). Proof: * both ->ht_up and ->tp_c are assign-once * ->tp_c of anything inserted into tp_c->hlist is tp_c * hnodes never get reinserted into the lists or moved between those, so anything found by

[PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Various improvements from Al. Al Viro (11): net: sched: cls_u32: disallow linking to root hnode net: sched: cls_u32: make sure that divisor is a power of 2 net: sched: cls_u32: get rid of unused argument of u32_destroy_key() net: sched: cls_u32: get rid of

[PATCH net-next 05/11] net: sched: cls_u32: get rid of tc_u_common ->rcu

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro unused Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim --- net/sched/cls_u32.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 810c49ac1bbe..c378168f4562 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@

[PATCH net-next 04/11] net: sched: cls_u32: get rid of tc_u_knode ->tp

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro not used anymore Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim --- net/sched/cls_u32.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index ef0f2e6ec422..810c49ac1bbe 100644 --- a/net/sched/cls_u32.c +++

[PATCH net-next 09/11] net: sched: cls_u32: get rid of tp_c

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro Both hnode ->tp_c and tp_c argument of u32_set_parms() the latter is redundant, the former - never read... Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim --- net/sched/cls_u32.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH net-next 01/11] net: sched: cls_u32: disallow linking to root hnode

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro Operation makes no sense. Nothing will actually break if we do so (depth limit in u32_classify() will prevent infinite loops), but according to maintainers it's best prohibited outright. NOTE: doing so guarantees that u32_destroy() will trigger the call of u32_destroy_hnode(); we

[PATCH net-next 06/11] net: sched: cls_u32: clean tc_u_common hashtable

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro * calculate key *once*, not for each hash chain element * let tc_u_hash() return the pointer to chain head rather than index - callers are cleaner that way. Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim --- net/sched/cls_u32.c | 24 +--- 1 file

[PATCH net-next 07/11] net: sched: cls_u32: pass tc_u_common to u32_set_parms() instead of tc_u_hnode

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro the only thing we used ht for was ht->tp_c and callers can get that without going through ->tp_c at all; start with lifting that into the callers, next commits will massage those, eventually removing ->tp_c altogether. Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim ---

[PATCH net-next 10/11] net: sched: cls_u32: keep track of knodes count in tc_u_common

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro allows to simplify u32_delete() considerably Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim --- net/sched/cls_u32.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 3d4c360f9b0c..61593bee08db 100644 ---

[PATCH net-next 02/11] net: sched: cls_u32: make sure that divisor is a power of 2

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro Tested by modifying iproute2 to to allow sending a divisor > 255 Tested-by: Jamal Hadi Salim Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim --- net/sched/cls_u32.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/sched/cls_u32.c

[PATCH net-next 11/11] net: sched: cls_u32: simplify the hell out u32_delete() emptiness check

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro Now that we have the knode count, we can instantly check if any hnodes are non-empty. And that kills the check for extra references to root hnode - those could happen only if there was a knode to carry such a link. Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim ---

[PATCH net-next 03/11] net: sched: cls_u32: get rid of unused argument of u32_destroy_key()

2018-10-07 Thread Jamal Hadi Salim
From: Al Viro Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim --- net/sched/cls_u32.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index ce55eea448a0..ef0f2e6ec422 100644 --- a/net/sched/cls_u32.c +++

Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

2018-10-07 Thread Jesper Dangaard Brouer
On Sat, 6 Oct 2018 00:05:22 +0200 Jiri Olsa wrote: > On Fri, Oct 05, 2018 at 11:44:35AM -0700, Alexei Starovoitov wrote: > > On Fri, Oct 05, 2018 at 08:14:09AM +0200, Jiri Olsa wrote: > > > On Thu, Oct 04, 2018 at 03:10:15PM -0700, Alexei Starovoitov wrote: > > > > On Thu, Oct 04, 2018 at

[PATCH v8 15/15] MAINTAINERS: Add entry for Marvell OcteonTX2 Admin Function driver

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham Added maintainers entry for Marvell OcteonTX2 SOC's RVU admin function driver. Signed-off-by: Sunil Goutham --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bb5f431..bc76b03 100644 --- a/MAINTAINERS +++

[PATCH v8 13/15] octeontx2-af: Add support for CGX link management

2018-10-07 Thread sunil . kovvuri
From: Linu Cherian CGX LMAC initialization, link status polling etc is done by low level secure firmware. For link management this patch adds a interface or communication mechanism between firmware and this kernel CGX driver. - Firmware interface specification is defined in cgx_fw_if.h. -

[PATCH v8 11/15] octeontx2-af: Add Marvell OcteonTX2 CGX driver

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham This patch adds basic template for Marvell OcteonTX2's CGX ethernet interface driver. Just the probe. RVU AF driver will use APIs exported by this driver for various things like PF to physical interface mapping, loopback mode, interface stats etc. Hence marged both drivers

[PATCH v8 07/15] octeontx2-af: Scan blocks for LFs provisioned to PF/VF

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham Scan all RVU blocks to find any 'LF to RVU PF/VF' mapping done by low level firmware. If found any, mark them as used in respective block's LF bitmap and also save mapped PF/VF's PF_FUNC info. This is done to avoid reattaching a block LF to a different RVU PF/VF.

[PATCH v8 09/15] octeontx2-af: Configure block LF's MSIX vector offset

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham Firmware configures a certain number of MSIX vectors to each of enabled RVU PF/VF. When a block LF is attached to a PF/VF, number of MSIX vectors needed by that LF are set aside (out of PF/VF's total MSIX vectors) and LF's msix_offset is configured in HW. Also added support

[PATCH v8 14/15] octeontx2-af: Register for CGX lmac events

2018-10-07 Thread sunil . kovvuri
From: Linu Cherian Added support in RVU AF driver to register for CGX LMAC link status change events from firmware and managing them. Processing part will be added in followup patches. - Introduced eventqueue for posting events from cgx lmac. Queueing mechanism will ensure that events can be

[PATCH v8 08/15] octeontx2-af: Add RVU block LF provisioning support

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham Added support for a RVU PF/VF to request AF via mailbox to attach or detach NPA/NIX/SSO/SSOW/TIM/CPT block LFs. Also supports partial detachment and modifying current LF attached count of a certian block type. Signed-off-by: Sunil Goutham ---

[PATCH v8 10/15] octeontx2-af: Reconfig MSIX base with IOVA

2018-10-07 Thread sunil . kovvuri
From: Geetha sowjanya HW interprets RVU_AF_MSIXTR_BASE address as an IOVA, hence create a IOMMU mapping for the physcial address configured by firmware and reconfig RVU_AF_MSIXTR_BASE with IOVA. Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham ---

[PATCH v8 12/15] octeontx2-af: Set RVU PFs to CGX LMACs mapping

2018-10-07 Thread sunil . kovvuri
From: Linu Cherian Each of the enabled CGX LMAC is considered a physical interface and RVU PFs are mapped to these. VFs of these SRIOV PFs will be virtual interfaces and share CGX LMAC along with PF. This mapping info will be used later on for Rx/Tx pkt steering. Signed-off-by: Linu Cherian

[PATCH v8 05/15] octeontx2-af: Add mailbox IRQ and msg handlers

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham This patch adds support for mailbox interrupt and message handling. Mapped mailbox region and registered a workqueue for message handling. Enabled mailbox IRQ of RVU PFs and registered a interrupt handler. When IRQ is triggered work is added to the mbox workqueue for msgs to

[PATCH v8 02/15] octeontx2-af: Reset all RVU blocks

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham Go through all BLKADDRs and check which ones are implemented on this silicon and do a HW reset of each implemented block. Also added all RVU AF and PF register offsets. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c| 78 ++

[PATCH v8 06/15] octeontx2-af: Convert mbox msg id check to a macro

2018-10-07 Thread sunil . kovvuri
From: Aleksey Makarov With 10's of mailbox messages expected to be handled in future, checking for message id could become a lengthy switch case. Hence added a macro to auto generate the switch case for each msg id. Signed-off-by: Aleksey Makarov Signed-off-by: Sunil Goutham ---

[PATCH v8 03/15] octeontx2-af: Gather RVU blocks HW info

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham This patch gathers NPA/NIX/SSO/SSOW/TIM/CPT RVU blocks's HW info like number of LFs. Important register offsets saved for later use to avoid code duplication for each block. A bitmap is allocated for each of the blocks which later on will be used to allocate a LF for a RVU

[PATCH v8 04/15] octeontx2-af: Add mailbox support infra

2018-10-07 Thread sunil . kovvuri
From: Aleksey Makarov This patch adds mailbox support infrastructure APIs. Each RVU device has a dedicated 64KB mailbox region shared with it's peer for communication. RVU AF has a separate mailbox region shared with each of RVU PFs and a RVU PF has a separate region shared with each of it's VF.

[PATCH v8 01/15] octeontx2-af: Add Marvell OcteonTX2 RVU AF driver

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham This patch adds basic template for Marvell OcteonTX2's resource virtualization unit (RVU) admin function (AF) driver. Just the driver registration and probe. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/Kconfig | 3 +

[PATCH v8 00/15] octeontx2-af: Add RVU Admin Function driver

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham Resource virtualization unit (RVU) on Marvell's OcteonTX2 SOC maps HW resources from the network, crypto and other functional blocks into PCI-compatible physical and virtual functions. Each functional block again has multiple local functions (LFs) for provisioning to PCI

Re: [PATCH v7 15/15] MAINTAINERS: Add entry for Marvell OcteonTX2 Admin Function driver

2018-10-07 Thread Sunil Kovvuri
On Sat, Oct 6, 2018 at 1:05 PM Joe Perches wrote: > > On Sat, 2018-10-06 at 11:36 +0530, sunil.kovv...@gmail.com wrote: > > Added maintainers entry for Marvell OcteonTX2 SOC's RVU > > admin function driver. > [] > > diff --git a/MAINTAINERS b/MAINTAINERS > [] > > @@ -8844,6 +8844,15 @@ S:

[PATCH v2 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap

2018-10-07 Thread Pankaj Bansal
Add support for an MDIO bus multiplexer controlled by a regmap device, like an FPGA. Tested on a NXP LX2160AQDS board which uses the "QIXIS" FPGA attached to the i2c bus. Signed-off-by: Pankaj Bansal --- Notes: V2: - replaced be32_to_cpup with of_property_read_u32 - incorporated

[PATCH v2 1/2] dt-bindings: net: add MDIO bus multiplexer driven by a regmap device

2018-10-07 Thread Pankaj Bansal
Add support for an MDIO bus multiplexer controlled by a regmap device, like an FPGA. Tested on a NXP LX2160AQDS board which uses the "QIXIS" FPGA attached to the i2c bus. Signed-off-by: Pankaj Bansal --- Notes: V2: - Fixed formatting error caused by using space instead of tab -

  1   2   >