[PATCHv4 net-next 10/14] net: sch: api: add extack support in qdisc_alloc

Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 2 +- net/sched/sch_generic.c | 6 -- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/include/net/sch_gener

[PATCHv4 net-next 03/14] net: sched: sch: add extack for init callback

This patch adds extack support for init callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- n

[PATCHv4 net-next 04/14] net: sched: sch: add extack for change qdisc ops

This patch adds extack support for change callback for qdisc ops structtur to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/

[PATCHv4 net-next 09/14] net: sch: api: add extack support in tcf_block_get

Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/pkt_cls.h| 6 -- net/sched/cls_api.c | 13 + net/sched/sch_atm.c | 6 -- net/sched/sch_cbq.c | 4 ++-- net/sched/sch_drr.c

[PATCHv4 net-next 12/14] net: sch: sch_cbq: add extack support

l Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/sch_cbq.c | 46 ++ 1 file changed, 34 insertions(+), 12 deletions(-) diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c index efe5bf15b031..f

[PATCHv4 net-next 11/14] net: sch: api: add extack support in qdisc_create_dflt

call an init callback which can fail by any per-qdisc specific handling. Cc: David Ahern <dsah...@gmail.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/pkt_sched.h | 3 ++- include/net/sch_generic.h |

[PATCHv4 net-next 05/14] net: sched: sch: add extack to change class

This patch adds extack support for class change callback api. This prepares to handle extack support inside each specific class implementation. Cc: David Ahern <dsah...@gmail.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com>

[PATCHv4 net-next 13/14] net: sch: sch_cbs: add extack support

l Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/sch_cbs.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/net/sched/sch_cbs.c b/net/sched/sch_cbs.c index 8bf6e163d29c..cdd96b9a27bc 100644 --- a/n

[PATCHv4 net-next 08/14] net: sch: api: add extack support in qdisc_get_rtab

Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/pkt_sched.h | 3 ++- net/sched/act_police.c | 4 ++-- net/sched/sch_api.c | 9 +++-- net/sched/sch_cbq.c | 7 --- net/sched/sch_htb.c | 6 -- net/sched

[PATCHv4 net-next 14/14] net: sch: sch_drr: add extack support

l Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/sch_drr.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/net/sched/sch_drr.c b/net/sched/sch_drr.c index bf638ce57c50..e0b0cf8a9939 100644 --- a/n

[PATCHv4 net-next 06/14] net: sched: sch: add extack for block callback

This patch adds extack support for block callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- n

[PATCHv4 net-next 07/14] net: sched: sch: add extack for graft callback

This patch adds extack support for graft callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- n

[PATCHv4 net-next 01/14] net: sched: fix coding style issues

This patch fix checkpatch issues for upcomming patches according to the sched api file. It changes mostly how to check on null pointer. Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/sch_api.c| 2 +- net/sch

[PATCHv4 net-next 00/14] net: sched: sch: introduce extack support

backs: tcf_block - Alex Alexander Aring (14): net: sched: fix coding style issues net: sched: sch_api: handle generic qdisc errors net: sched: sch: add extack for init callback net: sched: sch: add extack for change qdisc ops net: sched: sch: add extack to change class net: sched: sch: add

[PATCHv4 net-next 02/14] net: sched: sch_api: handle generic qdisc errors

This patch adds extack support for generic qdisc handling. The extack will be set deeper to each called function which is not part of netdev core api. Cc: David Ahern <dsah...@gmail.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Alexander Aring <ar...@mojatat

Re: [PATCHv3 net-next 00/14] net: sched: sch: introduce extack support

Hi, On Wed, Dec 20, 2017 at 11:32 AM, David Miller <da...@davemloft.net> wrote: > From: Alexander Aring <ar...@mojatatu.com> > Date: Mon, 18 Dec 2017 17:44:59 -0500 > >> this patch series basically add support for extack in common qdisc handling. >> Additional

[PATCHv3 net-next 07/14] net: sched: sch: add extack for graft callback

This patch adds extack support for graft callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 3 ++- net/sched/sch_atm

[PATCHv3 net-next 08/14] net: sch: api: add extack support in qdisc_get_rtab

ed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/pkt_sched.h | 3 ++- net/sched/act_police.c | 4 ++-- net/sched/sch_api.c | 9 +++-- net/sched/sch_cbq.c | 7 --- net/sched/sch_htb.c | 6 -- net/sched/sch_tbf.c | 6 -- 6 files changed, 23 inser

[PATCHv3 net-next 02/14] net: sched: sch_api: handle generic qdisc errors

This patch adds extack support for generic qdisc handling. The extack will be set deeper to each called function which is not part of netdev core api. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/sch

[PATCHv3 net-next 09/14] net: sch: api: add extack support in tcf_block_get

ed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/pkt_cls.h| 6 -- net/sched/cls_api.c | 13 + net/sched/sch_atm.c | 6 -- net/sched/sch_cbq.c | 4 ++-- net/sched/sch_drr.c | 2 +- net/sched/sch_dsmark.c | 2 +- net/sched/sch_fq_

[PATCHv3 net-next 11/14] net: sch: api: add extack support in qdisc_create_dflt

call an init callback which can fail by any per-qdisc specfic handling. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/pkt_sched.h | 3 ++- include/net/sch_generic.h | 3 ++- net/sched/sch_atm.c | 5 +++-- net/sch

[PATCHv3 net-next 12/14] net: sch: sch_cbq: add extack support

This patch adds extack support for the cbq qdisc implementation by adding NL_SET_ERR_MSG in validation of user input. Also it serves to illustrate a use case of how the infrastructure ops api changes are to be used by individual qdiscs. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Ale

[PATCHv3 net-next 14/14] net: sch: sch_drr: add extack support

This patch adds extack support for the drr qdisc implementation by adding NL_SET_ERR_MSG in validation of user input. Also it serves to illustrate a use case of how the infrastructure ops api changes are to be used by individual qdiscs. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Ale

[PATCHv3 net-next 13/14] net: sch: sch_cbs: add extack support

This patch adds extack support for the cbs qdisc implementation by adding NL_SET_ERR_MSG in validation of user input. Also it serves to illustrate a use case of how the infrastructure ops api changes are to be used by individual qdiscs. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Ale

[PATCHv3 net-next 04/14] net: sched: sch: add extack for change qdisc ops

This patch adds extack support for change callback for qdisc ops structtur to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c

[PATCHv3 net-next 05/14] net: sched: sch: add extack to change class

This patch adds extack support for class change callback api. This prepares to handle extack support inside each specific class implementation. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sch

[PATCHv3 net-next 06/14] net: sched: sch: add extack for block callback

This patch adds extack support for block callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/cls_api.c | 4 ++-- net/sched/sch_api

[PATCHv3 net-next 10/14] net: sch: api: add extack support in qdisc_alloc

ed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 2 +- net/sched/sch_generic.c | 6 -- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h index 2ea04863ea34..

[PATCHv3 net-next 03/14] net: sched: sch: add extack for init callback

This patch adds extack support for init callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 2 +- net/sched/sch_atm.

[PATCHv3 net-next 00/14] net: sched: sch: introduce extack support

s callback: init, qdisc_class_ops callbacks: change and graft - Add sch_cbs as example for qdisc_ops callback: change - Add sch_drr as example for qdisc_class ops callbacks: tcf_block - Alex Alexander Aring (14): net: sched: fix coding style issues net: sched: sch_api: handle generic qdisc errors net:

[PATCHv3 net-next 01/14] net: sched: fix coding style issues

This patch fix checkpatch issues for upcomming patches according to the sched api file. It changes mostly how to check on null pointer. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/sch_api.c| 2 +- net/sched/sch_cbq.c| 12 ++-- net/sched/sch_gred.c

Re: [PATCHv2 net-next 03/15] net: sched: sch_api: handle generic qdisc errors

Hi, On Thu, Dec 14, 2017 at 1:38 PM, Alexander Aring <ar...@mojatatu.com> wrote: > This patch adds extack support for generic qdisc handling. The extack > will be set deeper to each called function which is not part of netdev > core api. > > Cc: David Ahern <dsah...

[PATCHv2 net-next 06/15] net: sched: sch: add extack to change class

This patch adds extack support for class change callback api. This prepares to handle extack support inside each specific class implementation. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sch

[PATCHv2 net-next 02/15] lib: nlattr: set extack msg if validate_nla fails

This patch sets a generic netlink error message if the validation of the netlink attribute failed. It avoids several different settings of netlink messages by handle nla_parse_nested on error case. Suggested-by: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@moj

[PATCHv2 net-next 05/15] net: sched: sch: add extack for change qdisc ops

This patch adds extack support for change callback for qdisc ops structtur to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c

[PATCHv2 net-next 08/15] net: sched: sch: add extack for graft callback

This patch adds extack support for graft callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 3 ++- net/sched/sch_cbq

[PATCHv2 net-next 04/15] net: sched: sch: add extack for init callback

This patch adds extack support for init callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 2 +- net/sched/sch_cbq.

[PATCHv2 net-next 10/15] net: sch: api: add extack support in tcf_block_get

ed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/pkt_cls.h| 6 -- net/sched/cls_api.c | 13 + net/sched/sch_cbq.c | 4 ++-- net/sched/sch_drr.c | 2 +- net/sched/sch_dsmark.c | 2 +- net/sched/sch_fq_codel.c | 2 +- net/sched/sch_hfs

[PATCHv2 net-next 14/15] net: sch: sch_cbs: add extack support

This patch adds extack support for the cbs qdisc implementation by adding NL_SET_ERR_MSG in validation of user input. Also it serves to illustrate a use case of how the infrastructure ops api changes are to be used by individual qdiscs. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Ale

[PATCHv2 net-next 13/15] net: sch: sch_cbq: add extack support

This patch adds extack support for the cbq qdisc implementation by adding NL_SET_ERR_MSG in validation of user input. Also it serves to illustrate a use case of how the infrastructure ops api changes are to be used by individual qdiscs. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Ale

[PATCHv2 net-next 15/15] net: sch: sch_drr: add extack support

This patch adds extack support for the drr qdisc implementation by adding NL_SET_ERR_MSG in validation of user input. Also it serves to illustrate a use case of how the infrastructure ops api changes are to be used by individual qdiscs. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Ale

[PATCHv2 net-next 09/15] net: sch: api: add extack support in qdisc_get_rtab

ed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/pkt_sched.h | 3 ++- net/sched/act_police.c | 4 ++-- net/sched/sch_api.c | 9 +++-- net/sched/sch_cbq.c | 7 --- net/sched/sch_htb.c | 6 -- net/sched/sch_tbf.c | 6 -- 6 files changed, 23 inser

[PATCHv2 net-next 03/15] net: sched: sch_api: handle generic qdisc errors

This patch adds extack support for generic qdisc handling. The extack will be set deeper to each called function which is not part of netdev core api. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/sch

[PATCHv2 net-next 11/15] net: sch: api: add extack support in qdisc_alloc

ed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 5 +++-- net/sched/sch_generic.c | 6 -- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h index 2ea04863ea34..

[PATCHv2 net-next 12/15] net: sch: api: add extack support in qdisc_create_dflt

call an init callback which can fail by any per-qdisc specfic handling. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/pkt_sched.h | 3 ++- include/net/sch_generic.h | 3 ++- net/sched/sch_cbq.c | 9 + net/sch

[PATCHv2 net-next 00/15] net: sched: sch: introduce extack support

: init, qdisc_class_ops callbacks: change and graft - Add sch_cbs as example for qdisc_ops callback: change - Add sch_drr as example for qdisc_class ops callbacks: tcf_block - Alex Alexander Aring (15): net: sched: fix coding style issues lib: nlattr: set extack msg if validate_nla fails net:

[PATCHv2 net-next 07/15] net: sched: sch: add extack for block callback

This patch adds extack support for block callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/cls_api.c | 4 ++-- net/sched/sch_api

[PATCHv2 net-next 01/15] net: sched: fix coding style issues

This patch fix checkpatch issues for upcomming patches according to the sched api file. It changes mostly how to check on null pointer. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/sch_api.c| 2 +- net/sched/sch_cbq.c| 12 ++-- net/sched/sch_gred.c

Re: [PATCH net-next] net: llc: remove init_net check

Hi, On Thu, Nov 30, 2017 at 3:12 PM, Eric Dumazet wrote: > ... > > > Well, we use different netns for isolation. > > You need more changes than simply removing this check, I guess. > > __llc_sap_find() would need a per netns list, or proper netns checks. > I looked

Re: [PATCH net-next 0/6] net: sched: sch: introduce extack support

Hi, On Wed, Dec 6, 2017 at 3:40 PM, David Miller <da...@davemloft.net> wrote: > From: Alexander Aring <ar...@mojatatu.com> > Date: Wed, 6 Dec 2017 11:08:39 -0500 > >> this patch series basically add support for extack in common qdisc handling. >> Additional it ad

[PATCH net-next 0/6] net: sched: sch: introduce extack support

it reviewable. There are some above 80-chars width warnings, which I ignore because it looks more ugly otherwise. This patch-series based on patches by David Ahren which gave me some hints how to deal with extack support. Cc: David Ahern <dsah...@gmail.com> - Alex Alexander Aring (6): net:

[PATCH net-next 6/6] net: sched: sch: add extack for graft callback

This patch adds extack support for graft callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 3 ++- net/sched/sch_cbq

[PATCH net-next 5/6] net: sched: sch: add extack for block callback

This patch adds extack support for block callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/cls_api.c | 4 ++-- net/sched/sch_api

[PATCH net-next 1/6] net: sched: sch_api: handle generic qdisc errors

This patch adds extack support for generic qdisc handling. The extack will be set deeper to each called function which is not part of netdev core api. A future patchset will add per-qdisc specific changes. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@moj

[PATCH net-next 3/6] net: sched: sch: add extack for change qdisc ops

This patch adds extack support for change callback for qdisc ops structtur to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c

[PATCH net-next 4/6] net: sched: sch: add extack to change class

This patch adds extack support for class change callback api. This prepares to handle extack support inside each specific class implementation. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sch

[PATCH net-next 2/6] net: sched: sch: add extack for init callback

This patch adds extack support for init callback to prepare per-qdisc specific changes for extack. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 2 +- net/sched/sch_cbq.

[PATCH net-next 1/2] net: sched: sch_api: fix code style issues

This patch fix checkpatch issues for upcomming patches according to the sched api file. It changes checking on null pointer, remove unnecessary brackets, add variable names for parameters and adjust 80 char width. Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Ari

[PATCH net-next 0/2] net: sched: sch_api: fix coding style issues for extack

after this. - Alex Cc: David Ahern <dsah...@gmail.com> Alexander Aring (2): net: sched: sch_api: fix code style issues net: sched: sch_api: rearrange init handling include/net/sch_generic.h | 10 +++-- net/sched/sch_api.c | 97 +-- 2

[PATCH net-next 2/2] net: sched: sch_api: rearrange init handling

the same behaviour as before, just without assign err variable in if condition. It also makes the code easier to read. Reviewed-by: Jamal Hadi Salim <j...@mojatatu.com> Cc: David Ahern <dsah...@gmail.com> Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sc

[PATCH net-next] net: llc: remove init_net check

bled Linux bridges in different namespaces. The bridges are connected via veth interfaces. This patch makes STP work in such a setup. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/llc/llc_input.c | 4 1 file changed, 4 deletions(-) diff --git a/net/llc/llc_input.c b/net

[PATCH iproute2] tc: m_ife: fix match tcindex parsing

This patch changes ife_prio to ife_tcindex which is right variable to assign in the argument in this case. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- Found by inspection the code. tc/m_ife.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_ife.c b/tc/m

routing UAPI mismatch invalid state behavior?

Hi, I figure out some problem, easy to reproduce: # setup dummy $ modprobe dummy $ ip link set dummy0 up # issue $ ip route replace default via 169.254.65.37 dev dummy0 RTNETLINK answers: Network is unreachable so it will forbid me to do that, but: $ ip route replace 169.254.65.37 dev dummy0

[PATCH net-next 2/3] sched: act: ife: migrate to use per-cpu counters

This patch migrates the current counter handling which is protected by a spinlock to a per-cpu counter handling. This reduce the time where the spinlock is being held. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/act_ife.c | 29 +++-- 1 file c

[PATCH net-next 3/3] sched: act: ife: update parameters via rcu handling

This patch changes the parameter updating via RCU and not protected by a spinlock anymore. This reduce the time that the spinlock is being held. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/net/tc_act/tc_ife.h | 10 -- net/sched/act_ife.c

[PATCH net-next 0/3] sched: act: ife: UAPI checks and performance tweaks

. - I use still dereference in dump callback, so I think what I didn't got was what happened when rcu_assign_pointer will do when rcu read lock is held. I suppose the pointer will be updated, then we don't have any issue here. Alexander Aring (3): sched: act: ife: move encode/decode

[PATCH net-next 1/3] sched: act: ife: move encode/decode check to init

This patch adds the check of the two possible ife handlings encode and decode to the init callback. The decode value is for usability aspect and used in userspace code only. The current code offers encode else decode only. This patch avoids any other option than this. Signed-off-by: Alexander

Re: [RFC net 1/1] net: sched: act: fix rcu race in dump

Hi, On Tue, Oct 10, 2017 at 10:12 AM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Tue, 2017-10-10 at 08:32 -0400, Alexander Aring wrote: >> This patch fixes an issue with kfree_rcu which is not protected by RTNL >> lock. It could be that the current assigned rcu

Re: [RFC net 1/1] net: sched: act: fix rcu race in dump

Hi, On Tue, Oct 10, 2017 at 8:32 AM, Alexander Aring <ar...@mojatatu.com> wrote: > This patch fixes an issue with kfree_rcu which is not protected by RTNL > lock. It could be that the current assigned rcu pointer will be freed by > kfree_rcu while dump callback is running. > >

[RFC net 1/1] net: sched: act: fix rcu race in dump

params B - dump params \--> will dump params A This could be a unlikely case that the last rcu_assign_pointer was not happened before dump callback. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/act_skbmod.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[RFC net 0/1] net: sched: act: fix rcu race

r in other tc actions where code was just copy The problem because nobody hits this issue is, I think that dump will do alot of previous stuff which took more time than a rcu_synchronize. Anyway, this change should avoid any use after free issues etc. - Alex Alexander Aring (1): net: sched: ac

[PATCH iproute2 3/4] tc: m_ife: report about kernels default type

This patch will report about if the ethertype for IFE is not specified that the default IFE type is used. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- tc/m_ife.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tc/m_ife.c b/tc/m_ife.c index 7b57130e..5633ab90 100644 --

[PATCH iproute2 1/4] tc: m_ife: allow ife type to zero

This patch allows to set an ethertype for IFE which is zero. There is no kernel side validation which forbids a type to zero. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- tc/m_ife.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tc/m_ife.c b/tc/m_ife.c

[PATCH iproute2 4/4] man: tc-ife: add default type note

This patch updates the tc-ife man page that the default IFE ethertype will be used if it's not specified. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- man/man8/tc-ife.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/tc-ife.8 b/man/man8/tc-ife.8

[PATCH iproute2 0/4] tc: m_ife: handle IFE ethertype value

of tc-ife. Note: Please wait until the related kernel patches comes in. This patch series contains an UAPI change which need to be accepted by netdev at first. Thanks. - Alex Alexander Aring (4): tc: m_ife: allow ife type to zero tc: m_ife: print IEEE ethertype format tc: m_ife: report about

[PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format

This patch uses the usually IEEE format to display an ethertype which is 4-digits and every digit in upper case. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- tc/m_ife.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_ife.c b/tc/m_ife.c index e05e2276..7b

[PATCH net-next 1/3] if_ether: add forces ife lfb type

t;FoRCES" which is a spelling error inside the IEEE ethertype specification. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h index 5bc9bfd

[PATCH net-next 2/3] act_ife: use registered ife_type as fallback

This patch handles a default IFE type if it's not given by user space netlink api. The default IFE type will be the registered ethertype by IEEE for IFE ForCES. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- net/sched/act_ife.c | 17 +++-- 1 file changed, 3 insertions(

[PATCH net-next 3/3] tc-testing: add test for testing ife type

This patch adds a new testcase for the IFE type setting in tc. In case of user specified the type it will check if the ife is correctly configured to react on it. If it's not specified the default IFE type should be used. Signed-off-by: Alexander Aring <ar...@mojatatu.com> --- .../tc-test

[PATCH net-next 0/3] tc: act_ife: handle IEEE IFE ethertype as default

. - Alex Alexander Aring (3): if_ether: add forces ife lfb type act_ife: use registered ife_type as fallback tc-testing: add test for testing ife type include/uapi/linux/if_ether.h | 1 + net/sched/act_ife.c| 17 ++-- .../tc-testing

Re: bluetooth 6lowpan interfaces are not virtual anymore

Hi Michael, On 04/18/2017 06:59 PM, Michael Richardson wrote: > > Alexander Aring <a...@pengutronix.de> wrote: > > What does the 6LoWPAN interface? > > > It will do a protocol change (an adaptation, because 6LoWPAN should > > provide the same

Re: bluetooth 6lowpan interfaces are not virtual anymore

opinion: wrong. At least if you want to try to make a more efficient qdisc handling, means dropping skb's in queue when userspace sends too much. You will change it back, control two queues seems to be difficult. On 04/18/2017 12:43 PM, Luiz Augusto von Dentz wrote: > Hi Alex, > > On Mon,

bluetooth 6lowpan interfaces are not virtual anymore

Hi, bluetooth-next contains patches which introduces a queue for bluetooth 6LoWPAN interfaces. [0] At first, the current behaviour is now that 802.15.4 6LoWPAN interfaces are virtual and bluetooth 6LoWPAN interfaces are not virtual anymore. To have a different handling in both subsystems is

Re: skb_over_panic using UDP and 6lowpan / fakelb

Hi, sorry for the late reply. On 04/03/2017 07:29 PM, Cong Wang wrote: > (Cc'ing netdev and maintainers) > > On Mon, Mar 27, 2017 at 2:16 AM, David Palma wrote: >> >> Hi, >> >> Sending a simple UDP packet (39 bytes long), over a 6lowpan interface >> (using fakelb),

Re: [PATCH v6 6/6] 6lowpan: Fix IID format for Bluetooth

Hi, sorry, I decided now to take a look into the patch... Currently I have no time to do anything... normally. That's why I simple said "everything okay" in irc. On 03/02/2017 02:23 PM, Luiz Augusto von Dentz wrote: > From: Luiz Augusto von Dentz > > According to RFC

Re: [PATCH v5 5/6] 6lowpan: Use netdev addr_len to determine lladdr len

H On 02/27/2017 08:13 AM, Alexander Aring wrote: > Hi, > > On 02/24/2017 01:14 PM, Luiz Augusto von Dentz wrote: >> From: Luiz Augusto von Dentz <luiz.von.de...@intel.com> >> >> This allow technologies such as Bluetooth to use its native lladdr which &

Re: [PATCH v5 5/6] 6lowpan: Use netdev addr_len to determine lladdr len

Hi, On 02/24/2017 01:14 PM, Luiz Augusto von Dentz wrote: > From: Luiz Augusto von Dentz > > This allow technologies such as Bluetooth to use its native lladdr which > is eui48 instead of eui64 which was expected by functions like > lowpan_header_decompress and

Re: [PATCH v5 4/6] ipv6: addrconf: fix 48 bit 6lowpan autoconfiguration

Hi, okay now I am finally confused. On 02/24/2017 01:14 PM, Luiz Augusto von Dentz wrote: > From: Alexander Aring <a...@pengutronix.de> > > This patch adds support for 48 bit 6LoWPAN address length > autoconfiguration which is the case for BTLE 6LoWPAN. > > Signed

Re: [PATCH v5 6/6] 6lowpan: Fix IID format for Bluetooth

Hi, On 02/26/2017 07:05 AM, Alexander Aring wrote: > > Hi, > > On 02/24/2017 01:14 PM, Luiz Augusto von Dentz wrote: >> From: Luiz Augusto von Dentz <luiz.von.de...@intel.com> >> >> Accourding to RFC 7668 U/L bit shall not be used: >> >> https:

Re: [PATCH v5 6/6] 6lowpan: Fix IID format for Bluetooth

Hi, On 02/24/2017 01:14 PM, Luiz Augusto von Dentz wrote: > From: Luiz Augusto von Dentz > > Accourding to RFC 7668 U/L bit shall not be used: > > https://wiki.tools.ietf.org/html/rfc7668#section-3.2.2 [Page 10]: > >In the figure, letter 'b' represents a bit

introduce IPV6_PKTINFO_L2 socket-option?

Hi all, I am currently writing some userspace UDP Software for 6LoWPAN subsystem. It will use UDP IPv6 sockets, the 6LoWPAN adaptation will be done at kernelspace. My problem is currently the following: I need per recvmsg(2) the used source link-layer address for the incoming UDP packet which

Re: [PATCH] ieee802154: check device type

is that we're not checking that this is an IEEE802154 interface, > so let's do what ieee802154_nl_get_dev() is doing. (Maybe we should even > be calling this directly?) > > Cc: Lennert Buytenhek <buyt...@wantstofly.org> > Cc: Alexander Aring <alex.ar...@gmail.com> > Cc: Marcel Holtmann <

[RFC] UAPI for 6lowpan

Hi all, I currently want to search nice solution to adding an UAPI for 6LoWPAN. The current 6LoWPAN UAPI is some dev-hacking stuff in debugfs [0]. Marcel told me before I tried to send upstream patches for radvd [1] I definitely should introduce a stable UAPI concept. The question is here, what

[PATCHv4 net-next 03/12] 6lowpan: remove ipv6 module request

Since we use exported function from ipv6 kernel module we don't need to request the module anymore to have ipv6 functionality. Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> Reviewed-by: Stefan Schmidt <ste...@osg.samsung.com> Signed-off-by: Alexander Aring <a...

[PATCHv4 net-next 01/12] 6lowpan: add private neighbour data

;da...@davemloft.net> Reviewed-by: Stefan Schmidt <ste...@osg.samsung.com> Acked-by: YOSHIFUJI Hideaki <yoshf...@linux-ipv6.org> Signed-off-by: Alexander Aring <a...@pengutronix.de> --- include/linux/netdevice.h | 3 +-- include/net/6lowpan.h | 10 ++ net/ieee80

[PATCHv4 net-next 10/12] 6lowpan: introduce 6lowpan-nd

aki <yoshf...@linux-ipv6.org> Signed-off-by: Alexander Aring <a...@pengutronix.de> --- include/net/ndisc.h | 18 ++-- net/6lowpan/6lowpan_i.h | 4 + net/6lowpan/Makefile| 2 +- net/6lowpan/core.c | 4 +- net/6lowpan/ndisc.c | 234 +

[PATCHv4 net-next 02/12] 6lowpan: add 802.15.4 short addr slaac

..@linux-ipv6.org> Cc: Patrick McHardy <ka...@trash.net> Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> Reviewed-by: Stefan Schmidt <ste...@osg.samsung.com> Signed-off-by: Alexander Aring <a...@pengutronix.de> --- include/net/6lowpan.h | 6 ++ include/net/

[PATCHv4 net-next 07/12] addrconf: put prefix address add in an own function

netsov <kuz...@ms2.inr.ac.ru> Cc: James Morris <jmor...@namei.org> Cc: Hideaki YOSHIFUJI <yoshf...@linux-ipv6.org> Cc: Patrick McHardy <ka...@trash.net> Reviewed-by: Stefan Schmidt <ste...@osg.samsung.com> Acked-by: YOSHIFUJI Hideaki <yoshf...@linux-i

[PATCHv4 net-next 06/12] ndisc: add __ndisc_fill_addr_option function

JI <yoshf...@linux-ipv6.org> Cc: Patrick McHardy <ka...@trash.net> Acked-by: YOSHIFUJI Hideaki <yoshf...@linux-ipv6.org> Reviewed-by: Stefan Schmidt <ste...@osg.samsung.com> Signed-off-by: Alexander Aring <a...@pengutronix.de> --- net/ipv6/ndisc.c | 14 ++---

[PATCHv4 net-next 11/12] 6lowpan: add support for getting short address

In case of sending RA messages we need some way to get the short address from an 802.15.4 6LoWPAN interface. This patch will add a temporary debugfs entry for experimental userspace api. Reviewed-by: Stefan Schmidt <ste...@osg.samsung.com> Signed-off-by: Alexander Aring <a...@pengu

<    1   2   3   4   >