[PATCH iproute] arrange prefix parsing code after redundant patches

. This patch reverts changes introduced by those redundant patches. Signed-off-by: Alexander Zubkov <gr...@msu.ru> --- ip/iproute.c | 65 ++-- lib/utils.c | 13 2 files changed, 46 insertions(+), 32 deletions(-) diff --gi

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

ephen Hemminger" <step...@networkplumber.org>: > On Tue, 27 Mar 2018 18:29:31 +0200 > Alexander Zubkov <gr...@msu.ru> wrote: > >>  Hi Stephen, >> >>  Looks like the new patch was applied after the revert of original patch and >> fix patch f

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

to do things right in master branch 27.03.2018, 18:01, "Stephen Hemminger" <step...@networkplumber.org>: > On Wed, 14 Mar 2018 21:26:40 +0100 > Alexander Zubkov <gr...@msu.ru> wrote: > >>  Hello, >> >>  For example, it can be fixed in such way

Re: [PATCH iproute2] treat "default" and "all"/"any" addresses differenty

This version of patch is for master now. 18.03.2018, 17:50, "Alexander Zubkov" <gr...@msu.ru>: > Debian maintainer found that basic command: > # ip route flush all > No longer worked as expected which breaks user scripts and > expectations. It no lo

[PATCH iproute2] treat "default" and "all"/"any" addresses differenty

nd "all"/"any" always matches anything in exact, root and match modes. Reported-by: Luca Boccassi <bl...@debian.org> Signed-off-by: Alexander Zubkov <gr...@msu.ru> --- lib/utils.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

Re: [PATCH iproute2] treat "default" and "all"/"any" parameters differenty

. If there are no answer for some more time, I'll consider that fix as suitable and send it as a proper patch to the list. That will not require reverse patch too. 16.03.2018, 21:37, "Stephen Hemminger" <step...@networkplumber.org>: > On Tue, 13 Mar 2018 21:19:45 +0100 > Alexander Zubko

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

bitlen = plen; } else { if (dst->bitlen == -2) bitlen = 0; - else - flags = 0; } dst->flags |= flags; On 14.03.2018 09:59, Alexander Zubkov wrote: Hello, There was a series of

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

unspecified family or change filtering logic. I have added Serhey Popovych in the recepients, so he can give some ideas on what his aim is and help choose better solution. 13.03.2018, 21:12, "Alexander Zubkov" <gr...@msu.ru>: > Hi, > > I just realized that you need patch for v4.15

[PATCH iproute2] treat "default" and "all"/"any" parameters differenty

"all"/"any" was altered too, because they were the same branch of the code. As those parameters mean different, they need to be treated differently in code too. This patch reflects the difference. Reported-by: Luca Boccassi <bl...@debian.org> Signed-off-by: Alexander Zubkov

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hi, I just realized that you need patch for v4.15.0, which is easier to do. I'll send it as separate message now. I will make patch for the master branch, but later. On 13.03.2018 13:02, Luca Boccassi wrote: On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote: Hello again, The fun

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

hink if "ip route ls [all|any]" shows all routes and "ip route ls default" shows only default, everybody will be happy with that? 13.03.2018, 09:46, "Alexander Zubkov" <gr...@msu.ru>: > Hello. > > May be the better way would be to change how "

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hello. May be the better way would be to change how "all"/"any" argument behaves? My original concern was about "default" only. I agree too, that "all" or "any" should work for all routes. But not for the default. 12.03.2018, 22:37, "Luca Boccassi" : > On Mon, 2018-03-12 at

Re: [PATCH iproute2] ip route: broken logic when using default word and family not specified

tep...@networkplumber.org> wrote: > On Sat, 18 Nov 2017 14:12:48 +0100 > Alexander Zubkov <zubkov...@gmail.com> wrote: > >> Hello, >> >> I have found odd behaviour when using "ip route list" (and other bound >> commands) with prefix "default". >>

[PATCH v3] iproute: list/flush/save filter also by metric

Metric is one of the "unique key" fields of the route in Linux. But still one can not use its value in filter while running ip list. Because of this writing checks in scripts for example is incovenient. Signed-off-by: Alexander Zubkov <gr...@msu.ru> --- ip/iproute.c | 21

[PATCH] iproute: "list/flush/save default" selected all of the routes

the same all-zeroes value like no prefix specified at all. Thus following code blindly ignores the fact, that prefix was actually specified. This patch adds the flag PREFIXLEN_SPECIFIED to the default route too. And then checks its value when filtering routes. Signed-off-by: Alexander Zubkov <gr.

Re: [PATCH iproute2] ip route: broken logic when using default word and family not specified

Hello everybody, I will be glad to hear a piece of feedback on this proposal. On Sat, Nov 18, 2017 at 5:56 PM, Alexander Zubkov <zubkov...@gmail.com> wrote: > I also opened earlier a ticket in bugzilla: > https://bugzilla.kernel.org/show_bug.cgi?id=197899 > And Stephen Hemmi

Re: iproute2: make ip route list to search by metric too

Hello everybody, Excuse me for probably being impatient. But may I have some feedback on my proposal? On Sat, Nov 18, 2017 at 11:11 AM, Alexander Zubkov <zubkov...@gmail.com> wrote: > I think this version will be better. It uses metric mask (like for > some other options) instead o

Re: [PATCH iproute2] ip route: broken logic when using default word and family not specified

be other opinions. On Sat, Nov 18, 2017 at 2:12 PM, Alexander Zubkov <zubkov...@gmail.com> wrote: > Hello, > > I have found odd behaviour when using "ip route list" (and other bound > commands) with prefix "default". > > When family not specified, i

[PATCH iproute2] ip route: broken logic when using default word and family not specified

Hello, I have found odd behaviour when using "ip route list" (and other bound commands) with prefix "default". When family not specified, its value is completely ignored and "ip route list default" shows all inet4 prefixes. Same do "ip route list exact default" and "ip route list match default".

Re: iproute2: make ip route list to search by metric too

I think this version will be better. It uses metric mask (like for some other options) instead of simple yes/no flag. On Sat, Nov 18, 2017 at 2:44 AM, Alexander Zubkov <zubkov...@gmail.com> wrote: > Hello again, > > Things turned out to be not so hard. Please take a look at the

Re: iproute2: make ip route list to search by metric too

17 at 1:40 AM, Alexander Zubkov <zubkov...@gmail.com> wrote: > Hello all, > > Currently routes in the Linux routing table have these "key" fields: > prefix, tos, table, metric (as I know). I.e. we cannot have two > different routes with the same set of this

iproute2: make ip route list to search by metric too

t as I see it parses arguments and fills some structures. And then my tries to understand failed. I opened the bug: https://bugzilla.kernel.org/show_bug.cgi?id=197897, but I was pointed out that this mailing list is a better place for this question. -- Alexander Zubkov