On Sat, Oct 24, 2020 at 07:09:53PM +0100, Russell King - ARM Linux admin wrote:
> On Sat, Oct 24, 2020 at 07:17:05PM +0200, Andrew Lunn wrote:
> > > - Every PHY driver gains a .handle_interrupt() implementation that, for
> > > the most part, would look like below:
>
On Sat, Oct 24, 2020 at 10:36:36AM -0700, Tom Rix wrote:
>
> On 10/24/20 9:39 AM, Andrew Lunn wrote:
> > On Sat, Oct 24, 2020 at 08:03:51AM -0700, Tom Rix wrote:
> >> On 10/23/20 1:45 AM, Xu Yilun wrote:
> >>> This driver supports the ethernet reti
On Sun, Oct 25, 2020 at 04:55:56PM +0800, Icenowy Zheng wrote:
> Currently there are many boards that just set "rgmii" as phy-mode in the
> device tree, and leave the hardware [TR]XDLY pins to set PHY delay mode.
>
> In order to keep old device tree working, omit setting delay for just
> "RGMII" w
On Sun, Oct 25, 2020 at 03:16:36PM +0100, Ard Biesheuvel wrote:
> On Sun, 18 Oct 2020 at 17:45, Andrew Lunn wrote:
> >
> > > However, that leaves the question why bbc4d71d63549bcd was backported,
> > > although I understand why the discussion is a bit trickier there. Bu
On Sun, Oct 25, 2020 at 10:27:05PM +0800, Icenowy Zheng wrote:
>
>
> 于 2020年10月25日 GMT+08:00 下午10:18:25, Andrew Lunn 写到:
> >On Sun, Oct 25, 2020 at 04:55:56PM +0800, Icenowy Zheng wrote:
> >> Currently there are many boards that just set "rgmii" as phy-mode in
On Sun, Oct 25, 2020 at 03:34:06PM +0100, Ard Biesheuvel wrote:
> On Sun, 25 Oct 2020 at 15:29, Andrew Lunn wrote:
> >
> > On Sun, Oct 25, 2020 at 03:16:36PM +0100, Ard Biesheuvel wrote:
> > > On Sun, 18 Oct 2020 at 17:45, Andrew Lunn wrote:
> > > >
> &g
> > +u64 read_mac_stats(struct eth_com *ecom, unsigned int addr)
> > +{
> > + u32 data_l, data_h;
> > +
> > + if (eth_com_read_reg(ecom, addr, &data_l) ||
> > + eth_com_read_reg(ecom, addr + 1, &data_h))
> > + return 0xULL;
> return -1; ?
Since this is a u64 fu
> >> 1. As the PHY chip has hardware configuration for configuring delays,
> >> we should at least have a mode that respects what's set on the
> >hardware.
> >
> >Yes, that is PHY_INTERFACE_MODE_NA. In DT, set the phy-mode to "". Or
> >for most MAC drivers, don't list a phy-mode at all.
>
> Howeve
> By referring to linux/phy.h, NA means not applicable. This surely
> do not apply when RGMII is really in use.
It means the PHY driver should not touch the mode, something else has
set it up. That could be strapping, the bootloader, ACPI firmware,
whatever.
> I think no document declares RGMII m
> > > +The Intel(R) PAC N3000 is a FPGA based SmartNIC platform for
> > > multi-workload
> > > +networking application acceleration. A simple diagram below to for the
> > > board:
> > > +
> > > + ++
> > > + |
On Mon, Oct 26, 2020 at 10:47:36AM +0100, Mauro Carvalho Chehab wrote:
> Some functions have different names between their prototypes
> and the kernel-doc markup.
>
> Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Andrew Lunn
Andrew
On Mon, Oct 26, 2020 at 03:58:11PM +1000, Pavana Sharma wrote:
> Signed-off-by: Pavana Sharma
Please swap the order of the patches so the build does not break.
Andrew
> > > > Do you really mean PHY? I actually expect it is PCS?
> > >
> > > For this implementation, yes.
> >
> > Yes, you have a PHY? Or Yes, it is PCS?
>
> Sorry, I mean I have a PHY.
>
> >
> > To me, the phylib maintainer, having a PHY means you have a base-T
> > interface, 25Gbase-T, 40Gbase
ann
Hi Arnd
It is nice to have the additional type checking.
Since you added a Fixes: tag, do you want this in stable?
netdev puts into the Subject line the tree it is intended for:
[PATCH net v1]
or
[PATCH net-next v1]
Anyway:
Reviewed-by: Andrew Lunn
Andrew
x27;, with the same value '0'.
>
> Fixes: efca3878a5fb ("ch_ktls: Issue if connection offload fails")
> Signed-off-by: Arnd Bergmann
Hi Arnd
I have the same fix in my tree of W=1 fixes. I was just waiting for
net-next to open.
Reviewed-by: Andrew Lunn
Andrew
write_mmd (struct phy_device *phydev, int
> devad, u32 regnum, u16 val)'.
>
> It turns that both the C and the H files have the same
> kernel-doc markup for the same functions. Let's drop the
> at the header file, keeping the one closer to the code.
>
> Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Andrew Lunn
Andrew
> (mv88e6xxx) What is the policy regarding the use of DSA vs. EDSA? It
> seems like all chips capable of doing EDSA are using that, except for
> the Peridot.
Hi Tobias
Marvell removed the ability to use EDSA, in the way we do in Linux
DSA, on Peridot. One of the configuration bits is gone. So i
> > (mv88e6xxx) What is the policy regarding the use of DSA vs. EDSA? It
> > seems like all chips capable of doing EDSA are using that, except for
> > the Peridot.
>
> I have no documentation whatsoever for mv88e6xxx, but just wondering,
> what is the benefit brought by EDSA here vs DSA? Does DSA
On Tue, Oct 27, 2020 at 04:05:30PM +0100, Marek Behun wrote:
> When I first read about port trunking in the Peridot documentation, I
> immediately thought that this could be used to transparently offload
> that which is called Bonding in Linux...
>
> Is this what you want to eventually do?
>
> BT
On Tue, Oct 27, 2020 at 05:49:24PM +0300, Ivan Mikhaylov wrote:
> phy-handle can't be handled well for ast2400/2500 which has an embedded
> MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize
> PHYs from mdio child node with of_mdiobus_register.
>
> Signed-off-by: Ivan Mikhay
disabled.
>
> Suggested-by: Andrew Lunn
> Signed-off-by: Łukasz Stelmach
Reviewed-by: Andrew Lunn
Andrew
On Tue, Oct 27, 2020 at 05:49:23PM +0300, Ivan Mikhaylov wrote:
> Split MDIO registration and PHY connect into ftgmac100_setup_mdio and
> ftgmac100_mii_probe.
>
> Signed-off-by: Ivan Mikhaylov
Reviewed-by: Andrew Lunn
Andrew
On Tue, Oct 27, 2020 at 08:56:09PM +, Chris Packham wrote:
>
> On 24/10/20 11:42 am, Andrew Lunn wrote:
> >> +int mv88e6123_serdes_get_regs_len(struct mv88e6xxx_chip *chip, int port)
> >> +{
> >> + if (mv88e6xxx_serdes_get_lane(chip, por
Hi Tobias
> All LAG configuration is cached in `struct dsa_lag`s. I realize that
> the standard M.O. of DSA is to read back information from hardware
> when required. With LAGs this becomes very tricky though. For example,
> the change of a link state on one switch will require re-balancing of
> L
On Wed, Oct 28, 2020 at 12:43:44PM +0200, Vladimir Oltean wrote:
> On Wed, Oct 28, 2020 at 08:42:15AM +0100, Kurt Kanzenbach wrote:
> > From: Vladimir Oltean
> >
> > Some switches rely on unique pvids to ensure port separation in
> > standalone mode, because they don't have a port forwarding matr
On Wed, Oct 28, 2020 at 10:09:12AM +1000, Pavana Sharma wrote:
> Add 5GBASE-R phy interface mode supported by mv88e6393
> family.
>
> Signed-off-by: Pavana Sharma
Reviewed-by: Andrew Lunn
Andrew
W=1 warns of functions which look like printk but don't have
attributes so the compile can check that arguments matches the format
string.
Andrew Lunn (2):
net: dccp: Add __printf() markup to fix -Wsuggest-attribute=format
net: tipc: Add __printf() markup to fix -Wsuggest-attribute=f
net/tipc/netlink_compat.c: In function ‘tipc_tlv_sprintf’:
net/tipc/netlink_compat.c:137:2: warning: function ‘tipc_tlv_sprintf’ might be
a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
137 | n = vscnprintf(buf, rem, fmt, args);
Signed-off-by: Andrew Lunn
---
net
As the subject suggests, there is still one warning left:
net/ceph/crush/mapper.c:674: warning: Function parameter or member 'left' not
described in 'crush_choose_indep'
It would be nice if somebody who understands this code could fix that
warning. Then ceph become W=1 clean.
Andrew
There are two W=1 warnings left after this patch is applied:
net/dccp/ccids/ccid2.c:365: warning: Function parameter or member 'mrtt' not
described in 'ccid2_rtt_estimator'
net/dccp/ccids/lib/tfrc_equation.c:695: warning: Function parameter or member
'loss_event_rate' not described in 'tfrc_inve
net/dccp/ccid.c: In function ‘ccid_kmem_cache_create’:
net/dccp/ccid.c:85:2: warning: function ‘ccid_kmem_cache_create’ might be a
candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
85 | vsnprintf(slab_name_fmt, CCID_SLAB_NAME_LENGTH, fmt, args);
Signed-off-by: Andrew
On Wed, Oct 28, 2020 at 10:08:27AM +1000, Pavana Sharma wrote:
> Add new mode supported by MV88E6393 family.
>
> Signed-off-by: Pavana Sharma
> ---
> include/linux/phy.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 3a09d2bf69ea..9
Function parameter or member 'untag_vlan'
not described in 'parse_vlan_tag'
net/openvswitch/vport.c:122: warning: Function parameter or member 'parms' not
described in 'ovs_vport_alloc'
Signed-off-by: Andrew Lunn
---
net/openvswitch/flow.c | 4
net/ope
net/llc/llc_conn.c:917: warning: Function parameter or member 'kern' not
described in 'llc_sk_alloc'
net/llc/llc_conn.c:917: warning: Function parameter or member 'prot' not
described in 'llc_sk_alloc'
Signed-off-by: Andrew Lunn
---
net/llc/llc_con
net/netlabel/netlabel_calipso.c:376: warning: Function parameter or member
'ops' not described in 'netlbl_calipso_ops_register'
Signed-off-by: Andrew Lunn
---
net/netlabel/netlabel_calipso.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/netlabel/netlabel_cali
7;dev' not
described in 'atalk_rcv'
net/appletalk/ddp.c:1422: warning: Function parameter or member 'orig_dev' not
described in 'atalk_rcv'
net/appletalk/ddp.c:1422: warning: Function parameter or member 'pt' not
described in 'atalk_rcv'
net/a
On Wed, Oct 28, 2020 at 01:45:11AM +0100, Tobias Waldekranz wrote:
> On Tue, Oct 27, 2020 at 23:36, Andrew Lunn wrote:
> > If you are dynamically allocating dsa_lag structures, at run time, you
> > need to think about this. But the number of LAGs is limited by the
> > number
clear it is not supposed to be trigraph.
Andrew Lunn (2):
net: marvell: mvneta: Fix trigraph warning with W=1
net: rose: Escape trigraph to fix warning with W=1
drivers/net/ethernet/marvell/mvneta.c | 2 +-
net/rose/af_rose.c| 2 +-
2 files changed, 2 insertions(+), 2
net/l3mdev/l3mdev.c:249: warning: Function parameter or member 'arg' not
described in 'l3mdev_fib_rule_match'
Signed-off-by: Andrew Lunn
---
net/l3mdev/l3mdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/l3mdev/l3mdev.c b/net/l3mdev/l3mdev.c
index 864326f150e2.
'
not described in 'digital_start_poll'
net//nfc/digital_core.c:470: warning: Function parameter or member
'tm_protocols' not described in 'digital_start_poll'
net//nfc/nci/core.c:1119: warning: Function parameter or member 'tx_headroom'
not describe
On Wed, Oct 28, 2020 at 10:09:50AM +1000, Pavana Sharma wrote:
> The Marvell 88E6393X device is a single-chip integration of a 11-port
> Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers
> and three 10-Gigabit interfaces.
>
> This patch adds functionalities specific to mv88
er or member 'type' not
described in 'crush_choose_indep'
net/ceph/crush/mapper.c:655: warning: Function parameter or member 'weight_max'
not described in 'crush_choose_indep'
net/ceph/crush/mapper.c:655: warning: Function parameter or member 'weigh
red in the build. Fix the
warning by escaping the ?? prefix of a trigraph.
Signed-off-by: Andrew Lunn
---
net/rose/af_rose.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c
index cf7d974e0f61..2c297834d268 100644
--- a/net/rose/af_rose.c
+++
to a plain question to avoid the warning.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c
b/drivers/net/ethernet/marvell/mvneta.c
index 54b0bf574c05..55f4c49c1278 100644
--- a/d
t
described in 'tcp_lp_rtt_sample'
net//ipv4/tcp_lp.c:265: warning: Function parameter or member 'sk' not
described in 'tcp_lp_pkts_acked'
net//ipv4/tcp_lp.c:97: warning: Function parameter or member 'sk' not described
in 'tcp_lp_init'
There are
ue'
net/dccp/output.c:378: warning: Function parameter or member 'sk' not described
in 'dccp_retransmit_skb'
net/dccp/qpolicy.c:88: warning: Function parameter or member '' not described
in 'dccp_qpolicy_operations'
net/dccp/qpolicy.c:88: warning: Functio
On Tue, Oct 27, 2020 at 06:09:08PM -0700, Jakub Kicinski wrote:
> On Wed, 28 Oct 2020 01:59:07 +0100 Andrew Lunn wrote:
> > net/ceph/cls_lock_client.c:143: warning: Function parameter or member 'oid'
> > not described in 'ceph_cls_break_lock'
> > net/ceph
rpl_sr_hdr srh[0];
};
Similarly:
net//ipv6/rpl.c:10: warning: Function parameter or member 'x' not described in
'IPV6_PFXTAIL_LEN'
where IPV6_PFXTAIL_LEN is a macro definition, not a function.
Convert the header comments to a plain /* comment.
Signed-off-by: Andrew Lunn
--
[TIPC_NLA_LINK_NAME]));
| ~~
| |
| void *
There is no nla_string(), so cast to a char *.
Signed-off-by: Andrew Lunn
---
net/tipc/netlink_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/netlink_compat.c b/net/tipc/net
getapp_prio_dscp_mask_map'
net//dcb/dcbnl.c:2016: warning: Function parameter or member 'dev' not
described in 'dcb_ieee_getapp_dscp_prio_mask_map'
net//dcb/dcbnl.c:2016: warning: Function parameter or member 'p_map' not
described in 'dcb_ieee_getapp_dscp_prio_mask_map'
net/
ion parameter 'audit_secid'
description in 'calipso_doi_remove'
net/ipv6/calipso.c:435: warning: Function parameter or member 'audit_info' not
described in 'calipso_doi_remove'
Signed-off-by: Andrew Lunn
---
net/ipv6/calipso.c | 4 ++--
1 file chan
> +static void
> +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs, void
> *_p)
> +{
> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev);
> + u16 *p = _p;
> + int offset, i;
You missed a reverse christmass tree fix here.
> +static int comp;
> +static i
On Thu, Oct 29, 2020 at 10:30:14AM +0800, Zou Wei wrote:
> Fix the following coccinelle report:
>
> ./drivers/net/ethernet/nvidia/forcedeth.c:3479:8-10:
> WARNING: possible condition with no effect (if == else)
>
> Both branches are the same, so remove the else if/else altogether.
>
> Reported-b
On Thu, Oct 29, 2020 at 10:33:52AM +0800, Zou Wei wrote:
> Fix the following coccinelle report:
>
> ./drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:233:6-8:
> WARNING: possible condition with no effect (if == else)
>
> Both branches are the same, so remove the else if/else altogether.
>
On Thu, Oct 29, 2020 at 10:49:34AM +0800, kernel test robot wrote:
> Hi Andrew,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Andrew-Lunn/net-dccp-Add-__print
On Thu, Oct 29, 2020 at 03:42:00PM +1000, Pavana Sharma wrote:
> Add new mode supported by MV88E6393 family.
Hi Pavana
I asked you to add kerneldoc for this new value, but you have not
added it. Please compile your code with W=1, and you should see the
warning.
Andrew
> It would be good to pass this through checkpatch - I notice some lines
> seem to be over the 80 character limit now.
Hi Russell
The limit got raised to something higher. I personally prefer 80, and
if a file is using 80, new code would be inconsistent with old code if
it did not use 80. So your
On Thu, Oct 29, 2020 at 02:39:15PM +0800, DENG Qingfang wrote:
> MT762x HW supports frame length up to 2048 (maximum length on GDM),
> so allow setting MTU up to 2030.
>
> Signed-off-by: DENG Qingfang
> ---
>
> I only tested this on MT7621, no sure if it is applicable for other SoCs
> especially
On Thu, Oct 29, 2020 at 03:25:25PM +0530, Bhaskar Chowdhury wrote:
> Fixed spelling in comment like below:
>
> s/defalut/default/p
>
> This is in linux-next.
>
> Signed-off-by: Bhaskar Chowdhury
Reviewed-by: Andrew Lunn
Andrew
On Thu, Oct 29, 2020 at 08:07:57PM +0800, Willy Liu wrote:
> Realtek single-port 2.5Gbps Ethernet PHY ids as below:
> RTL8226-CG: 0x001cc800(ES)/0x001cc838(MP)
> RTL8226B-CG/RTL8221B-CG: 0x001cc840(ES)/0x001cc848(MP)
> ES: engineer sample
> MP: mass production
>
> Since above PHYs are already in m
On Thu, Oct 29, 2020 at 02:19:27PM +, David Laight wrote:
> From: Andrew Lunn
> > Sent: 28 October 2020 00:23
> >
> > net/rose/af_rose.c: In function ‘rose_info_show’:
> > net/rose/af_rose.c:1413:20: warning: trigraph ??- ignored, use -trigraphs
> >
> What about reverting the realtek PHY commit from stable?
> As Ard said it doesn't really fix anything (usage wise) and causes a bunch of
> problems.
>
> If I understand correctly we have 3 options:
> 1. 'Hack' the drivers in stable to fix it (and most of those hacks will take
>a long time
> IIRC there is no public documentation for this PHY, right? So most
> people that are affected by this are not actually able to implement
> this workaround, even if they wanted to.
The information you need is in the mailing list, where a realtek
person describes what the bits do.
Andrew
On Thu, Oct 29, 2020 at 02:52:52PM +, David Laight wrote:
> From: Andrew Lunn
> > Sent: 29 October 2020 14:31
> > On Thu, Oct 29, 2020 at 02:19:27PM +, David Laight wrote:
> > > From: Andrew Lunn
> > > > Sent: 28 October 2020 00:23
> > &
> >> +static irqreturn_t ax88796c_interrupt(int irq, void *dev_instance)
> >> +{
> >> + struct net_device *ndev = dev_instance;
> >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev);
Do the assignment later.
Andrew
that are known to need this.
>
> Fixes: f166f890c8f0 ("net: ethernet: fec: Replace interrupt driven MDIO with
> polled IO")
> Signed-off-by: Greg Ungerer
Tested-by: Andrew Lunn
I tested this on Vybrid, which is not the best of platforms, since i
never had any of these p
On Fri, Oct 30, 2020 at 10:43:51AM +0800, DENG Qingfang wrote:
> On Thu, Oct 29, 2020 at 9:02 PM Andrew Lunn wrote:
> >
> > On Thu, Oct 29, 2020 at 02:39:15PM +0800, DENG Qingfang wrote:
> > > MT762x HW supports frame length up to 2048 (maximum length on GDM),
> >
tion 2.5Gbps single port PHY
> RTL8221B-VM-CG: the 2.5Gbps single port PHY with MACsec feature
>
> This patch adds the minimal drivers to manage these transceivers.
>
> Signed-off-by: Willy Liu
Reviewed-by: Andrew Lunn
Andrew
ixes: f58d2598cf70 ("net: dsa: qca8k: implement the port MTU callbacks")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Jonathan McDowell
Reviewed-by: Andrew Lunn
Andrew
0:00:00:00:00:00
> Current message level: 0x (0)
>
> Link detected: yes
>
> Signed-off-by: Dan Murphy
Reviewed-by: Andrew Lunn
Andrew
On Fri, Oct 30, 2020 at 12:29:48PM -0500, Dan Murphy wrote:
> Per the 802.3cg spec the 10base T1L can operate at 2 different
> differential voltages 1v p2p and 2.4v p2p. The abiility of the PHY to
> drive that output is dependent on the PHY's on board power supply.
Hi Dan
So this property is abou
> +static int dp83td510_config_init(struct phy_device *phydev)
> +{
> + struct dp83td510_private *dp83td510 = phydev->priv;
> + int mst_slave_cfg;
> + int ret = 0;
> +
> + if (phy_interface_is_rgmii(phydev)) {
> + if (dp83td510->rgmii_delay) {
> + ret
On Fri, Oct 30, 2020 at 04:37:07PM +0300, Ivan Mikhaylov wrote:
> Add the phy-handle and MDIO description and add the example with
> PHY and MDIO nodes.
>
> Signed-off-by: Ivan Mikhaylov
Reviewed-by: Andrew Lunn
Andrew
Signed-off-by: Ivan Mikhaylov
Reviewed-by: Andrew Lunn
Andrew
> > - Every PHY driver gains a .handle_interrupt() implementation that, for
> > the most part, would look like below:
> >
> > irq_status = phy_read(phydev, INTR_STATUS);
> > if (irq_status < 0) {
> > phy_error(phydev);
> > return IRQ_NONE;
> > }
> >
> > i
t just pass a parameter!
The DBG does not seem to have any real value, to just remove it.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/smsc/smc911x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smc911x.c
b/drivers/net/ethernet/smsc/smc911x.c
index
happen. But due to the macro magic, it is hard to
perform the read without assigning it to a variable. So add
_always_unused attribute to status to tell the compiler we don't
expect to use the value.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/smsc/smc911x.c | 4 ++--
1 file chang
the skb->data pointer cannot be cast to a
u32 in a meaningful way. Use long instead.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/smsc/smc911x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smc911x.c
b/drivers/net/ethernet/smsc
case is not needed.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/smsc/smc91x.c | 4 ++--
drivers/net/ethernet/smsc/smc91x.h | 10 ++
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smc91x.c
b/drivers/net/ethernet/smsc/smc91x.c
index
DBG is disabled, the compiler never sees it being used.
Change the DBG macro to actually make use of the passed parameters,
and the leave the optimiser to remove the unwanted code inside the if
(0).
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/smsc/smc911x.c | 6 +-
1 file changed, 5
;
drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member
'value' not described in 'try_toggle_control_gpio'
drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member
'nsdelay' not described in 'try_toggle_control_g
more is not going to
make that much difference.
Andrew Lunn (7):
drivers: net: smc91x: Fix set but unused W=1 warning
drivers: net: smc91x: Fix missing kerneldoc reported by W=1
drivers: net: smc911x: Work around set but unused status
drivers: net: smc911x: Fix set but unused status because
Improve the build testing of these SMSC drivers by enabling them when
COMPILE_TEST is selected.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/smsc/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/smsc/Kconfig
b/drivers/net/ethernet
;
Add more #if defined() to totally remove the code when not needed.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/dec/tulip/tulip_core.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c
b/drivers/net/ethernet/dec/tulip/tulip_core.c
index
to assign the data to a variable
during this discard operation.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/davicom/dm9000.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/davicom/dm9000.c
b/drivers/net/ethernet/davicom/dm9000.c
index
Fixup various W=1 warnings, and then add COMPILE_TEST support, which
explains why these where missed on the previous pass.
Andrew Lunn (2):
drivers: net: davicom: Fixed unused but set variable with W=1
drivers: net: davicom Add COMPILE_TEST support
drivers/net/ethernet/davicom/Kconfig | 2
Improve the build testing of this davicom driver by enabling it when
COMPILE_TEST is selected.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/davicom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/davicom/Kconfig
b/drivers/net/ethernet
> Sure, I just wanted to add the comment before others simply copy and
> paste this (pseudo) code. And in patch 9 (aquantia) and 18 (realtek)
> it is used as is. And IIRC at least the Aquantia PHY doesn't mask
> the interrupt status.
And that is were we are going to have issues with this patch set
> So, then re-send for this or just this patch ping?
> Naturally, this is for net-next.
> I don't mind doing either way.
Please resend, with all the acked-by, reviewed-by added, now that
net-next is open.
Andrew
-truncation]
None of the device names are 16 characters long, so it was never an
issue, but reduce the length of the buffer size by one to avoid the
warning.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/marvell/sky2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
The txqueue parameter to the watchdog callback is unused in this
driver. But it still needs to be documented.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
b/drivers
To improve build testing of this driver, add COMPILE_TEST support.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/xilinx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/Kconfig
b/drivers/net/ethernet/xilinx/Kconfig
index d0d0d4fe9d40
drivers/net/ethernet//xilinx/xilinx_emaclite.c:341:35: warning: cast from
pointer to integer of different size [-Wpointer-to-int-cast]
341 | addr = (void __iomem __force *)((u32 __force)addr ^
Use long instead of u32 to avoid problems on 64 bit systems.
Signed-off-by: Andrew Lunn
kerneldoc, pointer issues, and add COMPILE_TEST support to easy
finding future issues via build testing.
Andrew Lunn (3):
drivers: net: xilinx_emaclite: Add missing parameter kerneldoc
drivers: net: xilinx_emaclite: Fix -Wpointer-to-int-cast warnings with
W=1
drivers: net
, as this file has lots of checkpatch warnings.
Signed-off-by: Andrew Lunn
---
drivers/net/xen-netfront.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 3e9895bec15f..920cac4385bf 100644
--- a/drivers/net/xen
]
1188 | u32 firstcsr;
This file has funky indentation, and makes little use of tabs. Keep
with this style in the patch, but that makes checkpatch unhappy.
Signed-off-by: Andrew Lunn
---
drivers/net/wan/lmc/lmc_main.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a
__underlying_strncpy __builtin_strncpy
| ^
./include/linux/string.h:307:9: note: in expansion of macro
‘__underlying_strncpy’
307 | return __underlying_strncpy(p, q, size);
Replace strncpy with strlcpy to guarantee the string is terminated.
Signed-off-by: Andrew Lunn
nft_request_module calls vsnprintf() using parameters passed to it.
Make the function with __printf() attribute so the compiler can check
the format and arguments.
Signed-off-by: Andrew Lunn
---
net/netfilter/nf_tables_api.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
_virtio.c:83: warning: Function parameter or member 'chan_list' not
described in 'virtio_chan'
net/9p/trans_virtio.c:83: warning: Function parameter or member 'p9_max_pages'
not described in 'virtio_chan'
net/9p/trans_virtio.c:83: warning: Function parameter or membe
ibed in 'ip6_tnl_err'
net/ipv6/ip6_tunnel.c:499: warning: Function parameter or member 'info' not
described in 'ip6_tnl_err'
net/ipv6/ip6_tunnel.c:499: warning: Function parameter or member 'offset' not
described in 'ip6_tnl_err'
ip6_tnl_err() is an
701 - 800 of 7453 matches
Mail list logo
