Null pointer dereference in UDP4 core on AVR32 ATNGW100

is not supporting anymore avr32 I use the version just before this removal. (Nicolas, does Atmel care about that?) -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Null pointer dereference in UDP4 core on AVR32 ATNGW100

On Fri, Jul 31, 2015 at 4:25 PM, Andy Shevchenko andy.shevche...@gmail.com wrote: Hi! Got few weeks ago an old AVR32 board (ATNGW100). It has ethernet cards supported by macb driver. Bring it mostly back to work with recent kernel from linux-next. Now, when I start networking on it, I got

Re: [PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote: There is no need to use hex_dump_to_buffer() in the cases like this: hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); /* len = 16 */ sprintf(%s\n, outbuf); since it maybe easily converted to simple

Re: Null pointer dereference in UDP4 core on AVR32 ATNGW100

: 256 (order: 0, 4096 bytes) UDP-Lite hash table entries: 256 (order: 0, 4096 bytes) futex hash table entries: 16 (order: -5, 192 bytes) On Fri, Jul 31, 2015 at 3:45 PM, Andy Shevchenko andy.shevche...@gmail.com wrote: On Fri, Jul 31, 2015 at 4:25 PM, Andy Shevchenko andy.shevche...@gmail.com

Re: [PATCH 1/5] device property: helper macros for property entry creation

property_set - Collection of built-in device properties. * @fwnode: Handle to be pointed to by the fwnode field of struct device. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

-type]); if (error) return error; spin_lock_irqsave(rfkill-lock, flags); -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 5/5] net: rfkill: gpio: remove rfkill_gpio_platform_data

= pdata-name; - rfkill-type = pdata-type; - } else { - return -ENODEV; Shouldn't we leave the error path and modify to check if we have device property set set? } rfkill-clk = devm_clk_get(pdev-dev, NULL); -- Andy Shevchenko andriy.shevche

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

On Thu, 2015-08-06 at 11:30 +0300, Heikki Krogerus wrote: On Wed, Aug 05, 2015 at 05:07:29PM +0300, Andy Shevchenko wrote: On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: +static inline enum rfkill_type rfkill_find_type(const char *name) +{ + return 0; Hmm

Re: [net:master 41/49] drivers/net/ethernet/cadence/macb.c:164:1: error: macro writel passed 3 arguments, but takes just 2

2012-10-31 105 } 55054a16a drivers/net/ethernet/cadence/macb.c Havard Skinnemoen 2012-10-31 106 f2ce8a9e4 drivers/net/ethernet/cadence/macb.c Andy Shevchenko 2015-07-24 107 /* I/O accessors */ f2ce8a9e4 drivers/net/ethernet/cadence/macb.c

[PATCH v1 1/6] net/macb: improve big endian CPU support

. Fixes: a50dad355a53 (net: macb: Add big endian CPU support) Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/ethernet/cadence/macb.c | 103 ++-- drivers/net/ethernet/cadence/macb.h | 28 -- 2 files changed, 87 insertions

[PATCH v1 6/6] net/macb: convert to kernel doc

This patch coverts struct description to the kernel doc format. There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- include/linux/platform_data/macb.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/include/linux

[PATCH v1 4/6] net/macb: suppress compiler warnings

‘gem_get_ethtool_strings’: drivers/net/ethernet/cadence/macb.c:1988: warning: comparison between signed and unsigned Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/ethernet/cadence/macb.c | 5 ++--- drivers/net/ethernet/cadence/macb.h | 6 +++--- 2 files changed, 5

[PATCH v1 0/6] net/macb: fix for AVR32 and clean up

It seems no one had tested recently the driver on AVR32 platforms such as ATNGW100. This series bring it back to work. Andy Shevchenko (6): net/macb: improve big endian CPU support net/macb: check if macb_config present net/macb: use dev_*() when netdev is not yet registered net/macb

[PATCH v1 5/6] net/macb: replace macb_count_tx_descriptors() by DIV_ROUND_UP()

macb_count_tx_descriptors() repeats the generic macro DIV_ROUND_UP(). The patch does a replacement. There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/ethernet/cadence/macb.c | 10 ++ 1 file changed, 2 insertions(+), 8

[PATCH v1 2/6] net/macb: check if macb_config present

for jumbo frames) Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/ethernet/cadence/macb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 6980115..7986778 100644

[PATCH v1 3/6] net/macb: use dev_*() when netdev is not yet registered

To avoid messages like macb macb.0 (unnamed net_device) (uninitialized): Cadence caps 0x macb macb.0 (unnamed net_device) (uninitialized): invalid hw address, using random let's use dev_*() macros. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net

[PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

the output is groupped by 2 bytes and looks like a typo. Thus, patch changes that to plain byte stream. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/wireless/iwlwifi/dvm/debugfs.c | 8 ++-- drivers/net/wireless/iwlwifi/mvm/debugfs.c | 7 +-- 2 files

[PATCH 2/2] iwlegacy: convert hex_dump_to_buffer() to %*ph

the output is groupped by 2 bytes and looks like a typo. Thus, patch changes that to plain byte stream. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/wireless/iwlegacy/3945-mac.c | 2 +- drivers/net/wireless/iwlegacy/debug.c| 8 ++-- 2 files changed, 3

Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM

PARC */ > + return 1; > +} > + > /** > * i40e_get_mac_addr - get MAC address > * @hw: pointer to the HW structure > @@ -1021,6 +1054,9 @@ i40e_status i40e_get_mac_addr(struct i40e_hw *hw, u8 > *mac_addr) > i40e_status status; > u16

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On Tue, Nov 10, 2015 at 6:14 PM, Mans Rullgard wrote: > This adds a driver for the Aurora VLSI NB8800 Ethernet controller. > It is an almost complete rewrite of a driver originally found in > a Sigma Designs 2.6.22 tree. Few nitpicks below. > > Signed-off-by: Mans Rullgard

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

class are honored during the > comparison. > driver_data Data private to the driver. > */ > +#define CHIP_IP1000A 1 > > static const struct pci_device_id rio_pci_tbl[] = { > {0x1186, 0x4000, PCI_ANY_ID, PCI_ANY_ID, }, > {0x13f0, 0x1021,

Re: [PATCH 1/2 v2] dl2k: Add support for IP1000A-based cards

evice=0x4000 (rev 0x0c) > subsystem vendor=0x1186 device=0x4000 > Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> > Signed-off-by: Ondrej Zary <li...@rainbow-software.org> > --- > drivers/net/ethernet/dlink/Kconfig |5 ++-- > drivers/net/ethernet/dlink/dl2k.c

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On Wed, Nov 11, 2015 at 1:07 AM, Måns Rullgård <m...@mansr.com> wrote: > Andy Shevchenko <andy.shevche...@gmail.com> writes: >>>>> + nb8800_writel(priv, NB8800_TX_DESC_ADDR, txb->dma_desc); >>>>> + wmb(); /* ensure

Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM

On Fri, Oct 30, 2015 at 1:26 PM, Sowmini Varadhan <sowmini.varad...@oracle.com> wrote: > On (10/30/15 02:14), Andy Shevchenko wrote: >> >> Does the following has no stubs? >> >> > + struct i40e_pf *pf = hw->back; >> > + struct

Re: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

On Wed, Nov 4, 2015 at 10:06 PM, Sowmini Varadhan <sowmini.varad...@oracle.com> wrote: > On (11/04/15 21:59), Andy Shevchenko wrote: >> > See earlier response. So, if maintainer is okay I'm also okay with those and you may take my tag. -- With Best Regards, Andy Shevchenko

Re: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

On Thu, Nov 5, 2015 at 12:53 AM, Nelson, Shannon <shannon.nel...@intel.com> wrote: >> From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] >> Sent: Wednesday, November 04, 2015 11:59 AM >> >> On Wed, Nov 4, 2015 at 9:39 PM, Sowmini Varadhan >>

Re: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

Firmware or IDPROM, an > explicit write is needed via i40e_aq_mac_address_write() and > i40e_aq_add_macvlan() invocation. > Few comments (mostly stylish) And take my Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> > Reviewed-by: Martin K. Petersen <martin.peter...@orac

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

t_mac_address(dp); > + if (!addr) > + addr = arch_get_platform_mac_address(); > + > + if (addr) { What about if (!addr) return -ENODATA; (Yes, ENODATA looks suitable for me) > + ether_addr_copy(mac_addr, addr); > + return 0; > + } > + > + return -ENODEV; > +} > +EXPORT_SYMBOL(eth_platform_get_mac_address); -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

On Thu, Nov 5, 2015 at 8:31 PM, David Miller <da...@davemloft.net> wrote: > From: Andy Shevchenko <andy.shevche...@gmail.com> > Date: Thu, 5 Nov 2015 20:13:21 +0200 > >> What about >> >> if (!addr) >> return -ENODATA; > > I totally disag

Re: [PATCH v4] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

lt; 0) > +#define MDIO_CMD_GOBIT(31) > +#define MDIO_CMD_WRBIT(26) > + > +#define NB8800_MDIO_STS0x24 > +#define MDIO_STS_ERR BIT(31) > + > +#define NB8800_MC_ADDR(i) (0x28 + (i)) > +#define NB8800_MC_INIT 0x2e > +#define NB8800_UC_ADDR(i) (0x3c + (i)) > + > +#define NB8800_MAC_MODE0x44 > +#define RGMII_MODE BIT(7) > +#define HALF_DUPLEXBIT(4) > +#define BURST_EN BIT(3) > +#define LOOPBACK_ENBIT(2) > +#define GMAC_MODE BIT(0) > + > +#define NB8800_IC_THRESHOLD0x50 > +#define NB8800_PE_THRESHOLD0x51 > +#define NB8800_PF_THRESHOLD0x52 > +#define NB8800_TX_BUFSIZE 0x54 > +#define NB8800_FIFO_CTL0x56 > +#define NB8800_PQ1 0x60 > +#define NB8800_PQ2 0x61 > +#define NB8800_SRC_ADDR(i) (0x6a + (i)) > +#define NB8800_STAT_DATA 0x78 > +#define NB8800_STAT_INDEX 0x7c > +#define NB8800_STAT_CLEAR 0x7d > + > +#define NB8800_SLEEP_MODE 0x7e > +#define SLEEP_MODE BIT(0) > + > +#define NB8800_WAKEUP 0x7f > +#define WAKEUP BIT(0) > + > +#define NB8800_TXC_CR 0x100 > +#define TCR_LK BIT(12) > +#define TCR_DS BIT(11) > +#define TCR_BTS(x) (((x) & 0x7) << 8) > +#define TCR_DIEBIT(7) > +#define TCR_TFI(x) (((x) & 0x7) << 4) > +#define TCR_LE BIT(3) > +#define TCR_RS BIT(2) > +#define TCR_DM BIT(1) > +#define TCR_EN BIT(0) > + > +#define NB8800_TXC_SR 0x104 > +#define TSR_DE BIT(3) > +#define TSR_DI BIT(2) > +#define TSR_TO BIT(1) > +#define TSR_TI BIT(0) > + > +#define NB8800_TX_SAR 0x108 > +#define NB8800_TX_DESC_ADDR0x10c > + > +#define NB8800_TX_REPORT_ADDR 0x110 > +#define TX_BYTES_TRASFERRED(x) (((x) >> 16) & 0x) > +#define TX_FIRST_DEFERRAL BIT(7) > +#define TX_EARLY_COLLISIONS(x) (((x) >> 3) & 0xf) > +#define TX_LATE_COLLISION BIT(2) > +#define TX_PACKET_DROPPED BIT(1) > +#define TX_FIFO_UNDERRUN BIT(0) > +#define IS_TX_ERROR(r) ((r) & 0x87) > + > +#define NB8800_TX_FIFO_SR 0x114 > +#define NB8800_TX_ITR 0x118 > + > +#define NB8800_RXC_CR 0x200 > +#define RCR_FL BIT(13) > +#define RCR_LK BIT(12) > +#define RCR_DS BIT(11) > +#define RCR_BTS(x) (((x) & 7) << 8) > +#define RCR_DIEBIT(7) > +#define RCR_RFI(x) (((x) & 7) << 4) > +#define RCR_LE BIT(3) > +#define RCR_RS BIT(2) > +#define RCR_DM BIT(1) > +#define RCR_EN BIT(0) > + > +#define NB8800_RXC_SR 0x204 > +#define RSR_DE BIT(3) > +#define RSR_DI BIT(2) > +#define RSR_RO BIT(1) > +#define RSR_RI BIT(0) > + > +#define NB8800_RX_SAR 0x208 > +#define NB8800_RX_DESC_ADDR0x20c > + > +#define NB8800_RX_REPORT_ADDR 0x210 > +#define RX_BYTES_TRANSFERRED(x)(((x) >> 16) & 0x) > +#define RX_MULTICAST_PKT BIT(9) > +#define RX_BROADCAST_PKT BIT(8) > +#define RX_LENGTH_ERR BIT(7) > +#define RX_FCS_ERR BIT(6) > +#define RX_RUNT_PKTBIT(5) > +#define RX_FIFO_OVERRUNBIT(4) > +#define RX_LATE_COLLISION BIT(3) > +#define RX_FRAME_LEN_ERROR BIT(2) > +#define RX_ERROR_MASK 0xfc > +#define IS_RX_ERROR(r) ((r) & RX_ERROR_MASK) > + > +#define NB8800_RX_FIFO_SR 0x214 > +#define NB8800_RX_ITR 0x218 > + > +/* Sigma Designs SMP86xx additional registers */ > +#define NB8800_TANGOX_PAD_MODE 0x400 > +#define NB8800_TANGOX_MDIO_CLKDIV 0x420 > +#define NB8800_TANGOX_RESET0x424 > + -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On Sat, Oct 31, 2015 at 8:41 PM, Måns Rullgård <m...@mansr.com> wrote: > Andy Shevchenko <andy.shevche...@gmail.com> writes: > >>> +static int nb8800_mdio_read(struct mii_bus *bus, int phy_id, int reg) >>> +{ >>> + struct nb880

Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM

s in Open Firmware > on systems that support it, and use IDPROM on SPARC if no OF address > is found. > > Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> > Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Few nitpicks below, otherwise: Reviewed-by: And

Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM

On Fri, Oct 30, 2015 at 8:12 PM, Sowmini Varadhan <sowmini.varad...@oracle.com> wrote: > On (10/30/15 20:06), Andy Shevchenko wrote: >> >> > +#include "i40e.h" >> >> Why do you need this one exactly? > > I needed it to find p

[PATCH 1/1] i40e: re-use %*ph specifier to hexdump a data

Instead of using a custom approach change the code to use %*ph format specifier. Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- drivers/net/ethernet/intel/i40e/i40e_common.c | 22 -- drivers/net/ethernet/intel/i40evf/i40e_common.

[PATCH v1 1/2] net:hns: annotate IO address space properly

.../hns/hns_dsaf_reg.h:991:36:got void *base Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_re

[PATCH v1 2/2] net:hns: print MAC with %pM

printf() has a dedicated specifier to print MAC addresses. Use it instead of pushing each byte via stack. Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 49 +++--- 1 file changed, 14 insertions(

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

else > + memcpy(*fw, fw_entry->data, fw_entry->size); > > release_firmware(fw_entry); > > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.

Re: [PATCH 24/28] net: pch_gbe: add device tree support

pdata && adapter->pdata->platform_init) > adapter->pdata->platform_init(pdev, pdata); > > @@ -2729,6 +2759,7 @@ err_free_adapter: > pch_gbe_hal_phy_hw_reset(>hw); > err_free_netdev: > free_netdev(netdev); > +err_out: Redundant. > return ret; > } For now it's a common practice to mix styles in probe due to usage of devres API. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] vhost: replace % with & on data path

Tested-by: Venkatesh Srinivas <venkate...@google.com> > > -- vs; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH] mwifiex: correctly handling kzalloc

card->mp_tx_agg_buf_size, > card->mp_rx_agg_buf_size); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord.

Re: [PATCH 06/10] net: hns: use to_platform_device()

rg > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method

+ ret = -ENOMEM; >> + } >> >> release_firmware(fw_entry); >> >> -- >> 2.6.1 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.

Re: [PATCH] libertas: fix possible NULL dereference

f a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: stmmac: add a warning when aliases are not present in device tree

.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Bes

Re: [patch v2 net-next 12/13] net: hns: implement the miscellaneous operation by asl

Y_INTERFACE_MODE_XGMII : PHY_INTERFACE_MODE_SGMII; > + > + dev_dbg(mac_cb->dev, "mac_id=%d, phy_if=%d\n", mac_cb- > >mac_id, phy_if); > + + exit_free: > + ACPI_FREE(obj); > + > + return phy_if; > +} > -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [patch v2 net-next 00/13] net: hns: add support of ACPI

omments in mind, which I didn't put here, though there is one you perhaps need to address. Otherwise FWIW: Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > > change log: >  v1 -> v2: >  1. use acpi_dev_found() instead of acpi_match_device_ids() to check &

[PATCH v1 1/1] net/lapb: tuse %*ph to dump buffers

Use %*ph specifier to dump small buffers in hex format instead doing this byte-by-byte. Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- net/lapb/lapb_in.c | 5 ++--- net/lapb/lapb_out.c | 4 +--- net/lapb/lapb_subr.c | 14 +- 3 files changed, 8 inse

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

p[13 + i + DSAF_PRIO_NR] = hw_stats- > >tx_pfc[i]; > + } Two different approaches how to assign data. Above uses 2 for-loops, here you put everything to one. > + p[29] = hw_stats->tx_pkts; > + return [30]; > + } >   > + p[13] = hw_stats->tx_pkts; >   return [14]; >  } -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [PATCH net-next 01/19] net: hns: bug fix of ge reset sequence

1(dsaf_dev->dsaf_ver) ? 0x100 : 0x40; reg_val_1 <<= dsaf_dev->reset_offset; reg_val_2 <<= dsaf_dev- >reset_offset; >   >   if (!dereset) { >   dsaf_write_sub(dsaf_dev, > DSAF_SUB_SC_GE_RESET_REQ1_REG, -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

On Wed, 2016-06-22 at 09:43 +0800, Yisen Zhuang wrote: > > 在 2016/6/21 18:32, Andy Shevchenko 写道: > > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: > > > From: Daode Huang <huangda...@hisilicon.com> > > > > > > For SoC hip06, PFC pause ha

Re: [PATCH v2 4/4] param: convert some "on"/"off" users to strtobool

ck-sched.c b/kernel/time/tick-sched.c > index 9d7a053545f5..b57f822c2069 100644 > --- a/kernel/time/tick-sched.c > +++ b/kernel/time/tick-sched.c > @@ -387,20 +387,14 @@ void __init tick_nohz_init(void) > /* > * NO HZ enabled ? > */ > -int tick_nohz_enabled __read_mostly = 1; > +bool tick_nohz_enabled __read_mostly = true; > unsigned long tick_nohz_active __read_mostly; > /* > * Enable / Disable tickless mode > */ > static int __init setup_tick_nohz(char *str) > { > - if (!strcmp(str, "off")) > - tick_nohz_enabled = 0; > - else if (!strcmp(str, "on")) > - tick_nohz_enabled = 1; > - else > - return 0; > - return 1; > + return kstrtobool(str, 0, _nohz_enabled); > } > > __setup("nohz=", setup_tick_nohz); > -- > 2.6.3 > -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 1/4] lib: move strtobool to kstrtobool

; Signed-off-by: Kees Cook <keesc...@chromium.org> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> One minor below. > --- > include/linux/kernel.h | 3 +++ > include/linux/string.h | 6 +- > lib/kstrtox.c | 35 +

Re: [PATCH v2 2/4] lib: update single-char callers of strtobool

glob.h > index a25b2513f146..d21da9f05bae 100644 > --- a/fs/cifs/cifsglob.h > +++ b/fs/cifs/cifsglob.h > @@ -1596,11 +1596,11 @@ GLOBAL_EXTERN atomic_t midCount; > > /* Misc globals */ > GLOBAL_EXTERN bool enable_oplocks; /* enable or disable oplocks */ > -GLOBAL_EXTERN unsigned int lookupCacheEnabled; > +GLOBAL_EXTERN bool lookupCacheEnabled; > GLOBAL_EXTERN unsigned int global_secflags;/* if on, session setup sent > with more secure ntlmssp2 challenge/resp */ > GLOBAL_EXTERN unsigned int sign_CIFS_PDUs; /* enable smb packet signing */ > -GLOBAL_EXTERN unsigned int linuxExtEnabled;/*enable Linux/Unix CIFS > extensions*/ > +GLOBAL_EXTERN bool linuxExtEnabled;/*enable Linux/Unix CIFS extensions*/ > GLOBAL_EXTERN unsigned int CIFSMaxBufSize; /* max size not including hdr */ > GLOBAL_EXTERN unsigned int cifs_min_rcv;/* min size of big ntwrk buf > pool */ > GLOBAL_EXTERN unsigned int cifs_min_small; /* min size of small buf pool */ > -- > 2.6.3 > -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool

urn 0; > + case 'f': > + case 'F': > + *res = false; > + return 0; > + default: > + break; > + } > default: > break; > } > -- > 2.6.3 > -- With Best Regards, Andy Shevchenko

Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

ly okay, though I would recommend to move long string literal to the next line. -- With Best Regards, Andy Shevchenko

Re: [PATCH 1/3] lib: fix callers of strtobool to use char array

lob.h b/fs/cifs/cifsglob.h > index a25b2513f146..d21da9f05bae 100644 > --- a/fs/cifs/cifsglob.h > +++ b/fs/cifs/cifsglob.h > @@ -1596,11 +1596,11 @@ GLOBAL_EXTERN atomic_t midCount; > > /* Misc globals */ > GLOBAL_EXTERN bool enable_oplocks; /* enable or disable oplocks */ > -GLOBAL_EXTERN unsigned int lookupCacheEnabled; > +GLOBAL_EXTERN bool lookupCacheEnabled; > GLOBAL_EXTERN unsigned int global_secflags;/* if on, session setup sent > with more secure ntlmssp2 challenge/resp */ > GLOBAL_EXTERN unsigned int sign_CIFS_PDUs; /* enable smb packet signing */ > -GLOBAL_EXTERN unsigned int linuxExtEnabled;/*enable Linux/Unix CIFS > extensions*/ > +GLOBAL_EXTERN bool linuxExtEnabled;/*enable Linux/Unix CIFS extensions*/ > GLOBAL_EXTERN unsigned int CIFSMaxBufSize; /* max size not including hdr */ > GLOBAL_EXTERN unsigned int cifs_min_rcv;/* min size of big ntwrk buf > pool */ > GLOBAL_EXTERN unsigned int cifs_min_small; /* min size of small buf pool */ > -- > 2.6.3 > -- With Best Regards, Andy Shevchenko

Re: [patch net 1/2] net: hns: fix return value of the function about rss

nst > u32 *indir, const u8 *key, >   >   ret = ops->set_rss(priv->ae_handle, indir, key, hfunc); >   > - return 0; > + return ret; Ditto. -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [patch net 2/2] net: hns: fixes a bug of RSS

return ret; Redundant ret variable. switch (value) { case X:  break; default:  return -ERRNO; } return 0; > +} -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool

; can > not get the tatal table each time. > FWIW: Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > change log: > PATCH v3: >  - This patchset fixes the building warning and error > > PATCH v2: >  - This patchset fixes the comments provid

Re: [PATCH] mwifiex: fix possible NULL dereference

On Tue, Apr 12, 2016 at 8:43 PM, Rustad, Mark D <mark.d.rus...@intel.com> wrote: > Andy Shevchenko <andy.shevche...@gmail.com> wrote: > >> On Mon, Apr 11, 2016 at 6:27 PM, Sudip Mukherjee >> <sudipm.mukher...@gmail.com> wrote: >>> >>>

Re: [PATCH] mwifiex: fix possible NULL dereference

for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++) > synchronize_irq(card->msix_entries[i].vector); > -- > 1.9.1 > -- With Best Regards, Andy Shevchenko

Re: [PATCH net 4/4] net: hns: remove useless head=ring->next_to_clean

eadl_relaxed(ring->io_base + RCB_REG_HEAD); > + int head = readl_relaxed(ring->io_base + RCB_REG_HEAD); >   >   if (head != ring->next_to_clean) { >   ring_data->ring->q->handle->dev->ops- > >toggle_ring_irq( -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [PATCH net 4/4] net: hns: remove useless head=ring->next_to_clean

On Tue, 2016-03-08 at 16:02 +0800, Lisheng011 wrote: > > 在 2016/3/8 15:18, Andy Shevchenko 写道: > > > > On Tue, 2016-03-08 at 11:52 +0800, Lisheng wrote: > > > > > > From: Qianqian Xie <xieqianq...@huawei.com> > > > > > &g

Re: [PATCH net] net: hns: fix the bug about loopback

dev->dev_addr, 6); ether_addr_copy() ? > + skb->data[5] += 0x1f; This has to be explained. > + } > + > + frame_size &= ~1ul; And how 1ul is different to plain 1 here? > + memset(>data[frame_size / 2], 0xAA, frame_size / 2 - > 1); > + memset(>data[frame_size / 2 + 10], 0xBE, frame_size / 2 > - 11); > + memset(>data[frame_size / 2 + 12], 0xAF, frame_size / 2 > - 13); Magic numbers have to be explained. Also, what is the logic to overwrite the data if frame_size is big enough? > +} > + -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [PATCH net-next] net: hns: add support of pause frame ctrl for HNS V2

G + mac_id > * 4, 0xff); > + *en = dsaf_get_dev_bit(dsaf_dev, > +    DSAF_PAUSE_CFG_REG + mac_id * > 4, > +    DSAF_MAC_PAUSE_RX_EN_B); And what the point of if branch then? I think it's an obvious misfix, you must repla

Re: [patch net-next 01/11] net: hisilicon: add support of acpi for hns-mdio

/* Mask out all PHYs from auto probing. */ > + new_bus->phy_mask = ~0; > + > + /* Register the MDIO bus */ > + ret = mdiobus_register(new_bus); > + if (ret) > + return ret; > + } else { > + dev_err(>dev, "cannot get cfd data from of or > acpi\n"); Same as for previous message. > + return -ENXIO; > + } > + >   if (ret) { >   dev_err(>dev, "Cannot register as MDIO > bus!\n"); >   platform_set_drvdata(pdev, NULL); > @@ -499,12 +527,19 @@ static const struct of_device_id > hns_mdio_match[] = { >   {} >  }; >   > +static const struct acpi_device_id hns_mdio_acpi_match[] = { > + { "HISI0141", 0 }, > + { }, > +}; > +MODULE_DEVICE_TABLE(acpi, hns_mdio_acpi_match); > + >  static struct platform_driver hns_mdio_driver = { >   .probe = hns_mdio_probe, >   .remove = hns_mdio_remove, >   .driver = { >      .name = MDIO_DRV_NAME, >      .of_match_table = hns_mdio_match, > +    .acpi_match_table = ACPI_PTR(hns_mdio_acpi_match), >      }, >  }; >   So, I suggest to split this to two logical changes: 1. Move to use fwnode_handle 2. Add ACPI bits -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [patch net-next 04/11] net: hns: enet specify a reference to dsaf by fwnode_handle

dev_err(dev, "not find ae-handle\n"); >   goto out_read_prop_fail; >   } > - /* try to find port-idx-in-ae first */ > + priv->fwnode = _node->fwnode; > + >   ret = device_property_read_u32(dev, "port-idx-in-ae", > _id); >   if (ret) { >   /* only for old code compatible */ > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.h > b/drivers/net/ethernet/hisilicon/hns/hns_enet.h > index 337efa5..44bb301 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.h > +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.h > @@ -54,7 +54,7 @@ struct hns_nic_ops { >  }; >   >  struct hns_nic_priv { > - const struct device_node *ae_node; > + const struct fwnode_handle  *fwnode; >   u32 enet_ver; >   u32 port_id; >   int phy_mode; -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi

T/platform code. Too many changes where IS_ENABLED() involved shows as I can imagine bad architecture / split of the driver. -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [patch net-next 05/11] net: hns: add uniform interface for phy connection

 hns_nic_adjust_link, 0, h- > >phy_if); > + phy_dev = hns_nic_phy_connect(ndev, phy_dev, > +       hns_nic_adjust_link, > +   0, h->phy_if); >   else > - phy_dev = of_phy_attach(ndev, h->phy_node, 0, h- > >phy_if); > + phy_dev = hns_nic_phy_attach(ndev, phy_dev, 0, h- > >phy_if); -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to linux/acpi.h

only once to some big part of code. If kernel is build without ACPI support you even will not have this in your driver at all. --  Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

[PATCH v1 1/1] ISDN: eicon: replace custom hex_asc_lo() / hex_pack_byte()

Instead of custom approach re-use generic helpers to convert byte to hex format. Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- drivers/isdn/hardware/eicon/message.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/driver

Re: [PATCH net-next 6/9] net: hns: normalize two different loop

On Mon, 2016-06-27 at 05:08 -0700, Joe Perches wrote: > On Mon, 2016-06-27 at 15:00 +0300, Andy Shevchenko wrote: > > On Mon, 2016-06-27 at 04:49 -0700, Joe Perches wrote: > > > > > > On Mon, 2016-06-27 at 17:54 +0800, Yisen Zhuang wrote: > > > &

Re: [PATCH net-next 6/9] net: hns: normalize two different loop

snprintf(buff + 1 * ETH_GSTRING_LEN * > > DSAF_PRIO_NR, > > +  ETH_GSTRING_LEN, > > "onod%d_pfc_prio%d_pkts", > > +  node, i); > >   buff += ETH_GSTRING_LEN; > > This looks

Re: [PATCH] net: ethernet: stmmac: add ARP management

t be too noisy? pr_* -> dev_* > + /* Copy MAC addr into MAC_ARP_ADDRESS register*/ > + priv->hw->dma->set_arp_addr(priv->ioaddr, 1, > + priv->dev->dev_addr); > + } > + } -- With Best Regards, Andy Shevchenko

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 01/17/2017 03:34 PM, Andy Shevchenko wrote: >> On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli <f.faine...@gmail.com> >> wrote: >>> +static int device_class_name_m

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

On Wed, Jan 18, 2017 at 2:04 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 01/17/2017 04:00 PM, Andy Shevchenko wrote: >> On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli <f.faine...@gmail.com> >> wrote: >>> On 01/17/2017 03:34 PM, Andy Shevchenko w

Re: [PATCHv2 5/7] TAP: Extending tap device create/destroy APIs

On Wed, Jan 18, 2017 at 2:03 AM, Sainath Grandhi <sainath.gran...@intel.com> wrote: > Extending tap APIs get/free_minor and create/destroy_cdev to handle more than > one > type of virtual interface. > Yes, looks better now. FWIW: Reviewed-by: Andy Shevchenko <andy

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

} > + > + return device_find_child(parent, class_name, device_class_name_match); > +} > +EXPORT_SYMBOL_GPL(device_find_in_class_name); > +extern struct device *device_find_in_class_name(struct device *parent, > + char *class_name); Ditto. -- With Best Regards, Andy Shevchenko

[PATCH v1 1/1] ISDN: eicon: replace custom hex_dump_to_buffer()

Instead of custom approach re-use generic helper to convert bytes to hex format. The output is slightly changed, namely string starts from the first dword value. Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- drivers/isdn/hardware/eicon/message.

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

IS_BUILTIN(CONFIG_ARCH_PXA) && ((r) & 2) &&\ > +lp->half_word_align4) Hmm... Isn't enough to have just (r) & 2 && lp->half_word_align4 ? -- With Best Regards, Andy Shevchenko

Re: Synopsys Ethernet QoS Driver

we can keep driver's name in the structure in async with file name). -- With Best Regards, Andy Shevchenko

Re: Synopsys Ethernet QoS

future. Wait, you would like to tell that we have more than 2 drivers for the same (okay, same vendor) IP?! It's better to unify them earlier, than have n+ copies. P.S. Though, I don't see how sxgbe got in the list. First glance on the code doesn't show similarities. -- With Best Regards, Andy Shevchenko

Re: Synopsys Ethernet QoS

"stmmac" driver. > > Therefore, if consolidation changes the driver module name for > existing users, then that is not a good plan at all. You have at least one supporter here. Though I jumped in to the discussion very late, not sure if everyone have time to answer to that. -- With Best Regards, Andy Shevchenko

Re: [PATCH] net: stmmac: fix maxmtu assignment to be within valid range

_PAD + NET_IP_ALIGN); > - if (priv->plat->maxmtu < ndev->max_mtu) > + if ((priv->plat->maxmtu < ndev->max_mtu) && > + (priv->plat->maxmtu >= ndev->min_mtu)) > ndev->max_mtu = priv->plat->maxmtu; Perhaps add a warning message on else branch? -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 4/7] x86: put msr-index.h in uapi

On Fri, Jan 6, 2017 at 11:43 AM, Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: > This header file is exported, thus move it to uapi. Just hint for the future: -M (move) -C (copy) -D (delete) [though this is NOT for applying] -- With Best Regards, Andy Shevchenko

Re: [PATCHv1 1/7] TAP: Refactoring macvtap.c

(-) > delete mode 100644 drivers/net/macvtap.c > create mode 100644 drivers/net/macvtap_main.c > create mode 100644 drivers/net/tap.c > create mode 100644 include/linux/if_macvtap.h Can you use -M -C for better view of this change? It's really hard to review. -- With Best Regards, Andy Shevchenko

Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

d_tail(_major->next, _list); > + return err; > + err = tap_list_add(*tap_major, device_name); > > return err; return tap_list_add(); > void tap_destroy_cdev(dev_t major, struct cdev *tap_cdev) > { > + struct major_info *tap_major, *tmp; > + bool found = false;

Re: [PATCH v4] net: stmmac: fix maxmtu assignment to be within valid range

v->min_mtu) || > +(priv->plat->maxmtu > ndev->max_mtu)) > + netdev_warn(priv->dev, What is the difference to just 'else'? (Returning back to my initial proposal, I don't remember telling anything about 'else if' concept) > + "%s: warning: maxmtu having invalid value (%d)\n", > + __func__, priv->plat->maxmtu); -- With Best Regards, Andy Shevchenko

Re: [PATCH v3] net: stmmac: fix maxmtu assignment to be within valid range

int common_default_data() {...} >> and call it at the beginning of the rest of *_defautl_data() hooks. >> > > Just try to understand, are you referring changing the code something > like this: > > stmmac_default_data(plat); > if (info) { > info->pdev = pdev; > if (info->setup) { > ret = info->setup(plat, info); > if (ret) > return ret; > } > } > > Where all the common code is inside the stmmac_default_data()? No. common_default_data() { ... common defaults among *_default_data() ... } *_default_data() { ... common_default_data(); ... } -- With Best Regards, Andy Shevchenko

Re: [PATCH v5] net: stmmac: fix maxmtu assignment to be within valid range

ndition to > ensure the assignment is made within a valid range. FWIW: Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> > > Signed-off-by: Kweh, Hock Leong <hock.leong.k...@intel.com> > --- > changelog v5: > * revert back that plat->maxmtu > ndev-

Re: [PATCH v3] net: stmmac: fix maxmtu assignment to be within valid range

t; + plat->maxmtu = JUMBO_LEN; Please, use *_default_data() hooks for that. At some point it might make sense to extract static int common_default_data() {...} and call it at the beginning of the rest of *_defautl_data() hooks. -- With Best Regards, Andy Shevchenko

Re: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

netdev/msg410864.html -- With Best Regards, Andy Shevchenko

Re: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

On Wed, Dec 21, 2016 at 2:16 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Wed, Dec 21, 2016 at 1:53 PM, Bartosz Folta <bfo...@cadence.com> wrote: >> I think that there is a delay on some mailing lists (marc.info and >> mail-archive.com). Latest mess

Re: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

remove(struct pci_dev *pdev) > +{ > + struct platform_device *plat_dev = pci_get_drvdata(pdev); > + struct macb_platform_data *plat_data = > dev_get_platdata(_dev->dev); > + > + platform_device_unregister(plat_dev); > + pci_disable_device(pdev); Ditto. > + clk_unregister(plat_data->pclk); > + clk_unregister(plat_data->hclk); > +} -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] NFC: Add nfc_dbg() macro

On Wed, 2017-03-22 at 21:22 +0200, Andy Shevchenko wrote: > In some cases nfc_dbg() is useful. Add such macro to a header. > I think we may drop this, since the idea is to get rid of such macros (as I read back in 2011 in commit message of change that removed nfc_dbg() one). I will

[PATCH v1] NFC: netlink: Use error code from nfc_activate_target()

-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- net/nfc/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c index 03f3d5c7beb8..03be522127ec 100644 --- a/net/nfc/netlink.c +++ b/net/nfc/netlink.c @@ -918,7 +918,7 @@

[PATCH v1] NFC: Add nfc_dbg() macro

In some cases nfc_dbg() is useful. Add such macro to a header. Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> --- include/net/nfc/nfc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net/nfc/nfc.h b/include/net/nfc/nfc.h index 1a3de8b34ad2..bbdc73a3239d

Re: [PATCH 18/22] gpio: acpi: fix string overflow for large pin numbers

est_interrupt(struct acpi_resource *ares, >   char ev_name[5]; >   sprintf(ev_name, "_%c%02X", >   agpio->triggering == ACPI_EDGE_SENSITIVE ? > 'E' : 'L', > - pin); > + (u8)pin); >   if (ACPI_SUCCESS(acpi_get_handle(handle, ev_name, > _handle))) >   handler = acpi_gpio_irq_handler; >   } -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning

On Fri, Jul 14, 2017 at 10:37 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Fri, Jul 14, 2017 at 9:18 PM, Andy Shevchenko > <andy.shevche...@gmail.com> wrote: >> On Fri, Jul 14, 2017 at 3:07 PM, Arnd Bergmann <a...@arndb.de> wrote: >>> gcc points out a poss

Re: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning

+ b/drivers/platform/x86/alienware-wmi.c > @@ -421,7 +421,7 @@ static DEVICE_ATTR(lighting_control_state, 0644, > show_control_state, > static int alienware_zone_init(struct platform_device *dev) > { > int i; > - char buffer[10]; > + char buffer[13]; > char *name; > > if (interface == WMAX) { > -- > 2.9.0 > -- With Best Regards, Andy Shevchenko

  1   2   3   >