RE: [PATCH] bnx2x: Alloc 4k fragment for each rx ring buffer element

Hi Gabriel, Thanks for pointing out this shortcoming. However, I don't think that the solution you suggested would work as is. @@ -628,21 +644,30 @@ static int bnx2x_fill_frag_skb(struct bnx2x *bp, struct bnx2x_fastpath *fp, bnx2x_fp_qstats(bp, fp)-rx_skb_alloc_failed++;

RE: [BUG] bnx2x_config_vlan_mac called a NULL function pointer

Looking into it... > -Original Message- > From: Otto Sabart [mailto:osab...@redhat.com] > Sent: Thursday, October 22, 2015 10:45 PM > To: netdev <netdev@vger.kernel.org> > Cc: Ariel Elior <ariel.el...@qlogic.com>; Adam Okuliar <aokul...@redhat.com>; >

RE: bnx2x - occasional high packet loss (on LAN)

Hi Nikola, Please provide dmesg output from your system. Thanks, Ariel > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Nikola Ciprich > Sent: Tuesday, September 15, 2015 7:17 AM > To: netdev > Cc:

RE: [RFC v2 net-next 00/10] Add new drivers: qed & qede

> -Original Message- > From: Yuval Mintz [mailto:yuval.mi...@qlogic.com] > Sent: Thursday, September 17, 2015 5:24 PM > To: netdev <netdev@vger.kernel.org> > Cc: Ariel Elior <ariel.el...@qlogic.com>; Yuval Mintz <yuval.mi...@qlogic.com> > Subject: [RF

RE: bnx2x - occasional high packet loss (on LAN)

> -Original Message- > From: Nikola Ciprich [mailto:nikola.cipr...@linuxbox.cz] > Sent: Monday, September 21, 2015 1:32 PM > To: Ariel Elior <ariel.el...@qlogic.com> > Cc: netdev <netdev@vger.kernel.org>; n...@linuxbox.cz > Subject: Re: bnx2x - occas

RE: [PATCH] bnx2x:Fix error handling and return statement in the function bnx2x_vf_init

> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Thursday, November 19, 2015 5:31 AM > To: Ariel Elior <ariel.el...@qlogic.com> > Cc: netdev <netdev@vger.kernel.org>; linux-kernel > <linux-ker...@vger.kernel.org> > Su

RE: bnx2x commits needed to use 7.51.10 firmware?

+Yuval > -Original Message- > From: Dan Streetman [mailto:dan.street...@canonical.com] > Sent: Wednesday, February 03, 2016 2:20 AM > To: Ariel Elior <ariel.el...@qlogic.com> > Cc: netdev <netdev@vger.kernel.org> > Subject: bnx2x commits needed to use 7

RE: [PATCH net 0/7] bnx2x: endianness fixes

> -Original Message- > From: Michal Schmidt [mailto:mschm...@redhat.com] > Sent: Wednesday, March 02, 2016 2:47 PM > To: netdev <netdev@vger.kernel.org> > Cc: Yuval Mintz <yuval.mi...@qlogic.com>; Ariel Elior <ariel.el...@qlogic.com> > Subject: [PA

RE: [PATCH 2/2] bnx2x:Fix error handling for functions in bnx2x_link.c

> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Monday, March 07, 2016 4:12 AM > To: Ariel Elior <ariel.el...@qlogic.com> > Cc: netdev <netdev@vger.kernel.org>; linux-kernel > <linux-ker...@vger.kernel.org> > Subjec

RE: [PATCH 1/2] bnx2x:Fix error handling for the function bnx2x_set_mutl_gpio

> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Monday, March 07, 2016 4:05 AM > To: Ariel Elior <ariel.el...@qlogic.com> > Cc: netdev <netdev@vger.kernel.org>; linux-kernel > <linux-ker...@vger.kernel.org> > Subjec

[PATCH net-next v2 6/6] qede: Register l2 queues with doorbell overflow recovery mechanism

All L2 queues funnel through this flow, so this would cover the regular RSS queues, as well queues created for VFs, mqos queues, xdp queues, etc. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qede/qede_main.c | 9

[PATCH net-next v2 1/6] qed: Add doorbell overflow recovery mechanism

Add the database used to register doorbelling entities, and APIs for adding and deleting entries, and logic for traversing the database and doorbelling once on behalf of all entities. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet

[PATCH net-next 0/6 v2] qed*: Doorbell overflow recovery

entities, and APIs for adding and deleting entries, and logic for traversing the database and doorbelling once on behalf of all entities. Please consider applying to net-next. Thanks, Ariel Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar v1->v2: ---

[PATCH net-next v2 5/6] qed: Expose the doorbell overflow recovery mechanism to the protocol drivers

Most of the doorbelling entities are outside of the core module. L2 queues, Roce queues, iscsi and fcoe all need to register. Make the APIs available for these drivers. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed

[PATCH net-next v2 3/6] qed: Register slowpath queue doorbell with doorbell overflow recovery mechanism

Slow path queue is a doorbelling entity. Register it with the overflow mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed_sp.h | 4 ++- drivers/net/ethernet/qlogic/qed/qed_spq.c | 47

[PATCH net-next v2 4/6] qed: Register light L2 queues with doorbell overflow recovery mechanism

Light L2 queues are doorbelling entities. Modify the implementation to keep the doorbell data necessary for doorbelling in well known location instead of recomputing every time. Register the LL2 queue with doorbell recovery mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon

[PATCH net-next v2 2/6] qed: Use the doorbell overflow recovery mechanism in case of doorbell overflow

been missed. After a set time with no indications, terminate the periodic task. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed.h | 14 ++- drivers/net/ethernet/qlogic/qed/qed_dev.c | 14 ++- drivers

[PATCH net-next v3 2/6] qed: Use the doorbell overflow recovery mechanism in case of doorbell overflow

been missed. After a set time with no indications, terminate the periodic task. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed.h | 14 ++- drivers/net/ethernet/qlogic/qed/qed_dev.c | 14 ++- drivers

[PATCH net-next v3 1/6] qed: Add doorbell overflow recovery mechanism

Add the database used to register doorbelling entities, and APIs for adding and deleting entries, and logic for traversing the database and doorbelling once on behalf of all entities. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet

[PATCH net-next v3 6/6] qede: Register l2 queues with doorbell overflow recovery mechanism

All L2 queues funnel through this flow, so this would cover the regular RSS queues, as well queues created for VFs, mqos queues, xdp queues, etc. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qede/qede_main.c | 9

[PATCH net-next v3 3/6] qed: Register slowpath queue doorbell with doorbell overflow recovery mechanism

Slow path queue is a doorbelling entity. Register it with the overflow mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed_sp.h | 4 ++- drivers/net/ethernet/qlogic/qed/qed_spq.c | 47

[PATCH net-next v3 4/6] qed: Register light L2 queues with doorbell overflow recovery mechanism

Light L2 queues are doorbelling entities. Modify the implementation to keep the doorbell data necessary for doorbelling in well known location instead of recomputing every time. Register the LL2 queue with doorbell recovery mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon

[PATCH net-next 0/6 v2] qed*: Doorbell overflow recovery

entities, and APIs for adding and deleting entries, and logic for traversing the database and doorbelling once on behalf of all entities. Please consider applying to net-next. Thanks, Ariel Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar v1->v2: ---

[PATCH net-next v3 5/6] qed: Expose the doorbell overflow recovery mechanism to the protocol drivers

Most of the doorbelling entities are outside of the core module. L2 queues, Roce queues, iscsi and fcoe all need to register. Make the APIs available for these drivers. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed

[PATCH net-next 0/6] qed*: Doorbell overflow recovery

entities, and APIs for adding and deleting entries, and logic for traversing the database and doorbelling once on behalf of all entities. Please consider applying to net-next. Thanks, Ariel Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar Ariel Elior (6

[PATCH net-next 6/6] qede: Register l2 queues with doorbell overflow recovery mechanism

All L2 queues funnel through this flow, so this would cover the regular RSS queues, as well queues created for VFs, mqos queues, xdp queues, etc. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qede/qede_main.c | 9

[PATCH net-next 4/6] qed: Register light L2 queues with doorbell overflow recovery mechanism

Light L2 queues are doorbelling entities. Modify the implementation to keep the doorbell data necessary for doorbelling in well known location instead of recomputing every time. Register the LL2 queue with doorbell recovery mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon

[PATCH net-next 3/6] qed: Register slowpath queue doorbell with doorbell overflow recovery mechanism

Slow path queue is a doorbelling entity. Register it with the overflow mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed_sp.h | 4 ++- drivers/net/ethernet/qlogic/qed/qed_spq.c | 47

[PATCH net-next 2/6] qed: Use the doorbell overflow recovery mechanism in case of doorbell overflow

been missed. After a set time with no indications, terminate the periodic task. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed.h | 14 ++- drivers/net/ethernet/qlogic/qed/qed_dev.c | 14 ++- drivers

[PATCH net-next 1/6] qed: Add doorbell overflow recovery mechanism

Add the database used to register doorbelling entities, and APIs for adding and deleting entries, and logic for traversing the database and doorbelling once on behalf of all entities. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet

[PATCH net-next 5/6] qed: Expose the doorbell overflow recovery mechanism to the protocol drivers

Most of the doorbelling entities are outside of the core module. L2 queues, Roce queues, iscsi and fcoe all need to register. Make the APIs available for these drivers. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed

[PATCH net-next v3 5/6] qed: Expose the doorbell overflow recovery mechanism to the protocol drivers

Most of the doorbelling entities are outside of the core module. L2 queues, Roce queues, iscsi and fcoe all need to register. Make the APIs available for these drivers. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed

[PATCH net-next v3 6/6] qede: Register l2 queues with doorbell overflow recovery mechanism

All L2 queues funnel through this flow, so this would cover the regular RSS queues, as well queues created for VFs, mqos queues, xdp queues, etc. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qede/qede_main.c | 9

[PATCH net-next 0/6 v3] qed*: Doorbell overflow recovery

entities, and APIs for adding and deleting entries, and logic for traversing the database and doorbelling once on behalf of all entities. Please consider applying to net-next. Thanks, Ariel Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar v1->v2: ---

[PATCH net-next v3 1/6] qed: Add doorbell overflow recovery mechanism

Add the database used to register doorbelling entities, and APIs for adding and deleting entries, and logic for traversing the database and doorbelling once on behalf of all entities. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet

[PATCH net-next v3 2/6] qed: Use the doorbell overflow recovery mechanism in case of doorbell overflow

been missed. After a set time with no indications, terminate the periodic task. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed.h | 14 ++- drivers/net/ethernet/qlogic/qed/qed_dev.c | 14 ++- drivers

[PATCH net-next v3 4/6] qed: Register light L2 queues with doorbell overflow recovery mechanism

Light L2 queues are doorbelling entities. Modify the implementation to keep the doorbell data necessary for doorbelling in well known location instead of recomputing every time. Register the LL2 queue with doorbell recovery mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon

[PATCH net-next v3 3/6] qed: Register slowpath queue doorbell with doorbell overflow recovery mechanism

Slow path queue is a doorbelling entity. Register it with the overflow mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed_sp.h | 4 ++- drivers/net/ethernet/qlogic/qed/qed_spq.c | 47