[PATCH] net: xilinx: constify net_device_ops structures

before: textdata bss dec hex filename 6201 744 069451b21 ethernet/xilinx/xilinx_emaclite.o File size after: textdata bss dec hex filename 6745 192 069371b19 ethernet/xilinx/xilinx_emaclite.o Signed-off-by: Bhumika Goyal

[PATCH] net: moxa: constify net_device_ops structures

before: textdata bss dec hex filename 4821 744 0556515bd ethernet/moxa/moxart_ether.o File size after: textdata bss dec hex filename 5373 192 0556515bd ethernet/moxa/moxart_ether.o Signed-off-by: Bhumika Goyal <bh

[PATCH v2] net: moxa: constify net_device_ops structures

: textdata bss dec hex filename 4821 744 0556515bd ethernet/moxa/moxart_ether.o File size after: textdata bss dec hex filename 5373 192 0556515bd ethernet/moxa/moxart_ether.o Signed-off-by: Bhumika Goyal <bh

[PATCH v2] net: xilinx: constify net_device_ops structure

: textdata bss dec hex filename 6201 744 069451b21 ethernet/xilinx/xilinx_emaclite.o File size after: textdata bss dec hex filename 6745 192 069371b19 ethernet/xilinx/xilinx_emaclite.o Signed-off-by: Bhumika Goyal

[PATCH] qlogic: qlcnic_sysfs: constify bin_attribute structures

optional_qualifier@ identifier r1.i; @@ +const struct bin_attribute i; Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/qlogic/

[PATCH] qlogic: netxen: constify bin_attribute structures

optional_qualifier@ identifier r1.i; @@ +const struct bin_attribute i; Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/

[PATCH] net: ieee802154: constify ieee802154_ops structures

-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ieee802154/adf7242.c | 2 +- drivers/net/ieee802154/atusb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index 9fa7ac9..4ff4c7d 100644 --- a/drive

[PATCH] wireless: ath: ath9k: constify ath_bus_ops structure

1359 176 01535 5ff ath/ath9k/ahb.o Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/ath/ath9k/ahb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c

[PATCH] net: wireless: marvell: libertas: constify cfg80211_ops structures

1954 16 231955a9b wireless/marvell/libertas/cfg.o File size after: textdata bss dec hex filename 220411154 16 232115aab wireless/marvell/libertas/cfg.o Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/marvell/li

[PATCH] net: wireless: ath: wil6210: constify cfg80211_ops structures

6632 0 2476560bd wireless/ath/wil6210/cfg80211.o File size after: textdata bss dec hex filename 189335832 0 2476560bd wireless/ath/wil6210/cfg80211.o Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/ath/wil6210/cf

[PATCH] net: constify mdiobb_ops structures

dec hex filename 1915 192 02107 83b drivers/net/phy/mdio-gpio.o Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/8390/ax88796.c | 2 +- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 2 +- drivers/net/ethernet/r

Re: [PATCH] net: wireless: realtek: constify rate_control_ops structures

On Sat, Dec 3, 2016 at 2:09 AM, Larry Finger <larry.fin...@lwfinger.net> wrote: > On 12/02/2016 03:50 AM, Bhumika Goyal wrote: >> >> The structures rate_control_ops are only passed as an argument to the >> functions ieee80211_rate_control_{register/unregister}. This a

[PATCH] net: wireless: realtek: constify rate_control_ops structures

wireless/realtek/rtlwifi/rc.o File size after: textdata bss dec hex filename 2095 0 02095 wireless/realtek/rtlwifi/rc.o Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/rc.c | 2 +- 1 file changed, 1 ins

[PATCH] vhost: scsi: constify target_core_fabric_ops structures

textdata bss dec hex filename 184792601 40 211205280 drivers/vhost/scsi.o Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/vhost/scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c

Re: [PATCH] vhost: scsi: constify target_core_fabric_ops structures

On Tue, Jan 10, 2017 at 10:41 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Mon, Jan 09, 2017 at 08:51:02PM +0530, Bhumika Goyal wrote: >> Declare target_core_fabric_ops strucrues as const as they are only >> passed as an argument to the functions tar

[PATCH] ath9k: make ath_ps_ops structures as const

ath_ps_ops structures are only stored as a reference in the ps_ops field of a ath_common structure. This field is of type const, so make the structures as const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/ath/ath9k/htc_drv_init.c | 2 +- drivers/net/wirele

[PATCH] mlxsw: make mlxsw_config_profile const

Make these structures const as they only stored in the profile field of a mlxsw_driver structure, which is of type const. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- drivers/net/ethernet/mellanox

[PATCH] ixgbe: declare ixgbe_mac_operations structures as const

Declare ixgbe_mac_operations structures as const as they are only stored in the mac_ops field of ixgbe_info structure. This field is of type const and therefore ixgbe_mac_operations structure can be made const too. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet

[PATCH] can: c_can_pci: make c_can_pci_data const

Make c_can_pci_data structures const as they are only used during a copy operation. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/can/c_can/c_can_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/c_can_pci.c b/drivers/n

[PATCH] hamradio: baycom: make hdlcdrv_ops const

Make hdlcdrv_ops structures const as they are only passed to hdlcdrv_register function. The corresponding argument is of type const, so make the structures const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/hamradio/baycom_par.c | 2 +- drivers/net/ha

[PATCH] net: dsa: make dsa_switch_ops const

Make these structures const as they are only stored in the ops field of a dsa_switch structure, which is const. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/dsa/dsa_loop.c | 2 +- drivers/net/dsa/lan9303-core.c | 2 +- drivers/net/dsa/mt

[PATCH] atm: make atmdev_ops const

Make these structures const as they are either passed to the function atm_dev_register having the corresponding argument as const or stored in the ops field of a atm_dev structure, which is also const. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drive

[PATCH] net: atm: make atmdev_ops const

Make these const as they are only stored in the ops field of a atm_dev structure, which is const. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/atm/clip.c | 2 +- net/atm/lec.c | 2 +- net/atm/mpc.c | 2 +- net/atm/signaling.c | 2 +- 4

[PATCH 1/2] wlcore: add const to bin_attribute structure

Add const to bin_attribute structure as it is only passed to the functions sysfs_{remove/create}_bin_file. The corresponding arguments are of type const, so declare the structure to be const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/ti/wlcore/sysfs.c | 2

[PATCH 2/2] qlcnic: add const to bin_attribute structure

Add const to bin_attribute structure as it is only passed to the functions sysfs_{remove/create}_bin_file. The corresponding arguments are of type const, so declare the structure to be const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_s

[PATCH 0/2] drivers/net: add const to bin_attribute structures

Declare bin_attribute structures as const. Bhumika Goyal (2): wlcore: add const to bin_attribute structure qlcnic: add const to bin_attribute structure drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 2 +- drivers/net/wireless/ti/wlcore/sysfs.c| 2 +- 2 files changed, 2

[PATCH] isdn: kcapi: make capi_version const

Declare this structure as const as it is only used during a copy operation. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/isdn/capi/kcapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c index 9

[PATCH v2] rtlwifi: constify rate_control_ops structure

rate_control_ops structure is only passed as an argument to the function ieee80211_rate_control_{register/unregister}. This argument is of type const, so declare the structure as const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- Changes in v2: * Change subject line. drive

[PATCH] Bluetooth: make device_type const

Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/bluetooth/hci_sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/blu

[PATCH] net: dsa: mv88e6xxx: make irq_chip const

Make this const as it is only used in a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/dsa/mv88e6xxx/chip.c| 2 +- drivers/net/dsa/mv88e6xxx/global2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH] wireless: ipw2x00: make iw_handler_def const

Make these const as they are only stored in the const field of a net_device structure. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/intel/ipw2x00/ipw2100.c | 4 ++-- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- 2 files changed, 3 insertions(+), 3 del

[PATCH] net/mlx4_core: make mlx4_profile const

Make these const as they are only used in a copy operation. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/mellanox/mlx4/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/et

[PATCH] net/mlx5e: make mlx5e_profile const

Make this const as it is only passed as an argument to the function mlx5e_create_netdev and the corresponding argument is of type const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 0/2] drivers: net: add const to mii_phy_ops structures

The object references of mii_phy_ops structures are only stored in the ops field of a mii_phy_def structure. This ops field is of type const. So, mii_phy_ops structures having similar properties can be declared as const. Bhumika Goyal (2): drivers/net/sungem: add const to mii_phy_ops structures

[PATCH 1/2] drivers/net/sungem: add const to mii_phy_ops structures

The object references of mii_phy_ops structures are only stored in the ops field of a mii_phy_def structure. This ops field is of type const. So, mii_phy_ops structures having similar properties can be declared as const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drive

[PATCH 2/2] drivers: net: emac: add const to mii_phy_ops structures

The object references of mii_phy_ops structures are only stored in the ops field of a mii_phy_def structure. This ops field is of type const. So, mii_phy_ops structures having similar properties can be declared as const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/et

[PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure

Declare thermal_cooling_device_ops structure as const as it is only passed as an argument to the function thermal_cooling_device_register and this argument is of type const. So, declare the structure as const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless

[PATCH] ath10k: add const to thermal_cooling_device_ops structure

Declare thermal_cooling_device_ops structure as const as it is only passed as an argument to the function thermal_cooling_device_register and this argument is of type const. So, declare the structure as const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/ath/

[PATCH] cw1200: add const to hwbus_ops structures

Declare hwbus_ops structures as const as they are only passed as an argument to the function cw1200_core_probe. This argument is of type const. So, make these structures const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/st/cw1200/cw1200_sdio.c | 2 +- drive

[PATCH] ath10k: make ath10k_hw_ce_regs const

Make them const as they are not modified in the file referencing them. They are only stored in the const field 'hw_ce_reg' of an ath10k structure. Also, make the declarations in the header const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/wireless/ath/ath10k/hw

[PATCH v2 12/15] RDMA/cma: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in v2- Combine all the

[PATCH v2 07/15] usb: gadget: configfs: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in v2- Combine

[PATCH v2 05/15] ocfs2/cluster: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in

[PATCH v2 02/15] usb: gadget: make config_item_type structures const

Make these structures const as they are only passed to the const argument of the functions config_{group/item}_init_type_name. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in v2- Combine all the followup patches and the constification patches into a series. drivers/usb/

[PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const

to the argument of the function config_group_init_type_name which is now const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in v2- Combine all the followup patches and the constification patches into a series. fs/configfs/dir.c| 10 +- fs/configfs/

[PATCH v2 11/15] stm class: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or used inside a if statement or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com&g

[PATCH v2 13/15] netconsole: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in

[PATCH v2 15/15] configfs: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in v2- Combine

[PATCH v2 06/15] PCI: endpoint: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in v2- Combine

[PATCH v2 00/15] make structure field, function arguments and structures const

Make the ci_type field and some function arguments as const. After this change, make config_item_type structures as const. * Changes in v2- Combine all the followup patches and the constification patches into a series. Bhumika Goyal (15): configfs: make ci_type field, some pointers

[PATCH v2 03/15] target: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in

[PATCH v2 14/15] dlm: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in v2- Combine

[PATCH v2 09/15] ACPI: configfs: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in

[PATCH v2 10/15] nullb: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in

[PATCH v2 04/15] iio: make function argument and some structures const

or they are stored in the const "ci_type" field of a config_item structure. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- * Changes in v2- Combine all the followup patches and the constification patches into a series. drivers/iio/dummy/iio_simple_dummy.c | 2 +- drivers/

[PATCH v2 08/15] nvmet: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or used inside an if statement or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle Signed-off-by: Bhumika Goyal <bhumi...@gmail.com&g

[PATCH] netconsole: make config_item_type const

structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/netconsole.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 0e27920..be9aa36 100644 --- a/drivers/net/ne

[PATCH] net: dsa: make some structures const

Make these const as they are not modified anywhere. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 2 +- drivers/net/dsa/qca8k.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c

[PATCH] net: bcm63xx_enet: make bcm_enetsw_ethtool_ops const

Make this const as it is never modified. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/br

[PATCH] net: ethernet: ax88796: make mdiobb_ops const

Make this const as it is only stored in a const field of a mdiobb_ctrl structure. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/8390/ax88796.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/8390/ax88796.c b/drive

[PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops const

Make this const as it is only stored in a const field of a mdiobb_ctrl structure. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/f

[PATCH] ravb: make mdiobb_ops const

Make these const as they are only stored in a const field of a mdiobb_ctrl structure. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- drivers/net/ethernet/renesas/sh_eth.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH] net: mdio-gpio: make mdiobb_ops const

Make this const as it is only stored in a const field of a mdiobb_ctrl structure. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/phy/mdio-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c

[PATCH 6/6] power: supply: make device_attribute const

Make these const as they are only passed as an argument to the function device_create_file and device_remove_file and the corresponding arguments are of type const. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/power/supply/olpc_battery.c | 2 +-

[PATCH 4/6] qlogic: make device_attribute const

Make these const as they are only passed as an argument to the function device_create_file and device_remove_file and the corresponding arguments are of type const. Done using Coccinelle Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/ethernet/qlogic/netxen/netxen_nic_

[PATCH 3/6] hid: make device_attribute const

Make this const as it is only passed as an argument to the function device_create_file and device_remove_file and the corresponding arguments are of type const. Done using Coccinelle Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 ins

[PATCH 5/6] platform/x86: make device_attribute const

Make these const as they are only passed as an argument to the function device_create_file and device_remove_file and the corresponding arguments are of type const. Done using Coccinelle Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/platform/x86/classmate-laptop

[PATCH 1/6] ACPI: make device_attribute const

Make these const as they are only passed as an argument to the function device_create_file and device_remove_file and the corresponding arguments are of type const. Done using Coccinelle Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/acpi/battery.c | 2 +- drivers/acpi

[PATCH 2/6] nbd: make device_attribute const

Make this const as is is only passed as an argument to the function device_create_file and device_remove_file and the corresponding arguments are of type const. Done using Coccinelle Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/block/nbd.c | 2 +- 1 file changed, 1 ins

[PATCH 0/6] drivers: make device_attribute const

match.s; expression e1; position ref.p; @@ device_create_file(e1,@p,...) @bad depends on !good1 && !good2@ position ref.p; identifier match.s; @@ s@p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct device_attribute s; Bhumika Goyal (6): AC

Re: [PATCH 0/6] drivers: make device_attribute const

On Mon, Aug 21, 2017 at 5:13 PM, Bhumika Goyal <bhumi...@gmail.com> wrote: > Make these const. Done using Coccinelle. > > @match disable optional_qualifier@ > identifier s; > @@ > static struct device_attribute s = {...}; > > @ref@ > position p; > ident

Re: [PATCH] ptp: make ptp_clock_info const

On Tue, Aug 22, 2017 at 11:57 AM, Richard Cochran <richardcoch...@gmail.com> wrote: > On Mon, Aug 21, 2017 at 11:01:12PM +0530, Bhumika Goyal wrote: >> File ptp_ixp46x.c is not tested as I could not find any architecture >> to cross compile it. > > No problem. Thanks f

[PATCH] can: peak_pci: Make i2c_algo_bit_data const

Make this const as it is only used in a copy operation. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- drivers/net/can/sja1000/peak_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/sja1000/peak_pci.c b/drivers/net/can/sja1000/peak_pci.c

Re: [PATCH 0/6] drivers: make device_attribute const

On Mon, Aug 21, 2017 at 5:58 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: > On Mon, Aug 21, 2017 at 1:43 PM, Bhumika Goyal <bhumi...@gmail.com> wrote: >> Make these const. Done using Coccinelle. >> >> @match disable optional_qualifier@ >> identifier s; &g

[PATCH 1/7] Bluetooth: 6lowpan: make header_ops const

Make this const as it is only stored as a reference in a const field of a net_device structure. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/bluetooth/6lowpan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lo

[PATCH 2/7] bridge: make ebt_table const

Make this const as it is only passed to a const argument of the function ebt_register_table. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/bridge/netfilter/ebtable_nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/netfilter/ebtable_nat.c

[PATCH 7/7] SUNRPC: make kvec const

Make this const as it is only used during a copy operation. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/sunrpc/xdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c index e34f4ee..a096025 100644 --- a/net/sunrpc/xdr.c

[PATCH 6/7] netfilter: nat: make rhashtable_params const

Make this const as it is either used during a copy operation or passed to a const argument of the function rhltable_init. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/netfilter/nf_nat_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/net

[PATCH 3/7] ieee802154: 6lowpan: make header_ops const

Make this const as it is only stored as a reference in a const field of a net_device structure. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/ieee802154/6lowpan/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee

[PATCH 5/7] RDS: make rhashtable_params const

Make this const as it is either used during a copy operation or passed to a const argument of the function rhltable_init Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/rds/bind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/bind.c b/net/rds/bind.c

[PATCH 4/7] ipv4: make net_protocol const

Make these const as they are only passed to a const argument of the function inet_add_protocol. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/ipv4/af_inet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index d

[PATCH 0/7] net: make some structures const

Make these const as they are not modified. Bhumika Goyal (7): Bluetooth: 6lowpan: make header_ops const bridge: make ebt_table const ieee802154: 6lowpan: make header_ops const ipv4: make net_protocol const RDS: make rhashtable_params const netfilter: nat: make rhashtable_params const

Re: [PATCH 4/6] qlogic: make device_attribute const

On Mon, Aug 21, 2017 at 10:55 PM, David Miller <da...@davemloft.net> wrote: > From: Bhumika Goyal <bhumi...@gmail.com> > Date: Mon, 21 Aug 2017 17:13:10 +0530 > >> Make these const as they are only passed as an argument to the >> function device_c

[PATCH] net: ethernet: make ptp_clock_info const

| e = s@p.f | c(...,s@p.f,...) | c(...,s@p,...) ) @bad depends on !good1@ position ref.p; identifier match.s; @@ s@p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct ptp_clock_info s; Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- d

[PATCH] ptp: make ptp_clock_info const

| e = s@p.f | c(...,s@p.f,...) | c(...,s@p,...) ) @bad depends on !good1@ position ref.p; identifier match.s; @@ s@p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct ptp_clock_info s; Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

84.985133] proc_tcp_early_demux+0x29/0x30 > > I think this is the second time such a patch has been reverted. > > Cc: Bhumika Goyal <bhumi...@gmail.com> > Signed-off-by: David Ahern <dsah...@gmail.com> > --- > Bhumika: How are you testing these constify changes? In th

Re: [PATCH] netconsole: make config_item_type const

On Thu, Oct 12, 2017 at 2:29 PM, Bhumika Goyal <bhumi...@gmail.com> wrote: > This is a followup patch for: https://lkml.org/lkml/2017/10/11/375 and > https://patchwork.kernel.org/patch/649/ > > Make these structures const as they are either passed to the functions >

[PATCH 4/4] SUNRPC: make cache_detail structures const

Make these const as they are only getting passed to the function cache_create_net having the argument as const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- net/sunrpc/auth_gss/svcauth_gss.c | 4 ++-- net/sunrpc/svcauth_unix.c | 4 ++-- 2 files changed, 4 insertions

[PATCH 2/4] NFS: make cache_detail structure const

Make it const as it is only getting passed to the function cache_create_net having the argument as const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- fs/nfs/dns_resolve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_res

[PATCH 3/4] NFSD: make cache_detail structures const

Make these const as they are only getting passed to the function cache_create_net having the argument as const. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- fs/nfsd/export.c| 4 ++-- fs/nfsd/nfs4idmap.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/f

[PATCH 0/4] make function arg and structures as const

Make the function argument as const. After thing change, make the cache_detail structures as const. Bhumika Goyal (4): sunrpc: make the function arg as const NFS: make cache_detail structures const NFSD: make cache_detail structures const SUNRPC: make cache_detail structures const fs

[PATCH 1/4] sunrpc: make the function arg as const

Make the struct cache_detail *tmpl argument of the function cache_create_net as const as it is only getting passed to kmemup having the argument as const void *. Add const to the prototype too. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- include/linux/sunrpc/cache.h | 2 +- net/

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

On Thu, Oct 19, 2017 at 5:05 PM, Laurent Pinchart wrote: > Hi Christoph, > > On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote: >> > Now we have 9 const instances of the config_item_type structure that are >> > identical, with only the .ct_owner