[PATCH v3 2/9] MAINTAINERS: Add myself as maintainer of sun8i-emac

2016-09-09 Thread Corentin Labbe
This patch add myself as maintainer of the sun8i-emac driver. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..43f5be3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig

2016-09-09 Thread Corentin Labbe
Enable the sun8i-emac driver in the sunxi default configuration Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/configs/sunxi_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig index 7

[PATCH v3 1/9] ethernet: add sun8i-emac driver

2016-09-09 Thread Corentin Labbe
This patch add support for sun8i-emac ethernet MAC hardware. It could be found in Allwinner H3/A83T/A64 SoCs. It supports 10/100/1000 Mbit/s speed with half/full duplex. It can use an internal PHY (MII 10/100) or an external PHY via RGMII/RMII. Signed-off-by: Corentin Labbe <clabbe.mo

[PATCH v3 7/9] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI One

2016-09-09 Thread Corentin Labbe
From: Hans de Goede <hdego...@redhat.com> The sun8i-emac hardware is present on the Orange PI One. It uses the internal PHY. This patch create the needed emac and phy nodes. Signed-off-by: Hans de Goede <hdego...@redhat.com> Signed-off-by: Corentin Labbe <clabbe.montj...@gmail

[PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module

2016-09-09 Thread Corentin Labbe
This patch add the dt node for the syscon register present on the Allwinner H3. Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3.dtsi | 5 ++

[PATCH v4 02/10] MAINTAINERS: Add myself as maintainer of sun8i-emac

2016-10-07 Thread Corentin Labbe
This patch add myself as maintainer of the sun8i-emac driver. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 40f4629..e197d82 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH v4 03/10] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-10-07 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the Allwinner sun8i-emac driver. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../bindings/net/allwinner,sun8i-emac.txt | 70 ++ 1 file changed, 70 insertions(+) create mode

[PATCH v4 09/10] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig

2016-10-07 Thread Corentin Labbe
Enable the sun8i-emac driver in the sunxi default configuration Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/configs/sunxi_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig index 7

[PATCH v4 01/10] ethernet: add sun8i-emac driver

2016-10-07 Thread Corentin Labbe
This patch add support for sun8i-emac ethernet MAC hardware. It could be found in Allwinner H3/A83T/A64 SoCs. It supports 10/100/1000 Mbit/s speed with half/full duplex. It can use an internal PHY (MII 10/100) or an external PHY via RGMII/RMII. Signed-off-by: Corentin Labbe <clabbe.mo

[PATCH v4 05/10] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver

2016-10-07 Thread Corentin Labbe
The sun8i-emac is an ethernet MAC hardware that support 10/100/1000 speed. This patch enable the sun8i-emac on the Allwinner H3 SoC Device-tree. The SoC H3 have an internal PHY, so optionals syscon and ephy are set. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/bo

[PATCH v4 06/10] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC

2016-10-07 Thread Corentin Labbe
The sun8i-emac hardware is present on the Orange PI PC. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 8 1 file changed, 8 insertions(+) diff --git a/ar

[PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module

2016-10-07 Thread Corentin Labbe
This patch add the dt node for the syscon register present on the Allwinner H3. Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3.dtsi | 5 ++

[PATCH v4 00/10] net-next: ethernet: add sun8i-emac driver

2016-10-07 Thread Corentin Labbe
refactoring Corentin Labbe (9): ethernet: add sun8i-emac driver MAINTAINERS: Add myself as maintainer of sun8i-emac ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac ARM: dts: sun8i-h3: Add dt node for the syscon control module ARM: dts: sun8i-h3: add sun8i-emac ethernet

[PATCH v4 08/10] ARM: dts: sun8i: Enable sun8i-emac on the Orange Pi 2

2016-10-07 Thread Corentin Labbe
The sun8i-emac hardware is present on the Orange PI 2. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8 1 file changed, 8 insertions(+) diff --git a/ar

[PATCH v4 07/10] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI One

2016-10-07 Thread Corentin Labbe
From: Hans de Goede <hdego...@redhat.com> The sun8i-emac hardware is present on the Orange PI One. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Hans de Goede <hdego...@redhat.com> Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>

[PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig

2016-10-07 Thread Corentin Labbe
Enable the sun8i-emac driver in the multi_v7 default configuration Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_def

Re: [PATCH 3/5] net: thunderx: Fix configuration of L3/L4 length checking

2016-11-14 Thread Corentin Labbe
On Mon, Nov 14, 2016 at 04:24:44PM +0530, sunil.kovv...@gmail.com wrote: > From: Sunil Goutham > > This patch fixes enabling of HW verification of L3/L4 length and > TCP/UDP checksum which is currently being cleared. Also fixed VLAN > stripping config which is being cleared

[PATCH 1/3] net: stmmac: replace all pr_xxx by their netdev_xxx counterpart

2016-11-16 Thread Corentin Labbe
;stmmac:" print since this will be a duplicate with that dev_xxx displays. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 204 -- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 14 +- 2 files changed,

[PATCH 3/3] net: stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

2016-11-16 Thread Corentin Labbe
From: LABBE Corentin <clabbe.montj...@gmail.com> As sugested by Joe Perches, we could replace all if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) by the simpler macro netif_xxx(priv, hw, priv->dev, ...) Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- dr

[PATCH 2/3] net: stmmac: replace hardcoded function name by __func__

2016-11-16 Thread Corentin Labbe
From: LABBE Corentin <clabbe.montj...@gmail.com> Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 +++ 1 file changed, 3 inse

[PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h

2016-12-15 Thread Corentin Labbe
This patch move the define for IRNET_MINOR to include/linux/miscdevice.h It is better that all minor number definitions are in the same place. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- include/linux/miscdevice.h | 1 + net/irda/irnet/irnet_ppp.h | 1 - 2 files chan

[PATCH 1/5] irda: irproc.c: Remove unneeded linux/miscdevice.h include

2016-12-15 Thread Corentin Labbe
irproc.c does not use any miscdevice so this patch remove this unnecessary inclusion. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- net/irda/irproc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/irda/irproc.c b/net/irda/irproc.c index b9ac598..77cfdde 100644 ---

[PATCH 5/5] irda: irnet: add member name to the miscdevice declaration

2016-12-15 Thread Corentin Labbe
Since the struct miscdevice have many members, it is dangerous to init it without members name relying only on member order. This patch add member name to the init declaration. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- net/irda/irnet/irnet_ppp.h | 6 +++--- 1 file chan

[PATCH 4/5] irda: irnet: Remove unused IRNET_MAJOR define

2016-12-15 Thread Corentin Labbe
The IRNET_MAJOR define is not used, so this patch remove it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- net/irda/irnet/irnet_ppp.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/irda/irnet/irnet_ppp.h b/net/irda/irnet/irnet_ppp.h index 18fcead..ec092c9

[PATCH 2/5] irda: irnet: Move linux/miscdevice.h include

2016-12-15 Thread Corentin Labbe
The only use of miscdevice is irda_ppp so no need to include linux/miscdevice.h for all irda files. This patch move the linux/miscdevice.h include to irnet_ppp.h Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- net/irda/irnet/irnet.h | 1 - net/irda/irnet/irnet_ppp.h |

[PATCH 2/2] net: stmmac: unify mdio functions

2016-12-01 Thread Corentin Labbe
and write functions. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/common.h | 6 + .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 6 + .../net/ethernet/stmicro/stmmac/dwmac100_core.c| 7 ++ drivers/net/ethernet/stmicro/

[PATCH 1/2] net: stmmac: avoid Camelcase naming

2016-12-01 Thread Corentin Labbe
This patch simply rename regValue to value, like it was named in other mdio functions. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/et

Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming

2016-12-02 Thread Corentin Labbe
On Fri, Dec 02, 2016 at 09:44:48AM +0100, Giuseppe CAVALLARO wrote: > Hello Corentin > > patches look ok, I just wonder if you tested it in case of > the stmmac is connected to a transceiver. Let me consider it > a critical part of the driver to properly work. > > Regards > Peppe > I tested it

[PATCH] net: stmmac: add set_mac to the stmmac_ops

2017-03-22 Thread Corentin Labbe
by a call to this pointer. Since dwmac4_ops is const, set_mac cannot be modified after, and so dwmac4_ops is duplioacted like dwmac4_dma_ops. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 ++ .../net/ethernet/stmicro/

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

2017-03-23 Thread Corentin Labbe
On Thu, Mar 23, 2017 at 10:12:18AM +, Joao Pinto wrote: > > Hi Corentin, > > Às 10:08 AM de 3/23/2017, Corentin Labbe escreveu: > > Hello > > > > Using next-20170323 produce a huge performance regression on my sunxi > > boards. > > On dwmac-sun8i,

stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

2017-03-23 Thread Corentin Labbe
lost after. Reverting aff3d9eff84399e433c4aca65a9bb236581bc082 fix the issue. I still try to found which part of this patch mades the performance lower. Regards Corentin Labbe

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

2017-03-27 Thread Corentin Labbe
On Mon, Mar 27, 2017 at 06:44:22PM +0100, Joao Pinto wrote: > Às 6:28 PM de 3/27/2017, David Miller escreveu: > > From: Corentin Labbe <clabbe.montj...@gmail.com> > > Date: Mon, 27 Mar 2017 19:00:58 +0200 > > > >> On Mon, Mar 27, 2017 at 04:26:48PM +01

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

2017-03-27 Thread Corentin Labbe
On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: > Hi David, > > Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > > On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: > >> For cores that have more than 1 TX queue configured, the kernel would > &g

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

2017-03-27 Thread Corentin Labbe
On Mon, Mar 27, 2017 at 06:06:05PM +0100, Joao Pinto wrote: > Às 6:00 PM de 3/27/2017, Corentin Labbe escreveu: > > On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: > >> Hi David, > >> > >> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > >&

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

2017-03-25 Thread Corentin Labbe
On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: > For cores that have more than 1 TX queue configured, the kernel would crash, > since only one TX queue is permitted by default. > > Signed-off-by: Joao Pinto > --- >

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

2017-03-27 Thread Corentin Labbe
On Mon, Mar 27, 2017 at 10:04:57AM +0100, Joao Pinto wrote: > Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > > On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: > >> For cores that have more than 1 TX queue configured, the kernel would > >> crash, &

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

2017-03-30 Thread Corentin Labbe
On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: > From: Arnd Bergmann > Date: Tue, 28 Mar 2017 11:48:21 +0200 > > > A driver must not access the two fields directly but should instead use > > the helper functions to set the values and keep a consistent internal > >

[PATCH v2] net: stmmac: add set_mac to the stmmac_ops

2017-03-23 Thread Corentin Labbe
by a call to this pointer. Since dwmac4_ops is const, set_mac cannot be modified after, and so dwmac4_ops is duplioacted like dwmac4_dma_ops. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 ++ .../net/ethernet/stmicro/

[PATCH] Revert "net: stmmac: enable multiple buffers"

2017-03-28 Thread Corentin Labbe
The commit aff3d9eff843 ("net: stmmac: enable multiple buffers") breaks numerous boards. while some patch exists for fixing some of it, dwmac-sunxi is still broken with it. Since this patch is very huge, it will be better to split it in smaller part. Signed-off-by: Corentin Labbe <

Re: [PATCH] Revert "net: stmmac: enable multiple buffers"

2017-03-29 Thread Corentin Labbe
On Tue, Mar 28, 2017 at 10:11:23PM -0700, David Miller wrote: > > Did you even test all 3 of Thierry's patches? > > I want you to do that before we revert. > Yes I tested all 3, dwmac-sunxi is still broken with them

[PATCH] selftests: add a generic testsuite for ethernet device

2017-03-31 Thread Corentin Labbe
This patch add a generic testsuite for testing ethernet network device driver. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/net/netdevice.sh | 185 +++ 2 files change

[PATCH] selftests: add a generic testsuite for ethernet device

2017-03-31 Thread Corentin Labbe
, so that an already used network interface will not be modified (mac/IP address for example). Regards Corentin Labbe (1): selftests: add a generic testsuite for ethernet device tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/net/netdevice.sh | 185

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-24 Thread Corentin Labbe
x_q->priv_data; > > >> +u32 tx_count = priv->dma_cap.number_tx_queues; > > > > > > I changed this to priv->plat->tx_queues_to_use as used elsewhere to make > > > sure we don't try to clean up non-initialized TX queues. This seems to > > > solve an issue that would occasionally happen after the TX queue timed > > > out, but the fundamental issue is still there. > > > > Yes, you are correct. It should be priv->plat->tx_queues_to_use instead of > > "u32 > > tx_count = priv->dma_cap.number_tx_queues;"... sorry for that, but in my > > setup > > is the same value. Could you please make a patch for it? > > Yes, I can submit a patch for that. > > After some more testing I did get a couple (roughly 2 out of 10) > successful boots (I'm booting over NFS using the EQOS), and given that > this pointed towards something related to uninitialized data, I changed > all occurrences of kmalloc_array() with kcalloc() and that I've gotten > 10 successful reboots out of 10. > > I still can't pinpoint why this is now necessary since previously the > kmalloc_array() was working just fine. The only thing I can think of is > that we're not properly initializing all fields of the new queue > structures, since that's the only thing that's changed with this commit. > > I haven't investigated in detail yet, but from nothing so far has jumped > out at me. > > Thierry I have tried this change, but it made the situation worse on dwmac-sunxi (no network at all). Joao, perhaps it's time to revert the faulty (and very huge) patch and rework it by splitting at least in two: - adding RX queue / adding TX queue And more if possible (like just adding an unused queue parameter) or a patch just for adding stmmac_free_tx_buffers() for example. I think it will help to find where the problem is. And this time I will test them before applying:) Regards Corentin Labbe

linux-next-20170320 break stmmac on dwmac-sunxi

2017-03-20 Thread Corentin Labbe
Hello Just pushed next-20170320 to my boards and stmmac stop working on both intree dwmac-sunxi and my dev dwmac-sun8i. It seems that interrupts never fire, and transmit queue timeout. I will try to bisect this problem but perhaps other people could try to reproduce it. Regards Corentin Labbe

[PATCH] netfilter: logging copyrights is useless

2017-03-15 Thread Corentin Labbe
Logging copyrights does not add any useful information in logs. This patch remove such logging Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- net/ipv4/netfilter/arp_tables.c | 1 - net/ipv4/netfilter/ip_tables.c | 1 - net/ipv6/netfilter/ip6_tables.c | 1 - net/net

Re: linux-next-20170320 breaks stmmac on meson (Amlogic S905GXBB)

2017-03-21 Thread Corentin Labbe
On Tue, Mar 21, 2017 at 10:13:08AM +, Joao Pinto wrote: > > Hi Heiner and Corentin, > > Às 9:58 PM de 3/20/2017, Heiner Kallweit escreveu: > > As reported by Corentin Labbe before: > > stmmac in the latest next kernel is broken also on meson8b. > > > >

Re: [v5,net-next,2/9] net: stmmac: configure mtl rx and tx algorithms

2017-03-21 Thread Corentin Labbe
On Tue, Mar 21, 2017 at 02:10:47PM +, Joao Pinto wrote: > ++Adding Corentin > > Às 2:08 PM de 3/21/2017, Thierry Reding escreveu: > > On Tue, Mar 21, 2017 at 01:58:36PM +, Joao Pinto wrote: > >> Às 12:24 PM de 3/21/2017, Thierry Reding escreveu: > >>> On Tue, Mar 21, 2017 at 12:02:03PM

Re: [PATCH v3 net-next] net: stmmac: fix dma operation mode config for older versions

2017-03-22 Thread Corentin Labbe
pare dma op mode config for multiple > queues") > Reported-by: Corentin Labbe <clabbe.montj...@gmail.com> > Reviewed-by: Thierry Reding <thierry.red...@gmail.com> > Signed-off-by: Joao Pinto <jpi...@synopsys.com> > --- > changes v2->v3: > - Commit ID and t

Re: [PATCH 2/3] net: stmmac: Restore DT backwards-compatibility

2017-03-22 Thread Corentin Labbe
t have any > + * snps,mtl-rx-config or snps,mtl-tx-config properties, we fall back > + * to one RX and TX queues each. > + */ > + plat->rx_queues_to_use = 1; > + plat->tx_queues_to_use = 1; > + > rx_node = of_parse_phandle(pdev->dev.of_node,

[PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the pine64 It uses an external PHY via RMII. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/bo

[PATCH v3 19/20] ARM: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig

2017-04-03 Thread Corentin Labbe
From: LABBE Corentin <clabbe.montj...@gmail.com> Enable the dwmac-sun8i driver in the sunxi default configuration Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/configs/sunxi_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sunxi

[PATCH v3 18/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on the BananaPi M64

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the BananaPi M64. It uses an external PHY rtl8211e via RGMII. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH v3 14/20] ARM64: dts: sun50i-a64: Add dt node for the syscon control module

2017-04-03 Thread Corentin Labbe
This patch add the dt node for the syscon register present on the Allwinner A64. Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a6

[PATCH v3 15/20] ARM64: dts: sun50i-a64: add dwmac-sun8i Ethernet driver

2017-04-03 Thread Corentin Labbe
at this level. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 37 +++ 1 file changed, 37 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

[PATCH v3 20/20] ARM: sunxi: Enable dwmac-sun8i driver on multi_v7_defconfig

2017-04-03 Thread Corentin Labbe
Enable the dwmac-sun8i driver in the multi_v7 default configuration Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_def

[PATCH v3 17/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64 plus

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the pine64 plus. It uses an external PHY rtl8211e via RGMII. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../arm64/boot/dts/allwinner/sun50i-a64-pine64-plus.dts | 17 - 1 file changed, 16 insertions(+), 1 deletion(-)

[PATCH v3 05/20] net: stmmac: Add dwmac-sun8i

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i is a heavy hacked version of stmmac hardware by allwinner. In fact the only common part is the descriptor management and the first register function. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/Kconfig| 11 + d

[PATCH v3 06/20] ARM: dts: sunxi-h3-h5: Add dt node for the syscon control module

2017-04-03 Thread Corentin Labbe
This patch add the dt node for the syscon register present on the Allwinner H3/H5 Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock.. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dt

[PATCH v3 10/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi 2

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI 2. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8 1 file changed, 8 insertions(+) diff --git a/ar

[PATCH v3 11/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange PI One

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI One. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v3 04/20] ARM: sun8i: dt: Add DT bindings documentation for Allwinner syscon

2017-04-03 Thread Corentin Labbe
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/misc/allwinner,syscon.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/allwinner,syscon.txt diff --git a/Documentation/devi

[PATCH v3 12/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi plus

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI plus. It uses an external PHY rtl8211e via RGMII. This patch create the needed regulator, emac and phy nodes. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-plus.dt

[PATCH v3 07/20] ARM: dts: sunxi-h3-h5: add dwmac-sun8i ethernet driver

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. This patch enable the dwmac-sun8i on Allwinner H3/H5 SoC Device-tree. SoC H3/H5 have an internal PHY, so optionals syscon and ephy are set. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/bo

[PATCH v3 09/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange PI PC

2017-04-03 Thread Corentin Labbe
From: LABBE Corentin <clabbe.montj...@gmail.com> The dwmac-sun8i hardware is present on the Orange PI PC. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 8

[PATCH v3 13/20] ARM: dts: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high

2017-04-03 Thread Corentin Labbe
On the Orange Pi PC Plus, the polarity of the LEDs on the RJ45 Ethernet port were changed from active low to active high. Signed-off-by: Chen-Yu Tsai <w...@csie.org> Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts | 5 +

[PATCH v3 08/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Banana Pi M2+

2017-04-03 Thread Corentin Labbe
From: LABBE Corentin <clabbe.montj...@gmail.com> The dwmac-sun8i hardware is present on the Banana Pi M2+ It uses an external PHY rtl8211e via RGMII. This patch create the needed regulator, emac and phy nodes. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/

[PATCH v2] selftests: add a generic testsuite for ethernet device

2017-04-04 Thread Corentin Labbe
This patch add a generic testsuite for testing ethernet network device driver. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- Changes since v1: - Test for starting master interface - Changed printing format to "RESULT: $netdev: line" - Use "ip link"

Re: [PATCH v2] selftests: add a generic testsuite for ethernet device

2017-04-04 Thread Corentin Labbe
On Tue, Apr 04, 2017 at 04:43:19PM +0200, Niklas Cassel wrote: > On 04/04/2017 03:32 PM, Corentin Labbe wrote: > > This patch add a generic testsuite for testing ethernet network device > > driver. > > > > Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com&g

Re: [PATCH] selftests: add a generic testsuite for ethernet device

2017-04-03 Thread Corentin Labbe
On Fri, Mar 31, 2017 at 04:12:41PM +0200, Andrew Lunn wrote: > On Fri, Mar 31, 2017 at 02:57:52PM +0200, Corentin Labbe wrote: > > This patch add a generic testsuite for testing ethernet network device > > driver. > > > > Signed-off-by: Corentin Labbe

Re: [PATCH] selftests: add a generic testsuite for ethernet device

2017-04-04 Thread Corentin Labbe
On Mon, Apr 03, 2017 at 03:27:41PM +0200, Andrew Lunn wrote: > > By ifnum, you mean by the order that "ip link" gives ? > > I've not checked if it remains in order as interfaces are hot > plugged/unplugged. But i guess you are running tests direct after > boot, and unplugs/replugs are unlikely? >

[PATCH v3 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver

2017-04-03 Thread Corentin Labbe
. The remaining are DT patch enabling it. Regards Corentin Labbe Changes since v2: - corrected order of syscon compatible - added compatible = "ethernet-phy-ieee802.3-c22 to PHY - added set_mac function Changes since v1: - added TX/RX delay units - splitted syscon documentation in its own patch - regu

[PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr

2017-04-03 Thread Corentin Labbe
Thoses symbol will be needed for the dwmac-sun8i ethernet driver. For letting it to be build as module, they need to be exported. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

[PATCH v3 03/20] dt-bindings: net: Add DT bindings documentation for Allwinner dwmac-sun8i

2017-04-03 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the Allwinner dwmac-sun8i driver. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 77 ++ 1 file

[PATCH v3 02/20] net: stmmac: add optional setup function

2017-04-03 Thread Corentin Labbe
Instead of adding more ifthen logic for adding a new mac_device_info setup function, it is easier to add a function pointer to the function needed. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++- include/linux/st

Re: [PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr

2017-04-12 Thread Corentin Labbe
On Mon, Apr 03, 2017 at 02:39:03PM +0200, Giuseppe CAVALLARO wrote: > Hello Alex > > do you can check if this has to be done for ST platforms? > I do not remember that it was necessary when build as module so > I cannot expect this should be only for dwmac-sun8i. > > Regards > peppe >

Re: Network driver "test suite"

2017-04-12 Thread Corentin Labbe
On Wed, Apr 12, 2017 at 10:16:17AM +1000, Benjamin Herrenschmidt wrote: > Hi folks ! > > Does anybody knows of an existing kind of automated "test suite" for a > network/ethernet driver ? > > IE. Something we could run both on the "tested" driver and a cross-over > "known good" peer (possibly

[PATCH v4 06/18] arm: sun8i: sunxi-h3-h5: Add dt node for the syscon control module

2017-04-12 Thread Corentin Labbe
This patch add the dt node for the syscon register present on the Allwinner H3/H5 Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock.. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dt

[PATCH v4 18/18] arm: multi_v7: Enable dwmac-sun8i driver on multi_v7_defconfig

2017-04-12 Thread Corentin Labbe
Enable the dwmac-sun8i driver in the multi_v7 default configuration Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_def

[PATCH v4 12/18] arm64: allwinner: sun50i-a64: Add dt node for the syscon control module

2017-04-12 Thread Corentin Labbe
This patch add the dt node for the syscon register present on the Allwinner A64. Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a6

[PATCH v4 16/18] arm64: allwinner: bananapi-m64: Enable dwmac-sun8i

2017-04-12 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the BananaPi M64. It uses an external PHY rtl8211e via RGMII. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH v4 15/18] arm: allwinner: pine64-plus: Enable dwmac-sun8i

2017-04-12 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the pine64 plus. It uses an external PHY rtl8211e via RGMII. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../arm64/boot/dts/allwinner/sun50i-a64-pine64-plus.dts | 17 - 1 file changed, 16 insertions(+), 1 deletion(-)

[PATCH v4 14/18] arm: allwinner: pine64: Enable dwmac-sun8i

2017-04-12 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the pine64 It uses an external PHY via RMII. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/bo

[PATCH v4 17/18] arm: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig

2017-04-12 Thread Corentin Labbe
Enable the dwmac-sun8i driver in the sunxi default configuration Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/configs/sunxi_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig index 5c

[PATCH v4 13/18] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver

2017-04-12 Thread Corentin Labbe
at this level. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 37 +++ 1 file changed, 37 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

[PATCH v4 00/18] net-next: stmmac: add dwmac-sun8i ethernet driver

2017-04-12 Thread Corentin Labbe
. The remaining are DT patch enabling it. Regards Corentin Labbe Changes since v3: - Renamed tx-delay/rx-delay to tx-delay-ps/rx-delay-ps - fix syscon compatible example - Changed parameter type for setup() function - Dropped some DT patchs for boards which I could not test further Changes since v2

[PATCH v4 03/18] dt-bindings: net: Add DT bindings documentation for Allwinner dwmac-sun8i

2017-04-12 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the Allwinner dwmac-sun8i driver. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 77 ++ 1 file

[PATCH v4 02/18] net: stmmac: add optional setup function

2017-04-12 Thread Corentin Labbe
Instead of adding more ifthen logic for adding a new mac_device_info setup function, it is easier to add a function pointer to the function needed. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++- include/linux/st

[PATCH v4 05/18] net-next: stmmac: Add dwmac-sun8i

2017-04-12 Thread Corentin Labbe
The dwmac-sun8i is a heavy hacked version of stmmac hardware by allwinner. In fact the only common part is the descriptor management and the first register function. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/Kconfig| 11 + d

[PATCH v4 07/18] arm: sun8i: sunxi-h3-h5: add dwmac-sun8i ethernet driver

2017-04-12 Thread Corentin Labbe
The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. This patch enable the dwmac-sun8i on Allwinner H3/H5 SoC Device-tree. SoC H3/H5 have an internal PHY, so optionals syscon and ephy are set. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/bo

[PATCH v4 09/18] arm: sun8i: orangepi-2: Enable dwmac-sun8i

2017-04-12 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI 2. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8 1 file changed, 8 insertions(+) diff --git a/ar

[PATCH v4 04/18] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon

2017-04-12 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the syscon present in allwinner devices. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/misc/allwinner,syscon.txt | 19 +++ 1 file changed, 19 insertions(+) create mode

[PATCH v4 01/18] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr

2017-04-12 Thread Corentin Labbe
Thoses symbol will be needed for the dwmac-sun8i ethernet driver. For letting it to be build as module, they need to be exported. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

[PATCH v4 08/18] arm: sun8i: orangepi-pc: Enable dwmac-sun8i

2017-04-12 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI PC. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v4 10/18] arm: sun8i: orangepi-one: Enable dwmac-sun8i

2017-04-12 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI One. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v4 11/18] arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high

2017-04-12 Thread Corentin Labbe
On the Orange Pi PC Plus, the polarity of the LEDs on the RJ45 Ethernet port were changed from active low to active high. Signed-off-by: Chen-Yu Tsai <w...@csie.org> Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts | 5 +

Re: [PATCH 0/4 v2 net-next] net: stmmac: adding multiple buffers

2017-04-07 Thread Corentin Labbe
450 deletions(-) > > -- > 2.9.3 > For whole serie, Tested-by: Corentin Labbe <clabbe.montj...@gmail.com>

Re: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

2017-04-07 Thread Corentin Labbe
On Mon, Apr 03, 2017 at 01:38:47PM +0200, Maxime Ripard wrote: > On Mon, Apr 03, 2017 at 11:14:40AM +0200, Corentin Labbe wrote: > > The dwmac-sun8i hardware is present on the pine64 > > It uses an external PHY via RMII. > > > > Signed-off-by: Corentin Labbe <clabbe.

Re: [PATCH v3 02/20] net: stmmac: add optional setup function

2017-04-07 Thread Corentin Labbe
On Mon, Apr 03, 2017 at 02:32:33PM +0200, Giuseppe CAVALLARO wrote: > Hello Corentin > > On 4/3/2017 11:14 AM, Corentin Labbe wrote: > > Instead of adding more ifthen logic for adding a new mac_device_info > > setup function, it is easier to add a function pointer to th

Re: [PATCH v3 04/20] ARM: sun8i: dt: Add DT bindings documentation for Allwinner syscon

2017-04-07 Thread Corentin Labbe
On Mon, Apr 03, 2017 at 01:19:54PM +0200, Maxime Ripard wrote: > On Mon, Apr 03, 2017 at 11:14:28AM +0200, Corentin Labbe wrote: > > Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> > > --- > > .../devicetree/bindings/misc/allwinner,syscon.txt | 19 >

Re: [PATCH 0/4 v2 net-next] net: stmmac: adding multiple buffers

2017-04-05 Thread Corentin Labbe
On Wed, Apr 05, 2017 at 05:43:00PM +0100, Joao Pinto wrote: > This patch adds multiple buffers to stmmac in a more fragmented > way, in order to make problem debug easier. > > I would kindly request to people to test this patch in their HWs in > order to check if everything's functional. Thank

<    1   2   3   4   5   >