Re: tc related lockdep warning.

2006-09-26 Thread Dave Jones
On Tue, Sep 26, 2006 at 06:15:21PM +0200, Patrick McHardy wrote: Patrick McHardy wrote: jamal wrote: Yes, that looks plausible. Can you try making those changes and see if the warning is gone? I think this points to a bigger brokeness caused by the move of dev-qdisc to

tc related lockdep warning.

2006-09-24 Thread Dave Jones
= [ INFO: inconsistent lock state ] - inconsistent {softirq-on-R} - {in-softirq-W} usage. swapper/0 [HC0[0]:SC1[2]:HE1:SE0] takes: (police_lock){-+--}, at: [f8d304fd] tcf_police_destroy+0x24/0x8f [act_police] {softirq-on-R} state

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Dave Jones
On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: Refine cb cleaning debug printout and print out all cleaned cbs' status. Add debug flag for EEPROM csum failures that were overridden by the user. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Dave Jones
On Tue, Sep 19, 2006 at 05:40:34PM -0400, Jeff Garzik wrote: Dave Jones wrote: On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: + add_taint(TAINT_MACHINE_CHECK); I object to this flag being abused this way. A corrupt EEPROM on a network card has

neigh_lookup lockdep warning

2006-09-02 Thread Dave Jones
Seen during boot of a 2.6.18rc5-git1 based kernel. Dave === [ INFO: possible circular locking dependency detected ] 2.6.17-1.2608.fc6 #1 --- swapper/0 is trying to acquire

Re: [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()

2006-08-15 Thread Dave Jones
On Tue, Aug 15, 2006 at 03:25:58PM -0400, Pavel Roskin wrote: diff --git a/drivers/net/wireless/orinoco.h b/drivers/net/wireless/orinoco.h index 16db3e1..8fd9b32 100644 --- a/drivers/net/wireless/orinoco.h +++ b/drivers/net/wireless/orinoco.h @@ -135,11 +135,9 @@ extern irqreturn_t

remove unnecessary config.h includes from drivers/net/

2006-08-10 Thread Dave Jones
On Wed, Aug 09, 2006 at 09:04:38PM -0700, David Miller wrote: From: Dave Jones [EMAIL PROTECTED] Date: Wed, 9 Aug 2006 22:21:16 -0400 config.h is automatically included by kbuild these days. Signed-off-by: Dave Jones [EMAIL PROTECTED] Applied to net-2.6.19, thanks Dave

IPX changes introduce warning.

2006-08-09 Thread Dave Jones
We've just added an implicit declaration in the latest tree.. net/ipx/af_ipx.c: In function 'ipx_rcv': net/ipx/af_ipx.c:1648: error: implicit declaration of function 'ipxhdr' (Yes, my builds fail on -Werror-implicit, so that things like this get caught early) Probably something simple like a

remove unnecessary config.h includes from net/

2006-08-09 Thread Dave Jones
config.h is automatically included by kbuild these days. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6/net/ipv4/netfilter/ip_conntrack_sip.c~2006-08-09 22:18:48.0 -0400 +++ linux-2.6/net/ipv4/netfilter/ip_conntrack_sip.c 2006-08-09 22:18:53.0 -0400 @@ -8,7

another networking lockdep trace.

2006-08-08 Thread Dave Jones
From a recent rc3-git kernel. Dave -- http://www.codemonkey.org.uk ---BeginMessage--- Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201560

Re: orinoco driver causes *lots* of lockdep spew

2006-08-03 Thread Dave Jones
On Thu, Aug 03, 2006 at 03:11:53PM +0100, Christoph Hellwig wrote: Could we please just get rid of the wireless extensions over netlink code again? It doesn't help to solve anything and just creates a bigger mess to untangle when switching to a fully fledged wireless stack. If we're going

Re: orinoco driver causes *lots* of lockdep spew

2006-08-03 Thread Dave Jones
On Thu, Aug 03, 2006 at 11:58:00AM -0700, Jean Tourrilhes wrote: On Thu, Aug 03, 2006 at 03:11:53PM +0100, Christoph Hellwig wrote: On Thu, Aug 03, 2006 at 11:54:41PM +1000, Herbert Xu wrote: Arjan van de Ven [EMAIL PROTECTED] wrote: this is another one of those nasty buggers;

orinoco driver causes *lots* of lockdep spew

2006-08-02 Thread Dave Jones
Wow. Nearly 400 lines of debug spew, from a simple 'ifup eth1'. Dave ADDRCONF(NETDEV_UP): eth1: link is not ready eth1: New link status: Disconnected (0002) == [ INFO: hard-safe - hard-unsafe lock order detected ]

neigh_lookup lockdep bug.

2006-07-31 Thread Dave Jones
2.6.18rc2-gitSomething on my firewall box just triggered this.. Dave [515613.791771] === [515613.841467] [ INFO: possible circular locking dependency detected ] [515613.873284]

Re: [PATCH] mark sk98lin driver for removal

2006-07-22 Thread Dave Jones
mainline, and backed out numerous fixes made to it in the mainline kernel. It's a huge effort to get the 'good bits' out of that patch, and letting it die is the only sensible solution IMO. ACKed-by: Dave Jones [EMAIL PROTECTED] +SK98LIN GIGABBIT ETHERNET DRIVER typo :-) Dave

sch_htb compile fix.

2006-07-15 Thread Dave Jones
net/sched/sch_htb.c: In function 'htb_change_class': net/sched/sch_htb.c:1605: error: expected ';' before 'do_gettimeofday' Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.17.noarch/net/sched/sch_htb.c~2006-07-15 03:40:14.0 -0400 +++ linux-2.6.17.noarch/net/sched/sch_htb.c

another networking lockdep bug

2006-07-12 Thread Dave Jones
Not sure if this one got reported/fixed yet, as I was running a kernel from sometime last week.. Dave === [ INFO: possible circular locking dependency detected ] ---

starting mc triggers lockdep

2006-07-07 Thread Dave Jones
With 2.6.18rc1 + a selection of the lockdep tweaks found so far, midnight commander makes the kernel unhappy. Dave === [ INFO: possible circular locking dependency detected ]

e100 lockdep irq lock inversion.

2006-07-07 Thread Dave Jones
Another one triggered by a Fedora-development user.. e100: eth1: e100_watchdog: link up, 100Mbps, half-duplex = [ INFO: possible irq lock inversion dependency detected ] - ipcalc/1671

more rc1 lockdep fun.

2006-07-07 Thread Dave Jones
=== [ INFO: possible circular locking dependency detected ] --- gnome-settings-/3278 is trying to acquire lock: (sk_lock-AF_INET){--..}, at: [8022800c] tcp_sendmsg+0x1f/0xb1a but task

Re: 2.6.17-mm4

2006-06-30 Thread Dave Jones
On Fri, Jun 30, 2006 at 01:14:30PM +0100, Alan Cox wrote: Ar Gwe, 2006-06-30 am 11:54 +0200, ysgrifennodd Arjan van de Ven: another quick hack is to check for vesa lb... eg if pci is present, skip this thing entirely :) Not really, many people made VLB/PCI combo boards. - check the

Re: 2.6.17-mm4

2006-06-29 Thread Dave Jones
On Thu, Jun 29, 2006 at 10:46:24PM +0200, Michal Piotrowski wrote: On 29/06/06, Dave Jones [EMAIL PROTECTED] wrote: On Thu, Jun 29, 2006 at 10:39:33PM +0200, Michal Piotrowski wrote: This looks very strange. BUG: unable to handle kernel paging request at virtual address 6b6b6c07

Re: 2.6.17-mm4

2006-06-29 Thread Dave Jones
On Thu, Jun 29, 2006 at 10:39:33PM +0200, Michal Piotrowski wrote: This looks very strange. BUG: unable to handle kernel paging request at virtual address 6b6b6c07 Looks like a use after free. printing eip: c0138594 *pde= Oops: 0002 [#1] 4K_STACK PREEMPT SMP last

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-12 Thread Dave Jones
On Mon, Jun 12, 2006 at 06:39:58PM +0300, Faidon Liambotis wrote: FWIW, I think we've experienced a similar situation like this in the past in the networking land and the consensus was to completely remove the other driver. I'm referring to e100/eepro100, of course. The difference with

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-11 Thread Dave Jones
On Sat, Jun 10, 2006 at 02:08:50PM -0400, Dave Jones wrote: On Sat, Jun 10, 2006 at 08:50:10PM +0300, Faidon Liambotis wrote: Remove Prism II IDs from the orinoco driver since now we have a separate driver for them (HostAP). Additionally, kill orinoco_{pci,plx,nortel} completely

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-11 Thread Dave Jones
On Sun, Jun 11, 2006 at 06:27:19PM -0400, Dave Jones wrote: On Sat, Jun 10, 2006 at 02:08:50PM -0400, Dave Jones wrote: On Sat, Jun 10, 2006 at 08:50:10PM +0300, Faidon Liambotis wrote: Remove Prism II IDs from the orinoco driver since now we have a separate driver for them

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-11 Thread Dave Jones
On Sun, Jun 11, 2006 at 06:31:40PM -0400, Kyle McMartin wrote: On Sun, Jun 11, 2006 at 06:40:54PM -0400, Dave Jones wrote: Under hostap, it's a brick, it won't even report any scanning results. Did you switch it into managed mode? The hostap driver, iirc, defaults to running

Remove useless check for null dev from uli526x_interrupt()

2006-06-11 Thread Dave Jones
As we're already dereferencing dev a few lines above, if this check could ever trigger, we'd have already oopsed. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6/drivers/net/tulip/uli526x.c~ 2006-06-11 20:24:41.0 -0400 +++ linux-2.6/drivers/net/tulip/uli526x.c 2006

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-10 Thread Dave Jones
On Sat, Jun 10, 2006 at 08:50:10PM +0300, Faidon Liambotis wrote: Remove Prism II IDs from the orinoco driver since now we have a separate driver for them (HostAP). Additionally, kill orinoco_{pci,plx,nortel} completely, since they only exist to support Prism cards. No attempt was made to

Re: 2.6.17-rc6-mm1

2006-06-07 Thread Dave Jones
On Wed, Jun 07, 2006 at 10:47:24AM -0700, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc6/2.6.17-rc6-mm1/ Just spotted this typo in a new option. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- rc6mm1/net/Kconfig~ 2006-06-07 14:19:44.0

Re: latest -stable breaks Squid

2006-05-04 Thread Dave Jones
On Thu, May 04, 2006 at 04:25:46PM -0700, David S. Miller wrote: That being said, the first thing that should be tried is reverting the above mentioned change and see if the problem goes away. If so, then we need to investigate what the bandwidth delay product is for the connection, and

latest -stable breaks Squid

2006-05-03 Thread Dave Jones
So I pushed out an update for Fedora Core 5 users yesterday that moved the kernel from 2.6.16.9 to 2.6.16.13. I've since heard My network performance is awful, and worse yet, some apps seem broken as in the report below. Anyone have any ideas ? Dave --

Re: latest -stable breaks Squid

2006-05-03 Thread Dave Jones
On Wed, May 03, 2006 at 05:19:15PM -0400, Dave Jones wrote: So I pushed out an update for Fedora Core 5 users yesterday that moved the kernel from 2.6.16.9 to 2.6.16.13. I've since heard My network performance is awful, and worse yet, some apps seem broken as in the report below. Further

E1000 stopped transmitting in rc3.

2006-04-27 Thread Dave Jones
With 2.6.17-rc3, my E1000 won't get a dhcp lease. Looking at tcpdump and ifconfig output, it's easy to see why. It's recieving packets, but the packets transmitted field of ifconfig never increases. The last version I have built that worked ok was 2.6.17rc2-git3 NIC is .. 03:0e.0 Ethernet

Re: [IPSEC]: Kill unused decap state argument

2006-04-02 Thread Dave Jones
/selinux/xfrm.c:317: error: 'struct sec_path' has no member named 'x' Does this look sane ? Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.16.noarch/security/selinux/xfrm.c~2006-04-02 23:27:07.0 -0500 +++ linux-2.6.16.noarch/security/selinux/xfrm.c 2006-04-02 23:27

rtnetlink compile failure.

2006-03-24 Thread Dave Jones
: undefined reference to `wireless_rtnetlink_get' Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.16.noarch/drivers/net/wireless/Kconfig~ 2006-03-24 18:01:46.0 -0500 +++ linux-2.6.16.noarch/drivers/net/wireless/Kconfig2006-03-24 18:02:03.0 -0500 @@ -27,6 +27,7

potential leak in tun_get_user

2006-03-08 Thread Dave Jones
We're leaking an skb in a failure path in this function. Coverity #632 Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6/drivers/net/tun.c~2006-03-08 22:43:54.0 -0500 +++ linux-2.6/drivers/net/tun.c 2006-03-08 22:46:16.0 -0500 @@ -249,8 +249,11 @@ static

Another gss_krb5 double kfre

2006-03-06 Thread Dave Jones
Variation on a theme, with same result - double free of same object. Coverity #950 Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6/net/sunrpc/auth_gss/gss_krb5_seal.c~ 2006-03-06 04:23:05.0 -0500 +++ linux-2.6/net/sunrpc/auth_gss/gss_krb5_seal.c 2006-03-06 04:23

remove useless test in ip6_append_data

2006-03-05 Thread Dave Jones
We've already dereferenced 'np' a dozen times at this point, so it's safe to say it's not null. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.15.noarch/net/ipv6/ip6_output.c~ 2006-03-06 02:22:05.0 -0500 +++ linux-2.6.15.noarch/net/ipv6/ip6_output.c 2006-03-06 02:23

Re: ratelimit atmsvc failure messages

2006-02-13 Thread Dave Jones
On Mon, Feb 13, 2006 at 03:35:05PM -0800, David S. Miller wrote: From: Dave Jones [EMAIL PROTECTED] Date: Sat, 11 Feb 2006 19:24:23 -0500 This seems to be trivial to trigger. Signed-off-by: Dave Jones [EMAIL PROTECTED] Applied, thanks. I did some more testing with this. Rate

Re: two bluetooth oopses in 2.6.16rc2-git

2006-02-12 Thread Dave Jones
On Sun, Feb 12, 2006 at 09:46:43AM +0100, Marcel Holtmann wrote: Triggered whilst running a socket stress test. (The tainted flag came from 'p8023') does 2.6.15-1.1929_FC5smp equals 2.6.16-rc2-git? yes. How do you produce these oopses, because I've never seen them.

Re: two bluetooth oopses in 2.6.16rc2-git

2006-02-12 Thread Dave Jones
On Sun, Feb 12, 2006 at 10:19:36AM +0100, Marcel Holtmann wrote: Hi Dave, Triggered whilst running a socket stress test. (The tainted flag came from 'p8023') does 2.6.15-1.1929_FC5smp equals 2.6.16-rc2-git? yes. not additional Fedora specific patches? It is

Re: ratelimit irda messages

2006-02-12 Thread Dave Jones
suggested that to me off-list, but I hadn't got around to it yet. Looks good to me. Signed-off-by: Dave Jones [EMAIL PROTECTED] Dave - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

ratelimit atmsvc failure messages

2006-02-11 Thread Dave Jones
This seems to be trivial to trigger. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.15.noarch/net/atm/signaling.c~2006-02-11 19:20:09.0 -0500 +++ linux-2.6.15.noarch/net/atm/signaling.c 2006-02-11 19:21:30.0 -0500 @@ -56,7 +56,8 @@ static void sigd_put_skb

Re: p8023 taints kernel

2006-02-11 Thread Dave Jones
On Sat, Feb 11, 2006 at 06:11:48PM -0800, Randy.Dunlap wrote: needs quotes: GPL Indeed. Missing license tag. I've assumed this is GPL. (It could also use a MODULE_AUTHOR) Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.15.noarch/net/802/p8023.c~2006-02-11 21:15

Re: p8023 taints kernel

2006-02-11 Thread Dave Jones
On Sat, Feb 11, 2006 at 07:37:19PM -0800, David S. Miller wrote: From: Dave Jones [EMAIL PROTECTED] Date: Sat, 11 Feb 2006 21:17:38 -0500 On Sat, Feb 11, 2006 at 06:11:48PM -0800, Randy.Dunlap wrote: needs quotes: GPL Indeed. Dave, please type make patches you

two bluetooth oopses in 2.6.16rc2-git

2006-02-11 Thread Dave Jones
Triggered whilst running a socket stress test. (The tainted flag came from 'p8023') Dave Feb 11 21:52:00 trogdor kernel: Unable to handle kernel NULL pointer dereference at virtual address 01b0 Feb 11 21:52:00 trogdor kernel: printing eip: Feb 11 21:52:00 trogdor kernel:

slab corruption in 2.6.16rc1-git4

2006-02-02 Thread Dave Jones
I've had a box being tortured with random junk packets (created with isic) for a few days, and it spat this out last night.. Feb 1 04:28:09 trogdor kernel: Slab corruption: (Not tainted) start=cefc8a9c, len=244 Feb 1 04:28:09 trogdor kernel: Redzone: 0x5a2cf071/0x5a2cf071. Feb 1 04:28:09

Re: badness in dst_release

2006-02-02 Thread Dave Jones
On Wed, Feb 01, 2006 at 01:08:33PM -0500, Dave Jones wrote: I managed to get a box running 2.6.16rc1-git4 to spit this out.. Dave UDP: bad checksum. From 192.168.79.115:43047 to 192.168.76.106:61494 ulen 1083 Badness in dst_release at include/net/dst.h:154

Re: badness in dst_release

2006-02-02 Thread Dave Jones
On Thu, Feb 02, 2006 at 04:49:29PM -0800, David S. Miller wrote: From: Dave Jones [EMAIL PROTECTED] Date: Thu, 2 Feb 2006 14:30:28 -0500 Here's a second flavour. Can you git bisect to figure out when this problem started to occur? I'll give it a try sometime soon, though I'm up

Re: [PATCH] add CONFIG_NETDEBUG to suppress bad packet messages

2006-02-02 Thread Dave Jones
On Thu, Feb 02, 2006 at 04:35:01PM -0800, Stephen Hemminger wrote: If you are on a hostile network, or are running protocol tests, you can easily get the logged swamped by messages about bad UDP and ICMP packets. This turns those messages off unless a config option is enabled.

Re: [PATCH] add CONFIG_NETDEBUG to suppress bad packet messages

2006-02-02 Thread Dave Jones
packets. This turns those messages off unless a config option is enabled. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] NETDEBUG should print out something by default. We should fix the NETDEBUG() users. Dave Jones recently fixed a case in IGMP, for example. It should

badness in dst_release

2006-02-01 Thread Dave Jones
I managed to get a box running 2.6.16rc1-git4 to spit this out.. Dave UDP: bad checksum. From 192.168.79.115:43047 to 192.168.76.106:61494 ulen 1083 Badness in dst_release at include/net/dst.h:154 (Not tainted) [c029d580] __kfree_skb+0x36/0xdd [c02ba807]

Re: [2.6 patch] schedule SHAPER for removal

2006-01-22 Thread Dave Jones
On Sun, Jan 22, 2006 at 07:32:56PM +0100, Arjan van de Ven wrote: The only supported combinations are distributions with the kernels they ship. I think you're being unreasonable here. Absolutely. The statement is also completely false. Fedora rebases to a new point release shortly

Re: [PATCH 2/2] sk98lin: module table alias

2006-01-18 Thread Dave Jones
On Wed, Jan 18, 2006 at 11:56:26AM -0800, Stephen Hemminger wrote: Nack. changing module tables in one driver depending on another driver is always bogus. Better send a patch to udev/modutils/whatever maintainers to prefer one over the others. Is there really any such stuff

Badness in cache_free_debugcheck at mm/slab.c:2315

2006-01-11 Thread Dave Jones
We got this in Fedora bugzilla from a user running a 2.6.15-rc7-git2 vintage kernel. This seemed important enough to warrant a closer look by someone familiar with recent networking changes in case this hasn't been reported/fixed yet. Dave On Sat, Jan 07, 2006 at 08:13:54PM

dccp_ipv6 fails to link on some archs.

2006-01-06 Thread Dave Jones
Our daily build-system spat this out about 2.6.15-git2 WARNING: /usr/src/build/676459-ia64/install/lib/modules/2.6.15-1.1830_FC5/kernel/net/dccp/dccp_ipv6.ko needs unknown symbol csum_ipv6_magic WARNING:

Re: [PATCH] skge: get rid of warning on race

2005-12-13 Thread Dave Jones
On Mon, Dec 12, 2005 at 09:59:30PM -0800, Linux Kernel wrote: tree 987cfbd2134b82bea55c55fa17bd70d29df70458 parent 0e670506668a43e1355b8f10c33d081a676bd521 author Stephen Hemminger [EMAIL PROTECTED] Wed, 07 Dec 2005 07:01:49 -0800 committer Jeff Garzik [EMAIL PROTECTED] Tue, 13 Dec 2005

Re: Broadcom 43xx first results

2005-12-05 Thread Dave Jones
On Mon, Dec 05, 2005 at 02:08:28PM -0500, Jeff Garzik wrote: Jiri Benc wrote: On Mon, 05 Dec 2005 13:38:37 -0500, Joseph Jezak wrote: We're not writing an entire stack. We're writing a layer that sits in between the current ieee80211 stack that's already present in the kernel and

e1000 checksum problem

2005-11-20 Thread Dave Jones
Has anything changed recently in how e1000 handles checksum offload ? My desktop box has been rock solid for months, but the last few weeks I've noticed a lot of timeouts over http etc. Further investigation with ethereal showed incorrect tcp checksums on certain packets. Disabling rx/tx offload

Re: e1000 checksum problem

2005-11-20 Thread Dave Jones
On Mon, Nov 21, 2005 at 08:07:20AM +1100, Herbert Xu wrote: Dave Jones [EMAIL PROTECTED] wrote: Has anything changed recently in how e1000 handles checksum offload ? My desktop box has been rock solid for months, but the last few weeks I've noticed a lot of timeouts over http etc

Re: e1000 checksum problem

2005-11-20 Thread Dave Jones
On Mon, Nov 21, 2005 at 08:25:14AM +1100, Herbert Xu wrote: On Sun, Nov 20, 2005 at 04:21:32PM -0500, Dave Jones wrote: Hmm, that does make sense. Maybe the problem exists elsewhere, as thinking more about it, it's only certain sites that seem to have the problem (I notice

<    1   2