Re: RFC3927 ARP patch status?

maintainers are so inclined, they can do the necessary things to get it into the mainline. David Daney - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: RFC3927 ARP patch status?

be a mine field, but the only thing that has to be changed in the kernel to support it is to somehow configure the arp driver to broadcast unconditionally on certain interfaces. The majority of the rfc3927 protocol is done by userspace applications, so should *not* really effect the kernel. David

Re: RFC3927 ARP patch status?

Anand Kumria wrote: Herbert, On Sat, Jun 03, 2006 at 09:12:06AM +1000, Herbert Xu wrote: David Daney [EMAIL PROTECTED] wrote: There were some discussions about whether it made sense for the kernel to support the behavior required by the RFC. Other comments debated the wisdom of using

[PATCH] net: Broadcast ARP packets on link local addresses

From: David Daney Greetings, When an internet host joins a network where there is no DHCP server, it may auto-allocate an IP address by the method described in RFC 3927. There are several user space daemons available that implement most of the protocol (zcip, busybox, ...). The kernel's APR

Re: [PATCH] net: Broadcast ARP packets on link local addresses

Herbert Xu wrote: On Fri, Mar 31, 2006 at 09:49:31PM -0500, jamal wrote: The RFC seems to talk about sender IP address instead though... my understanding: the sender is trying to claim that IP and is setting the destination to the IP it is trying to claim and see if someone responds. Are

Re: [PATCH] net: Broadcast ARP packets on link local addresses

in devices that are certified to comply with these standards need something similar to the patch. That said, other messages have pointed out several issues with the patch, so I will go about creating a new version. In any event I think these discussions have been beneficial. Thanks, David Daney

[PATCH] net: Broadcast ARP packets on link local addresses (Version2).

From: David Daney Here is a new version of the patch I sent March 31. For background, this is my description from the first patch: When an internet host joins a network where there is no DHCP server, it may auto-allocate an IP address by the method described in RFC 3927. There are several

Re: Broadcast ARP packets on link local addresses (Version2).

Janos Farkas wrote: On 2006-04-05 at 14:22:08, David Daney wrote: The changes in this version are that it tests the source IP address instead of the destination. The test now matches the test described in the RFC. Also a small cleanup as suggested by Herbert Xu. Some comments on the first

Re: Broadcast ARP packets on link local addresses (Version2).

? There must be one or more reasons that it exists. It must not exist to cause IPv4 ARP to do broadcast as specified in RFC 3927, or we would not be having this conversation. Overloading its current semantics, will cause in unnecessary ARP broadcasts in non RFC 3927 cases. David Daney

Re: Broadcast ARP packets on link local addresses (Version2).

jamal wrote: On Fri, 2006-07-04 at 11:31 -0700, David Daney wrote: jamal wrote: It exists. Just use it. For testing just use the ip utility. But why does it exist? There must be one or more reasons that it exists. There is only one reason it exists: to define an IP address as being

Re: Broadcast ARP packets on link local addresses (Version2).

jamal wrote: On Thu, 2006-06-04 at 09:17 -0700, David Daney wrote: Janos Farkas wrote: Sorry for chiming in this late in the discussion, but... Shouldn't it be more correct to not depend on the ip address of the used network, but to use the scope parameter of the given address

Re: Broadcast ARP packets on link local addresses (Version2).

that when we transition to using 2.6 kernels it would already be in place. Thanks, David Daney - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Broadcast ARP packets on link local addresses (Version2).

to the general public due to is having been posted (as is your original patch). So those who really need of something like this have options. David Daney - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller

writeq()/readq() and suffer a decrease in performance. I/we wouldn't object to either of these, so it is really up to you. Please let us know what you think the best way forward is. Thanks, David Daney -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH] net: thunderx: add 64-bit dependency

for the quick fix. I agree with your analysis... Acked-by: David Daney david.da...@cavium.com diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig index 6365fb4242be..fc3d8e3ee807 100644 --- a/drivers/net/ethernet/cavium/Kconfig +++ b/drivers/net/ethernet

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

On 08/12/2015 08:23 AM, Catalin Marinas wrote: On Tue, Aug 11, 2015 at 01:04:55PM -0700, David Daney wrote: On 08/11/2015 11:49 AM, David Miller wrote: From: David Daney ddaney.c...@gmail.com Date: Mon, 10 Aug 2015 17:58:35 -0700 Change from v1: Drop PHY binding part, use fwnode_property

Re: [PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.

/resources/nic-request-v2.pdf This actually seems to have been adopted by the UEFI people as a Standard, I am not sure where a record of this is kept though. So, we are changing our firmware to use this standard (which is quite similar the the DT with respect to MAC addresses). Thanks, David Daney

[PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent.

From: David Daney david.da...@cavium.com commit 18ee49ddb0d2 (phylib: rename mii_bus::dev to mii_bus::parent) changed the parent of PHY devices from the bus to the bus parent. Then, commit 4dea547fef1b (phylib: rework to prepare for OF registration of PHYs) moved the code into phy_device.c

Re: [PATCH 1/3] net: mdio-octeon: Modify driver to work on both ThunderX and Octeon

Chintakuntla rchintakun...@cavium.com Signed-off-by: David Daney david.da...@cavium.com --- drivers/net/phy/Kconfig |9 ++- drivers/net/phy/mdio-octeon.c | 122 +++- 2 files changed, 111 insertions(+), 20 deletions(-) diff --git a/drivers/net/phy/Kconfig b

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

On 08/11/2015 11:49 AM, David Miller wrote: From: David Daney ddaney.c...@gmail.com Date: Mon, 10 Aug 2015 17:58:35 -0700 Change from v1: Drop PHY binding part, use fwnode_property* APIs. The first patch (1/2) rearranges the existing code a little with no functional change to get ready

[PATCH 0/2] net: thunder: Add ACPI support.

From: David Daney david.da...@cavium.com Hook up PHYs, and get MAC address from ACPI for the thunder driver. The first patch (1/2) rearranges the existing code a little with no functional change to get ready for the second. The second (2/2) does the actual work of adding support to extract

[PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.

From: David Daney david.da...@cavium.com Find out which PHYs belong to which BGX instance in the ACPI way. Set the MAC address of the device as provided by ACPI tables. This is similar to the implementation for devicetree in of_get_mac_address(). The table is searched for the device property

[PATCH 1/2] net: thunder: Factor out DT specific code in BGX

From: Robert Richter rrich...@cavium.com Separate DT code in preparation for follow-on ACPI integration. Based on code from: Tomasz Nowicki tomasz.nowi...@linaro.org Signed-off-by: Robert Richter rrich...@cavium.com Signed-off-by: David Daney david.da...@cavium.com --- drivers/net/ethernet

Re: [PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.

On 08/07/2015 07:01 AM, Mark Rutland wrote: On Fri, Aug 07, 2015 at 01:33:10AM +0100, David Daney wrote: From: David Daney david.da...@cavium.com Find out which PHYs belong to which BGX instance in the ACPI way. Set the MAC address of the device as provided by ACPI tables. This is similar

Re: [PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.

. In the interests of code clarity and asthetics, we will go with the code without the #ifdefs, and rely on the compiler to optimize away any dead code. David Daney Tomasz -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.

On 08/07/2015 07:54 AM, Graeme Gregory wrote: On Thu, Aug 06, 2015 at 05:33:10PM -0700, David Daney wrote: From: David Daney david.da...@cavium.com Find out which PHYs belong to which BGX instance in the ACPI way. Set the MAC address of the device as provided by ACPI tables. This is similar

[PATCH v2 1/2] net: thunder: Factor out DT specific code in BGX

From: Robert Richter rrich...@redhat.com Separate DT code in preparation for follow-on ACPI integration. Based on code from: Tomasz Nowicki tomasz.nowi...@linaro.org Signed-off-by: Robert Richter rrich...@cavium.com Signed-off-by: David Daney david.da...@cavium.com --- drivers/net/ethernet

[PATCH v2 2/2] net, thunder, bgx: Add support to get MAC address from ACPI.

From: David Daney david.da...@cavium.com Currently there is no way to get the MAC address in a firmware independent manner, so set the MAC address of the device directly from the ACPI tables. The binding agrees with the proposed standard here: http://www.uefi.org/sites/default/files/resources

[PATCH v2 0/2] net: thunder: Add ACPI support.

From: David Daney david.da...@cavium.com Change from v1: Drop PHY binding part, use fwnode_property* APIs. The first patch (1/2) rearranges the existing code a little with no functional change to get ready for the second. The second (2/2) does the actual work of adding support to extract

[PATCH 4/4] net: thunderx: Incorporate pass2 silicon CPI index configuration changes

utham <sgout...@cavium.com> Signed-off-by: David Daney <david.da...@cavium.com> --- drivers/net/ethernet/cavium/thunder/nic_main.c | 29 -- drivers/net/ethernet/cavium/thunder/nic_reg.h | 4 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/dri

[PATCH 2/4] net: thunderx: Fix incorrect subsystem devid of VF on pass2 silicon

From: Sunil Goutham <sgout...@cavium.com> Signed-off-by: Sunil Goutham <sgout...@cavium.com> Signed-off-by: David Daney <david.da...@cavium.com> --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

[PATCH 3/4] net: thunderx: Rewrite silicon revision tests.

From: David Daney <david.da...@cavium.com> The test for pass-1 silicon was incorrect, it should be for all revisions less than 8. Also the revision is already present in the pci_dev, so there is no need to read and keep a private copy. Remove rev_id and code to read it from struct

[PATCH 0/4] net: thunderx: Support pass-2 revision hardware.

From: David Daney <david.da...@cavium.com> With the availability of a new revision of the ThunderX NIC hardware a few changes to the driver are required. With these, the driver works on all currently available hardware revisions. David Daney (1): net: thunderx: Rewrite silicon revision

[PATCH 1/4] net: thunderx: Remove PF soft reset.

From: Sunil Goutham <sgout...@cavium.com> In some silicon revisions, the soft reset clobbers PCI config space, so quit doing the reset. Signed-off-by: Sunil Goutham <sgout...@cavium.com> Signed-off-by: David Daney <david.da...@cavium.com> --- drivers/net/ethernet/cavium/thun

Re: SoCFPGA ethernet broken

On 10/15/2015 01:25 PM, Florian Fainelli wrote: On 15/10/15 12:59, Dinh Nguyen wrote: On 10/15/2015 03:03 PM, Florian Fainelli wrote: On 15/10/15 12:09, Dinh Nguyen wrote: Hi, commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." seems to have broken

Re: SoCFPGA ethernet broken

aps something like: const struct device *dev_walker; dev_walker = >dev; do { of_node = dev_walker->of_node; dev_walker = dev_walker->parent; } while (!of_node && dev_walker); An alternative would be to assign the bus the same of_node as the bus parent. If either approach

Re: [PATCH] net: mdio-octeon: Drop obsolete Kconfig advice

: Radha Mohan Chintakuntla <rchintakun...@cavium.com> Cc: David Daney <david.da...@cavium.com> Cc: David S. Miller <da...@davemloft.net> Jean, good catch: Acked-by: David Daney <david.da...@cavium.com> --- drivers/net/phy/Kconfig |2 -- 1 file changed, 2 deletions(-) --

Re: _DSD standardization note (WAS: Re: [PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.)

wrote: Hi David, On Sat, Aug 8, 2015 at 2:11 AM, David Daney <dda...@caviumnetworks.com> wrote: On 08/07/2015 05:05 PM, Rafael J. Wysocki wrote: [cut] It is actually useful to people as far as I can say. Also, if somebody is going to use properties with ACPI, why whould th

[PATCH] net: mdio-octeon: Add PCI driver binding.

From: David Daney <david.da...@cavium.com> When the Cavium mdio-octeon devices appear in the Thunder family of arm64 based SoCs, they show up as PCI devices. Add PCI driver wrapping so the driver is bound in the standard PCI device scan. When in this form, a single PCI device may have mor

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

On 09/24/2015 02:52 PM, David Miller wrote: From: David Daney <ddaney.c...@gmail.com> Date: Tue, 22 Sep 2015 17:41:36 -0700 From: David Daney <david.da...@cavium.com> When the Cavium mdio-octeon devices appear in the Thunder family of arm64 based SoCs, they show up as PCI devic

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

On 09/24/2015 03:14 PM, David Miller wrote: From: David Daney <dda...@caviumnetworks.com> Date: Thu, 24 Sep 2015 15:04:23 -0700 On 09/24/2015 02:52 PM, David Miller wrote: From: David Daney <ddaney.c...@gmail.com> Date: Tue, 22 Sep 2015 17:41:36 -0700 From: David Dan

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

On 09/24/2015 03:50 PM, David Miller wrote: From: David Daney <dda...@caviumnetworks.com> Date: Thu, 24 Sep 2015 15:45:41 -0700 2) The OF device tree nodes for PCI devices do not result in the creation of a platform device. But they are created for the children right? And that's the o

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

On 09/24/2015 03:04 PM, David Daney wrote: On 09/24/2015 02:52 PM, David Miller wrote: From: David Daney <ddaney.c...@gmail.com> Date: Tue, 22 Sep 2015 17:41:36 -0700 From: David Daney <david.da...@cavium.com> When the Cavium mdio-octeon devices appear in the Thunder family of

Re: [PATCH net] phy: micrel: Fix finding PHY properties in MAC node.

deprecated feature of allowing PHY properties to be placed into the MAC node. In order to find the MAC node, we need to walk up the tree of devices until we find one with an OF node attached. Reported-by: Dinh Nguyen <dingu...@opensource.altera.com> Suggested-by: David Daney <david.da..

Re: [PATCH net] phy: micrel: Fix finding PHY properties in MAC node.

deprecated feature of allowing PHY properties to be placed into the MAC node. In order to find the MAC node, we need to walk up the tree of devices until we find one with an OF node attached. Reported-by: Dinh Nguyen <dingu...@opensource.altera.com> Suggested-by: David Daney <david.da..

Re: SoCFPGA ethernet broken

S is supposed to be ABI. Old DTS should still work on new kernels in ideal world. If you supply the device tree file in the kernel tree, it is not an ABI. If the device tree is not part of the kernel, and instead comes from the boot firmware of the board, then you could make the ABI claim.

Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

change the bindings on the kernel side as you don't control the firmware. David Daney The patch fixes broken networking on EdgeRouter Lite. Fixes: ae461131960b ("of: of_mdio: Add a whitelist of PHY compatibilities.") Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> Revi

Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code.

, David Daney

Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code.

ke this in a general way. David Daney

Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code.

I am going to send a new version of this set. David Daney On 03/11/2016 09:53 AM, David Daney wrote: From: David Daney <david.da...@cavium.com> Changes from v1: - In 1/3 Add back check for non-OF objects in bgx_init_of_phy(). It is probably not necessary, but better safe than

Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code.

On 03/14/2016 12:27 PM, David Miller wrote: From: David Daney <ddaney.c...@gmail.com> Date: Fri, 11 Mar 2016 09:53:08 -0800 Changes from v1: - In 1/3 Add back check for non-OF objects in bgx_init_of_phy(). It is probably not necessary, but better safe than sorry... The fi

[PATCH 2/3] net: cavium: For Kconfig THUNDER_NIC_BGX, select MDIO_THUNDER.

From: David Daney <david.da...@cavium.com> Previously we selected MDIO_OCTEON, which after creating the Thunder specific MDIO bus driver is much less useful. Signed-off-by: David Daney <david.da...@cavium.com> --- drivers/net/ethernet/cavium/Kconfig | 2 +- 1 file changed, 1 ins

[PATCH 3/3] net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.

From: David Daney <david.da...@cavium.com> It is possible, although unlikely, that probing will find the phy_device for the first LMAC of a thunder BGX device, but then need to fail with -EPROBE_DEFER on a subsequent LMAC. In this case, we need to call put_device() on each of the phy_d

[PATCH 1/3] phy: mdio-cavium: Add missing MODULE_* annotations.

From: David Daney <david.da...@cavium.com> When the code was factored out of mdio-octeon.c, the MODULE_DESCRIPTION, MODULE_AUTHOR and MODULE_LICENSE annotations were inadvertently omitted. Restore them so that we don't get kernel taint warnings upon module loading. Signed-off-by: David

[PATCH 0/3] net/phy: Fixes for Cavium Thunder MDIO code.

From: David Daney <david.da...@cavium.com> Previous patch set: commit 5fc7cf179449 ("net: thunderx: Cleanup PHY probing code.") commit 1eefee901fca ("phy: mdio-octeon: Refactor into two files/modules") commit 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium

[PATCH] netdev: Move octeon/octeon_mgmt driver to cavium directory.

From: David Daney <david.da...@cavium.com> No code changes. Since OCTEON is a Cavium product, move the driver to the vendor directory to unclutter things a bit. Signed-off-by: David Daney <david.da...@cavium.com> --- drivers/net/ethernet/Kconfig | 1 -

[PATCH v2 2/3] phy: mdio-octeon: Refactor into two files/modules

From: David Daney <david.da...@cavium.com> A follow-on patch uses PCI probing to find the Thunder MDIO hardware. In preparation for this, split out the common code into a new file mdio-cavium.c, which will be used by both the existing OCTEON driver, and the new Thunder PCI based driver. A

Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code.

On 03/11/2016 09:31 AM, Andrew Lunn wrote: + phy_np = of_parse_phandle(node, "phy-handle", 0); + /* If there is no phy or defective firmware presents +* this cortina phy, for which there is no driver +* support, ignore it. +

[PATCH v2 1/3] net: thunderx: Cleanup PHY probing code.

From: David Daney <david.da...@cavium.com> Remove the call to force the octeon-mdio driver to be loaded. Allow the standard driver loading mechanisms to load the PHY drivers, and use -EPROBE_DEFER to cause the BGX driver to be probed only after the PHY drivers are available. Reorder the s

[PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.

From: David Daney <david.da...@cavium.com> The Cavium Thunder SoCs have multiple MIDO buses that are part of a single PCI device. To model this in the device tree we call the PCI parent device a "cavium,thunder-8890-mdio-nexus", it has several children, one for each MDIO bu

[PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code.

From: David Daney <david.da...@cavium.com> Changes from v1: - In 1/3 Add back check for non-OF objects in bgx_init_of_phy(). It is probably not necessary, but better safe than sorry... The firmware on many Cavium Thunder systems configures the MDIO bus hardware to be probed as a PCI

[PATCH 0/3] net/phy: Improvements to Cavium Thunder MDIO code.

From: David Daney <david.da...@cavium.com> The firmware on many Cavium Thunder systems configures the MDIO bus hardware to be probed as a PCI device. In order to use the MDIO bus drivers in this configuration, we must add PCI probing to the driver. There are two parts to this set of

[PATCH 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.

From: David Daney <david.da...@cavium.com> The Cavium Thunder SoCs have multiple MIDO buses that are part of a single PCI device. To model this in the device tree we call the PCI parent device a "cavium,thunder-8890-mdio-nexus", it has several children, one for each MDIO bu

[PATCH 1/3] net: thunderx: Cleanup PHY probing code.

From: David Daney <david.da...@cavium.com> Remove the call to force the octeon-mdio driver to be loaded. Allow the standard driver loading mechanisms to load the PHY drivers, and use -EPROBE_DEFER to cause the BGX driver to be probed only after the PHY drivers are available. Reorder the s

[PATCH 2/3] phy: mdio-octeon: Refactor into two files/modules

From: David Daney <david.da...@cavium.com> A follow-on patch uses PCI probing to find the Thunder MDIO hardware. In preparation for this, split out the common code into a new file mdio-cavium.c, which will be used by both the existing OCTEON driver, and the new Thunder PCI based driver. A

Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code.

e")" clause from this driver. Before this patchset, you did not special case this compatible string. So at the very least, you need to split this into a separate patch, so the maintainers can ACK/NACK it, independent of the other change it is embedded in. I can, and will, do that. Thanks, David Daney

Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.

On 03/16/2016 03:50 PM, Andreas Färber wrote: Hi, Am 11.03.2016 um 18:53 schrieb David Daney: diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 40faec9..075a4cc 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -196,6 +196,17 @@ config MDIO_OCTEON

Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code.

On 03/11/2016 10:00 AM, Andrew Lunn wrote: On Fri, Mar 11, 2016 at 09:41:06AM -0800, David Daney wrote: On 03/11/2016 09:31 AM, Andrew Lunn wrote: + phy_np = of_parse_phandle(node, "phy-handle", 0); + /* If there is no phy or defective firmwar

Re: [PATCH] net: thunderx: Fix broken of_node_put() code.

Due to mail server malfunction, this patch was sent twice. Please ignore this duplicate. Thanks, David Daney On 03/31/2016 06:01 PM, David Daney wrote: From: David Daney <david.da...@cavium.com> commit b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -E

[PATCH] net: thunderx: Fix broken of_node_put() code.

From: David Daney <david.da...@cavium.com> commit b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.") incorrectly moved the call to of_node_put() outside of the loop. Under normal loop exit, the node has already had of_node_put() called, s

[PATCH] net: thunderx: Fix broken of_node_put() code.

From: David Daney <david.da...@cavium.com> commit b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.") incorrectly moved the call to of_node_put() outside of the loop. Under normal loop exit, the node has already had of_node_put() called, s

[PATCH] net: thunderx: Fix broken of_node_put() code.

From: David Daney <david.da...@cavium.com> commit b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.") incorrectly moved the call to of_node_put() outside of the loop. Under normal loop exit, the node has already had of_node_put() called, s

Re: [PATCH] net: thunderx: Fix broken of_node_put() code.

On 04/08/2016 01:15 PM, David Miller wrote: From: David Daney <dda...@caviumnetworks.com> Date: Fri, 8 Apr 2016 09:41:35 -0700 Due to mail server malfunction, this patch was sent twice. Please ignore this duplicate. This submission had another problem too. Do not use the date o

Re: [PATCH] phy: mdio-thunder: Fix some Kconfig typos

On 03/16/2016 04:23 PM, Andreas Färber wrote: Drop two extra occurrences of "on" in option title and help text. Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.") Cc: David Daney <david.da...@cavium.com> Signed-off-by: Andrea

Re: [PATCH 1/1] net: thunderx: avoid null pointer dereference

<xypron.g...@gmx.de> In any event, it seems sane to make this change, so: Acked-by: David Daney <david.da...@cavium.com> --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ca

Re: [PATCH 05/15] ethernet: cavium: octeon: add missing of_node_put after calling of_parse_phandle

On 07/26/2016 07:20 PM, Peter Chen wrote: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen NAK. --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 1 + 1 file changed, 1

Re: [PATCH net-next 00/18] liquidio support for new device cn23xx

On 08/03/2016 11:55 AM, Raghu Vatsavayi wrote: Dave, Please consider following patches for support of new device CN23XX in liquidio family of adapters. Patches may have to be applied in following order as some of the patches depend on earlier patches. Thanks Raghu Vatsavayi. Raghu Vatsavayi

[PATCH] net: thunderx: Fix OOPs with ethtool --register-dump

From: David Daney <david.da...@cavium.com> The ethtool_ops .get_regs function attempts to read the nonexistent register NIC_QSET_SQ_0_7_CNM_CHG, which produces a "bus error" type OOPs. Fix by not attempting to read, and removing the definition of, NIC_QSET_SQ_0_7_CNM_CHG. A

[PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

Some Cavium dev boards have firmware which doesn't supply a proper ethernet-phy-ieee802.3-c22" compatible property. Restore these boards to working order by whitelisting this compatible value. Signed-off-by: David Daney <david.da...@cavium.com> --- drivers/of/of_mdio.c | 1 + 1 file

Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

On 02/17/2017 12:09 PM, Florian Fainelli wrote: On 02/17/2017 12:04 PM, David Daney wrote: Some Cavium dev boards have firmware which doesn't supply a proper ethernet-phy-ieee802.3-c22" compatible property. Restore these boards to working order by whitelisting this compatible value. S

Re: Improving OCTEON II 10G Ethernet performance

On 08/25/2016 11:22 AM, Aaro Koskinen wrote: Hi, On Thu, Aug 25, 2016 at 09:50:15AM -0700, David Daney wrote: Ideally we would configure the packet classifiers on the RX side to create multiple RX queues based on a hash of the TCP 5-tuple, and handle each queue with a single NAPI instance

Re: Improving OCTEON II 10G Ethernet performance

On 08/24/2016 06:29 PM, Ed Swierk wrote: I'm trying to migrate from the Octeon SDK to a vanilla Linux 4.4 kernel for a Cavium OCTEON II (CN6880) board running in 64-bit little-endian mode. So far I've gotten most of the hardware features I need working, including XAUI/RXAUI, USB, boot bus and

Re: Improving OCTEON II 10G Ethernet performance

On 08/25/2016 02:18 PM, Aaro Koskinen wrote: Hi, On Thu, Aug 25, 2016 at 01:11:45PM -0700, David Daney wrote: On 08/25/2016 11:22 AM, Aaro Koskinen wrote: On Thu, Aug 25, 2016 at 09:50:15AM -0700, David Daney wrote: Ideally we would configure the packet classifiers on the RX side to create

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

the answer is: Q: Have you tested the patch on OCTEON based hardware that contains the "octeon_mgmt" Ethernet ports? Please answer either "yes" or "no". Thanks, David Daney Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/net/ethe

Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap

. Thanks -Arvind On Wednesday 14 December 2016 11:02 PM, David Daney wrote: On 12/14/2016 08:25 AM, Arvind Yadav wrote: Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. i Have you ever seen

Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap

On 12/14/2016 08:25 AM, Arvind Yadav wrote: Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. Have you ever seen this failure in the wild? How was the patch tested? Thanks, David Daney

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

as well fixes it. Fixes: 111fc64a237f ("liquidio CN23XX: VF registration") Fixes: d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") Signed-off-by: Arnd Bergmann <a...@arndb.de> I didn't know about this new "imply" thing. This seems like a plausible fix,

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

On 12/19/2016 08:04 AM, David Miller wrote: From: Arvind Yadav Date: Thu, 15 Dec 2016 00:33:30 +0530 Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference.

Re: [PATCH 5/5] PCI: remove pci_enable_msix

On 03/27/2017 10:11 AM, Christoph Hellwig wrote: On Mon, Mar 27, 2017 at 09:59:35AM -0700, David Daney wrote: On 03/27/2017 01:29 AM, Christoph Hellwig wrote: Unused now that all callers switched to pci_alloc_irq_vectors. And you are aware that the ThunderX GPIO driver that I am attempting

Re: [PATCH 5/5] PCI: remove pci_enable_msix

in? You offer no solution for drivers that would benefit from using a sparse sub set of the available MSI-X vectors. David Daney Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/pci/msi.c | 21 - include/linux/pci.h | 4 2 files changed, 25 del

Re: [PATCH 5/5] PCI: remove pci_enable_msix

On 03/27/2017 11:41 PM, Christoph Hellwig wrote: On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote: Use pci_enable_msix_{exact,range} for now, as I told you before. That still results in twice as many MSI-X being provisioned than are needed. How so? Except for the return value

Re: [PATCH 5/5] PCI: remove pci_enable_msix

On 03/30/2017 03:56 PM, Bjorn Helgaas wrote: On Tue, Mar 28, 2017 at 09:24:15AM -0700, David Daney wrote: On 03/27/2017 11:41 PM, Christoph Hellwig wrote: On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote: Use pci_enable_msix_{exact,range} for now, as I told you before

[PATCH v2 5/5] MIPS: BPF: Fix multiple problems in JIT skb access helpers.

o Socket data is unsigned, so use unsigned accessors instructions. o Fix path result pointer generation arithmetic. o Fix half-word byte swapping code for unsigned semantics. Signed-off-by: David Daney <david.da...@cavium.com> --- arch/mips/net/bpf_jit_asm.S | 23

[PATCH v2 3/5] MIPS: BPF: Use unsigned access for unsigned SKB fields.

The SKB vlan_tci and queue_mapping fields are unsigned, don't sign extend these in the BPF JIT. In the vlan_tci case, the value gets masked so the change is not needed for correctness, but do it anyway for agreement with the types defined in struct sk_buff. Signed-off-by: David Daney <david

[PATCH v2 1/5] MIPS: uasm: Add support for LHU.

The follow-on BPF JIT patches use the LHU instruction, so add it. Signed-off-by: David Daney <david.da...@cavium.com> --- arch/mips/include/asm/uasm.h | 1 + arch/mips/mm/uasm-mips.c | 1 + arch/mips/mm/uasm.c | 3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff

[PATCH v2 0/5] MIPS: BPF: JIT fixes and improvements.

: 305 PASSED, 0 FAILED, [85/297 JIT'ed] Both big and little endian tested. We still lack eBPF support, but this is better than nothing. David Daney (5): MIPS: uasm: Add support for LHU. MIPS: BPF: Add JIT support for SKF_AD_HATYPE. MIPS: BPF: Use unsigned access for unsigned SKB fields. MIPS

[PATCH v2 2/5] MIPS: BPF: Add JIT support for SKF_AD_HATYPE.

This let's us pass some additional "modprobe test-bpf" tests with JIT enabled. Reuse the code for SKF_AD_IFINDEX, but substitute the offset and size of the "type" field. Signed-off-by: David Daney <david.da...@cavium.com> --- arch/mips/net/bpf_jit.c | 21 +++

[PATCH v2 4/5] MIPS: BPF: Quit clobbering callee saved registers in JIT code.

-off-by: David Daney <david.da...@cavium.com> --- arch/mips/net/bpf_jit.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/arch/mips/net/bpf_jit.c b/arch/mips/net/bpf_jit.c index a68cd36..44b9250 100644 --- a/arch/mips/net/bpf_jit.c +++ b/arch/mips/net/bpf

Re: [PATCH v2 0/5] MIPS: BPF: JIT fixes and improvements.

On 03/14/2017 03:29 PM, Daniel Borkmann wrote: On 03/14/2017 10:21 PM, David Daney wrote: Changes from v1: - Use unsigned access for SKF_AD_HATYPE - Added three more patches for other problems found. Testing the BPF JIT on Cavium OCTEON (mips64) with the test-bpf module identified

Re: [PATCH v2 0/5] MIPS: BPF: JIT fixes and improvements.

On 03/14/2017 05:29 PM, David Miller wrote: From: David Daney <david.da...@cavium.com> Date: Tue, 14 Mar 2017 14:21:39 -0700 Changes from v1: - Use unsigned access for SKF_AD_HATYPE - Added three more patches for other problems found. Testing the BPF JIT on Cavium OCTEON (

  1   2   3   >