From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
b/drivers/net/ether
From: David Decotigny <de...@googlers.com>
replaced by __ethtool_get_ksettings.
Signed-off-by: David Decotigny <de...@googlers.com>
---
include/linux/ethtool.h | 4
net/core/ethtool.c | 45 ++---
2 files changed, 14 insertions(+),
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
net/core/net-sysfs.c | 15 +--
net/packet/af_packet.c | 11 +--
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/net/core/net-sysfs.c b/net/core
From: David Decotigny <de...@googlers.com>
This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by
the new get_ksettings/set_ksettings callbacks. This API provides
support for most legacy ethtool_cmd fields, adds support for larger
link mode masks (up to 4064 bits, variable
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/net/bonding/bond_main.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
i
From: David Decotigny <de...@googlers.com>
Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic
way.
Tested:
unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE,
ARM.
Signed-off-by: David Decotigny <de...@googlers.com>
---
include/linux/b
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
b/drivers/infinib
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
b/drivers/infiniband/hw/usnic/usnic_ib_v
From: David Decotigny <de...@googlers.com>
This is mainly testing bitmap construction and conversion to/from u32[]
for now.
Tested:
qemu i386, x86_64, ppc, ppc64 BE and LE, ARM.
Signed-off-by: David Decotigny <de...@googlers.com>
---
lib/Kconfig.debug
From: David Decotigny <de...@googlers.com>
History:
v7
- module_exit in test_bitmap
v6
- fix copy_from_user in user/kernel handshake
v5
note: please see v4 bullets for a question regarding bitmap.c
- minor fix to make allyesconfig/allmodconfig
v4
- removed typedef for link mode b
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
include/rdma/ib_addr.h | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h
index c34c900..931a47b 100644
-
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
net/bridge/br_if.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
index c367b3e..b37a1cc 100644
--- a/net/bridge/br_if
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/scsi/fcoe/fcoe_transport.c | 36
1 file changed, 20 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe_transport.c
b/drive
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
b/drivers/infiniband/hw/usnic/usnic_ib_v
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
arch/mips/txx9/generic/setup_tx4939.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/mips/txx9/generic/setup_tx4939.c
b/arch/mips/txx9/generic/setup_tx
From: David Decotigny <de...@googlers.com>
History:
v9
- add 'link' in macro, struct and function names
- rename ethtool_link_ksettings::parent -> ::base
- remove un-needed mlx4 en_dbg_enabled() companion patch
- note: bitmap u32[] API patches were merged separately by Kan
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/net/team/team.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 00558e1..2769835 100644
--- a
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
net/core/net-sysfs.c | 15 +--
net/packet/af_packet.c | 11 +--
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/net/core/net-sysfs.c b/net/core
From: David Decotigny <de...@googlers.com>
replaced by __ethtool_get_link_ksettings.
Signed-off-by: David Decotigny <de...@googlers.com>
---
include/linux/ethtool.h | 4
net/core/ethtool.c | 45 ++---
2 files changed, 14 inser
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 357 +---
drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 +
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
net/8021q/vlan_dev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 055f0e9..e416a40 100644
--- a/net/8021
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
b/drivers/infinib
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/net/macvlan.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 426a2cc..6e953e3 100644
--- a
From: David Decotigny <de...@googlers.com>
This patch defines a new ETHTOOL_GLINKSETTINGS/SLINKSETTINGS API,
handled by the new get_link_ksettings/set_link_ksettings callbacks.
This API provides support for most legacy ethtool_cmd fields, adds
support for larger link mode masks (up to 406
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/net/bonding/bond_main.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
i
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/net/ipvlan/ipvlan_main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
i
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
b/drivers/infinib
016-02-09 at 16:29 -0800, David Decotigny wrote:
>> From: David Decotigny <de...@googlers.com>
>>
>> This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by
>> the new get_ksettings/set_ksettings callbacks. This API provides
>> support for most legac
t;b...@decadent.org.uk> wrote:
> On Fri, 2016-03-11 at 09:58 -0800, David Decotigny wrote:
> [...]
>> +static int parse_hex_u32_bitmap(const char *s,
>> + unsigned int nbits, u32 *result)
>> +{
>> + const unsigned nwords = __KERNEL_DIV_
Please note that v5 patch depends on Ben Hutchings'
http://patchwork.ozlabs.org/patch/596879/ to make any sense.
On Tue, Mar 15, 2016 at 4:42 PM, David Decotigny <ddeco...@gmail.com> wrote:
> Just sent v5 of the series: now only this patch left. Applied all your
> suggestions.
>
From: David Decotigny <de...@googlers.com>
More info with kernel commit 8d3f2806f8fb ("Merge branch
'ethtool-ksettings'").
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 681 -
internal.h
to try
AF_INET first for backward compatibility reasons, then fallback to
AF_NETLINK?
On Sun, Mar 13, 2016 at 10:24 AM, Ben Hutchings <b...@decadent.org.uk> wrote:
> On Fri, 2016-03-11 at 09:58 -0800, David Decotigny wrote:
>> From: David Decotigny <de...@googlers.com>
From: David Decotigny <de...@googlers.com>
This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also
fixes a few compilation warnings as well as a heap corruption bug.
History:
v4
review Ben Hutchings:
using AF_UNIX instead of INET6 in the absence of v4 sockets
[-Werror=format=]
ctx->devname, ring_count->data);
^
Signed-off-by: Maciej Żenczykowski <m...@google.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
internal.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/internal.h b/internal.h
in
From: David Decotigny <de...@googlers.com>
Tested:
On qemu e1000:
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 9
too much data from stdin
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 11
not enough data from stdin
$ dd if=/dev/zero bs=2 count=5
From: David Decotigny <de...@googlers.com>
This addresses:
ethtool.c:1116:8: warning: ignoring return value of ‘fread’, declared with
attribute warn_unused_result [-Wunused-result]
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 5 -
1 file changed,
From: David Decotigny <de...@googlers.com>
More info with kernel SHA1: 8d3f2806f8fbd9b22 "Merge branch
'ethtool-ksettings'".
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 682 +++--
internal.h
From: David Decotigny <de...@googlers.com>
This cover changes up to:
commit 14e2037902d65213842b4e40305ff54a64abbcb6
Author: Nicolas Dichtel <nicolas.dich...@6wind.com>
Date: Fri Mar 4 11:52:19 2016 +0100
ethtool.h: define INT_MAX for userland
Signed-off-by: David D
From: David Decotigny <de...@googlers.com>
This is required for recent version of ethtool.h .
This covers kernel.h up to:
commit b5d3755a22e0cc4c369c0985aef0c52c2477c1e7
Author: Nicolas Dichtel <nicolas.dich...@6wind.com>
Date: Fri Mar 4 11:52:16 2016 +0100
From: David Decotigny <de...@googlers.com>
The 'regs' pointer is owned by do_gregs(), but updated internally inside
dump_regs() without propagating it back to do_gregs(): later free(regs)
in do_gregs() reclaims the wrong area. This commit moves the realloc()
inside do_gregs().
Sign
ed-off-by: Maciej Żenczykowski <m...@google.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
test-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-common.c b/test-common.c
index adc3cd4..cd63d1d 100644
--- a/test-common.c
+++ b/test-common.c
@@ -10
rules [-Werror=strict-aliasing]
marvell.c:428:2: error: dereferencing type-punned pointer will break
strict-aliasing rules [-Werror=strict-aliasing]
Note: code appears endian-dependent, not fixed by this commit.
Signed-off-by: Maciej Żenczykowski <m...@google.com>
Signed-off-by: David D
com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
test-features.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-features.c b/test-features.c
index d7bd994..6ebb364 100644
--- a/test-features.c
+++ b/test-features.c
@@ -18,7 +18,7 @@ static const
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 761252f..f9336e3 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -4615,6 +4615,9
Ben Hutchings decadent.org.uk> writes:
>
> When the ETHTOOL_GLINKSETTINGS implementation finds that userland is
> using the wrong number of words of link mode bitmaps (or is trying to
> find out the right numbers) it sets the cmd field to 0 in the response
> structure.
>
> This is inconsistent
From: David Decotigny <de...@googlers.com>
This removes the requirement that ethtool be tied to the support
of a specific L3 protocol, also updates a comment.
# Patch Set Summary:
David Decotigny (2):
ethtool: minor doc update
netlin
From: David Decotigny <de...@googlers.com>
Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in
ETHTOOL_GLINKSETTINGS response to wrong nwords")
Signed-off-by: David Decotigny <de...@googlers.com>
---
include/uapi/linux/ethtool.h | 6 +++---
1 file chang
From: David Decotigny <de...@googlers.com>
This patch removes the requirement that ethtool be tied to the support
of a specific L3 protocol (ethtool uses an AF_INET socket today).
Signed-off-by: David Decotigny <de...@googlers.com>
---
net/netlink/af_netlink.c | 10 +-
1 fil
From: David Decotigny <de...@googlers.com>
History:
v7
added ref to related kernel commit in netlink ioctl patch description
v6
re-added last patch, to use AF_NETLINK when AF_INET not available
v5
rebased main patch, removed last patch "use AF_LOCAL w
From: David Decotigny <de...@googlers.com>
To benefit from this, kernel commit 025c68186e07 ("netlink: add support
for NIC driver ioctls") is needed.
Signed-off-by: David Decotigny <de...@googlers.com>
---
configure.ac | 2 +-
ethtool.c| 7 +++
2 files chang
From: David Decotigny <de...@googlers.com>
More info with kernel commit 8d3f2806f8fb ("Merge branch
'ethtool-ksettings'").
Note: The new features implemented in this patch depend on kernel
commit 793cf87de9d1 ("Set cmd field in ETHTOOL_GLINKSETTINGS response to
wrong n
From: David Decotigny <de...@googlers.com>
Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in
ETHTOOL_GLINKSETTINGS response to wrong nwords")
Signed-off-by: David Decotigny <de...@googlers.com>
---
include/uapi/linux/ethtool.h | 6 +++---
1 file chang
From: David Decotigny <de...@googlers.com>
By returning -ENOIOCTLCMD, sock_do_ioctl() falls back to calling
dev_ioctl(), which provides support for NIC driver ioctls, which
includes ethtool support. This is similar to the way ioctls are handled
in udp.c or tcp.c.
This removes the requi
From: David Decotigny <de...@googlers.com>
This removes the requirement that ethtool be tied to the support
of a specific L3 protocol, also updates a comment.
History:
v2
updated commit description for the netlink ioctl patch
v1
initial subm
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
configure.ac | 2 +-
ethtool.c| 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 3105415..47d2a0f 100644
--- a/config
From: David Decotigny <de...@googlers.com>
More info with kernel commit 8d3f2806f8fb ("Merge branch
'ethtool-ksettings'").
Note: The new features implemented in this patch depend on kernel
commit 793cf87de9d1 ("Set cmd field in ETHTOOL_GLINKSETTINGS response to
wrong n
From: David Decotigny <de...@googlers.com>
This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also
fixes a few compilation warnings as well as a heap corruption bug.
History:
v4
review Ben Hutchings:
using AF_UNIX instead of INET6 in the absence of v4 sockets
[-Werror=format=]
ctx->devname, ring_count->data);
^
Signed-off-by: Maciej Żenczykowski <m...@google.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
internal.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/internal.h b/internal.h
in
From: David Decotigny <de...@googlers.com>
More info with kernel SHA1: 8d3f2806f8fbd9b22 "Merge branch
'ethtool-ksettings'".
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 682 +++--
internal.h
com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
test-features.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-features.c b/test-features.c
index d7bd994..6ebb364 100644
--- a/test-features.c
+++ b/test-features.c
@@ -18,7 +18,7 @@ static const
From: David Decotigny <de...@googlers.com>
This is required for recent version of ethtool.h .
This covers kernel.h up to:
commit b5d3755a22e0cc4c369c0985aef0c52c2477c1e7
Author: Nicolas Dichtel <nicolas.dich...@6wind.com>
Date: Fri Mar 4 11:52:16 2016 +0100
ed-off-by: Maciej Żenczykowski <m...@google.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
test-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-common.c b/test-common.c
index adc3cd4..cd63d1d 100644
--- a/test-common.c
+++ b/test-common.c
@@ -10
From: David Decotigny <de...@googlers.com>
This cover changes up to:
commit 14e2037902d65213842b4e40305ff54a64abbcb6
Author: Nicolas Dichtel <nicolas.dich...@6wind.com>
Date: Fri Mar 4 11:52:19 2016 +0100
ethtool.h: define INT_MAX for userland
Signed-off-by: David D
From: David Decotigny <de...@googlers.com>
The 'regs' pointer is owned by do_gregs(), but updated internally inside
dump_regs() without propagating it back to do_gregs(): later free(regs)
in do_gregs() reclaims the wrong area. This commit moves the realloc()
inside do_gregs().
Sign
rules [-Werror=strict-aliasing]
marvell.c:428:2: error: dereferencing type-punned pointer will break
strict-aliasing rules [-Werror=strict-aliasing]
Note: code appears endian-dependent, not fixed by this commit.
Signed-off-by: Maciej Żenczykowski <m...@google.com>
Signed-off-by: David D
From: David Decotigny <de...@googlers.com>
This addresses:
ethtool.c:1116:8: warning: ignoring return value of ‘fread’, declared with
attribute warn_unused_result [-Wunused-result]
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 5 -
1 file changed,
From: David Decotigny <de...@googlers.com>
Tested:
On qemu e1000:
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 9
too much data from stdin
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 11
not enough data from stdin
$ dd if=/dev/zero bs=2 count=5
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 761252f..f9336e3 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -4615,6 +4615,9
From: Maciej Żenczykowski <m...@google.com>
This fixes:
test-features.c:21:1: error: missing braces around initializer
[-Werror=missing-braces]
cmd_gssetinfo = { { ETHTOOL_GSSET_INFO, 0, 1ULL << ETH_SS_FEATURES }, 34 };
^
Signed-off-by: David Decotigny <de...@googlers
From: David Decotigny <de...@googlers.com>
Tested:
On qemu e1000:
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 9
too much data from stdin
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 11
not enough data from stdin
$ dd if=/dev/zero bs=2 count=5
From: David Decotigny <de...@googlers.com>
The 'regs' pointer is owned by do_gregs(), but updated internally inside
dump_regs() without propagating it back to do_gregs(): later free(regs)
in do_gregs() reclaims the wrong area. This commit moves the realloc()
inside do_gregs().
Sign
From: David Decotigny <de...@googlers.com>
This cover changes up to:
commit 3f1ac7a700d039c61d8d8b99f28d605d489a60cf
Author: David Decotigny <de...@googlers.com>
Date: Wed Feb 24 10:57:59 2016 -0800
net: ethtool: add new ETHTOOL_xLINKSETTINGS API
Signed-off-by: Dav
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
internal.h | 8
1 file changed, 8 insertions(+)
diff --git a/internal.h b/internal.h
index 5df8124..5fd87f1 100644
--- a/internal.h
+++ b/internal.h
@@ -42,6 +42,14 @@ typ
From: David Decotigny <de...@googlers.com>
More info with kernel SHA1: 8d3f2806f8fbd9b22 "Merge branch
'ethtool-ksettings'".
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 682 +++--
internal.h
From: David Decotigny <de...@googlers.com>
This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also
fixes a few compilation warnings as well as a heap corruption bug.
History:
v2
added do_seeprom patch
added netdev@ as recipient
v1
initial subm
rules [-Werror=strict-aliasing]
marvell.c:428:2: error: dereferencing type-punned pointer will break
strict-aliasing rules [-Werror=strict-aliasing]
Note: code appears endian-dependent, not fixed by this commit.
Signed-off-by: David Decotigny <de...@googlers.com>
---
ma
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
internal.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/internal.h b/internal.h
index 5f8504d..5df8124 100644
--- a/internal.h
+++ b/internal.h
@@ -13,6 +13,
From: David Decotigny <de...@googlers.com>
This addresses:
ethtool.c:1116:8: warning: ignoring return value of ‘fread’, declared with
attribute warn_unused_result [-Wunused-result]
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 5 -
1 file changed,
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index e1acf09..4daf538 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -4618,6 +4618,9
ed-off-by: David Decotigny <de...@googlers.com>
---
test-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-common.c b/test-common.c
index adc3cd4..cd63d1d 100644
--- a/test-common.c
+++ b/test-common.c
@@ -100,7 +100,7 @@ void test_free(void *ptr)
void *test_reall
or=format=]
ctx->devname, ring_count->data);
^
Signed-off-by: David Decotigny <de...@googlers.com>
---
internal.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/internal.h b/internal.h
index b5ef646..5f8504d 100644
--- a/internal.h
+++ b/internal.h
@@ -
From: David Decotigny <de...@googlers.com>
This addresses:
ethtool.c:1116:8: warning: ignoring return value of ‘fread’, declared with
attribute warn_unused_result [-Wunused-result]
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 5 -
1 file changed,
rules [-Werror=strict-aliasing]
marvell.c:428:2: error: dereferencing type-punned pointer will break
strict-aliasing rules [-Werror=strict-aliasing]
Note: code appears endian-dependent, not fixed by this commit.
Signed-off-by: Maciej Żenczykowski <m...@google.com>
Signed-off-by: David D
com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
test-features.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-features.c b/test-features.c
index d7bd994..6ebb364 100644
--- a/test-features.c
+++ b/test-features.c
@@ -18,7 +18,7 @@ static const
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index e1acf09..4daf538 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -4618,6 +4618,9
From: David Decotigny <de...@googlers.com>
This cover changes up to:
commit 3f1ac7a700d039c61d8d8b99f28d605d489a60cf
Author: David Decotigny <de...@googlers.com>
Date: Wed Feb 24 10:57:59 2016 -0800
net: ethtool: add new ETHTOOL_xLINKSETTINGS API
Signed-off-by: Dav
From: David Decotigny <de...@googlers.com>
Tested:
On qemu e1000:
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 9
too much data from stdin
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 11
not enough data from stdin
$ dd if=/dev/zero bs=2 count=5
ed-off-by: Maciej Żenczykowski <m...@google.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
test-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-common.c b/test-common.c
index adc3cd4..cd63d1d 100644
--- a/test-common.c
+++ b/test-common.c
@@ -10
From: David Decotigny <de...@googlers.com>
The 'regs' pointer is owned by do_gregs(), but updated internally inside
dump_regs() without propagating it back to do_gregs(): later free(regs)
in do_gregs() reclaims the wrong area. This commit moves the realloc()
inside do_gregs().
Sign
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
internal.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/internal.h b/internal.h
index 5f8504d..5df8124 100644
--- a/internal.h
+++ b/internal.h
@@ -13,6 +13,
From: David Decotigny <de...@googlers.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
internal.h | 8
1 file changed, 8 insertions(+)
diff --git a/internal.h b/internal.h
index 5df8124..7c44d0e 100644
--- a/internal.h
+++ b/internal.h
@@ -42,6 +42,14 @@ typ
From: David Decotigny <de...@googlers.com>
More info with kernel SHA1: 8d3f2806f8fbd9b22 "Merge branch
'ethtool-ksettings'".
Signed-off-by: David Decotigny <de...@googlers.com>
---
ethtool.c | 682 +++--
internal.h
or=format=]
ctx->devname, ring_count->data);
^
Signed-off-by: Maciej Żenczykowski <m...@google.com>
Signed-off-by: David Decotigny <de...@googlers.com>
---
internal.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/internal.h b/internal.h
in
From: David Decotigny <de...@googlers.com>
This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also
fixes a few compilation warnings as well as a heap corruption bug.
History:
v3
TRUE/FALSE obvious-ification
v2
added do_seeprom patch
added netdev@ as recipien
From: David Decotigny <de...@googlers.com>
To benefit from this, kernel commit 025c68186e07 ("netlink: add support
for NIC driver ioctls") is needed.
Signed-off-by: David Decotigny <de...@googlers.com>
---
configure.ac | 2 +-
ethtool.c| 7 +++
2 files chang
From: David Decotigny <de...@googlers.com>
[ re-sending this series, same v7 as the one previously sent ]
History:
v7
added ref to related kernel commit in netlink ioctl patch description
v6
re-added last patch, to use AF_NETLINK when AF_INET not available
v5
rebased main
From: David Decotigny <de...@googlers.com>
More info with kernel commit 8d3f2806f8fb ("Merge branch
'ethtool-ksettings'").
Note: The new features implemented in this patch depend on kernel
commit 793cf87de9d1 ("Set cmd field in ETHTOOL_GLINKSETTINGS response to
wrong n
From: David Decotigny <de...@googlers.com>
To benefit from this, kernel commit 025c68186e07 ("netlink: add support
for NIC driver ioctls") is needed.
Signed-off-by: David Decotigny <de...@googlers.com>
---
configure.ac | 2 +-
ethtool.c| 7 +++
2 files chang
From: David Decotigny <de...@googlers.com>
More info with kernel commit 8d3f2806f8fb ("Merge branch
'ethtool-ksettings'").
Note: The new features implemented in this patch depend on kernel
commit 793cf87de9d1 ("Set cmd field in ETHTOOL_GLINKSETTINGS response to
wrong n
From: David Decotigny <de...@googlers.com>
[ this is a plain re-post, same v7 as the ones previously sent ]
History:
v7
added ref to related kernel commit in netlink ioctl patch description
v6
re-added last patch, to use AF_NETLINK when AF_INET not available
v5
rebase
101 - 200 of 210 matches
Mail list logo
