Re: [PATCH v2 1/3] net: core: ethtool: add ethtool_op_{get|set}_link_ksettings

Are you sure this belongs to ethtool.h? For one, I believe you need an #include phy.h somewhere. I would suggest instead to keep this in phy.h, presumably with a more explicit name suggesting that phydev is involved. On Sun, May 8, 2016 at 2:44 PM, Philippe Reynes wrote: >

[ethtool PATCH v7 2/2] ethtool: use netlink socket when AF_INET not available

From: David Decotigny <de...@googlers.com> To benefit from this, kernel commit 025c68186e07 ("netlink: add support for NIC driver ioctls") is needed. Signed-off-by: David Decotigny <de...@googlers.com> --- configure.ac | 2 +- ethtool.c| 7 +++ 2 files chang

[ethtool PATCH v7 1/2] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

From: David Decotigny <de...@googlers.com> More info with kernel commit 8d3f2806f8fb ("Merge branch 'ethtool-ksettings'"). Note: The new features implemented in this patch depend on kernel commit 793cf87de9d1 ("Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong n

[ethtool PATCH v7 0/2] add support for new ETHTOOL_xLINKSETTINGS ioctls

From: David Decotigny <de...@googlers.com> [ this is a plain re-post, same v7 as the ones previously sent ] History: v7 added ref to related kernel commit in netlink ioctl patch description v6 re-added last patch, to use AF_NETLINK when AF_INET not available v5 rebase

Re: [PATCH v3 1/3] net: phy: add phy_ethtool_{get|set}_link_ksettings

ttings(struct net_device *ndev, > + const struct ethtool_link_ksettings *cmd); > > int __init mdio_bus_init(void); > void mdio_bus_exit(void); > -- > 1.7.4.4 > Acked-By: David Decotigny <de...@googlers.com>

[PATCH v1] mlx4: remove unused fields

From: David Decotigny <de...@googlers.com> This also can address following UBSAN warnings: [ 36.640343] [ 36.648772] UBSAN: Undefined behaviour in drivers/net/ethernet/mellanox/mlx4/fw.c:857:26 [ 36.

Re: [ethtool PATCH v4 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

f-by: Vidya Sagar Ravipati <vi...@cumulusnetworks.com> > Acked-By: David Decotigny <de...@googlers.com> > --- > ethtool.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/ethtool.c b/ethtool.c > index 1d6564e..ab58c7f 100644 > --

[PATCH iproute2 v1 2/2] iproute2: a non-expected rtnl message is an error

--- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index dae793b..10d0afe 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -320,7 +320,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) if

[PATCH iproute2 v1 1/2] iproute2: avoid exit in case of error.

Be consistent with how non-0 print_route() return values are handled elesewhere: return -1. --- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index 98bfad6..dae793b 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -1743,7 +1743,7 @@

Re: [PATCH net] ethtool: do not print warning for applications using legacy API

Signed-off-by: David Decotigny <de...@googlers.com> On Fri, Dec 29, 2017 at 10:02 AM, Stephen Hemminger <step...@networkplumber.org> wrote: > From: Stephen Hemminger <step...@networkplumber.org> > > In kernel log ths message appears on every boot: > "war

<    1   2   3