Re: [PATCH net] net: phylink: ensure inband AN works correctly

2019-05-21 Thread David Miller
From: Russell King Date: Mon, 20 May 2019 16:07:20 +0100 > Do not update the link interface mode while the link is down to avoid > spurious link interface changes. > > Always call mac_config if we have a PHY to propagate the pause mode > settings to the MAC. > > Signed-off-by: Russell King Ap

Re: [PATCH net] ipv6: Consider sk_bound_dev_if when binding a raw socket to an address

2019-05-21 Thread David Miller
From: Mike Manning Date: Mon, 20 May 2019 19:57:17 +0100 > IPv6 does not consider if the socket is bound to a device when binding > to an address. The result is that a socket can be bound to eth0 and > then bound to the address of eth1. If the device is a VRF, the result > is that a socket can on

Re: [PATCH net-next] cxgb4: Revert "cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size"

2019-05-21 Thread David Miller
From: Vishal Kulkarni Date: Tue, 21 May 2019 09:12:02 +0530 > This reverts commit 2391b0030e241386d710df10e53e2cfc3c5d4fc1 > SGE's BAR2 Doorbell/GTS Page Size is now interpreted correctly in the > firmware itself by using actual host page size. Hence previous commit > needs to be reverted. > > S

Re: [PATCH net-next] cxgb4: Enable hash filter with offload

2019-05-21 Thread David Miller
From: Vishal Kulkarni Date: Tue, 21 May 2019 09:10:37 +0530 > This patch enables hash filter along with offload > > Signed-off-by: Vishal Kulkarni This commit message is too terse. What is going on here. Why does this change need to made? Why did you implement it this way? Is this a bug fi

Re: [PATCH net] selftests: fib_rule_tests: use pre-defined DEV_ADDR

2019-05-21 Thread David Miller
From: Hangbin Liu Date: Tue, 21 May 2019 14:40:47 +0800 > DEV_ADDR is defined but not used. Use it in address setting. > Do the same with IPv6 for consistency. > > Reported-by: David Ahern > Fixes: fc82d93e57e3 ("selftests: fib_rule_tests: fix local IPv4 address typo") > Signed-off-by: Hangbin

Re: LPC networking track?

2019-05-22 Thread David Miller
From: Jesse Brandeburg Date: Wed, 22 May 2019 09:36:44 -0700 > Hi, is there any update on the plan for the networking track at > Plumbers (LPC) in Lisbon this year? Last year there was a CFP, but if > there was one this year I can't find any mention or details. We are assembling the tech commit

Re: [PATCH net-next 0/4] phylink/sfp updates

2019-05-22 Thread David Miller
From: Russell King - ARM Linux admin Date: Mon, 20 May 2019 16:21:34 +0100 > I realise that net-next probably isn't open yet, but I believe folk > will find these patches "interesting" so I'm sending them to share > them with people working on this code, rather than expecting them to > be picked

Re: [PATCH net v2] Validate required parameters in inet6_validate_link_af

2019-05-22 Thread David Miller
From: Maxim Mikityanskiy Date: Tue, 21 May 2019 06:40:04 + > inet6_set_link_af requires that at least one of IFLA_INET6_TOKEN or > IFLA_INET6_ADDR_GET_MODE is passed. If none of them is passed, it > returns -EINVAL, which may cause do_setlink() to fail in the middle of > processing other comm

Re: [PATCH net] ocelot: Dont allocate another multicast list, use __dev_mc_sync

2019-05-22 Thread David Miller
From: Claudiu Manoil Date: Tue, 21 May 2019 19:52:55 +0300 > Doing kmalloc in atomic context is always an issue, > more so for a list that can grow significantly. > Turns out that the driver only uses the duplicated > list of multicast mac addresses to keep track of > what addresses to delete fro

Re: [PATCH net] mISDN: Fix indenting in dsp_cmx.c

2019-05-22 Thread David Miller
From: Dan Carpenter Date: Tue, 21 May 2019 12:42:56 +0300 > We used a script to indent this code back in 2012, but I guess it got > confused by the ifdefs and added some extra tabs. This patch removes > them. > > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH net v2 0/3] Documentation: tls: add offload documentation

2019-05-22 Thread David Miller
From: Jakub Kicinski Date: Tue, 21 May 2019 18:57:11 -0700 > This set adds documentation for TLS offload. It starts > by making the networking documentation a little easier > to navigate by hiding driver docs a little deeper. > It then RSTifys the existing Kernel TLS documentation. > Last but not

Re: [PATCH net 0/3] net/tls: fix device surprise removal with offload

2019-05-22 Thread David Miller
From: Jakub Kicinski Date: Tue, 21 May 2019 19:01:59 -0700 > This series fixes two issues with device surprise removal. > First we need to take a read lock around resync, otherwise > netdev notifier handler may clear the structures from under > our feet. > > Secondly we need to be careful about

Re: [PATCH] mISDN: make sure device name is NUL terminated

2019-05-22 Thread David Miller
From: Dan Carpenter Date: Wed, 22 May 2019 11:45:13 +0300 > The user can change the device_name with the IMSETDEVNAME ioctl, but we > need to ensure that the user's name is NUL terminated. Otherwise it > could result in a buffer overflow when we copy the name back to the user > with IMGETDEVINFO

Re: [PATCH] net: fec: remove redundant ipg clock disable

2019-05-22 Thread David Miller
From: Baruch Siach Date: Wed, 22 May 2019 16:56:15 +0300 > Don't disable the ipg clock in the regulator error path. The clock is > disable unconditionally two lines below the failed_regulator label. > > Signed-off-by: Baruch Siach Applied to net-next.

Re: [PATCH net-next v2] cxgb4: Enable hash filter with offload

2019-05-22 Thread David Miller
From: Vishal Kulkarni Date: Wed, 22 May 2019 21:46:12 +0530 > Hash (exact-match) filters used for offloading flows share the > same active region resources on the chip with upper layer drivers, > like iw_cxgb4, chcr, etc. Currently, only either Hash filters > or ULDs can use the active region res

Re: [PATCH net-next v2 5/8] net: phy: dp83867: Use unsigned variables to store unsigned properties

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:24 + > The variables used to store u32 DT properties were signed ints. This > doesn't work properly if the value of the property were to overflow. > Use unsigned variables so this doesn't happen. > > Cc: Andrew Lunn > Cc: Florian Fainelli >

Re: [PATCH net-next v2 6/8] net: phy: dp83867: IO impedance is not dependent on RGMII delay

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:25 + > The driver would only set the IO impedance value when RGMII internal > delays were enabled. There is no reason for this. Move the IO > impedance block out of the RGMII delay block. > > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Hei

Re: [PATCH net-next v2 4/8] net: phy: dp83867: Rework delay rgmii delay handling

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:23 + > The code was assuming the reset default of the delay control register > was to have delay disabled. This is what the datasheet shows as the > register's initial value. However, that's not actually true: the > default is controlled by th

Re: [PATCH net-next v2 1/8] dt-bindings: phy: dp83867: Describe how driver behaves w.r.t rgmii delay

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:19 + > Add a note to make it more clear how the driver behaves when "rgmii" vs > "rgmii-id", "rgmii-idrx", or "rgmii-idtx" interface modes are selected. > > Cc: Rob Herring > Cc: Mark Rutland > Signed-off-by: Trent Piepho Applied.

Re: [PATCH net-next v2 7/8] net: phy: dp83867: Validate FIFO depth property

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:26 + > Insure property is in valid range and fail when reading DT if it is not. > Also add error message for existing failure if required property is not > present. > > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Heiner Kallweit > Signed-of

Re: [PATCH net-next v2 8/8] net: phy: dp83867: Allocate state struct in probe

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:27 + > This was being done in config the first time the phy was configured. > Should be in the probe method. > > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Heiner Kallweit > Signed-off-by: Trent Piepho Applied.

Re: [PATCH net-next v2 3/8] net: phy: dp83867: Add ability to disable output clock

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:22 + > Generally, the output clock pin is only used for testing and only serves > as a source of RF noise after this. It could be used to daisy-chain > PHYs, but this is uncommon. Since the PHY can disable the output, make > doing so an option

Re: [PATCH net-next v2 2/8] dt-bindings: phy: dp83867: Add documentation for disabling clock output

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:21 + > The clock output is generally only used for testing and development and > not used to daisy-chain PHYs. It's just a source of RF noise afterward. > > Add a mux value for "off". I've added it as another enumeration to the > output prope

Re: [PATCH net-next 0/2] net: phy: T1 support

2019-05-22 Thread David Miller
From: Andrew Lunn Date: Wed, 22 May 2019 20:47:02 +0200 > T1 PHYs make use of a single twisted pair, rather than the traditional > 2 pair for 100BaseT or 4 pair for 1000BaseT. This patchset adds link > modes for 100BaseT1 and 1000BaseT1, and them makes use of 100BaseT1 in > the list of PHY featur

Re: [PATCH v2 net-next 0/8] net: Export functions for nexthop code

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:04:38 -0700 > From: David Ahern > > This set exports ipv4 and ipv6 fib functions for use by the nexthop > code. It also adds new ones to send route notifications if a nexthop > configuration changes. > > v2 > - repost of patches dropped at the end of

Re: [PATCH net-next] selftests: fib-onlink: Make quiet by default

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:09:16 -0700 > From: David Ahern > > Add VERBOSE argument to fib-onlink-tests.sh and make output quiet by > default. Add getopt parsing of inputs and support for -v (verbose) and > -p (pause on fail). > > Signed-off-by: David Ahern Applied.

Re: [PATCH net-next] net: Set strict_start_type for routes and rules

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:07:43 -0700 > From: David Ahern > > New userspace on an older kernel can send unknown and unsupported > attributes resulting in an incompelete config which is almost > always wrong for routing (few exceptions are passthrough settings > like the protoc

Re: [PATCH net-next] neighbor: Add tracepoint to __neigh_create

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:22:21 -0700 > From: David Ahern > > Add tracepoint to __neigh_create to enable debugging of new entries. > > Signed-off-by: David Ahern Applied.

Re: [PATCH net-next] selftests: pmtu: Simplify cleanup and namespace names

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:11:06 -0700 > From: David Ahern > > The point of the pause-on-fail argument is to leave the setup as is after > a test fails to allow a user to debug why it failed. Move the cleanup > after posting the result to the user to make it so. > > Random nam

Re: [PATCH net] ipv6: Fix redirect with VRF

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 15:12:18 -0700 > From: David Ahern > > IPv6 redirect is broken for VRF. __ip6_route_redirect walks the FIB > entries looking for an exact match on ifindex. With VRF the flowi6_oif > is updated by l3mdev_update_flow to the l3mdev index and the > FLOWI_FLA

Re: [PATCH net-next] ipv4/igmp: shrink struct ip_sf_list

2019-05-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 May 2019 15:00:25 -0700 > Removing two 4 bytes holes allows to use kmalloc-32 > kmem cache instead of kmalloc-64 on 64bit kernels. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net 0/4] bnxt_en: Bug fixes.

2019-05-22 Thread David Miller
From: Michael Chan Date: Wed, 22 May 2019 19:12:53 -0400 > There are 4 driver fixes in this series: > > 1. Fix RX buffer leak during OOM condition. > 2. Call pci_disable_msix() under correct conditions to prevent hitting BUG. > 3. Reduce unneeded mmeory allocation in kdump kernel to prevent OOM.

Re: [PATCH net] ipv4/igmp: fix another memory leak in igmpv3_del_delrec()

2019-05-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 May 2019 16:51:22 -0700 > syzbot reported memory leaks [1] that I have back tracked to > a missing cleanup from igmpv3_del_delrec() when > (im->sfmode != MCAST_INCLUDE) > > Add ip_sf_list_clear_all() and kfree_pmc() helpers to explicitely > handle the cleanups be

Re: [PATCH net] ipv4/igmp: fix build error if !CONFIG_IP_MULTICAST

2019-05-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 May 2019 18:35:16 -0700 > ip_sf_list_clear_all() needs to be defined even if !CONFIG_IP_MULTICAST > > Fixes: 3580d04aa674 ("ipv4/igmp: fix another memory leak in > igmpv3_del_delrec()") > Signed-off-by: Eric Dumazet > Reported-by: kbuild test robot Applied, t

Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs

2019-05-23 Thread David Miller
From: Andreas Steinmetz Date: Thu, 23 May 2019 09:46:15 +0200 > MACsec causes oopses followed by a kernel panic when attached directly or > indirectly to a bridge. It causes erroneous > checksum messages when attached to vxlan. When I did investigate I did find > skb leaks, apparent skb mis-han

Re: [patch net-next v2] devlink: add warning in case driver does not set port type

2019-05-23 Thread David Miller
From: Jiri Pirko Date: Thu, 23 May 2019 10:43:35 +0200 > From: Jiri Pirko > > Prevent misbehavior of drivers who would not set port type for longer > period of time. Drivers should always set port type. Do WARN if that > happens. > > Note that it is perfectly fine to temporarily not have the t

Re: [PATCH net-next] cxgb4: use firmware API for validating filter spec

2019-05-23 Thread David Miller
From: Raju Rangoju Date: Thu, 23 May 2019 19:21:21 +0530 > Adds support for validating hardware filter spec configured in firmware > before offloading exact match flows. > > Use the new fw api FW_PARAM_DEV_FILTER_MODE_MASK to read the filter mode > and mask from firmware. If the api isn't suppor

Re: [PATCH net-next] Revert "dpaa2-eth: configure the cache stashing amount on a queue"

2019-05-23 Thread David Miller
From: Ioana Radulescu Date: Thu, 23 May 2019 17:38:22 +0300 > This reverts commit f8b995853444aba9c16c1ccdccdd397527fde96d. > > The reverted change instructed the QMan hardware block to fetch > RX frame annotation and beginning of frame data to cache before > the core would read them. > > It tu

Re: [PATCH net] cxgb4: offload VLAN flows regardless of VLAN ethtype

2019-05-23 Thread David Miller
From: Raju Rangoju Date: Thu, 23 May 2019 20:41:44 +0530 > VLAN flows never get offloaded unless ivlan_vld is set in filter spec. > It's not compulsory for vlan_ethtype to be set. > > So, always enable ivlan_vld bit for offloading VLAN flows regardless of > vlan_ethtype is set or not. > > Fixes

Re: [PATCH net-next] net: qualcomm: rmnet: Move common struct definitions to include

2019-05-23 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Wed, 22 May 2019 14:21:07 -0600 > Create if_rmnet.h and move the rmnet MAP packet structs to this > common include file. To account for portablity, add little and > big endian bitfield definitions similar to the ip & tcp headers. > > The definitions in

Re: [PATCH net-next 0/6] add TFO backup key

2019-05-23 Thread David Miller
From: Jason Baron Date: Wed, 22 May 2019 16:39:32 -0400 > Christoph, Igor, and I have worked on an API that facilitates TFO key > rotation. This is a follow up to the series that Christoph previously > posted, with an API that meets both of our use-cases. Here's a > link to the previous work: >

Re: [PATCH 00/11] Netfilter/IPVS fixes for net

2019-05-23 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 23 May 2019 23:35:36 +0200 > The following patchset contains Netfilter/IPVS fixes for your net tree: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks.

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-05-23

2019-05-23 Thread David Miller
From: Jeff Kirsher Date: Thu, 23 May 2019 15:33:25 -0700 > This series contains updates to ice driver only. ... > The following are changes since commit > 16fa1cf1ed2a652a483cf8f1ea65c703693292e8: > Revert "dpaa2-eth: configure the cache stashing amount on a queue" > and are available in the

Re: [PATCH net,stable 1/1] net: fec: add defer probe for of_get_mac_address

2019-05-24 Thread David Miller
From: Andy Duan Date: Thu, 23 May 2019 01:55:23 + > @@ -3146,7 +3150,10 @@ static int fec_enet_init(struct net_device *ndev) > memset(cbd_base, 0, bd_size); > > /* Get the Ethernet address */ > - fec_get_mac(ndev); > + ret = fec_get_mac(ndev); > + if (ret) > +

Re: [PATCH net,stable 1/1] net: fec: fix the clk mismatch in failed_reset path

2019-05-24 Thread David Miller
From: Andy Duan Date: Thu, 23 May 2019 01:55:28 + > Fix the clk mismatch in the error path "failed_reset" because > below error path will disable clk_ahb and clk_ipg directly, it > should use pm_runtime_put_noidle() instead of pm_runtime_put() > to avoid to call runtime resume callback. > >

Re: [PATCH net] cxgb4: Revert "cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size"

2019-05-24 Thread David Miller
From: Vishal Kulkarni Date: Thu, 23 May 2019 08:07:21 +0530 > This reverts commit 2391b0030e241386d710df10e53e2cfc3c5d4fc1 which has > introduced regression. Now SGE's BAR2 Doorbell/GTS Page Size is > interpreted correctly in the firmware itself by using actual host > page size. Hence previous co

Re: [PATCH net-next 0/7] ipv6: Move exceptions to fib6_nh and make it optional in a fib6_info

2019-05-24 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 20:27:54 -0700 > From: David Ahern > > Patches 1 and 4 move pcpu and exception caches from fib6_info to fib6_nh. > With respect to the current FIB entries this is only a movement from one > struct to another contained within the first. > > Patch 2 refac

Re: [PATCH net] net: sched: don't use tc_action->order during action dump

2019-05-24 Thread David Miller
From: Vlad Buslov Date: Thu, 23 May 2019 09:32:31 +0300 > Function tcf_action_dump() relies on tc_action->order field when starting > nested nla to send action data to userspace. This approach breaks in > several cases: > > - When multiple filters point to same shared action, tc_action->order fi

Re: [PATCH net-next v2] selftests/net: SO_TXTIME with ETF and FQ

2019-05-24 Thread David Miller
From: Willem de Bruijn Date: Thu, 23 May 2019 13:48:46 -0400 > From: Willem de Bruijn > > The SO_TXTIME API enables packet tranmission with delayed delivery. > This is currently supported by the ETF and FQ packet schedulers. > > Evaluate the interface with both schedulers. Install the schedule

Re: [PATCH net-next v2 0/3] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII

2019-05-24 Thread David Miller
From: Heiner Kallweit Date: Thu, 23 May 2019 20:06:10 +0200 > Add support for interface mode USXGMII. > > On Freescale boards LS1043A and LS1046A a warning may pop up now > because mode xgmii should be changed to usxgmii (as the used > Aquantia PHY doesn't support XGMII). Series applied.

Re: [PATCH net-next] udp: Avoid post-GRO UDP checksum recalculation

2019-05-25 Thread David Miller
From: Sean Tranchetti Date: Thu, 23 May 2019 13:36:17 -0600 > @@ -472,11 +472,15 @@ static inline struct sk_buff *udp_rcv_segment(struct > sock *sk, > struct sk_buff *skb, bool ipv4) > { > struct sk_buff *segs; > + netdev_features_t features

Re: [PATCH net 0/3] dpaa2-eth: Fix smatch warnings

2019-05-26 Thread David Miller
From: Ioana Radulescu Date: Fri, 24 May 2019 18:15:14 +0300 > Fix a couple of warnings reported by smatch. Series applied.

Re: [PATCH net-next 00/11] inet: frags: avoid possible races at netns dismantle

2019-05-26 Thread David Miller
From: Eric Dumazet Date: Fri, 24 May 2019 09:03:29 -0700 > This patch series fixes a race happening on netns dismantle with > frag queues. While rhashtable_free_and_destroy() is running, > concurrent timers might run inet_frag_kill() and attempt > rhashtable_remove_fast() calls. This is not allow

Re: [PATCH v3 2/2] net: core: support XDP generic on stacked devices.

2019-05-26 Thread David Miller
From: Stephen Hemminger Date: Thu, 23 May 2019 10:54:29 -0700 > @@ -4858,6 +4841,17 @@ static int __netif_receive_skb_core(struct sk_buff > *skb, bool pfmemalloc, > > __this_cpu_inc(softnet_data.processed); > > + if (static_branch_unlikely(&generic_xdp_needed_key)) { > +

Re: [PATCH net 0/4] net/tls: two fixes for rx_list pre-handling

2019-05-26 Thread David Miller
From: Jakub Kicinski Date: Fri, 24 May 2019 10:34:29 -0700 > tls_sw_recvmsg() had been modified to cater better to async decrypt. > Partially read records now live on the rx_list. Data is copied from > this list before the old do {} while loop, and the not included > correctly in deciding whether

Re: [PATCH net-next] net: phy: bcm87xx: improve bcm87xx_config_init and feature detection

2019-05-26 Thread David Miller
From: Heiner Kallweit Date: Fri, 24 May 2019 22:24:19 +0200 > PHY drivers don't have to and shouldn't fiddle with phylib internals. > Most of the code in bcm87xx_config_init() can be removed because > phylib takes care. > > In addition I replaced usage of PHY_10GBIT_FEC_FEATURES with an > implem

Re: [PATCH net-next] selftest: Fixes for icmp_redirect test

2019-05-26 Thread David Miller
From: David Ahern Date: Fri, 24 May 2019 16:37:07 -0700 > From: David Ahern > > I was really surprised that the IPv6 mtu exception followed by redirect > test was passing as nothing about the code suggests it should. The problem > is actually with the logic in the test script. > > Fix the test

Re: [PATCH net 1/4] net: aquantia: tx clean budget logic error

2019-05-26 Thread David Miller
From: Igor Russkikh Date: Sat, 25 May 2019 09:57:59 + > In case no other traffic happening on the ring, full tx cleanup > may not be completed. That may cause socket buffer to overflow > and tx traffic to stuck until next activity on the ring happens. > > This is due to logic error in budget

Re: [PATCH net-next 0/3] r8169: small improvements

2019-05-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 25 May 2019 20:42:30 +0200 > Series with small improvements. Series applied, thanks.

Re: [PATCH net-next] r8169: remove support for RTL_GIGA_MAC_VER_01

2019-05-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 25 May 2019 21:14:39 +0200 > RTL_GIGA_MAC_VER_01 is RTL8169, the ancestor of the chip family. > It didn't have an internal PHY and I've never seen it in the wild. > What isn't there doesn't need to be maintained, so let's remove > support for it. > > Signed-off-b

Re: [PATCH net-next] r8169: improve RTL8168d PHY initialization

2019-05-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 25 May 2019 20:57:42 +0200 > Certain parts of the PHY initialization are the same for sub versions > 1 and 2 of RTL8168d. So let's factor this out to simplify the code. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next] team: add ethtool get_link_ksettings

2019-05-27 Thread David Miller
From: Hangbin Liu Date: Mon, 27 May 2019 11:31:10 +0800 > Like bond, add ethtool get_link_ksettings to show the total speed. > > Signed-off-by: Hangbin Liu Yeah, this mirrors what bonding does. Jiri, please review.

Re: [PATCH] enetc: fix le32/le16 degrading to integer warnings

2019-05-27 Thread David Miller
From: "Y.b. Lu" Date: Mon, 27 May 2019 03:55:20 + > Fix blow sparse warning introduced by a previous patch. > - restricted __le32 degrades to integer > - restricted __le16 degrades to integer > > Fixes: d39823121911 ("enetc: add hardware timestamping support") > Signed-off-by: Yangbo Lu Ap

Re: [PATCH net 1/4] net: aquantia: tx clean budget logic error

2019-05-27 Thread David Miller
From: Igor Russkikh Date: Mon, 27 May 2019 09:57:18 + > This is not about introducing tx clean budget, but about fixing a bug. > > tx clean budget logic is present in majority of the drivers as I see, > including igb,ixgbe,mlx5. > > I see it as a logical action to limit the time driver spen

Re: [PATCH net-next 0/4] ipv6: Update RFC references and implement ICMP errors for limits

2019-05-28 Thread David Miller
Any time you say "Do A and B" it means that your patch set is doing two different things and should be split up properly into two separate submissions.

Re: [PATCH] net: stmmac: Do not output error on deferred probe

2019-05-28 Thread David Miller
From: Thierry Reding Date: Mon, 27 May 2019 12:52:51 +0200 > From: Thierry Reding > > If the subdriver defers probe, do not show an error message. It's > perfectly fine for this error to occur since the driver will get another > chance to probe after some time and will usually succeed after all

Re: [PATCH net-next] enetc: Enable TC offloading with mqprio

2019-05-28 Thread David Miller
From: Claudiu Manoil Date: Mon, 27 May 2019 18:21:31 +0300 > From: Camelia Groza > > Add support to configure multiple prioritized TX traffic > classes with mqprio. > > Configure one BD ring per TC for the moment, one netdev > queue per TC. > > Signed-off-by: Camelia Groza > Signed-off-by: C

Re: [PATCH net] selftests: pmtu: Fix encapsulating device in pmtu_vti6_link_change_mtu

2019-05-28 Thread David Miller
From: Stefano Brivio Date: Mon, 27 May 2019 19:42:23 +0200 > In the pmtu_vti6_link_change_mtu test, both local and remote addresses > for the vti6 tunnel are assigned to the same address given to the dummy > interface that we use as encapsulating device with a known MTU. > > This works as long a

Re: [PATCH net-next] selftests/net: ipv6 flowlabel

2019-05-28 Thread David Miller
From: Willem de Bruijn Date: Mon, 27 May 2019 16:47:51 -0400 > From: Willem de Bruijn > > Test the IPv6 flowlabel control and datapath interfaces: > > Acquire and release the right to use flowlabels with socket option > IPV6_FLOWLABEL_MGR. > > Then configure flowlabels on send and read them o

Re: [PATCH net-next 0/3] inet: frags: followup to 'inet-frags-avoid-possible-races-at-netns-dismantle'

2019-05-28 Thread David Miller
From: Eric Dumazet Date: Mon, 27 May 2019 16:56:46 -0700 > Latest patch series ('inet-frags-avoid-possible-races-at-netns-dismantle') > brought another syzbot report shown in the third patch changelog. > > While fixing the issue, I had to call inet_frags_fini() later > in IPv6 and ilowpan. > >

Re: [PATCH net] llc: fix skb leak in llc_build_and_send_ui_pkt()

2019-05-28 Thread David Miller
From: Eric Dumazet Date: Mon, 27 May 2019 17:35:52 -0700 > If llc_mac_hdr_init() returns an error, we must drop the skb > since no llc_build_and_send_ui_pkt() caller will take care of this. ... > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Eric Dumazet > Reported-by: syzbot Appl

Re: [PATCH net-next 0/6] net: API and initial implementation for nexthop objects

2019-05-28 Thread David Miller
From: David Ahern Date: Fri, 24 May 2019 14:43:02 -0700 > From: David Ahern > > This set contains the API and initial implementation for nexthops as > standalone objects. > > Patch 1 contains the UAPI and updates to selinux struct. > > Patch 2 contains the barebones code for nexthop commands,

Re: [net-next 00/10][pull request] 1GbE Intel Wired LAN Driver Updates 2019-05-28

2019-05-28 Thread David Miller
From: Jeff Kirsher Date: Tue, 28 May 2019 17:17:16 -0700 > This series contains updates to e1000e, igb and igc. Pulled, thanks Jeff.

Re: [PATCH net-next 0/2] qed*: Fix inifinite spinning of PTP poll thread.

2019-05-29 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Mon, 27 May 2019 20:21:31 -0700 > The patch series addresses an error scenario in the PTP Tx implementation. > > Please consider applying it to net-next. Series applied.

Re: [PATCH net-next] macvlan: Replace strncpy() by strscpy()

2019-05-29 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 27 May 2019 13:38:55 -0500 > The strncpy() function is being deprecated. Replace it by the safer > strscpy() and fix the following Coverity warning: > > "Calling strncpy with a maximum size argument of 16 bytes on destination > array ifrr.ifr_ifrn.ifrn_name

Re: [PATCH] rhashtable: Add rht_ptr_rcu and improve rht_ptr

2019-05-29 Thread David Miller
From: Herbert Xu Date: Tue, 28 May 2019 15:02:31 +0800 > This patch moves common code between rht_ptr and rht_ptr_exclusive > into __rht_ptr. It also adds a new helper rht_ptr_rcu exclusively > for the RCU case. This way rht_ptr becomes a lock-only construct > so we can use the lighter rcu_dere

Re: [PATCH net-next 2/5] net: phylink: support for link gpio interrupt

2019-05-29 Thread David Miller
From: Russell King - ARM Linux admin Date: Tue, 28 May 2019 11:02:49 +0100 > I was intending to add a note to this patch indicating that it > depends on "net: phylink: ensure consistent phy interface mode" but > failed to do before sending it out - sorry! If you'd prefer a patch > that doesn't d

Re: [PATCH] net: phy: marvell10g: report if the PHY fails to boot firmware

2019-05-29 Thread David Miller
From: Russell King Date: Tue, 28 May 2019 10:34:42 +0100 > Some boards do not have the PHY firmware programmed in the 3310's flash, > which leads to the PHY not working as expected. Warn the user when the > PHY fails to boot the firmware and refuse to initialise. > > Signed-off-by: Russell King

Re: [PATCH v3 0/4] net: phy: dp83867: add some fixes

2019-05-29 Thread David Miller
From: Max Uvarov Date: Tue, 28 May 2019 13:00:48 +0300 > v3: use phy_modify_mmd() > v2: fix minor comments by Heiner Kallweit and Florian Fainelli Series applied, thank you.

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-05-29

2019-05-29 Thread David Miller
From: Jeff Kirsher Date: Wed, 29 May 2019 11:47:39 -0700 > This series contains updates to ice driver only. Pulled, thanks Jeff.

Re: [PATCH net-next] r8169: remove 1000/Half from supported modes

2019-05-29 Thread David Miller
From: Heiner Kallweit Date: Tue, 28 May 2019 18:43:46 +0200 > MAC on the GBit versions supports 1000/Full only, however the PHY > partially claims to support 1000/Half. So let's explicitly remove > this mode. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next v6] net: sched: Introduce act_ctinfo action

2019-05-29 Thread David Miller
From: Kevin 'ldir' Darbyshire-Bryant Date: Tue, 28 May 2019 17:03:50 + > ctinfo is a new tc filter action module. It is designed to restore > information contained in firewall conntrack marks to other packet fields > and is typically used on packet ingress paths. At present it has two > ind

Re: [PATCH v2 net-next 00/11] Decoupling PHYLINK from struct net_device

2019-05-29 Thread David Miller
From: Ioana Ciornei Date: Tue, 28 May 2019 20:38:06 +0300 > Following two separate discussion threads in: > https://www.spinics.net/lists/netdev/msg569087.html > and: > https://www.spinics.net/lists/netdev/msg570450.html > > Previous RFC patch set: https://www.spinics.net/lists/netdev/msg571

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-30 Thread David Miller
From: Alexei Starovoitov Date: Thu, 30 May 2019 08:18:10 -0700 > On Thu, May 30, 2019 at 8:16 AM David Ahern wrote: >> >> On 5/30/19 9:06 AM, Alexei Starovoitov wrote: >> > Huge number of core changes and zero tests. >> >> As mentioned in a past response, there are a number of tests under >> sel

Re: [PATCH net-next v2] udp: Avoid post-GRO UDP checksum recalculation

2019-05-30 Thread David Miller
From: Sean Tranchetti Date: Tue, 28 May 2019 12:22:54 -0600 > Currently, when resegmenting an unexpected UDP GRO packet, the full UDP > checksum will be calculated for every new SKB created by skb_segment() > because the netdev features passed in by udp_rcv_segment() lack any > information about

Re: [PATCH PATCH v4 0/2] XDP generic fixes

2019-05-30 Thread David Miller
From: Stephen Hemminger Date: Tue, 28 May 2019 11:47:29 -0700 > This set of patches came about while investigating XDP > generic on Azure. The split brain nature of the accelerated > networking exposed issues with the stack device model. Series applied.

Re: [pull request][net 0/6] Mellanox, mlx5 fixes 2019-05-28

2019-05-30 Thread David Miller
From: Saeed Mahameed Date: Wed, 29 May 2019 02:07:57 + > This series introduces some fixes to mlx5 driver. > > Please pull and let me know if there is any problem. Pulled. > For -stable v4.13: > ('net/mlx5: Allocate root ns memory using kzalloc to match kfree') > > For -stable v4.16: > ('

Re: [PATCH] inet: frags: Remove unnecessary smp_store_release/READ_ONCE

2019-05-30 Thread David Miller
From: Herbert Xu Date: Wed, 29 May 2019 13:40:26 +0800 > The smp_store_release call in fqdir_exit cannot protect the setting > of fqdir->dead as claimed because its memory barrier is only > guaranteed to be one-way and the barrier precedes the setting of > fqdir->dead. > > IOW it doesn't provide

Re: [PATCH net] r8169: fix MAC address being lost in PCI D3

2019-05-30 Thread David Miller
From: Heiner Kallweit Date: Wed, 29 May 2019 07:44:01 +0200 > (At least) RTL8168e forgets its MAC address in PCI D3. To fix this set > the MAC address when resuming. For resuming from runtime-suspend we > had this in place already, for resuming from S3/S5 it was missing. > > The commit reference

Re: [PATCH V4 net-next 0/6] Peer to Peer One-Step time stamping

2019-05-30 Thread David Miller
From: Richard Cochran Date: Tue, 28 May 2019 22:58:01 -0700 > This series adds support for PTP (IEEE 1588) P2P one-step time > stamping along with a driver for a hardware device that supports this. > > If the hardware supports p2p one-step, it subtracts the ingress time > stamp value from the Pd

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-30 Thread David Miller
From: Alexei Starovoitov Date: Thu, 30 May 2019 11:27:23 -0700 > On Thu, May 30, 2019 at 11:01 AM David Miller wrote: >> >> From: Alexei Starovoitov >> Date: Thu, 30 May 2019 08:18:10 -0700 >> >> > On Thu, May 30, 2019 at 8:16 AM David Ahern wrote: &g

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-30 Thread David Miller
From: David Ahern Date: Thu, 30 May 2019 12:52:43 -0600 > The nexthop code paths are not live yet. More changes are needed before > that can happen. I have been sending the patches in small, reviewable > increments to be kind to reviewers than a single 27 patch set with > everything (the remainin

Re: [PATCH net 0/2] mlxsw: Two small fixes

2019-05-30 Thread David Miller
From: Ido Schimmel Date: Wed, 29 May 2019 10:59:43 +0300 > From: Ido Schimmel > > Patch #1 from Jiri fixes an issue specific to Spectrum-2 where the > insertion of two identical flower filters with different priorities > would trigger a warning. > > Patch #2 from Amit prevents the driver from

Re: [PATCH net-next 0/8] mlxsw: Hardware monitoring enhancements

2019-05-30 Thread David Miller
From: Ido Schimmel Date: Wed, 29 May 2019 11:47:14 +0300 > From: Ido Schimmel > > This patchset from Vadim provides various hardware monitoring related > improvements for mlxsw. > > Patch #1 allows querying firmware version from the switch driver when > the underlying bus is I2C. This is usefu

Re: [PATCH V1 net-next 01/11] net: ena: add handling of llq max tx burst size

2019-05-30 Thread David Miller
From: Date: Wed, 29 May 2019 12:49:54 +0300 > static inline int ena_com_write_sq_doorbell(struct ena_com_io_sq *io_sq) > { > u16 tail = io_sq->tail; > + u16 max_entries_in_tx_burst = io_sq->llq_info.max_entries_in_tx_burst; Reverse christmas tree please.

Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv_flags

2019-05-30 Thread David Miller
From: Date: Wed, 29 May 2019 12:49:55 +0300 > @@ -560,6 +564,14 @@ struct ena_admin_set_feature_mtu_desc { > u32 mtu; > }; > > +struct ena_admin_get_extra_properties_strings_desc { > + u32 count; > +}; > + > +struct ena_admin_get_extra_properties_flags_desc { > + u32 flags; > +};

Re: [PATCH V4 net-next 0/6] Peer to Peer One-Step time stamping

2019-05-30 Thread David Miller
From: David Miller Date: Thu, 30 May 2019 11:55:07 -0700 (PDT) > Series applied, thanks Richard. I had to revert, this doesn't build. drivers/ptp/ptp_ines.c: In function ‘ines_txtstamp’: drivers/ptp/ptp_ines.c:674:3: warning: ‘old_skb’ may be used uninitialized in this function

Re: [PATCH net-next v2 0/6] add TFO backup key

2019-05-30 Thread David Miller
From: Jason Baron Date: Wed, 29 May 2019 12:33:55 -0400 > Christoph, Igor, and I have worked on an API that facilitates TFO key > rotation. This is a follow up to the series that Christoph previously > posted, with an API that meets both of our use-cases. Here's a > link to the previous work: >

Re: [PATCH v2 net 0/2] Fixes for DSA tagging using 802.1Q

2019-05-30 Thread David Miller
From: Vladimir Oltean Date: Thu, 30 May 2019 00:42:29 +0300 > During the prototyping for the "Decoupling PHYLINK from struct > net_device" patchset, the CPU port of the sja1105 driver was moved to a > different spot. This uncovered an issue in the tag_8021q DSA code, > which used to work by mist

Re: [PATCH net] net: correct zerocopy refcnt with udp MSG_MORE

2019-05-30 Thread David Miller
From: Willem de Bruijn Date: Wed, 29 May 2019 15:33:57 -0400 > Fixes: 52900d22288ed ("udp: elide zerocopy operation in hot path") This is not a valid commit ID.

  1   2   3   4   5   6   7   8   9   10   >