Re: [PATCH net] net: don't clear sock->sk early to avoid trouble in strparser

2019-05-30 Thread David Miller
From: Jakub Kicinski Date: Wed, 29 May 2019 16:33:23 -0700 > af_inet sets sock->sk to NULL which trips strparser over: ... > To avoid this issue set sock->sk after sk_prot->close. > My grepping and testing did not discover any code which > would depend on the current behaviour. > > Fixes: c4623

Re: [net-next]hinic: add LRO support

2019-05-30 Thread David Miller
All of these module params are a non-starter.

Re: [PATCH net-next] r8169: enable WoL speed down on more chip versions

2019-05-30 Thread David Miller
From: Heiner Kallweit Date: Wed, 29 May 2019 20:52:03 +0200 > Call the pll power down function also for chip versions 02..06 and > 13..15. The MAC can't be powered down on these chip versions, but at > least they benefit from the speed-down power-saving if WoL is enabled. > > Signed-off-by: Hein

Re: [PATCH net-next,v3 0/9] connection tracking support for bridge

2019-05-30 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 29 May 2019 13:25:30 +0200 > This patchset adds native connection tracking support for the bridge. Series applied.

Re: [PATCH] net: ethernet: ti: cpsw_ethtool: fix ethtool ring param set

2019-05-30 Thread David Miller
From: Ivan Khoronzhuk Date: Thu, 30 May 2019 00:47:53 +0300 > Fixes: 37e2d99b59c4765112533a1d38174fea58d28a51 ("ethtool: Ensure new > ring parameters are within bounds during SRINGPARAM") > > Signed-off-by: Ivan Khoronzhuk Please do not chop up Fixes: tags into multiple lines. Please do not p

Re: [PATCH net] net-gro: fix use-after-free read in napi_gro_frags()

2019-05-30 Thread David Miller
From: Eric Dumazet Date: Wed, 29 May 2019 15:36:10 -0700 > If a network driver provides to napi_gro_frags() an > skb with a page fragment of exactly 14 bytes, the call > to gro_pull_from_frag0() will 'consume' the fragment > by calling skb_frag_unref(skb, 0), and the page might > be freed and reu

Re: [PATCH net-next 0/2] r8169: decouple firmware handling code from actual driver code

2019-05-30 Thread David Miller
From: Heiner Kallweit Date: Wed, 29 May 2019 21:13:05 +0200 > These two patches are a step towards eventually factoring out firmware > handling code to a separate source file. Series applied.

Re: [PATCH net-next 0/7] net: add rcu annotations for ifa_list

2019-05-30 Thread David Miller
From: Florian Westphal Date: Wed, 29 May 2019 13:43:25 +0200 > Eric Dumazet reported follwing problem: > > It looks that unless RTNL is held, accessing ifa_list needs proper RCU > protection. indev->ifa_list can be changed under us by another cpu > (which owns RTNL) [..] > > A proper r

Re: [PATCH net-next] qed: Fix static checker warning

2019-05-30 Thread David Miller
From: Michal Kalderon Date: Thu, 30 May 2019 15:20:40 +0300 > In some cases abs_ppfid could be printed without being initialized. > > Fixes: 79284adeb99e ("qed: Add llh ppfid interface and 100g support for > offload protocols") > Reported-by: Dan Carpenter > Signed-off-by: Michal Kalderon Ap

Re: [PATCH net-next v2 0/3] net: phy: improve handling of more complex C45 PHY's

2019-05-30 Thread David Miller
From: Heiner Kallweit Date: Thu, 30 May 2019 15:08:09 +0200 > This series tries to address few problematic aspects raised by > Russell. Concrete example is the Marvell 88x3310, the changes > should be helpful for other complex C45 PHY's too. > > v2: > - added patch enabling interrupts also if ph

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-05-30

2019-05-30 Thread David Miller
From: Jeff Kirsher Date: Thu, 30 May 2019 11:50:30 -0700 > This series contains updates to ice driver only. Pulled, thanks Jeff.

Re: [PATCH net-next 1/6] seg6: Fix TLV definitions

2019-05-30 Thread David Miller
From: Tom Herbert Date: Thu, 30 May 2019 14:50:16 -0700 > TLV constants are defined for PAD1, PADN, and HMAC (the three defined in > draft-ietf-6man-segment-routing-header-19). The other TLV are unused and > not correct so they are removed. Removing macros will break userland compilation, you ca

Re: [PATCH net v2] net: correct zerocopy refcnt with udp MSG_MORE

2019-05-30 Thread David Miller
From: Willem de Bruijn Date: Thu, 30 May 2019 18:01:21 -0400 > From: Willem de Bruijn > > TCP zerocopy takes a uarg reference for every skb, plus one for the > tcp_sendmsg_locked datapath temporarily, to avoid reaching refcnt zero > as it builds, sends and frees skbs inside its inner loop. > >

Re: [PATCH V4 net-next 0/6] Peer to Peer One-Step time stamping

2019-05-31 Thread David Miller
From: Richard Cochran Date: Thu, 30 May 2019 22:51:32 -0700 > Anyhow, I rebased v5 of my series to latest net-next, and I'm getting > a lot of these: > > In file included from net/ipv6/af_inet6.c:45:0: > ./include/linux/netfilter_ipv6.h: In function ‘nf_ipv6_br_defrag’: > ./include/linux/netfilt

Re: Bad XDP performance with mlx5

2019-05-31 Thread David Miller
From: Jesper Dangaard Brouer Date: Fri, 31 May 2019 18:18:17 +0200 > On Fri, 31 May 2019 08:51:43 +0200 Tom Barbette wrote: > >> I wonder if it doesn't simply come from mlx5/en_main.c: >> rq->buff.map_dir = rq->xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE; >> > > Nope, that is not the probl

Re: [PATCH] netfilter: nf_conntrack_bridge: fix CONFIG_IPV6=y

2019-05-31 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 31 May 2019 11:11:24 +0200 > This patch fixes a few problems with CONFIG_IPV6=y and > CONFIG_NF_CONNTRACK_BRIDGE=m: > > In file included from net/netfilter/utils.c:5: > include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag': > include/linux/netfilter_i

MERGE net --> net-next

2019-05-31 Thread David Miller
I just merged net into net-next, just FYI...

Re: [PATCH net-next] net: phy: phylink: support using device PHY in fixed or 802.3z mode

2019-05-31 Thread David Miller
So many changes to the same file that seem somehow related. Therefore, why didn't you put this stuff into a formal patch series?

Re: [PATCH net-next] ipv6: Send ICMP errors for exceeding extension header limits

2019-05-31 Thread David Miller
From: Tom Herbert Date: Tue, 28 May 2019 16:32:42 -0700 > @@ -156,8 +159,11 @@ static bool ip6_parse_tlv(const struct tlvtype_proc > *procs, >* See also RFC 4942, Section 2.1.9.5. >*/ > padlen += optlen; > -

Re: [PATCH net-next 0/5] phylink/sfp updates

2019-05-31 Thread David Miller
From: Russell King - ARM Linux admin Date: Tue, 28 May 2019 10:56:39 +0100 > This is a series of updates to phylink and sfp: Series applied.

Re: [PATCH net-next] net: phy: phylink: support using device PHY in fixed or 802.3z mode

2019-05-31 Thread David Miller
From: Robert Hancock Date: Fri, 31 May 2019 13:41:05 -0600 > On 2019-05-31 1:29 p.m., David Miller wrote: >> >> So many changes to the same file that seem somehow related. >> >> Therefore, why didn't you put this stuff into a formal patch series? > > The

Re: [net-next PATCH] net: rtnetlink: Enslave device before bringing it up

2019-05-31 Thread David Miller
From: Phil Sutter Date: Wed, 29 May 2019 15:51:20 +0200 > Unlike with bridges, one can't add an interface to a bond and set it up > at the same time: > > | # ip link set dummy0 down > | # ip link set dummy0 master bond0 up > | Error: Device can not be enslaved while up. > > Of all drivers with

Re: [PATCH net 1/1] net: dsa: sja1105: Don't store frame type in skb->cb

2019-05-31 Thread David Miller
From: Vladimir Oltean Date: Thu, 30 May 2019 00:51:26 +0300 > Due to a confusion I thought that eth_type_trans() was called by the > network stack whereas it can actually be called by network drivers to > figure out the skb protocol and next packet_type handlers. > > In light of the above, it is

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-31 Thread David Miller
David, can you add some supplementary information to your cover letter et al. which seems to be part of what Alexei is asking for and seems quite reasonable? Thanks.

Re: [PATCH net] vrf: Increment Icmp6InMsgs on the original netdev

2019-05-31 Thread David Miller
From: Stephen Suryaputra Date: Thu, 30 May 2019 01:08:15 -0400 > Get the ingress interface and increment ICMP counters based on that > instead of skb->dev when the the dev is a VRF device. > > This is a follow up on the following message: > https://www.spinics.net/lists/netdev/msg560268.html >

Re: [PATCH V5 net-next 0/6] Peer to Peer One-Step time stamping

2019-05-31 Thread David Miller
From: Richard Cochran Date: Thu, 30 May 2019 22:56:20 -0700 > This series adds support for PTP (IEEE 1588) P2P one-step time > stamping along with a driver for a hardware device that supports this. ... Series applied, will push out after build testing :-) Thanks.

Re: [net-next 00/13][pull request] Intel Wired LAN Driver Updates 2019-05-31

2019-05-31 Thread David Miller
From: Jeff Kirsher Date: Fri, 31 May 2019 01:15:05 -0700 > This series contains updates to the iavf driver. Pulled, thanks Jeff. I do agree with Joe that the debug logging macro can be improved. Please take a look at his feedback. Thanks.

Re: [PATCH V5 net-next 0/6] Peer to Peer One-Step time stamping

2019-05-31 Thread David Miller
From: David Miller Date: Fri, 31 May 2019 14:54:56 -0700 (PDT) > From: Richard Cochran > Date: Thu, 30 May 2019 22:56:20 -0700 > >> This series adds support for PTP (IEEE 1588) P2P one-step time >> stamping along with a driver for a hardware device that supports thi

Re: pull-request: bpf-next 2019-05-31

2019-05-31 Thread David Miller
From: Alexei Starovoitov Date: Fri, 31 May 2019 20:38:13 -0700 > The following pull-request contains BPF updates for your *net-next* tree. > > Lots of exciting new features in the first PR of this developement cycle! > The main changes are: > > 1) misc verifier improvements, from Alexei. > > 2

Re: [PATCH 00/15] Netfilter/IPVS updates for net-next

2019-06-01 Thread David Miller
From: Pablo Neira Ayuso Date: Sat, 1 Jun 2019 20:23:25 +0200 > The following patchset container Netfilter/IPVS update for net-next: Pulled, thanks Pablo.

Re: [PATCH net-next] selftests: Add test cases for nexthop objects

2019-06-02 Thread David Miller
From: David Ahern Date: Thu, 30 May 2019 12:06:36 -0700 > From: David Ahern > > Add functional test cases for nexthop objects. > > Signed-off-by: David Ahern Applied, thanks.

Re: [PATCH net-next] cxgb4: Set initial IRQ affinity hints

2019-06-02 Thread David Miller
From: Nirranjan Kirubaharan Date: Thu, 30 May 2019 23:14:28 -0700 > + while (--ethqidx >= 0) { > + --msi_index; It is more canonical to use "msi_index--;" here.

Re: [PATCH net-next] Update my email address

2019-06-02 Thread David Miller
From: Wei Liu Date: Fri, 31 May 2019 08:31:02 +0100 > Signed-off-by: Wei Liu Applied.

Re: [PATCH net] packet: unconditionally free po->rollover

2019-06-02 Thread David Miller
From: Willem de Bruijn Date: Fri, 31 May 2019 12:37:23 -0400 > From: Willem de Bruijn > > Rollover used to use a complex RCU mechanism for assignment, which had > a race condition. The below patch fixed the bug and greatly simplified > the logic. > > The feature depends on fanout, but the stat

Re: [PATCH net-next v3] net: add rcu annotations for ifa_list

2019-06-02 Thread David Miller
From: Florian Westphal Date: Fri, 31 May 2019 18:27:02 +0200 > v3: fix typo in patch1 commit message > All other patches are unchanged. > v2: remove ifa_list iteration in afs instead of conversion > > Eric Dumazet reported following problem: > > It looks that unless RTNL is held, accessin

Re: [PATCH net-next] net: ethernet: improve eth_platform_get_mac_address

2019-06-02 Thread David Miller
From: Heiner Kallweit Date: Fri, 31 May 2019 19:14:44 +0200 > pci_device_to_OF_node(to_pci_dev(dev)) is the same as dev->of_node, > so we can simplify the code. In addition add an empty line before > the return statement. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next] r8169: improve r8169_csum_workaround

2019-06-02 Thread David Miller
From: Heiner Kallweit Date: Fri, 31 May 2019 19:17:15 +0200 > Use helper skb_is_gso() and simplify access to tx_dropped. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next] nexthop: Add entry to MAINTAINERS

2019-06-02 Thread David Miller
From: David Ahern Date: Fri, 31 May 2019 12:44:09 -0600 > From: David Ahern > > Add entry to MAINTAINERS file for new nexthop code. > > Signed-off-by: David Ahern Applied.

Re: [PATCH net-next 0/3] r8169: replace several function pointers with direct calls

2019-06-02 Thread David Miller
From: Heiner Kallweit Date: Fri, 31 May 2019 19:52:24 +0200 > This series removes most function pointers from struct rtl8169_private > and uses direct calls instead. This simplifies the code and avoids > the penalty of indirect calls in times of retpoline. Series applied, thanks.

Re: [PATCH net] net: fix indirect calls helpers for ptype list hooks.

2019-06-03 Thread David Miller
From: Paolo Abeni Date: Mon, 3 Jun 2019 12:46:43 +0200 > Fixes: 92884ca8830b ("net: fix indirect calls helpers for ptype list hooks.") This doesn't seem to be a valid GIT SHA1_ID. [davem@localhost net]$ git describe 92884ca8830b fatal: Not a valid object name 92884ca8830b Please respin with t

Re: [PATCH net-next 0/9] mlxsw: Add support for physical hardware clock

2019-06-03 Thread David Miller
From: Ido Schimmel Date: Mon, 3 Jun 2019 15:12:35 +0300 > This is the first of about four patchsets that add PTP support in mlxsw > for the Spectrum-1 ASIC. Richard, could you give this a quick review? Thank you.

Re: [PATCH net 2/4] s390/qeth: don't use obsolete dst entry

2019-06-03 Thread David Miller
From: Julian Wiedmann Date: Mon, 3 Jun 2019 17:04:44 +0200 > While qeth_l3 uses netif_keep_dst() to hold onto the dst, a skb's dst > may still have been obsoleted (via dst_dev_put()) by the time that we > end up using it. The dst then points to the loopback interface, which > means the neighbour

Re: [PATCH V2 net 00/11] Extending the ena driver to support new features and enhance performance

2019-06-03 Thread David Miller
From: Date: Mon, 3 Jun 2019 17:43:18 +0300 > From: Sameeh Jubran > > This patchset introduces the following: > > * add support for changing the inline header size (max_header_size) for > applications > with overlay and nested headers > * enable automatic fallback to polling mode for admin q

Re: [PATCH net-next] flow_dissector: remove unused FLOW_DISSECTOR_F_STOP_AT_L3 flag

2019-06-03 Thread David Miller
From: Stanislav Fomichev Date: Fri, 31 May 2019 14:05:06 -0700 > This flag is not used by any caller, remove it. > > Signed-off-by: Stanislav Fomichev Applied.

Re: [PATCH net-next] flow_offload: include linux/kernel.h from flow_offload.h

2019-06-03 Thread David Miller
From: Edward Cree Date: Fri, 31 May 2019 22:47:21 +0100 > flow_stats_update() uses max_t, so ensure we have that defined. > > Signed-off-by: Edward Cree Applied.

Re: [PATCH net-next] ipv6: icmp: use this_cpu_read() in icmpv6_sk()

2019-06-03 Thread David Miller
From: Eric Dumazet Date: Fri, 31 May 2019 15:27:00 -0700 > In general, this_cpu_read(*X) is faster than *this_cpu_ptr(X) > > Also remove the inline attibute, totally useless. > > Signed-off-by: Eric Dumazet > Cc: Kefeng Wang Applied.

Re: [pull request][net-next 0/9] Mellanox, mlx5 updates 2019-05-31

2019-06-03 Thread David Miller
From: Saeed Mahameed Date: Fri, 31 May 2019 20:09:19 + > This series adds misc updates to mlx5 driver. > For more information please see tag log below. > > Please pull and let me know if there is any problem. > > Please note that the series starts with a merge of mlx5-next branch, > to reso

Re: [PATCH net-next] ipv6: use this_cpu_read() in rt6_get_pcpu_route()

2019-06-03 Thread David Miller
From: Eric Dumazet Date: Fri, 31 May 2019 18:11:25 -0700 > this_cpu_read(*X) is faster than *this_cpu_ptr(X) > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net-next] ipv4: icmp: use this_cpu_read() in icmp_sk()

2019-06-03 Thread David Miller
From: Eric Dumazet Date: Fri, 31 May 2019 19:09:02 -0700 > this_cpu_read(*X) is faster than *this_cpu_ptr(X) > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net-next] tcp: use this_cpu_read(*X) instead of *this_cpu_ptr(X)

2019-06-03 Thread David Miller
From: Eric Dumazet Date: Fri, 31 May 2019 19:17:33 -0700 > this_cpu_read(*X) is slightly faster than *this_cpu_ptr(X) > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net-next] r8169: use paged versions of phylib MDIO access functions

2019-06-03 Thread David Miller
From: Heiner Kallweit Date: Sun, 2 Jun 2019 10:53:49 +0200 > Use paged versions of phylib MDIO access functions to simplify > the code. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net] selftests: set sysctl bc_forwarding properly in router_broadcast.sh

2019-06-03 Thread David Miller
From: Xin Long Date: Sun, 2 Jun 2019 19:09:55 +0800 > sysctl setting bc_forwarding for $rp2 is needed when ping_test_from h2, > otherwise the bc packets from $rp2 won't be forwarded. This patch is to > add this setting for $rp2. > > Also, as ping_test_from does grep "$from" only, which could ma

Re: [PATCH] net: sfp: read eeprom in maximum 16 byte increments

2019-06-03 Thread David Miller
From: Russell King Date: Sun, 02 Jun 2019 15:13:00 +0100 > Some SFP modules do not like reads longer than 16 bytes, so read the > EEPROM in chunks of 16 bytes at a time. This behaviour is not specified > in the SFP MSAs, which specifies: > > "The serial interface uses the 2-wire serial CMOS E2

Re: [PATCH net-next] net: fix use-after-free in kfree_skb_list

2019-06-03 Thread David Miller
From: Eric Dumazet Date: Sun, 2 Jun 2019 11:24:18 -0700 > syzbot reported nasty use-after-free [1] > > Lets remove frag_list field from structs ip_fraglist_iter > and ip6_fraglist_iter. This seens not needed anyway. ... > Fixes: 0feca6190f88 ("net: ipv6: add skbuff fraglist splitter") > Fixes:

Re: [PATCH net-next 0/4] r8169: make firmware handling code ready to be factored out

2019-06-03 Thread David Miller
From: Heiner Kallweit Date: Mon, 3 Jun 2019 21:22:46 +0200 > This series contains the final steps to make firmware handling code > ready to be factored out into a separate source code file. Series applied, thanks.

Re: [PATCH net 0/2] net/tls: redo the RX resync locking

2019-06-04 Thread David Miller
From: Jakub Kicinski Date: Fri, 31 May 2019 20:11:59 -0700 > Take two of making sure we don't use a NULL netdev pointer > for RX resync. This time using a bit and an open coded > wait loop. > > Posting as revert + new patch, hopefully this will make it > easier to backport to stable (unless thi

Re: [PATCH] net: phylink: avoid reducing support mask

2019-06-04 Thread David Miller
From: Russell King Date: Sun, 02 Jun 2019 15:12:54 +0100 > Avoid reducing the support mask as a result of the interface type > selected for SFP modules, or when setting the link settings through > ethtool - this should only change when the supported link modes of > the hardware combination change

Re: [PATCH net-next 00/11] FDB updates for SJA1105 DSA driver

2019-06-04 Thread David Miller
From: Vladimir Oltean Date: Mon, 3 Jun 2019 00:11:52 +0300 > This patch series adds: > > - FDB switchdev support for the second generation of switches (P/Q/R/S). > I could test/code these now that I got a board with a SJA1105Q. > > - Management route support for SJA1105 P/Q/R/S. This is need

Re: [PATCH v2 net 1/1] net: dsa: sja1105: Fix link speed not working at 100 Mbps and below

2019-06-04 Thread David Miller
From: Vladimir Oltean Date: Mon, 3 Jun 2019 02:31:37 +0300 > The hardware values for link speed are held in the sja1105_speed_t enum. > However they do not increase in the order that sja1105_get_speed_cfg was > iterating over them (basically from SJA1105_SPEED_AUTO - 0 - to > SJA1105_SPEED_1000M

Re: [PATCH RESEND net-next] net: stmmac: socfpga: add RMII phy mode

2019-06-04 Thread David Miller
From: Dinh Nguyen Date: Mon, 3 Jun 2019 09:44:18 -0500 > Add option for enabling RMII phy mode. > > Reviewed-by: Florian Fainelli > Signed-off-by: Wei Liang Lim > Signed-off-by: Dinh Nguyen Applied.

Re: [PATCH net v2 0/2] net/tls: redo the RX resync locking

2019-06-04 Thread David Miller
From: Jakub Kicinski Date: Tue, 4 Jun 2019 12:00:10 -0700 > Hi! > > Take two of making sure we don't use a NULL netdev pointer > for RX resync. This time using a bit and an open coded > wait loop. > > v2: > - fix build warning (DaveM). :-) Applied and queued up for -stable.

Re: [patch net-next v3 0/8] expose flash update status to user

2019-06-04 Thread David Miller
From: Jiri Pirko Date: Tue, 4 Jun 2019 15:40:36 +0200 > From: Jiri Pirko > > When user is flashing device using devlink, he currenly does not see any > information about what is going on, percentages, etc. > Drivers, for example mlxsw and mlx5, have notion about the progress > and what is happ

Re: [PATCH net-next] net: ipv4: fix rcu lockdep splat due to wrong annotation

2019-06-04 Thread David Miller
From: Florian Westphal Date: Mon, 3 Jun 2019 22:41:44 +0200 > syzbot triggered following splat when strict netlink > validation is enabled: > > net/ipv4/devinet.c:1766 suspicious rcu_dereference_check() usage! > > This occurs because we hold RTNL mutex, but no rcu read lock. > The second call

Re: [PATCH net-next 0/8] net/tls: small general improvements

2019-06-04 Thread David Miller
From: Jakub Kicinski Date: Mon, 3 Jun 2019 15:16:57 -0700 > This series cleans up and improves the tls code, mostly the offload > parts. > > First a slight performance optimization - avoiding unnecessary re- > -encryption of records in patch 1. Next patch 2 makes the code > more resilient by c

Re: [PATCH net-next 0/2] Support MPLS features in bonding and vlan net devices

2019-06-04 Thread David Miller
From: Ariel Levkovich Date: Mon, 3 Jun 2019 22:36:45 + > Netdevice HW MPLS features are not passed from device driver's netdevice to > upper netdevice, specifically VLAN and bonding netdevice which are created > by the kernel when needed. > > This prevents enablement and usage of HW offloads

Re: [PATCH net-next] ipv6: Always allocate pcpu memory in a fib6_nh

2019-06-04 Thread David Miller
From: David Ahern Date: Mon, 3 Jun 2019 18:37:03 -0700 > From: David Ahern > > A recent commit had an unintended side effect with reject routes: > rt6i_pcpu is expected to always be initialized for all fib6_info except > the null entry. The commit mentioned below skips it for reject routes > a

Re: [PATCH net] ipv6: tcp: enable flowlabel reflection in some RST packets

2019-06-04 Thread David Miller
From: Eric Dumazet Date: Tue, 4 Jun 2019 18:16:00 -0700 > On 6/4/19 12:29 PM, Eric Dumazet wrote: >> This extends commit 22b6722bfa59 ("ipv6: Add sysctl for per >> namespace flow label reflection"), for some TCP RST packets. >> >> When RST packets are sent because no socket could be found, >> it

Re: [PATCH net] udp: only choose unbound UDP socket for multicast when not in a VRF

2019-06-04 Thread David Miller
From: Tim Beale Date: Tue, 4 Jun 2019 13:56:23 +1200 > By default, packets received in another VRF should not be passed to an > unbound socket in the default VRF. This patch updates the IPv4 UDP > multicast logic to match the unicast VRF logic (in compute_score()), > as well as the IPv6 mcast lo

Re: [PATCH v3 net-next 0/7] net: add struct nexthop to fib{6}_info

2019-06-04 Thread David Miller
From: David Ahern Date: Mon, 3 Jun 2019 20:19:48 -0700 > Set 10 of 11 to improve route scalability via support for nexthops as > standalone objects for fib entries. > https://lwn.net/Articles/763950/ Series applied, thanks David.

Re: [PATCH net-next 0/2] r8169: factor out firmware handling

2019-06-04 Thread David Miller
From: Heiner Kallweit Date: Tue, 4 Jun 2019 07:44:53 +0200 > Let's factor out firmware handling into a separate source code file. > This simplifies reading the code and makes clearer what the interface > between driver and firmware handling is. This doesn't apply cleanly to net-next, specificall

Re: [PATCH net-next] vmxnet3: turn off lro when rxcsum is disabled

2019-06-04 Thread David Miller
From: Ronak Doshi Date: Mon, 3 Jun 2019 23:58:38 -0700 > Currently, when rx csum is disabled, vmxnet3 driver does not turn > off lro, which can cause performance issues if user does not turn off > lro explicitly. This patch adds fix_features support which is used to > turn off LRO whenever RXCSUM

Re: [PATCH v2 net 0/4] s390/qeth: fixes 2019-06-04

2019-06-04 Thread David Miller
From: Julian Wiedmann Date: Tue, 4 Jun 2019 10:15:05 +0200 > same patch series as yesterday, except that patch 2 has been adjusted > as per your review to use dst_check(). Please have another look. The correct usage is: dst = dst_check();

Re: [PATCH net v2] net: fix indirect calls helpers for ptype list hooks.

2019-06-04 Thread David Miller
From: Paolo Abeni Date: Tue, 4 Jun 2019 11:44:06 +0200 > As Eric noted, the current wrapper for ptype func hook inside > __netif_receive_skb_list_ptype() has no chance of avoiding the indirect > call: we enter such code path only for protocols other than ipv4 and > ipv6. > > Instead we can wrap

Re: [PATCH net-next v2 0/2] r8169: factor out firmware handling

2019-06-05 Thread David Miller
From: Heiner Kallweit Date: Wed, 5 Jun 2019 07:59:02 +0200 > Let's factor out firmware handling into a separate source code file. > This simplifies reading the code and makes clearer what the interface > between driver and firmware handling is. > > v2: > - fix small whitespace issue in patch 2

Re: [PATCH v3 net 0/4] s390/qeth: fixes 2019-06-05

2019-06-05 Thread David Miller
From: Julian Wiedmann Date: Wed, 5 Jun 2019 13:48:47 +0200 > one more shot... now with patch 2 fixed up so that it uses the > dst entry returned from dst_check(). Looks good, series applied, thanks.

Re: [PATCH net] pktgen: do not sleep with the thread lock held.

2019-06-05 Thread David Miller
From: Paolo Abeni Date: Wed, 5 Jun 2019 14:34:46 +0200 > @@ -3062,20 +3062,49 @@ static int thread_is_running(const struct > pktgen_thread *t) > return 0; > } > > -static int pktgen_wait_thread_run(struct pktgen_thread *t) > +static bool pktgen_lookup_thread(struct pktgen_net *pn, stru

Re: [PATCH v3 net-next] net: fec_ptp: Use dev_err() instead of pr_err()

2019-06-05 Thread David Miller
From: Fabio Estevam Date: Wed, 5 Jun 2019 10:10:35 -0300 > dev_err() is more appropriate for printing error messages inside > drivers, so switch to dev_err(). > > Signed-off-by: Fabio Estevam > Acked-by: Fugang Duan > --- > Changes since v2: > - Made it a standalone patch > - Collected Andy's

Re: [net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2019-06-05

2019-06-05 Thread David Miller
From: Jeff Kirsher Date: Wed, 5 Jun 2019 13:23:43 -0700 > This series contains updates to mainly ixgbe, with a few updates to > i40e, net, ice and hns2 driver. Pulled, thanks for the ETH_P_LLDP consolidation.

Re: [net-next 2/2] i40e: Check and set the PF driver state first in i40e_ndo_set_vf_mac

2019-06-05 Thread David Miller
From: Jeff Kirsher Date: Wed, 5 Jun 2019 12:45:16 -0700 > From: Lihong Yang > > The PF driver state flag __I40E_VIRTCHNL_OP_PENDING needs to be > checked and set at the beginning of i40e_ndo_set_vf_mac. Otherwise, > if there are error conditions before it, the flag will be cleared > unexpected

Re: [net-next 1/2] i40e: Do not check VF state in i40e_ndo_get_vf_config

2019-06-05 Thread David Miller
From: Jeff Kirsher Date: Wed, 5 Jun 2019 12:45:15 -0700 > From: Lihong Yang > > The VF configuration returned in i40e_ndo_get_vf_config is > already stored by the PF. There is no dependency on any > specific state of the VF to return the configuration. > Drop the check against I40E_VF_STATE_IN

Re: [PATCH net] ipv6: fix the check before getting the cookie in rt6_get_cookie

2019-06-05 Thread David Miller
From: Xin Long Date: Sun, 2 Jun 2019 19:10:46 +0800 > In Jianlin's testing, netperf was broken with 'Connection reset by peer', > as the cookie check failed in rt6_check() and ip6_dst_check() always > returned NULL. > > It's caused by Commit 93531c674315 ("net/ipv6: separate handling of FIB > e

Re: [PATCH net] ipv4: not do cache for local delivery if bc_forwarding is enabled

2019-06-05 Thread David Miller
From: Xin Long Date: Sun, 2 Jun 2019 19:10:24 +0800 > With the topo: > > h1 ---| rp1| > | route rp3 |--- h3 (192.168.200.1) > h2 ---| rp2| > > If rp1 bc_forwarding is set while rp2 bc_forwarding is not, after > doing "ping 192.168.200.255" on h1,

Re: [PATCHv2 1/1] net: rds: add per rds connection cache statistics

2019-06-05 Thread David Miller
From: Zhu Yanjun Date: Mon, 3 Jun 2019 00:28:01 -0400 > The variable cache_allocs is to indicate how many frags (KiB) are in one > rds connection frag cache. > The command "rds-info -Iv" will output the rds connection cache > statistics as below: > " > RDS IB Connections: > LocalAddr Remot

Re: [PATCH 1/1] net: rds: fix memory leak when unload rds_rdma

2019-06-05 Thread David Miller
From: Zhu Yanjun Date: Mon, 3 Jun 2019 08:48:19 -0400 > When KASAN is enabled, after several rds connections are > created, then "rmmod rds_rdma" is run. The following will > appear. ... > This is rds connection memory leak. The root cause is: > When "rmmod rds_rdma" is run, rds_ib_remove_one w

Re: [PATCH v2 net-next] ipv6: Send ICMP errors for exceeding extension header limits

2019-06-05 Thread David Miller
From: Tom Herbert Date: Mon, 3 Jun 2019 08:47:47 -0700 > Define constants and add support to send ICMPv6 Parameter Problem > errors as specified in draft-ietf-6man-icmp-limits-02. Tom, I've kinda had enough of this pushing your agenda by trying to add support for ipv6 features that are in draft

Re: [PATCH V2] Fix memory leak in sctp_process_init

2019-06-05 Thread David Miller
From: Neil Horman Date: Mon, 3 Jun 2019 16:32:59 -0400 > syzbot found the following leak in sctp_process_init > BUG: memory leak > unreferenced object 0x88810ef68400 (size 1024): ... > The problem was that the peer.cookie value points to an skb allocated > area on the first pass through thi

Re: [PATCH net v2] ethtool: fix potential userspace buffer overflow

2019-06-05 Thread David Miller
From: Vivien Didelot Date: Mon, 3 Jun 2019 16:57:13 -0400 > ethtool_get_regs() allocates a buffer of size ops->get_regs_len(), > and pass it to the kernel driver via ops->get_regs() for filling. > > There is no restriction about what the kernel drivers can or cannot do > with the open ethtool_r

Re: [PATCH net] net: aquantia: fix wol configuration not applied sometimes

2019-06-05 Thread David Miller
From: Igor Russkikh Date: Tue, 4 Jun 2019 13:23:49 + > From: Nikita Danilov > > WoL magic packet configuration sometimes does not work due to > couple of leakages found. > > Mainly there was a regression introduced during readx_poll refactoring. > > Next, fw request waiting time was too s

Re: [PATCH net-next] net: phy: remove state PHY_FORCING

2019-06-05 Thread David Miller
From: Heiner Kallweit Date: Tue, 4 Jun 2019 23:02:34 +0200 > In the early days of phylib we had a functionality that changed to the > next lower speed in fixed mode if no link was established after a > certain period of time. This functionality has been removed years ago, > and state PHY_FORCING

Re: [PATCH net] Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied"

2019-06-05 Thread David Miller
From: Hangbin Liu Date: Wed, 5 Jun 2019 12:27:14 +0800 > This reverts commit e9919a24d3022f72bcadc407e73a6ef17093a849. > > Nathan reported the new behaviour breaks Android, as Android just add > new rules and delete old ones. > > If we return 0 without adding dup rules, Android will remove the

Re: [PATCH net] Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied"

2019-06-05 Thread David Miller
From: Nathan Chancellor Date: Wed, 5 Jun 2019 18:23:51 -0700 > On Wed, Jun 05, 2019 at 05:55:26PM -0700, David Miller wrote: >> From: Hangbin Liu >> Date: Wed, 5 Jun 2019 12:27:14 +0800 >> >> > This reverts commit e9919a24d3022f72bcadc407e73a6ef17093a849. >

Re: [PATCH net-next] net: phy: Add detection of 1000BaseX link mode support

2019-06-05 Thread David Miller
From: Robert Hancock Date: Tue, 4 Jun 2019 16:15:01 -0600 > Add 1000BaseX to the link modes which are detected based on the > MII_ESTATUS register as per 802.3 Clause 22. This allows PHYs which > support 1000BaseX to work properly with drivers using phylink. > > Previously 1000BaseX support was

Re: [PATCH net-next 2/3] dpaa2-eth: Support multiple traffic classes on Tx

2019-06-05 Thread David Miller
From: Ioana Radulescu Date: Wed, 5 Jun 2019 12:57:25 +0300 > + queue_mapping %= dpaa2_eth_queue_count(priv); You are now performing a very expensive modulus operation every single TX packet, regardless of whether TC is in use or not. The whole reason we store the queue mapping pre-cooked i

Re: [PATCH] net: phy: marvell10g: allow PHY to probe without firmware

2019-06-05 Thread David Miller
From: Russell King Date: Wed, 05 Jun 2019 11:43:16 +0100 > + (state == PHY_UP || state == PHY_RESUMING)) { drivers/net/phy/marvell10g.c: In function ‘mv3310_link_change_notify’: drivers/net/phy/marvell10g.c:268:35: error: ‘PHY_RESUMING’ undeclared (first use in this function); did you m

Re: [PATCH net] inet_connection_sock: remove unused parameter of reqsk_queue_unlink func

2019-06-05 Thread David Miller
From: Zhiqiang Liu Date: Wed, 5 Jun 2019 18:49:49 +0800 > small cleanup: "struct request_sock_queue *queue" parameter of > reqsk_queue_unlink > func is never used in the func, so we can remove it. > > Signed-off-by: Zhiqiang Liu Applied, thanks.

Re: [PATCH v2 net-next 0/2] ipv6: tcp: more control on RST flowlabels

2019-06-05 Thread David Miller
From: Eric Dumazet Date: Wed, 5 Jun 2019 07:55:08 -0700 > First patch allows to reflect incoming IPv6 flowlabel > on RST packets sent when no socket could handle the packet. > > Second patch makes sure we send the same flowlabel > for RST or ACK packets on behalf of TIME_WAIT sockets. Series a

Re: [PATCH net] inet_connection_sock: remove unused parameter of reqsk_queue_unlink func

2019-06-05 Thread David Miller
in the func, so we can remove it. >>> >>> Signed-off-by: Zhiqiang Liu >> >> Applied, thanks. >> > > Hi, David Miller. > So sorry for forgetting to sign partner's name who find the cleanup together. > I have sent v2 patch with my partner's

Re: [PATCH net-next] r8169: silence sparse warning in rtl8169_start_xmit

2019-06-06 Thread David Miller
From: Heiner Kallweit Date: Thu, 6 Jun 2019 07:49:17 +0200 > The opts[] array is of type u32. Therefore remove the wrong > cpu_to_le32(). The opts[] array members are converted to little endian > later when being assigned to the respective descriptor fields. > > This is not a new issue, it just

Re: [PATCH net 0/2] ipv6: fix EFAULT on sendto with icmpv6 and hdrincl

2019-06-06 Thread David Miller
From: Olivier Matz Date: Thu, 6 Jun 2019 09:15:17 +0200 > The following code returns EFAULT (Bad address): > > s = socket(AF_INET6, SOCK_RAW, IPPROTO_ICMPV6); > setsockopt(s, SOL_IPV6, IPV6_HDRINCL, 1); > sendto(ipv6_icmp6_packet, addr); /* returns -1, errno = EFAULT */ > > The problem

Re: [PATCH 1/1] net: rds: fix memory leak in rds_ib_flush_mr_pool

2019-06-06 Thread David Miller
From: Zhu Yanjun Date: Thu, 6 Jun 2019 04:00:03 -0400 > When the following tests last for several hours, the problem will occur. ... > When ibmr_ret is NULL, llist_entry is not executed. clean_nodes->next > instead of clean_nodes is added in clean_list. > So clean_nodes is discarded. It can not

<    1   2   3   4   5   6   7   8   9   10   >