Re: [PATCH tcp-2.6 0/2]: SACK block validation

2007-06-19 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 01:25:56 +0300 Do you have some plans regarding tcp-2.6? It is sort-of stuck in the mud until some real performance analysis of the RB-Tree stuff can be done. I'm currently knee-deep in working on support for some virtualization disk

Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread David Miller
From: PJ Waskiewicz [EMAIL PROTECTED] Date: Mon, 18 Jun 2007 11:42:29 -0700 + + /* The TX queue control structures */ + struct net_device_subqueue *egress_subqueue; + int egress_subqueue_count; Since every net device will have at least one

Re: [PATCH] AF_RXRPC: Return the number of bytes buffered in rxrpc_send_data()

2007-06-19 Thread David Miller
From: David Howells [EMAIL PROTECTED] Date: Mon, 18 Jun 2007 12:52:36 +0100 Return the number of bytes buffered in rxrpc_send_data(). Signed-off-by: David Howells [EMAIL PROTECTED] Patch applied, thanks a lot David. - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread David Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 19:35:45 +0200 pktgen heavily uses gettimeofday. I was using tsc as clock source with our opterons in the lab. In late 2.6.20 gettimeofday was changed so tsc couldn't be used on opterons (pktgen at least). To give you an

Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 13:01:18 -0700 I've been thinking about this more today, so please bear with me if I'm missing something. Right now, with how qdisc_restart() is running, we'd definitely call netif_subqueue_stopped(dev, skb-queue_mapping)

Re: [NET 00/02]: MACVLAN driver

2007-06-19 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 23:14:21 +0200 Stephen Hemminger wrote: Looks good. I have some changes to allow devices with multiple MAC addresses (never finished). This device could use that. How would the driver do that? I was thinking about using

Re: [RFC PATCH tcp-2.6 1/2] [TCP]: Discard fuzzy SACK blocks

2007-06-19 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Wed, 20 Jun 2007 02:09:44 +0300 (EEST) For sure you're curious enough - have a nice day with the negations... ;-) ...Seriously, double verification of that pkt_len part wouldn't hurt considering it's complexity. Thanks for explaining everything,

Re: [PATCH] NET: Multiple queue hardware support

2007-06-20 Thread David Miller
From: Jan-Bernd Themann [EMAIL PROTECTED] Date: Wed, 20 Jun 2007 16:58:43 +0200 to me it seems that this patch set only include multiple transmit queue support (for qdisc). Am I right with this observation? If so, are there also plans to support multiple receive queues to allow the queues to

Re: [RFC NET 00/02]: Secondary unicast address support

2007-06-21 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 21 Jun 2007 13:08:12 -0600 However this just seems to allow a card to decode multiple mac addresses which in some oddball load balancing configurations may actually be useful, but it seems fairly limited. Do you have a specific use case

Re: [IPV6] NDISC: Fix thinko to control Router Preference support.

2007-06-22 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Fri, 22 Jun 2007 15:15:27 +0900 (JST) Bug reported by Haruhito Watanabe [EMAIL PROTECTED]. This is also appropriate for -stable releases. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] Thank you, I will apply this and push around

Re: [PATCH] inetdevice.h must include sysctl.h

2007-06-22 Thread David Miller
From: Satyam Sharma [EMAIL PROTECTED] Date: Sat, 23 Jun 2007 05:26:52 +0530 [PATCH] include sysctl.h from inetdevice.h When CONFIG_INET=y and CONFIG_SYSCTL=n: In file included from net/core/netpoll.c:16: include/linux/inetdevice.h:15: error: '__NET_IPV4_CONF_MAX' undeclared here (not in

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-22 Thread David Miller
From: David Stevens [EMAIL PROTECTED] Date: Fri, 22 Jun 2007 21:30:05 -0700 [EMAIL PROTECTED] wrote on 06/22/2007 06:17:46 PM: On 23/06/07 02:04, David Stevens wrote: Why not make the application that writes resolv.conf also listen on a raw ICMPv6 socket? I don't believe you'd

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-23 Thread David Miller
From: Michael Buesch [EMAIL PROTECTED] Date: Sat, 23 Jun 2007 11:07:14 +0200 Yeah, it might work. But I think the compiler doesn't guarantee you anything about it. The compiler actually does guarentee these things, and that's why we have the endian bitfield macros. You're overreacting, we've

Re: [PATCH][Resend] TIPC: Fix infinite loop in netlink handler

2007-06-23 Thread David Miller
From: Florian Westphal [EMAIL PROTECTED] Date: Sat, 23 Jun 2007 20:25:46 +0200 From: Florian Westphal [EMAIL PROTECTED] The tipc netlink config handler uses the nlmsg_pid from the request header as destination for its reply. If the application initialized nlmsg_pid to 0, the reply is looped

Re: [RFD] L2 Network namespace infrastructure

2007-06-23 Thread David Miller
From: Benny Amorsen [EMAIL PROTECTED] Date: 23 Jun 2007 23:22:38 +0200 Policy routing just doesn't cut it; it's cumbersome to set up, limited to 256 tables False. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [RFD] L2 Network namespace infrastructure

2007-06-23 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 23 Jun 2007 15:41:16 -0600 If you want the argument to compile out. That is not a problem at all. I dropped that part from my patch because it makes infrastructure more complicated and there appeared to be no gain. However having a type

Re: [RFD] L2 Network namespace infrastructure

2007-06-23 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 23 Jun 2007 16:56:49 -0600 If the only use was strong isolation which Dave complains about I would concur that the namespace approach is inappropriate. However there are a lot other uses. By your very admission the only appropriate use

Re: [RFC] [PATCH 2.6.21.5] ppp: fix osize too small errors when decoding mppe

2007-06-24 Thread David Miller
From: Konstantin Sharlaimov [EMAIL PROTECTED] Date: Wed, 20 Jun 2007 22:37:18 +1100 The mppe_decompress() function required a buffer that is 1 byte too small when receiving a message of mru size. This fixes buffer allocation to prevent this from occurring. Signed-off-by: Konstantin

Re: [PATCH] NET: [CORE] Re-enable irqs before pushing pending DMA requests

2007-06-24 Thread David Miller
From: Shannon Nelson [EMAIL PROTECTED] Date: Thu, 21 Jun 2007 09:34:55 -0700 This moves the local_irq_enable() call in net_rx_action() to before calling the CONFIG_NET_DMA's dma_async_memcpy_issue_pending() rather than after. This shortens the irq disabled window and allows for DMA drivers

Re: [PATCH] net: Make skb_seq_read unmap the last fragment

2007-06-24 Thread David Miller
From: Olaf Kirch [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 09:56:24 +0200 From: Olaf Kirch [EMAIL PROTECTED] Make skb_seq_read unmap the last fragment Having walked through the entire skbuff, skb_seq_read would leave the last fragment mapped. As a consequence, the unwary caller would leak

Re: [RFC SKBUFF]: Keep track of writable header len of headerless clones

2007-06-24 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Sun, 24 Jun 2007 14:53:36 +0200 - sendmsg eth0, no NAT: sys 0m2.508s - sendmsg eth0, NAT: sys 0m2.539s - sendmsg eth0, NAT + patch: sys 0m2.445s(no change) This is probably because we're touching all the

Re: [RFD] L2 Network namespace infrastructure

2007-06-24 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sun, 24 Jun 2007 06:58:54 -0600 I am convinced I can keep network namespaces something that is so trivial and obvious to get right you won't have to pay attention to them. Ok then, I'll hold you to this when you post the rest of your

Re: [PATCH 1/2 - rev2] qdisc_restart - readability changes plus one bug fix.

2007-06-24 Thread David Miller
From: Krishna Kumar [EMAIL PROTECTED] Date: Mon, 18 Jun 2007 10:21:24 +0530 New changes : - Incorporated Peter Waskiewicz's comments. - Re-added back one warning message (on driver returning wrong value). Previous changes : - Converted to use switch/case code which looks neater. -

Re: [PATCH 2/2 - rev2] qdisc_restart - couple of optimizations.

2007-06-24 Thread David Miller
From: Krishna Kumar [EMAIL PROTECTED] Date: Mon, 18 Jun 2007 10:24:11 +0530 (Same from previous patch, resending for completion) Changes : - netif_queue_stopped need not be called inside qdisc_restart as it has been called already in qdisc_run() before the first skb is sent, and in

Re: [RFC SKBUFF]: Keep track of writable header len of headerless clones

2007-06-24 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Sun, 24 Jun 2007 14:53:36 +0200 I expect other users can see a similar performance improvement, packet mangling iptables targets, ipip and ip_gre come to mind .. Comments welcome. Patrick please give me a suitable signed-off-by line, I'd like to

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-24 Thread David Miller
From: Dan Williams [EMAIL PROTECTED] Date: Sun, 24 Jun 2007 22:17:31 -0400 The glibc guys rejected things like periodically stat()-ing resolv.conf. At least these days such a thing could be re-proposed using something like inotify(), although it might be difficult to get glibc to receive that

Re: [PATCH 1/2 - rev2] qdisc_restart - readability changes plus onebug fix.

2007-06-24 Thread David Miller
From: Krishna Kumar [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 08:18:32 +0530 Hi Jamal, Dave (and anyone else interested), Could you review this patch ? I definitely will. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] Age Entry For IPv4 Route Table

2007-06-25 Thread David Miller
From: Varun Chandramohan [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 13:28:37 +0530 Ok i understand. But can you suggest anyother way to do the above? Just because I found a fault in your patch doesn't mean that it becomes my job isn't to implement the feature for you. - To unsubscribe from this

Re: [RFC SKBUFF]: Keep track of writable header len of headerless clones

2007-06-25 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 10:51:59 +0200 David Miller wrote: Patrick please give me a suitable signed-off-by line, I'd like to apply this to net-2.6.23 Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Applied and pushed out, thanks Patrick

Re: [PATCH] NET: Multiqueue network device support.

2007-06-25 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 12:47:31 -0400 On Fri, 2007-22-06 at 09:26 +0800, Zhu Yi wrote: We don't have THL and THH in our driver. They are what you suggested. The queue wakeup number is 1/4 of the ring size. So how did you pick 1/4? Experimentation? If you look

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 14:01:31 -0700 Awesome Dave!! Thank you very much. :) Please get your next round of patches ready, Patrick and I can review them and barring any serious issues we can finally put this stuff in to net-2.6.23. - To unsubscribe

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 23:08:09 +0200 David Miller wrote: I've been using this patch and the IPROUTE2 patches Patrick has proposed with no issues. Can someone else look at these patches when they have time? I'd be interested in seeing them make

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 14:33:12 -0700 I'm putting them into the latest 2.6.23 tree right now - I'll have them tested and sent upstream later today. Please repull as I just put Patrick's RTNETLINK patch in for real this time :-) - To unsubscribe

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 16:23:02 -0700 It looks like the one Patrick resent was the older version that requires a typecast. This is the function prototype currently in the kernel: +extern int rtattr_parse_nested_compat(struct rtattr *tb[], int

Re: [RTNETLINK]: Add nested compat attribute

2007-06-26 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 26 Jun 2007 12:04:21 +0200 David Miller wrote: Meanwhile, Patrick please clear up the situation :-) Attached is both an incremental patch and a complete replacement, please take whichever you like better :) I applied the incremental

Re: [PATCH 2.6.21.1] ipconfig: add support for multiple user devs

2007-06-27 Thread David Miller
From: Sean Kormilo [EMAIL PROTECTED] Date: Thu, 17 May 2007 15:16:12 -0400 Update ipconfig to enable users to specify multiple devices on the kernel commandline ip= option. This allows for up-to 4 devices to be specified, with devices separated by a '/' character. For example, to limit

Re: [PATCH 1/2] [IPV6] MIP6: Kill unnecessary ifdefs.

2007-06-27 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 16:50:18 +0900 From: Masahide NAKAMURA [EMAIL PROTECTED] Kill unnecessary CONFIG_IPV6_MIP6. o It is redundant for RAW socket to keep MH out with the config then it can handle any protocol. o Clean-up at AH. Signed-off-by: Masahide

Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.

2007-06-27 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 16:50:19 +0900 From: Masahide NAKAMURA [EMAIL PROTECTED] This patch makes MIPv6 loadable module named mip6. Here is a modprobe.conf(5) example to load it automatically when user application uses XFRM state for MIPv6: alias xfrm-type-10-43

Re: [PATCH] [XFRM]: Add module alias for transformation type.

2007-06-27 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 25 May 2007 13:23:23 +0900 Hi Ingo and all, This is the third one of MIPv6 module patch. It can be applied after two patches which are already sent to the list. Could you review it? It is clean-up for XFRM type modules and adds aliases with its

Re: resend [PATCH 1/5 2.6.21] UDP: Introduce UDP encapsulation type for L2TP

2007-06-27 Thread David Miller
From: James Chapman [EMAIL PROTECTED] Date: Sat, 26 May 2007 18:47:24 +0100 This patch adds a new UDP_ENCAP_L2TPINUDP encapsulation type for UDP sockets. When a UDP socket's encap_type is UDP_ENCAP_L2TPINUDP, the skb is delivered to a function pointed to by udp_encap_l2tp_rcv. If the skb

Re: [RFC] IPV6 checksum offloading in network devices

2007-06-27 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 30 May 2007 14:00:34 -0700 This is better. There is still a possiblity when a device allows IPV6 and not IPV4 checksumming, that the checksum will be done in the fixup code in dev_queue_xmit. The existing model for checksum offload does

Re: [RFC PATCH 0/2] dmaengine: preparation for raid acceleration

2007-06-27 Thread David Miller
From: Dan Williams [EMAIL PROTECTED] Date: Fri, 01 Jun 2007 17:17:49 -0700 Hello David, The following two patches are part of the raid acceleration series I would like to push for 2.6.23 consideration. I am sending these two separately for your review for the following reasons: the

Re: resend [PATCH 2/5 2.6.21] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-06-27 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Wed, 27 Jun 2007 00:18:24 -0700 (PDT) From: James Chapman [EMAIL PROTECTED] Date: Sat, 26 May 2007 18:47:24 +0100 Add struct sockaddr_pppol2tp to carry L2TP-specific address information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't

Re: [NET 01/05]: dev_mcast: unexport dev_mc_upload

2007-06-27 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 22 Jun 2007 14:24:07 +0200 (MEST) [NET]: dev_mcast: unexport dev_mc_upload dev_mc_add/dev_mc_delete take care of uploading the list when necessary and thats the only interface other code should use. Also remove two incorrect calls in

Re: [NET 02/05]: dev: introduce generic net_device address lists

2007-06-27 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 22 Jun 2007 14:24:09 +0200 (MEST) [NET]: dev: introduce generic net_device address lists Introduce struct dev_addr_list and list maintenance functions based on dev_mc_list and the related functions. This will be used by follow-up patches

Re: [NET 03/05]: dev_mcast: switch to generic net_device address lists

2007-06-27 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 22 Jun 2007 14:24:10 +0200 (MEST) [NET]: dev_mcast: switch to generic net_device address lists Use generic net_device address lists for multicast list handling. Some defines are used to keep drivers working. Signed-off-by: Patrick McHardy

Re: [NET 04/05]: dev: secondary unicast address support

2007-06-27 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 22 Jun 2007 14:24:12 +0200 (MEST) [NET]: dev: secondary unicast address support Add support for configuring secondary unicast addresses on network devices. To support this devices capable of filtering multiple unicast addresses need to

Re: [NET 04/05]: dev: secondary unicast address support

2007-06-27 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 27 Jun 2007 10:30:09 +0200 David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 22 Jun 2007 14:24:12 +0200 (MEST) [NET]: dev: secondary unicast address support Add support for configuring secondary unicast

Re: [PATCH 1/5 2.6.22-rc6] UDP: Introduce UDP encapsulation type for L2TP

2007-06-27 Thread David Miller
From: James Chapman [EMAIL PROTECTED] Date: Wed, 27 Jun 2007 23:20:38 +0100 This patch adds a new UDP_ENCAP_L2TPINUDP encapsulation type for UDP sockets. When a UDP socket's encap_type is UDP_ENCAP_L2TPINUDP, the skb is delivered to a function pointed to by the udp_sock's encap_rcv funcptr.

Re: [PATCH 2/5 2.6.22-rc6] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-06-27 Thread David Miller
From: James Chapman [EMAIL PROTECTED] Date: Wed, 27 Jun 2007 23:20:38 +0100 Add struct sockaddr_pppol2tp to carry L2TP-specific address information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't use the union inside struct sockaddr_pppox because the L2TP-specific data is larger than

Re: [PATCH 3/5 2.6.22-rc6] L2TP: PPP over L2TP driver core

2007-06-27 Thread David Miller
From: James Chapman [EMAIL PROTECTED] Date: Wed, 27 Jun 2007 23:20:38 +0100 This driver handles only L2TP data frames; control frames are handled by a userspace application. It implements L2TP using the PPPoX socket family. There is a PPPoX socket for each L2TP session in an L2TP tunnel. PPP

Re: [PATCH 4/5 2.6.22-rc6] L2TP: Add PPPoL2TP maintainer

2007-06-27 Thread David Miller
From: James Chapman [EMAIL PROTECTED] Date: Wed, 27 Jun 2007 23:20:38 +0100 Signed-off-by: James Chapman [EMAIL PROTECTED] Patch applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 5/5 2.6.22-rc6] L2TP: Add PPPoL2TP in-kernel documentation

2007-06-27 Thread David Miller
From: James Chapman [EMAIL PROTECTED] Date: Wed, 27 Jun 2007 23:20:38 +0100 Signed-off-by: James Chapman [EMAIL PROTECTED] Also applied, thanks a lot. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] NET: Multiqueue network device support.

2007-06-27 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Wed, 27 Jun 2007 18:32:45 -0400 On Tue, 2007-26-06 at 13:57 -0700, David Miller wrote: From: jamal [EMAIL PROTECTED] Date: Tue, 26 Jun 2007 09:27:28 -0400 Back to the question: Do you recall how this number was arrived at? 128 packets

Re: [PATCH] NET: Multiqueue network device support.

2007-06-27 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Wed, 27 Jun 2007 20:15:47 -0400 On Wed, 2007-27-06 at 15:54 -0700, David Miller wrote: The thing that's really important is that the value is not so large such that the TX ring can become empty. In the case of batching, varying the values makes

Re: a maze of twisty stats, most different

2007-06-28 Thread David Miller
From: David Stevens [EMAIL PROTECTED] Date: Thu, 28 Jun 2007 11:17:51 -0700 Comments? I think sysfs is a better model for MIBs, the extensibility we get for free since each SNMP MIB entry we want to add is simply a new file. I'd be quite thrilled to apply a patch which implemented this. - To

Re: [PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-28 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Thu, 28 Jun 2007 15:32:40 -0400 Patrick McHardy wrote: Yes, but there are users that don't go through qdiscs, like netpoll, Having them check the QDISC_RUNNING bit seems ugly. Is netpoll the only such user? netpoll tends to be a special case in

Re: git-net, git-netdev-all and everything else on g5

2007-06-28 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Fri, 29 Jun 2007 03:18:31 +0800 On Thu, Jun 28, 2007 at 09:13:38AM +, Andrew Morton wrote: With the full -mm lineup, my tg3-using powerpc g5 spits lots of these: windfarm: Drive bay control loop started. audit(1183017094.732:2):

Re: [PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-28 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Thu, 28 Jun 2007 16:08:43 -0700 Thanks Patrick for taking care of this. I am totally fine with this patch; if anyone else has feedback, please send it. If not, I'm excited to see if these can be considered for 2.6.23 now. :) Thanks

Re: [PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-28 Thread David Miller
From: PJ Waskiewicz [EMAIL PROTECTED] Date: Thu, 28 Jun 2007 09:21:13 -0700 -struct net_device *alloc_netdev(int sizeof_priv, const char *name, - void (*setup)(struct net_device *)) +struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name, + void

Re: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-28 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 28 Jun 2007 21:24:37 +0200 Waskiewicz Jr, Peter P wrote: [...] The only reasonable thing it can do is not care about multiqueue and just dequeue as usual. In fact I think it should be an error to configure multiqueue on a non-root qdisc.

Re: [GIT PATCHES] SCTP fixes

2007-06-28 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Thu, 28 Jun 2007 10:34:57 -0400 Hi David Please pull the following changes: The following changes since commit 19e6454ca778e11e81497bd87c930dc0defd03d7: David Howells (1): [AF_RXRPC]: Return the number of bytes buffered in

Re: Multiqueue and virtualization WAS(Re: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-29 Thread David Miller
This conversation begins to go into a pointless direction already, as I feared it would. Nobody is going to configure bridges, classification, tc, and all of this other crap just for a simple virtualized guest networking device. It's a confined and well defined case that doesn't need any of

Re: Multiqueue and virtualization WAS(Re: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-29 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Fri, 29 Jun 2007 21:30:53 -0400 On Fri, 2007-29-06 at 14:31 -0700, David Miller wrote: Maybe for the control node switch, yes, but not for the guest network devices. And that is precisely what i was talking about - and i am sure thats how

Re: Multiqueue and virtualization WAS(Re: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-30 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Sat, 30 Jun 2007 10:52:44 -0400 On Fri, 2007-29-06 at 21:35 -0700, David Miller wrote: Awesome, but let's concentrate on the client since I can actually implement and test anything we come up with :-) Ok, you need to clear one premise for me

Re: [NET]: Fix secondary unicast/multicast address count maintenance

2007-06-30 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Sat, 30 Jun 2007 18:46:29 +0200 Fix a bug introduced by the secondary unicast address patches. Applied, thanks Patrick. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 07/12] use a dynamic pool of sk_buffs to keep up with fast targets

2007-07-02 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Mon, 2 Jul 2007 21:36:36 -0700 My initial thought is that if there is a legitimate need for this new capability then it should be made available to other parts of the kernel rather than being private to the AEO driver. Absolutely. We even used to

Re: [PATCH 8/9] [TCP]: Reduce sacked_out with reno when purging write_queue

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:36:01 +0300 Previously TCP had a transitional state during which reno counted segments that are already below the current window into sacked_out, which is now prevented. Re-try now unconditional S+L catching (I wonder if we could

Re: [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 31 May 2007 19:31:21 +0300 (EEST) (i.e, how does it show up in oops if tcp_verify_left_out looks like this): #define tcp_verify_left_out(tp) BUG_ON(...) ...does it still point to the tcp.h line then or to the tcp_sync_left_out(tp) @

Re: Suspicious fackets_out handling

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 1 Jun 2007 15:17:00 +0300 (EEST) On Thu, 31 May 2007, David Miller wrote: Is it possible to update fastpath_cnt_hint properly perhaps? I think that would be valid and even accurate as it can checks skb's seq against fastpath_skb_hint-seq

Re: [PATCH tcp-2.6 1/3] [TCP]: Add tcp_dec_pcount_approx int variant

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 15 Jun 2007 14:10:28 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied to tcp-2.6 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH] [TCP]: Fix logic breakage due to DSACK separation

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 16 Jun 2007 02:04:25 +0300 (EEST) There are still some things I must think carefully in sacktag processing since it does not validate start_seq and end_seq at all which can be abused currently at least in tcp-2.6. ...I would rather put end to

Re: [PATCH] mac80211: Set low initial rate in rc80211_simple

2007-07-02 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Mon, 11 Jun 2007 21:24:11 -0400 From: Larry Finger [EMAIL PROTECTED] The initial rate for STA's using rc80211_simple is set to the last rate in the rate table. For situations for which the signal is weak, the rate may be too high for

Re: [PATCH] mac80211: Add support for SIOCGIWRATE ioctl to provide rate information

2007-07-02 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Mon, 11 Jun 2007 21:23:19 -0400 From: Larry Finger [EMAIL PROTECTED] At present, transmission rate information for mac80211 is available only if verbose debugging is turned on, and then only in the logs. This patch implements the SIOCGIWRATE

Re: [PATCH] pktgen IPSEC 1/4: Centralize pktgen packet overhead management

2007-07-02 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 12 Jun 2007 08:00:28 -0400 commit 38477d7ddfa58f58cce99bc902b4c18883647a71 Author: Jamal Hadi Salim [EMAIL PROTECTED] Date: Tue Jun 12 06:43:00 2007 -0400 [PKTGEN] Centralize packet overhead tracking Track the extra packet overhead for

Re: Resend: [PATCH] pktgen IPSEC 3/4: Introduce xfrm SAD only lookup

2007-07-02 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 12 Jun 2007 19:06:03 -0400 commit 4fe3190756589ef8155eb97fe725f2564f1fc77d Author: Jamal Hadi Salim [EMAIL PROTECTED] Date: Tue Jun 12 12:35:39 2007 -0400 [XFRM] Introduce standalone SAD lookup This allows other in-kernel functions to do

Re: Resend: [PATCH] pktgen IPSEC 4/4: Add IPSEC support to pktgen

2007-07-02 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 12 Jun 2007 19:08:39 -0400 commit bfd389bba7654aa118f0949ff0de45a3bce9700c Author: Jamal Hadi Salim [EMAIL PROTECTED] Date: Tue Jun 12 18:59:33 2007 -0400 [PKTGEN] IPSEC support Added transport mode ESP support for starters. I will

Re: [NET_SCHED 01/04]: Remove CONFIG_NET_ESTIMATOR option

2007-07-02 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 17:02:19 +0200 (MEST) [NET_SCHED]: Remove CONFIG_NET_ESTIMATOR option The generic estimator is always built in anways and all the config options does is prevent including a minimal amount of code for setting it up. Additionally

Re: [NET_SCHED 02/04]: Remove unnecessary stats_lock pointers

2007-07-02 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 17:02:21 +0200 (MEST) [NET_SCHED]: Remove unnecessary stats_lock pointers Remove stats_lock pointers from qdisc-internal structures, in all cases it points to dev-queue_lock. The only case where it is necessary is for top-level

Re: [NET_SCHED 03/04]: sch_htb: use generic estimator

2007-07-02 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 23:22:06 +0200 [NET_SCHED]: sch_htb: use generic estimator Use the generic estimator instead of reimplementing (parts of) it. For compatibility always create a default estimator for new classes. Signed-off-by: Patrick McHardy

Re: [NET_SCHED 04/04]: Remove unnecessary includes

2007-07-02 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 17:02:23 +0200 (MEST) [NET_SCHED]: Remove unnecessary includes Signed-off-by: Patrick McHardy [EMAIL PROTECTED] There was a minor conflict with the multi-queue patches but it was line number noise so I took care of it. Applied,

Re: [PATCH] Allow group ownership of TUN/TAP devices (fwd)

2007-07-02 Thread David Miller
From: Jeff Dike [EMAIL PROTECTED] Date: Thu, 21 Jun 2007 10:59:11 -0400 On Mon, Jun 18, 2007 at 10:36:54PM -0700, David Miller wrote: This patch looks fine. I'd like it resubmitted with a proper changelog and signoff, and once I have that I will thus queue it up for the 2.6.23 merge

Re: [PATCH 1/4] [IrDA] Netlink layer

2007-07-02 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 02 Jul 2007 01:14:28 +0300 First IrDA configuration netlink layer implementation. Currently, we only support the set/get mode commands. Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] Patch applied, thanks. - To unsubscribe from this list: send the line

Re: [PATCH 2/4] [IrDA] Monitor mode

2007-07-02 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 02 Jul 2007 01:14:29 +0300 Through the IrDA netlink set mode command, we switch to IrDA monitor mode, where one IrLAP instance receives all the packets on the media, without ever responding to them. Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] Applied,

Re: [PATCH 3/4] [IrDA] kingsun-sir.c charset fix

2007-07-02 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 02 Jul 2007 01:14:30 +0300 Cc: Alex Villacís Lasso [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 4/4] [IrDA] tsap init routine factorisation

2007-07-02 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 02 Jul 2007 01:14:31 +0300 This patch extracts common code from irttp_open_tsap() and irttp_dup() into a new function to 1) avoid code duplication, 2) help avoid forgetting object initialization in the tsap duplication path in the future. Signed-off-by:

Re: [PATCH] [TCP]: Fix logic breakage due to DSACK separation

2007-07-03 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Tue, 3 Jul 2007 13:52:35 +0300 (EEST) 1. fack_count in skb (your proposal months ago) + Trivial arithmetics, no walking necessary to find it (ever) - Very expensive in storage wise (like you have stated earlier) We have a 4-byte hole in

Re: [WIP][PATCHES] Network xmit batching - tg3 support

2007-07-03 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 03 Jul 2007 09:09:48 -0400 [It sounds very dangerous to me the way skb-cb is being used by the vlan code (i.e requires human intervention/knowledge to catch it as an issue). I had no freaking idea the vlan code was using it. Maybe a huge comment

Re: [GIT PATCHES]: Crit SCTP updates

2007-07-03 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Tue, 3 Jul 2007 15:52:38 -0400 This is a pull request for some critical SCTP fixes that I just pushed out. The fix some important issues and I think should be candidates for stable. Thanks Vlad I'll pull this in and push to Linus as soon as I get a

Re: [PATCH] Re: [NETPOLL] netconsole: fix soft lockup when removing module

2007-07-04 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Wed, 4 Jul 2007 08:41:59 +0200 On Mon, Jul 02, 2007 at 09:52:26AM +0200, Jarek Poplawski wrote: From my recent patch: #1 Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work() required a work function should

Re: [PATCH 1/2][IPV6] addrconf: fix timer deleting on exit

2007-07-05 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Thu, 5 Jul 2007 13:12:46 +0200 It looks like a timer function can be running and rearm the timer after removing a ipv6 module. Signed-off-by: Jarek Poplawski [EMAIL PROTECTED] This is completely academic as ipv6 as a module cannot be removed,

Re: [RFC 2/2] shrink size of scatterlist on common i386/x86-64

2007-07-05 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 05 Jul 2007 16:14:14 -0700 The scatterlist only needs 16 bits for length/offset because PAGE_SIZE is 4K Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Unfortunately I don't think this can be done, even on i386. It is legal to use

Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code

2007-07-05 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 05 Jul 2007 18:45:02 +0200 James Chapman wrote: This cleanup fell out after adding L2TP support where a new encap_rcv funcptr was added to struct udp_sock. Have XFRM use the new encap_rcv funcptr, which allows us to move the XFRM encap

Re: [2.6 patch] net/core/netevent.c should #include net/netevent.h

2007-07-05 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Fri, 6 Jul 2007 01:22:17 +0200 Every file should include the headers containing the prototypes for its global functions. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied, thanks Adrian. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] IPV6: Call inet6addr_chain notifiers on link down

2007-07-05 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Tue, 03 Jul 2007 10:57:32 -0400 Currently if the link is brought down via ip link or ifconfig down, the inet6addr_chain notifiers are not called even though all the addresses are removed from the interface. This caused SCTP to add duplicate

Re: [PATCH] skbuff: remove export of static symbol

2007-07-05 Thread David Miller
From: Johannes Berg [EMAIL PROTECTED] Date: Thu, 05 Jul 2007 11:33:01 +0200 skb_clone_fraglist is static so it shouldn't be exported. Signed-off-by: Johannes Berg [EMAIL PROTECTED] Patch applied, thanks! - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [RFC 2/2] shrink size of scatterlist on common i386/x86-64

2007-07-05 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 5 Jul 2007 17:00:51 -0700 On Thu, 05 Jul 2007 16:43:08 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 05 Jul 2007 16:14:14 -0700 The scatterlist only needs 16 bits for length

-ENOCOMPILE

2007-07-05 Thread David Miller
Vlad, you're on my shit list for the next week for submitting a patch to the 2.6.22 tree which won't even compile: net/ipv6/addrconf.c: In function $,1rx(Baddrconf_ifdown$,1ry(B: net/ipv6/addrconf.c:2475: error: $,1rx(Bifp$,1ry(B undeclared (first use in this function)

Re: [RFC 2/2] shrink size of scatterlist on common i386/x86-64

2007-07-06 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Fri, 06 Jul 2007 17:43:46 +1000 On Thu, 2007-07-05 at 17:15 -0700, David Miller wrote: Also even with the scatterlist idea, we'd still need to do two map calls, one for skb-data and one for the page vector. We could make skb-shinfo(skb)-frags[0

Re: [RFC 2/2] shrink size of scatterlist on common i386/x86-64

2007-07-06 Thread David Miller
From: Williams, Mitch A [EMAIL PROTECTED] Date: Fri, 6 Jul 2007 10:14:56 -0700 In my opinion, IOMMU table locking is the major issue with this type of architecture. Since both Intel and AMD are touting IOMMUs for virtual- ization support, this is an issue that's going to need a lot of

<    1   2   3   4   5   6   7   8   9   10   >