Re: IP1000 gigabit nic driver

depending on how horrific the code looks on closer inspection. Not got a whole lot of time to do this so no timescale for completion... David Vrabel - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: IP1000 gigabit nic driver

Pekka Enberg wrote: I ended up doing most of them myself [1]. Sorry :-) Are the datasheets public by the way? http://www.icplus.com.tw/Data/Datasheet/IP1000A-DS-R08-07052005.pdf 1. http://www.cs.helsinki.fi/u/penberg/linux/ip1000-driver.patch - To unsubscribe from this list: send the

Re: IP1000 gigabit nic driver

-- ipg_remove() now works. - Move PHY and MAC address initialization into the ipg_probe(). It was previously filling in the MAC address on open which breaks some user space. - Folded ipg_nic_init into ipg_probe since it was broke otherwise. Signed-off-by: David Vrabel [EMAIL PROTECTED] Index

Re: IP1000 gigabit nic driver

Lennert Buytenhek wrote: On Mon, May 01, 2006 at 10:38:47PM +0200, Francois Romieu wrote: -/* Minimum number of miliseconds used to toggle MDC clock during +/* Minimum number of nanoseconds used to toggle MDC clock during * MII/GMII register access. */ -#define IPG_PC_PHYCTRLWAIT

Re: IP1000 gigabit nic driver

email found in the original mail) is out of date so if anyone knows how to reach him, please let me know. Thanks! I think/guess that IC Plus bought out Sundance so you'd need to contact someone at IC Plus. David Vrabel - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 2/2] ipg: redundancy with mii.h

Francois Romieu wrote: ipg: remove forward declarations It makes no sense in a new driver. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Ack. ipg: replace #define with enum Added some underscores to improve readability. Signed-off-by: Francois

Re: [PATCH 2/2] ipg: redundancy with mii.h

Vrabel ipg: initialize Rx buffers correctly A previous patch resulted in the initialization of the Rx buffers being skipped. Signed-off-by: David Vrabel [EMAIL PROTECTED] --- linux-source-2.6.16.orig/drivers/net/ipg.c 2006-05-20 21:38:44.604788258 +0100 +++ linux-source-2.6.16/drivers/net/ipg.c

Re: Integrating IXP4xx NPE support in kernel (with IXP4xx accesslibrary)

into the kernel. The above mentioned bits for eCos/RedBoot would probably be a good starting point. David Vrabel ps. It's bad form to CC a subscription-only list. I've trimmed linux-arm-kernel from the CCs. -- David Vrabel, Design Engineer Arcom, Clifton Road Tel: +44 (0)1223 411200 ext. 3233

Re: [PATCH] xen-netfront: Remove the meaningless code

On 27/06/15 00:17, Liang Li wrote: The function netif_set_real_num_tx_queues() will return -EINVAL if the second parameter 1, so call this function with the second parameter set to 0 is meaningless. Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list

Re: [Xen-devel] [PATCH v2 0/7] xen: Clean up

On 17/06/15 15:28, Julien Grall wrote: Hi, Thoses patches was originally part of the Xen 64KB series [1]. Although, I think they can go without waiting the rest of the 64KB series. Patch #1-#4 should go through the Xen tree, even though patch #1 touches multiple part. Patch #5-#7

Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

On 04/06/15 13:45, Julien Grall wrote: On 03/06/15 18:06, Joe Perches wrote: On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: rx-status is an int16_t, print it using %d rather than %u in order to have a meaningful value when the field is negative. [] diff --git

Re: [PATCH net] xen: netback: read hotplug script once at start of day.

On 29/05/15 17:24, Ian Campbell wrote: --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -235,6 +235,7 @@ static int netback_remove(struct xenbus_device *dev) kobject_uevent(dev-dev.kobj, KOBJ_OFFLINE);

[PATCHv1] xen-netfront: properly destroy queues when removing device

. Signed-off-by: David Vrabel david.vra...@citrix.com --- drivers/net/xen-netfront.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 3f45afd..e031c94 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: Hi all, I'm experiencing xen-netfront crash when doing xl network-detach while some network activity is going on at the same time. It happens only when domU has more than one vcpu. Not sure if this matters, but the backend is in another

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

On 22/05/15 17:42, Marek Marczykowski-Górecki wrote: On Fri, May 22, 2015 at 05:25:44PM +0100, David Vrabel wrote: On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: Hi all, I'm experiencing xen-netfront crash when doing xl network-detach while some network activity is going on at the same

Re: xen-netfront crash when detaching network while some network activity

the queues (which includes deleting the napi instances) before freeing the netdevice. Reported-by: Marek Marczykowski marma...@invisiblethingslab.com Signed-off-by: David Vrabel david.vra...@citrix.com --- drivers/net/xen-netfront.c | 15 ++- 1 file changed, 2 insertions(+), 13

Re: [Xen-devel] [PATCH v3 17/20] net/xen-netfront: Make it running on 64KB page granularity

of 4KB. The rest of the code is relying on the grant table code. Note that we allocate a Linux page for each rx skb but only the first 4KB is used. We may improve the memory usage by extending the size of the rx skb. Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

On 29/07/15 12:35, Julien Grall wrote: Hi Wei, On 29/07/15 11:13, Wei Liu wrote: On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: [...] diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7d50711..3b7b7c3 100644 ---

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

patches. I think it may be possible to do further clean up in the x86 code to ensure that helpers returning machine address (such as virt_address) is not used by no auto-translated guests. I will let x86 xen expert doing it. Reviewed-by: David Vrabel david.vra...@citrix.com It looks a bit odd

Re: [Xen-devel] [PATCH v3] xen-apic: Enable on domU as well

On 10/08/15 14:40, Jason A. Donenfeld wrote: It turns out that domU also requires the Xen APIC driver. Otherwise we get stuck in busy loops that never exit, such as in this stack trace: Applied to for-linus-4.2 and tagged for stable, thanks. David -- To unsubscribe from this list: send the

Re: [Xen-devel] [PATCH v3 0/9] Use correctly the Xen memory terminologies

On 07/08/15 17:34, Julien Grall wrote: Hi all, This patch series aims to use the memory terminologies described in include/xen/mm.h [1] for Linux xen code. Applied to for-linus-4.3, thanks. David -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [Xen-devel] printk from softirq on xen: hard lockup

On 05/08/15 00:01, Jason A. Donenfeld wrote: Hey David, Sorry for the premature response on my phone earlier. Real reply follows. rcu_read_lock, when using Xen PV. Relevant excerpts of the ^^ PV guest? Yes. The lockup occurs on a PV guest. Nothing special

Re: [Xen-devel] printk from softirq on xen: hard lockup

On 04/08/15 17:41, Jason A. Donenfeld wrote: Hi folks, Paul McKenney and I had an offline discussion about some rcu questions that eventually lead into me investigating a strange full lock-up I'm experiencing as a consequence of a printk in softirq inside of an rcu_read_lock, when using Xen

Re: [PATCH v3] xen-apic: Enable on domU as well

On 10/08/15 14:40, Jason A. Donenfeld wrote: It turns out that domU also requires the Xen APIC driver. Otherwise we get stuck in busy loops that never exit, such as in this stack trace: What's the difference between v3 and v2? David -- To unsubscribe from this list: send the line unsubscribe

Re: [Xen-devel] printk from softirq on xen: hard lockup

On 06/08/15 16:58, Jason A. Donenfeld wrote: On Thu, Aug 6, 2015 at 12:02 PM, David Vrabel david.vra...@citrix.com wrote: Linux PV guests must use the Xen PV APIC driver. You need to investigate why your PV guest is not using this (although I'm surprised it works at all with the wrong one

Re: [Xen-devel] [PATCH net-next 0/8] xen-netback/core: packet hashing

On 24/10/15 12:55, David Miller wrote: > From: Paul Durrant > Date: Wed, 21 Oct 2015 11:36:17 +0100 > >> This series adds xen-netback support for hash negotiation with a frontend >> driver, and an implementation of toeplitz hashing as the initial negotiable >> algorithm.

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

On 21/10/15 19:57, Marek Marczykowski-Górecki wrote: > > Any ideas? No, sorry. Netfront looks correct to me. We take an additional ref for the ref released by gnttab_release_grant_reference(). The get_page() here is safe since we haven't freed the page yet (this is done in the subsequent call

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

On 16/10/15 10:05, Wei Liu wrote: > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: >> I changed patch with valid format. >> >> On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: >> >>> Since vzalloc can be failed in memory pressure, >>> writes -ENOMEM to xenstore to

[PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

. Signed-off-by: David Vrabel <david.vra...@citrix.com> --- drivers/net/xen-netback/common.h | 10 -- drivers/net/xen-netback/netback.c | 23 --- 2 files changed, 16 insertions(+), 17 deletions(-) Note that this can only be backported as-is

Re: [Xen-devel] [PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

On 09/09/15 20:34, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 08, 2015 at 02:25:14PM +0100, David Vrabel wrote: >> Commit f48da8b14d04ca87ffcffe68829afd45f926ec6a (xen-netback: fix >> unlimited guest Rx internal queue and carrier flapping) introduced a >> regression. >>

Re: [Xen-devel] [PATCH net v3 2/2] xen-netfront: respect user provided max_queues

On 10/09/15 11:18, Wei Liu wrote: > Originally that parameter was always reset to num_online_cpus during > module initialisation, which renders it useless. > > The fix is to only set max_queues to num_online_cpus when user has not > provided a value. Reviewed-by: David Vr

Re: [PATCH net v2 2/2] xen-netfront: respect user provided max_queues

On 09/09/15 11:23, Wei Liu wrote: > Originally that parameter was always reset to num_online_cpus during > module initialisation, which renders it useless. > > The fix is to only set max_queues to num_online_cpus when user has not > provided a value. Reviewed-by: David Vr

Re: [PATCH net] xen-netback: respect user provided max_queues

nsigned int xenvif_max_queues = 0; You don't need this. Otherwise, Reviewed-by: David Vrabel <david.vra...@citrix.com> Is an equivalent fix needed in netfront? David > module_param_named(max_queues, xenvif_max_queues, uint, 0644); > MODULE_PARM_DESC(max_queues, >

Re: [Xen-devel] [PATCH net-next] xen-netfront: always set num queues if possible

On 14/09/15 22:28, Charles (Chas) Williams wrote: > The xen store preserves this information across module invocations. > If you insmod netfront with two queues and later insmod again with one > queue, the backend will still believe you asked for two queues. Can you rewrite the commit message to

Re: [Xen-devel] [PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

On 09/09/15 20:34, David Miller wrote: > From: David Vrabel <david.vra...@citrix.com> > Date: Tue, 8 Sep 2015 14:25:14 +0100 > >> Commit f48da8b14d04ca87ffcffe68829afd45f926ec6a (xen-netback: fix >> unlimited guest Rx internal queue and carrier flapping) introduced a

Re: [Xen-devel] [PATCH] xen-netfront: set real_num_tx_queues to zreo avoid to trigger BUG_ON

On 20/02/16 06:00, Gonglei (Arei) wrote: > Hi, > > Thanks for rapid feedback :) > >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Saturday, February 20, 2016 12:37 PM >> >> From: Gonglei >> Date: Sat, 20 Feb 2016 09:27:26 +0800 >> >>> It's possible for a

Re: [Xen-devel] [PATCH] xen-netfront: set real_num_tx_queues to zreo avoid to trigger BUG_ON

On 20/02/16 01:27, Gonglei wrote: > It's possible for a race condition to exist between xennet_open() and > talk_to_netback(). After invoking netfront_probe() then other > threads or processes invoke xennet_open (such as NetworkManager) > immediately may trigger BUG_ON(). Besides, we also should

[PATCHv2 net] xen-netfront: request Tx response events more often

e ring. Signed-off-by: Malcolm Crossley <malcolm.cross...@citrix.com> Signed-off-by: David Vrabel <david.vra...@citrix.com> --- v2: - Use bool. --- drivers/net/xen-netfront.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/net/xen-netfront.c

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

On 22/01/16 12:34, Wei Liu wrote: > The comment at the beginning of the file is the canonical source of > licenses for this module. Currently it contains GPL and MIT license. Fix > the code to reflect the reality. "The MIT license" isn't really a thing. The closest is the X11 license[1], but

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

On 22/01/16 14:15, Ian Campbell wrote: > On Fri, 2016-01-22 at 13:49 +, Wei Liu wrote: >> On Fri, Jan 22, 2016 at 01:14:24PM +0000, David Vrabel wrote: >>> On 22/01/16 12:34, Wei Liu wrote: >>>> The comment at the beginning of the file is the canonical source of

Re: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

On 07/07/16 11:35, Wei Liu wrote: > On Thu, Jul 07, 2016 at 10:58:16AM +0100, David Vrabel wrote: >> On 07/07/16 08:57, Jan Beulich wrote: >>> Only a positive return value indicates success. >> >> This is not correct. >> > > Do you mean the

Re: [Xen-devel] [PATCH] xen-netfront: prefer xenbus_write() over xenbus_printf() where possible

On 07/07/16 09:00, Jan Beulich wrote: > ... as being the simpler variant. It's really annoying that all these related cleanups where not in the same thread. Don't do this again, please. The better clean-up is to remove xenbus_write() in favour of xenbus_printf() everywhere (especially since one

Re: [Xen-devel] [PATCH] xen-netback: prefer xenbus_scanf() over xenbus_gather()

On 07/07/16 08:57, Jan Beulich wrote: > ... for single items being collected: It is more typesafe (as the > compiler can check format string and to-be-written-to variable match) > and requires one less parameter to be passed. Do not split commit messages between the subject and the body in this

Re: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

On 07/07/16 08:57, Jan Beulich wrote: > Only a positive return value indicates success. This is not correct. David

Re: [Xen-devel] [PATCH] xen-netfront: correct return value checks on xenbus_scanf()

On 07/07/16 08:59, Jan Beulich wrote: > Only a positive return value indicates success. This checks were already correct. David

Re: [PATCH net-next] xen-netfront: avoid packet loss when ethernet header crosses page boundary

th skb_copy(). > > Signed-off-by: Vitaly Kuznetsov <vkuzn...@redhat.com> We should probably fix the backend to handle this (by grant copying a minimum amount in the linear area, but since netfront needs to work with older netback. Acked-by: David Vrabel <david.vra...@citrix.com> David

Re: [Xen-devel] [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

g fragmented in the backend. Reviewed-by: David Vrabel <david.vra...@citrix.com> David

Re: [Xen-devel] [PATCH v2 net-next 7/7] xen/netback: add fraglist support for to-guest rx

On 04/10/16 10:29, Paul Durrant wrote: > From: Ross Lagerwall <ross.lagerw...@citrix.com> > > This allows full 64K skbuffs (with 1500 mtu ethernet, composed of 45 > fragments) to be handled by netback for to-guest rx. Reviewed-by: David Vrabel <david.vra...@citrix.com> David

Re: [Xen-devel] [PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

On 04/10/16 13:47, Konrad Rzeszutek Wilk wrote: > On Tue, Oct 04, 2016 at 10:29:16AM +0100, Paul Durrant wrote: >> From: David Vrabel <david.vra...@citrix.com> >> >> Instead of only placing one skb on the guest rx ring at a time, process >> a batch of up-to 64.

[PATCHv2] sunrpc: fix write space race causing stalls

pace(). Suggested-by: Trond Myklebust <tron...@primarydata.com> Signed-off-by: David Vrabel <david.vra...@citrix.com> --- net/sunrpc/xprtsock.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index bf16883..e

[PATCHv1] sunrpc: fix write space race causing stalls

ospace() (which is supposed to handle the above race) does not call xprt_write_space() as the SOCKWQ_ASYNC_NOSPACE bit is clear and thus the task is not woken. Fix the race by have xprt_wait_for_buffer_space() check for write space after putting the task to sleep. Signed-off-by: David Vr

Re: [PATCHv1] sunrpc: fix write space race causing stalls

On 16/09/16 17:01, Trond Myklebust wrote: > >> On Sep 16, 2016, at 08:28, David Vrabel <david.vra...@citrix.com> wrote: >> >> Write space becoming available may race with putting the task to sleep >> in xprt_wait_for_buffer_space(). The existing mechanism t

Re: [PATCHv1] sunrpc: fix write space race causing stalls

On 16/09/16 18:06, Trond Myklebust wrote: > >> On Sep 16, 2016, at 12:41, David Vrabel <david.vra...@citrix.com> wrote: >> >> On 16/09/16 17:01, Trond Myklebust wrote: >>> >>>> On Sep 16, 2016, at 08:28, David Vrabel <david.vra...@citrix.com&g

Re: [PATCH net-next RESEND] xen-netfront: avoid packet loss when ethernet header crosses page boundary

On 19/09/16 11:22, Vitaly Kuznetsov wrote: > David Miller writes: > >> From: Vitaly Kuznetsov >> Date: Fri, 16 Sep 2016 12:59:14 +0200 >> >>> @@ -595,6 +596,19 @@ static int xennet_start_xmit(struct sk_buff *skb, >>> struct net_device *dev) >>>

Re: [Xen-devel] [PATCH net-next] xen-netfront: avoid packet loss when ethernet header crosses page boundary

On 22/08/16 16:42, Vitaly Kuznetsov wrote: > > I see two ways to fix the issue: > - Change the 'wire' protocol between netfront and netback to start keeping > the original SKB structure. We'll have to add a flag indicating the fact > that the particular request is a part of the original

Re: [PATCH 00/12] xen: add common function for reading optional value

ith the call of the new function > where appropriate. Acked-by: David Vrabel <david.vra...@citrix.com> Please queue for the next release. David

[PATCHv1 net] xen-netback: fix guest Rx stall detection (after guest Rx refactor)

are placed on the ring, permanently stalling the VIF. This is a regression introduced by eb1723a29b9a7 (xen-netback: refactor guest rx). Fix this by reinstating the setting of queue->last_rx_time when placing a packet onto the guest Rx ring. Signed-off-by: David Vrabel <david.vra...@citr