Reading through the patches they look usable to me.
Having to patch iproute to create the more interesting network
devices sucks, but that problem seems fundamental. We might
be able to avoid it if we allowed fields to be reused between
different types of devices but that makes the error
Patrick McHardy [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Reading through the patches they look usable to me.
Having to patch iproute to create the more interesting network
devices sucks, but that problem seems fundamental. We might
be able to avoid it if we allowed fields
Patrick McHardy [EMAIL PROTECTED] writes:
I still think adding a IFLA_PARTNER or a custom attribute is cleaner
in this case. Slight semantic mismatches are the worst design bugs
to correct.
Indeed, IFLA_PARTNER sounds like a better idea. I just suggested to
Pavel to create only a single
+static int rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)
+{
+ struct rtnl_link_ops *ops;
+ struct net_device *dev;
+ struct ifinfomsg *ifm;
+ char name[MODULE_NAME_LEN];
+ char ifname[IFNAMSIZ];
+ struct nlattr *tb[IFLA_MAX+1];
+ struct
Patrick McHardy [EMAIL PROTECTED] writes:
Alexey Kuznetsov wrote:
I just suggested to
Pavel to create only a single device per newlink operation and binding
them later,
I see some logical inconsistency here.
Look, the second end is supposed
Patrick McHardy [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
+if (linkinfo[IFLA_INFO_NAME]) {
+nla_strlcpy(name, linkinfo[IFLA_INFO_NAME], sizeof(name));
+ops = rtnl_link_ops_get(name);
Ugh. Shouldn't we have the request_module logic here?
Otherwise
Alexey Kuznetsov [EMAIL PROTECTED] writes:
Hello!
Good point, I didn't think of that. Is there a version of this patch
that already uses different namespaces so I can look at it?
Pavel does not like the idea. It looks not exactly pretty, like you said.
:-)
The alternative is to create
Miklos Szeredi [EMAIL PROTECTED] writes:
[CC'd Al Viro and Alan Cox, restored patch]
There are races involving the garbage collector, that can throw away
perfectly good packets with AF_UNIX sockets in them.
The problems arise when a socket goes from installed to in-flight or
vice
Patrick McHardy [EMAIL PROTECTED] writes:
These two patches contain a first short at secondary unicast address support.
I'm still working on converting macvlan as an example, but since I'm about to
leave for tonight I thougth I'd get them out for some comments now.
The patch adds two new
Patrick McHardy [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
I'm trying to understand what the point of this patch is.
In once sense I find the concept of filtering and listening for multiple
mac addresses very interesting, especially if we could break out different
streams of traffic
Ben Greear [EMAIL PROTECTED] writes:
Patrick McHardy wrote:
Eric W. Biederman wrote:
For the macvlan code do we need to do anything special if we transmit
to a mac we would normally receive? Another unicast mac of the same
nic for example.
That doesn't happen under normal circumstances
Never mind. I saw this and I thought it was an old obscure bug.
But it appears it is a new condition, that has already been
fixed.
Eric
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Currently all of the prerequisite work for implementing a network
namespace (i.e. virtualization of the network stack with one kernel)
has already been merged or is in the process of being merged.
Therefore it is now time for a bit of high level design review of
the network namespace work and
measured any performance overhead
specific to network namespace infrastructure. As code
to compile out the network namespace pointers etc is complicated
it is best to avoid that code unless that complexity is justified.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/net
Miklos Szeredi [EMAIL PROTECTED] writes:
Right. But the devil is in the details, and (as you correctly point
out later) to implement this, the whole locking scheme needs to be
overhauled. Problems:
- Using the queue lock to make the dequeue and the fd detach atomic
wrt the GC is
Patrick McHardy [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
-- The basic design
There will be a network namespace structure that holds the global
variables for a network namespace, making those global variables
per network namespace.
One of those per network namespace global
Stephen Hemminger [EMAIL PROTECTED] writes:
On Sat, 23 Jun 2007 08:20:40 -0700
Ben Greear [EMAIL PROTECTED] wrote:
Patrick McHardy wrote:
Eric W. Biederman wrote:
-- The basic design
There will be a network namespace structure that holds the global
variables for a network
Ben Greear [EMAIL PROTECTED] writes:
Patrick McHardy wrote:
Eric W. Biederman wrote:
-- The basic design
There will be a network namespace structure that holds the global
variables for a network namespace, making those global variables
per network namespace.
One of those per network
Patrick McHardy [EMAIL PROTECTED] writes:
Depending upon the data structure it will either be modified to hold
a per entry network namespace pointer or it there will be a separate
copy per network namespace. For large global data structures like
the ipv4 routing cache hash table adding an
Carl-Daniel Hailfinger [EMAIL PROTECTED] writes:
Can one namespace DoS other namespaces' access to the routing cache?
Two scenarios come to mind:
* provoking hash collisions
* lock contention (sorry, haven't checked whether/how we do locking)
My initial expectation is that the protections we
Ben Greear [EMAIL PROTECTED] writes:
Any chance it could allow one to use a single threaded, single process and do
something like
int fd1 = socket(, namespace1);
int fd2 = socket(, namespace2);
Or, maybe a sockopt or similar call to move a socket into a particular
namespace?
I
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Sat, 23 Jun 2007 11:19:34 -0600
Further and fundamentally all a global achieves is removing the need
for the noise patches where you pass the pointer into the various
functions. For long term
Jeff Garzik [EMAIL PROTECTED] writes:
David Miller wrote:
I don't accept that we have to add another function argument
to a bunch of core routines just to support this crap,
especially since you give no way to turn it off and get
that function argument slot back.
To be honest I think this
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Sat, 23 Jun 2007 16:56:49 -0600
If the only use was strong isolation which Dave complains about I would
concur that the namespace approach is inappropriate. However there are
a lot other uses
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Sat, 23 Jun 2007 15:41:16 -0600
If you want the argument to compile out. That is not a problem at all.
I dropped that part from my patch because it makes infrastructure more
complicated
Miklos Szeredi [EMAIL PROTECTED] writes:
And I think incremental GC algorithms are much too complex for this
task. What I've realized, is that in fact we don't require a generic
garbage collection algorithm, just a much more specialized cycle
collection algorithm, since refcounting in struct
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Sun, 24 Jun 2007 06:58:54 -0600
I am convinced I can keep network namespaces something that is so
trivial and obvious to get right you won't have to pay attention
to them.
Ok then, I'll hold you
Daniel Lezcano [EMAIL PROTECTED] writes:
2. People expressed concerns that complete separation of namespaces
may introduce an undesired overhead in certain usage scenarios.
The overhead comes from packets traversing input path, then output path,
then input path again in the destination
This family of containers are used too for HPC (high performance computing)
and
for distributed checkpoint/restart. The cluster runs hundred of jobs, spawning
them on different hosts inside an application container. Usually the jobs
communicates with broadcast and multicast.
Application
Herbert Poetzl [EMAIL PROTECTED] writes:
On Tue, Sep 05, 2006 at 08:45:39AM -0600, Eric W. Biederman wrote:
Daniel Lezcano [EMAIL PROTECTED] writes:
For HPC if you are interested in migration you need a separate IP
per container. If you can take you IP address with you migration
Herbert Poetzl [EMAIL PROTECTED] writes:
On Wed, Sep 06, 2006 at 11:10:23AM +0200, Daniel Lezcano wrote:
As far as I see, vserver use a layer 3 solution but, when needed, the
veth component, made by Nestor Pena, is used to provide a layer 2
virtualization. Right ?
well, no, we do not
Kir Kolyshkin [EMAIL PROTECTED] writes:
Herbert Poetzl wrote:
my point (until we have an implementation which clearly
shows that performance is equal/better to isolation)
is simply this:
of course, you can 'simulate' or 'construct' all the
isolation scenarios with kernel bridging and
Cedric Le Goater [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
hmm ? What about an MPI application ?
I would expect each MPI task to be run in its container on different nodes
or on the same node. These individual tasks _communicate_ between each
other through the MPI layer (not only
Caitlin Bestler [EMAIL PROTECTED] writes:
[EMAIL PROTECTED] wrote:
Finally, as I understand both network isolation and network
virtualization (both level2 and level3) can happily co-exist. We do
have several filesystems in kernel. Let's have several network
virtualization approaches,
Stephen Hemminger [EMAIL PROTECTED] writes:
The problem with VNIC's is it won't work for all devices (without lots of
work), and for many device's it requires putting the device in promiscuous
mode. It also plays havoc with network access control devices.
Which is fine. If it works it is a
Daniel Lezcano [EMAIL PROTECTED] writes:
IHMO, I think there is one reason. The unsharing mechanism is not only for
containers, its aim other kind of isolation like a bsdjail for example. The
unshare syscall is flexible, shall the network unsharing be one-block
solution ?
For example, we
Herbert Poetzl [EMAIL PROTECTED] writes:
On Thu, Sep 07, 2006 at 08:23:53PM +0400, Kirill Korotaev wrote:
well, who said that you need to have things like RAW sockets
or other protocols except IP, not to speak of iptable and
routing entries ...
folks who _want_ full network virtualization
Herbert Poetzl [EMAIL PROTECTED] writes:
On Sat, Sep 09, 2006 at 11:57:24AM +0400, Dmitry Mishin wrote:
On Friday 08 September 2006 22:11, Herbert Poetzl wrote:
actually the light-weight ip isolation runs perfectly
fine _without_ CAP_NET_ADMIN, as you do not want the
guest to be able to
Dmitry Mishin [EMAIL PROTECTED] writes:
On Sunday 10 September 2006 07:41, Eric W. Biederman wrote:
I certainly agree that we are not at a point where a final decision
can be made. A major piece of that is that a layer 2 approach has
not shown to be without a performance penalty
Dmitry Mishin [EMAIL PROTECTED] writes:
On Sunday 10 September 2006 06:47, Herbert Poetzl wrote:
well, I think it would be best to have both, as
they are complementary to some degree, and IMHO
both, the full virtualization _and_ the isolation
will require a separate namespace to work,
Dmitry Mishin [EMAIL PROTECTED] writes:
On Monday 11 September 2006 18:57, Herbert Poetzl wrote:
I completely agree here, we need a separate namespace
for that, so that we can combine isolation and virtualization
as needed, unless the bind restrictions can be completely
expressed with an
Jesse Brandeburg [EMAIL PROTECTED] writes:
On 9/28/06, Sukadev Bhattiprolu [EMAIL PROTECTED] wrote:
$ cat /proc/interrupts
CPU0 CPU1
28: 0 0 IO-APIC-fasteoi eth0
NMI: 96 35
LOC: 18251 18524
ERR: 0
you should be
Dmitry Mishin [EMAIL PROTECTED] writes:
Added functions and macros required to operate with network namespaces.
They are required in order to switch network namespace for incoming packets
and
to not extend current network interface by additional network namespace argue.
Is exec_net only
CC list trimmed.
H. Peter Anvin [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
- Removal of sys_sysctl support where people had used conflicting sysctl
numbers. Trying to break glibc or other applications by changing the
ABI is not cool. 9 instances of this in the kernel seems
H. Peter Anvin [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
I think it would be fair to say that if they're not in linux/sysctl.h
they're
not architectural, but that doesn't resolve the counterpositive (are there
sysctls in linux/sysctl.h which aren't architectural? From the looks
H. Peter Anvin [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
With architectural I mean guaranteed to be stable (as opposed to
incidental). Sorry for the confusion.
Ok. Then largely we are in agreement. To implement that the rule is simple.
If it isn't CTL_UNNUMBERED and the number
Dmitry Mishin [EMAIL PROTECTED] writes:
On Wednesday 17 January 2007 23:16, Eric W. Biederman wrote:
Dmitry Mishin [EMAIL PROTECTED] writes:
Added functions and macros required to operate with network namespaces.
They are required in order to switch network namespace for incoming packets
Stephen Hemminger [EMAIL PROTECTED] writes:
On Wed, 17 Jan 2007 19:11:52 +0300
Dmitry Mishin [EMAIL PROTECTED] wrote:
Library function to create a seq_file in proc filesystem,
showing some information for each netdevice.
This code is present in the kernel in about 10 instances, and
all of
YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] writes:
In article [EMAIL PROTECTED] (at Wed, 17 Jan 2007 18:51:14
+0300), Dmitry Mishin [EMAIL PROTECTED] says:
===
L2 network namespaces
The most straightforward concept of network virtualization is complete
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Since the binary sysctl numbers are unique putting the registered
sysctls at the head of the sysctl list where they can override
existing sysctls serves no useful purpose.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/frv/kernel
There has not been much maintenance on sysctl in years, and as a result is
there is a lot to do to allow future interesting work to happen, and being
ambitious I'm trying to do it all at once :)
The patches in this series fall into several general categories.
- Removal of useless attempts to
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/net/wireless/arlan-proc.c |2 +-
include/linux/sysctl.h|1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/arlan-proc.c
b
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
We need to have the the definition of all top level sysctl
directories registers in sysctl.h so we don't conflict by
accident and cause abi problems.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/s390/appldata/appldata.h |3
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
The sysctl numbers used are unique so setting the insert_at_head
flag serves no semantis purpose, and is just confusing.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/llc/sysctl_net_llc.c |2 +-
1 files changed, 1 insertions
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/scsi/scsi_sysctl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/scsi_sysctl.c b/drivers/scsi/scsi_sysctl.c
index 04d06c2..b16b775 100644
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/linux/sysctl.h |2 ++
kernel/sysctl.c| 10 +-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
The sysctl numbers used are unique so setting the insert_at_head
flag serves no semantic purpose, so it is just confusing.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/netrom/sysctl_net_netrom.c |2 +-
1 files changed, 1
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
This is just a simple cleanup to keep kernel/sysctl.c
from getting to crowded with special cases, and by
keeping all of the ipc logic to together it makes
the code a little more readable.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/parport/procfs.c | 264 +-
1 files changed, 189 insertions(+), 75 deletions(-)
diff --git a/drivers/parport/procfs.c b/drivers/parport
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
This is just a simple cleanup to keep kernel/sysctl.c
from getting to crowded with special cases, and by
keeping all of the utsname logic to together it makes
the code a little more readable.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Putting ntfs-debug under FS_NRINODE was not a kosher thing to do
so don't give it any binary number.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
fs/ntfs/sysctl.c | 24
1 files changed, 16 insertions(+), 8
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/x86_64/mm/init.c | 22 --
1 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/arch/x86_64/mm/init.c b/arch/x86_64/mm/init.c
index 65aa66c..a04535d
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
parse_table has support for calling a strategy routine
when descending into a directory. To date no one has
used this functionality and the /proc/sys interface has
no analog to it.
So no one is using this functionality kill it and make
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
ocfs2 was did not have the binary number it uses under CTL_FS
registered in sysctl.h. Register it to avoid future conflicts,
and change the name of the definition to be in line with the
rest of the sysctl numbers.
Signed-off-by: Eric W
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
fs/xfs/linux-2.6/xfs_sysctl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_sysctl.c b/fs/xfs/linux-2.6/xfs_sysctl.c
index af24653..af777e9
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/dccp/sysctl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c
index fdcfca3..3391631 100644
--- a/net/dccp/sysctl.c
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/ax25/sysctl_net_ax25.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ax25/sysctl_net_ax25.c b/net/ax25/sysctl_net_ax25.c
index d23a27f..afdba04 100644
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/appletalk/sysctl_net_atalk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/appletalk/sysctl_net_atalk.c b/net/appletalk/sysctl_net_atalk.c
index 40b0af7
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
With unique binary numbers setting insert_at_head to
insert yourself at the head of sysctl list and thus override
existing sysctl entries serves no point.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/frv/kernel/pm.c |2
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
With unique sysctl binary numbers setting insert_at_head is pointless.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/macintosh/mac_hid.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
The sysctls used by the md driver are have unique binary numbers
so remove the insert_at_head flag as it serves no useful purpose.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/md/md.c |2 +-
1 files changed, 1 insertions
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
The sysctl numbers used are unique so setting the insert_at_head
flag serves no semantic purpose.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/rose/sysctl_net_rose.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
The sysctl numbers used are unique so setting the insert_at_head
flag servers no semantic purpose and is just confusing.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/ipx/sysctl_net_ipx.c |2 +-
1 files changed, 1 insertions
Since x25 uses unique binary numbers inserting yourself at the
head of the search list for sysctls so you can override already
registered sysctls is pointless.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/x25/sysctl_net_x25.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
With unique binary sysctl numbers setting insert_at_head to
override other sysctl entries is pointless.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/cdrom/cdrom.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
And make the mode of the kernel directory 0555 no one is allowed
to write to sysctl directories.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/ppc/kernel/ppc_htab.c | 11 ---
1 files changed, 8 insertions(+), 3
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
The sysctl numbers used are unique so setting the insert_at_head
flag does not succeed in overriding any sysctls, and is just
confusing because it doesn't. Clear the flag.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/decnet
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
This was partially done already and there was no ABI breakage what
a relief.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/powerpc/kernel/idle.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
With unique sysctl binary numbers setting insert_at_head is pointless.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/char/ipmi/ipmi_poweroff.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
In the binary sysctl interface the hpet driver was claiming to
be the cdrom driver. This is a no-no so remove support for the
binary interface.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/char/hpet.c |4 ++--
1 files
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Basically everything was done but I removed all element
initializers from the trailing entries to make it clear
the entire last entry should be zero filled.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/x86_64/kernel/vsyscall.c
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/frv/kernel/pm.c |1 -
include/linux/sysctl.h |1 +
2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/frv/kernel/pm.c b/arch/frv/kernel/pm.c
index ee677ce
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
init/main.c |3 +++
kernel/sysctl.c |3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/init/main.c b/init/main.c
index 8b4a7d7..8af5c6e 100644
--- a/init
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/frv/kernel/sysctl.c |1 -
include/linux/sysctl.h |1 +
2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/frv/kernel/sysctl.c b/arch/frv/kernel/sysctl.c
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/linux/sunrpc/debug.h |1 -
include/linux/sysctl.h |3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/sunrpc/debug.h b/include/linux
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
The only sysctl x86_64 provides are not provided elsewhere,
so insert_at_head is unnecessary.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/x86_64/ia32/ia32_binfmt.c |2 +-
arch/x86_64/mm/init.c |2 +-
2 files
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/x86_64/ia32/ia32_binfmt.c | 30 --
1 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/arch/x86_64/ia32/ia32_binfmt.c b/arch/x86_64/ia32
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
There are currently no users in the kernel for CTL_ANY and it
only has effect on the binary interface which is practically
unused.
So this complicates sysctl lookups for no good reason so just remove it.
Signed-off-by: Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
There is no need for open files in /proc/sys/XXX to hold
a reference count on the module that provides the file
to prevent module unload races. While there is code active
in the module p-used in the sysctl_table_header is incremented
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
The real time clock driver was using the binary number reserved
for cdroms in the sysctl binary number interface, which is a no-no.
So since the sysctl binary interface is wrong remove it.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/frv/kernel/sysctl.c | 29 -
1 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/arch/frv/kernel/sysctl.c b/arch/frv/kernel/sysctl.c
index
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Because the sunrpc sysctls don't conflict with any other
sysctls the setting the insert at head flag to register_sysctl
has no semantic meaning.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/sunrpc/sysctl.c |2 +-
net
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
We don't need this to prevent module unload races so remove
the unnecessary code.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
net/sunrpc/sysctl.c |8 +---
net/sunrpc/xprtsock.c |7 +--
2 files changed, 2
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/mips/au1000/common/power.c | 38 --
1 files changed, 32 insertions(+), 6 deletions(-)
diff --git a/arch/mips/au1000/common/power.c b/arch/mips
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
The assignment of binary numbers for sys_sysctl use was in
shambles and despite requiring methods. Nothing was implemented
on the sys_sysctl side.
So this patch gives a mercy killing to the sys_sysctl support for
powermanagment on mips/au1000
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
binfmt_misc has a mount point in the middle of the sysctl and
that mount point is created as a proc_generic directory.
Doing it that way gets in the way of cleaning up the sysctl
proc support as it continues the existence of a horrible hack
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
By not using the enumeration in sysctl.h (or even understanding it)
the SN platform placed their arch specific xpc directory on top of
CTL_KERN and only because they didn't have 4 entries in their xpc
directory got lucky and didn't break glibc
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
While doing the C99 conversion I notices that the top level sh64
directory was using the binary number for CTL_KERN. That is a
no-no so I removed the support for the sysctl binary interface
only leaving sysctl /proc support.
At least
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
This convers the sysctl ctl_tables to use C99 initializers.
While I was looking at it I discovered it was using a portion of
the sysctl binary addresses space under CTL_KERN KERN_OSTYPE
which was completely inappropriate. So I completely
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Will converting the coda sysctl initializers I discovered that
it is yet another user of sysctl that was stomping CTL_KERN.
So off with it's sys_sysctl support since it wasn't done
in a supportable way.
Signed-off-by: Eric W. Biederman [EMAIL
1 - 100 of 1118 matches
Mail list logo
