fields.
>
> Thanks to Dmitry V. Levin his analysis of this bug history.
>
> Cc: Jiri Olsa
> Cc: Daniel Borkmann
> Cc: Geert Uytterhoeven
> Cc: Linus Torvalds
> Signed-off-by: Baruch Siach
Thanks for your patch!
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uap
zeof(x) = 4
$ uname -m
x86_64
So the compiler allocates a single byte, even on a 64-bit platform!
The gap is solely determined by the alignment rule for the
successive field.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge
The whole block is protected by "if NET_VENDOR_MEDIATEK", so there is
no need for individual driver config symbols to duplicate this
dependency.
Signed-off-by: Geert Uytterhoeven
---
drivers/net/ethernet/mediatek/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ne
Signed-off-by: Geert Uytterhoeven
---
drivers/net/ethernet/samsung/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/samsung/Kconfig
b/drivers/net/ethernet/samsung/Kconfig
index 027938017579130f..e92a178a76df0849 100644
--- a/drivers/net/ethernet
. But that is more difficult to reproduce, as I don't have any arm32
boards that use RAVB, and on arm64 register access while a device is
suspended doesn't cause a crash, but continues silently without any effect.
Gr{oetje,eeting}s,
Geer
In general, device drivers should not be enabled by default.
Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver")
Signed-off-by: Geert Uytterhoeven
---
drivers/net/usb/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/Kconfig b/drive
The standard DT property name is "interrupt-names".
Fixes: fd913ef7ce619467 ("Bluetooth: btusb: Add out-of-band wakeup support")
Signed-off-by: Geert Uytterhoeven
Acked-by: Rob Herring
Reviewed-by: Brian Norris
Acked-by: Rajat Jain
---
Who takes this patch, before i
iver probe and driver unbind, and
changing that seems to be non-trivial).
Thanks for your comments!
Geert Uytterhoeven (2):
net: mdio-bitbang: Export mdiobb_{read,write}()
sh_eth: Make PHY access aware of Runtime PM to fix reboot crash
drivers/net/ethernet/renesas/sh_
: 7fa2955ff70ce453 ("sh_eth: Fix sleeping function called from invalid
context")
Signed-off-by: Geert Uytterhoeven
---
drivers/net/ethernet/renesas/sh_eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethern
) when it is opened (closed),
3. Make sure the device is powered during PHY access.
Signed-off-by: Geert Uytterhoeven
---
Tested on r8a73a4/ape6evm, where the LAN9220 is connected to a
power-managed bus, and any attempt to access a device register while the
device is suspended will trigger an
d, causing undefined behavior, which may crash the
system.
Fix this by wrapping the PHY bitbang accessors in the sh_eth driver by
wrappers that take care of Runtime PM, to resume the device when needed.
Reported-by: Wolfram Sang
Suggested-by: Andrew Lunn
Signed-off-by: Geert Uytterhoeven
---
v2
Export mdiobb_read() and mdiobb_write(), so Ethernet controller drivers
can call them from their MDIO read/write wrappers.
Signed-off-by: Geert Uytterhoeven
---
v2:
- New.
---
drivers/net/mdio/mdio-bitbang.c | 6 --
include/linux/mdio-bitbang.h| 3 +++
2 files changed, 7 insertions
As the Marvell PCIE WiFi-Ex driver does not have any code or data
located in initmem, there is no need to annotate the mwifiex_pcie
structure with __refdata. Drop the annotation, to avoid suppressing
future section warnings.
Signed-off-by: Geert Uytterhoeven
---
drivers/net/wireless/marvell
(void)clk_prepare_enable(priv->ref_clk);
This can fail.
Does this clock need to be enabled all the time?
At least it should be disabled in the probe failure path, and in
ravb_remove().
[1] Documentation/devicetree/bindings/net/renesas,etheravb.yaml
Gr{oetje,eeting}s,
bad relocations
> ce56510b R_PPC64_UADDR64 .rodata+0x01c72378
> ce565126 R_PPC64_UADDR64 .rodata+0x01c723c0
>
> They are not drivers that are used on PowerPC (I assume), so mark them
> to not be built on PPC64 when CONFIG_RELOCATABLE is enabled.
&g
sed uninitialized" warnings thrown up by gcc-4.1, until
(a bit later than) support for that compiler was removed...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal con
> check this here.
>
> Signed-off-by: Uwe Kleine-König
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven
Note that there are similar checks in snd_ps3_driver_probe(), which
can be removed, too:
if (WARN_ON(!firmware_has_feature(FW_FEATURE_PS3_LV1)))
return -E
ave
> accordingly.
>
> Signed-off-by: Uwe Kleine-König
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven
Note that the same can be done for ps3_vuart_port_driver.remove().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyon
dev, RPM_GET_PUT);
> + if (ret < 0) {
> + pm_runtime_put_noidle(dev);
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> /**
> * pm_runtime_put - Drop device usage counter and queue up "idle check" if 0.
>
The standard DT property name is "interrupt-names".
Fixes: fd913ef7ce619467 ("Bluetooth: btusb: Add out-of-band wakeup support")
Signed-off-by: Geert Uytterhoeven
Acked-by: Rob Herring
Reviewed-by: Brian Norris
Acked-by: Rajat Jain
---
Who takes this patch, before i
Hi Adam,
CC devicetree
On Mon, Dec 28, 2020 at 2:49 PM Adam Ford wrote:
> On Mon, Dec 14, 2020 at 4:05 AM Geert Uytterhoeven
> wrote:
> > On Sun, Dec 13, 2020 at 5:18 PM Adam Ford wrote:
> > > The SoC expects the txv_refclk is provided, but if it is provided
> >
d.
> if (IS_ERR(priv->clk)) {
> error = PTR_ERR(priv->clk);
> goto out_release;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with te
Hi Prabhakar,
On Thu, Dec 31, 2020 at 5:00 PM Lad Prabhakar
wrote:
> The rcar_canfd driver supports R-Car Gen3 and RZ/G2 SoC's, update the
> description to reflect this.
>
> Signed-off-by: Lad Prabhakar
Reviewed-by: Geert Uytterhoeven
> --- a/drivers/net/can/rcar/Kconfig
On Mon, Jan 4, 2021 at 10:03 AM Lad Prabhakar
wrote:
> The rcar_can driver also supports RZ/G SoC's, update the description to
> reflect this.
>
> Signed-off-by: Lad Prabhakar
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytter
Fixes: e2f016cf775129c0 ("net: phy: add a shutdown procedure")
Signed-off-by: Geert Uytterhoeven
---
Marked RFC as I do not know if this change breaks the use case fixed by
the faulty commit. Alternatively, the device may have to be started
explicitly first.
---
drivers/net/phy/phy_de
Hi Prabhakar,
On Mon, Jan 4, 2021 at 2:38 PM Lad, Prabhakar
wrote:
> On Mon, Jan 4, 2021 at 10:51 AM Geert Uytterhoeven
> wrote:
> > On Thu, Dec 31, 2020 at 5:00 PM Lad Prabhakar
> > wrote:
> > > The rcar_canfd driver supports R-Car Gen3 and RZ/G2 SoC's,
Hi Ioana,
On Mon, Jan 4, 2021 at 3:53 PM Ioana Ciornei wrote:
> On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote:
> > Wolfram reports that his R-Car H2-based Lager board can no longer be
> > rebooted in v5.11-rc1, as it crashes with an imprecise external abort
2d0...@gmail.com/
From b3cc15e56bddbe65e0196ce04604e5e6c78abd7a Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven
Date: Tue, 5 Jan 2021 10:29:22 +0100
Subject: [PATCH] [RFC] sh_eth: Make PHY access aware of Runtime PM to fix
reboot crash
Wolfram reports that his R-Car H2-based Lager board can no
l Delay Mode
bit in the APSR register, so its compatible value should be added to
the list of SoCs where tx-internal-delay-ps is required.
With that fixed:
Reviewed-by: Geert Uytterhoeven
The various Counter Registers starting at offset 0x700 are limited to
16-bit values, like on R-Car Gen2, while t
a required
property on RZ/G2H.
Fixes: 8b0308fe319b8002 ("Merge
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
Signed-off-by: Geert Uytterhoeven
---
Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devic
on TX4927 ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something
Hi Thomas,
On Wed, Jan 6, 2021 at 7:49 PM Thomas Bogendoerfer
wrote:
> On Wed, Jan 06, 2021 at 09:37:11AM +0100, Geert Uytterhoeven wrote:
> > On Tue, Jan 5, 2021 at 3:03 PM Thomas Bogendoerfer
> > wrote:
> > > I couldn't find any buyable product other than refere
Hi Nemoto-san,
On Thu, Jan 7, 2021 at 2:18 AM Atsushi Nemoto wrote:
> On Wed, 6 Jan 2021 21:41:24 +0100, Geert Uytterhoeven
> wrote:
> >> > Is that sufficient to keep it?
> >>
> >> for me it is. But now we probaly need some reverts then...
> >
>
1fccb2d6274 ("ravb: Add tx and rx clock internal delays mode of APSR")
> Signed-off-by: Sergey Shtylyov
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In persona
tly only one clock, there is no
> clock-names list either.
>
> Update bindings to add the additional optional clock, and explicitly
> name both of them.
>
> Signed-off-by: Adam Ford
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert U
On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote:
> The bindings have been updated to support two clocks, but the
> original clock now requires the name fck. Add a clock-names
> list in the device tree with fck in it.
>
> Signed-off-by: Adam Ford
Reviewed-by: Geert Uytterho
Hi Adam,
On Tue, Jan 5, 2021 at 1:53 PM Adam Ford wrote:
> On Mon, Jan 4, 2021 at 4:41 AM Geert Uytterhoeven
> wrote:
> > On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote:
> > > The bindings have been updated to support two clocks, but the
> > > original cloc
Hi Adam,
On Fri, Jan 8, 2021 at 3:11 PM Geert Uytterhoeven wrote:
> On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote:
> > The AVB driver assumes there is an external clock, but it could
> > be driven by an external clock. In order to enable a programmable
> > clock, it nee
On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote:
> The bindings have been updated to support two clocks, but the
> original clock now requires the name fck. Add a clock-names
> list in the device tree with fck in it.
>
> Signed-off-by: Adam Ford
Reviewed-by: Geert Uytterho
MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the
user may not want to enable. Fix this by making the test depend on
MPTCP instead.
Fixes: a00a582203dbc43e ("mptcp: move crypto test to KUNIT")
Signed-off-by: Geert Uytterhoeven
---
net/mptcp/Kconfig | 4 +---
1 fi
Hi Matthieu,
On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts
wrote:
> On 19/10/2020 13:32, Geert Uytterhoeven wrote:
> > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the
> > user may not want to enable. Fix this by making the test depend on
> > MPTCP
MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like
is done for all other IPv6 features.
Fixes: f870fa0b5768842c ("mptcp: Add MPTCP socket stubs")
Signed-off-by: Geert Uytterhoeven
---
net/mpt
On Mon, Oct 19, 2020 at 10:38 PM Geert Uytterhoeven
wrote:
> On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts
> wrote:
> > On 19/10/2020 13:32, Geert Uytterhoeven wrote:
> > > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the
> > > user may no
Hi Jakub,
On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote:
> On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
> > On 20/10/2020 09:38, Geert Uytterhoeven wrote:
> > > MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
> > > not w
Hi Matthieu,
On Wed, Oct 21, 2020 at 11:47 AM Matthieu Baerts
wrote:
> On 21/10/2020 11:43, Geert Uytterhoeven wrote:
> > On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote:
> >> On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
> >>> On 20/10/2020 0
reverts commit 3193c0836f203, and instead, it disables the -fgcse
> optimization for the entire source file, but only when building for
> X86.
>
> Cc: Nick Desaulniers
> Cc: Arvind Sankar
> Cc: Randy Dunlap
> Cc: Josh Poimboeuf
> Cc: Thomas Gleixner
> Cc: Alexei Starovoito
d Biesheuvel
(probably you missed by tag on v1 due to kernel.org hickups)
Thanks, this gets rid of the following warning, which you may
want to quote in the patch description:
aarch64-linux-gnu-ld: warning: orphan section `.eh_frame' from
`kernel/bpf/core.o' being placed i
est config patch when all other parts have
entered mainline. Note that I would have made the same changes
myself anyway, on -rc1 defconfig refresh.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In perso
lk")
> Signed-off-by: Adam Ford
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I&#x
c_bus_type.p && !early_soc_dev_attr)
> + return ERR_PTR(-EPROBE_DEFER);
> +
> while (!ret) {
> if (!(matches->machine || matches->family ||
> matches->revision || matches->soc_id))
Gr{oetje,eeting}s,
me drivers may be used on
multiple platforms, some of them registering an SoC device, some of
them not registering an SoC device. So there is no way to know the
difference between "SoC device not registered, intentionally", and
"SoC device not yet registered".
soc_device_match()
On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> The bindings have been updated to support two clocks, but the
> original clock now requires the name fck. Add a clock-names
> list in the device tree with fck in it.
>
> Signed-off-by: Adam Ford
> Reviewed-by: Geert Uytterho
Hi Adam,
On Sat, Apr 17, 2021 at 3:54 PM Adam Ford wrote:
> On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven
> wrote:
> > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> > > The AVB refererence clock assumes an external clock that runs
> >
> > reference
dr(struct page *page, dma_addr_t addr)
> +{
> + page->dma_addr[0] = addr;
> + if (sizeof(dma_addr_t) > sizeof(unsigned long))
> + page->dma_addr[1] = addr >> 16 >> 16;
... but we do have upper_32_bits() for a 32-bi
long long unsigned int
| %x
Fixes: d5395a5486596308 ("ath11k: qmi: add debug message for allocated memory
segment addresses and sizes")
Signed-off-by: Geert Uytterhoeven
---
drivers/net/wireless/ath/ath11k/qmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
ualcomm/rmnet/rmnet_map.h:7,
> from
> drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:14:
>include/linux/if_rmnet.h: At top level:
> >> include/linux/if_rmnet.h:66:2: error: expected ',', ';' or '}' before 'u8
sja1105_unpack() takes a "const void *buf" as its first parameter, so
there is no need to cast away the "const" of the "buf" variable before
calling it.
Drop the cast, as it prevents the compiler performing some checks.
Signed-off-by: Geert Uytterhoeven
Hi Vladimir,
On Wed, Feb 24, 2021 at 11:44 PM Vladimir Oltean wrote:
> On Tue, Feb 23, 2021 at 12:20:03PM +0100, Geert Uytterhoeven wrote:
> > sja1105_unpack() takes a "const void *buf" as its first parameter, so
> > there is no need to cast away the "const
plan to merge this whole patchset via netdev? If so, you need
> to repost anyway, once netdev reopens. So maybe you can change the
> wording?
The DTS patches should go in through the renesas and soc trees.
I can apply them as soon as the DT binding patch has been accepted.
Thanks!
Gr{oetje,e
; - u8 pad[1];
> };
If you use a flexible array member, it should be declared without a size,
i.e.
u8 key[];
Everything else is (trying to) fool the compiler, and leading to undefined
behavior, and people (re)adding explicit padding.
--
Gr{oetje,eeting}s,
G
Hi Samudrala,
On Fri, Mar 26, 2021 at 11:45 PM Samudrala, Sridhar
wrote:
> On 3/26/2021 1:06 AM, Geert Uytterhoeven wrote:
> > On Thu, Mar 25, 2021 at 11:29 PM Tony Nguyen
> > wrote:
> > From: Norbert Ciosek
> >
> > Remove padding from RSS structures.
Hi Adam,
On Mon, Mar 29, 2021 at 2:45 PM Adam Ford wrote:
> On Thu, Mar 4, 2021 at 2:08 AM Geert Uytterhoeven
> wrote:
> > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> > > For devices that use a programmable clock for the AVB reference clock,
> > > the
dev);
> out_release:
> + clk_disable_unprepare(priv->refclk);
> free_netdev(ndev);
>
> pm_runtime_put(&pdev->dev);
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Li
Hi Adam,
On Wed, Apr 14, 2021 at 3:08 PM Adam Ford wrote:
> On Tue, Apr 13, 2021 at 2:33 AM Geert Uytterhoeven
> wrote:
> > On Mon, Apr 12, 2021 at 3:27 PM Adam Ford wrote:
> > > For devices that use a programmable clock for the AVB reference clock,
> > > the
intended recipient, please
contact the sender and delete all copies; any review or distribution by others
is strictly prohibited.
___
Intel-wired-lan mailing list
intel-wired-...@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
???
clarations inside the existing #ifdef
blocks.
Signed-off-by: Geert Uytterhoeven
---
drivers/net/ethernet/freescale/fec_main.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_ma
nd as they're queued in net, not net-next, they
missed today's renesas-drivers release, and all related testing...
I applied them manually, and boot-tested rskrza1 (R7S72100) and
rza2mevb (R7S9210) using nfsroot. Worked fine.
Tested-by: Geert Uytterhoeven
Review will take a bit longer...
rt the clock.
>
> Signed-off-by: Adam Ford
Reviewed-by: Geert Uytterhoeven
i.e. will queue in renesas-devel (with the typo fixed) once the DT
bindings have been accepted.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- g
gt; ravb_ptp_stop(ndev);
>
> + if (priv->refclk)
> + clk_disable_unprepare(priv->refclk);
> +
> dma_free_coherent(ndev->dev.parent, priv->desc_bat_size,
> priv->desc_bat,
> priv->desc_bat_
SuperH Ethernet")
> Signed-off-by: Sergey Shtylyov
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself
er for
> sh_eth_cpu_data::trscer_err_mask for R7S72100.
>
> Fixes: db893473d313 ("sh_eth: Add support for r7s72100")
> Signed-off-by: Sergey Shtylyov
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Lin
::
> trscer_err_mask for R7S9210.
>
> Fixes: 6e0bb04d0e4f ("sh_eth: Add R7S9210 support")
> Signed-off-by: Sergey Shtylyov
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- g
To improve human readability and enable automatic validation, the tuples
in "pinctrl-*" properties should be grouped using angle brackets.
Signed-off-by: Geert Uytterhoeven
---
Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletio
, even if the latter support is not enabled.
Fix this by reinstating the dependency.
Fixes: 63368a7416df144b ("net: dsa: mv88e6xxx: Make global2 support mandatory")
Signed-off-by: Geert Uytterhoeven
---
drivers/net/dsa/mv88e6xxx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
To fix this, drop the automatic enabling of BCM4908_ENET.
Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller
driver")
Signed-off-by: Geert Uytterhoeven
---
Feel free to change to &qu
Merely enabling compile-testing should not enable additional code.
To fix this, restrict the automatic enabling of BCM4908_ENET to
ARCH_BCM4908.
Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller
driver")
Signed-off-by: Geert Uytterhoeven
---
v2:
- Enable
Hi Adam,
On Thu, Mar 18, 2021 at 1:44 PM Adam Ford wrote:
> On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven
> wrote:
> > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> > > The AVB refererence clock assumes an external clock that runs
> >
> > reference
re about)
If you don't update commit e0fe7fc6f2ca0781 ("dt-bindings: Whitespace
clean-ups in schema files"), I can send a patch after v5.9-rc1.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
I
- Remove pinctrl consumer properties, as they are handled by core
dt-schema,
- Document missing properties,
- Document missing PHY child node,
- Add "additionalProperties: false".
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Rob Herring
---
v2:
- Add R
ernal-delay-ps"
overrides.
Notes:
- R-Car E3 and D3 do not support TX internal delay handling,
- On R-Car D3, TX internal delay handling must always be enabled,
hence this fixes a bug on Draak,
- On R-Car V3H, RX internal delay handling must always be enabled.
Signed-off-
Currently, full delay handling is done in both the probe and resume
paths. Split it in two parts, so the resume path doesn't have to redo
the parsing part over and over again.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Sergei Shtylyov
---
v3:
- No changes,
v2:
- Add Review
Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding
documentation to json-schema.
Add missing properties.
Update the example to match reality.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Sergei Shtylyov
Reviewed-by: Rob Herring
---
v3:
- Add Reviewed-by,
v2:
- Add
commit 9150069bf5fc0e86 ("dt-bindings:
net: Add tx and rx internal delays"), which applies to the PHY.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Rob Herring
---
v3:
- Add Reviewed-by,
v2:
- New.
---
.../bindings/net/ethernet-controller.yaml | 14 ++
1 fi
e new "[rt]x-internal-delay-ps" properties.
Fall back to the old handling if none of these properties is present.
[1] Commit bcf3440c6dd78bfe ("net: phy: micrel: add phy-mode support for
the KSZ9031 PHY")
[2] Commit 9b23203c32ee02cd ("ravb: Mask PHY mode to av
These properties are mandatory, even when specified as zero, to
distinguish between old and new DTBs.
Update the (bogus) example accordingly.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Sergei Shtylyov
Reviewed-by: Rob Herring
---
v3:
- Add Reviewed-by,
v2:
- Replace "renesas,[
ternal-delay-ps"
overrides.
Notes:
- RZ/G2E does not support TX internal delay handling.
Signed-off-by: Geert Uytterhoeven
---
This depends on "[PATCH v3 5/7] ravb: Add support for explicit internal
clock delay configuration", and thus must not be applied before its
dependen
31368-1-geert+rene...@glider.be/
[3]
https://lore.kernel.org/r/CAMuHMdU+MR-2tr3-pH55G0GqPG9HwH3XUd=8hzxprfdmgqe...@mail.gmail.com/
[4]
https://lore.kernel.org/linux-devicetree/20200706143529.18306-1-geert+rene...@glider.be/
[5]
https://lore.kernel.org/linux-devicetree/20200619191554.24942-1-ge
Hi David,
On Wed, Aug 19, 2020 at 10:05 PM David Miller wrote:
> From: Geert Uytterhoeven
> Date: Wed, 19 Aug 2020 14:45:39 +0200
>
> > - Remove pinctrl consumer properties, as they are handled by core
> > dt-schema,
> > - Document missing properties,
> &g
Hi Sergei,
On Thu, Aug 20, 2020 at 2:26 PM Sergei Shtylyov
wrote:
> On 8/19/20 3:45 PM, Geert Uytterhoeven wrote:
>
> > - Remove pinctrl consumer properties, as they are handled by core
>
>So you're removing them even from the example?
Yes, as they're com
t; Signed-off-by: Lad Prabhakar
> Reviewed-by: Chris Paterson
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call m
Hi Prabhakar,
On Sun, Aug 16, 2020 at 9:07 PM Lad Prabhakar
wrote:
> Add pins, groups and functions for the CAN0 and CAN1 interface.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Chris Paterson
Reviewed-by: Geert Uytterhoeven
Don't you want to add the CAN_CLK pins, too?
On Sun, Aug 16, 2020 at 9:08 PM Lad Prabhakar
wrote:
> Add the definitions for can0 and can1 to the r8a7742 SoC dtsi.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Chris Paterson
Reviewed-by: Geert Uytterhoeven
i.e. will queue in renesas-devel for v5.10.
Gr{oe
Hi Prabhakar,
On Fri, Aug 21, 2020 at 4:23 PM Lad, Prabhakar
wrote:
> On Fri, Aug 21, 2020 at 1:52 PM Geert Uytterhoeven
> wrote:
> > On Sun, Aug 16, 2020 at 9:07 PM Lad Prabhakar
> > wrote:
> > > Add pins, groups and functions for the CAN0 and CAN1 interface.
>
his be handled in the platform code that instantiates the device,
i.e. in arch/m68k/mac/config.c:mac_platform_init()?
Cfr. commit f61e64310b75733d ("m68k: set dma and coherent masks for platform
FEC ethernets").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterho
his be handled in the platform code that instantiates the device,
i.e. in arch/m68k/mac/config.c:mac_platform_init()?
Cfr. commit f61e64310b75733d ("m68k: set dma and coherent masks for platform
FEC ethernets").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There
Hi Finn,
CC Christoph
On Thu, May 3, 2018 at 10:38 AM, Finn Thain wrote:
> On Thu, 3 May 2018, Geert Uytterhoeven wrote:
>> > --- a/drivers/net/ethernet/apple/macmace.c
>> > +++ b/drivers/net/ethernet/apple/macmace.c
>> > @@ -203,6 +203,10 @@ static int mace_prob
R8A7796 is R-Car M3-W.
Signed-off-by: Geert Uytterhoeven
---
Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
b/Documentation/devicetree/bindings/net/can
Hi Michael,
On Thu, May 3, 2018 at 10:24 PM, Michael Schmitz wrote:
> On Thu, May 3, 2018 at 8:51 PM, Christoph Hellwig wrote:
>> On Thu, May 03, 2018 at 10:46:56AM +0200, Geert Uytterhoeven wrote:
>>> Perhaps you can add a new helper (platform_device_register_simple_dma()?)
On Tue, May 8, 2018 at 9:02 AM, Geert Uytterhoeven wrote:
> JFYI, when comparing v4.17-rc4[1] to v4.17-rc3[3], the summaries are:
> - build errors: +1/-4
+ /kisskb/src/include/linux/mlx5/driver.h: error: 'struct irq_desc'
has no member named 'affinity_hint': =>
Hi Michael,
On Wed, Apr 18, 2018 at 12:35 AM, Michael Schmitz wrote:
> On Wed, Apr 18, 2018 at 1:53 AM, Geert Uytterhoeven
> wrote:
>> On Tue, Apr 17, 2018 at 12:04 AM, Michael Schmitz
>> wrote:
>>> Add platform device driver to populate the ax88796 platform data fr
1 - 100 of 710 matches
Mail list logo
