Re: [PATCHv2 4/5] sh_eth: enable wake-on-lan for sh7743

2016-12-13 Thread Geert Uytterhoeven
oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer&q

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-13 Thread Geert Uytterhoeven
4 > --- a/drivers/net/ethernet/renesas/sh_eth.h > +++ b/drivers/net/ethernet/renesas/sh_eth.h > @@ -493,6 +493,7 @@ struct sh_eth_cpu_data { > unsigned shift_rd0:1; /* shift Rx descriptor word 0 right by 16 */ > unsigned rmiimode:1;/* EtherC has RMIIMODE register */ >

Re: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Geert Uytterhoeven
d of the hardcoded values here? > > .tx_check = EESR_TC1 | EESR_FTC, > .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT | Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In perso

Re: Build regressions/improvements in v4.9-rc8

2016-12-05 Thread Geert Uytterhoeven
On Mon, Dec 5, 2016 at 10:09 AM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > JFYI, when comparing v4.9-rc8[1] to v4.9-rc7[3], the summaries are: > - build errors: +5/-10 + /home/kisskb/slave/src/drivers/net/ethernet/freescale/fec_main.c: error: 'fec_stats' undeclare

Re: [patch net v2] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Geert Uytterhoeven
ko <nikita.yo...@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <ge...@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself

Re: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-02 Thread Geert Uytterhoeven
Hi Chris, On Thu, Dec 1, 2016 at 7:53 PM, Chris Brandt <chris.bra...@renesas.com> wrote: > On 12/1/2016, Sergei Shtylyov wrote: >> >> On 12/01/2016 05:42 PM, Geert Uytterhoeven wrote: >> >> >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> &

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-19 Thread Geert Uytterhoeven
nd could not find any clock handling. > Maybe they only deal with power domains? There should be a generic way to prevent a device from being suspended. This will make sure the module clock is not disabled, and the power domain (if applicable) is not powered down. Note that the clock handling i

Re: [PATCH v2 06/23] MAINTAINERS: Add file patterns for dsa device tree bindings

2017-03-16 Thread Geert Uytterhoeven
Hi Andrew, On Sun, Mar 12, 2017 at 6:04 PM, Andrew Lunn <and...@lunn.ch> wrote: > On Sun, Mar 12, 2017 at 02:16:50PM +0100, Geert Uytterhoeven wrote: >> Submitters of device tree binding documentation may forget to CC >> the subsystem maintainer if this is missing. > >&

[PATCH v2.1 06/23] MAINTAINERS: Add file patterns for dsa device tree bindings

2017-03-16 Thread Geert Uytterhoeven
Submitters of device tree binding documentation may forget to CC the subsystem maintainer if this is missing. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Andrew Lunn <and...@lunn.ch> Cc: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Cc: Florian

[PATCH] can: rcar_can: Do not print virtual addresses

2017-04-03 Thread Geert Uytterhoeven
me. Fixes: fd1159318e55e901 ("can: add Renesas R-Car CAN driver") Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/net/can/rcar/rcar_can.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net

Re: [PATCH 1/1] drivers:net:ethernet:adi:bfin_mac: Use FIELD_SIZEOF defined kernel macro

2017-04-23 Thread Geert Uytterhoeven
= netdev_priv(netdev); > > return copy_to_user(ifr->ifr_data, >stamp_cfg, > - sizeof(lp->stamp_cfg)) ? > + FILD_SIZEOF(struct bfin_mac_local, stamp_cfg)) ? As the kbuild test robot already told you, this doesn't compile.

[PATCH v2 06/23] MAINTAINERS: Add file patterns for dsa device tree bindings

2017-03-12 Thread Geert Uytterhoeven
Submitters of device tree binding documentation may forget to CC the subsystem maintainer if this is missing. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Andrew Lunn <and...@lunn.ch> Cc: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Cc: netdev@vger.ker

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

2017-08-14 Thread Geert Uytterhoeven
great we can do WoL if not then user-space will be > prevented from enabling WoL and nothing in the current behavior changes. And all this explicit clock handling is done only because device_set_wakeup_enable() does not yet prevent the PM Domain code from powering down the device during system suspe

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-07-09 Thread Geert Uytterhoeven
That would be great, thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journ

[PATCH/RFC] dma-mapping: Provide dummy set_dma_ops() for NO_DMA=y

2017-07-09 Thread Geert Uytterhoeven
5567e989198b5a8d ("fsl/fman: propagate dma_ops"). This allows to revert commit 85688d9adf685572 ("fsl/fman: add dependency on HAS_DMA"). Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- include/linux/dma-mapping.h | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC

2017-07-10 Thread Geert Uytterhoeven
On Mon, Jul 10, 2017 at 5:32 PM, Biju Das <biju@bp.renesas.com> wrote: > Add a new compatible string for the RZ/G1M (R8A7743) SoC. > > Signed-off-by: Biju Das <biju@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Gr{oetje,eeting}s,

Re: [PATCH] dpaa_eth: use correct device for DMA mapping API

2017-07-10 Thread Geert Uytterhoeven
Hi Arnd, On Mon, Jul 10, 2017 at 5:14 PM, Arnd Bergmann <a...@arndb.de> wrote: > Geert Uytterhoeven ran into a build error without CONFIG_HAS_DMA, > as a result of the driver calling set_dma_ops(). While we can > fix the build error in the dma-mapping implementation, there is &g

Re: ath10k: ret used but uninitialized

2017-07-07 Thread Geert Uytterhoeven
h the style of initialising ret to zero, >> it tends to hide things. Instead my preference is something like below >> where the error handling is more explicit and easier to find where it's >> exactly failing. But that's just an example how I would try to solve it, >> it still lacks t

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-07-02 Thread Geert Uytterhoeven
On Tue, Jun 6, 2017 at 11:43 AM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > On Tue, May 23, 2017 at 11:36 AM, Geert Uytterhoeven > <ge...@linux-m68k.org> wrote: >> On Fri, May 19, 2017 at 12:21 AM, Florian Fainelli <f.faine...@gmail.com> >> wrot

[PATCH] ptp: dte: Use LL suffix for 64-bit constants

2017-07-06 Thread Geert Uytterhoeven
: integer constant is too large for ‘long’ type Add the missing "LL" suffix to fix this. Fixes: 8a56aa107f1e8123 ("ptp: Add a ptp clock driver for Broadcom DTE") Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- drivers/ptp/ptp_dte.c | 2 +- 1 file changed,

ath10k: ret used but uninitialized (was: Re: ath10k: add initial SDIO support)

2017-07-06 Thread Geert Uytterhoeven
re(jiffies, timeout) && !done) { > + ret = ath10k_sdio_mbox_proc_pending_irqs(ar, ); > + if (ret) > + break; > + } > + > + sdio_claim_host(ar_sdio->func); > + > + wake_up(_sdio->irq_wq); > + >

Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-05 Thread Geert Uytterhoeven
gt; }, > { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 > }, > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void > *)RCAR_GEN2 }, As Sergei already mentioned, a driver update is not needed due to the presence of family-specific compatible

Re: [PATCH v 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB

2017-07-05 Thread Geert Uytterhoeven
obile_defconfig > multiplatform configuration. > > Signed-off-by: Biju Das <biju@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paters...@renesas.com> Acked-by: Geert Uytterhoeven <geert+rene...@glider.be> Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-05 Thread Geert Uytterhoeven
Hi Chris, On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson <chris.paters...@renesas.com> wrote: >> From: geert.uytterhoe...@gmail.com >> [mailto:geert.uytterhoe...@gmail.com] On Behalf Of Geert Uytterhoeven >> Sent: 05 July 2017 14:47 >> On Wed, Jul 5, 2

[PATCH 1/2] net: phy: Freeze PHY polling before suspending devices

2017-08-22 Thread Geert Uytterhoeven
(phy_state_machine+0xa8/0x3dc) [] (phy_state_machine) from [] (process_one_work+0x240/0x3fc) [] (process_one_work) from [] (worker_thread+0x2b8/0x3f4) [] (worker_thread) from [] (kthread+0x124/0x144) [] (kthread) from [] (ret_from_fork+0x14/0x24) Code: e5903000 e0831001 e591 f57ff04f (e1

[PATCH 2/2] net: smsc911x: Quiten netif during suspend

2017-08-22 Thread Geert Uytterhoeven
ntk/parameters/console_suspend # echo platform > /sys/power/pm_test # echo mem > /sys/power/state To fix this, make sure the network interface is quitened during suspend. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- No stacktrace is provided, as the imprecise

[PATCH 0/2] net: Fix crashes due to activity during suspend

2017-08-22 Thread Geert Uytterhoeven
wer/state With this series applied, my test systems survive a loop of 100 test suspends. Thanks for your comments! Geert Uytterhoeven (2): net: phy: Freeze PHY polling before suspending devices net: smsc911x: Quiten netif during suspend drivers/net/ethernet/smsc/smsc911x.c | 15 ++-

Re: [PATCH 0/2] net: Fix crashes due to activity during suspend

2017-08-22 Thread Geert Uytterhoeven
Hi Florian, On Tue, Aug 22, 2017 at 8:49 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 08/22/2017 11:37 AM, Geert Uytterhoeven wrote: >> If an Ethernet device is used while the device is suspended, the system may >> crash. >> >> E.g. on sh73a0/kzm9g

Re: [PATCH 0/2] net: Fix crashes due to activity during suspend

2017-08-23 Thread Geert Uytterhoeven
Hi Florian, On Tue, Aug 22, 2017 at 8:49 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 08/22/2017 11:37 AM, Geert Uytterhoeven wrote: >> If an Ethernet device is used while the device is suspended, the system may >> crash. >> >> E.g. on sh73a0/kzm9g

[PATCH v2 0/5] ARM: dts: rcar-gen2: Convert to new CPG/MSSR bindings

2017-08-18 Thread Geert Uytterhoeven
een tested on r8a7790/lager, r8a7791/koelsch, r8a7792/blanche, r8a7793/gose, and r8a7794/alt. /sys/kernel/debug/clk/clk_summary has been compared before and after the conversion. Thanks for applying! Geert Uytterhoeven (5): ARM: dts: r8a7790: Convert to new CPG/MSSR bindings ARM: dts: r8a779

[PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

2017-05-03 Thread Geert Uytterhoeven
nntrack.ko] undefined! Fix this by forcing inlining of total_extension_size(). Fixes: b3a5db109e0670d6 ("netfilter: conntrack: use u8 for extension sizes again") Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- net/netfilter/nf_conntrack_core.c | 2 +- 1 file

Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

2017-05-03 Thread Geert Uytterhoeven
Hi Arnd, On Wed, May 3, 2017 at 2:32 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Wed, May 3, 2017 at 2:18 PM, Geert Uytterhoeven <ge...@linux-m68k.org> > wrote: >> If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the >> build will fail

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-18 Thread Geert Uytterhoeven
Hi Niklas, On Tue, May 16, 2017 at 2:16 PM, Niklas Söderlund <niklas.soderl...@ragnatech.se> wrote: > On 2017-05-16 13:36:21 +0200, Geert Uytterhoeven wrote: >> On Tue, May 16, 2017 at 1:01 PM, Simon Horman <ho...@verge.net.au> wrote: >> > Is there some way for - e

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Geert Uytterhoeven
PM: Device e680.ethernet failed to resume: error -110 Your resume routine cannot assume RAVB is in a sane mode, as it will have been reset if PSCI suspend was used. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Geert Uytterhoeven
Hi Niklas, On Fri, May 12, 2017 at 4:32 PM, Niklas Söderlund <niklas.soderl...@ragnatech.se> wrote: > On 2017-05-12 14:58:53 +0200, Niklas Söderlund wrote: >> On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: >> > On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlun

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Geert Uytterhoeven
Hi Niklas, On Fri, May 12, 2017 at 2:58 PM, Niklas Söderlund <niklas.soderl...@ragnatech.se> wrote: > On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: >> On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund >> <niklas.soderlund+rene...@ragnatech.se> wrote: >>

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-16 Thread Geert Uytterhoeven
Hi Simon, On Tue, May 16, 2017 at 1:01 PM, Simon Horman <ho...@verge.net.au> wrote: > On Tue, May 16, 2017 at 11:07:34AM +0200, Geert Uytterhoeven wrote: >> On Tue, May 16, 2017 at 11:02 AM, Niklas Söderlund >> <niklas.soderl...@ragnatech.se> wrote: >> >>

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-16 Thread Geert Uytterhoeven
d >> be OK. > > Do you think it's a good idea to move ahead with a v2 of the ravb WoL > patch to fix the unrelated issue and aim for it to be picked up prior to > suspend/resume support is added to the CPG/MSSR? Sure. It can still be used on R-Car Gen2, where we're not s*d by ma

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-16 Thread Geert Uytterhoeven
Hi Niklas, On Fri, May 12, 2017 at 11:12 PM, Niklas Söderlund <niklas.soderl...@ragnatech.se> wrote: > On 2017-05-12 16:43:55 +0200, Geert Uytterhoeven wrote: >> On Fri, May 12, 2017 at 4:32 PM, Niklas Söderlund >> <niklas.soderl...@ragnatech.se> wrote: >> >

Re: [PATCH 1/2] fsl/fman: propagate dma_ops

2017-06-26 Thread Geert Uytterhoeven
Hi Madalin, On Mon, Jun 26, 2017 at 4:55 PM, Madalin-cristian Bucur <madalin.bu...@nxp.com> wrote: >> -Original Message- >> From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] >> On Behalf Of Geert Uytterhoeven >> Sent: Monday, June 26

Re: [PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Geert Uytterhoeven
> It would be nice to specify the commit that caused this. That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops"). However, none of the fman code uses any DMA API calls, so IMHO the set_dma_ops() should be done somewhere else. Gr{oetje,eeting}s, G

Re: [PATCH 1/2] fsl/fman: propagate dma_ops

2017-06-26 Thread Geert Uytterhoeven
file? If it's really needed, can't set_dma_ops() be called from the driver that needs it, cfr. your other patch "[PATCH 2/2] dpaa_eth: reuse the dma_ops provided by the FMan MAC device"? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots o

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-05-18 Thread Geert Uytterhoeven
Hi Andrew, On Thu, May 18, 2017 at 6:09 PM, Andrew Lunn <and...@lunn.ch> wrote: > On Thu, May 18, 2017 at 02:59:05PM +0200, Geert Uytterhoeven wrote: >> If an Ethernet PHY is initialized before the interrupt controller it is >> connected to, a message like the following is p

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-05-18 Thread Geert Uytterhoeven
to complain when someone broke polling, than to fix the real problem ;-) But when I saw Thomas' patch[*] for of_irq_to_resource(), the time was ripe to tackle the root cause. [*] https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next=7a4228bbff769ebf449981a4248616db9f0cffec Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

[PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-05-18 Thread Geert Uytterhoeven
2. Propagate and handle errors from of_mdiobus_register_phy() and of_mdiobus_register_device(). Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- Seen on r8a7791/koelsch when using the new CPG/MSSR clock driver. I assume it always happened on RZ/G1 in mainline. ---

[PATCH 2/2] sh_eth: Do not print an error message for probe deferral

2017-05-18 Thread Geert Uytterhoeven
-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/net/ethernet/renesas/sh_eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index c85222b02754f5a7..2d686ccf971b1b65 100644 --- a/drive

[PATCH 1/2] sh_eth: Use platform device for printing before register_netdev()

2017-05-18 Thread Geert Uytterhoeven
h_eth: Register MDIO bus before registering the network device") Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-05-18 Thread Geert Uytterhoeven
Hi Florian, On Thu, May 18, 2017 at 8:25 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 05/18/2017 05:59 AM, Geert Uytterhoeven wrote: >> If an Ethernet PHY is initialized before the interrupt controller it is >> connected to, a message like the following is p

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-05-18 Thread Geert Uytterhoeven
s probably not been tested in anger. It would be good to test > this properly, with not just the first PHY returning -EPROBE_DEFER, to > really test the unwind. Unfortunately I don't have a board with multiple PHYs, so I cannot test that case. Does unbinding/rebinding a network driver with multip

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-05-23 Thread Geert Uytterhoeven
Hi Florian, On Fri, May 19, 2017 at 12:21 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 05/18/2017 01:36 PM, Geert Uytterhoeven wrote: >> On Thu, May 18, 2017 at 9:34 PM, Andrew Lunn <and...@lunn.ch> wrote: >>>>> This most certainly works fine in th

ravb WoL interrupt flood

2017-05-30 Thread Geert Uytterhoeven
status 0x, tx mask 0x0001. ... Unfortunately I cannot reproduce it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when

[PATCH v3 1/6] arm64: dts: lg1312: DT fix s/#interrupts-cells/#interrupt-cells/

2017-06-02 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Chanho Min <chanho@lge.com> --- v3: - Add Acked-by, v2: - Add Acked-by, - Rebased. --- arch/arm64/boot/dts/lg/lg1312.dtsi | 2 +- 1 file changed, 1 insert

[PATCH v3 2/6] arm64: dts: lg1313: DT fix s/#interrupts-cells/#interrupt-cells/

2017-06-02 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Chanho Min <chanho@lge.com> --- v3: - Add Acked-by, v2: - New. --- arch/arm64/boot/dts/lg/lg1313.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/lg/lg1313.dtsi

[PATCH v3 3/6] dt: booting-without-of: DT fix s/#interrupt-cell/#interrupt-cells/

2017-06-02 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Rob Herring <r...@kernel.org> --- v3: - No changes, v2: - Add Acked-by. --- Documentation/devicetree/booting-without-of.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentatio

[PATCH v3 4/6] powerpc: dts: acadia: DT fix s/#interrupts-parent/#interrupt-parent/

2017-06-02 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Rob Herring <r...@kernel.org> --- v3: - No changes, v2: - Add Acked-by. --- arch/powerpc/boot/dts/acadia.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/dts/acadi

[PATCH v3 5/6] dt-bindings: display: amlogic: DT fix s/resets-names/reset-names/

2017-06-02 Thread Geert Uytterhoeven
Fixes: 8cceda5349377e30 ("dt-bindings: Add bindings for the Amlogic Meson dw-hdmi extension") Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- v3: - New. --- Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt | 2 +- 1 file changed, 1 insertio

[PATCH v3 0/6] DT: Fix spelling of standard properties

2017-06-02 Thread Geert Uytterhoeven
uot; # false positive phys-cells git grep -E "#${words}-cell\>[^-]" git grep -w adress-cells git grep -Ew "interrupts-(map|parent)" Geert Uytterhoeven (6): arm64: dts: lg1312: DT fix s/#interrupts-cells/#interrupt-cells/ arm64: dts: lg1313: DT fix s/#int

[PATCH v3 6/6] dt-bindings: net: btusb: DT fix s/interrupt-name/interrupt-names/

2017-06-02 Thread Geert Uytterhoeven
Fixes: fd913ef7ce619467 ("Bluetooth: btusb: Add out-of-band wakeup support") Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- v3: - New. --- Documentation/devicetree/bindings/net/btusb.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-06-06 Thread Geert Uytterhoeven
Hi Florian, On Tue, May 23, 2017 at 11:36 AM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > On Fri, May 19, 2017 at 12:21 AM, Florian Fainelli <f.faine...@gmail.com> > wrote: >> On 05/18/2017 01:36 PM, Geert Uytterhoeven wrote: >>> On Thu, May

Re: [PATCH 33/44] openrisc: remove arch-specific dma_supported implementation

2017-06-09 Thread Geert Uytterhoeven
Hellwig <h...@lst.de> > --- > arch/openrisc/include/asm/dma-mapping.h | 7 --- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. Bu

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-06-12 Thread Geert Uytterhoeven
Hi Niklas, On Mon, Jun 12, 2017 at 1:32 PM, Niklas Söderlund <niklas.soderl...@ragnatech.se> wrote: > On 2017-05-18 10:52:25 +0200, Geert Uytterhoeven wrote: >> On Tue, May 16, 2017 at 2:16 PM, Niklas Söderlund >> <niklas.soderl...@ragnatech.se> wrote: >> >

xfrm4_state_afinfo size increase (was: Re: xfrm: Add a xfrm type offload.)

2017-05-04 Thread Geert Uytterhoeven
may occur? Perhaps type_offload_map[] (and type_map[] while at it) can be allocated at runtime instead, when the feature is used? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technic

[PATCH] test_bpf: Use ULL suffix for 64-bit constants

2017-05-03 Thread Geert Uytterhoeven
for ‘unsigned long’ type On 32-bit systems, "long" is only 32-bit. Replace the "UL" suffix by "ULL" to fix this. Fixes: 85f68fe898320575 ("bpf, arm64: implement jiting of BPF_XADD") Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- lib/test_bpf.c

Re: [PATCH v2] net: smsc911x: Quieten netif during suspend

2017-09-14 Thread Geert Uytterhoeven
Hi Florian, On Thu, Sep 14, 2017 at 1:28 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 09/13/2017 10:42 AM, Geert Uytterhoeven wrote: >> If the network interface is kept running during suspend, the net core >> may call net_device_ops.ndo_start_xmit() whil

Re: [PATCH 0/2] net: Fix crashes due to activity during suspend

2017-09-13 Thread Geert Uytterhoeven
Hi Florian, On Thu, Sep 7, 2017 at 3:09 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 08/23/2017 10:13 AM, Florian Fainelli wrote: >> On 08/23/2017 04:45 AM, Geert Uytterhoeven wrote: >>> On Tue, Aug 22, 2017 at 8:49 PM, Florian Fainelli <f.faine...@gmail.com

[PATCH v2] net: smsc911x: Quieten netif during suspend

2017-09-13 Thread Geert Uytterhoeven
ntk/parameters/console_suspend # echo platform > /sys/power/pm_test # echo mem > /sys/power/state To fix this, make sure the network interface is quietened during suspend. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- This is v2 of the series "[PATCH 0/2]

[PATCH] net: phy: Fix truncation of large IRQ numbers in phy_attached_print()

2017-09-21 Thread Geert Uytterhoeven
tmmac: Delete dead code for MDIO registration") Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/net/phy/phy_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 8cf0c5901f95870f..

Re: [PATCH net-next 3/3] net: sh_eth: implement R-Car Gen[12] fallback compatibility strings

2017-10-17 Thread Geert Uytterhoeven
r is being adopted? > drivers for Renesas SoCs. > > Note that R-Car Gen2 and RZ/G1 have many compatible IP blocks. The > approach that has been consistently taken for other IP blocks is to name > common code, compatibility strings and so on after Rcar Gen2. > > Signed-off-by: Simon

Re: [PATCH net-next 1/3] dt-bindings: net: sh_eth: add R-Car Gen[12] fallback compatibility strings

2017-10-17 Thread Geert Uytterhoeven
r is being adopted? > drivers for Renesas SoCs. > > Note that R-Car Gen2 and RZ/G1 have many compatible IP blocks. The > approach that has been consistently taken for other IP blocks is to name > common code, compatibility strings and so on after Rcar Gen2. > > Signed-off-by: Simon

Re: [PATCH net-next 2/3] net: sh_eth: rename name structures as rcar_gen[12]_*

2017-10-17 Thread Geert Uytterhoeven
Also rename sh_eth_set_rate_r8a777x as sh_eth_set_rate_rcar as > it it is used by the R-Car generations supported by the driver. > > This patch should have no run-time effect and > is compile-tested only. > > Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Reviewed-by: Gee

Re: [PATCH] ravb: Consolidate clock handling

2017-10-12 Thread Geert Uytterhoeven
Hi Simon, On Thu, Oct 12, 2017 at 11:55 AM, Simon Horman <ho...@verge.net.au> wrote: > On Thu, Oct 12, 2017 at 10:24:53AM +0200, Geert Uytterhoeven wrote: >> The module clock is used for two purposes: >> - Wake-on-LAN (WoL), which is optional, >> - gPTP Timer In

[PATCH] ravb: Consolidate clock handling

2017-10-12 Thread Geert Uytterhoeven
by making GTI use the stored clock for WoL use. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/net/ethernet/renesas/ravb_main.c | 35 +--- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/renesas/ravb_mai

Re: [PATCH] netfilter: xt_hashlimit: avoid 64-bit division

2017-09-07 Thread Geert Uytterhoeven
ashlimit: add rate match mode") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, this fixes a similar issue (__udivdi3 undefined) on m68k. Acked-by: Geert Uytterhoeven <ge...@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoe

Re: [PATCH] ravb: document R8A77970 bindings

2017-09-13 Thread Geert Uytterhoeven
bedded.com> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm

Re: [PATCH] dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB

2017-09-13 Thread Geert Uytterhoeven
On Wed, Sep 13, 2017 at 2:17 PM, Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> wrote: > Add a new compatible string for the R8A77995 (R-Car D3) RAVB. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Acked-by: Geert Uytterhoeven <geert+rene

Division by zero on UP (was: Re: netfilter: nat: use keyed locks)

2017-09-10 Thread Geert Uytterhoeven
: division by zero net/netfilter/nf_nat_core.c:537: warning: division by zero net/netfilter/nf_nat_core.c: In function ‘nf_nat_init’: net/netfilter/nf_nat_core.c:810: warning: division by zero net/netfilter/nf_nat_core.c:811: warning: division by zero net/netfilter/nf_nat

Re: Division by zero on UP (was: Re: netfilter: nat: use keyed locks)

2017-09-10 Thread Geert Uytterhoeven
Hi Florian, On Sun, Sep 10, 2017 at 1:21 PM, Florian Westphal <f...@strlen.de> wrote: > Geert Uytterhoeven <ge...@linux-m68k.org> wrote: >> > srchash = hash_by_src(net, >> > >>

[PATCH] netfilter: nat: Do not use ARRAY_SIZE() on spinlocks to fix zero div

2017-09-10 Thread Geert Uytterhoeven
. Suggested-by: Florian Westphal <f...@strlen.de> Fixes: 8073e960a03bf7b5 ("netfilter: nat: use keyed locks") Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- net/netfilter/nf_nat_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH 1/4] dt-bindings: net: ravb: Document optional reset-gpios property

2017-09-28 Thread Geert Uytterhoeven
The optional "reset-gpios" property (part of the generic MDIO bus properties) lets us describe the GPIO used for resetting the Ethernet PHY. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 2 ++ 1 file chang

[PATCH 3/4] arm64: dts: renesas: salvator-common: Add EthernetAVB PHY reset

2017-09-28 Thread Geert Uytterhoeven
-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- For proper PHY reset operation during system resume, this depends on "ravb: Add missing PHY reset during system resume". However, this patch can be applied independently. --- arch/arm64/boot/dts/renesas/salvator-common.dt

[PATCH 4/4] arm64: dts: renesas: ulcb: Add EthernetAVB PHY reset

2017-09-28 Thread Geert Uytterhoeven
by the bootloader before. Inspired by patches in the BSP for the individual Salvator-X/XS boards by Kazuya Mizuguchi. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- Compile-tested only. --- arch/arm64/boot/dts/renesas/ulcb.dtsi | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 0/4] ravb: Add PHY reset support

2017-09-28 Thread Geert Uytterhoeven
files. Thanks! Geert Uytterhoeven (4): dt-bindings: net: ravb: Document optional reset-gpios property ravb: Add optional PHY reset during system resume arm64: dts: renesas: salvator-common: Add EthernetAVB PHY reset arm64: dts: renesas: ulcb: Add EthernetAVB PHY reset Documentation

[PATCH 2/4] ravb: Add optional PHY reset during system resume

2017-09-28 Thread Geert Uytterhoeven
alvator-XS, where the enable pin of the regulator providing PHY power is connected to PRESETn, and PSCI suspend powers down the SoC. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/net/ethernet/renesas/ravb_main.c | 9 + 1 file changed, 9 insertions(+) diff --g

Re: [PATCH 2/4] ravb: Add optional PHY reset during system resume

2017-09-28 Thread Geert Uytterhoeven
Hi Florian, On Thu, Sep 28, 2017 at 7:22 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 09/28/2017 08:53 AM, Geert Uytterhoeven wrote: >> If the optional "reset-gpios" property is specified in DT, the generic >> MDIO bus code takes care of resett

Re: [PATCH] ravb: make mdiobb_ops const

2017-08-22 Thread Geert Uytterhoeven
e > "renesas: make mdiobb_ops const". With that fixed, you have my: "net: renesas: make mdiobb_ops const"? There are plenty of other Renesas-specific drivers spread all over the tree. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of L

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-29 Thread Geert Uytterhoeven
0) [] (kernel_init) from [] (ret_from_fork+0x14/0x24) DIsabling CONFIG_IRDA (apparently I wasn't using it anyway), and continuing my life... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversatio

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-29 Thread Geert Uytterhoeven
Hi Greg, On Tue, Aug 29, 2017 at 1:28 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Tue, Aug 29, 2017 at 01:11:31PM +0200, Stefano Brivio wrote: >> On Tue, 29 Aug 2017 12:59:00 +0200 >> Geert Uytterhoeven <ge...@linux-m68k.org> wrote: >> > O

Re: Build regressions/improvements in v4.14-rc2

2017-09-27 Thread Geert Uytterhoeven
On Wed, Sep 27, 2017 at 9:26 AM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > JFYI, when comparing v4.14-rc2[1] to v4.14-rc1[3], the summaries are: > - build errors: +1/-2 + /home/kisskb/slave/src/drivers/net/ethernet/intel/i40e/i40e_ethtool.c: error: implicit declaration

[PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-18 Thread Geert Uytterhoeven
upt. 2. Propagate and handle errors from of_mdiobus_register_phy() and of_mdiobus_register_device(). Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- Seen on e.g. r8a7791/koelsch when using the new CPG/MSSR clock driver, which will hit upstream in v4.15. I assume

Re: [PATCH 12/14] nubus: Rename struct nubus_dev

2017-11-13 Thread Geert Uytterhoeven
ill then bind with boards, not with functional > resources. > > Rename struct nubus_dev as struct nubus_functional_resource. This is > the vendor's terminology and avoids confusion. Isn't "struct nubus_functional_resource" a bit long? What about "nubus_res"? "nubus_fres&

Re: [PATCH 26/31] nds32: Build infrastructure

2017-11-13 Thread Geert Uytterhoeven
en exist, except in Documentation/kbuild/kconfig-language.txt, so it cannot be selected. Given the checks for __NDS32_EB__, NDS32 can be either big or little endian, so you should have (excatly one of) CPU_BIG_ENDIAN or CPU_LITTLE_ENDIAN set. Gr{oetje,eeting}s, Geert -- Ge

[PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit

2017-11-29 Thread Geert Uytterhoeven
((struct sk_buff *)cur_p->app4); ^ cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer. Note that several other fields in struct cdmac_bd are also too small to hold physical addresses on 64-bit platforms. Signed-off-by: Geert Uytterhoeven <geert+rene...@gli

Re: [PATCH v2 25/35] nds32: Build infrastructure

2017-11-29 Thread Geert Uytterhoeven
; as well, e.g. CPU specific compiler optimizations. Do you want to support multiple CPU types in a single kernel image (I see no "choice" statement above)? If yes, you may have a mix of aliasing and non-aliasing caches, so you may want to invert the logic, and sele

Re: [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-11-26 Thread Geert Uytterhoeven
Hi Florian, On Mon, Nov 27, 2017 at 5:05 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 11/06/2017 07:50 AM, Geert Uytterhoeven wrote: >> On Tue, Oct 31, 2017 at 5:33 PM, Florian Fainelli <f.faine...@gmail.com> >> wrote: >>> On 10/31/2017 08:26 AM, G

Re: [PATCH v2 25/35] nds32: Build infrastructure

2017-11-29 Thread Geert Uytterhoeven
bool "Non-aliasing cache" > depends on !CPU_N10 && !CPU_D10 > default n > help > If this CPU is using VIPT data cache and its cache way size is > larger > than page size, say N. If it is using PIPT data cache, say Y.

[PATCH/trivial] skbuff: Grammar s/are can/can/, s/change/changes/

2017-11-30 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- include/linux/skbuff.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index bc486ef23f20f91c..a38c80e9f91efee0 100644 --- a/include/linux/skbuff.h +++ b/i

Re: [PATCH 1/2] net: sh_eth: use correct "struct device" when calling DMA mapping functions

2017-12-05 Thread Geert Uytterhoeven
ver mistakenly uses the "struct device" > representing the logical device (embedded in "struct net_device") > rather than the "struct device" representing the physical device on > its bus. > > This commit fixes that by adjusting all calls to the DMA mapping

Re: [PATCH 2/2] net: sh_eth: don't use NULL as "struct device" for the DMA mapping API

2017-12-05 Thread Geert Uytterhoeven
ore, pass the appropriate "struct > device". > > Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots o

Re: [PATCH 1/2] net: sh_eth: use correct "struct device" when calling DMA mapping functions

2017-12-05 Thread Geert Uytterhoeven
> is better That was going to be my comment, too. I also haven't checked which generates the smallest code. > (although I'm seeing very strange things in the ravb driver built > with AArch654 gcc 4.8.5). Don't worry, you've just been bitten by the %p point

Re: [PATCH 1/2] net: sh_eth: use correct "struct device" when calling DMA mapping functions

2017-12-05 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Dec 5, 2017 at 10:38 AM, Thomas Petazzoni <thomas.petazz...@free-electrons.com> wrote: > On Tue, 5 Dec 2017 09:39:35 +0100, Geert Uytterhoeven wrote: >> >Using 'ndev->dev.parent' (as in ravb) also should work... not sure which >> > is better

<    1   2   3   4   5   >