[PATCH] drivers: net: cpsw: use module_platform_driver

There is no reasons to probe cpsw from late_initcall level and it's not recommended. Hence, use module_platform_driver() to register and probe cpsw driver from module_init() level. Cc: Tony Lindgren <t...@atomide.com> Acked-by: Mugunthan V N <mugunthan...@ti.com> Signed-off-by: Grygo

Re: [4.1.3-rt8] [report][cpuhotplug] BUG: spinlock bad magic on CPU#0, sh/137

On 10/12/2015 11:16 AM, Thomas Gleixner wrote: > On Fri, 9 Oct 2015, Grygorii Strashko wrote: >> I can constantly see below error report with 4.1 RT-kernel on TI ARM dra7-evm >> if I'm trying to unplug cpu1: >> >> [ 57.737589] CPU1: shutdown >> [ 57.767537] BUG

[4.1.3-rt8] [report][cpuhotplug] BUG: spinlock bad magic on CPU#0, sh/137

Hi All, I can constantly see below error report with 4.1 RT-kernel on TI ARM dra7-evm if I'm trying to unplug cpu1: [ 57.737589] CPU1: shutdown [ 57.767537] BUG: spinlock bad magic on CPU#0, sh/137 [ 57.767546] lock: 0xee994730, .magic: , .owner: /-1, .owner_cpu: 0 [

Re: [PATCH] net/smsc911x: Fix deferred probe for interrupt

On 08/30/2015 12:33 AM, Sergei Shtylyov wrote: > Hello. > > On 8/28/2015 9:50 PM, Tony Lindgren wrote: > >> The interrupt handler may not be available when smsc911x probes if the >> interrupt handler is a GPIO controller for example. Let's fix that >> by adding handling for -EPROBE_DEFER. > >>

Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock

in_lock_init(>lock); priv->pdev = pdev; priv->ndev = ndev; priv->dev = >dev; Reviewed-by: Grygorii Strashko <grygorii.stras...@ti.com> -- regards, -grygorii

Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency

e patch is based on master. Reviewed-by: Grygorii Strashko <grygorii.stras...@ti.com> drivers/net/ethernet/ti/cpsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 7b44587..9919cb3 100644 ---

Re: [PATCH] net: ethernet: ti: cpsw: remove rx_descs property

On 06/03/2016 01:43 AM, Ivan Khoronzhuk wrote: There is no reason to hold s/w dependent parameter in device tree. Even more, there is no reason in this parameter because davinici_cpdma driver splits pool of descriptors equally between tx and rx channels. That is, if number of descriptors 256,

Re: [PATCH] net: ethernet: ti: cpsw: remove rx_descs property

On 06/03/2016 09:25 PM, Ivan Khoronzhuk wrote: > > > On 03.06.16 19:50, Grygorii Strashko wrote: >> On 06/03/2016 01:43 AM, Ivan Khoronzhuk wrote: >>> There is no reason to hold s/w dependent parameter in device tree. >>> Even more, there is no reason in this

[PATCH 07/15] drivers: net: davinci_mdio: remove pm runtime calls from suspend callbacks

PM runtime is disabled when Davinci MDIO .suspend_late() and .resume_early() callbacks are called. As result, any PM runtime calls here will be just a nop and can be removed. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 3 ---

[PATCH 00/15] drivers: net: cpsw: improve runtime pm

d for Davinci MDIO) These changes should not affect on errata i877 implementation on DRA7. Power measurement on am335x GP EVM: Without this series: 547.60 mW total SoC power With this series + "ifconfig eth0 down": 477.32 mW Total Soc Power Grygorii Strashko (15): drivers: net: cps

[PATCH 05/15] drivers: net: cpsw: ndev: fix accessing to suspended device

callbacks which can access CPSW registers: .ndo_set_mac_address(), .ndo_vlan_rx_add_vid(), .ndo_vlan_rx_kill_vid(). Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 33 ++--- 1 file changed, 30 insertions(+), 3 del

[PATCH 03/15] drivers: net: cpsw: remove pm runtime calls from suspend callbacks

, before System suspend started. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index c76f9db..ba81d4e 100644 --- a/drivers/net/et

[PATCH 06/15] drivers: net: davinci_mdio: do pm runtime initialization later in probe

Do PM runtime initialization later in probe - this allows to simplify error handling a bit. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drive

[PATCH 02/15] drivers: net: cpsw: check return code from pm runtime calls

Add missed check of return codes from PM runtime get() calls. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ether

[PATCH 11/15] drivers: net: davinci_mdio: implement pm runtime auto mode

dio/power/autosuspend_delay_ms Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 48 +++--- 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/et

[PATCH 04/15] drivers: net: cpsw: ethtool: fix accessing to suspended device

access CPSW registers: .set_coalesce(), .get_ethtool_stats(), .set_pauseparam(), .get_regs() Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff

[PATCH 08/15] drivers: net: davinci_mdio: drop suspended and lock fields from mdio_data

. Hence, it's safe to drop "suspended" and "lock" fields from mdio_data. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/drivers/net/eth

[PATCH 14/15] drivers: net: davinci_mdio: enable pm runtime auto for ti cpsw-mdio

Use "ti,cpsw-mdio" to enable PM runtime auto-suspend on supported platforms, where MDIO is implemented as part of TI CPSW. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 45 +- 1 file change

[PATCH 10/15] drivers: net: davinci_mdio: add pm runtime callbacks

-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c index b206fd3..13f5080

[PATCH 15/15] ARM: dts: am335x/am437x/dra7: use new "ti,cpsw-mdio" compat string

Add "ti,cpsw-mdio" for am335x/am437x/dra7 SoCs where MDIO is implemented as part of TI CPSW and, this way, enable PM runtime auto suspend for Davinci MDIO driver on these paltforms. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- arch/arm/boot/dts/am33xx.dtsi

[PATCH 09/15] drivers: net: davinci_mdio: split reset function on init_clk and enable

The Davinci MDIO MDIO_CONTROL.CLKDIV can be calculated only once during probe, hence split __davinci_mdio_reset() on davinci_mdio_init_clk() and davinci_mdio_enable(). Initialize and save CLKDIV in .probe(). Then just use saved value. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.

[PATCH 12/15] net: davinci_mdio: document missed "ti,am4372-mdio" compat string

Document missed "ti,am4372-mdio" compat string used for TI am437x SoC (am4372.dtsi). Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- Documentation/devicetree/bindings/net/davinci-mdio.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 13/15] net: davinci_mdio: introduce "ti,cpsw-mdio" compat string

Introduce "ti,cpsw-mdio" compatible string for Davinci MDIO, because it's required to distinguish the case when MDIO is part of TI CPSW to enable features supported by TI CPSW (for example, enable PM management). Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --

[PATCH 01/15] drivers: net: cpsw: fix suspend when all ethX devices are down

. Hence, fix it by moving soft_reset_slave() from cpsw_suspend() to cpsw_slave_stop(). This way slave ports will be reset when CPSW is active and will be in proper state during Suspend. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 3 +-- 1 file c

Re: [PATCH 04/15] drivers: net: cpsw: ethtool: fix accessing to suspended device

On 06/15/2016 07:14 PM, Florian Fainelli wrote: On 06/15/2016 04:55 AM, Grygorii Strashko wrote: The CPSW might be suspended by RPM if all ethX interfaces are down, but it still could be accesible through ethtool interfce. In this case ethtool operations, requiring registers access, will cause

Re: [PATCH 12/15] net: davinci_mdio: document missed "ti,am4372-mdio" compat string

On 06/19/2016 05:35 PM, Rob Herring wrote: > On Wed, Jun 15, 2016 at 02:56:00PM +0300, Grygorii Strashko wrote: >> Document missed "ti,am4372-mdio" compat string used for TI am437x SoC >> (am4372.dtsi). >> >> Signed-off-by: Grygorii Strashko <grygorii.st

[PATCH] net: ethernet: ti: cpdma: switch to use genalloc

channel for limitation of max number of allowed descriptors for each CPDMA channel. This patch do not affect on net throuput. Cc: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- Testing TCP window: 256K, bandwidth in Mbits/sec:

[PATCH v2] net: ethernet: ti: cpdma: switch to use genalloc

channel for limitation of max number of allowed descriptors for each CPDMA channel. This patch do not affect on net throuput. Tested-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- Testing TCP window: 256K, bandwidth in Mbit

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

On 06/24/2016 07:15 PM, Lennart Sorensen wrote: > On Fri, Jun 24, 2016 at 11:35:15AM +0530, Mugunthan V N wrote: +static void cpdma_desc_pool_destroy(struct cpdma_desc_pool *pool) +{ +if (!pool) +return; + +WARN_ON(pool->used_desc); +if

[PATCH v2 15/15] ARM: dts: am335x/am437x/dra7: use new "ti,cpsw-mdio" compat string

Add "ti,cpsw-mdio" for am335x/am437x/dra7 SoCs where MDIO is implemented as part of TI CPSW and, this way, enable PM runtime auto suspend for Davinci MDIO driver on these paltforms. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- arch/arm/boot/dts/am33xx.dtsi

[PATCH v2 14/15] drivers: net: davinci_mdio: enable pm runtime auto for ti cpsw-mdio

Use "ti,cpsw-mdio" to enable PM runtime auto-suspend on supported platforms, where MDIO is implemented as part of TI CPSW. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 45 +- 1 file change

[PATCH v2 13/15] net: davinci_mdio: introduce "ti,cpsw-mdio" compat string

Introduce "ti,cpsw-mdio" compatible string for Davinci MDIO, because it's required to distinguish the case when MDIO is part of TI CPSW to enable features supported by TI CPSW (for example, enable PM management). Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --

[PATCH v2 08/15] drivers: net: davinci_mdio: drop suspended and lock fields from mdio_data

safe to drop "suspended" and "lock" fields from mdio_data. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/drivers/net/ethernet/ti/dav

[PATCH v2 12/15] net: davinci_mdio: document missed "ti,am4372-mdio" compat string

Document missed "ti,am4372-mdio" compat string used for TI am437x SoC (am4372.dtsi). Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- Documentation/devicetree/bindings/net/davinci-mdio.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v2 05/15] drivers: net: cpsw: ndev: fix accessing to suspended device

callbacks which need to access CPSW registers: .ndo_set_mac_address(), .ndo_vlan_rx_add_vid(), .ndo_vlan_rx_kill_vid(). Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 33 ++--- 1 file changed, 30 insertions

[PATCH v2 11/15] drivers: net: davinci_mdio: implement pm runtime auto mode

wer/autosuspend_delay_ms Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 48 +++--- 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davin

[PATCH v2 09/15] drivers: net: davinci_mdio: split reset function on init_clk and enable

The Davinci MDIO MDIO_CONTROL.CLKDIV can be calculated only once during probe, hence split __davinci_mdio_reset() on davinci_mdio_init_clk() and davinci_mdio_enable(). Initialize and save CLKDIV in .probe(). Then just use saved value. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.

[PATCH v2 04/15] drivers: net: cpsw: ethtool: fix accessing to suspended device

-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index ba81d4e..5fea986 100644 --- a/drive

[PATCH v2 06/15] drivers: net: davinci_mdio: do pm runtime initialization later in probe

Do PM runtime initialization later in probe - this allows to simplify error handling a bit. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drive

[PATCH v2 07/15] drivers: net: davinci_mdio: remove pm runtime calls from suspend callbacks

PM runtime is disabled when Davinci MDIO .suspend_late() and .resume_early() callbacks are called. As result, any PM runtime calls here will be just a nop and can be removed. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 3 ---

[PATCH v2 10/15] drivers: net: davinci_mdio: add pm runtime callbacks

-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c index b206fd3..13f5080

[PATCH v2 01/15] drivers: net: cpsw: fix suspend when all ethX devices are down

. Hence, fix it by moving soft_reset_slave() from cpsw_suspend() to cpsw_slave_stop(). This way slave ports will be reset when CPSW is active and will be in proper state during Suspend. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 3 +-- 1 file c

[PATCH v2 02/15] drivers: net: cpsw: check return code from pm runtime calls

Add missed check of return code from PM runtime get() calls. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ether

[PATCH v2 00/15] drivers: net: cpsw: improve runtime pm

e updated to use .begin()/.complete() callbacks - kbuild failure fixed - davinci_mdio DT updated with proper description of allowed compatible strings combinations Link on v1: https://lkml.org/lkml/2016/6/15/362 Grygorii Strashko (15): drivers: net: cpsw: fix suspend when all ethX devices are do

[PATCH v2 03/15] drivers: net: cpsw: remove pm runtime calls from suspend callbacks

already, before System suspend started. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index c76f9db..ba81d4e 100644 --- a/drive

Re: Keystone 2 boards boot failure

Hi Arnd, On 02/03/2016 10:40 PM, Arnd Bergmann wrote: > On Wednesday 03 February 2016 18:31:00 Grygorii Strashko wrote: >> On 02/03/2016 06:20 PM, Arnd Bergmann wrote: >>> On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: >>>> On 02/03/2016 04:11 P

Re: Keystone 2 boards boot failure

hi Arnd, On 02/05/2016 06:18 PM, Arnd Bergmann wrote: > On Thursday 04 February 2016 18:25:08 Grygorii Strashko wrote: >>> >>> I have another version for testing below. That removes the logic that >>> splits and reassembles the 64-bit values, but leaves the other cha

[PATCH] net: ti: netcp: restore get/set_pad_info() functionality

5361.html Cc: Wingman Kwok <w-kw...@ti.com> Cc: Murali Karicheri <m-kariche...@ti.com> Cc: Mugunthan V N <mugunthan...@ti.com> Reported-by: Franklin S Cooper Jr <fcoo...@ti.com> Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Grygorii Strashko <grygorii

Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

Hi All, On 02/09/2016 09:38 PM, Arnd Bergmann wrote: > On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote: >> >> The descriptors are usable by different drivers, one driver may use it as >> buf ptr/ len, other for something else. So they should remain as generic >> and it is up to

Re: Keystone 2 boards boot failure

On 02/04/2016 03:07 PM, Arnd Bergmann wrote: > On Thursday 04 February 2016 14:19:54 Grygorii Strashko wrote: >> On 02/03/2016 10:40 PM, Arnd Bergmann wrote: >>> On Wednesday 03 February 2016 18:31:00 Grygorii Strashko wrote: >>>> On 02/03/2016 06:20 PM, Arnd Bergman

Re: Keystone 2 boards boot failure

On 02/03/2016 06:20 PM, Arnd Bergmann wrote: > On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: >> On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote: >>> On 02/02/2016 07:19 PM, Franklin S Cooper Jr. wrote: >>>>> >>>> So

Re: Keystone 2 boards boot failure

hernet/ti/netcp_core.c >>> +++ b/drivers/net/ethernet/ti/netcp_core.c >>> @@ -167,7 +167,7 @@ static void set_pad_info(u32 pad0, u32 pad1, u32 pad2, >>> struct knav_dma_desc *des >>> { >>> desc->pad[0] = cpu_to_le32(pad0); >>>

Re: Keystone 2 boards boot failure

On 02/03/2016 06:20 PM, Arnd Bergmann wrote: On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote: On 02/02/2016 07:19 PM, Franklin S Cooper Jr. wrote: So only making this change on the latest master with no other changes I see

[PATCH 1/2] drivers: net: cpsw: fix port_mask parameters in ale calls

t;host_port" from all places where it's used to shift valid port mask. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c

[PATCH 2/2] drivers: net: cpsw: drop host_port field from struct cpsw_priv

field and it can be removed, and the HOST_PORT_NUM and ALE_PORT_HOST defines can be used instead. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/d

[PATCH 0/2] drivers: net: cpsw: fix ale calls and drop host_port field from cpsw_priv

This clean up series intended to: - fix port_mask parameters in ale calls and drop unnecessary shifts - drop host_port field from struct cpsw_priv Nothing critical. Tested on am437x-idk-evm in dual mac and switch modes. Grygorii Strashko (2): drivers: net: cpsw: fix port_mask parameters

Re: am335x: no multicast reception over VLAN

On 03/31/2016 10:52 AM, Yegor Yefremov wrote: > On Thu, Mar 31, 2016 at 8:37 AM, Mugunthan V N wrote: >> On Thursday 31 March 2016 01:17 AM, Peter Korsgaard wrote: "Mugunthan" == Mugunthan V N writes: >>> >>> Hi, >>> >>> > You had received

Re: am335x: no multicast reception over VLAN

On 03/29/2016 08:21 AM, Yegor Yefremov wrote: > Hi Mugunthan, > > On Tue, Mar 29, 2016 at 6:00 AM, Mugunthan V N wrote: >> Hi Yegor >> >> On Wednesday 16 March 2016 08:35 PM, Yegor Yefremov wrote: >>> I have an am335x based board using CPSW in Dual EMAC mode. Without >>>

Re: am335x: no multicast reception over VLAN

On 03/29/2016 03:35 PM, Yegor Yefremov wrote: > On Tue, Mar 29, 2016 at 1:05 PM, Grygorii Strashko > <grygorii.stras...@ti.com> wrote: >> On 03/29/2016 08:21 AM, Yegor Yefremov wrote: >>> Hi Mugunthan, >>> >>> On Tue, Mar 29, 2016 at 6:00 AM, Mugun

Re: [PATCH net v2 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config

On 04/22/2016 04:03 PM, Grygorii Strashko wrote: > On 04/21/2016 09:19 PM, David Rivshin (Allworx) wrote: >> From: David Rivshin <drivs...@allworx.com> >> >> Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add >> phy-handle parsing"

Re: [PATCH net v2 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

On 04/22/2016 06:45 PM, David Rivshin (Allworx) wrote: > On Fri, 22 Apr 2016 16:03:34 +0300 > Grygorii Strashko <grygorii.stras...@ti.com> wrote: > >> On 04/21/2016 09:26 PM, David Rivshin (Allworx) wrote: >>> From: David Rivshin <drivs...@allworx.com> >&

Re: [PATCH net v2 3/3] drivers: net: cpsw: use of_phy_connect() in fixed-link case

dified the deleted snprintf) - Added Tested-by from Nicolas Chauvet [1] https://patchwork.ozlabs.org/patch/560327/ Reviewed-by: Grygorii Strashko <grygorii.stras...@ti.com> drivers/net/ethernet/ti/cpsw.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/driver

Re: [PATCH net v2 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

On 04/21/2016 09:26 PM, David Rivshin (Allworx) wrote: > From: David Rivshin > > The phy-handle, phy_id, and fixed-link properties are mutually exclusive, > and only one need be specified. However if phy-handle was specified, an > error message would complain about the lack

Re: [PATCH net v2 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config

nges since v1 [1]: - Rebased (no conflicts) - Added Tested-by from Nicolas Chauvet [1] https://patchwork.ozlabs.org/patch/560326/ Reviewed-by: Grygorii Strashko <grygorii.stras...@ti.com> drivers/net/ethernet/ti/cpsw.c | 13 ++--- drivers/net/ethernet/ti/cpsw.h | 1 + 2 file

Re: [PATCH net v3 0/5] drivers: net: cpsw: phy-handle fixes

d-link case Documentation/devicetree/bindings/net/cpsw.txt | 6 +-- drivers/net/ethernet/ti/cpsw.c | 69 ++ drivers/net/ethernet/ti/cpsw.h | 1 + 3 files changed, 41 insertions(+), 35 deletions(-) Thanks a lot. Reviewed-by: Grygorii St

Re: [PATCH net v2 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

On 04/26/2016 12:55 AM, David Rivshin (Allworx) wrote: On Mon, 25 Apr 2016 22:12:20 +0300 Grygorii Strashko <grygorii.stras...@ti.com> wrote: On 04/22/2016 06:45 PM, David Rivshin (Allworx) wrote: On Fri, 22 Apr 2016 16:03:34 +0300 Grygorii Strashko <grygorii.stras...@ti.com> wr

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Hi, On 04/19/2016 04:56 PM, Andrew Goodbody wrote: > Adding a 2nd PHY to cpsw results in a NULL pointer dereference > as below. Fix by maintaining a reference to each PHY node in slave > struct instead of a single reference in the priv struct which was > overwritten by the 2nd PHY. David, Is it

[PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open

Access in Supervisor mode during Functional access and CPSW will stop functioning. Hence, fix it by moving pm_runtime_get_sync() before the first access to CPSW registers in cpsw_ndo_open(). Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 4 +

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/19/2016 08:14 PM, David Rivshin (Allworx) wrote: On Tue, 19 Apr 2016 18:44:41 +0300 Grygorii Strashko <grygorii.stras...@ti.com> wrote: On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: On Tue, 19 Apr 2016 17:41:07 +0300 Grygorii Strashko <grygorii.stras...@ti.com>

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: > On Tue, 19 Apr 2016 17:41:07 +0300 > Grygorii Strashko <grygorii.stras...@ti.com> wrote: > >> Hi, >> >> On 04/19/2016 04:56 PM, Andrew Goodbody wrote: >>> Adding a 2nd PHY to cpsw results in a

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/20/2016 02:38 AM, David Rivshin (Allworx) wrote: > On Tue, 19 Apr 2016 18:43:39 -0400 (EDT) > David Miller <da...@davemloft.net> wrote: > >> From: Grygorii Strashko <grygorii.stras...@ti.com> >> Date: Tue, 19 Apr 2016 21:44:09 +0300 >> >>> May

[PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

n V N <mugunthan...@ti.com> Cc: Richard Cochran <richardcoch...@gmail.com> Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1d5b4be..aca864d 100644 --- a/MAINTAI

Re: [PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

On 04/20/2016 05:23 PM, Tony Lindgren wrote: > * Grygorii Strashko <grygorii.stras...@ti.com> [160420 04:26]: >> Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW >> (am33/am43/am57/dr7/davinci) to ensure that related patches >> will go through dedicated linu

[PATCH v2] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

Tony Lindgren <t...@atomide.com> Cc: Mugunthan V N <mugunthan...@ti.com> Cc: Richard Cochran <richardcoch...@gmail.com> Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- Changes in v2: - added netdev@vger.kernel.org list MAINTAINERS | 9 + 1 file changed, 9 i

[PATCH 2/3] drivers: net: cpsw: fix wrong regs access in cpsw_remove

deinitialization actions which require CPSW registers access. In case of PM runtime error just leave cpsw_remove() as we can't do anything anymore. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 10 +- 1 file changed, 9 insertions

[PATCH 1/3] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

;lock, flags); <- deadlock The issue has not been observed before because CPDMA channels have been destroyed manually by CPSW until commit d941ebe88a41 ("net: ethernet: ti: cpsw: use destroy ctlr to destroy channels") was merged. Signed-off-by: Grygorii Strashko <grygorii.stras

[PATCH 3/3] drivers: net: cpsw: use of_platform_depopulate()

up of OF_POPULATED flag. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index a4d6eb5..ca5890f

[PATCH 0/3] drivers: net: cpsw: fix driver loading/unloading

on next insmod - need to use of_platform_depopulate() in cpsw_remove(). Grygorii Strashko (3): net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy() drivers: net: cpsw: fix wrong regs access in cpsw_remove drivers: net: cpsw: use of_platform_depopulate() drivers/net/ethernet/ti/cpsw.c

Re: [PATCH 0/2] net: davinci_cpdma: reduce latency on -rt

On 07/27/2016 10:03 AM, Uwe Kleine-König wrote: > On Tue, Jul 26, 2016 at 05:36:49PM +0300, Grygorii Strashko wrote: >> On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: >>> Hello, >>> >>> these patches are based on next-20160726. I didn't check yet how latency

Re: [PATCH 0/2] net: davinci_cpdma: reduce latency on -rt

On 07/27/2016 05:38 PM, Uwe Kleine-König wrote: > Hello, > > On Wed, Jul 27, 2016 at 05:11:54PM +0300, Grygorii Strashko wrote: >> On 07/27/2016 10:03 AM, Uwe Kleine-König wrote: >>> On Tue, Jul 26, 2016 at 05:36:49PM +0300, Grygorii Strashko wrote: >>>> On 0

Re: [PATCH 1/3] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

On 07/26/2016 11:54 PM, ivan.khoronzhuk wrote: > > > On 26.07.16 19:02, Grygorii Strashko wrote: >> On 07/23/2016 09:24 AM, Ivan Khoronzhuk wrote: >>> >>> >>> On 22.07.16 16:58, Grygorii Strashko wrote: >>>> Fix deadlock in cpdma_ctlr_destro

[PATCH v2 2/4] drivers: net: cpsw: fix wrong regs access in cpsw_remove

deinitialization actions which require CPSW registers access. In case of PM runtime error just leave cpsw_remove() as we can't do anything anymore. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 10 +- 1 file changed, 9 insertions

[PATCH v2 3/4] drivers: net: cpsw: use of_platform_depopulate()

up of OF_POPULATED flag. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index ec6f473..f0ed470

[PATCH v2 0/4] drivers: net: cpsw: fix driver loading/unloading

on next insmod - need to use of_platform_depopulate() in cpsw_remove(). 4) rmmod: system crash on omap_device removal Tested on: am437x-idk, am57xx-beagle-x15 Changes in v2: - build warning fixed - added fix for correct omap_device removal Link on v1: https://lkml.org/lkml/2016/7/22/240 Grygorii

[PATCH v2 4/4] ARM: OMAP2+: omap_device: fix crash on omap_device removal

ero Kristo <t-kri...@ti.com> Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- arch/arm/mach-omap2/omap_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c index f7ff3b9..2

[PATCH v2 1/4] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

ck, flags); The issue has not been observed before because CPDMA channels have been destroyed manually by CPSW until commit d941ebe88a41 ("net: ethernet: ti: cpsw: use destroy ctlr to destroy channels") was merged. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- drivers/net/et

Re: [PATCH v2 4/4] ARM: OMAP2+: omap_device: fix crash on omap_device removal

On 07/29/2016 08:15 AM, Peter Ujfalusi wrote: On 07/28/16 20:50, Grygorii Strashko wrote: Below call chain causes system crash when OMAP device is removed by calling of_platform_depopulate()/device_del(): Should you swap 3 <-> 4 in the series? Currently patch 3 will introduce the cra

Re: [PATCH 2/2] net: davinci_cpdma: reduce time holding chan->lock in cpdma_chan_submit

On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: > Allocating and preparing a dma descriptor doesn't need to happen under > the channel's lock. So do this before taking the channel's lock. The only > down side is that the dma descriptor might be allocated even though the > channel is about to be

Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log

On 07/26/2016 03:57 AM, David Miller wrote: From: Uwe Kleine-König Date: Mon, 25 Jul 2016 11:54:45 +0200 Such a big dump of register values is hardly useful on a production system. Another downside of the now removed functions is that calling emac_dump_regs

Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log

+ CC: Ivan On 07/26/2016 05:09 PM, Grygorii Strashko wrote: On 07/26/2016 03:57 AM, David Miller wrote: From: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> Date: Mon, 25 Jul 2016 11:54:45 +0200 Such a big dump of register values is hardly useful on a production system. Another do

Re: [PATCH 1/3] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

On 07/23/2016 09:24 AM, Ivan Khoronzhuk wrote: > > > On 22.07.16 16:58, Grygorii Strashko wrote: >> Fix deadlock in cpdma_ctlr_destroy() which is triggered now on >> cpsw module removal: >> cpsw_remove() >> - cpdma_ctlr_destroy() >>- spin_lock_irqsav

Re: [PATCH 0/2] net: davinci_cpdma: reduce latency on -rt

On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: Hello, these patches are based on next-20160726. I didn't check yet how latency improves by using these patches, but even if the improvment is small, it's still a good idea to have them. Sry, but how this will affect on -RT? This is not a raw

Re: [PATCH 2/2] net: davinci_cpdma: reduce time holding chan->lock in cpdma_chan_submit

On 07/27/2016 10:12 AM, Uwe Kleine-König wrote: > Hello, > > On Tue, Jul 26, 2016 at 05:25:58PM +0300, Grygorii Strashko wrote: >> On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: >>> Allocating and preparing a dma descriptor doesn't need to happen under >>> the

Kernel NFS boot failure

Hi All, We observe Kernel boot failure while running NFS boot stress test (1000 iterations): - Linux version 4.7.0 - am335x-evm (TI AM335x EVM) - failure rate 10-20 times per test. Originally this issue was reproduced using TI Kernel 4.4 ( git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git,

Re: [PATCH v2] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers

On 08/11/2016 04:00 AM, David Miller wrote: From: Grygorii Strashko <grygorii.stras...@ti.com> Date: Wed, 10 Aug 2016 20:02:53 +0300 diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 0805855..5caef77 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drive

[4.4-RT PATCH RFC/RFT] drivers: net: cpsw: mark rx/tx irq as IRQF_NO_THREAD

0 16K 412 551 33.7 32K 423 659.5 55.9 64K 436 728.3 67.0 128K537 845 57.4 This change does not affect on non-RT. Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- Hi All, I'll be appreciated on any feedback or tested-by. In case of pos

Re: Kernel NFS boot failure

On 08/03/2016 06:04 PM, Grygorii Strashko wrote: > Hi Vladimir, > > On 08/03/2016 03:06 PM, Vladimir Murzin wrote: >> On 03/08/16 12:41, Grygorii Strashko wrote: >>> We observe Kernel boot failure while running NFS boot stress test (1000 >>> iterations): >>

Re: [PATCH v3 00/13] net: ethernet: ti: cpsw: split driver data and per ndev data

- increase code readability - allows add a bunch of simplification - create prerequisites to add multi-channel support, when channels are shared between net devices Reviewed-by: Grygorii Strashko <grygorii.stras...@ti.com> -- regards, -grygorii

[PATCH v2] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers

space. Kmemleak does not scan IO memory and so reports memory leaks. Hence, mark allocated sk buffers as false positive explicitly. Acked-by: Catalin Marinas <catalin.mari...@arm.com> Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> --- changes in v2: - comments added dri

Re: Kernel NFS boot failure

Hi Vladimir, On 08/03/2016 03:06 PM, Vladimir Murzin wrote: > On 03/08/16 12:41, Grygorii Strashko wrote: >> We observe Kernel boot failure while running NFS boot stress test (1000 >> iterations): >> - Linux version 4.7.0 I'd like to pay your attention that this is

  1   2   3   4   5   >