[NET]: Added GSO header verification

2006-06-27 Thread Herbert Xu
hardware with a corresponding NETIF_F_TSO_ECN can accept them. The GSO engine can either fully segment the packet, or segment the first MTU and pass the rest to the hardware for further segmentation. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org

Re: [PATCH REPOST 0/2][RFC] Network Event Notifier Mechanism

2006-06-27 Thread Herbert Xu
. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [NET]: Added GSO header verification

2006-06-27 Thread Herbert Xu
On Tue, Jun 27, 2006 at 01:46:35PM -0700, Michael Chan wrote: On Tue, 2006-06-27 at 22:07 +1000, Herbert Xu wrote: [NET]: Added GSO header verification @@ -2166,10 +2166,14 @@ struct sk_buff *tcp_tso_segment(struct s if (!pskb_may_pull(skb, thlen)) goto out

Re: [PATCH REPOST 0/2][RFC] Network Event Notifier Mechanism

2006-06-27 Thread Herbert Xu
of protocols defined by the IETF. See the RDDP WG (http://www.ietf.org/html.charters/rddp-charter.html) for the Internet Drafts that define the protocols. Would it be possible for you to give us a quick summary of the relevant points? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [PATCH Round 3 0/2][RFC] Network Event Notifier Mechanism

2006-06-27 Thread Herbert Xu
-charter.html. Please give more specific reasons for needing these events because it is certainly far from obvious from reading those documents. Without reasons these invasive changes may turn out to be completely inappropriate. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [PATCH Round 3 0/2][RFC] Network Event Notifier Mechanism

2006-06-27 Thread Herbert Xu
On Wed, Jun 28, 2006 at 12:54:10PM +1000, Herbert Xu wrote: Please give more specific reasons for needing these events because it is certainly far from obvious from reading those documents. Never mind, I've found your earlier messages on the list which explains your reasons more clearly

Re: [PATCH]NET: Add ECN support for TSO

2006-06-27 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH Round 3 0/2][RFC] Network Event Notifier Mechanism

2006-06-27 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH]NET: Add ECN support for TSO

2006-06-27 Thread Herbert Xu
on the GSO mechanism to pick up the pieces (or rather generate the pieces as the case may be :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: TOE, etc. (was Re: [PATCH Round 3 0/2][RFC] Network Event Notifier Mechanism)

2006-06-27 Thread Herbert Xu
the line. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH]NET: Add ECN support for TSO

2006-06-27 Thread Herbert Xu
I must suggest that you turn this check into something like if (skb_shinfo(skb)-gso_type) or even if (skb_shinfo(skb)-gso_size) :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

Re: [PATCH]NET: Add ECN support for TSO

2006-06-27 Thread Herbert Xu
correctly in both cases. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: TOE, etc.

2006-06-27 Thread Herbert Xu
/tcpdump and the rest of our stack while at the same time it is using the same IP address as us and deciding what packets we will or won't see. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: [PATCH 2.6.17] support for TSO over IPv6

2006-06-29 Thread Herbert Xu
= SKB_GSO_TCP; You need to set SKB_GSO_TCPV6 for IPv6 packets here. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send

Re: [PATCH 2.6.17] support for TSO over IPv6

2006-06-29 Thread Herbert Xu
On Fri, Jun 30, 2006 at 09:32:44AM +1000, Herbert Xu wrote: diff -upNr netdev.org/include/linux/skbuff.h netdev.ipv6_tso/include/linux/skbuff.h --- netdev.org/include/linux/skbuff.h 2006-06-27 07:30:36.0 -0700 +++ netdev.ipv6_tso/include/linux/skbuff.h 2006-06-27 07:38

[TCP]: Reset gso_segs if packet is dodgy

2006-06-29 Thread Herbert Xu
would. Let's reset it in the per-protocol gso_segment functions. I didn't verify gso_size because that can be verified by the source of the dodgy packets. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: [PATCH 2.6.17] support for TSO over IPv6

2006-06-29 Thread Herbert Xu
/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: 2.6.17-mm3 -- BUG: illegal lock usage -- illegal {softirq-on-W} - {in-softirq-R} usage.

2006-06-29 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

[1/4] [IPV6]: Remove redundant length check on input

2006-06-29 Thread Herbert Xu
-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c

[2/4] [IPV6]: Added GSO support for TCPv6

2006-06-29 Thread Herbert Xu
Hi: [IPV6]: Added GSO support for TCPv6 This patch adds GSO support for IPv6 and TCPv6. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

[4/4] [IPV6]: Added GSO support for TCPv6

2006-06-29 Thread Herbert Xu
| -- Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[3/4] [NET]: Generalise TSO-specific bits from skb_setup_caps

2006-06-29 Thread Herbert Xu
provide a GSO implementation for their protocol which I think is a fair deal :) For now UFO continues to live without a GSO implementation which is OK since it doesn't use the sock caps field at the moment. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http

[5/4] [NET]: Verify gso_type too in gso_segment

2006-06-30 Thread Herbert Xu
Hi: [NET]: Verify gso_type too in gso_segment We don't want nasty Xen guests to pass a TCPv6 packet in with gso_type set to TCPv4 or even UDP (or a packet that's both TCP and UDP). Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: [5/4] [NET]: Verify gso_type too in gso_segment

2006-06-30 Thread Herbert Xu
in with gso_type set to TCPv4 or even UDP (or a packet that's both TCP and UDP). Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: jumbo frames and memory fragmentation

2006-06-30 Thread Herbert Xu
sane solution for jumbo packets. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe

Re: [1/4] [IPV6]: Remove redundant length check on input

2006-06-30 Thread Herbert Xu
TSO/TSO6. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 2.6.17] support for TSO over IPv6

2006-06-30 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] NET: Fix ipv6 GSO payload length

2006-06-30 Thread Herbert Xu
this! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

Re: [1/4] [IPV6]: Remove redundant length check on input

2006-07-03 Thread Herbert Xu
a new ethtool helper function for this. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [1/4] [IPV6]: Remove redundant length check on input

2006-07-03 Thread Herbert Xu
gives the inherent features of a device. That can then be used to derive the actual features in use. That way we won't need to invent a new ethtool helper function for this. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: RDMA will be reverted

2006-07-06 Thread Herbert Xu
Tom Tucker [EMAIL PROTECTED] wrote: All that said, the proposed patch helps not only iWARP, but other transports (iSCSI, IB) as well. It is not large, invasive, Care to explain on how it helps those other technologies? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: RDMA will be reverted

2006-07-06 Thread Herbert Xu
MAC and IP address, then we have the same concerns with it as we do with iWARP or TOE. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

What is RDMA (was: RDMA will be reverted)

2006-07-07 Thread Herbert Xu
/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [Xen-devel] kernel BUG at net/core/dev.c:1133!

2006-07-07 Thread Herbert Xu
0f 0 b 69 03 fe 8c 66 c0 e9 69 ff ff ff 0f 0b 6d 04 e8 ab 6c c0 e9 3a ff ff ff 0f 0b 6c 04 e8 ab 6c c0 0Kernel panic - not syncing: Fatal exception in interrupt Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [Xen-devel] kernel BUG at net/core/dev.c:1133!

2006-07-07 Thread Herbert Xu
internally. Actually, just having it loaded is enough to break TSO. So for all this time anyone who had ip_nat loaded were silently corrupting all their TSO checksums! I'll send a patch soon once I've tested it. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: starting mc triggers lockdep

2006-07-07 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: auro deadlock (was Re: e100 lockdep irq lock inversion.)

2006-07-07 Thread Herbert Xu
that ai-txq. Act 2 Enter the ipcalc program. This program calls an ioctl, which ends up calling udp_ioctl. udp_ioctl does spin_lock_bh(sk-sk_receive_queue.lock); Different queue. So no deadlock. Better luck next time :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-07 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

[1/2] [NET] gso: Add skb_is_gso

2006-07-07 Thread Herbert Xu
a little nicer and allows us to change the primary key for indicating whether an skb is GSO (if we ever want to do that). Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

[2/2] [NET] gso: Fix up GSO packets with broken checksums

2006-07-07 Thread Herbert Xu
converted to update the partial checksum instead of clearing it, this workaround can be removed. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: airo maybe should select crypto_aes

2006-07-07 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: starting mc triggers lockdep

2006-07-08 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: 2.6.17-mm3

2006-07-09 Thread Herbert Xu
directly. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

[IPV4] inetpeer: Get rid of volatile from peer_total

2006-07-09 Thread Herbert Xu
Hi Dave: Just joining on the fun on volatile :) [IPV4] inetpeer: Get rid of volatile from peer_total The variable peer_total is protected by a lock. The volatile marker makes no sense. This shaves off 20 bytes on i386. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan

Re: ipsec tunnel asymmetrical mtu

2006-07-11 Thread Herbert Xu
you run tcpdump. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: ipsec tunnel asymmetrical mtu

2006-07-11 Thread Herbert Xu
. The only thing I can think of is that it somehow managed to put some bogus entry into the conntrack table. What happens if you do grep 10.49.59.23 /proc/net/ip_conntrack before and after the tcpdump? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: What is RDMA (was: RDMA will be reverted)

2006-07-11 Thread Herbert Xu
of the networking community can add input into how things are done. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list

Re: [PATCH] cancel_rearming_delayed_work infinite loop fix

2006-07-11 Thread Herbert Xu
(test_bit(0, work-pending)); This is broken. If the work just starts running before your test_bit you'd exit without cancelling it properly. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: ipsec tunnel asymmetrical mtu

2006-07-11 Thread Herbert Xu
? It depends. A mild packet loss problem can become a big one when it is exacerbated by fragmentation, e.g., a 20% rate can become 40%. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [Patch 6/6] per task delay accounting taskstats interface: fix clone skbs for each listener

2006-07-11 Thread Herbert Xu
on that semaphore, I wonder of the box locks up. We do GFP_KERNEL inside semaphores/mutexes in lots of places. So if this can deadlock with the oom-killer we probably should fix that, preferably by having GFP_KERNEL fail in that case. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [Patch 6/6] per task delay accounting taskstats interface: fix clone skbs for each listener

2006-07-11 Thread Herbert Xu
which are trying to exit. Sorry, missed the context. If there is a deadlock then it's not just this allocation that you need worry about. There is also an allocation within genlmsg_uniast that would be GFP_KERNEL. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: ipsec tunnel asymmetrical mtu

2006-07-11 Thread Herbert Xu
to see if it's hitting them. We need to know if it's being dropped before, in, or after netfilter. Please also do ip r g 10.49.59.23 to make sure that it says something sane. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

[IPCOMP]: Fix truesize after decompression

2006-07-11 Thread Herbert Xu
-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c index

Re: ipsec tunnel asymmetrical mtu

2006-07-11 Thread Herbert Xu
show? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: Problems with xfrm (IPSec) and multicast

2006-07-11 Thread Herbert Xu
/ip_conntrack when this happens. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev

Re: [IPCOMP]: Fix truesize after decompression

2006-07-11 Thread Herbert Xu
upon the truesize value of this skb. Yes that's certainly possible. However, we'll need to audit the few spots (e.g., ATM) that use truesize without setting skb-sk. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [IPCOMP]: Fix truesize after decompression

2006-07-11 Thread Herbert Xu
from the normal networking stack. Indeed, at least they do have an sk to charge things to :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [BUG] Two BUG warnings in net/core/dev.c

2006-07-11 Thread Herbert Xu
not contain ip_nat_fn, please let us know. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe

Re: Unnecessary check in __sk_stream_mem_reclaim?

2006-07-11 Thread Herbert Xu
. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: Unnecessary check in __sk_stream_mem_reclaim?

2006-07-11 Thread Herbert Xu
sk_stream_mem_reclaim around. Besides, this function has only been exported since 2004 so it's highly unlikely for there to be stuff out there using it. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH] bonding: enhance the IP address check of arp_ip_target

2006-07-11 Thread Herbert Xu
Stephen Hemminger [EMAIL PROTECTED] wrote: Why not just use sscanf? Better yet, use a better interface like netlink rather than module parameters. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: [Bug 6688] Memory allocation problem

2006-07-12 Thread Herbert Xu
handling for fib_insert_node call The error handling around fib_insert_node was broken because we always zeroed the error before checking it. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [Bug 6688] Memory allocation problem

2006-07-12 Thread Herbert Xu
On Wed, Jul 12, 2006 at 09:44:46PM +1000, Herbert Xu wrote: [IPV4]: Fix error handling for fib_insert_node call Doh, fogot the patch. [IPV4]: Fix error handling for fib_insert_node call The error handling around fib_insert_node was broken because we always zeroed the error before checking

Re: [PATCH 1/1] net: fix __sk_stream_mem_reclaim

2006-07-12 Thread Herbert Xu
Ian McDonald [EMAIL PROTECTED] wrote: __sk_stream_mem_reclaim is only called by sk_stream_mem_reclaim. As such the check on sk-sk_forward_alloc is not needed and can be removed. Signed-off-by: Ian McDonald [EMAIL PROTECTED] Acked-by: Herbert Xu [EMAIL PROTECTED] What's more, even

[NET]: Update frag_list in pskb_trim

2006-07-13 Thread Herbert Xu
. For now though, let's do the conservative fix and update frag_list. Many thanks to Marco Berizzi for helping me to track down this bug. This 4-year old bug took 3 months to track down. Marco was very patient indeed :) Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan

[NET]: Add missing UFO initialisations

2006-07-13 Thread Herbert Xu
that it can have highly non-obvious symptoms. What happens is that uninitialised uso_size fields can cause packets to be incorrectly identified as UFO, which means that it does not get fragmented even if it's over the MTU. The fix is simple enough. Signed-off-by: Herbert Xu [EMAIL PROTECTED

Re: another networking lockdep bug

2006-07-13 Thread Herbert Xu
because the NFS sockets are not exported to user-space and therefore #1 can't happen. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: IPSec + large packets being corrupted

2006-07-13 Thread Herbert Xu
Berizzi. The following patch should fix the problem for you. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- [NET]: Update frag_list in pskb_trim

Re: [Bugme-new] [Bug 6430] New: ipsec tunnel : reply is not forwarded

2006-07-13 Thread Herbert Xu
they have a tunnel-mode SA with you). So you need at least 1 more policy on GW1 and 2 policies on GW2 for this to have a chance of working. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: jumbo frames and memory fragmentation

2006-07-13 Thread Herbert Xu
Chris Friesen [EMAIL PROTECTED] wrote: Herbert Xu wrote: Either upgrade your kernel or backport the page-splitting code in the current tree. That's really the only sane solution for jumbo packets. Looking at the page-splitting code, it says 82571 and greater support packet-split

Re: possible dos / wsize affected frozen connection length

2006-07-13 Thread Herbert Xu
keepalives can sit there for all eternity, if your machine lasts that long :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from

Re: 2.6.18-rc1-mm2

2006-07-14 Thread Herbert Xu
this. Prior to this change your TSO packets would've gone out with corrupted checksums silently. Essentially TSO would only slow your machine down since every transmission it makes has to be retransmitted as non-TSO. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: [NET]: Update frag_list in pskb_trim

2006-07-14 Thread Herbert Xu
. Marco was very patient indeed :) Signed-off-by: Herbert Xu [EMAIL PROTECTED] Signed-off-by: David S. Miller [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH 08/10] MLSXFRM: Add security context to acquire messages using PF_KEY

2006-07-14 Thread Herbert Xu
On Fri, Jul 14, 2006 at 09:54:59AM -0400, James Morris wrote: Herbert, any review from you on this would be greatly appreciated. OK, I'll try to have a look tomorrow (I'm GMT-4 at the moment). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

Re: [PATCH] clear skb cb on IP input

2006-07-15 Thread Herbert Xu
always zero the IPCB-opts in ip_rcv, it is no longer necessary to do so before calling netif_rx for tunneled packets. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: [PATCHv2 2.6.18-rc1-mm2 1/3] net: UDP-Lite generic support

2006-07-15 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] clear skb cb on IP input

2006-07-16 Thread Herbert Xu
know :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [stable] [NET]: Update frag_list in pskb_trim

2006-07-17 Thread Herbert Xu
as well to avoid copying the data area of the skb. For now though, let's do the conservative fix and update frag_list. Many thanks to Marco Berizzi for helping me to track down this bug. This 4-year old bug took 3 months to track down. Marco was very patient indeed :) Signed-off-by: Herbert Xu

Re: [PATCH] Bug in pskb_trim_rcsum()

2006-07-18 Thread Herbert Xu
calculate the checksum for only the first 8 bytes of the payload. If it does this incorrectly, then it doesn't support RX checksums at all. Which NIC is doing this BTW? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [PATCH] Bug in pskb_trim_rcsum()

2006-07-18 Thread Herbert Xu
packets to have patial checksums too. When this is done loopback can send TX CHECKSUM_HW packets instead of CHECKSUM_UNNECESSARY (I'm currently calling this CHECKSUM_PARTIAL). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Herbert Xu
/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Herbert Xu
need to know the difference between IPv4/IPv6. In this case it doesn't really matter because AFAIK they're trying to get switches to notice that the MAC has moved. So all you need is some packet that the switches can grok. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [PATCH] clear skb cb on IP input

2006-07-18 Thread Herbert Xu
. Patches are welcome :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: michael_mic in crypto api?

2006-07-19 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: michael_mic in crypto api?

2006-07-19 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

Re: A question about linux/net/ipv4/ipcomp.c

2006-07-21 Thread Herbert Xu
Igor V. Liferenko [EMAIL PROTECTED] wrote: Would you please say why it's 60, and not 52? The header length / 4 must fit within a single hexadecimal digit. Therefore the maximum is 15 * 4 = 60. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

Re: [XFRM]: Fix protocol field value for outgoing IPv6 GSO packets

2006-07-24 Thread Herbert Xu
for outgoing IPv6 GSO packets Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Acked-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH] ip multicast route bug fix

2006-07-25 Thread Herbert Xu
it's going to try to use the skb as a netlink skb instead :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list

Re: [IPROUTE]: Add support for multipath route realms

2006-07-25 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [IPROUTE]: Add support for multipath route realms

2006-07-25 Thread Herbert Xu
On Tue, Jul 25, 2006 at 06:19:33PM +1000, Herbert Xu wrote: new kernel: 1.2.3.4 nexthop realm 1 dev dummy0 weight 1 nexthop realm 2 dev dummy1 weight 1 nexthop realm 3 dev dummy2 weight 1 nexthop realm 4 dev dummy3 weight 1 This really looks like

Re: [PATCH] ip multicast route bug fix

2006-07-25 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index ba33f86..0a2af08 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@ -1593,6 +1593,7 @@ int

Re: BUGs in skb_checksum_help() and skb_gso_segment() in 2.6.18-rc2

2006-07-25 Thread Herbert Xu
to be excluded, but the IP address needs to be included for NAT). I have a patch that adds CHECKSUM_COMPLETE/CHECKSUM_PARTIAL if you want something to work from. Let me know if you want this and I'll bounce it to you. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: [PATCH Round 4 2/3] Core network changes to support network event notification.

2006-07-25 Thread Herbert Xu
for rt_cache_flush in net/ipv4/fib_hash.c. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: BUGs in skb_checksum_help() and skb_gso_segment() in 2.6.18-rc2

2006-07-25 Thread Herbert Xu
]: Require CAP_NET_ADMIN to create tuntap devices. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- 61a015eb86469404587e910e9b852fc35ce436b8

Re: ipsec tunnel policy vs routing table

2006-07-27 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: ipsec tunnel policy vs routing table

2006-07-27 Thread Herbert Xu
. It doesn't really. However your router might be proxy arping. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send

Re: Regarding offloading IPv6 addrconf and ndisc

2006-07-27 Thread Herbert Xu
the daemons? These are valid concerns. However, if we can have things like ntpd live in user-space without causing nuisance, then addrconf should be fine as well. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: Regarding offloading IPv6 addrconf and ndisc

2006-07-27 Thread Herbert Xu
extricate ourselves easily, we should attempt to come up with ways of eventually lifting us out. We should also try to avoid any actions that'll cause us to sink deeper :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

[IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-28 Thread Herbert Xu
. Similarly ip6_dst_store users can be divded into those that need to take the socket dst lock and those that don't. This patch adds __ip6_dst_store for those (everyone except UDP/datagram) that don't need an extra lock. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http

<    3   4   5   6   7   8   9   10   11   12   >