Thu, Nov 12, 2015 at 07:12:03PM IST, li...@eikelenboom.it wrote:
>On 2015-11-12 17:52, Eric Dumazet wrote:
>> On Thu, 2015-11-12 at 16:16 +0100, Sander Eikelenboom wrote:
>>
>>> > Thanks for the report, please try following patch :
>>>
>>> Hi Eric,
>>>
>>> Thanks for the patch!
>>> Got it up
red")
Fixes: 6ac311ae8bfb ("Adding switchdev ageing notification on port
bridged")
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
Signed-off-by: Jiri Pirko <j...@mellanox.com>
---
net/bridge/br_stp.c| 2 +-
net/bridge/br_stp_if.c | 2 +-
2 files changed, 2 insertion
br_should_learn() is protected by RCU and not by RTNL, so use correct
flavor of nbp_vlan_group().
Fixes: 907b1e6e83ed ("bridge: vlan: use proper rcu for the vlgrp
member")
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.c
Thu, Oct 15, 2015 at 05:58:33AM IDT, sfel...@gmail.com wrote:
>On Wed, Oct 14, 2015 at 10:42 AM, Ido Schimmel <ido...@mellanox.com> wrote:
>> Wed, Oct 14, 2015 at 08:14:24PM IDT, sfel...@gmail.com wrote:
>>>On Wed, Oct 14, 2015 at 8:25 AM, Vivien Didelot
>>><
Wed, Oct 14, 2015 at 08:14:24PM IDT, sfel...@gmail.com wrote:
>On Wed, Oct 14, 2015 at 8:25 AM, Vivien Didelot
><vivien.dide...@savoirfairelinux.com> wrote:
>> On Oct. Wednesday 14 (42) 09:14 AM, Ido Schimmel wrote:
>>> Tue, Oct 13, 2015 at 05:32:26PM IDT, vivien.d
Tue, Oct 13, 2015 at 05:32:26PM IDT, vivien.dide...@savoirfairelinux.com wrote:
>On Oct. Tuesday 13 (42) 11:31 AM, Ido Schimmel wrote:
>> Mon, Oct 12, 2015 at 08:36:25PM IDT, vivien.dide...@savoirfairelinux.com
>> wrote:
>> >Hi guys,
>> >
>> >On Oct. Mo
Wed, Sep 30, 2015 at 09:16:54PM IDT, ra...@blackwall.org wrote:
>From: Nikolay Aleksandrov
>
>When a new port is being added we need to make vlgrp available after
>rhashtable has been initialized and when removing a port we need to
>flush the vlans and free the
Mon, Oct 12, 2015 at 08:55:31PM IDT, niko...@cumulusnetworks.com wrote:
>On 10/12/2015 07:39 PM, Ido Schimmel wrote:
>> Mon, Oct 12, 2015 at 02:41:08PM IDT, ra...@blackwall.org wrote:
>>> From: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
>>>
>> Hi,
Mon, Oct 12, 2015 at 02:41:06PM IDT, ra...@blackwall.org wrote:
>From: Nikolay Aleksandrov
>
Hi Nik,
Small nitpick:
>@@ -825,17 +848,19 @@ unlock:
>
> int br_vlan_init(struct net_bridge *br)
> {
>+ struct net_bridge_vlan_group *vg;
> int ret = -ENOMEM;
Mon, Oct 12, 2015 at 02:41:08PM IDT, ra...@blackwall.org wrote:
>From: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
>
Hi,
>Ido Schimmel reported a problem with switchdev devices because of the
>order change of del_nbp operations, more specifically the move of
>nbp_vlan_
Mon, Oct 12, 2015 at 02:41:09PM IDT, ra...@blackwall.org wrote:
>From: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
>
>As Ido Schimmel pointed out the vlan_vid_del() loop in nbp_vlan_flush is
>unnecessary (and is actually a remnant of the old vlan code) so we can
>remov
Mon, Oct 12, 2015 at 09:15:39PM IDT, vivien.dide...@savoirfairelinux.com wrote:
>Hi,
>
>On Oct. Monday 12 (42) 08:51 PM, Ido Schimmel wrote:
>> Mon, Oct 12, 2015 at 02:41:09PM IDT, ra...@blackwall.org wrote:
>> >From: Nikolay Aleksandrov <niko...@cumulusnetworks.co
ed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
s spinlock only which is a problem for the vlan code, so use
>explicitly rcu for that to avoid problems.
>
>Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
--
To unsubscribe from this list: send the line "unsubsc
Mon, Oct 12, 2015 at 10:47:04PM IDT, ra...@blackwall.org wrote:
>From: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
>
>As Ido Schimmel pointed out the vlan_vid_del() code in nbp_vlan_flush is
>unnecessary (and is actually a remnant of the old vlan code) so we can
>rem
Mon, Oct 12, 2015 at 08:36:25PM IDT, vivien.dide...@savoirfairelinux.com wrote:
>Hi guys,
>
>On Oct. Monday 12 (42) 02:01 PM, Nikolay Aleksandrov wrote:
>> From: Nikolay Aleksandrov
>>
>> We shouldn't allow BRIDGE_VLAN_INFO_PVID flag in VLAN ranges.
>>
>>
Mon, Oct 12, 2015 at 10:47:05PM IDT, ra...@blackwall.org wrote:
>From: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
>
>Ido Schimmel reported a problem with switchdev devices because of the
>order change of del_nbp operations, more specifically the move of
>nbp_vlan_flus
Fri, Nov 13, 2015 at 02:34:45PM IST, li...@eikelenboom.it wrote:
>On 2015-11-13 12:06, Ido Schimmel wrote:
>> When NET_SWITCHDEV=n, switchdev_port_attr_set simply returns
>> EOPNOTSUPP.
>> In this case we should not emit errors and warnings to the kernel log.
>
>Hi Id
Thu, Dec 03, 2015 at 01:20:50AM IST, john.fastab...@gmail.com wrote:
>On 15-12-02 12:07 PM, Jiri Pirko wrote:
>> From: Ido Schimmel <ido...@mellanox.com>
>>
>> switchdev drivers reflect the newly requested topology to hardware when
>> CHANGEUPPER is received,
Mon, Dec 21, 2015 at 05:53:19PM IST, dsah...@gmail.com wrote:
>On 12/21/15 3:56 AM, Jiri Pirko wrote:
>> diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
>> index 5396ff08..12045de 100644
>> --- a/net/bridge/br_stp_if.c
>> +++ b/net/bridge/br_stp_if.c
>> @@ -39,7 +39,7 @@ void
gt;re-inject it to the Rx path by returning RX_HANDLER_PASS. This is
>consistent with previous behavior.
>
>Cc: Florian Westphal <f...@strlen.de>
>Fixes: 8626c56c8279 ("bridge: fix potential use-after-free when hook returns
>QUEUE or STOLEN verdict")
>Reviewed-by: Jir
iaki Makita <makita.toshi...@lab.ntt.co.jp>
Fixes: 8626c56c8279 ("bridge: fix potential use-after-free when hook returns
QUEUE or STOLEN verdict")
Signed-off-by: Jiri Pirko <j...@mellanox.com>
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
--
v1->v2:
* Prevent a m
try points to
>and notifies the bridge using the switchdev notifier) and
>mlxsw_emad_trans_timeout_work (provides async EMAD register access)
>respectively.
The ordering here is off - timeout_dw is for
mlxsw_emad_trans_timeout_work() and fdb_notify.dw is for
mlxsw_sp_fdb_notify_work(),
n Westphal <f...@strlen.de>
Fixes: 8626c56c8279 ("bridge: fix potential use-after-free when hook returns
QUEUE or STOLEN verdict")
Reviewed-by: Jiri Pirko <j...@mellanox.com>
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
---
net/bridge/br_input.c | 12 +++-
1 f
Sat, Jun 04, 2016 at 09:41:41AM IDT, shmulik.ladk...@gmail.com wrote:
>Hi,
>
>On Fri, 3 Jun 2016 12:39:45 +0300 Ido Schimmel <ido...@mellanox.com> wrote:
>> diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
>> index 1607977..c73ed44 100644
>> --- a/n
ck);
*** DEADLOCK ***
Fixes: cb41c997d444 ("team: team should sync the port's uc/mc addrs when add a
port")
Signed-off-by: Jiri Pirko <j...@mellanox.com>
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
---
drivers/net/team/team.c | 2 ++
1 file changed, 2 insertions(+)
diff --g
Fri, Feb 12, 2016 at 11:34:18PM IST, vivien.dide...@savoirfairelinux.com wrote:
Hi Vivien,
>Every call to br_set_state is followed by a call to br_log_state.
>Directly call it within br_set_state instead.
>
>Signed-off-by: Vivien Didelot
>---
Maybe I'm
Fri, Feb 12, 2016 at 11:34:19PM IST, vivien.dide...@savoirfairelinux.com wrote:
Hi Vivien,
>When a port leaves a bridge, the bridge layer puts its STP state to
>Disabled. If the port is part of an hardware switch, the mode needs to
>be set to Forwarding in order to restore communication with the
Fri, Feb 12, 2016 at 11:31:09PM IST, step...@networkplumber.org wrote:
Hi,
>This fixes a regression in the bridge ageing time caused by:
>
>commit c62987bbd8a1 ("bridge: push bridge setting ageing_time down to
>switchdev")
>
>There are users of Linux bridge which use the feature that if ageing
Hi John,
Mon, Feb 22, 2016 at 10:32:47PM IST, john.fastab...@gmail.com wrote:
>On 16-02-22 10:32 AM, Jiri Pirko wrote:
>> From: Ido Schimmel <ido...@mellanox.com>
>>
>> When splitting a port we replace it with 2 or 4 other ports. To be able
>> to do that we
rfairelinux.com>
>---
Acked-by: Ido Schimmel <ido...@mellanox.com>
Thanks Vivien.
Fri, Feb 12, 2016 at 11:31:09PM IST, step...@networkplumber.org wrote:
>This fixes a regression in the bridge ageing time caused by:
>
>commit c62987bbd8a1 ("bridge: push bridge setting ageing_time down to
>switchdev")
>
>There are users of Linux bridge which use the feature that if ageing time
ridge_master).
>
>Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com>
Acked-by: Ido Schimmel <ido...@mellanox.com>
Hi Vivien,
Wed, Mar 09, 2016 at 07:42:47PM IST, vivien.dide...@savoirfairelinux.com wrote:
>Add a new SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF switchdev attribute which is
>set before adding a port to a bridge and deleting a port from a bridge.
>
>The main purpose for this attribute is to provide
Hi Vivien,
Sun, Mar 13, 2016 at 08:42:26AM IST, vivien.dide...@savoirfairelinux.com wrote:
>Rework the netdev event handler, similar to what the Mellanox Spectrum
>driver does, to eventually welcome NETDEV_PRECHANGEUPPER actions and use
>netdev helpers, such as netif_is_bridge_master.
>
Thu, Mar 17, 2016 at 10:25:19PM IST, and...@lunn.ch wrote:
>On Thu, Mar 17, 2016 at 04:10:31PM -0400, Murali Karicheri wrote:
>> David,
>>
>> On 08/18/2015 04:47 PM, David Miller wrote:
>> > I see some drivers where the foo_debugfs.c file is larger than the rest
>> > of the driver. Once people
Mon, Mar 07, 2016 at 04:04:59PM IST, sergei.shtyl...@cogentembedded.com wrote:
>Hello.
>
>On 3/7/2016 11:24 AM, Jiri Pirko wrote:
>
>> From: Ido Schimmel <ido...@mellanox.com>
>>
>> The descriptor queues for sending (SDQs) and receiving (RDQs) packets
>&
ile.com>
Fixes: c62987bbd8a1 ("bridge: push bridge setting ageing_time down to
switchdev")
Acked-by: Ido Schimmel <ido...@mellanox.com>
Thank you.
Hi,
Fri, Apr 22, 2016 at 10:00:47PM IDT, sae...@mellanox.com wrote:
>From: Eran Ben Elisha
>
>Disable link up when initializing the HCA. Link up/down will be changed
>using (Ports Administrative and Operational Status Register) PAOS
>commands.
>
>If link layer is Ethernet,
Sat, Apr 23, 2016 at 11:21:45PM IDT, sae...@dev.mellanox.co.il wrote:
>On Sat, Apr 23, 2016 at 7:00 PM, Ido Schimmel <ido...@mellanox.com> wrote:
>> mutt suggests I sent you the following patches a while ago:
>>
>> net/mlx5e: Set port administrative status in ndo
Hi Vivien, Florian,
Tue, May 24, 2016 at 05:32:33PM IDT, vivien.dide...@savoirfairelinux.com wrote:
>Hi Florian,
>
>Florian Fainelli writes:
>
>> Described what the port_vlan_filtering function is supposed to
>> accomplish.
>>
>> Fixes: fb2dabad69f0 ("net: dsa: support VLAN
UEUE or STOLEN verdict")
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
Reviewed-by: Jiri Pirko <j...@mellanox.com>
Cc: Florian Westphal <f...@strlen.de>
Cc: John Fastabend <john.fastab...@gmail.com>
---
net/bridge/br_input.c | 8
1 file changed, 8 in
("mlxsw: spectrum: Add support in matchall mirror TC
offloading")
Reported-by: kbuild test robot <fengguang...@intel.com>
Signed-off-by: Jiri Pirko <j...@mellanox.com>
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
---
I know the merge window is already open, but I th
xsw: spectrum_router: Implement fib4 add/del
> switchdev obj ops")
> Signed-off-by: Vincent Stehlé <vincent.ste...@laposte.net>
> Cc: Jiri Pirko <j...@mellanox.com>
Acked-by: Ido Schimmel <ido...@mellanox.com>
Thank you.
Signed-off-by: Jiri Pirko <j...@mellanox.com>
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
---
man/man8/devlink.8 | 1 +
1 file changed, 1 insertion(+)
diff --git a/man/man8/devlink.8 b/man/man8/devlink.8
index df00f4f..cf0563b 100644
--- a/man/man8/devlink.8
+++ b/man/ma
Signed-off-by: Jiri Pirko <j...@mellanox.com>
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
---
man/man8/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/man/man8/Makefile b/man/man8/Makefile
index 929826e..9badbed 100644
--- a/man/man8/Makefile
++
kel <nog...@mellanox.com>
>Signed-off-by: Jiri Pirko <j...@mellanox.com>
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
Thu, Jul 21, 2016 at 11:19:13AM IDT, j...@resnulli.us wrote:
>From: Nogah Frankel <nog...@mellanox.com>
>
>Add max span resources to resources query.
>
>Signed-off-by: Nogah Frankel <nog...@mellanox.com>
>Signed-off-by: Jiri Pirko <j...@mellanox.com>
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
is also accessed via ethtool ops, but there we
are guaranteed to have PFC disabled.
Fixes: d81a6bdb87ce ("mlxsw: spectrum: Add IEEE 802.1Qbb PFC support")
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_dcb.c | 2 ++
1 file chang
When ieee_setpfc() gets called, PAUSE frames are not necessarily
disabled on the port.
Check if PAUSE frames are disabled or enabled and configure the port's
headroom buffer accordingly.
Fixes: d81a6bdb87ce ("mlxsw: spectrum: Add IEEE 802.1Qbb PFC support")
Signed-off-by: Ido Sch
We correctly execute mlxsw_sp_port_dcb_fini() when port is removed, but
I missed its rollback in the error path of port creation, so add it.
Fixes: f00817df2b42 ("mlxsw: spectrum: Introduce support for Data Center
Bridging (DCB)")
Signed-off-by: Ido Schimmel <ido...@mellanox.com&
Patches 1 and 2 fix a problem in which PAUSE frames settings are wrongly
overridden when ieee_setpfc() gets called.
Patch 3 adds a missing rollback in port's creation error path.
Ido Schimmel (3):
mlxsw: spectrum: Do not assume PAUSE frames are disabled
mlxsw: spectrum: Do not override PAUSE
Fri, Jul 01, 2016 at 07:16:23PM IDT, d...@cumulusnetworks.com wrote:
>On 7/1/16 8:04 AM, Jiri Pirko wrote:
>> @@ -327,6 +333,19 @@ mlxsw_sp_port_vport_find_by_fid(const struct
>> mlxsw_sp_port *mlxsw_sp_port,
>> return NULL;
>> }
>>
>> +static inline struct mlxsw_sp_rif *
>>
Fri, Jul 01, 2016 at 05:39:01PM IDT, d...@cumulusnetworks.com wrote:
>On 7/1/16 8:04 AM, Jiri Pirko wrote:
>> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.h
>> b/drivers/net/ethernet/mellanox/mlxsw/spectrum.h
>> index 05d5fcc..c2ac037 100644
>> ---
On Mon, Aug 15, 2016 at 02:51:20PM +, Ilan Tayari wrote:
> > Add the following traps:
> >
> > 1) MTU Error: Trap packets whose size is bigger than the egress RIF's MTU.
> > If DF
> > bit isn't set, traffic will continue to be routed in slow path.
> >
> > 2) TTL Error: Trap packets whose TTL
On Wed, Feb 08, 2017 at 09:56:00AM -0500, Andy Gospodarek wrote:
> On Wed, Feb 08, 2017 at 11:16:39AM +0100, Jiri Pirko wrote:
> > From: Ido Schimmel <ido...@mellanox.com>
> >
> > When a multipath route is hit the kernel doesn't consider nexthops that
&g
On Wed, Feb 08, 2017 at 11:05:54AM -0700, David Ahern wrote:
> On 2/8/17 8:32 AM, Ido Schimmel wrote:
> > In the case of multipath routes, if some of the nexthops can be
> > reflected, then we do so, but periodically ask the kernel to try and
> > resolve the others. Othe
On Wed, Feb 08, 2017 at 03:43:45PM -0500, David Miller wrote:
> From: David Miller
> Date: Wed, 08 Feb 2017 15:28:48 -0500 (EST)
>
> > Looks really nice, series applied, thanks!
>
> Jiri, just FYI, I bungled up merging this. And I am trying to fix
> that up.
>
> I forgot
gned-off-by: Philippe Reynes <trem...@gmail.com>
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
Tested-by: Ido Schimmel <ido...@mellanox.com>
Thanks!
On Thu, Jan 26, 2017 at 07:00:50PM -0800, Florian Fainelli wrote:
> Hi,
>
> As I am adding support for cls_matchall in the b53/bcm_sf2 drivers, I
> was looking into several, yet unrelated things:
>
> - mlxsw does not seem to specify whether the port used for capture
> remains usable, or blocks
sample rate group [trunc ]
>
> Where only ingress qdiscs are supported, and only a combination of
> matchall classifier and sample action will lead to activating hardware
> packet sampling.
>
> Signed-off-by: Yotam Gigi <yot...@mellanox.com>
> Signed-off-by: Jiri Pirko <j...@mellanox.com>
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
On Wed, Feb 15, 2017 at 10:28:21AM -0800, Jakub Kicinski wrote:
> What worries me is that the moment we started offloading packet
> modification we run at the risk of modifying packets twice. This used
> to be a problem only for eBPF but now mlx5 can also offload things like
> ttl decrement. For
x/mlxsw/spectrum_router.c): in case
> of this event, it only accesses the DELAY_PROBE_TIME of the
> passed neigh_parms.
>
> Signed-off-by: Marcus Huewe <suse-...@gmx.de>
Fixes: 2a4501ae18b5 ("neigh: Send a notification when DELAY_PROBE_TIME changes")
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
Next time, please Cc the author of the commit you're referring to in
your patch.
Thanks!
Hi,
On Thu, Feb 16, 2017 at 11:08:01PM +0100, Harald Welte wrote:
> Also, if netdev folks have some ideas/pointers about possible
> frameworks/tools for this kind of testing [it must exist for at least
> some other kernel networking code?]: Please let me know. I'd be
> interested to have a look
r such entries. Hence, don't
> indicate expiry for such fdb entries.
>
> CC: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
> CC: Jiri Pirko <j...@resnulli.us>
> CC: Ido Schimmel <ido...@mellanox.com>
> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.
: spectrum_buffers: Implement shared buffer
> configuration")
> Signed-off-by: Jiri Pirko <j...@mellanox.com>
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
Thanks!
t;)
> Signed-off-by: Jiri Pirko <j...@mellanox.com>
Acked-by: Ido Schimmel <ido...@mellanox.com>
Thanks
Hi,
On Sun, Sep 18, 2016 at 04:39:47PM +0800, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/net/ethernet/mellanox/mlxsw/spectrum.c:251:29: warning: no previous
> prototype for 'mlxsw_sp_span_entry_find' [-Wmissing-prototypes]
>
On Thu, Sep 15, 2016 at 08:58:50PM +0200, John Crispin wrote:
> Hi,
>
> While adding MDB support to the qca8k dsa driver I found that ipv4 mcast
> groups don't always get propagated to the dsa driver. In my setup there
> are 2 clients connected to the switch, both running a mdns client. The
>
On Wed, Sep 21, 2016 at 01:53:09PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> This allows to pass information about added/deleted FIB entries/rules to
> whoever is interested. This is done in a very similar way as devinet
> notifies address additions/removals.
>
>
;
> Signed-off-by: Jiri Pirko <j...@mellanox.com>
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
Thanks
ute's nexthop list don't all have the same switch ID, the
> -driver is not called to add/modify/delete the FIB entry.
> +port netdevs mentioned in the routes next hop list.
s/routes/route's/ ?
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
Thanks!
>
> Routes offloaded to the de
On Wed, Sep 21, 2016 at 01:53:13PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Since this is now taken care of by FIB notifier, remove the code, with
> all unused dependencies.
>
> Signed-off-by: Jiri Pirko
[...]
> -static struct net_device
On Wed, Sep 21, 2016 at 01:53:11PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Until now, in order to offload a FIB entry to HW we use switchdev op.
> However that has limits. Mainly in case we need to make the HW aware of
> all route prefixes configured in kernel. HW
; Signed-off-by: Arnd Bergmann <a...@arndb.de>
For net-next:
Acked-by: Ido Schimmel <ido...@mellanox.com>
BTW, which flags did you pass to generate this error? I can only
reproduce this with EXTRA_CFLAGS="-Wmaybe-uninitialized -Werror", but
for some reason EXTRA_CFLAGS=&q
On Fri, Sep 23, 2016 at 11:22:12AM +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Until now, in order to offload a FIB entry to HW we use switchdev op.
> However that has limits. Mainly in case we need to make the HW aware of
> all route prefixes configured in kernel. HW
On Sat, Sep 24, 2016 at 06:03:38PM -0700, Colin King wrote:
> From: Colin Ian King
>
> There is an earlier check and return if err is non-zero, so
> the check to see if it is zero is redundant in every iteration
> of the loop and hence the check can be removed.
>
>
figured in kernel. HW needs to know those in order
> to properly trap appropriate packets and pass the to kernel to do
> the forwarding. Abort mechanism is now handled within the mlxsw driver.
>
> Signed-off-by: Jiri Pirko <j...@mellanox.com>
Reviewed-by: Ido Schimmel <ido...@mellanox.com>
Thanks
On Wed, Oct 26, 2016 at 09:05:35AM -0600, David Ahern wrote:
> On 10/26/16 12:39 AM, ido...@idosch.org wrote:
> > From: Ido Schimmel <ido...@mellanox.com>
> >
> > netdev_next_lower_dev() returns NULL when we finished traversing the
> > adjacency list ('iter' poin
On Fri, Nov 11, 2016 at 11:20:41AM +0100, Jiri Pirko wrote:
> From: Yotam Gigi
>
> When binding port to a newly created span entry, its refcount is set 0
> even though it has a bound port. That leeds to unexpected behaviour when
s/leeds/leads/
> the user tries to delete
: c723c735fa6b ("mlxsw: spectrum_router: Periodically update the
> kernel's neigh table")
> Signed-off-by: Arkadi Sharshevsky <arka...@mellanox.com>
> Signed-off-by: Ido Schimmel <ido...@mellanox.com>
> Signed-off-by: Jiri Pirko <j...@me
On Thu, Oct 20, 2016 at 11:01:42AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the net-next tree got conflicts in:
>
> include/linux/netdevice.h
> net/core/dev.c
>
> between commit:
>
> e4961b076885 ("net: core: Correctly iterate over lower adjacency list")
>
Hi Dave,
On Wed, Oct 19, 2016 at 10:38:29AM -0400, David Miller wrote:
> From: ido...@idosch.org
> Date: Wed, 19 Oct 2016 16:57:08 +0300
>
> > From: Ido Schimmel <ido...@mellanox.com>
> >
> > Tamir reported the following trace when processing ARP requests rece
Hi Florian,
On Tue, Nov 22, 2016 at 09:56:30AM -0800, Florian Fainelli wrote:
> On 11/22/2016 09:41 AM, Ido Schimmel wrote:
> > Hi Florian,
> >
> > On Mon, Nov 21, 2016 at 11:09:22AM -0800, Florian Fainelli wrote:
> >> Hi all,
> >>
> >> This patch
Hi Florian,
On Mon, Nov 21, 2016 at 11:09:22AM -0800, Florian Fainelli wrote:
> Hi all,
>
> This patch series allows using the bridge master interface to configure
> an Ethernet switch port's CPU/management port with different VLAN attributes
> than
> those of the bridge downstream
On Thu, Nov 24, 2016 at 12:04:57AM +0100, Hannes Frederic Sowa wrote:
> On 23.11.2016 20:53, Ido Schimmel wrote:
> > On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote:
> >> Hmm, I think you need to read the sequence counter under rtnl_lock to
> >> hav
On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote:
> Hmm, I think you need to read the sequence counter under rtnl_lock to
> have an ordering with the rest of the updates to the RCU trie. Otherwise
> you don't know if the fib trie has the correct view regarding to the
> incoming
On Wed, Nov 23, 2016 at 06:08:23PM +0100, Hannes Frederic Sowa wrote:
> On Wed, Nov 23, 2016, at 18:04, Jiri Pirko wrote:
> > >Sure, but an abort function can be provided to the kernel anyway and the
> > >driver can care about that.
> >
> > Ok, how?
>
> I think just a sysctl ontop of this series
On Wed, Nov 16, 2016 at 08:43:25PM +0100, Hannes Frederic Sowa wrote:
> On 16.11.2016 19:51, Ido Schimmel wrote:
> > On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote:
> >> On 16.11.2016 16:18, Ido Schimmel wrote:
> >>> On Wed, Nov 16, 2016 at 03:
Hi,
On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote:
> On 16.11.2016 16:18, Ido Schimmel wrote:
> > On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes Frederic Sowa wrote:
> >> On 16.11.2016 15:09, Jiri Pirko wrote:
> >>> From: Ido
Hi Hannes,
On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes Frederic Sowa wrote:
> On 16.11.2016 15:09, Jiri Pirko wrote:
> > From: Ido Schimmel <ido...@mellanox.com>
> >
> > Commit b90eb7549499 ("fib: introduce FIB notification infrastructure")
> > in
Hi Dave,
On Wed, Nov 16, 2016 at 11:27:35AM -0500, David Miller wrote:
> From: Hannes Frederic Sowa
> Date: Wed, 16 Nov 2016 15:51:01 +0100
>
> > I don't see a way around doing a journal like in filesystems somehow,
>
> We really just need a sequence counter
Hi Hannes,
On Wed, Nov 16, 2016 at 08:43:25PM +0100, Hannes Frederic Sowa wrote:
> On 16.11.2016 19:51, Ido Schimmel wrote:
> > On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote:
> >> On 16.11.2016 16:18, Ido Schimmel wrote:
> >>> On Wed, No
On Thu, Nov 17, 2016 at 06:20:39PM +0100, Hannes Frederic Sowa wrote:
> On 17.11.2016 17:45, David Miller wrote:
> > From: Hannes Frederic Sowa
> > Date: Thu, 17 Nov 2016 15:36:48 +0100
> >
> >> The other way is the journal idea I had, which uses an rb-tree with
> >>
On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote:
> On Mon, 2016-10-31 at 23:13 +0200, ido...@idosch.org wrote:
> > From: Ido Schimmel <ido...@mellanox.com>
> >
> > When registering a FIB notifier block we should notify the caller of
> > alrea
Hi,
On Mon, Oct 31, 2016 at 03:36:06PM -0400, David Miller wrote:
> From: Jiri Pirko <j...@resnulli.us>
> Date: Sun, 30 Oct 2016 10:09:22 +0100
>
> > From: Ido Schimmel <ido...@mellanox.com>
> >
> > In the device, a MID entry represents a group of lo
On Tue, Nov 01, 2016 at 07:19:59AM -0700, Eric Dumazet wrote:
> On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote:
> > On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote:
>
> > > How well will this work for large FIB tables ?
> > >
> > > Hold
Hi Roopa,
On Tue, Nov 01, 2016 at 08:14:14AM -0700, Roopa Prabhu wrote:
> On 11/1/16, 7:19 AM, Eric Dumazet wrote:
> > On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote:
> >> On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote:
> >>> How well will
On Tue, Nov 01, 2016 at 12:54:01AM +0800, kbuild test robot wrote:
> Hi Ido,
>
> [auto build test ERROR on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/idosch-idosch-org/ipv4-fib-Replay-events-when-registering-FIB-notifier/20161031-163334
> config:
On Wed, Nov 02, 2016 at 06:29:40AM -0700, Roopa Prabhu wrote:
> On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote:
> > Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote:
> >>
> [snip]
>
> >>I understand..but, if you are adding some core infrastructure for
1 - 100 of 779 matches
Mail list logo