Commit ba5ca784 "bna: check for dma mapping errors" added besides other
things a statistic that counts number of DMA buffer mapping failures
per each Rx queue. This counter is not included in ethtool stats output.
Fixes: ba5ca784 "bna: check for dma mapping errors"
Signed
d fires Tx watchdog later. To avoid this, don't allow to set
Tx coalescing time to 0 and also remove subsequent checks that become
senseless.
Cc: satish.baddipad...@broadcom.com
Cc: siva.kal...@broadcom.com
Cc: michael.c...@broadcom.com
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
driv
Dne 31.8.2016 v 18:19 Michael Chan napsal(a):
On Wed, Aug 31, 2016 at 2:27 AM, Ivan Vecera <ivec...@redhat.com> wrote:
Dne 30.8.2016 v 17:46 Michael Chan napsal(a):
On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera <ivec...@redhat.com> wrote:
The recent commit 087d7a8c disallo
Dne 30.8.2016 v 17:46 Michael Chan napsal(a):
On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera <ivec...@redhat.com> wrote:
The recent commit 087d7a8c disallows to set Rx coalescing time to be 0
as this stops generating interrupts for the incoming packets. I found
the zero Tx coalescing time
Dne 30.8.2016 v 19:52 Sergei Shtylyov napsal(a):
Hello.
On 08/30/2016 05:38 PM, Ivan Vecera wrote:
The recent commit 087d7a8c disallows to set Rx coalescing time to be 0
You should specify both 12-digit SHA1 and the commit summary enclosed in
("").
as this stops generating
coalescing time to 0.
Cc: satish.baddipad...@broadcom.com
Cc: siva.kal...@broadcom.com
Cc: michael.c...@broadcom.com
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/net/ethernet/broadcom/tg3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/tg
Remove unused and useless priv_size member from struct devlink_ops.
Cc: Jiri Pirko <j...@mellanox.com>
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
include/net/devlink.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index c99f
On 1.8.2016 16:20, David Laight wrote:
From: Ivan Vecera
Sent: 29 July 2016 18:53
Change type of bna_id to atomic_t. The bnad_list_mutex is used to prevent
a race when bna_id is incremented. After the change the mutex can be
removed in the next step.
...
-static u32 bna_id;
+static atomic_t
Remove global bnad_list_mutex as it is not used anymore. This makes
bnad_add_to_list() and bnad_remove_from_list() empty so remove them too.
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/net/ethernet/brocade/bna/bnad.c | 20
1 file changed, 20 del
off-by: Ivan Vecera <ivec...@redhat.com>
drivers/net/ethernet/brocade/bna/bnad.c | 27 ++-
drivers/net/ethernet/brocade/bna/bnad.h | 1 -
2 files changed, 2 insertions(+), 26 deletions(-)
--
2.7.3
Change type of bna_id to atomic_t. The bnad_list_mutex is used to prevent
a race when bna_id is incremented. After the change the mutex can be
removed in the next step.
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/net/ethernet/brocade/bna/bnad.c | 4 ++--
1 file chan
Remove global variable bnad_list and bnad->list_entry that are used
as list of bna driver instances. It is not necessary and useless.
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/net/ethernet/brocade/bna/bnad.c | 3 ---
drivers/net/ethernet/brocade/bna/bnad.h | 1 -
On 26.6.2016 10:59, Ben Hutchings wrote:
On Fri, 2016-03-18 at 13:24 +0100, Ivan Vecera wrote:
Memory allocated at several places is not appropriately freed.
Given that ethtool is not a library or a long-running application - why
does that matter?
Ben.
Because each decently written program
beginning but it appeared after the commit
fd867d5 (net/core: generic support for disabling netdev features down stack)
that adds synchronization of features with lower devices.
Fixes: fd867d5 (net/core: generic support for disabling netdev features down
stack)
Cc: Jiri Pirko <j...@resnulli.
ower_2)
-> __netdev_update_features(lower_2)
-> netdev_features_change(lower_2)
-> call_netdevice_notifiers(...)
-> team_device_event(lower_2)
-> team_compute_features(team) [DEADLOCK]
Cc: Jiri Pirko <j...@resnulli.u
On 18.3.2016 13:24, Ivan Vecera wrote:
Memory allocated at several places is not appropriately freed.
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
Ben, ping.
I.
---
ethtool.c | 60 +---
1 file changed, 45 insertions(
Memory allocated at several places is not appropriately freed.
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
ethtool.c | 60 +---
1 file changed, 45 insertions(+), 15 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index 0
On 26.2.2016 13:44, Sathya Perla wrote:
On Fri, Feb 26, 2016 at 5:54 PM, Ivan Vecera <ivec...@redhat.com> wrote:
On 26.2.2016 12:36, Sathya Perla wrote:
On Fri, Feb 26, 2016 at 2:16 PM, Ivan Vecera <ivec...@redhat.com> wrote:
The FILTMGMT privilege is necessary on BE3 chip t
On 26.2.2016 12:36, Sathya Perla wrote:
On Fri, Feb 26, 2016 at 2:16 PM, Ivan Vecera <ivec...@redhat.com> wrote:
The FILTMGMT privilege is necessary on BE3 chip to manipulare filters
like MC, UC list management, VLAN filter, promisc mode... This privilege
is dropped for VFs when transp
be_open() fails thus be_open() also fails.
Cc: Sathya Perla <sathya.pe...@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com>
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/net/ethernet/emulex/benet/be_main.c | 11 +++
1 file cha
Use list_move_tail() to move MAC address entry from list of pending
to list of active entries. Simple list_add_tail() leaves the entry
also in the first list, this leads to list corruption.
Cc: Rasesh Mody <rasesh.m...@qlogic.com>
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
On 11.2.2016 10:56, Sathya Perla wrote:
On Wed, Feb 10, 2016 at 1:13 PM, Ivan Vecera <ivec...@redhat.com> wrote:
The EVB (virtual bridge) functionality should be disabled on older BE3
and Lancer chips if SR-IOV is disabled in the NIC's BIOS. This setting
is identified by the zero
..@broadcom.com>
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/net/ethernet/emulex/benet/be_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
index 9c1fc9d..10a0ad5 100644
---
On 3.2.2016 11:47, Jiri Pirko wrote:
+struct devlink_ops {
+ size_t priv_size;
+ int (*port_type_set)(struct devlink_port *devlink_port,
+enum devlink_port_type port_type);
+};
It does not make sense to have priv_size member here... If it is
necessary it
FW.
Cc: Sathya Perla <sathya.pe...@broadcom.com>
Cc: Ajit Khaparde <ajit.khapa...@broadcom.com>
Cc: Padmanabh Ratnakar <padmanabh.ratna...@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com>
Cc: Somnath Kotur <somnath.ko...@broadcom.com>
Si
.
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/net/ethernet/emulex/benet/be_ethtool.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c
b/drivers/net/ethernet/emulex/benet/be_ethtool.c
index 734f655..d2a5baf
On 11/16/2015 09:57 AM, Sathya Perla wrote:
On Fri, Nov 13, 2015 at 3:22 PM, Ivan Vecera <ivec...@redhat.com> wrote:
The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get
the current size of registers for ethtool registers dump. The size
is stored in data_read but onl
Remove rsstable array and its initialization from be_set_rss_hash_opts().
The array became unused after "e255787 be2net: Support for configurable
RSS hash key". The initial RSS table is now filled and stored for later
usage during Rx queue creation.
Signed-off-by: Ivan Vecera <ivec.
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/net/ethernet/emulex/benet/be_ethtool.c | 3 ++-
drivers/net/ethernet/emulex/benet/be_main.c| 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c
b/drivers/net/et
The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get
the current size of registers for ethtool registers dump. The size
is stored in data_read but only when the returned status is 0 otherwise
it is uninitialized thus random.
Signed-off-by: Ivan Vecera <ivec...@redhat.
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().
v2: removed unused variable
Signed-off-by: Ivan Vecera <ivec...@red
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().
v2: removed unused variable
v3: removed another unused variable
Signed-off-by:
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/infinib
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
ethtool.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ethtool.8.in b/ethtool.8.in
index ae56293..eeffa70 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -872,7 +872,7 @@ Enables/disables the device support
Check for DMA mapping errors, recover from them and register them in
ethtool stats like other errors.
Cc: Rasesh Mody <rasesh.m...@qlogic.com>
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c| 2 ++
drivers/net/ethernet/brocade/bna
On 17.8.2015 13:10, Corcodel Marian wrote:
Put rx_buf_sz on rtl_cfg_info structure and add new
parameter rx_buf_coef.Param rx_buf_sz may be different by nic's and same
rx_buf_coef On RTL 8101 series rx_buf_coef is not equal with rx_buf_sz.
Add --whitespace=warn on git
Signed-off-by:
On 17.8.2015 12:26, Corcodel Marian wrote:
Set InterFrame Gap time as largest posible for comp. Add
InterFrameGap2 bit set on start.
Why?
Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek/r8169.c
Basavapatna sriharsha.basavapa...@avagotech.com
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/emulex/benet/be_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet
are never acked the firmware fires IRQs for them again
and again.
Fixes: e29aa33 bna: Enable Multi Buffer RX
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bnad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/brocade
On 5.8.2015 12:46, Corcodel Marian wrote:
This patch fill with zero Tx descriptors before use.Is only
onpart by more patches but is critical.(critical)
Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com
diff --git a/drivers/net/ethernet/realtek/r8169.c
for these chips.
Signed-off-by: Ivan Vecera ivec...@redhat.com
Tested-by: Alexander Lindqvist alexan...@bitspace.se
---
drivers/net/ethernet/realtek/r8169.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek/r8169.c
Network header is set with offset ETH_HLEN but it is not true for VLAN
(multiple-)tagged and results in checksum issues in lower devices.
v2: leave skb-protocol untouched (thx Vlad), comment added
v3: moved after skb_probe_transport_header() call (thx Toshiaki)
Signed-off-by: Ivan Vecera ivec
On 07/20/2015 06:42 PM, Vlad Yasevich wrote:
On 07/20/2015 11:44 AM, Ivan Vecera wrote:
Network header is set with offset ETH_HLEN but it is not true for VLAN
(multiple-)tagged and results in checksum issues in lower devices.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net
Network header is set with offset ETH_HLEN but it is not true for VLAN
(multiple-)tagged and results in checksum issues in lower devices.
v2: leave skb-protocol untouched (thx Vlad), comment added
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/macvtap.c | 7 +++
1 file
Network header is set with offset ETH_HLEN but it is not true for VLAN
(multiple-)tagged and results in checksum issues in lower devices.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/macvtap.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/macvtap.c b
Next round of cleaning patches.
Ivan Vecera (3):
bna: remove unnecessary cast of BIT value
bna: make pointers to read-only inputs const
bna: remove superfluous parentheses
.../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
.../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10 +--
drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 98 +++---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c
BIT value is already unsigned so casting is not necessary.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 3 +--
drivers/net/ethernet/brocade/bna/bna_enet.c | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna.h | 19 +--
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 14 +++---
drivers/net/ethernet/brocade/bna/bnad.c | 6 +++---
drivers/net/ethernet/brocade/bna/bnad.h | 2
On 06/12/2015 03:30 PM, David Laight wrote:
From: Ivan Vecera
...
diff --git a/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.h
b/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.h
index 679a503..16090fd 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.h
+++ b/drivers/net
On 06/10/2015 10:29 PM, Joe Perches wrote:
On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
Signed-off-by: Ivan Vecera ivec...@redhat.com
There should be some indication a few messages have
been deleted in the commit log and a reason why too.
diff --git a/drivers/net/ethernet/brocade
On 06/10/2015 07:57 PM, Joe Perches wrote:
On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
Signed-off-by: Ivan Vecera ivec...@redhat.com
Have you verified that all of these are __aligned(2)?
I haven't, but you should verify that you have in the
commit log.
I have checked an alignment
The patch converts mac_t type to widely used 'u8 [ETH_ALEN]'.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_defs.h | 4 ++--
drivers/net/ethernet/brocade/bna/bfa_defs_cna.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8
,TX}Q_QPGE_PTR_GET
BNA_IOC_TIMER_FREQ
BNA_MESSAGE_SIZE
BNA_QE_INDX_2_PTR
BNA_QE_INDX_RANGE
BNA_Q_GET_{C,P}I
BNA_Q_{C,P}I_ADD
BNA_Q_FREE_COUNT
BNA_Q_IN_USE_COUNT
BNA_TO_POWER_OF_2
containing_rec
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_cs.h | 14
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 13 -
drivers/net/ethernet/brocade/bna/bna_types.h | 3 ---
2 files changed, 16 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
b/drivers/net/ethernet/brocade/bna
The bna_rx_config struct member paused can be removed as it is never
written and as it cannot have non-zero value the bna_rxf struct member
flags also cannot have BNA_RXF_F_PAUSED value and is always zero.
So the flags member can be removed as well as bna_rxf_flags enum and
the code-paths that
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index 29e0428..52fc439 100644
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna_enet.c | 15 ---
drivers/net/ethernet/brocade/bna/bna_types.h | 3 ---
2 files changed, 18 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_enet.c
b/drivers/net/ethernet/brocade
RXF_E_PAUSE RXF_E_RESUME events are never sent for bna_rxf object so
they needn't to be handled. The bna_rxf's state bna_rxf_sm_fltr_clr_wait
and function bna_rxf_fltr_clear are unused after this so remove them also.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_defs.h| 6 +-
drivers/net/ethernet/brocade/bna/bfa_defs_cna.h| 14 +--
.../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 6 +-
drivers/net/ethernet/brocade/bna/bfi.h | 70
Remove macros for manipulation with struct list_head and replace them
with standard ones.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_cee.c | 1 -
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10 +-
drivers/net/ethernet/brocade/bna/bfa_msgq.c
Patch converts kzalloc-copy_from_user sequence to memdup_user. There
is also one useless assignment of NULL to bnad-regdata as it is followed
by assignment of kzalloc output.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 27
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna.h | 15 ---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 6 --
drivers/net/ethernet/brocade/bna/bna_types.h | 4
3 files changed, 25 deletions(-)
diff --git a/drivers/net
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 5 +-
drivers/net/ethernet/brocade/bna/bna.h | 41 --
drivers/net/ethernet/brocade/bna/bna_enet.c | 23 --
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 117
is
struct sockaddr *.
v2: added __aligned directive to bnad_bcast_addr, renamed parameter of
bnad_set_mac_address() (thx j...@perches.com)
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 12 ++--
drivers/net/ethernet/brocade/bna/bnad.c
TX_E_PRIO_CHANGE event is never sent for bna_tx so it doesn't need to be
handled. After this change bna_tx-flags cannot contain
BNA_TX_F_PRIO_CHANGED flag and it can be also eliminated.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 22
Pointer cmpl used to iterate through completion entries is updated at
the beginning of while loop as well as at the end. The update at the end
of the loop is useless.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bnad.c | 1 -
1 file changed, 1 deletion
...and remove some of them. It is not necessary to log when .probe() and
.remove() are called or when TxQ is started or stopped. Also log level
of some of them was changed to more appropriate one (link up/down,
firmware loading failure.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers
Timeout functions are defined with 'void *' ptr argument. They should
be defined directly with 'struct bfa_ioc *' type to avoid type conversions.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 16 +---
drivers/net/ethernet/brocade/bna
removed:
bna_rx_ucast_add
bna_rx_ucast_del
simplified:
bna_enet_pause_config
bna_rx_mcast_delall
bna_rx_mcast_listset
bna_rx_mode_set
bna_rx_ucast_listset
bna_rx_ucast_set
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna.h | 24
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
.../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 2 +-
drivers/net/ethernet/brocade/bna/bfi_enet.h| 66 ++--
drivers/net/ethernet/brocade/bna/bna_enet.c
The patches clean the bna driver.
v2: changes comments requested by Joe
Ivan Vecera (19):
bna: use ether_addr_copy instead of memcpy
bna: get rid of mac_t
bna: replace pragma(pack) with attribute __packed
bna: get rid of duplicate and unused macros
bna: use BIT(x) instead of (1 x
Remove macros for manipulation with struct list_head and replace them
with standard ones.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_cee.c | 1 -
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10 +-
drivers/net/ethernet/brocade/bna/bfa_msgq.c
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 5 +-
drivers/net/ethernet/brocade/bna/bna.h | 41 --
drivers/net/ethernet/brocade/bna/bna_enet.c | 23 --
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 117
TX_E_PRIO_CHANGE event is never sent for bna_tx so it doesn't need to be
handled. After this change bna_tx-flags cannot contain
BNA_TX_F_PRIO_CHANGED flag and it can be also eliminated.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 22
,TX}Q_QPGE_PTR_GET
BNA_IOC_TIMER_FREQ
BNA_MESSAGE_SIZE
BNA_QE_INDX_2_PTR
BNA_QE_INDX_RANGE
BNA_Q_GET_{C,P}I
BNA_Q_{C,P}I_ADD
BNA_Q_FREE_COUNT
BNA_Q_IN_USE_COUNT
BNA_TO_POWER_OF_2
containing_rec
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_cs.h | 14
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
.../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 2 +-
drivers/net/ethernet/brocade/bna/bfi_enet.h| 66 ++--
drivers/net/ethernet/brocade/bna/bna_enet.c
removed:
bna_rx_ucast_add
bna_rx_ucast_del
simplified:
bna_enet_pause_config
bna_rx_mcast_delall
bna_rx_mcast_listset
bna_rx_mode_set
bna_rx_ucast_listset
bna_rx_ucast_set
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna.h | 24
The bna_rx_config struct member paused can be removed as it is never
written and as it cannot have non-zero value the bna_rxf struct member
flags also cannot have BNA_RXF_F_PAUSED value and is always zero.
So the flags member can be removed as well as bna_rxf_flags enum and
the code-paths that
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 13 -
drivers/net/ethernet/brocade/bna/bna_types.h | 3 ---
2 files changed, 16 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
b/drivers/net/ethernet/brocade/bna
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 12 ++--
drivers/net/ethernet/brocade/bna/bnad.c | 14 ++
2 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
b
RXF_E_PAUSE RXF_E_RESUME events are never sent for bna_rxf object so
they needn't to be handled. The bna_rxf's state bna_rxf_sm_fltr_clr_wait
and function bna_rxf_fltr_clear are unused after this so remove them also.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna.h | 15 ---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 6 --
drivers/net/ethernet/brocade/bna/bna_types.h | 4
3 files changed, 25 deletions(-)
diff --git a/drivers/net
The patch converts mac_t type to widely used 'u8 [ETH_ALEN]'.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_defs.h | 4 ++--
drivers/net/ethernet/brocade/bna/bfa_defs_cna.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index 29e0428..52fc439 100644
The patches clean the bna driver.
Ivan Vecera (19):
bna: use ether_addr_copy instead of memcpy
bna: get rid of mac_t
bna: replace pragma(pack) with attribute __packed
bna: get rid of duplicate and unused macros
bna: use BIT(x) instead of (1 x)
bna: remove unused cbfn parameter
bna
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_defs.h| 6 +-
drivers/net/ethernet/brocade/bna/bfa_defs_cna.h| 14 +--
.../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 6 +-
drivers/net/ethernet/brocade/bna/bfi.h | 70
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bna_enet.c | 15 ---
drivers/net/ethernet/brocade/bna/bna_types.h | 3 ---
2 files changed, 18 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_enet.c
b/drivers/net/ethernet/brocade
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bnad.c | 46 +
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 34 --
drivers/net/ethernet/brocade/bna/bnad_ethtool.c | 9 ++---
drivers/net/ethernet/brocade/bna
Timeout functions are defined with 'void *' ptr argument. They should
be defined directly with 'struct bfa_ioc *' type to avoid type conversions.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 16 +---
drivers/net/ethernet/brocade/bna
Patch converts kzalloc-copy_from_user sequence to memdup_user. There
is also one useless assignment of NULL to bnad-regdata as it is followed
by assignment of kzalloc output.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 27
Pointer cmpl used to iterate through completion entries is updated at
the beginning of while loop as well as at the end. The update at the end
of the loop is useless.
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bnad.c | 1 -
1 file changed, 1 deletion
. The bfa_ioc_poll_fwinit() should directly
send timeout event for iocpf and the same should be done if firmware
download into HW fails.
Cc: Rasesh Mody rasesh.m...@qlogic.com
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 4 ++--
1 file changed, 2
at this place. The upstream driver uses multiple timers instead
of this.
Cc: Rasesh Mody rasesh.m...@qlogic.com
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/bnad.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c
b
These patches fix several bugs found during device initialization debugging.
Cc: Rasesh Mody rasesh.m...@qlogic.com
Ivan Vecera (3):
bna: fix firmware loading on big-endian machines
bna: remove unreasonable iocpf timer start
bna: fix soft lock-up during firmware initialization failure
-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/brocade/bna/cna_fwimg.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/brocade/bna/cna_fwimg.c
b/drivers/net/ethernet/brocade/bna/cna_fwimg.c
index ebf462d..badea36 100644
--- a/drivers/net/ethernet/brocade/bna
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state changes.
v2: added current link speed to log message
Ivan, I disagree with the v2 change. I think your original
On 04/28/2015 06:44 PM, David Miller wrote:
From: Ivan Vecera ivec...@redhat.com
Date: Tue, 28 Apr 2015 16:32:37 +0200
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state
: Ajit Khaparde ajit.khapa...@emulex.com
Signed-off-by: Ivan Vecera ivec...@redhat.com
---
drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
index fb0bc3c
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state changes.
v2: added current link speed to log message
Ivan, I disagree with the v2 change. I think your original
101 - 200 of 203 matches
Mail list logo
