err;
> +
> + /* Check if specific bridge flag attribute offload is supported */
> + if (!(attr.u.brport_flags_support & mask)) {
> + br_warn(p->br, "bridge flag offload is not supported %u(%s)\n",
> + (unsigned int)p->port_no, p->dev->name);
> + return -EOPNOTSUPP;
> + }
> +
> + attr.id = SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS;
> + attr.flags = SWITCHDEV_F_DEFER;
> + attr.u.brport_flags = flags;
> + err = switchdev_port_attr_set(p->dev, &attr);
> + if (err) {
> + br_warn(p->br, "error setting offload flag on port %u(%s)\n",
> + (unsigned int)p->port_no, p->dev->name);
> + return err;
> + }
> +
> + return 0;
> +}
>
Reviewed-by: Ivan Vecera
kadi Sharshevsky
> Reviewed-by: Ido Schimmel
> Reviewed-by: Ivan Vecera
> Signed-off-by: Jiri Pirko
> ---
> include/net/switchdev.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index 929d6af..63a
y: Arkadi Sharshevsky
> Reviewed-by: Ido Schimmel
> Reviewed-by: Ivan Vecera
> Signed-off-by: Jiri Pirko
> ---
> net/switchdev/switchdev.c | 30 ++
> 1 file changed, 6 insertions(+), 24 deletions(-)
>
> diff --git a/net/switchdev/switchdev.c b/net/s
SWITCHDEV_FDB_DEL_TO_DEVICE;
> + call_switchdev_notifiers(notifier_type, dev, &info.info);
> +}
> +
> +void
> +br_switchdev_fdb_notify(const struct net_bridge_fdb_entry *fdb, int type)
> +{
> + if (!fdb->added_by_user)
> + return;
> +
> + switch (type) {
> + case RTM_DELNEIGH:
> + br_switchdev_fdb_call_notifiers(false, fdb->addr.addr,
> + fdb->vlan_id,
> + fdb->dst->dev);
> + break;
> + case RTM_NEWNEIGH:
> + br_switchdev_fdb_call_notifiers(true, fdb->addr.addr,
> + fdb->vlan_id,
> + fdb->dst->dev);
> + break;
> + }
> +}
>
Reviewed-by: Ivan Vecera
The driver unlike other drivers does not log link state changes.
Cc: Sathya Perla
Cc: Subbu Seetharaman
Cc: Ajit Khaparde
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/emulex/benet
On 04/22/2015 03:10 PM, Joe Perches wrote:
On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote:
The driver unlike other drivers does not log link state changes.
[]
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
[]
@@ -662,6 +662,8
The driver unlike other drivers does not log link state changes.
v2: added current link speed to log message
Cc: Sathya Perla
Cc: Subbu Seetharaman
Cc: Ajit Khaparde
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be.h | 3 ++-
drivers/net/ethernet/emulex/benet
On 04/22/2015 04:07 PM, Joe Perches wrote:
On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote:
>The driver unlike other drivers does not log link state changes.
Why add all the speed stuff, why not add a query instead?
I think it'd be simpler to add a line like:
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state changes.
v2: added current link speed to log message
Ivan, I disagree with the v2 change. I think your original
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state changes.
v2: added current link speed to log message
Ivan, I disagree with the v2 change. I think your original
On 04/28/2015 06:44 PM, David Miller wrote:
From: Ivan Vecera
Date: Tue, 28 Apr 2015 16:32:37 +0200
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state changes.
v2
The driver unlike other drivers does not log link state changes. It's
better for an user when asynchronous link states are logged in the
system log.
v3: Changes from v2 discarded as "not necessary"
Cc: Sathya Perla
Cc: Subbu Seetharaman
Cc: Ajit Khaparde
Signed-off-
These patches fix several bugs found during device initialization debugging.
Cc: Rasesh Mody
Ivan Vecera (3):
bna: fix firmware loading on big-endian machines
bna: remove unreasonable iocpf timer start
bna: fix soft lock-up during firmware initialization failure
drivers/net/ethernet
Firmware required by bna is stored in appropriate files as sequence
of LE32 integers. After loading by request_firmware() they need to be
byte-swapped on big-endian arches. Without this conversion the NIC
is unusable on big-endian machines.
Cc: Rasesh Mody
Signed-off-by: Ivan Vecera
bfa_ioc_poll_fwinit() should directly
send timeout event for iocpf and the same should be done if firmware
download into HW fails.
Cc: Rasesh Mody
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
this place. The upstream driver uses multiple timers instead
of this.
Cc: Rasesh Mody
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bnad.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c
b/drivers/net/ethernet/brocade/bna/bnad.c
features(lower_2)
-> __netdev_update_features(lower_2)
-> netdev_features_change(lower_2)
-> call_netdevice_notifiers(...)
-> team_device_event(lower_2)
-> team_compute_features(team) [DEADLOCK]
Cc: Jiri Pirko
Signed-of
m from the beginning but it appeared after the commit
fd867d5 (net/core: generic support for disabling netdev features down stack)
that adds synchronization of features with lower devices.
Fixes: fd867d5 (net/core: generic support for disabling netdev features down
stack)
Cc: Jiri Pirko
Signed-of
set's FW.
Cc: Sathya Perla
Cc: Ajit Khaparde
Cc: Padmanabh Ratnakar
Cc: Sriharsha Basavapatna
Cc: Somnath Kotur
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
On 11.2.2016 10:56, Sathya Perla wrote:
On Wed, Feb 10, 2016 at 1:13 PM, Ivan Vecera wrote:
The EVB (virtual bridge) functionality should be disabled on older BE3
and Lancer chips if SR-IOV is disabled in the NIC's BIOS. This setting
is identified by the zero value of total VFs report
set's FW.
v2: added the comment
Cc: Sathya Perla
Cc: Ajit Khaparde
Cc: Padmanabh Ratnakar
Cc: Sriharsha Basavapatna
Cc: Somnath Kotur
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ether
On 3.2.2016 11:47, Jiri Pirko wrote:
+struct devlink_ops {
+ size_t priv_size;
+ int (*port_type_set)(struct devlink_port *devlink_port,
+enum devlink_port_type port_type);
+};
It does not make sense to have priv_size member here... If it is
necessary it s
Memory allocated at several places is not appropriately freed.
Signed-off-by: Ivan Vecera
---
ethtool.c | 60 +---
1 file changed, 45 insertions(+), 15 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index 0cd0d4f..ca0bf28 100644
--- a
On 18.3.2016 13:24, Ivan Vecera wrote:
Memory allocated at several places is not appropriately freed.
Signed-off-by: Ivan Vecera
Ben, ping.
I.
---
ethtool.c | 60 +---
1 file changed, 45 insertions(+), 15 deletions(-)
diff --git a
On 26.6.2016 10:59, Ben Hutchings wrote:
On Fri, 2016-03-18 at 13:24 +0100, Ivan Vecera wrote:
Memory allocated at several places is not appropriately freed.
Given that ethtool is not a library or a long-running application - why
does that matter?
Ben.
Because each decently written program
Use list_move_tail() to move MAC address entry from list of pending
to list of active entries. Simple list_add_tail() leaves the entry
also in the first list, this leads to list corruption.
Cc: Rasesh Mody
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 2 +-
1
be_open() fails thus be_open() also fails.
Cc: Sathya Perla
Cc: Sriharsha Basavapatna
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_main.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers
On 26.2.2016 12:36, Sathya Perla wrote:
On Fri, Feb 26, 2016 at 2:16 PM, Ivan Vecera wrote:
The FILTMGMT privilege is necessary on BE3 chip to manipulare filters
like MC, UC list management, VLAN filter, promisc mode... This privilege
is dropped for VFs when transparrent tagging is enabled on
On 26.2.2016 13:44, Sathya Perla wrote:
On Fri, Feb 26, 2016 at 5:54 PM, Ivan Vecera wrote:
On 26.2.2016 12:36, Sathya Perla wrote:
On Fri, Feb 26, 2016 at 2:16 PM, Ivan Vecera wrote:
The FILTMGMT privilege is necessary on BE3 chip to manipulare filters
like MC, UC list management, VLAN
Dne 28.3.2017 v 09:10 Jiri Pirko napsal(a):
Tue, Mar 28, 2017 at 12:48:34AM CEST, da...@davemloft.net wrote:
Please fix up these warnings and resubmit:
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function
‘mlxsw_sp_rif_counter_free’:
drivers/net/ethernet/mellanox/mlxsw/spectrum_
Dne 28.3.2017 v 08:51 Jiri Pirko napsal(a):
Tue, Mar 28, 2017 at 12:48:34AM CEST, da...@davemloft.net wrote:
Please fix up these warnings and resubmit:
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function
‘mlxsw_sp_rif_counter_free’:
drivers/net/ethernet/mellanox/mlxsw/spectrum_
Dne 28.3.2017 v 09:59 Jiri Pirko napsal(a):
Tue, Mar 28, 2017 at 09:57:22AM CEST, j...@resnulli.us wrote:
Tue, Mar 28, 2017 at 09:42:58AM CEST, ivec...@redhat.com wrote:
Dne 28.3.2017 v 09:10 Jiri Pirko napsal(a):
Tue, Mar 28, 2017 at 12:48:34AM CEST, da...@davemloft.net wrote:
Please fix up
ellanox/mlxsw/spectrum_dpipe.h
create mode 100644 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.h
Reviewed-by: Ivan Vecera
2017-04-08 16:14 GMT+02:00 Stephen Hemminger :
> On Sat, 8 Apr 2017 17:05:48 +0300
> Nikolay Aleksandrov wrote:
>
>> On 08/04/17 16:49, Ido Schimmel wrote:
>> > On Sat, Apr 08, 2017 at 09:30:42AM -0400, Stephen Hemminger wrote:
>> >> On Sat, 8 Apr 2017 14:41:58 +0300
>> >> wrote:
>> >>
>> >>> st
a Basavapatna
Cc: Somnath Kotur
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_main.c | 31 -
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.
t;
I have done tests on BE3 PF & both privileged and non-privileged as well
as on Skyhawk PF and VF. No problems found.
Regarding firmware, I'm using version 11.1.215.0 on my devices and this version
is affected on BE3. Older versions are affected as well.
Ivan
>
> On Thu, Jan 2
2017-01-27 13:38 GMT+01:00 Sriharsha Basavapatna
:
> Hi Ivan,
>
> This patch is a bit involved. We need some time to review and test
> this to make sure it works with other (non-BE3/VF - Skyhawk, Lancer)
> devices. Also, IIRC we shouldn't see this issue with the latest FW.
>
> Thanks,
> -Harsha
Bt
2017-01-31 19:01 GMT+01:00 David Miller :
>
>
> Sriharsha and other Broadcom folks, you must follow-up on Ivan's
> explanations and proof of testing.
>
> It is not acceptable for you to leave this patch's review state in
> limbo for days, no matter how complicated or big the patch is. You
> must a
My apologies for my previous replies... Gmail sent them as HTML emails
that are not acceptable for ML...
Thanks,
Ivan
g on privileged BE3 VFs")
Cc: Sathya Perla
Cc: Ajit Khaparde
Cc: Sriharsha Basavapatna
Cc: Somnath Kotur
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_main.c | 33 -
1 file changed, 28 insertions(+), 5 deletions(-)
diff --git a/drivers
/MAINTAINERS
@@ -11908,6 +11908,7 @@ F: include/linux/swiotlb.h
SWITCHDEV
M: Jiri Pirko
+M: Ivan Vecera
L: netdev@vger.kernel.org
S: Supported
F: net/switchdev/
Acked-by: Ivan Vecera
ld not be allowed to change its MAC
in any case.
Cc: Sathya Perla
Cc: Ajit Khaparde
Cc: Sriharsha Basavapatna
Cc: Somnath Kotur
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_main.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drive
Cc: Somnath Kotur
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c
b/drivers/net/ethernet/emulex/benet/be_cmds.c
index 0e74529..30e8550 100644
--- a/drivers
BE3 VFs without FILTMGMT privilege are not allowed to modify its MAC,
VLAN table and UC/MC lists. So don't try to delete MAC on such VFs.
Cc: Sathya Perla
Cc: Ajit Khaparde
Cc: Sriharsha Basavapatna
Cc: Somnath Kotur
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_m
Any bridge options specified during link creation (e.g. ip link add)
are ignored as br_dev_newlink() does not process them.
Use br_changelink() to do it.
Signed-off-by: Ivan Vecera
---
net/bridge/br_netlink.c | 33 +++--
1 file changed, 19 insertions(+), 14 deletions
Any bridge options specified during link creation (e.g. ip link add)
are ignored as br_dev_newlink() does not process them.
Use br_changelink() to do it.
Fixes: 1332351 bridge: implement rtnl_link_ops->changelink
Signed-off-by: Ivan Vecera
---
net/bridge/br_netlink.c |
Any bridge options specified during link creation (e.g. ip link add)
are ignored as br_dev_newlink() does not process them.
Use br_changelink() to do it.
Fixes: 1332351 ("bridge: implement rtnl_link_ops->changelink")
Signed-off-by: Ivan Vecera
---
net/bridge/br_n
ltering is broken.
Cc: Sathya Perla
Cc: Ajit Khaparde
Cc: Sriharsha Basavapatna
Cc: Somnath Kotur
Fixes: 988d44b be2net: Avoid redundant addition of mac address in HW
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be_main.c | 9 +++--
1 file changed, 3 insertions(+), 6 d
o HW. So the last UC address is never
stored into HW and address 00:00:00:00;00:00 (from uc_list[0]) is used
instead.
Cc: Sathya Perla
Cc: Ajit Khaparde
Cc: Sriharsha Basavapatna
Cc: Somnath Kotur
Fixes: b717241 be2net: replace polling with sleeping in the FW completion path
Signed-off-by:
er == MDB_RTR_TYPE_TEMP)
+ p->multicast_router = MDB_RTR_TYPE_TEMP_QUERY;
}
int br_multicast_set_port_router(struct net_bridge_port *p, unsigned long val)
Acked-by: Ivan Vecera
allow timer refresh */
if (p->multicast_router == MDB_RTR_TYPE_TEMP)
Acked-by: Ivan Vecera
val)
goto unlock;
+ br_mc_disabled_update(br->dev, !val);
br->multicast_disabled = !val;
if (br->multicast_disabled)
goto unlock;
Acked-by: Ivan Vecera
Add missing words to the help output for -x and -X commands as well
as an ability to set the indirection table to default value.
Signed-off-by: Ivan Vecera
---
ethtool.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index 7af039e..61043ee 100644
++++++
> p1 p2 p3 p4 p5 p6
> -
> - front-panel ports
>
> -
>
> +
> + front-panel ports
> +
>
> Fig 1.
>
>
Acked-by: Ivan Vecera
Remove global variable bnad_list and bnad->list_entry that are used
as list of bna driver instances. It is not necessary and useless.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bnad.c | 3 ---
drivers/net/ethernet/brocade/bna/bnad.h | 1 -
2 files changed, 4 deleti
Change type of bna_id to atomic_t. The bnad_list_mutex is used to prevent
a race when bna_id is incremented. After the change the mutex can be
removed in the next step.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bnad.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Remove global bnad_list_mutex as it is not used anymore. This makes
bnad_add_to_list() and bnad_remove_from_list() empty so remove them too.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bnad.c | 20
1 file changed, 20 deletions(-)
diff --git a/drivers
-by: Ivan Vecera
drivers/net/ethernet/brocade/bna/bnad.c | 27 ++-
drivers/net/ethernet/brocade/bna/bnad.h | 1 -
2 files changed, 2 insertions(+), 26 deletions(-)
--
2.7.3
Remove unused and useless priv_size member from struct devlink_ops.
Cc: Jiri Pirko
Signed-off-by: Ivan Vecera
---
include/net/devlink.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index c99ffe8..211bd3c 100644
--- a/include/net/devlink.h
et Tx coalescing time to 0.
Cc: satish.baddipad...@broadcom.com
Cc: siva.kal...@broadcom.com
Cc: michael.c...@broadcom.com
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/broadcom/tg3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/tg3.c
b/drivers/net/eth
Dne 30.8.2016 v 19:52 Sergei Shtylyov napsal(a):
Hello.
On 08/30/2016 05:38 PM, Ivan Vecera wrote:
The recent commit 087d7a8c disallows to set Rx coalescing time to be 0
You should specify both 12-digit SHA1 and the commit summary enclosed in
("").
as this stops generating
Dne 30.8.2016 v 17:46 Michael Chan napsal(a):
On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera wrote:
The recent commit 087d7a8c disallows to set Rx coalescing time to be 0
as this stops generating interrupts for the incoming packets. I found
the zero Tx coalescing time stops generating interrupts
Dne 31.8.2016 v 18:19 Michael Chan napsal(a):
On Wed, Aug 31, 2016 at 2:27 AM, Ivan Vecera wrote:
Dne 30.8.2016 v 17:46 Michael Chan napsal(a):
On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera wrote:
The recent commit 087d7a8c disallows to set Rx coalescing time to be 0
as this stops
d fires Tx watchdog later. To avoid this, don't allow to set
Tx coalescing time to 0 and also remove subsequent checks that become
senseless.
Cc: satish.baddipad...@broadcom.com
Cc: siva.kal...@broadcom.com
Cc: michael.c...@broadcom.com
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/broa
Dne 14.10.2016 v 21:46 Ben Greear napsal(a):
I am getting warnings about sign missmatch.
Maybe make SPEED_UNKNOWN be ((__u32)(0x)) ?
The 0xU could be better.
Ivan
local_bh_enable_ip(unsigned long ip)
WARN_ON_ONCE(in_irq() || irqs_disabled()); <<<<<< WARN
Cc: Sony Chacko
Cc: dept-hsglinuxnic...@qlogic.com
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/broadcom/bnx2.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
local_bh_enable_ip(unsigned long ip)
WARN_ON_ONCE(in_irq() || irqs_disabled()); <<<<<< WARN
Cc: Sony Chacko
Cc: dept-hsglinuxnic...@qlogic.com
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/broadcom/bnx2.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
Dne 17.10.2016 v 19:21 David Miller napsal(a):
From: Ivan Vecera
Date: Mon, 17 Oct 2016 18:20:31 +0200
diff --git a/drivers/net/ethernet/broadcom/bnx2.c
b/drivers/net/ethernet/broadcom/bnx2.c
index 27f11a5..9c408413 100644
--- a/drivers/net/ethernet/broadcom/bnx2.c
+++ b/drivers/net/ethernet
"
Cc: Alexander Duyck
Signed-off-by: Ivan Vecera
---
arch/powerpc/include/asm/checksum.h | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc/include/asm/checksum.h
b/arch/powerpc/include/asm/checksum.h
index ee655ed..1e8fceb 100644
--- a/arch/powerpc/in
longer
necessary driver "kind" strings which were used to link PCI ids with
individual mlxsw drivers.
Suggested-by: Ivan Vecera
Tested-by: Ivan Vecera
Signed-off-by: Jiri Pirko
Reviewed-by: Ido Schimmel
Thanks Jiri.
Acked-by: Ivan Vecera
Commit ba5ca784 "bna: check for dma mapping errors" added besides other
things a statistic that counts number of DMA buffer mapping failures
per each Rx queue. This counter is not included in ethtool stats output.
Fixes: ba5ca784 "bna: check for dma mapping errors"
Signed
r of
strings in the array and also removes rtnl_link_stats64 entries that
are not used in output and are always zero.
Fixes: 6e7333d "net: add rx_nohandler stat counter"
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bnad_ethtool.c | 50 -
1 fi
On 1.8.2016 16:20, David Laight wrote:
From: Ivan Vecera
Sent: 29 July 2016 18:53
Change type of bna_id to atomic_t. The bnad_list_mutex is used to prevent
a race when bna_id is incremented. After the change the mutex can be
removed in the next step.
...
-static u32 bna_id;
+static atomic_t
Signed-off-by: Ivan Vecera
---
ethtool.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ethtool.8.in b/ethtool.8.in
index ae56293..eeffa70 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -872,7 +872,7 @@ Enables/disables the device support of EEE.
Determines whether the
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().
Signed-off-by: Ivan Vecera
---
drivers/infiniband/hw/nes/
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().
v2: removed unused variable
Signed-off-by: Ivan Vecera
---
drivers/infiniba
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().
v2: removed unused variable
v3: removed another unused variable
Signed-off
RXF_E_PAUSE & RXF_E_RESUME events are never sent for bna_rxf object so
they needn't to be handled. The bna_rxf's state bna_rxf_sm_fltr_clr_wait
and function bna_rxf_fltr_clear are unused after this so remove them also.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/b
removed:
bna_rx_ucast_add
bna_rx_ucast_del
simplified:
bna_enet_pause_config
bna_rx_mcast_delall
bna_rx_mcast_listset
bna_rx_mode_set
bna_rx_ucast_listset
bna_rx_ucast_set
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna.h | 24 +
drivers/net
The bna_rx_config struct member paused can be removed as it is never
written and as it cannot have non-zero value the bna_rxf struct member
flags also cannot have BNA_RXF_F_PAUSED value and is always zero.
So the flags member can be removed as well as bna_rxf_flags enum and
the code-paths that need
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 13 -
drivers/net/ethernet/brocade/bna/bna_types.h | 3 ---
2 files changed, 16 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
b/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
index
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 12 ++--
drivers/net/ethernet/brocade/bna/bnad.c | 14 ++
2 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
b/drivers/net/ethernet
TX_E_PRIO_CHANGE event is never sent for bna_tx so it doesn't need to be
handled. After this change bna_tx->flags cannot contain
BNA_TX_F_PRIO_CHANGED flag and it can be also eliminated.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna_tx_r
FT
BNA_{C,RX,TX}Q_QPGE_PTR_GET
BNA_IOC_TIMER_FREQ
BNA_MESSAGE_SIZE
BNA_QE_INDX_2_PTR
BNA_QE_INDX_RANGE
BNA_Q_GET_{C,P}I
BNA_Q_{C,P}I_ADD
BNA_Q_FREE_COUNT
BNA_Q_IN_USE_COUNT
BNA_TO_POWER_OF_2
containing_rec
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_cs.h | 14
dr
Signed-off-by: Ivan Vecera
---
.../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 2 +-
drivers/net/ethernet/brocade/bna/bfi_enet.h| 66 ++--
drivers/net/ethernet/brocade/bna/bna_enet.c| 4 +-
drivers
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna.h | 15 ---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 6 --
drivers/net/ethernet/brocade/bna/bna_types.h | 4
3 files changed, 25 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna
The patch converts mac_t type to widely used 'u8 [ETH_ALEN]'.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_defs.h | 4 ++--
drivers/net/ethernet/brocade/bna/bfa_defs_cna.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8
drivers/ne
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index 29e0428..52fc439 100644
--- a/drivers/net/ethernet
The patches clean the bna driver.
Ivan Vecera (19):
bna: use ether_addr_copy instead of memcpy
bna: get rid of mac_t
bna: replace pragma(pack) with attribute __packed
bna: get rid of duplicate and unused macros
bna: use BIT(x) instead of (1 << x)
bna: remove unused cbfn par
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_defs.h| 6 +-
drivers/net/ethernet/brocade/bna/bfa_defs_cna.h| 14 +--
.../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 6 +-
drivers/net/ethernet/brocade/bna/bfi.h | 70 +++---
drivers
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna_enet.c | 15 ---
drivers/net/ethernet/brocade/bna/bna_types.h | 3 ---
2 files changed, 18 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_enet.c
b/drivers/net/ethernet/brocade/bna/bna_enet.c
index
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 5 +-
drivers/net/ethernet/brocade/bna/bna.h | 41 --
drivers/net/ethernet/brocade/bna/bna_enet.c | 23 --
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 117 +--
4 files
Remove macros for manipulation with struct list_head and replace them
with standard ones.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_cee.c | 1 -
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10 +-
drivers/net/ethernet/brocade/bna/bfa_msgq.c | 10 +-
drivers
Patch converts kzalloc->copy_from_user sequence to memdup_user. There
is also one useless assignment of NULL to bnad->regdata as it is followed
by assignment of kzalloc output.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 27 -
Pointer cmpl used to iterate through completion entries is updated at
the beginning of while loop as well as at the end. The update at the end
of the loop is useless.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bnad.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bnad.c | 46 +
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 34 --
drivers/net/ethernet/brocade/bna/bnad_ethtool.c | 9 ++---
drivers/net/ethernet/brocade/bna/cna_fwimg.c| 2
Timeout functions are defined with 'void *' ptr argument. They should
be defined directly with 'struct bfa_ioc *' type to avoid type conversions.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 16 +---
drivers/net/ethernet/brocad
On 06/10/2015 10:29 PM, Joe Perches wrote:
On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
Signed-off-by: Ivan Vecera
There should be some indication a few messages have
been deleted in the commit log and a reason why too.
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c
b
On 06/10/2015 07:57 PM, Joe Perches wrote:
On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
Signed-off-by: Ivan Vecera
Have you verified that all of these are __aligned(2)?
I haven't, but you should verify that you have in the
commit log.
I have checked an alignment of all inst
The patch converts mac_t type to widely used 'u8 [ETH_ALEN]'.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_defs.h | 4 ++--
drivers/net/ethernet/brocade/bna/bfa_defs_cna.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8
drivers/ne
101 - 200 of 240 matches
Mail list logo
