Re: [v2,1/2] tools: bpftool: add net attach command to attach XDP on interface

2019-08-03 Thread Jakub Kicinski
On Sat, 3 Aug 2019 18:39:21 +0900, Daniel T. Lee wrote: > On Sat, Aug 3, 2019 at 3:39 AM Jakub Kicinski wrote: > > Right, I was wondering if we want to call it force, though? force is > > sort of a reuse of iproute2 concept. But it's kind of hard to come up > > with name

Re: [PATCH net 0/2] flow_offload hardware priority fixes

2019-08-05 Thread Jakub Kicinski
On Sat, 3 Aug 2019 09:08:54 +0200, Pablo Neira Ayuso wrote: > The idea is that every subsystem (ethtool, tc, nf) sets up/binds its > own flow_block object. And each flow_block object has its own priority > range space. So whatever priority the user specifies only applies to > the specific subsystem

Re: [PATCH] tools: bpftool: fix reading from /proc/config.gz

2019-08-05 Thread Jakub Kicinski
On Mon, 5 Aug 2019 08:29:36 -0700, Stanislav Fomichev wrote: > On 08/05, Peter Wu wrote: > > /proc/config has never existed as far as I can see, but /proc/config.gz > > is present on Arch Linux. Execute an external gunzip program to avoid > > linking to zlib and rework the option scanning code sinc

Re: [PATCH 1/1] bpf: introduce new helper udp_flow_src_port

2019-08-05 Thread Jakub Kicinski
On Sat, 3 Aug 2019 23:52:16 -0700, Y Song wrote: > > include/uapi/linux/bpf.h | 21 +++-- > > net/core/filter.c | 20 > > tools/include/uapi/linux/bpf.h| 21 +++-- > > tools/testing/selftests/bpf/bpf_helpers.h |

Re: [PATCH v2] tools: bpftool: fix reading from /proc/config.gz

2019-08-05 Thread Jakub Kicinski
On Tue, 6 Aug 2019 02:07:02 +0100, Peter Wu wrote: > /proc/config has never existed as far as I can see, but /proc/config.gz > is present on Arch Linux. Execute an external gunzip program to avoid > linking to zlib and rework the option scanning code since a pipe is not > seekable. This also fixes

Re: [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2019-08-04

2019-08-05 Thread Jakub Kicinski
On Sun, 4 Aug 2019 04:59:18 -0700, Jeff Kirsher wrote: > This series contains more updates to fm10k from Jake Keller. > > Jake removes the unnecessary initialization of some variables to help > resolve static code checker warnings. Explicitly return success during > resume, since the value of 'e

Re: [PATCH net-next v6 0/6] flow_offload: add indr-block in nf_table_offload

2019-08-05 Thread Jakub Kicinski
-block. Looks good to me, thanks for the changes! Acked-by: Jakub Kicinski

Re: [net-next v2 0/8][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-05

2019-08-05 Thread Jakub Kicinski
On Mon, 5 Aug 2019 11:54:51 -0700, Jeff Kirsher wrote: > This series contains updates to i40e driver only. > > Dmitrii adds missing statistic counters for VEB and VEB TC's. > > Slawomir adds support for logging the "Disable Firmware LLDP" flag > option and its current status. > > Jake fixes an

Re: [PATCH 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 18:11:19 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jakub Kicinski > Cc

Re: [PATCH 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 19:00:49 +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 06, 2019 at 09:50:08AM -0700, Jakub Kicinski wrote: > > On Tue, 6 Aug 2019 18:11:19 +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the > &

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 18:40:36 +0200, Jiri Pirko wrote: > Hi all. > > I just discussed this with DavidA and I would like to bring this to > broader audience. David wants to limit kernel resources in network > namespaces, for example fibs, fib rules, etc. > > He claims that devlink api is rich enough

Re: [PATCH 0/2 net,v4] flow_offload hardware priority fixes

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 18:03:08 +0200, Pablo Neira Ayuso wrote: > Hi, > > This patchset contains two updates for the flow_offload users: > > 1) Pass the major tc priority to drivers so they do not have to >lshift it. This is a preparation patch for the fix coming in >patch #2. > > 2) Set th

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 20:38:41 +0200, Jiri Pirko wrote: > >> So the proposal is to have some new device, say "kernelnet", that > >> would implicitly create per-namespace devlink instance. This devlink > >> instance would be used to setup resource limits. Like: > >> > >> devlink resource set kernelnet

Re: [PATCH net] hv_netvsc: Fix a warning of suspicious RCU usage

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 05:17:44 +, Dexuan Cui wrote: > This fixes a warning of "suspicious rcu_dereference_check() usage" > when nload runs. > > Signed-off-by: Stephen Hemminger > Signed-off-by: Dexuan Cui Minor change in behaviour would perhaps be worth acknowledging in the commit message (sin

Re: [PATCH net-next v2 1/1] qed: Add new ethtool supported port types based on media.

2019-08-06 Thread Jakub Kicinski
On Mon, 5 Aug 2019 23:59:50 -0700, Rahul Verma wrote: > Supported ports in ethtool are displayed based on media type. > For media type fibre and twinaxial, port type is "FIBRE". Media type > Base-T is "TP" and media KR is "Backplane". > > V1->V2: > Corrected the subject. > > Signed-off-by: Rahul

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 12:15:17 -0700, David Ahern wrote: > From: David Ahern > > Prior to the commit in the fixes tag, the resource controller in netdevsim > tracked fib entries and rules per network namespace. Restore that behavior. > > Fixes: 5fc494225c1e ("netdevsim: create devlink instance per

[PATCH bpf 1/2] tools: bpftool: fix error message (prog -> object)

2019-08-06 Thread Jakub Kicinski
Change an error message to work for any object being pinned not just programs. Fixes: 71bb428fe2c1 ("tools: bpf: add bpftool") Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH bpf 2/2] tools: bpftool: add error message on pin failure

2019-08-06 Thread Jakub Kicinski
No error message is currently printed if the pin syscall itself fails. It got lost in the loadall refactoring. Fixes: 77380998d91d ("bpftool: add loadall command") Reported-by: Andy Lutomirski Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- CC: l...@kernel.org, s...@

[PATCH bpf 0/2] tools: bpftool: fix pinning error messages

2019-08-06 Thread Jakub Kicinski
Hi! First make sure we don't use "prog" in error messages because the pinning operation could be performed on a map. Second add back missing error message if pin syscall failed. Jakub Kicinski (2): tools: bpftool: fix error message (prog -> object) tools: bpftool: add er

[PATCH net v2] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-08-06 Thread Jakub Kicinski
s decrypted mark copy (Willem); - remove the stale doc entry (Boris); - rely entirely on EOR marking to prevent coalescing (Boris); - use an internal sendpages flag instead of marking the socket (Boris). Signed-off-by: Jakub Kicinski --- Documentation/networking/tls-offload.rst | 18 -

Re: [PATCH net v2] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-08-07 Thread Jakub Kicinski
On Wed, 7 Aug 2019 12:59:00 -0400, Willem de Bruijn wrote: > On Wed, Aug 7, 2019 at 2:06 AM Jakub Kicinski wrote: > > diff --git a/net/core/sock.c b/net/core/sock.c > > index d57b0cc995a0..0f9619b0892f 100644 > > --- a/net/core/sock.c > > +++ b/net/core/sock.c >

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-07 Thread Jakub Kicinski
On Tue, 6 Aug 2019 20:33:47 -0600, David Ahern wrote: > Some time back supported was added for devlink 'resources'. The idea is > that hardware (mlxsw) has limited resources (e.g., memory) that can be > allocated in certain ways (e.g., kvd for mlxsw) thus implementing > restrictions on the number o

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-07 Thread Jakub Kicinski
On Tue, 6 Aug 2019 21:10:40 -0600, David Ahern wrote: > On 8/6/19 8:59 PM, Andrew Lunn wrote: > > However, zoom out a bit, from networking to the whole kernel. In > > general, across the kernel as a whole, resource management is done > > with cgroups. cgroups is the consistent operational model acr

Re: [v3,2/4] tools: bpftool: add net detach command to detach XDP on interface

2019-08-07 Thread Jakub Kicinski
On Wed, 7 Aug 2019 10:02:04 -0700, Y Song wrote: > -bash-4.4$ sudo ./bpftool net detach x dev v2 > -bash-4.4$ sudo ./bpftool net > xdp: > v1(4) driver id 1172 > > tc: > eth0(2) clsact/ingress fbflow_icmp id 29 act [] > eth0(2) clsact/egress cls_fg_dscp_section id 27 act [] > eth0(2) clsact/egress

Re: [v3,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-07 Thread Jakub Kicinski
On Wed, 7 Aug 2019 11:25:06 +0900, Daniel T. Lee wrote: > By this commit, using `bpftool net attach`, user can attach XDP prog on > interface. New type of enum 'net_attach_type' has been made, as stated at > cover-letter, the meaning of 'attach' is, prog will be attached on interface. > > With 'o

Re: [PATCH net v2] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-08-07 Thread Jakub Kicinski
On Wed, 7 Aug 2019 14:46:23 -0400, Willem de Bruijn wrote: > > > > @@ -984,6 +984,9 @@ ssize_t do_tcp_sendpages(struct sock *sk, struct > > > > page *page, int offset, > > > > if (!skb) > > > > goto wait_for_memory; > > > > > > > > +#ifdef CO

[PATCH net v3] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-08-07 Thread Jakub Kicinski
marking the socket (Boris). v3 (Willem): - reorganize the can_skb_orphan_partial() condition; - fix the flag leak-in through tcp_bpf_sendmsg. Signed-off-by: Jakub Kicinski --- Documentation/networking/tls-offload.rst | 18 -- include/linux/skbuff.h | 8 +++

Re: [PATCH net v3] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-08-08 Thread Jakub Kicinski
On Thu, 8 Aug 2019 11:59:18 -0400, Willem de Bruijn wrote: > > diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c > > index 7c0b2b778703..43922d86e510 100644 > > --- a/net/tls/tls_device.c > > +++ b/net/tls/tls_device.c > > @@ -373,9 +373,9 @@ static int tls_push_data(struct sock *sk, > >

Re: [v3,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-08 Thread Jakub Kicinski
On Thu, 8 Aug 2019 07:15:22 +0900, Daniel T. Lee wrote: > > > + return -EINVAL; > > > + } > > > + > > > + NEXT_ARG(); > > > > nit: the new line should be before NEXT_ARG(), IOV NEXT_ARG() belongs > > to the code which consumed the argument > > > > I'm not sure I'm following

Re: [v3,2/4] tools: bpftool: add net detach command to detach XDP on interface

2019-08-08 Thread Jakub Kicinski
On Thu, 8 Aug 2019 12:52:11 -0700, Y Song wrote: > > Ah ok. In this scenario if driver has a native xdp support we would be > > invoking > > its ndo_bpf even if there's no prog currently attached and it wouldn't > > return > > error value. > > > > Looking at dev_xdp_uninstall, setting driver's pr

Re: [net 01/12] net/mlx5e: Use flow keys dissector to parse packets for ARFS

2019-08-08 Thread Jakub Kicinski
On Thu, 8 Aug 2019 20:22:00 +, Saeed Mahameed wrote: > From: Maxim Mikityanskiy > > The current ARFS code relies on certain fields to be set in the SKB > (e.g. transport_header) and extracts IP addresses and ports by custom > code that parses the packet. The necessary SKB fields, however, are

Re: [PATCH v2 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 14:30:59 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jakub Kicinski > Cc

Re: [PATCH 3/3] tipc: fix issue of calling smp_processor_id() in preemptible

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 15:16:57 +0800, Ying Xue wrote: > Fixes: e9c1a793210f ("tipc: add dst_cache support for udp media") > syzbot+1a68504d96cd17b33...@syzkaller.appspotmail.com ^ Reported-by: missing here? > Signed-off-by: Hillf Danton > Signed-off-by: Ying Xue

Re: [net 01/12] net/mlx5e: Use flow keys dissector to parse packets for ARFS

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 18:49:50 +, Saeed Mahameed wrote: > On Thu, 2019-08-08 at 18:15 -0700, Jakub Kicinski wrote: > > On Thu, 8 Aug 2019 20:22:00 +, Saeed Mahameed wrote: > > > From: Maxim Mikityanskiy > > > > > > The current ARFS code relies on

Re: [PATCH v3] tools: bpftool: fix reading from /proc/config.gz

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 08:32:10 -0700, Stanislav Fomichev wrote: > On 08/09, Peter Wu wrote: > > /proc/config has never existed as far as I can see, but /proc/config.gz > > is present on Arch Linux. Add support for decompressing config.gz using > > zlib which is a mandatory dependency of libelf. Replac

Re: [net-next 01/15] ice: Implement ethtool ops for channels

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 11:31:25 -0700, Jeff Kirsher wrote: > From: Henry Tieman > > Add code to query and set the number of queues on the primary > VSI for a PF. This is accessed from the 'ethtool -l' and 'ethtool -L' > commands, respectively. > > Signed-off-by: Henry Tieman > Signed-off-by: Tony

Re: [patch net-next] netdevsim: register couple of devlink params

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 13:05:12 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Register couple of devlink params, one generic, one driver-specific. > Make the values available over debugfs. > > Example: > $ echo "111" > /sys/bus/netdevsim/new_device > $ devlink dev param > netdevsim/netdevsim111:

Re: [v4,0/4] tools: bpftool: add net attach/detach command to attach XDP prog

2019-08-09 Thread Jakub Kicinski
driver id 20 > > # bpftool net detach xdpdrv dev enp6s0np0 > # bpftool net > xdp: > > > While this patch only contains support for XDP, through `net > attach/detach`, bpftool can further support other prog attach types. > > XDP attach/detach tested on Mellanox

Re: [PATCH v3] tools: bpftool: fix reading from /proc/config.gz

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 14:48:31 -0700, Stanislav Fomichev wrote: > I'm just being nit picky :-) > Because changelog says we already depend on -lz, but then in the patch > we explicitly add it. > > I think you were right in pointing out that we already implicitly depend > on -lz via -lelf and/or -lbfd.

[PATCH net] net/tls: swap sk_write_space on close

2019-08-09 Thread Jakub Kicinski
t;bpf: sockmap/tls, close can race with map free") Signed-off-by: Jakub Kicinski --- net/tls/tls_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c index 9cbbae606ced..ce6ef56a65ef 100644 --- a/net/tls/tls_main.c +++ b/net/tls/tls_main.c @@ -30

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2019 08:13:39 -0700, Roopa Prabhu wrote: > On Mon, Aug 12, 2019 at 1:31 AM Jiri Pirko wrote: > > Mon, Aug 12, 2019 at 03:37:26AM CEST, dsah...@gmail.com wrote: > > >On 8/11/19 7:34 PM, David Ahern wrote: > > >> On 8/10/19 12:30 AM, Jiri Pirko wrote: > > >>> Could you please wr

Re: [net-next 01/15] ice: Implement ethtool ops for channels

2019-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2019 15:07:09 +, Nguyen, Anthony L wrote: > On Fri, 2019-08-09 at 14:15 -0700, Jakub Kicinski wrote: > > On Fri, 9 Aug 2019 11:31:25 -0700, Jeff Kirsher wrote: > > > From: Henry Tieman > > > > > > Add code to query and set the number of q

Re: [PATCH] tools: bpftool: add feature check for zlib

2019-08-12 Thread Jakub Kicinski
ep target of tools/lib/bpf/Makefile, pulled in by bpftool via > a dependency on libbpf.a. Add a similar feature check for zlib. > > Suggested-by: Jakub Kicinski > Signed-off-by: Peter Wu Acked-by: Jakub Kicinski Thanks!

Re: [patch net-next] netdevsim: implement support for devlink region and snapshots

2019-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2019 12:16:20 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Implement dummy region of size 32K and allow user to create snapshots > or random data using debugfs file trigger. > > Signed-off-by: Jiri Pirko I'm nacking all the netdevsim patches unless the selftest is posted at

Re: [patch net-next v3 0/3] net: devlink: Finish network namespace support

2019-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2019 18:24:41 -0600, David Ahern wrote: > On 8/12/19 7:47 AM, Jiri Pirko wrote: > > From: Jiri Pirko > > > > Devlink from the beginning counts with network namespaces, but the > > instances has been fixed to init_net. The first patch allows user > > to move existing devlink instanc

Re: [patch net-next v3 1/3] net: devlink: allow to change namespaces

2019-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2019 15:47:49 +0200, Jiri Pirko wrote: > @@ -6953,9 +7089,33 @@ int devlink_compat_switch_id_get(struct net_device > *dev, > return 0; > } > > +static void __net_exit devlink_pernet_exit(struct net *net) > +{ > + struct devlink *devlink; > + > + mutex_lock(&devlink_

Re: [patch net-next v3 1/3] net: devlink: allow to change namespaces

2019-08-13 Thread Jakub Kicinski
On Tue, 13 Aug 2019 08:13:55 +0200, Jiri Pirko wrote: > Tue, Aug 13, 2019 at 03:21:22AM CEST, jakub.kicin...@netronome.com wrote: > >On Mon, 12 Aug 2019 15:47:49 +0200, Jiri Pirko wrote: > >> @@ -6953,9 +7089,33 @@ int devlink_compat_switch_id_get(struct net_device > >> *dev, > >>return 0; >

Re: [patch net-next v3 0/3] net: devlink: Finish network namespace support

2019-08-13 Thread Jakub Kicinski
On Mon, 12 Aug 2019 19:46:57 -0600, David Ahern wrote: > On 8/12/19 7:11 PM, Jakub Kicinski wrote: > > If the devlink instance just disappeared - that'd be a very very strange > > thing. Only software objects disappear with the namespace. > > Netdevices without ->rtnl

Re: [PATCv4 net-next] octeontx2-pf: Add RSS multi group support

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 04:17:44 + Geethasowjanya Akula wrote: > Hi All, > > Any feedback on this patch. I think Dave merged it already, see commit 81a4362016e7 ("octeontx2-pf: Add RSS multi group support") in net-next.

Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-12 Thread Jakub Kicinski
On Wed, 13 Jan 2021 02:47:51 +0530 rohit maheshwari wrote: > On 07/01/21 12:47 AM, Jakub Kicinski wrote: > > On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: > >> Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. > >> And it broke tls offl

Re: [PATCH net-next 0/7] a set of fixes of coding style

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 00:42:58 -0600 Lijun Pan wrote: > This series address several coding style problems. Erm, are you sure this series will not conflict with the fixes Sukadev is sending?

Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 11:55:11 -0800 Praveen Chaudhary wrote: > Hi Jakub > > Thanks for the review, > > Sure, I will reraise the patch (again v0i, sonce no code changes) after > adding space before '<'. > > This patch adds lines in 'include/uapi/', that requires ABI version changes > for debian

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 13:23:16 +0100 Eric Dumazet wrote: > On Tue, Jan 12, 2021 at 12:08 PM Alexander Lobakin wrote: > > > > From: Edward Cree > > Date: Tue, 12 Jan 2021 09:54:04 + > > > > > Without wishing to weigh in on whether this caching is a good idea... > > > > Well, we already have

Re: [Patch net] cls_flower: call nla_ok() before nla_next()

2021-01-12 Thread Jakub Kicinski
On Mon, 11 Jan 2021 18:55:48 -0800 Cong Wang wrote: > From: Cong Wang > > fl_set_enc_opt() simply checks if there are still bytes left to parse, > but this is not sufficent as syzbot seems to be able to generate > malformatted netlink messages. nla_ok() is more strict so should be > used to valid

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 11:03:00 +0100 Marc Kleine-Budde wrote: > On 1/12/21 10:54 AM, Vincent Mailhol wrote: > > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > > tx timestamp gets attached on the skb. > > > > There two main reasons to include this call in can_put_echo_skb(): >

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 17:46:25 -0800 Jakub Kicinski wrote: > On Tue, 12 Jan 2021 11:03:00 +0100 Marc Kleine-Budde wrote: > > On 1/12/21 10:54 AM, Vincent Mailhol wrote: > > > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > > > tx timesta

Re: [PATCH net-next v2 5/7] ibmvnic: serialize access to work queue

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 16:40:49 -0800 Sukadev Bhattiprolu wrote: > Saeed Mahameed [sa...@kernel.org] wrote: > > On Tue, 2021-01-12 at 10:14 -0800, Sukadev Bhattiprolu wrote: > > > > > @@ -5467,7 +5472,15 @@ static int ibmvnic_remove(struct vio_dev *dev) > > > return -EBUSY; > > > } > >

Re: [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 10:14:34 -0800 Sukadev Bhattiprolu wrote: > Use more consistent locking when reading/writing the adapter->state > field. This patch set fixes a race condition during ibmvnic_open() > where the adapter could be left in the PROBED state if a reset occurs > at the wrong time. This

Re: [PATCH net v2] net: macb: Add default usrio config to default gem config

2021-01-12 Thread Jakub Kicinski
On Mon, 11 Jan 2021 17:47:28 -0800 Atish Patra wrote: > There is no usrio config defined for default gem config leading to > a kernel panic devices that don't define a data. This issue can be > reprdouced with microchip polar fire soc where compatible string > is defined as "cdns,macb". > > Fixes:

Re: [PATCH v2] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

2021-01-12 Thread Jakub Kicinski
On Mon, 11 Jan 2021 18:09:49 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > In rvu_mbox_handler_cgx_mac_addr_get() > and rvu_mbox_handler_cgx_mac_addr_set(), > the msg is expected only from PFs that are mapped to CGX LMACs. > It should be checked before mapping, > so we add the is_cg

Re: [PATCH v1] net/ipv4: add IPv4_is_multicast() check in ip_mc_leave_group().

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 00:47:09 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > There is no IPv4_is_multicast() check added to ip_mc_leave_group() > to determine whether imr->imr_multiaddr.s_addr is a multicast address. > If not a multicast address, it may result in an error. > In some c

Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE() under some circumstances

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 15:59:15 + David Howells wrote: > From: Baptiste Lepers > > The call state may be changed at any time by the data-ready routine in > response to received packets, so if the call state is to be read and acted > upon several times in a function, READ_ONCE() must be used unle

Re: [PATCH net 1/2] net: stmmac: fix taprio schedule configuration

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 18:24:56 +0100 Yannick Vignon wrote: > From: Yannick Vignon > > When configuring a 802.1Qbv schedule through the tc taprio qdisc on an NXP > i.MX8MPlus device, the effective cycle time differed from the requested one > by N*96ns, with N number of entries in the Qbv Gate Contro

Re: [PATCH] net: phy: smsc: fix clk error handling

2021-01-12 Thread Jakub Kicinski
k_get_optional() throw an error but instead of returning the error it > > ignores it. > > > > Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in > > support") > > Suggested-by: Jakub Kicinski > > Signed-off-by: Marco Felsch > > Reviewed-by: Andrew Lunn Applied, thanks!

Re: [PATCH net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig

2021-01-12 Thread Jakub Kicinski
On Mon, 11 Jan 2021 15:49:33 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 01:50:46PM +0100, Marek Vasut wrote: > > The PHYLIB must be selected to provide mdiobus_*() functions, and the > > MICREL_PHY is necessary too, as that is the only possible PHY attached > > to the KS8851 (it is the inte

Re: [PATCH net] net: dsa: clear devlink port type before unregistering slave netdevs

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 10:49:21 -0800 Florian Fainelli wrote: > On 1/11/21 4:48 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > Florian reported a use-after-free bug in devlink_nl_port_fill found with > > KASAN: > > > > (devlink_nl_port_fill) > > (devlink_port_notify) > > (devlink_port

Re: [PATCH net] net: dsa: unbind all switches from tree when DSA master unbinds

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 10:51:39 -0800 Florian Fainelli wrote: > On 1/11/21 3:09 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > Currently the following happens when a DSA master driver unbinds while > > there are DSA switches attached to it: > > > > $ echo :00:00.5 > /sys/bus/pci/d

Re: [PATCH net-next 0/3] r8169: further improvements

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 12:21:48 -0800 Saeed Mahameed wrote: > On Tue, 2021-01-12 at 09:27 +0100, Heiner Kallweit wrote: > > Series includes further smaller improvements. > > > > Heiner Kallweit (3): > > r8169: align rtl_wol_suspend_quirk with vendor driver and rename it > > r8169: improve rtl8169

Re: [PATCH net-next 1/2] mlxsw: Register physical ports as a devlink resource

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 10:39:30 +0200 Ido Schimmel wrote: > From: Danielle Ratson > > The switch ASIC has a limited capacity of physical ('flavour physical' > in devlink terminology) ports that it can support. While each system is > brought up with a different number of ports, this number can be > i

Re: [PATCH net 0/3] Netfilter fixes for net

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 23:20:30 +0100 Pablo Neira Ayuso wrote: > The following patchset contains Netfilter fixes for net: > > 1) Pass conntrack -f to specify family in netfilter conntrack helper >selftests, from Chen Yi. > > 2) Honor hashsize modparam from nf_conntrack_buckets sysctl, >from

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 05:46:05 +0100 Eric Dumazet wrote: > On Wed, Jan 13, 2021 at 2:02 AM Jakub Kicinski wrote: > > > > On Tue, 12 Jan 2021 13:23:16 +0100 Eric Dumazet wrote: > > > On Tue, Jan 12, 2021 at 12:08 PM Alexander Lobakin > > > wrote: > > >

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 18:15:20 +0100 Eric Dumazet wrote: > > IDK much about MM, but we already have a kmem_cache for skbs and now > > we're building a cache on top of a cache. Shouldn't MM take care of > > providing a per-CPU BH-only lockless cache? > > I think part of the improvement comes from

Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE() under some circumstances

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 08:23:54 + David Howells wrote: > Jakub Kicinski wrote: > > > On Tue, 12 Jan 2021 15:59:15 + David Howells wrote: > > > From: Baptiste Lepers > > > > > > The call state may be changed at any time by the data-ready routine in

Re: [PATCH net-next 1/2] mlxsw: Register physical ports as a devlink resource

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 16:26:56 +0200 Ido Schimmel wrote: > On Wed, Jan 13, 2021 at 02:39:02PM +0100, Jiri Pirko wrote: > > Wed, Jan 13, 2021 at 09:32:41AM CET, ido...@idosch.org wrote: > > >On Tue, Jan 12, 2021 at 08:21:22PM -0800, Jakub Kicinski wrote: > > >> On T

Re: [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking

2021-01-13 Thread Jakub Kicinski
On Tue, 12 Jan 2021 20:42:47 -0800 Sukadev Bhattiprolu wrote: > Jakub Kicinski [k...@kernel.org] wrote: > > On Tue, 12 Jan 2021 10:14:34 -0800 Sukadev Bhattiprolu wrote: > > > Use more consistent locking when reading/writing the adapter->state > > > field. This pa

Re: kernel BUG at net/core/dev.c:NUM!

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 02:27:27 -0800 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:c49243e8 Merge branch 'net-fix-issues-around-register_netd.. > git tree: net > console output: https://syzkaller.appspot.com/x/log.txt?x=11da7ba8d0 > kernel config: ht

Re: [pull request][net-next V2 00/11] mlx5 updates 2021-01-07

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 16:01:57 -0800 Saeed Mahameed wrote: > On Wed, 2021-01-13 at 15:41 -0800, Jakub Kicinski wrote: > > On Mon, 11 Jan 2021 23:05:23 -0800 Saeed Mahameed wrote: > > > From: Saeed Mahameed > > > > > > Hi Dave, Jakub > > > > >

[PATCH net] net: sit: unregister_netdevice on newlink's error path

2021-01-13 Thread Jakub Kicinski
the system. Reported-and-tested-by: syzbot+2393580080a2da190...@syzkaller.appspotmail.com Fixes: e2f1f072db8d ("sit: allow to configure 6rd tunnels via netlink") Signed-off-by: Jakub Kicinski --- net/ipv6/sit.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/i

[PATCH net v2 3/7] MAINTAINERS: vrf: move Shrijeet to CREDITS

2021-01-13 Thread Jakub Kicinski
...@cumulusnetworks.com INACTIVE MAINTAINER Shrijeet Mukherjee Signed-off-by: Jakub Kicinski --- CC: Shrijeet Mukherjee CC: David Ahern --- CREDITS | 4 MAINTAINERS | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CREDITS b/CREDITS index 3dceea737694..98e7485ec106

[PATCH net v2 2/7] MAINTAINERS: net: move Alexey Kuznetsov to CREDITS

2021-01-13 Thread Jakub Kicinski
Kuznetsov Signed-off-by: Jakub Kicinski --- CC: Alexey Kuznetsov CC: Hideaki YOSHIFUJI --- CREDITS | 4 MAINTAINERS | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CREDITS b/CREDITS index 59a704a45170..3dceea737694 100644 --- a/CREDITS +++ b/CREDITS @@ -2142,6 +2142,10

[PATCH net v2 0/7] MAINTAINERS: remove inactive folks from networking

2021-01-13 Thread Jakub Kicinski
nothing in last 5yrs v2: - keep Felix and Mirko Jakub Kicinski (7): MAINTAINERS: altx: move Jay Cliburn to CREDITS MAINTAINERS: net: move Alexey Kuznetsov to CREDITS MAINTAINERS: vrf: move Shrijeet to CREDITS MAINTAINERS: ena: remove Zorik Machulsky from reviewers MAINTAINERS: t

[PATCH net v2 1/7] MAINTAINERS: altx: move Jay Cliburn to CREDITS

2021-01-13 Thread Jakub Kicinski
[2]: k...@kernel.org [2]: o.rem...@pengutronix.de INACTIVE MAINTAINER Jay Cliburn Signed-off-by: Jakub Kicinski Acked-by: Chris Snook --- CC: Jay Cliburn --- CREDITS | 4 MAINTAINERS | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CREDITS b/CREDITS index

[PATCH net v2 4/7] MAINTAINERS: ena: remove Zorik Machulsky from reviewers

2021-01-13 Thread Jakub Kicinski
3c62 2020-09-10 00:00:00 3 Saeed Bishara : Tags 470793a78ce3 2020-02-11 00:00:00 2 Zorik Machulsky : Top reviewers: [4]: same...@amazon.com [3]: snel...@pensando.io [3]: shay...@amazon.com INACTIVE MAINTAINER Zorik Machulsky Signed-off-by: Jakub Kicinski --- CC: Netan

[PATCH net v2 7/7] MAINTAINERS: dccp: move Gerrit Renker to CREDITS

2021-01-13 Thread Jakub Kicinski
kstew...@linuxfoundation.org [6]: alli...@lohutok.net [5]: eduma...@google.com INACTIVE MAINTAINER Gerrit Renker Signed-off-by: Jakub Kicinski --- CC: Gerrit Renker CC: d...@vger.kernel.org --- CREDITS | 4 MAINTAINERS | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --

[PATCH net v2 5/7] MAINTAINERS: tls: move Aviad to CREDITS

2021-01-13 Thread Jakub Kicinski
uthor e91de6afa81c 2020-06-01 00:00:00 22 Tags e91de6afa81c 2020-06-01 00:00:00 29 Daniel Borkmann : Author c16ee04c9b30 2018-10-20 00:00:00 7 Committer b8e202d1d1d0 2020-02-21 00:00:00 19 Tags b8e202d1d1d0 2020-02-21 00:00:00 28 Jakub Kicinski : Author 5c39f26e67c9 2020-11-27 00:00:

[PATCH net v2 6/7] MAINTAINERS: ipvs: move Wensong Zhang to CREDITS

2021-01-13 Thread Jakub Kicinski
uthor 7980d2eabde8 2020-10-12 00:00:00 26 Tags 4bc3c8dc9f5f 2020-11-27 00:00:00 78 Top reviewers: [6]: horms+rene...@verge.net.au INACTIVE MAINTAINER Wensong Zhang Signed-off-by: Jakub Kicinski --- CC: Wensong Zhang CC: Simon Horman CC: Julian Anastasov --- CREDITS

Re: [PATCH net] net: stmmac: use __napi_schedule() for PREEMPT_RT

2021-01-13 Thread Jakub Kicinski
On Tue, 12 Jan 2021 15:01:22 +0100 Sebastien Laveze wrote: > From: Seb Laveze > > Use of __napi_schedule_irqoff() is not safe with PREEMPT_RT in which > hard interrupts are not disabled while running the threaded interrupt. > > Using __napi_schedule() works for both PREEMPT_RT and mainline Linux

Re: [PATCH net-next v3 06/13] selftests: Use separate stdout and stderr buffers in nettest

2021-01-13 Thread Jakub Kicinski
On Tue, 12 Jan 2021 21:00:33 -0700 David Ahern wrote: > From: David Ahern > > When a single instance of nettest is doing both client and > server modes, stdout and stderr messages can get interlaced > and become unreadable. Allocate a new set of buffers for the > child process handling server mod

Re: [pull request][net-next V2 00/11] mlx5 updates 2021-01-07

2021-01-13 Thread Jakub Kicinski
On Mon, 11 Jan 2021 23:05:23 -0800 Saeed Mahameed wrote: > From: Saeed Mahameed > > Hi Dave, Jakub > > This series provides misc updates for mlx5 driver. > v1->v2: > - Drop the +trk+new TC feature for now until we handle the module > dependency issue. > > For more information please see

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Jakub Kicinski
On Fri, 8 Jan 2021 17:45:54 +0200 Claudiu Beznea wrote: > KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special > power saving mode (backup mode) that cuts the power for almost all > parts of the SoC. The rail powering the ethernet PHY is also cut off. > When resuming, in case the PHY

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > This comes from an end-user request, where they're running multiple VMs on > hosts with bonded interfaces connected to some interest switch topologies, > where 802.3ad isn't an option. They're currently running a proprietary > solution that e

Re: [PATCH V3] drivers: net: marvell: Fixed two spellings,controling to controlling and oen to one

2021-01-13 Thread Jakub Kicinski
On Tue, 12 Jan 2021 09:26:48 -0800 Randy Dunlap wrote: > On 1/12/21 2:31 AM, Bhaskar Chowdhury wrote: > > s/oen/one/ > > s/controling/controlling/ > > > > Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap Applied, thanks.

Re: [PATCH v2] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 21:27:35 +0800 (CST) Yingjie Wang wrote: > Thanks for your reply. I commit this change on linux-next/stable > branch, and I use "git log --pretty=fixes" command to get the Fixes > tag. I want to know if I need to make a change on any other branch > and commit it? For networkin

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 13:12:12 +0100 Jiri Pirko wrote: > This patchset introduces support for modular switch systems. > NVIDIA Mellanox SN4800 is an example of such. It contains 8 slots > to accomodate line cards. Available line cards include: > 16X 100GbE (QSFP28) > 8X 200GbE (QSFP56) > 4X 400GbE (Q

Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > Resending the stragglers again. > > > This set is part of a larger effort attempting to clean-up W=1 > > kern

Re: [PATCH net-next] net: ethtool: allow MAC drivers to override ethtool get_ts_info

2021-01-13 Thread Jakub Kicinski
On Sun, 10 Jan 2021 17:35:25 +0100 Andrew Lunn wrote: > On Sun, Jan 10, 2021 at 11:13:44AM +, Russell King wrote: > > Check whether the MAC driver has implemented the get_ts_info() > > method first, and call it if present. If this method returns > > -EOPNOTSUPP, defer to the phylib or default

Re: [PATCH v4 net-next 00/10] Configuring congestion watermarks on ocelot switch using devlink-sb

2021-01-13 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:43:06 +0200 Vladimir Oltean wrote: > In some applications, it is important to create resource reservations in > the Ethernet switches, to prevent background traffic, or deliberate > attacks, from inducing denial of service into the high-priority traffic. > > These patches gi

Re: [PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-13 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:43:14 +0200 Vladimir Oltean wrote: > +struct ocelot_devlink_private { > + struct ocelot *ocelot; > +}; I don't think you ever explained to me why you don't put struct ocelot in the priv. - ocelot = devm_kzalloc(&pdev->dev, sizeof(*ocelot), GFP_KERNEL); - if

Re: [PATCH net-next 1/3] bus: mhi: core: Add helper API to return number of free TREs

2021-01-13 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote: > From: Hemant Kumar > > Introduce mhi_get_free_desc_count() API to return number > of TREs available to queue buffer. MHI clients can use this > API to know before hand if ring is full without calling queue > API. > > Signed-off-by: Hemant

Re: [PATCH v1 1/1] time64.h: Consolidated PSEC_PER_SEC definition

2021-01-13 Thread Jakub Kicinski
On Tue, 12 Jan 2021 17:37:09 +0200 Andy Shevchenko wrote: > We have currently three users of the PSEC_PER_SEC each of them defining it > individually. Instead, move it to time64.h to be available for everyone. > > There is a new user coming with the same constant in use. It will also > make its li

<    1   2   3   4   5   6   7   8   9   10   >