On 13-11-2007 19:57, Jon Nelson wrote:
I'm not sure if this is the right place,
Me too. Looks more like acpi or pci problem. Did you try to experiment
with something like: pci=noacpi or acpi=off boot parameters? Probably
some point to your .config and dmesg should be useful too, so taking
it to
Jon Nelson wrote, On 11/15/2007 09:21 PM:
...
NOTE: to avoid list noise, I can make a bug out of this on
bugzilla.kernel.org and we can proceed from there if that is
preferred.
Why avoid list noise? These lists are made just for this. But, since
this case needs a lot of space for your
Stephen Hemminger wrote, On 11/15/2007 07:20 PM:
On Thu, 15 Nov 2007 09:26:00 +0100
Jarek Poplawski [EMAIL PROTECTED] wrote:
On 15-11-2007 04:38, Stephen Hemminger wrote:
Simple mtu change when device is down.
Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382.
Signed-off-by: Stephen
On 16-11-2007 03:18, Andrew Morton wrote:
On Thu, 15 Nov 2007 18:04:19 -0800 (PST) [EMAIL PROTECTED] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=9391
Summary: Netgear GA320T(tg3) strange errors and non-workingness
Product: Drivers
Version: 2.5
Jon Nelson wrote, On 11/16/2007 03:08 PM:
...
The lspci is exactly as it was output. The dmesg is shortened only
slightly. The kernel is the latest available for openSUSE 10.3. No MSI
because this is an Athlon XP (read: 32bit, single core, regular old
33MHz, 32bit PCI).
The interrupts look
Jon Nelson wrote, On 11/17/2007 01:59 AM:
...
OK. This is what I did.
Using git I grabbed a copy of Linus' tree and using the latest files
for via-velocity.[c,h], commit
99fee6d7e5748d96884667a4628118f7fc130ea0, I determined that if I
backed out change
Bill Fink wrote, On 11/16/2007 08:26 PM:
...
Regarding the Target IP, RFC 826 says:
The target protocol address is necessary in the request form
of the packet so that a machine can determine whether or not
to enter the sender information in a table or to send a reply.
Denys Fedoryshchenko wrote, On 11/20/2007 10:43 AM:
...
If let's say i will limit bandwidth to 1Mbps, and will try to send packets
will 100Mbps speed, and will check which packets will be dropped.
As a matter of fact, I wonder why you're so afraid of this dropping. It's
usual method of
On 20-11-2007 22:21, Denys Fedoryshchenko wrote:
...
If traffic is dropped - it will be resent, a lot of energy will be wasted for
nothing. Same bytes will pass all long way around earth just because i am not
able to manage my QoS box :-)
Sure, but you'll use probably almost every bit you've
Joerg Pommnitz wrote, On 11/23/2007 03:47 PM:
Hello all,
I might make a fool out of me, but I think the prio qdisc doesn't work as
advertised in any document I could lay my hands on.
Marketing?
My problem was that the link quality reported by the olsr.org olsrd degraded
depending on
On 26-11-2007 23:25, Jarek Poplawski wrote:
...
Are you doing this on the same box? I was tracing this long time ago too,
and, if
I didn't miss something, it was about the place! So, as I recall (after
finding
some old message) this TOS is considered only for packets going through
On Tue, Nov 27, 2007 at 01:28:43AM -0800, Joerg Pommnitz wrote:
Jarek,
iptables chains (this is what I think you are referring to) are not the issue.
Yes, but this could (wrongly) look like this according to my 1-st message.
This
is about the qdisc that sits immediately over the device
On Tue, Nov 27, 2007 at 02:54:10AM -0800, Joerg Pommnitz wrote:
Jarek,
this is all about outgoing packets, e.g. egress to use your word.
It doesn't matter whether the packets are originated locally or
whether the packets are forwarded from another host (I tried
both).
To restate the
On 21-11-2007 23:13, Bernard Pidoux wrote:
...
[ INFO: inconsistent lock state ]
The error seems to reside around ax25_disconnect+0x46/0xaf [ax25] that
is called when an AX25 connect timeout or a connection failure occurs.
Connect timeout is probably activating
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
The do_setlink function is protected by rtnl, additional locks are
unnecessary,
and the set_operstate() function is called from protected parts. Locks removed
from both functions.
It doesn't look like in accordance with a comment to
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
In do_setlink() a single ntification is sent at the end of the function
if any modification occured. If the address has been changed, another
notification is sent.
...
@@ -858,6 +859,7 @@ static int do_setlink(struct net_device *dev, struct
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
...
Index: extensions/libxt_ifgroup.man
===
--- extensions/libxt_ifgroup.man (revision 0)
+++ extensions/libxt_ifgroup.man (revision 0)
@@ -0,0 +1,36 @@
+Maches
Jarek Poplawski wrote, On 12/01/2007 10:19 PM:
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
...
Index: extensions/libxt_ifgroup.man
...
+Valid only in the in the
+Valid only in the
+.B FORWARD
+and
+.B OUTPUT
+and
+.B POSTROUTING
+chains, and user-defined chains which
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link. Symbolic names can be specified in
/etc/iproute2/rt_ifgroup. Any value of unsigned int32 is valid.
...
diff --git a/lib/rt_names.c
Bernard Pidoux wrote, On 12/02/2007 06:37 PM:
Hi,
Many thanks for your patch for ~/net/ax25/ax25_subr.c
Introduction of local_bh_disable() ... local_bh_enable()
cured the inconsistent lock state related to AX25 connect timeout.
I have now a stable monoprocessor system running AX25
On 01-12-2007 21:27, Michael Buesch wrote:
On Saturday 01 December 2007 20:00:23 Arnaldo Carvalho de Melo wrote:
Em Sat, Dec 01, 2007 at 12:45:32PM -0500, John W. Linville escreveu:
On Sat, Dec 01, 2007 at 03:17:44PM -0200, Arnaldo Carvalho de Melo wrote:
Sonics Silicon Backplane support (SSB)
On 03-12-2007 12:40, Laszlo Attila Toth wrote:
Jarek Poplawski írta:
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
In do_setlink() a single ntification is sent at the end of the function
if any modification occured. If the address has been changed, another
notification is sent
Joonwoo Park wrote, On 12/04/2007 10:48 AM:
Hi,
dev_set_rx_mode calls __dev_set_rx_mode with softirq disabled (by
netif_tx_lock_bh)
therefore __dev_set_promiscuity can be called with softirq disabled.
It will cause in_interrupt() to return true and ASSERT_RTNL warning.
Is there a good
Bernard Pidoux wrote, On 12/04/2007 11:26 PM:
Jarek Poplawski wrote:
Bernard Pidoux wrote, On 12/02/2007 06:37 PM:
Hi,
Many thanks for your patch for ~/net/ax25/ax25_subr.c
Introduction of local_bh_disable() ... local_bh_enable()
cured the inconsistent lock state related to AX25 connect
On 04-12-2007 23:26, Jarek Poplawski wrote:
...
But, IMHO, blowing ASSERT_RTNL up in a few places shouldn't be much
worse. After all, how long such a debugging code should be kept. It
seems, at least sometimes we should be a bit more confident of how
it's called.
I see this won't be done
On 06-12-2007 07:31, Mitsuru Chinen wrote:
IPv4 stack doesn't reply any ICMP destination unreachable message
with net unreachable code when IP detagrams are being discarded
because of no route could be found in the forwarding path.
Incidentally, IPv6 stack replies such ICMPv6 message in the
On 06-12-2007 09:14, Mitsuru Chinen wrote:
On Thu, 6 Dec 2007 08:49:47 +0100
Jarek Poplawski [EMAIL PROTECTED] wrote:
On 06-12-2007 07:31, Mitsuru Chinen wrote:
IPv4 stack doesn't reply any ICMP destination unreachable message
with net unreachable code when IP detagrams are being discarded
On 10-12-2007 18:10, Arkadiusz Miskiewicz wrote:
Hello,
I noticed that HTB doesn't properly limit traffic if someone sends UDP
packages bigger than 1500.
Does HTB have some problems/known limits in this area?
There is other traffic in that class and when I drop udp packets bigger than
On Tue, Dec 11, 2007 at 09:17:30AM +0100, Arkadiusz Miskiewicz wrote:
On Tuesday 11 of December 2007, Jarek Poplawski wrote:
On 10-12-2007 18:10, Arkadiusz Miskiewicz wrote:
Hello,
I noticed that HTB doesn't properly limit traffic if someone sends UDP
packages bigger than 1500
On 13-12-2007 03:49, Herbert Xu wrote:
On Thu, Dec 13, 2007 at 09:58:56AM +0800, Herbert Xu wrote:
[IPSEC]: Fix reversed ICMP6 policy check
While that won't crash anymore, it's still logically wrong.
Here's a more complete fix.
...even more than this!
Since more than a year each time I
On 12-12-2007 19:41, Kok, Auke wrote:
David Miller wrote:
From: Andrew Gallatin [EMAIL PROTECTED]
Date: Wed, 12 Dec 2007 12:29:23 -0500
Is the netif_running() check even required?
No, it is not.
When a device is brought down, one of the first things
that happens is that we wait for all
On Thu, Dec 13, 2007 at 05:50:13AM -0800, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 14:49:53 +0100
As a matter of fact, since it's unlikely() in net_rx_action() anyway,
I wonder what is the main reason or gain of leaving such a tricky
exception
David Miller wrote, On 12/13/2007 02:50 PM:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 14:49:53 +0100
As a matter of fact, since it's unlikely() in net_rx_action() anyway,
I wonder what is the main reason or gain of leaving such a tricky
exception, instead of letting
Stephen Hemminger wrote, On 12/13/2007 09:41 PM:
David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 21:16:12 +0100
I see in a nearby thread you would prefer to save some work to drivers
(like this netif_running() check), but I think this all
David Miller wrote, On 12/13/2007 09:37 PM:
...
For example, if we export the list handling widget into the -poll()
routines, god help the person who wants to change how the poll list is
managed in net_rx_action() :-/
...I'm afraid I can't understand: I mean doing the same but without
passing
David Miller wrote, On 12/13/2007 11:34 PM:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 23:28:41 +0100
...I'm afraid I can't understand: I mean doing the same but without
passing this info with 'work == weight': if driver sends this info,
why it can't instead call
Eric Dumazet wrote, On 12/14/2007 12:09 PM:
...
+ /*
+ * Instead of returning hash % ht-cfg.size (implying a divide)
+ * we return the high 32 bits of the (hash * ht-cfg.size) that will
+ * give results between [0 and cfg.size-1] and same hash distribution,
+ * but
Jarek Poplawski wrote, On 12/14/2007 09:59 PM:
Eric Dumazet wrote, On 12/14/2007 12:09 PM:
...
+/*
+ * Instead of returning hash % ht-cfg.size (implying a divide)
+ * we return the high 32 bits of the (hash * ht-cfg.size) that will
+ * give results between [0 and cfg.size
On Fri, Dec 14, 2007 at 11:29:28PM +0100, Bernard Pidoux wrote:
Hi,
This patch cancels a circular locking conflict that appeared with a timeout
of an AX25 connection.
signed off by Jarek Poplawski
One spurious space less here, and maybe a few more words to the changelog.
Regards,
Jarek P
Eric Dumazet wrote, On 12/14/2007 10:37 PM:
Jarek Poplawski a écrit :
Eric Dumazet wrote, On 12/14/2007 12:09 PM:
...
+ /*
+* Instead of returning hash % ht-cfg.size (implying a divide)
+* we return the high 32 bits of the (hash * ht-cfg.size) that will
+* give results
Andrew Morton wrote, On 12/15/2007 12:13 PM:
On Fri, 14 Dec 2007 22:58:24 -0500 Miles Lane [EMAIL PROTECTED] wrote:
On Dec 14, 2007 6:36 PM, Andrew Morton [EMAIL PROTECTED] wrote:
On Fri, 14 Dec 2007 17:13:21 -0500
Miles Lane [EMAIL PROTECTED] wrote:
...
Pid: 6944, comm: cat Not tainted
Andrew Morton wrote, On 12/15/2007 12:13 PM:
On Fri, 14 Dec 2007 22:58:24 -0500 Miles Lane [EMAIL PROTECTED] wrote:
...
I applied the patch and then tried my test again. This time my system
locked up.
Perhaps I should open a new thread for this, since the problem looks
pretty different.
Andrew Morton wrote, On 12/15/2007 11:48 AM:
On Sat, 15 Dec 2007 14:10:21 +0800 Herbert Xu [EMAIL PROTECTED] wrote:
On Fri, Dec 14, 2007 at 09:44:18PM -0800, Andrew Morton wrote:
That sounds like a bug in mutex_trylock() to me.
I was relying on
On Mon, Dec 17, 2007 at 09:26:32AM +0800, Herbert Xu wrote:
On Sun, Dec 16, 2007 at 07:06:41PM +0100, Jarek Poplawski wrote:
It seemed to exist a few days ago:
http://kerneltrap.org/mailarchive/linux-netdev/2007/12/4/473123
Btw., I don't know which of the patches: Eric's or yours
On Mon, Dec 17, 2007 at 08:26:01AM +0100, Jarek Poplawski wrote:
On Mon, Dec 17, 2007 at 09:26:32AM +0800, Herbert Xu wrote:
...
I retract what I've said in this thread and continue to oppose
this change without a might_sleep.
...
So, I think using might_sleep() explicitly would be much more
On Mon, Dec 17, 2007 at 03:31:33PM +0800, Herbert Xu wrote:
On Mon, Dec 17, 2007 at 08:26:01AM +0100, Jarek Poplawski wrote:
Btw. #2: David Miller gave this example of ASSERT_RTNL use:
ASSERT_RTNL();
page = alloc_page(GFP_KERNEL);
But isn't there a debugging duplication
On Mon, Dec 17, 2007 at 11:06:04AM +0100, Bernard Pidoux F6BVP wrote:
Hi,
When I killall kissattach I can see the following message.
This happens on kernel 2.6.24-rc5 already patched with the 6 previously
patches I sent recently.
===
[
On Tue, Dec 18, 2007 at 10:12:31PM +0100, Pidoux wrote:
Hi,
Thank you Jarek for the analysis of the circular locking dependency report.
I applied the patch you proposed and it works well as soon as I am able to
reboot now without
lock warning message and I can also killall kissattach.
I
On 20-12-2007 05:29, Herbert Xu wrote:
Hi Dave:
I had wanted to fix this for ages but kept putting it off and then
forgetting about it :) So before I forget again,
[IPSEC]: Avoid undefined shift operation when testing algorithm ID
The aalgos/ealgos fields are only 32 bits wide.
On 20-12-2007 04:31, Satoru SATOH wrote:
ip route show does not print correct value when larger rto_min is
set (e.g. 3sec).
This problem is because of overflow in print_route() and
the patch below is a workaround fix for that.
...
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -510,16 +510,16
...
Subject: [PATCH] nested VLAN: fix lockdep's recursive locking warning
Allow vlans nesting other vlans without lockdep's warnings (max. 8 levels).
Reported-by: Benny Amorsen
Tested-by: Benny Amorsen(?) NEEDS TESTING!
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.24
Satoru SATOH wrote, On 12/20/2007 05:21 PM:
i see. HZ can be 1000.. i should be wrong.
however, i got the following,
[root iproute2.org]# ./ip/ip route change 192.168.140.0/24 dev eth1 rto_min 4s
[root iproute2.org]# gdb -q ./ip/ip
...
(gdb) p hz
$1 = 10
That's why I had
Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
...
but since it's your patch, I hope you do some additional checking
if it's always like this...
...or maybe only changing this all a little bit will make it look safer!
Jarek P.
--
To unsubscribe from this list: send the line unsubscribe
On 21-12-2007 03:24, Satoru SATOH wrote:
2007/12/21, Jarek Poplawski [EMAIL PROTECTED]:
Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
...
but since it's your patch, I hope you do some additional checking
if it's always like this...
...or maybe only changing this all a little bit will make
Keyur Chudgar wrote, On 12/21/2007 02:12 AM:
...
If some hardware requirements, for example is, they need to have 256
bytes aligned address for them to do the DMA, no matter what the
packet size is. In this kind of cases, can you guide me what should I
do? Is there any way already in Linux I
On Fri, Dec 28, 2007 at 01:44:17AM +0200, Denys Fedoryshchenko wrote:
...
For bandwidth sharing it is perfect, but i want just to make things, which i
did with TBF - some time bursty speed, and then slow down to lower speed if
customer is using too much. In theory it has to work like this,
Amorsen(?) STILL NEEDS TESTING!
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.24-rc6-mm1-/net/8021q/vlan.c 2.6.24-rc6-mm1+/net/8021q/vlan.c
--- 2.6.24-rc6-mm1-/net/8021q/vlan.c2007-12-23 14:55:38.0 +0100
+++ 2.6.24-rc6-mm1+/net/8021q/vlan.c2008-01-02
On 02-01-2008 17:01, Paul Moore wrote:
When sk_buffs are cloned the iif field of the new, cloned packet is neither
zeroed out or copied from the existing sk_buff. The result is that the newly
cloned sk_buff has garbage in the iif field which is a Bad Thing. This patch
fixes this problem by
On Thu, Jan 03, 2008 at 11:15:34AM -0500, Paul Moore wrote:
...
While I'm at it, is there some reason for this #define in __skb_clone()?
#define C(x) n-x = skb-x
... it seems kinda silly to me and I tend to think the code would be
better without it.
IMHO, if there are a lot of this,
On Thu, Jan 03, 2008 at 04:20:06PM -0500, Paul Moore wrote:
...
For me personally, I would argue the readability bit. Whenever I see a
function/macro call I have to go find the function/macro definition
before I can understand what it is doing. Granted, the macro is
defined local to the
On Thu, Jan 03, 2008 at 11:06:08PM +0100, Jarek Poplawski wrote:
...
I'm not macros fan in general: just yesterday I've cursed a bit at some
guy (I forgot the name...), who gave all these meaningful names to
macros in linux/pkt_cls.h. But, maybe after some time I'll start to
defend them
On 04-01-2008 11:23, Torsten Kaiser wrote:
On Jan 2, 2008 10:51 PM, Herbert Xu [EMAIL PROTECTED] wrote:
On Wed, Jan 02, 2008 at 07:29:59PM +0100, Torsten Kaiser wrote:
Vanilla 2.6.24-rc6 seems stable. I did not see any crash or warnings.
OK that's great. The next step would be to try
On Fri, Jan 04, 2008 at 04:21:26PM +0100, Torsten Kaiser wrote:
On Jan 4, 2008 2:30 PM, Jarek Poplawski [EMAIL PROTECTED] wrote:
...
I'm open for any suggestions and will try to answer any questions.
I'm very glad, thanks!
The only thing that is sadly not practical is bisecting the borkenout
On Sat, Jan 05, 2008 at 09:01:02AM +0100, Torsten Kaiser wrote:
On Jan 5, 2008 1:07 AM, Jarek Poplawski [EMAIL PROTECTED] wrote:
On Fri, Jan 04, 2008 at 04:21:26PM +0100, Torsten Kaiser wrote:
On Jan 4, 2008 2:30 PM, Jarek Poplawski [EMAIL PROTECTED] wrote:
The only thing that is sadly
On Sat, Jan 05, 2008 at 03:52:32PM +0100, Torsten Kaiser wrote:
...
So my personal conclusion would be, that someone is writing to memory
that he no longer owns. Most probably 0-bytes. (the complete_routine
got NULLed and the warning about dst-__refcnt being 0).
Use-after-free or something
On Sun, Jan 06, 2008 at 11:30:48AM +0100, Torsten Kaiser wrote:
...
I think this bug is highly timing dependent. Its not always the same
package that dies and as this is a SMP system I would guess two CPUs
using the same data will trigger this.
And using the poison-option will definitily slow
On 04-01-2008 12:40, David Miller wrote:
...
That tx_cleaned thing clouds the logic in all of these driver's
poll routines.
The one necessary precondition is that when work_done budget
we exit polling and return a value less than budget.
If the -poll() returns a value less than budget,
Costa Tsaousis wrote, On 12/27/2007 10:00 AM:
Merry Christams,
I would like to report incompatibilities of the sunhme driver with x86 SMP.
Hi Costa,
It seems your report has to wait for better times... I'm not driver's
expert, but maybe you could try some of these:
- since 'the list'
On 08-01-2008 06:59, Al Viro wrote:
On Mon, Jan 07, 2008 at 07:26:12PM -0800, Linus Torvalds wrote:
I usually just compile a small program like
const char array[]=\xnn\xnn\xnn...;
int main(int argc, char **argv)
{
printf(%p\n, array);
*(int
On 08-01-2008 08:53, Eric Dumazet wrote:
David Miller a écrit :
...
Furthermore, these:
rcu_read_unlock_bh()
rcu_read_lock_bh()
sequences are at best funny looking. For other lock types we would
look at this and ask Does this even accomplish anything reliably?
Well, original
On Wed, Jan 09, 2008 at 08:57:53AM +0900, FUJITA Tomonori wrote:
...
diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c
new file mode 100644
index 000..495575a
--- /dev/null
+++ b/lib/iommu-helper.c
@@ -0,0 +1,80 @@
+/*
+ * IOMMU helper functions for the free area management
+ */
+
On Thu, Jan 10, 2008 at 04:31:22PM +0100, Patrick McHardy wrote:
...
No, this seems fine, thanks. Even better would be a way to get
the last lockdep subclass through lockdep somehow, but I couldn't
find a clean way for this. So I've applied your patch and also
fixed macvlan.
As a matter of
On Thu, Jan 10, 2008 at 10:08:16PM +0100, Jarek Poplawski wrote:
...
But still some 'quirks' are possible there: removing and adding
devices 'properly' would often require resetting of many subclasses,
...Hmm, probably they are always removed from/with the children, then no
problem! (I know, I
Eric Dumazet wrote, On 01/09/2008 11:37 AM:
...
[NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache
...
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index d337706..28484f3 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -283,12 +283,12 @@ static struct rtable
On Fri, Jan 11, 2008 at 11:00:20AM +1100, Herbert Xu wrote:
On Fri, Jan 11, 2008 at 12:10:42AM +0100, Jarek Poplawski wrote:
It seems this optimization could've a side effect: if during such a
loop updates are done, and r is seen !NULL during while() check, but
NULL after rcu_dereference
On Fri, Jan 11, 2008 at 09:30:10AM +0100, Jarek Poplawski wrote:
On Fri, Jan 11, 2008 at 11:00:20AM +1100, Herbert Xu wrote:
On Fri, Jan 11, 2008 at 12:10:42AM +0100, Jarek Poplawski wrote:
It seems this optimization could've a side effect: if during such a
loop updates are done, and r
On Fri, Jan 11, 2008 at 10:11:40AM +0100, Jarek Poplawski wrote:
...
So, IOW: strictly speaking you are right, r can't change here, but I
meant r vs. the returned value! Before the patch the returned value
couldn't be NULL unless all elements of the list were looped. After
...even more
On Fri, Jan 11, 2008 at 09:38:52PM +1100, Herbert Xu wrote:
On Fri, Jan 11, 2008 at 10:11:40AM +0100, Jarek Poplawski wrote:
So, IOW: strictly speaking you are right, r can't change here, but I
meant r vs. the returned value! Before the patch the returned value
couldn't be NULL unless
On Thu, Jan 10, 2008 at 09:22:42PM -0800, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Sun, 30 Dec 2007 15:13:23 +0100
On Sat, Dec 29, 2007 at 07:14:43PM -0800, David Miller wrote:
...
I've removed the warning and made the branch back to 'again'
unconditional as I
On Fri, Jan 11, 2008 at 09:37:42PM +1100, Herbert Xu wrote:
On Fri, Jan 11, 2008 at 09:30:10AM +0100, Jarek Poplawski wrote:
It looks like I'm really too lazy and/or these selfdocumenting features
of RCU are a bit overrated: one can never be sure which pointer is
really RCU protected
On Thu, Jan 10, 2008 at 03:51:11PM -0800, Paul E. McKenney wrote:
On Fri, Jan 11, 2008 at 12:10:42AM +0100, Jarek Poplawski wrote:
Eric Dumazet wrote, On 01/09/2008 11:37 AM:
...
[NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache
...
diff --git a/net/ipv4/route.c b/net/ipv4
On 14-01-2008 16:58, Chris Friesen wrote:
...
How close to bleeding edge do we need to be for it to be considered
acceptable to ask questions on netdev?
Given that the embedded space tends to be perpetually stuck on older
kernels (our current release is based on 2.6.14) do you have any
On 15-01-2008 07:36, Makito SHIOKAWA wrote:
Change code not to rearm bond_mii_monitor() when value 0 is set for miimon.
Signed-off-by: Makito SHIOKAWA [EMAIL PROTECTED]
---
drivers/net/bonding/bond_main.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
---
On 15-01-2008 07:36, Makito SHIOKAWA wrote:
...
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -643,10 +643,8 @@ static ssize_t bonding_store_arp_interva
%s Disabling MII monitoring.\n,
bond-dev-name, bond-dev-name);
On Tue, Jan 15, 2008 at 08:47:07AM -0600, Chris Friesen wrote:
Jarek Poplawski wrote:
IMHO, checking this with a current stable, which probably you are going
to do some day, anyway, should be 100% acceptable: giving some input to
netdev, while still working for yourself.
While I would love
Patrick McHardy wrote, On 01/15/2008 05:05 PM:
Badalian Vyacheslav wrote:
...
Yes, packets in the old qdisc are lost.
Maybe if tc do changes - need create second queue (hash of rules or how
you named it?) and do changes at it. Then replace old queue rules by
created new.
Logic -
1.
On Wed, Jan 16, 2008 at 12:46:02AM +0300, [EMAIL PROTECTED] wrote:
...
Hmmm... i found way to fix this for me... but its not look good
Scheme look like:
Root - prio bands 3 priomap 0 0 0 0
--- Class 1
--- Class 2
Copy of all table (Last this qdisc be root)
--- Class 3
On Wed, Jan 16, 2008 at 01:04:59AM +0300, [EMAIL PROTECTED] wrote:
Good night! =)
Good morning! ;)
Sorry... i was wrong...
I see that problem more serious
Lets see to scheme
Class 1
---qdisc
--- 10k classes
Class 2
---qdisc
--- 10k classes
All traffic go to class 2...
On Wed, Jan 16, 2008 at 11:17:08AM +1100, Herbert Xu wrote:
...
Well people are always going to operate on this model for commercial
reasons. FWIW I used to work for a company that stuck to a specific
version of the Linux kernel, and I suppose I still do even now :)
But the important thing
On Wed, Jan 16, 2008 at 06:02:00AM +0100, Patrick McHardy wrote:
...
This would need support from the qdiscs to do it properly. Looks
non-trivial for HTB/HFSC/CBQ, but the others shouldn't be that hard.
Yes. At first I've thought this would need quite a lot of work, but
it seems, there could be
On Wed, Jan 16, 2008 at 09:05:47AM +0100, Patrick McHardy wrote:
...
Yes, thats one possibility (without the dummy device though please).
But I wonder what this would actually be useful for. I don't think
replacing the root qdisc by a different type is a common scenario,
for the same type you
On Wed, Jan 16, 2008 at 11:35:35AM +0300, Badalian Vyacheslav wrote:
...
I simple recreate all rules. I change idea from do many add,change,delete
because have many kernel panics on many kernels 2.6.x
First i have panics on delete filter operation... was fix it... great..
then have panics on
On 15-01-2008 07:36, Makito SHIOKAWA wrote:
Fix some RTNL lock taking:
* RTNL (mutex; may sleep) must not be taken under read_lock (spinlock; must be
atomic). However, RTNL is taken under read_lock in bond_loadbalance_arp_mon()
and bond_activebackup_arp_mon(). So change code to take RTNL
On Wed, Jan 16, 2008 at 12:19:51PM +0900, Makito SHIOKAWA wrote:
This patch is supposing a case that bond_mii_monitor() is invoked in
bond_open(), and after that, 0 is set to miimon via sysfs (see same place
on other monitors).
Though message in bonding_store_miimon() says miimon value
On Wed, Jan 16, 2008 at 09:04:58PM +0100, Willy Tarreau wrote:
...
you can work with latest release provided that you always have a fallback
to an earlier one. That way, you don't bet too much on something you don't
completely control. If it works, it tells you you'll be able to completely
On Thu, Jan 17, 2008 at 02:30:36PM +0900, Makito SHIOKAWA wrote:
But, since during this change from sysfs cancel_delayed_work_sync()
could be probably used, and it's rather efficient with killing
rearming works, it seems this check could be unnecessary yet.
What going to be cancelled in
On Thu, Jan 17, 2008 at 02:30:37PM +0900, Makito SHIOKAWA wrote:
Maybe I'm wrong, but since this read_lock() is given and taken anyway,
it seems this looks a bit better to me (why hold this rtnl longer
than needed?):
read_unlock(bond-lock);
rtnl_unlock();
Jarek Poplawski wrote, On 01/18/2008 11:27 PM:
Makito SHIOKAWA wrote, On 01/18/2008 02:43 PM:
...
@@ -1026,7 +1028,7 @@ static ssize_t bonding_store_miimon(stru
cancel_delayed_work_sync(bond-lb_arp_work);
}
-if (bond-dev-flags IFF_UP
Makito SHIOKAWA wrote, On 01/18/2008 02:43 PM:
Hmm... I'm not sure I understand your point, but it seems both
bonding_store_arp_interval() and bonding_store_miimon() where this
field could be changed, currently use cancel_delayed_work() with
flush_workqueue(), so I presume, there is no
Andrew Morton wrote, On 01/18/2008 08:48 AM:
On Thu, 17 Jan 2008 23:33:54 -0800 (PST) [EMAIL PROTECTED] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=9773
Summary: pptp/ppp connection die at high speed on Athlon X2 6000+
Product: Networking
Version:
401 - 500 of 612 matches
Mail list logo
