...@cumulusnetworks.com
CC: netdev@vger.kernel.org (open list:BONDING DRIVER)
Signed-off-by: Jarod Wilson ja...@redhat.com
---
drivers/net/bonding/bond_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 19eb990..2aa5b5f
() after its unregister_netdevice()
call. Now I can load and unload no problem.
CC: Solarflare linux maintainers linux-net-driv...@solarflare.com
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson ja...@redhat.com
---
drivers/net/ethernet/sfc/efx.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 6/15/2015 9:49 AM, Edward Cree wrote:
On 12/06/15 19:51, Jarod Wilson wrote:
Without this change, modprobe -r sfc hits the BUG_ON() in
efx_pci_remove_main(). Best as I can tell, this was just an oversight,
efx-state gets set to STATE_UNINIT in the error path of
efx_register_netdev() just
On 2015-08-17 12:55 PM, Veaceslav Falico wrote:
On Mon, Aug 17, 2015 at 12:23:03PM -0400, Jarod Wilson wrote:
From: Uwe Koziolek uwe.kozio...@redknee.com
With some very finicky switch hardware, active backup bonding can get
into
a situation where we play ping-pong between interfaces, trying
On 2015-08-14 7:41 PM, Jarod Wilson wrote:
On 2015-08-14 2:56 AM, Michal Kubecek wrote:
On Thu, Aug 13, 2015 at 02:02:55PM -0400, Jarod Wilson wrote:
Currently, all bonding devices come up, and claim to have LRO support,
which ethtool will let you toggle on and off, even if none
Signed-off-by: Uwe Koziolek uwe.kozio...@redknee.com
Signed-off-by: Jarod Wilson ja...@redhat.com
---
drivers/net/bonding/bond_main.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 0c627b4..60b9483 100644
--- a/drivers
in a bond will not trigger
LRO support to be enabled at the bond level, even while it is enabled on
the slave itself.
This change becomes necessary when NETIF_F_LRO is added to
netdev_features.h's NETIF_F_ONE_FOR_ALL.
CC: Jon Mason jdma...@kudzu.us
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson
...@qlogic.com
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson ja...@redhat.com
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
b/drivers/net/ethernet/broadcom/bnx2x
...@qlogic.com
CC: dept-gelinuxnic...@qlogic.com
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson ja...@redhat.com
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
b
...@qlogic.com
CC: Sony Chacko sony.cha...@qlogic.com
CC: Rajesh Borundia rajesh.borun...@qlogic.com
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson ja...@redhat.com
---
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
...@intel.com
CC: intel-wired-...@lists.osuosl.org
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson ja...@redhat.com
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
b/drivers
was generated against net-next master, it applies to 4.2.0-rc6 with
a bit of fuzz.
Jarod Wilson (6):
net/bonding: enable LRO if one device supports it
ethernet/bnx2x: advertise LRO support in vlan_features
ethernet/ixgbe: advertise LRO support in vlan_features
ethernet/netxen: advertise LRO support
therb...@google.com
CC: Scott Feldman sfel...@gmail.com
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson ja...@redhat.com
---
include/linux/netdev_features.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
On 2015-08-14 2:56 AM, Michal Kubecek wrote:
On Thu, Aug 13, 2015 at 02:02:55PM -0400, Jarod Wilson wrote:
Currently, all bonding devices come up, and claim to have LRO support,
which ethtool will let you toggle on and off, even if none of the
underlying hardware devices actually support
google.com>
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <go...@cumulusnetworks.com>
CC: Jiri Pirko <j...@resnulli.us>
CC: Nikolay Aleksandrov <ra...@blackwall.org>
CC: Michal Kubecek <mkube...@suse.cz>
ichal Kubecek <mkube...@suse.cz>
CC: Alexander Duyck <alexander.du...@gmail.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
Note: this replaces "[RFC PATCH net-next] net/core: initial support for
stacked dev feature toggles" for
Alexander Duyck wrote:
On 10/30/2015 09:25 AM, Jarod Wilson wrote:
...
Rather than outright dropping the second bit though, I was thinking
maybe just drop a note in dmesg along the lines of "hey, you shut off
LRO, it is still enabled on upper dev foo", to placate end-users.
I wo
works.com>
CC: Jiri Pirko <j...@resnulli.us>
CC: Nikolay Aleksandrov <ra...@blackwall.org>
CC: Michal Kubecek <mkube...@suse.cz>
CC: Alexander Duyck <alexander.du...@gmail.com>
CC: Geert Uytterhoeven <ge...@linux-m68k.org>
CC: netdev@vger.kernel.org
Signed-
Michal Kubecek wrote:
On Tue, Nov 03, 2015 at 03:36:57PM -0500, Jarod Wilson wrote:
With moving netdev_sync_lower_features() after the .ndo_set_features
calls, I neglected to verify that devices added *after* a flag had been
disabled on an upper device were properly added with that flag
Alexander Duyck wrote:
On 11/03/2015 12:36 PM, Jarod Wilson wrote:
With moving netdev_sync_lower_features() after the .ndo_set_features
calls, I neglected to verify that devices added *after* a flag had been
disabled on an upper device were properly added with that flag
disabled as
well
Gospodarek <go...@cumulusnetworks.com>
CC: Jiri Pirko <j...@resnulli.us>
CC: Nikolay Aleksandrov <ra...@blackwall.org>
CC: Michal Kubecek <mkube...@suse.cz>
CC: Alexander Duyck <alexander.du...@gmail.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja..
kwall.org>
CC: Michal Kubecek <mkube...@suse.cz>
CC: Alexander Duyck <alexander.du...@gmail.com>
CC: netdev@vger.kernel.org
Reported-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
v2: Based on suggestions from Alex
Alexander Duyck wrote:
On 11/02/2015 09:53 AM, Jarod Wilson wrote:
There are some netdev features, which when disabled on an upper device,
such as a bonding master or a bridge, must be disabled and cannot be
re-enabled on underlying devices.
This is a rework of an earlier more heavy-handed
Michal Kubecek wrote:
On Fri, Oct 23, 2015 at 10:51:09PM -0700, Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
+static netdev_features_t netdev_sync_upper_features(struct net_device *lower,
+ struct net_device *upper, netdev_features_t features
Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
There are some netdev features that make little sense to toggle on and
off in a stacked device setup on only one device in the stack. The prime
example is a bonded connection, where it really doesn't make sense to
disable LRO
n-update, so look at both.
CC: dept-gelinuxnic...@qlogic.com
CC: netdev@vger.kernel.org
CC: Manish Chopra <manish.cho...@qlogic.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(
Jarod Wilson wrote:
The bonding driver saves a copy of slaves' original mac address and then
assigns whatever mac as needed to the slave, depending on mode. In at
least modes 5 and 6 (balance-tlb, balance-alb), it often ends up being the
mac address of another slave. On release from the bond
Nikolay Aleksandrov wrote:
On 11/03/2015 02:57 PM, Jarod Wilson wrote:
Geert Uytterhoeven wrote:
On Tue, Nov 3, 2015 at 11:03 AM, Nikolay Aleksandrov
<niko...@cumulusnetworks.com> wrote:
On 11/03/2015 03:55 AM, Jarod Wilson wrote:
[snip]
+#define for_each_netdev_feature(mask_addr, f
ichal Kubecek <mkube...@suse.cz>
CC: Alexander Duyck <alexander.du...@gmail.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
v2: Move manipulation of lower devices after ndo_set_features so the upper
device gets fully set up first and remove now r
Geert Uytterhoeven wrote:
On Tue, Nov 3, 2015 at 11:03 AM, Nikolay Aleksandrov
<niko...@cumulusnetworks.com> wrote:
On 11/03/2015 03:55 AM, Jarod Wilson wrote:
[snip]
+#define for_each_netdev_feature(mask_addr, feature) \
+ i
: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
CC: Alexander Duyck <alexander.du...@gmail.com>
CC: intel-wired-...@lists.osuosl.org
CC: netdev@vger.kernel.org
Acked-by: Alexander Duyck <adu...@mirantis.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
Note: this patch is re
Jay Vosburgh wrote:
Jarod Wilson<ja...@redhat.com> wrote:
Jarod Wilson wrote:
...
As Andy already stated I'm not a fan of such workarounds either but it's
necessary sometimes so if this is going to be actually considered then a
few things need to be fixed. Please make this a proper b
@gmail.com>
CC: intel-wired-...@lists.osuosl.org
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
note: this patch is dependent on the previously submitted "igb: don't unmap
hw_addr
if its NULL", which added io_addr.
v3: don't modify igb_rd32, just pass reg
Nikolay Aleksandrov wrote:
On 10/06/2015 09:53 PM, Jarod Wilson wrote:
From: Uwe Koziolek<uwe.kozio...@redknee.com>
With some very finicky switch hardware, active backup bonding can get into
a situation where we play ping-pong between interfaces, trying to get one
to come up as the
eslav Falico <vfal...@gmail.com>
CC: netdev@vger.kernel.org
Signed-off-by: Uwe Koziolek <uwe.kozio...@redknee.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
v2: add code comment as to why change is needed
v3: fix wrapping of comments
v4: [jarod] add module parameter g
Jarod Wilson wrote:
From: Uwe Koziolek<uwe.kozio...@redknee.com>
With some very finicky switch hardware, active backup bonding can get into
a situation where we play ping-pong between interfaces, trying to get one
to come up as the active slave. There seems to be an issue with the
switch
Alexander Duyck wrote:
On 09/21/2015 09:14 PM, Jarod Wilson wrote:
Alexander Duyck wrote:
On 09/21/2015 10:11 AM, Jarod Wilson wrote:
Some pci changes upcoming in 4.3 seem to cause additional disconnects,
which can happen at unfortuitous times for igb, leading to issues
such as
this, where
er <jeffrey.t.kirs...@intel.com>
CC: Alexand Duyck <alexander.du...@gmail.com>
CC: intel-wired-...@lists.osuosl.org
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/intel/igb/e1000_regs.h | 7 +++
drivers/net/
Jarod Wilson wrote:
...
As Andy already stated I'm not a fan of such workarounds either but it's
necessary sometimes so if this is going to be actually considered then a
few things need to be fixed. Please make this a proper bonding option
which can be changed at runtime and not only via
st set the
new features, but now we return an error and don't set them. Fix this by
returning the old behaviour and setting err to 0 when ndo_set_features
is not present.
Fixes: e7868a85e1b2 ("net/core: ensure features get disabled on new lower devs")
CC: Jarod Wilson<ja...@redhat.co
On 2015-08-17 4:51 PM, Uwe Koziolek wrote:
On Mon, Aug 17, 2015 at 09:14PM +0200, Jay Vosburgh wrote:
Uwe Koziolek <uwe.kozio...@redknee.com> wrote:
On2015-08-17 07:12 PM,Jarod Wilson wrote:
...
Uwe, can you perhaps further enlighten us as to what num_grat_arp
settings were
Rustad, Mark D wrote:
On Sep 9, 2015, at 9:07 PM, Jarod Wilson<ja...@redhat.com> wrote:
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/drivers/net/ethernet/intel/igb/igb_main.c
index e174fbb..a5e0022 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/et
ark.d.rus...@intel.com>
CC: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
CC: intel-wired-...@lists.osuosl.org
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/intel/igb/igb.h | 2 ++
drivers/net/ethernet/intel/igb/igb_main.
go well. Simple solution here is to simply make sure
hw_addr is not NULL before we try to call pci_iounmap on it, and now I can
hot-unplug this thunderbolt dock without a problem.
CC: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
CC: intel-wired-...@lists.osuosl.org
CC: netdev@vger.kernel.or
ndy seemed okay with
it, provided there was a comment explaining. Just looking at what might
have to be done next here to keep heading towards a resolution.
Thanks much,
--
Jarod Wilson
ja...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the bo
Alexander Duyck wrote:
On 09/21/2015 10:11 AM, Jarod Wilson wrote:
Some pci changes upcoming in 4.3 seem to cause additional disconnects,
which can happen at unfortuitous times for igb, leading to issues such as
this, where the disconnect happened just before igb_configure_tx_ring
<mark.d.rus...@intel.com>
CC: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
CC: intel-wired-...@lists.osuosl.org
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
Note: this is a follow-up patch in addition to the previously submitted
"igb: don'
Don't open-code it.
CC: Solarflare linux maintainers <linux-net-driv...@solarflare.com>
CC: Shradha Shah <ss...@solarflare.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/sfc/net_driver.h | 3 ++-
1 file changed, 2 inserti
://bugzilla.kernel.org/show_bug.cgi?id=70761
CC: "Eugene A. Shatokhin" <eugene.shatok...@rosalab.ru>
CC: Przemek Rudy <pru...@o2.pl>
CC: Jay Cliburn <jclib...@gmail.com>
CC: Chris Snook <chris.sn...@gmail.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@r
ris.sn...@gmail.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/atheros/alx/hw.c | 10 +-
drivers/net/ethernet/atheros/alx/hw.h | 9 ++---
drivers/net/ethernet/atheros/alx/main.c | 7 +++
3 files changed, 14 insertions(+), 1
es attached to the bug,
so I'm working on touching up the descriptions and formatting, regression
testing them on my laptop that has an alx-driven E2200 in it (which isn't
affected by this bug), and then I can ship them up for proper review.
--
Jarod Wilson
ja...@redhat.com
--
To unsubscribe from
Reasonably sure this doesn't serve any purpose.
CC: Jay Cliburn <jclib...@gmail.com>
CC: Chris Snook <chris.sn...@gmail.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/atheros/alx/main.c | 1 -
1 file changed, 1 delet
: Solarflare linux maintainers <linux-net-driv...@solarflare.com>
CC: Edward Cree <ec...@solarflare.com>
CC: Bert Kenward <bkenw...@solarflare.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/sfc/mcdi_port.c | 4
1 fi
On Tue, Jun 07, 2016 at 05:20:16PM -0400, Jarod Wilson wrote:
> On Mon, Jun 06, 2016 at 02:55:29PM -0400, Jarod Wilson wrote:
> > On Mon, Jun 06, 2016 at 05:29:30PM +0100, Bert Kenward wrote:
> > > 7000-series SFC NICs connected with an SFP+ module currently fail to
> > >
On Mon, Jun 06, 2016 at 02:55:29PM -0400, Jarod Wilson wrote:
> On Mon, Jun 06, 2016 at 05:29:30PM +0100, Bert Kenward wrote:
> > 7000-series SFC NICs connected with an SFP+ module currently fail to
> > report any supported link speeds.
> >
> > Reported-by: Jar
On Mon, Jun 06, 2016 at 05:29:30PM +0100, Bert Kenward wrote:
> 7000-series SFC NICs connected with an SFP+ module currently fail to
> report any supported link speeds.
>
> Reported-by: Jarod Wilson <ja...@redhat.com>
> Signed-off-by: Bert Kenward <bkenw...@solarflare.co
On Thu, Jun 09, 2016 at 02:02:04PM -0400, Jarod Wilson wrote:
> On Wed, Jun 01, 2016 at 03:31:46PM -0700, Alexander Duyck wrote:
> > On Wed, Jun 1, 2016 at 12:27 PM, Jarod Wilson <ja...@redhat.com> wrote:
> > > On Wed, Jun 01, 2016 at 07:31:53AM -0700, Alexander Duyck wrot
On Thu, Jun 09, 2016 at 04:55:01PM -0400, Jarod Wilson wrote:
> On Thu, Jun 09, 2016 at 02:02:04PM -0400, Jarod Wilson wrote:
> > On Wed, Jun 01, 2016 at 03:31:46PM -0700, Alexander Duyck wrote:
> > > On Wed, Jun 1, 2016 at 12:27 PM, Jarod Wilson <ja...@redhat.com> wrote
/avg/max/mdev = 0.327/0.381/0.424/0.043 ms
Also slipped a related-ish fix to the kerneldoc text for
e1000e_vlan_strip_disable here...
CC: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
CC: intel-wired-...@lists.osuosl.org
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@r
On Thu, Jun 09, 2016 at 06:17:45PM -0400, Jarod Wilson wrote:
> On Thu, Jun 09, 2016 at 04:55:01PM -0400, Jarod Wilson wrote:
> > On Thu, Jun 09, 2016 at 02:02:04PM -0400, Jarod Wilson wrote:
> > > On Wed, Jun 01, 2016 at 03:31:46PM -0700, Alexander Duyck wrote:
> > >
On Wed, Jun 01, 2016 at 03:31:46PM -0700, Alexander Duyck wrote:
> On Wed, Jun 1, 2016 at 12:27 PM, Jarod Wilson <ja...@redhat.com> wrote:
> > On Wed, Jun 01, 2016 at 07:31:53AM -0700, Alexander Duyck wrote:
> >> On Tue, May 17, 2016 at 12:03 PM, Jarod Wilson <ja...@red
On Wed, Jun 01, 2016 at 07:31:53AM -0700, Alexander Duyck wrote:
> On Tue, May 17, 2016 at 12:03 PM, Jarod Wilson <ja...@redhat.com> wrote:
> > I've got a bug report about an e1000e interface, where a vlan interface is
> > set up on top of it:
> >
> > $ ip link ad
ning latest net-next, and old iproute2 is just fine.
...I haven't run into anything that didn't work with current iproute2
either while testing out functionality of these patches. If there's
something in particular that seems most suspect that I perhaps simply
haven't tried, I can give that a go as well
lease paths, I don't see anything preventing concurrent slave adds and
removes, which could mean there are situations where those checks really
are necessary. I don't actually know.
--
Jarod Wilson
ja...@redhat.com
On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote:
> Replace 'goto' with 'return' to remove unnecessary check at label:
> err_undo_flags.
I think you're going to have to explain how you came to the conclusion
that the check isn't necessary.
--
Jarod Wilson
ja...@redhat.com
TA(tb[IFLA_STATS64]),
+ MIN(RTA_PAYLOAD(tb[IFLA_STATS64]), sizeof(stats)));
+
+ print_link_stats64(fp, , carrier_changes, slen);
+ } else if (tb[IFLA_STATS]) {
+ struct rtnl_link_stats stats = { 0 };
+ slen = RTA_PAYLOAD(tb[IFLA_S
On Tue, Feb 09, 2016 at 08:52:38PM -0800, Eric Dumazet wrote:
> On Tue, 2016-02-09 at 17:41 -0800, Stephen Hemminger wrote:
> > On Tue, 9 Feb 2016 18:51:35 -0500
> > Jarod Wilson <ja...@redhat.com> wrote:
> >
> > > On Tue, Feb 09, 2016 at 11:17:57AM -0800, Step
Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <go...@cumulusnetworks.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/bonding/bond_main.c | 1 +
1 file changed, 1 insertion(+)
and resubmitted for net-next after 4.5 is put to
bed, but I do have users who consider this an important bugfix.
Jarod Wilson (4):
net/core: relax BUILD_BUG_ON in netdev_stats_to_stats64
net: add rx_nohandler stat counter
team: track sum of rx_nohandler for all slaves
bond: track sum
CC: Jiri Pirko <j...@resnulli.us>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/team/team.c | 10 +++---
include/linux/if_team.h | 1 +
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/team/team.c b/drivers/net
t;dan...@iogearbox.net>
CC: Tom Herbert <t...@herbertland.com>
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <go...@cumulusnetworks.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com&g
On Wed, Jan 27, 2016 at 01:09:47PM -0800, Eric Dumazet wrote:
> On Wed, 2016-01-27 at 15:21 -0500, Jarod Wilson wrote:
>
> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index 289c231..7973ab5 100644
> > --- a/include/linux/netdevice.h
> > +
On Thu, Jan 28, 2016 at 01:02:15AM -0500, Jarod Wilson wrote:
> On Wed, Jan 27, 2016 at 01:09:47PM -0800, Eric Dumazet wrote:
> > On Wed, 2016-01-27 at 15:21 -0500, Jarod Wilson wrote:
> >
> > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > &
On Thu, Jan 28, 2016 at 01:02:15AM -0500, Jarod Wilson wrote:
> On Wed, Jan 27, 2016 at 01:09:47PM -0800, Eric Dumazet wrote:
> > On Wed, 2016-01-27 at 15:21 -0500, Jarod Wilson wrote:
> >
> > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > &
On Mon, Jan 25, 2016 at 09:27:20AM -0500, Jarod Wilson wrote:
> On Sun, Jan 24, 2016 at 10:42:22PM -0800, David Miller wrote:
> > From: Jarod Wilson <ja...@redhat.com>
> > Date: Fri, 22 Jan 2016 14:11:22 -0500
> >
> > > diff --git a/net/core/dev.c b/net/cor
Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <go...@cumulusnetworks.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/bonding/bond_main.c | 1 +
1 file changed, 1 insertion(+)
require that rtnl_link_stats64 is larger, and
zero out all the stat counters that aren't present in net_device_stats.
CC: Eric Dumazet <eduma...@google.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
net/core/dev.c | 19 +--
1 file
and resubmitted for net-next after 4.5 is put to
bed, but I do have users who consider this an important bugfix.
This has been tested quite a bit on x86_64, and now lightly on i686 as
well, to verify functionality of updates to netdev_stats_to_stats64()
on 32-bit arches.
Jarod Wilson (4):
net/core
t;dan...@iogearbox.net>
CC: Tom Herbert <t...@herbertland.com>
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <go...@cumulusnetworks.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com&g
CC: Jiri Pirko <j...@resnulli.us>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/team/team.c | 10 +++---
include/linux/if_team.h | 1 +
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/team/team.c b/drivers/net
On Sat, Jan 30, 2016 at 03:26:35PM -0800, David Miller wrote:
> From: Jarod Wilson <ja...@redhat.com>
> Date: Sat, 30 Jan 2016 15:53:05 -0500
>
> > On Sat, Jan 30, 2016 at 03:39:01PM -0500, Jarod Wilson wrote:
> >> Ew, no, it won't work correctly on 32-bit. The for l
On Sat, Jan 30, 2016 at 10:34:32AM -0800, Eric Dumazet wrote:
> On Sat, 2016-01-30 at 13:19 -0500, Jarod Wilson wrote:
> > The netdev_stats_to_stats64 function copies the deprecated
> > net_device_stats format stats into rtnl_link_stats64 for legacy support
> > purposes, but
On Sat, Jan 30, 2016 at 03:39:01PM -0500, Jarod Wilson wrote:
> On Sat, Jan 30, 2016 at 10:34:32AM -0800, Eric Dumazet wrote:
> > On Sat, 2016-01-30 at 13:19 -0500, Jarod Wilson wrote:
> > > The netdev_stats_to_stats64 function copies the deprecated
> > > ne
On Fri, Jan 29, 2016 at 07:37:51PM -0800, David Miller wrote:
> From: Jarod Wilson <ja...@redhat.com>
> Date: Thu, 28 Jan 2016 10:49:44 -0500
>
> > The network core tries to keep track of dropped packets, but some packets
> > you wouldn't really call dropped, so mu
require that rtnl_link_stats64 is larger, and
zero out all the stat counters that aren't present in net_device_stats.
CC: Eric Dumazet <eduma...@google.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
Re-re-sending, hopefully getting the patch to th
.@gmail.com>
> Cc: Andy Gospodarek <go...@cumulusnetworks.com>
> Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com>
>
> ---
> v2: more detail in log and comment; no code change.
This sounds suspiciously like the same problem Uwe was encountering[*] and
attempting to solve. Uwe, can you give this patch a try?
[*] = http://marc.info/?l=linux-netdev=144416122705850=2
--
Jarod Wilson
ja...@redhat.com
0
$ cat /sys/devices/virtual/net/bond0/statistics/rx_unhandled
33181
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <go...@cumulusnetworks.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.
@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
net/core/net-procfs.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/net/core/net-procfs.c b/net/core/net-procfs.c
index 2bf8329..9f88f34 100644
--- a/net/core/net-procfs.c
+++ b/net/core/net-pr
a...@google.com>
CC: Jiri Pirko <j...@mellanox.com>
CC: Daniel Borkmann <dan...@iogearbox.net>
CC: Tom Herbert <t...@herbertland.com>
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <go...@cumulusnetworks.com>
t;dan...@iogearbox.net>
CC: Tom Herbert <t...@herbertland.com>
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <go...@cumulusnetworks.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
CC: Jiri Pirko <j...@resnulli.us>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/team/team.c | 10 +++---
include/linux/if_team.h | 1 +
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/team/team.c b/drivers/net
On Thu, Jan 28, 2016 at 05:00:02AM -0800, Eric Dumazet wrote:
> On Thu, 2016-01-28 at 01:18 -0500, Jarod Wilson wrote:
>
> > Or not. Now I remember why I added that in the first place:
> >
> > In file included from ./arch/x86/include/asm/uaccess.h:7:0,
> >
ize moments later. Just needs some documentation updates,
which I've done locally. Will rebuild, re-test, then hopefully get an
updated patchset out the door.
--
Jarod Wilson
ja...@redhat.com
SYMBOL_GPL(devlink_alloc);
> >
> >The increment then decrement bit feels... Clunky and a little confusing.
> >Why not just atomic_read(_counter) before different_name:, then an
> >atomic_inc_return(_counter) under the if clause before the goto, and
> >eliminate the devlink->index-- bit?
>
> If I split it it would not be atomic op anymore. But the
> devlink->index-- is just to adjust the start, nothing else.
> This is copied from nl80211 code.
Argh, I'm a moron. You need to increment dev_counter, can't just read it's
current value. Still fugly, but okay, does actually serve a purpose this
way.
--
Jarod Wilson
ja...@redhat.com
gt; +}
> +EXPORT_SYMBOL_GPL(devlink_alloc);
The increment then decrement bit feels... Clunky and a little confusing.
Why not just atomic_read(_counter) before different_name:, then an
atomic_inc_return(_counter) under the if clause before the goto, and
eliminate the devlink->index-- bit?
--
Jarod Wilson
ja...@redhat.com
dy Gospodarek <go...@cumulusnetworks.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
net/core/dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 8cba3d8..1354c7b 100644
--- a/net/core/dev.c
+++ b/
On Sun, Jan 24, 2016 at 10:42:22PM -0800, David Miller wrote:
> From: Jarod Wilson <ja...@redhat.com>
> Date: Fri, 22 Jan 2016 14:11:22 -0500
>
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index 8cba3d8..1354c7b 100644
> > --- a/net/core/dev.c
> &
On Sat, Jan 23, 2016 at 07:23:09AM -0800, Eric Dumazet wrote:
> On Fri, 2016-01-22 at 14:11 -0500, Jarod Wilson wrote:
>
> > ---
> > net/core/dev.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > i
On Tue, Jan 26, 2016 at 01:24:59PM -0800, Eric Dumazet wrote:
> On Tue, Jan 26, 2016 at 1:14 PM, Jarod Wilson <ja...@redhat.com> wrote:
> > On Sat, Jan 23, 2016 at 07:23:09AM -0800, Eric Dumazet wrote:
> >> On Fri, 2016-01-22 at 14:11 -0500, Jarod Wilson wrote:
> >
On Tue, Jan 26, 2016 at 01:21:00PM -0800, David Miller wrote:
> From: Jarod Wilson <ja...@redhat.com>
> Date: Tue, 26 Jan 2016 16:14:53 -0500
>
> > # ethtool -S bond0
> > no stats available
>
> ethtool -S is for device specific stats.
Okay, good, that was wh
1 - 100 of 231 matches
Mail list logo
