[PATCH net] sfc: skip ptp allocations on secondary interfaces

2016-12-15 Thread Jarod Wilson
...@solarflare.com CC: Edward Cree <ec...@solarflare.com> CC: Bert Kenward <bkenw...@solarflare.com> CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson <ja...@redhat.com> --- drivers/net/ethernet/sfc/ptp.c | 32 +--- 1 file changed, 17 insertions(+), 15 deleti

Re: [PATCH net] sfc: skip ptp allocations on secondary interfaces

2016-12-16 Thread Jarod Wilson
On 2016-12-15 3:31 PM, Jarod Wilson wrote: Rather than allocating efx_ptp_data, a buffer, a workqueue, etc., and then ultimately deciding not to call ptp_clock_register() for non-primary interfaces, just exit out of efx_ptp_prober() earlier. Saves a little memory and speeds up init and teardown

Re: bond procfs hw addr prints

2017-03-30 Thread Jarod Wilson
On 2017-03-13 11:26 PM, Jarod Wilson wrote: On 2017-03-13 10:06 PM, Jarod Wilson wrote: On 2017-03-13 8:28 PM, Jay Vosburgh wrote: Jarod Wilson <ja...@redhat.com> wrote: I've got a bug report for someone using a Intel OPA devices in a bond, and it appears these devices have a ha

Re: [PATCH net] net:ethernet:aquantia: Fix for RX checksum offload.

2017-03-22 Thread Jarod Wilson
On 2017-03-22 1:21 PM, Pavel Belous wrote: From: Pavel Belous <pavel.bel...@aquantia.com> Since AQC-100/107/08 chips supports hardware checksums for RX we should indicate this via NETIF_F_RXCSUM flag. Looks good, and fixes an lnst netperf test failure. Acked-by: Jarod Wils

Re: [patch] sfc: cleanup a condition in efx_udp_tunnel_del()

2017-03-22 Thread Jarod Wilson
Agreed, looks like a cut-n-paste buglet. Acked-by: Jarod Wilson <ja...@redhat.com> -- Jarod Wilson ja...@redhat.com

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-15 Thread Jarod Wilson
f I replied to the proper version of the patch. To reiterate, patch looks appropriate and necessary. Reviewed-by: Jarod Wilson <ja...@redhat.com> -- Jarod Wilson ja...@redhat.com

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-15 Thread Jarod Wilson
appropriate and necessary fix to me. Reviewed-by: Jarod Wilson <ja...@redhat.com> -- Jarod Wilson ja...@redhat.com

[PATCH net-next] bonding: attempt to better support longer hw addresses

2017-04-04 Thread Jarod Wilson
setup (with a mix of e1000 and e1000e cards), running LNST's bonding tests. CC: Jay Vosburgh <j.vosbu...@gmail.com> CC: Veaceslav Falico <vfal...@gmail.com> CC: Andy Gospodarek <a...@greyhouse.net> CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson <ja...@redhat.com>

Re: Horrid balance-rr bonding udp throughput

2017-04-10 Thread Jarod Wilson
On 2017-04-08 7:33 PM, Jarod Wilson wrote: I'm digging into some bug reports covering performance issues with balance-rr, and discovered something even worse than the reporter. My test setup has a pair of NICs, one e1000e, one e1000 (but dual e1000e seems the same). When I do a test run

Re: Horrid balance-rr bonding udp throughput

2017-04-11 Thread Jarod Wilson
On 2017-04-10 2:50 PM, Jarod Wilson wrote: On 2017-04-08 7:33 PM, Jarod Wilson wrote: I'm digging into some bug reports covering performance issues with balance-rr, and discovered something even worse than the reporter. My test setup has a pair of NICs, one e1000e, one e1000 (but dual e1000e

Re: [PATCH net-next] bonding: attempt to better support longer hw addresses

2017-04-06 Thread Jarod Wilson
On 2017-04-05 9:45 PM, David Miller wrote: From: Jarod Wilson <ja...@redhat.com> Date: Tue, 4 Apr 2017 17:32:42 -0400 ... Applied, but: +static inline void bond_hw_addr_copy(u8 *dst, const u8 *src, unsigned int len) +{ + if (len == ETH_ALEN) { + ether_addr_copy(ds

Horrid balance-rr bonding udp throughput

2017-04-08 Thread Jarod Wilson
, anyone has some insight, I'd be happy to hear it. :) -- Jarod Wilson ja...@redhat.com

bond procfs hw addr prints

2017-03-13 Thread Jarod Wilson
tinkered with just yet feels very clean, on top of not actually working yet. :) -- Jarod Wilson ja...@redhat.com

Re: bond procfs hw addr prints

2017-03-13 Thread Jarod Wilson
On 2017-03-13 8:28 PM, Jay Vosburgh wrote: Jarod Wilson <ja...@redhat.com> wrote: I've got a bug report for someone using a Intel OPA devices in a bond, and it appears these devices have a hardware address length of 20, opposed to the typical 6 on ethernet. When they dump /proc/net/b

Re: bond procfs hw addr prints

2017-03-13 Thread Jarod Wilson
On 2017-03-13 10:06 PM, Jarod Wilson wrote: On 2017-03-13 8:28 PM, Jay Vosburgh wrote: Jarod Wilson <ja...@redhat.com> wrote: I've got a bug report for someone using a Intel OPA devices in a bond, and it appears these devices have a hardware address length of 20, opposed to the typ

[PATCH net-next] bonding: add 802.3ad support for 25G speeds

2017-03-14 Thread Jarod Wilson
Cut-n-paste enablement of 802.3ad bonding on 25G NICs, which currently report 0 as their bandwidth. CC: Jay Vosburgh <j.vosbu...@gmail.com> CC: Veaceslav Falico <vfal...@gmail.com> CC: Andy Gospodarek <a...@greyhouse.net> CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson

Re: [Patch net] bonding: use ETH_MAX_MTU as max mtu

2017-03-06 Thread Jarod Wilson
On 2017-03-02 3:24 PM, Cong Wang wrote: This restores the ability of setting bond device's mtu to 9000. Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") Reported-by: daz...@gmail.com Reported-by: Brad Campbell <lists2...@fnarfbargle.com> Cc:

[PATCH net] team: use ETH_MAX_MTU as max mtu

2017-03-06 Thread Jarod Wilson
vger.kernel.org Signed-off-by: Jarod Wilson <ja...@redhat.com> --- drivers/net/team/team.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 4a24b5d15f5a..1b52520715ae 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c

Re: [Patch net] bonding: use ETH_MAX_MTU as max mtu

2017-03-06 Thread Jarod Wilson
) Reported-by: daz...@gmail.com Reported-by: Brad Campbell <lists2...@fnarfbargle.com> Cc: Jarod Wilson <ja...@redhat.com> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> Apologies, I'm a bit late to the party, direct CC didn't land in inbox because of duplicate suppress

Re: [Patch net 3/3] team: use a larger struct for mac address

2017-04-26 Thread Jarod Wilson
On 2017-04-26 1:28 PM, Cong Wang wrote: On Wed, Apr 26, 2017 at 9:46 AM, Jarod Wilson <ja...@redhat.com> wrote: On 2017-04-26 12:11 PM, Cong Wang wrote: On Wed, Apr 26, 2017 at 8:55 AM, Jarod Wilson <ja...@redhat.com> wrote: We already have struct sockaddr_storage that c

Re: [Patch net 3/3] team: use a larger struct for mac address

2017-04-26 Thread Jarod Wilson
both bonding and team, rather than having different per-driver structs, or Yet Another Address Storage implementation. -- Jarod Wilson ja...@redhat.com

Re: [Patch net 3/3] team: use a larger struct for mac address

2017-04-26 Thread Jarod Wilson
On 2017-04-26 12:11 PM, Cong Wang wrote: On Wed, Apr 26, 2017 at 8:55 AM, Jarod Wilson <ja...@redhat.com> wrote: We already have struct sockaddr_storage that could be used throughout this set as well. We just converted a few pieces of the bonding driver over to using it for better s

[PATCH net] bonding: fix accounting of active ports in 3ad

2017-05-17 Thread Jarod Wilson
to produce the state where I could see both in the same aggregator, but a number of ports count of 1. CC: Jay Vosburgh <j.vosbu...@gmail.com> CC: Veaceslav Falico <vfal...@gmail.com> CC: Andy Gospodarek <a...@greyhouse.net> CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson <ja.

[PATCH net] bonding: fix randomly populated arp target array

2017-05-19 Thread Jarod Wilson
lobal variables") CC: Mahesh Bandewar <mahe...@google.com> CC: Jay Vosburgh <j.vosbu...@gmail.com> CC: Veaceslav Falico <vfal...@gmail.com> CC: Andy Gospodarek <a...@greyhouse.net> CC: netdev@vger.kernel.org CC: sta...@vger.kernel.org Signed-off-by: Jarod Wilson <ja...

Re: [PATCH net] bonding: fix randomly populated arp target array

2017-05-19 Thread Jarod Wilson
On 2017-05-19 4:38 PM, Mahesh Bandewar (महेश बंडेवार) wrote: On Fri, May 19, 2017 at 11:46 AM, Jarod Wilson <ja...@redhat.com> wrote: In commit dc9c4d0fe023, the arp_target array moved from a static global to a local variable. By the nature of static globals, the array used to be initi

Re: [PATCH net] bonding: fix accounting of active ports in 3ad

2017-05-19 Thread Jarod Wilson
On 2017-05-19 5:14 PM, David Miller wrote: From: Jarod Wilson <ja...@redhat.com> Date: Wed, 17 May 2017 11:11:44 -0400 As of 7bb11dc9f59d and 0622cab0341c, bond slaves in a 3ad bond are not removed from the aggregator when they are down, and the active slave count is NOT equal to

[PATCH net v2] bonding: fix accounting of active ports in 3ad

2017-05-19 Thread Jarod Wilson
alico <vfal...@gmail.com> CC: Andy Gospodarek <a...@greyhouse.net> CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson <ja...@redhat.com> --- v2: fix incorrect git sha reference, add more testing data drivers/net/bonding/bond_3ad.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-05 Thread Jarod Wilson
est this patch if my analysis appears sound? This patch looks good, the original reproducing setup successfully recovers after the original active slave goes down, even with NetworkManager in the mix. Reviewed-by: Jarod Wilson <ja...@redhat.com> -- Jarod Wilson ja...@redhat.com

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-01 Thread Jarod Wilson
to get a net-next-ish kernel into their hands, but the bonding driver we're working with here is quite close to current net-next already, so I'm fairly confident the same thing will happen. -- Jarod Wilson ja...@redhat.com

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-03 Thread Jarod Wilson
suggested, use Jay's patch). Will do, test build is just about ready here. -- Jarod Wilson ja...@redhat.com

Re: [PATCH net] sfc: pass valid pointers from efx_enqueue_unwind

2017-12-08 Thread Jarod Wilson
this fix it would fail with a NULL pointer dereference in efx_dequeue_buffer, with efx_enqueue_skb in the call stack. Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2") Reported-by: Jarod Wilson <ja...@redhat.com> Signed-off-by: Bert Kenward <bkenw...@solarflare.c

<    1   2   3