On Mon, Jan 22, 2024 at 2:55 PM Jason Wang wrote:
>
> On Mon, Jan 22, 2024 at 2:20 PM Xuan Zhuo wrote:
> >
> > On Mon, 22 Jan 2024 12:16:27 +0800, Jason Wang wrote:
> > > On Mon, Jan 22, 2024 at 12:00 PM Xuan Zhuo
> > > wrote:
> > > >
> &
On Mon, Jan 22, 2024 at 3:07 PM Xuan Zhuo wrote:
>
> On Mon, 22 Jan 2024 14:58:09 +0800, Jason Wang wrote:
> > On Mon, Jan 22, 2024 at 2:55 PM Jason Wang wrote:
> > >
> > > On Mon, Jan 22, 2024 at 2:20 PM Xuan Zhuo
> > > wrote:
> > > >
>
On Mon, Jan 22, 2024 at 3:36 PM Xuan Zhuo wrote:
>
> On Mon, 22 Jan 2024 15:19:12 +0800, Jason Wang wrote:
> > On Mon, Jan 22, 2024 at 3:07 PM Xuan Zhuo
> > wrote:
> > >
> > > On Mon, 22 Jan 2024 14:58:09 +0800, Jason Wang
> > > wrote:
>
On Mon, Jan 22, 2024 at 4:04 PM Xuan Zhuo wrote:
>
> On Mon, 22 Jan 2024 15:57:08 +0800, Jason Wang wrote:
> > On Mon, Jan 22, 2024 at 3:36 PM Xuan Zhuo
> > wrote:
> > >
> > > On Mon, 22 Jan 2024 15:19:12 +0800, Jason Wang
> > > wrote:
>
On Tue, Jan 16, 2024 at 3:59 PM Xuan Zhuo wrote:
>
> introduce virtqueue_get_buf_ctx_dma() to collect the dma info when
> get buf from virtio core for premapped mode.
>
> If the virtio queue is premapped mode, the virtio-net send buf may
> have many desc.
This feature is not specific to virtio-ne
On Tue, Jan 16, 2024 at 3:59 PM Xuan Zhuo wrote:
>
> Introduce helper virtqueue_get_dma_premapped(), then the driver
> can know whether dma unmap is needed.
>
> Signed-off-by: Xuan Zhuo
> ---
> drivers/net/virtio/main.c | 22 +-
> drivers/net/virtio/virtio_net.h | 3 --
On Tue, Jan 16, 2024 at 3:59 PM Xuan Zhuo wrote:
>
> If the xsk is enabling, the xsk tx will share the send queue.
Any reason for this? Technically, virtio-net can work as other NIC
like 256 queues. There could be some work like optimizing the
interrupt allocations etc.
> But the xsk requires th
On Tue, Jan 16, 2024 at 3:59 PM Xuan Zhuo wrote:
>
> This is the second part of virtio-net support AF_XDP zero copy.
>
> The whole patch set
> http://lore.kernel.org/all/20231229073108.57778-1-xuanz...@linux.alibaba.com
>
> ## About the branch
>
> This patch set is pushed to the net-next branch, b
On Thu, Jan 25, 2024 at 1:52 PM Xuan Zhuo wrote:
>
> On Thu, 25 Jan 2024 13:42:05 +0800, Xuan Zhuo
> wrote:
> > On Thu, 25 Jan 2024 11:39:28 +0800, Jason Wang wrote:
> > > On Tue, Jan 16, 2024 at 3:59 PM Xuan Zhuo
> > > wrote:
> > > >
> >
On Thu, Jan 25, 2024 at 2:24 PM Xuan Zhuo wrote:
>
> On Thu, 25 Jan 2024 11:39:20 +0800, Jason Wang wrote:
> > On Tue, Jan 16, 2024 at 3:59 PM Xuan Zhuo
> > wrote:
> > >
> > > If the xsk is enabling, the xsk tx will share the send queue.
> >
> >
On Thu, Jan 25, 2024 at 1:58 PM Xuan Zhuo wrote:
>
> On Thu, 25 Jan 2024 11:39:03 +0800, Jason Wang wrote:
> > On Tue, Jan 16, 2024 at 3:59 PM Xuan Zhuo
> > wrote:
> > >
> > > Introduce helper virtqueue_get_dma_premapped(), then the driver
> &
On Thu, Jan 25, 2024 at 2:33 PM Xuan Zhuo wrote:
>
> On Thu, 25 Jan 2024 14:14:58 +0800, Jason Wang wrote:
> > On Thu, Jan 25, 2024 at 1:52 PM Xuan Zhuo
> > wrote:
> > >
> > > On Thu, 25 Jan 2024 13:42:05 +0800, Xuan Zhuo
> > > wrote:
> >
On Mon, Jan 29, 2024 at 2:28 PM Xuan Zhuo wrote:
>
> On Mon, 29 Jan 2024 11:37:56 +0800, Xuan Zhuo
> wrote:
> > On Mon, 29 Jan 2024 11:14:43 +0800, Jason Wang wrote:
> > > On Thu, Jan 25, 2024 at 2:33 PM Xuan Zhuo
> > > wrote:
> > > >
> >
On Mon, Jan 29, 2024 at 11:33 AM Xuan Zhuo wrote:
>
> On Mon, 29 Jan 2024 11:07:50 +0800, Jason Wang wrote:
> > On Thu, Jan 25, 2024 at 1:58 PM Xuan Zhuo
> > wrote:
> > >
> > > On Thu, 25 Jan 2024 11:39:03 +0800, Jason Wang
> > > wrote:
>
On Mon, Jan 29, 2024 at 11:28 AM Xuan Zhuo wrote:
>
> On Mon, 29 Jan 2024 11:06:35 +0800, Jason Wang wrote:
> > On Thu, Jan 25, 2024 at 2:24 PM Xuan Zhuo
> > wrote:
> > >
> > > On Thu, 25 Jan 2024 11:39:20 +0800, Jason Wang
> > > wrote:
>
On Tue, Jan 16, 2024 at 1:56 PM Xuan Zhuo wrote:
>
> On Tue, 26 Dec 2023 15:30:57 +0800, Xuan Zhuo
> wrote:
> > As the spec:
> >
> > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
> >
> > The virtio net supports to get device stats.
>
> Hi Jason,
>
> Any
On Sat, Feb 3, 2024 at 12:01 AM Jakub Kicinski wrote:
>
> On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wrote:
> > > Can you say more? I'm curious what's your use case.
> >
> > I'm not working at Nvidia, so my point of view may differ from theirs.
> > From what I can tell is that those two counters
On Sun, Feb 4, 2024 at 8:39 PM Michael S. Tsirkin wrote:
>
> On Sun, Feb 04, 2024 at 09:20:18AM +0800, Jason Wang wrote:
> > On Sat, Feb 3, 2024 at 12:01 AM Jakub Kicinski wrote:
> > >
> > > On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wrote:
> > > > &
On Tue, Mar 19, 2024 at 2:56 PM Michael S. Tsirkin wrote:
>
> On Tue, Mar 12, 2024 at 11:35:47AM +0800, Xuan Zhuo wrote:
> > As discussed:
> >
> > http://lore.kernel.org/all/cacgkmevq0no8qgc46u4mgsmtud44fd_cflcpavmj3rhyqrz...@mail.gmail.com
> >
> > If the virtio is premapped mode, the driver shoul
t; We do not have a consistent reproducer but when we put some bigger
> > > network load on a VM, the hypervisor's kernel crashes.
> > >
> > > Help is much appreciated! We are happy to test any patches.
> >
> > CCing Michael Tsirkin and Jason Wang for vh
On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo wrote:
>
> As discussed:
>
> http://lore.kernel.org/all/cacgkmevq0no8qgc46u4mgsmtud44fd_cflcpavmj3rhyqrz...@mail.gmail.com
>
> If the virtio is premapped mode, the driver should manage the dma info by
> self.
> So the virtio core should not store the dma
On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo wrote:
>
> This commit structure the indirect desc table.
> Then we can get the desc num directly when doing unmap.
>
> And save the dma info to the struct, then the indirect
> will not use the dma fields of the desc_extra. The subsequent
> commits will m
On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo wrote:
>
> In the functions vring_unmap_extra_packed and vring_unmap_desc_packed,
> multiple checks are made whether unmap is performed and whether it is
> INDIRECT.
>
> These two functions are usually called in a loop, and we should put the
> check outsi
On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo wrote:
>
> Now, the API virtqueue_set_dma_premapped just support to
> enable premapped mode.
>
> If we allow enabling the premapped dynamically, we should
> make this API to support disable the premapped mode.
>
> Signed-off-by: Xuan Zhuo
> ---
> driver
On Thu, Mar 21, 2024 at 4:22 PM Xuan Zhuo wrote:
>
> On Thu, 21 Mar 2024 14:02:14 +0800, Jason Wang wrote:
> > On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo
> > wrote:
> > >
> > > Now, the API virtqueue_set_dma_premapped just support to
> > > e
On Thu, Mar 21, 2024 at 4:21 PM Xuan Zhuo wrote:
>
> On Thu, 21 Mar 2024 13:57:06 +0800, Jason Wang wrote:
> > On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo
> > wrote:
> > >
> > > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed,
> >
On Thu, Mar 21, 2024 at 7:46 PM Heng Qi wrote:
>
> When the dim worker is scheduled, if it fails to acquire the lock,
> dim may not be able to return to the working state later.
>
> For example, the following single queue scenario:
> 1. The dim worker of rxq0 is scheduled, and the dim status is
On Thu, Mar 21, 2024 at 7:46 PM Heng Qi wrote:
>
> Currently, ctrlq processes commands in a synchronous manner,
> which increases the delay of dim commands when configuring
> multi-queue VMs, which in turn causes the CPU utilization to
> increase and interferes with the performance of dim.
>
> The
On Thu, Mar 21, 2024 at 4:29 PM Xuan Zhuo wrote:
>
> On Thu, 21 Mar 2024 12:47:18 +0800, Jason Wang wrote:
> > On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo
> > wrote:
> > >
> > > This commit structure the indirect desc table.
> > > Then we c
On Thu, Mar 21, 2024 at 5:44 PM Igor Raits wrote:
>
> Hello Jason & others,
>
> On Wed, Mar 20, 2024 at 10:33 AM Jason Wang wrote:
> >
> > On Tue, Mar 19, 2024 at 9:15 PM Igor Raits wrote:
> > >
> > > Hello Stefan,
> > >
> > &g
On Fri, Mar 22, 2024 at 2:04 PM Xuan Zhuo wrote:
>
> On Fri, 22 Mar 2024 13:13:36 +0800, Jason Wang wrote:
> > On Thu, Mar 21, 2024 at 4:22 PM Xuan Zhuo
> > wrote:
> > >
> > > On Thu, 21 Mar 2024 14:02:14 +0800, Jason Wang
> > > wrote:
>
On Mon, Mar 25, 2024 at 2:58 PM Heng Qi wrote:
>
>
>
> 在 2024/3/25 下午2:29, Jason Wang 写道:
> > On Mon, Mar 25, 2024 at 10:11 AM Heng Qi wrote:
> >>
> >>
> >> 在 2024/3/22 下午1:17, Jason Wang 写道:
> >>> On Thu, Mar 21, 2024 at 7:46 PM Heng
On Fri, Mar 22, 2024 at 3:58 PM Xuan Zhuo wrote:
>
> On Fri, 22 Mar 2024 13:15:10 +0800, Jason Wang wrote:
> > On Thu, Mar 21, 2024 at 4:29 PM Xuan Zhuo
> > wrote:
> > >
> > > On Thu, 21 Mar 2024 12:47:18 +0800, Jason Wang
> > > wrote:
>
On Mon, Mar 25, 2024 at 3:18 PM Heng Qi wrote:
>
>
>
> 在 2024/3/25 下午1:57, Jason Wang 写道:
> > On Mon, Mar 25, 2024 at 10:21 AM Heng Qi wrote:
> >>
> >>
> >> 在 2024/3/22 下午1:19, Jason Wang 写道:
> >>> On Thu, Mar 21, 2024 at 7:46 PM Heng Q
On Mon, Mar 25, 2024 at 4:22 PM Heng Qi wrote:
>
>
>
> 在 2024/3/25 下午3:56, Jason Wang 写道:
> > On Mon, Mar 25, 2024 at 3:18 PM Heng Qi wrote:
> >>
> >>
> >> 在 2024/3/25 下午1:57, Jason Wang 写道:
> >>> On Mon, Mar 25, 2024 at 10:21 AM Heng Q
On Mon, Mar 25, 2024 at 10:21 AM Heng Qi wrote:
>
>
>
> 在 2024/3/22 下午1:19, Jason Wang 写道:
> > On Thu, Mar 21, 2024 at 7:46 PM Heng Qi wrote:
> >> Currently, ctrlq processes commands in a synchronous manner,
> >> which increases the delay of dim commands w
On Mon, Mar 25, 2024 at 10:11 AM Heng Qi wrote:
>
>
>
> 在 2024/3/22 下午1:17, Jason Wang 写道:
> > On Thu, Mar 21, 2024 at 7:46 PM Heng Qi wrote:
> >> When the dim worker is scheduled, if it fails to acquire the lock,
> >> dim may not be able to return to th
On Tue, Mar 26, 2024 at 10:46 AM Heng Qi wrote:
>
>
>
> 在 2024/3/25 下午4:42, Jason Wang 写道:
> > On Mon, Mar 25, 2024 at 4:22 PM Heng Qi wrote:
> >>
> >>
> >> 在 2024/3/25 下午3:56, Jason Wang 写道:
> >>> On Mon, Mar 25, 2024 at 3:18 PM Heng Q
On Mon, Mar 25, 2024 at 4:44 PM Igor Raits wrote:
>
> Hello,
>
> On Fri, Mar 22, 2024 at 12:19 PM Igor Raits wrote:
> >
> > Hi Jason,
> >
> > On Fri, Mar 22, 2024 at 9:39 AM Igor Raits wrote:
> > >
> > > Hi Jason,
> > >
> > &g
On Tue, Mar 26, 2024 at 1:57 PM Heng Qi wrote:
>
>
>
> 在 2024/3/26 下午12:08, Jason Wang 写道:
> > On Tue, Mar 26, 2024 at 10:46 AM Heng Qi wrote:
> >>
> >>
> >> 在 2024/3/25 下午4:42, Jason Wang 写道:
> >>> On Mon, Mar 25, 2024 at 4:22 PM Heng Q
On Mon, Mar 25, 2024 at 4:54 PM Xuan Zhuo wrote:
>
> As discussed:
>
> http://lore.kernel.org/all/cacgkmevq0no8qgc46u4mgsmtud44fd_cflcpavmj3rhyqrz...@mail.gmail.com
>
> If the virtio is premapped mode, the driver should manage the dma info by
> self.
> So the virtio core should not store the dma
Hi Jason,
> > > >
> > > > On Fri, Mar 22, 2024 at 9:39 AM Igor Raits wrote:
> > > > >
> > > > > Hi Jason,
> > > > >
> > > > > On Fri, Mar 22, 2024 at 6:31 AM Jason Wang
> > > > > wrote:
> > >
On Wed, Mar 27, 2024 at 3:16 PM Xuan Zhuo wrote:
>
> On Tue, 26 Mar 2024 14:35:21 +0800, Jason Wang wrote:
> > On Mon, Mar 25, 2024 at 4:54 PM Xuan Zhuo
> > wrote:
> > >
> > > As discussed:
> > >
> > > http://lore.kernel.or
On Wed, Mar 27, 2024 at 4:07 PM Xuan Zhuo wrote:
>
> On Wed, 27 Mar 2024 15:50:17 +0800, Jason Wang wrote:
> > On Wed, Mar 27, 2024 at 3:16 PM Xuan Zhuo
> > wrote:
> > >
> > > On Tue, 26 Mar 2024 14:35:21 +0800, Jason Wang
> > > wrote:
>
On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo wrote:
>
> In the functions vring_unmap_extra_packed and vring_unmap_desc_packed,
> multiple checks are made whether unmap is performed and whether it is
> INDIRECT.
>
> These two functions are usually called in a loop, and we should put the
> check outsid
On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo wrote:
>
> This commit structure the indirect desc table.
> Then we can get the desc num directly when doing unmap.
>
> And save the dma info to the struct, then the indirect
> will not use the dma fields of the desc_extra. The subsequent
> commits will ma
On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo wrote:
>
> This commit structure the indirect desc table.
> Then we can get the desc num directly when doing unmap.
>
> And save the dma info to the struct, then the indirect
> will not use the dma fields of the desc_extra. The subsequent
> commits will ma
On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo wrote:
>
> As discussed:
> http://lore.kernel.org/all/CACGkMEug-=C+VQhkMYSgUKMC==04m7-uem_yc21bggkkzh8...@mail.gmail.com
>
> When the vq is premapped mode, the driver manages the dma
> info is a good way.
>
> So this commit make the virtio core not to stor
immediately by virtqueue_set_dma_premapped(). This patch introduces a
> new parameter to find_vqs(). Then we can judge should we allocate the
> dma array(struct vring_desc_dma) or not inside find_vqs().
>
> The driver must check the premapped mode of every vq after find_vqs().
>
> Signed-of
On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo wrote:
>
> Export the premapped to drivers, then drivers can check
> the vq premapped mode after the find_vqs().
> Because the find_vqs() just try to enable the vq premapped mode,
> the driver must check that after find_vqs().
What's the reason for this?
On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo wrote:
>
> Now, the virtio core can set the premapped mode by find_vqs().
> If the premapped can be enabled, the dma array will not be
> allocated. So virtio-net use the api of find_vqs to enable the
> premapped.
>
> Judge the premapped mode by the vq->pre
On Thu, Mar 28, 2024 at 3:38 PM Xuan Zhuo wrote:
>
> On Thu, 28 Mar 2024 14:56:55 +0800, Jason Wang wrote:
> > On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo
> > wrote:
> > >
> > > This commit structure the indirect desc table.
> > > Then we c
On Thu, Mar 28, 2024 at 3:32 PM Xuan Zhuo wrote:
>
> On Thu, 28 Mar 2024 14:56:47 +0800, Jason Wang wrote:
> > On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo
> > wrote:
> > >
> > > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed,
> > &
On Thu, Mar 28, 2024 at 3:42 PM Xuan Zhuo wrote:
>
> On Thu, 28 Mar 2024 15:06:33 +0800, Jason Wang wrote:
> > On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo
> > wrote:
> > >
> > > As discussed:
> > > http://lore.kernel.org/all/CACGkMEug-=C+VQhkMYSg
On Thu, Mar 28, 2024 at 4:27 PM Xuan Zhuo wrote:
>
> On Thu, 28 Mar 2024 16:05:02 +0800, Jason Wang wrote:
> > On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo
> > wrote:
> > >
> > > Now, the virtio core can set the premapped mode by find_vqs().
> > > I
On Thu, Mar 28, 2024 at 4:16 PM Xuan Zhuo wrote:
>
> On Thu, 28 Mar 2024 16:07:14 +0800, Jason Wang wrote:
> > On Thu, Mar 28, 2024 at 3:32 PM Xuan Zhuo
> > wrote:
> > >
> > > On Thu, 28 Mar 2024 14:56:47 +0800, Jason Wang
> > > wrote:
>
On Mon, Apr 1, 2024 at 11:10 AM Xuan Zhuo wrote:
>
> On Mon, 1 Apr 2024 09:40:07 +0800, Xuan Zhuo
> wrote:
> > On Fri, 29 Mar 2024 11:20:08 +0800, Jason Wang wrote:
> > > On Thu, Mar 28, 2024 at 4:27 PM Xuan Zhuo
> > > wrote:
> > > >
> >
On Sun, Apr 7, 2024 at 2:03 PM Xuan Zhuo wrote:
>
> On Sun, 7 Apr 2024 12:24:00 +0800, Jason Wang wrote:
> > On Mon, Apr 1, 2024 at 11:10 AM Xuan Zhuo
> > wrote:
> > >
> > > On Mon, 1 Apr 2024 09:40:07 +0800, Xuan Zhuo
> > > wrote:
> >
On Mon, Mar 18, 2024 at 7:06 PM Xuan Zhuo wrote:
>
> The virtio-net device stats spec:
>
> https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
>
> We introduce the relative feature and structures.
>
> Signed-off-by: Xuan Zhuo
Acked-by: Jason Wang
Thanks
On Mon, Mar 18, 2024 at 7:06 PM Xuan Zhuo wrote:
>
> As the spec
> https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
>
> The virtnet cvq supports to get result from the device.
>
> Signed-off-by: Xuan Zhuo
> ---
> drivers/net/virtio_net.c | 47
1. If the queue
> num is larger than 10, the length of the prefix is 12. So the
> key name max is 19. That is too short. We will introduce some keys
> such as "gso_packets_coalesced". So we should change the prefix
> to "rx0_".
>
> Signed-off-by: Xuan Zhuo
Acked-by: Jason Wang
Thanks
On Mon, Mar 18, 2024 at 7:06 PM Xuan Zhuo wrote:
>
> Now, we have this:
>
> tx_queue_0_tx_timeouts
>
> This is used to record the tx schedule timeout.
> But this has two "tx". I think the below is enough.
>
> tx_queue_0_timeouts
>
> So I rename this field.
>
> Signed-off-by: Xuan Zhuo
> R
On Mon, Mar 18, 2024 at 7:06 PM Xuan Zhuo wrote:
>
> As the spec
> https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
>
> make virtio-net support getting the stats from the device by ethtool -S
> .
>
> Due to the numerous descriptors stats, an organization me
On Wed, Apr 10, 2024 at 6:55 PM Xuan Zhuo wrote:
>
> On Wed, 10 Apr 2024 14:09:23 +0800, Jason Wang wrote:
> > On Mon, Mar 18, 2024 at 7:06 PM Xuan Zhuo
> > wrote:
> > >
> > > As the spec
> > > https://github.com/oasis-tcs/virtio-spec/co
On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote:
>
> Now, we chain the pages of big mode by the page's private variable.
> But a subsequent patch aims to make the big mode to support
> premapped mode. This requires additional space to store the dma addr.
>
> Within the sub-struct that contains th
On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo wrote:
>
> On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang wrote:
> > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo
> > wrote:
> > >
> > > Now, we chain the pages of big mode by the page's private variable.
> >
On Mon, Apr 15, 2024 at 10:35 AM Xuan Zhuo wrote:
>
> On Fri, 12 Apr 2024 13:49:12 +0800, Jason Wang wrote:
> > On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo
> > wrote:
> > >
> > > On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang
> > > wrote:
>
On Mon, Apr 15, 2024 at 10:51 AM Xuan Zhuo wrote:
>
> On Thu, 11 Apr 2024 14:09:24 +0800, Jason Wang wrote:
> > On Wed, Apr 10, 2024 at 6:55 PM Xuan Zhuo
> > wrote:
> > >
> > > On Wed, 10 Apr 2024 14:09:23 +0800, Jason Wang
> > > wrote:
>
On Mon, Apr 15, 2024 at 4:15 PM Xuan Zhuo wrote:
>
> On Mon, 15 Apr 2024 14:45:36 +0800, Jason Wang wrote:
> > On Mon, Apr 15, 2024 at 10:51 AM Xuan Zhuo
> > wrote:
> > >
> > > On Thu, 11 Apr 2024 14:09:24 +0800, Jason Wang
> > > wrote:
>
On Mon, Apr 15, 2024 at 4:50 PM Xuan Zhuo wrote:
>
> On Mon, 15 Apr 2024 14:43:24 +0800, Jason Wang wrote:
> > On Mon, Apr 15, 2024 at 10:35 AM Xuan Zhuo
> > wrote:
> > >
> > > On Fri, 12 Apr 2024 13:49:12 +0800, Jason Wang
> > > wrote:
>
On Mon, Apr 15, 2024 at 5:04 PM Xuan Zhuo wrote:
>
> On Mon, 15 Apr 2024 16:56:45 +0800, Jason Wang wrote:
> > On Mon, Apr 15, 2024 at 4:50 PM Xuan Zhuo
> > wrote:
> > >
> > > On Mon, 15 Apr 2024 14:43:24 +0800, Jason Wang
> > > wrote:
>
---
Note that this can be done already with vp_vdpa feature provisioning:
commit c1ca352d371f724f7fb40f016abdb563aa85fe55
Author: Jason Wang
Date: Tue Sep 27 15:48:10 2022 +0800
vp_vdpa: support feature provisioning
For example:
vdpa dev add name dev1 mgmtdev pci/:02:00.0 device_features 0x30002
Thanks
On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo wrote:
>
> On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang wrote:
> > On Mon, Apr 15, 2024 at 5:04 PM Xuan Zhuo
> > wrote:
> > >
> > > On Mon, 15 Apr 2024 16:56:45 +0800, Jason Wang
> > > wrote:
>
On Tue, Apr 16, 2024 at 9:03 PM Jiri Pirko wrote:
>
> Tue, Apr 16, 2024 at 11:53:35AM CEST, j...@resnulli.us wrote:
> >Mon, Apr 15, 2024 at 07:26:59PM CEST, k...@kernel.org wrote:
> >>On Sat, 13 Apr 2024 15:23:53 +0200 Jiri Pirko wrote:
> >>> That is a goal. Currently I do it with:
> >>> vng --qem
ys/bus/virtio/drivers/virtio_net/bind
> >> $ cat /sys/bus/virtio/devices/virtio0/features
> >> 11110101110010001000
> >>
> >> Note that sysfs "features" know already exists, this patch does not
> >> tou
> >> >> $ echo "virtio0" > /sys/bus/virtio/drivers/virtio_net/bind
> >> >> $ cat /sys/bus/virtio/devices/virtio0/features
> >> >> 11110101110010001000
> >> >>
> >> >> Note that sysfs "featur
On Wed, Apr 17, 2024 at 4:45 PM Xuan Zhuo wrote:
>
> On Wed, 17 Apr 2024 12:08:10 +0800, Jason Wang wrote:
> > On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo
> > wrote:
> > >
> > > On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang
> > > wrote:
>
On Thu, Apr 18, 2024 at 12:15 PM Jason Wang wrote:
>
> On Wed, Apr 17, 2024 at 4:45 PM Xuan Zhuo wrote:
> >
> > On Wed, 17 Apr 2024 12:08:10 +0800, Jason Wang wrote:
> > > On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo
> > > wrote:
> > > >
> &
e, enum dma_data_direction dir,
>unsigned long attrs);
>
> Signed-off-by: Xuan Zhuo
Acked-by: Jason Wang
Thanks
by: Xuan Zhuo
Acked-by: Jason Wang
Thanks
/* Average packet length for mergeable receive buffers. */
> @@ -432,16 +435,16 @@ skb_vnet_common_hdr(struct sk_buff *skb)
> }
>
> /*
> - * private is used to chain pages for big packets, put the whole
> - * most recent used list in the beginning for reuse
> + * put the whole most recent used list in the beginning for reuse
> */
While at this, let's explain the pp is used to chain pages or we can
do it on the definition of page_chain_add().
Others look good.
Acked-by: Jason Wang
Thanks
On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote:
>
> Now, we have virtio DMA APIs, the driver can be the premapped
> mode whatever the virtio core uses dma api or not.
>
> So remove the limit of checking use_dma_api from
> virtqueue_set_dma_premapped().
>
> Signed-off-by: Xuan Zhuo
> ---
> driv
On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote:
>
> In big mode, pre-mapping DMA is beneficial because if the pages are not
> used, we can reuse them without needing to unmap and remap.
>
> We require space to store the DMA address. I use the page.dma_addr to
> store the DMA address from the pp
On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote:
>
> Currently, big, merge, and small modes all support the premapped mode.
> We can now enable premapped mode by default. Furthermore,
> virtqueue_set_dma_premapped() must succeed when called immediately after
> find_vqs(). Consequently, we can ass
On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote:
>
> Now, for the merge and small, the premapped mode can be enabled
> unconditionally.
I guess it's not only merge and small but big mode as well?
>
> So we can remove the failover code.
>
> Signed-off-by: Xuan Z
On Wed, Apr 17, 2024 at 3:31 AM Daniel Jurgens wrote:
>
> The command VQ will no longer be protected by the RTNL lock. Use a
> spinlock to protect the control buffer header and the VQ.
>
> Signed-off-by: Daniel Jurgens
> Reviewed-by: Jiri Pirko
> ---
> drivers/net/virtio_net.c | 6 +-
> 1 f
18 at 15:36 +0800, Heng Qi wrote:
> >>>> 在 2024/4/18 下午2:42, Jason Wang 写道:
> >>>>> On Wed, Apr 17, 2024 at 3:31 AM Daniel Jurgens
> >>> wrote:
> >>>>>> The command VQ will no longer be protected by the RTNL lock. Use a
> >>
On Thu, Apr 18, 2024 at 4:35 PM Xuan Zhuo wrote:
>
> On Thu, 18 Apr 2024 14:25:06 +0800, Jason Wang wrote:
> > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo
> > wrote:
> > >
> > > In big mode, pre-mapping DMA is beneficial because if the pages are not
> >
On Thu, Apr 18, 2024 at 4:37 PM Xuan Zhuo wrote:
>
> On Thu, 18 Apr 2024 14:26:33 +0800, Jason Wang wrote:
> > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo
> > wrote:
> > >
> > > Currently, big, merge, and small modes all support the premapped mode.
>
On Fri, Apr 19, 2024 at 12:23 PM Xuan Zhuo wrote:
>
> On Fri, 19 Apr 2024 08:43:43 +0800, Jason Wang wrote:
> > On Thu, Apr 18, 2024 at 4:35 PM Xuan Zhuo
> > wrote:
> > >
> > > On Thu, 18 Apr 2024 14:25:06 +0800, Jason Wang
> > > wrote:
>
On Fri, Apr 19, 2024 at 3:07 PM Xuan Zhuo wrote:
>
> On Fri, 19 Apr 2024 13:46:25 +0800, Jason Wang wrote:
> > On Fri, Apr 19, 2024 at 12:23 PM Xuan Zhuo
> > wrote:
> > >
> > > On Fri, 19 Apr 2024 08:43:43 +0800, Jason Wang
> > > wrote:
>
On Fri, Apr 19, 2024 at 3:28 PM Xuan Zhuo wrote:
>
> On Fri, 19 Apr 2024 15:24:25 +0800, Jason Wang wrote:
> > On Fri, Apr 19, 2024 at 3:07 PM Xuan Zhuo
> > wrote:
> > >
> > > On Fri, 19 Apr 2024 13:46:25 +0800, Jason Wang
> > > wrote:
>
On Mon, Apr 22, 2024 at 3:24 PM Xuan Zhuo wrote:
>
> We call the build_skb() actually without copying data.
> The comment is misleading. So remove it.
>
> Signed-off-by: Xuan Zhuo
Acked-by: Jason Wang
Thanks
> ---
> drivers/net/virtio_net.c | 1 -
> 1 file changed
On Mon, Apr 22, 2024 at 3:24 PM Xuan Zhuo wrote:
>
> In big mode, pre-mapping DMA is beneficial because if the pages are not
> used, we can reuse them without needing to unmap and remap.
>
> We require space to store the DMA address. I use the page.dma_addr to
> store the DMA address from the pp s
On Tue, Apr 23, 2024 at 8:38 PM Xuan Zhuo wrote:
>
> On Tue, 23 Apr 2024 12:36:42 +0800, Jason Wang wrote:
> > On Mon, Apr 22, 2024 at 3:24 PM Xuan Zhuo
> > wrote:
> > >
> > > In big mode, pre-mapping DMA is beneficial because if the pages are not
> >
On Wed, Apr 24, 2024 at 9:10 AM Xuan Zhuo wrote:
>
> On Wed, 24 Apr 2024 08:43:21 +0800, Jason Wang wrote:
> > On Tue, Apr 23, 2024 at 8:38 PM Xuan Zhuo
> > wrote:
> > >
> > > On Tue, 23 Apr 2024 12:36:42 +0800, Jason Wang
> > > wrote:
>
On Wed, Apr 24, 2024 at 10:42 AM Xuan Zhuo wrote:
>
> On Wed, 24 Apr 2024 10:34:56 +0800, Jason Wang wrote:
> > On Wed, Apr 24, 2024 at 9:10 AM Xuan Zhuo
> > wrote:
> > >
> > > On Wed, 24 Apr 2024 08:43:21 +0800, Jason Wang
> > > wrote:
>
rtnet_get_hw_stats_string(struct virtnet_info *vi, int type,
> int qid, u8 **data)
> +{
> + const struct virtnet_stat_desc *desc;
> + const char *fmt, *noq_fmt;
> + u8 *p = *data;
> + u32 num = 0;
> +
> + if (!virtio_has_feature(vi->vdev, VIRTIO_NET_F_DEVICE_STATS))
> + return;
> +
> + if (type == VIRTNET_Q_TYPE_CQ) {
> + noq_fmt = "cq_hw_%s";
> +
> + if (VIRTIO_NET_STATS_TYPE_CVQ & vi->device_stats_cap) {
Nit: I think we'd better to have a consistent style:
If we do
type == VIRTNET_Q_TYPE_CQ
then we'd better use
vi->device_stats_cap & VIRTIO_NET_STATS_TYPE_CVQ
Other than this,
Acked-by: Jason Wang
Thanks
On Wed, Apr 24, 2024 at 10:58 AM Xuan Zhuo wrote:
>
> On Wed, 24 Apr 2024 10:45:49 +0800, Jason Wang wrote:
> > On Wed, Apr 24, 2024 at 10:42 AM Xuan Zhuo
> > wrote:
> > >
> > > On Wed, 24 Apr 2024 10:34:56 +0800, Jason Wang
> > > wrote:
>
nd driver stats.
>
> Signed-off-by: Xuan Zhuo
> ---
Acked-by: Jason Wang
Thanks
201 - 300 of 2070 matches
Mail list logo
