Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-26 Thread Jason Wang
On 2021/1/20 下午2:52, Yongji Xie wrote: On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: Now we have a global percpu counter to limit the recursion depth of eventfd_signal(). This can avoid deadlock or stack overflow. But in stack overflow case, it

Re: [RFC v3 06/11] vhost-vdpa: Add an opaque pointer for vhost IOTLB

2021-01-26 Thread Jason Wang
On 2021/1/20 下午3:52, Yongji Xie wrote: On Wed, Jan 20, 2021 at 2:24 PM Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: Add an opaque pointer for vhost IOTLB to store the corresponding vma->vm_file and offset on the DMA mapping. Let's split the patch into two. 1) opaque

Re: [RFC v3 05/11] vdpa: shared virtual addressing support

2021-01-26 Thread Jason Wang
On 2021/1/20 下午3:10, Yongji Xie wrote: On Wed, Jan 20, 2021 at 1:55 PM Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: This patches introduces SVA (Shared Virtual Addressing) support for vDPA device. During vDPA device allocation, vDPA device driver needs to indicate whether SVA

Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Jason Wang
On 2021/1/27 下午5:11, Yongji Xie wrote: On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: On 2021/1/20 下午2:52, Yongji Xie wrote: On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: Now we have a global percpu counter to limit the recursion depth of

Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices

2021-01-27 Thread Jason Wang
On 2021/1/27 下午4:57, Stefano Garzarella wrote: On Wed, Jan 27, 2021 at 11:33:03AM +0800, Jason Wang wrote: On 2021/1/20 下午7:08, Stefano Garzarella wrote: On Wed, Jan 20, 2021 at 11:46:38AM +0800, Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: With VDUSE, we should be able to

Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Jason Wang
On 2021/1/27 下午4:50, Yongji Xie wrote: On Tue, Jan 26, 2021 at 4:09 PM Jason Wang wrote: On 2021/1/19 下午1:07, Xie Yongji wrote: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In

Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Jason Wang
On 2021/1/28 上午11:52, Yongji Xie wrote: On Thu, Jan 28, 2021 at 11:05 AM Jason Wang wrote: On 2021/1/27 下午5:11, Yongji Xie wrote: On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: On 2021/1/20 下午2:52, Yongji Xie wrote: On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: On 2021/1/19 下

Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Jason Wang
On 2021/1/28 下午2:03, Yongji Xie wrote: + +static const struct file_operations vduse_domain_fops = { + .mmap = vduse_domain_mmap, + .release = vduse_domain_release, +}; It's better to explain the reason for introducing a dedicated file for mmap() here. To make the implementation of io

Re: [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue

2021-01-28 Thread Jason Wang
On 2021/1/28 下午9:41, Eli Cohen wrote: suspend_vq should only suspend the VQ on not save the current available index. This is done when a change of map occurs when the driver calls save_channel_info(). Signed-off-by: Eli Cohen Acked-by: Jason Wang --- drivers/vdpa/mlx5/net

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-28 Thread Jason Wang
On 2021/1/28 下午9:41, Eli Cohen wrote: When a change of memory map occurs, the hardware resources are destroyed and then re-created again with the new memory map. In such case, we need to restore the hardware available and used indices. The driver failed to restore the used index which is added

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Jason Wang
On 2021/2/1 上午2:55, Eli Cohen wrote: On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote: On 2021/1/28 下午9:41, Eli Cohen wrote: When a change of memory map occurs, the hardware resources are destroyed and then re-created again with the new memory map. In such case, we need to restore

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Jason Wang
On 2021/2/1 下午1:52, Eli Cohen wrote: On Mon, Feb 01, 2021 at 11:36:23AM +0800, Jason Wang wrote: On 2021/2/1 上午2:55, Eli Cohen wrote: On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote: On 2021/1/28 下午9:41, Eli Cohen wrote: When a change of memory map occurs, the hardware resources

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Jason Wang
On 2021/2/1 下午2:38, Eli Cohen wrote: On Mon, Feb 01, 2021 at 02:00:35PM +0800, Jason Wang wrote: On 2021/2/1 下午1:52, Eli Cohen wrote: On Mon, Feb 01, 2021 at 11:36:23AM +0800, Jason Wang wrote: On 2021/2/1 上午2:55, Eli Cohen wrote: On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-01 Thread Jason Wang
On 2021/1/29 上午8:21, Wei Wang wrote: With the implementation of napi-tx in virtio driver, we clean tx descriptors from rx napi handler, for the purpose of reducing tx complete interrupts. But this could introduce a race where tx complete interrupt has been raised, but the handler found there is

Re: [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue

2021-02-01 Thread Jason Wang
On 2021/2/2 上午3:17, Si-Wei Liu wrote: On Mon, Feb 1, 2021 at 10:51 AM Si-Wei Liu wrote: On Thu, Jan 28, 2021 at 5:46 AM Eli Cohen wrote: suspend_vq should only suspend the VQ on not save the current available index. This is done when a change of map occurs when the driver calls save_channel

Re: [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue

2021-02-01 Thread Jason Wang
On 2021/2/2 下午12:15, Si-Wei Liu wrote: On Mon, Feb 1, 2021 at 7:13 PM Jason Wang wrote: On 2021/2/2 上午3:17, Si-Wei Liu wrote: On Mon, Feb 1, 2021 at 10:51 AM Si-Wei Liu wrote: On Thu, Jan 28, 2021 at 5:46 AM Eli Cohen wrote: suspend_vq should only suspend the VQ on not save the current

Re: [RFC v4 01/11] eventfd: Increase the recursion depth of eventfd_signal()

2021-03-02 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Increase the recursion depth of eventfd_signal() to 1. This is the maximum recursion depth we have found so far. Signed-off-by: Xie Yongji Acked-by: Jason Wang It might be useful to explain how/when we can reach for this condition. Thanks

Re: [RFC v4 02/11] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-03-02 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Use vhost_dev->mutex to protect vhost device iotlb from concurrent access. Fixes: 4c8cf318("vhost: introduce vDPA-based backend") Signed-off-by: Xie Yongji --- drivers/vhost/vdpa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/vhost/v

Re: [RFC v4 04/11] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map()

2021-03-02 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Add an opaque pointer for DMA mapping. Suggested-by: Jason Wang Signed-off-by: Xie Yongji Acked-by: Jason Wang --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 6 +++--- drivers/vhost/vdpa.c | 2 +- include/linux/vdpa.h | 2

Re: [RFC v4 03/11] vhost-iotlb: Add an opaque pointer for vhost IOTLB

2021-03-02 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Add an opaque pointer for vhost IOTLB. And introduce vhost_iotlb_add_range_ctx() to accept it. Suggested-by: Jason Wang Signed-off-by: Xie Yongji Acked-by: Jason Wang --- drivers/vhost/iotlb.c | 20 include/linux

[PATCH] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
When CAP_IPC_LOCK is set we should not check locked memory against rlimit as what has been implemented in mlock(). Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index

[PATCH V2] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
ility. " Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend") Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index ef688c8c0e0e..e93572e2e344 100644 --- a/

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-02 Thread Jason Wang
On 2021/3/2 5:47 下午, Michael S. Tsirkin wrote: On Mon, Mar 01, 2021 at 11:56:50AM +0800, Jason Wang wrote: On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: Detecting it isn't enough though, we will need a new ioctl to notif

Re: [PATCH] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
On 2021/3/2 5:51 下午, Michael S. Tsirkin wrote: On Tue, Mar 02, 2021 at 04:14:18AM -0500, Jason Wang wrote: When CAP_IPC_LOCK is set we should not check locked memory against rlimit as what has been implemented in mlock(). Signed-off-by: Jason Wang Indeed and it's not just

Re: [RFC v4 05/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-03 Thread Jason Wang
mapping. And corresponding vma->vm_file and offset will be also passed as an opaque pointer. Suggested-by: Jason Wang Signed-off-by: Xie Yongji --- drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- drivers/vdpa/vdpa.c | 9 +++- driv

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This implements a MMU-based IOMMU driver to support mapping kernel dma buffer into userspace. The basic idea behind it is treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set up MMU mapping instead of IOMMU mapping for the DMA transfer so that t

Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the control path, the VDUSE driver will make use of message mechnism to forward the config opera

Re: [RFC v4 09/11] Documentation: Add documentation for VDUSE

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: VDUSE (vDPA Device in Userspace) is a framework to support implementing software-emulated vDPA devices in userspace. This document is intended to clarify the VDUSE design and usage. Signed-off-by: Xie Yongji --- Documentation/userspace-api/index.rst |

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This patch introduces a workqueue to support injecting virtqueue's interrupt asynchronously. This is mainly for performance considerations which makes sure the push() and pop() for used vring can be asynchronous. Do you have pref numbers for this patch

Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support injecting virtqueue's interrupt to the specified cpu. How userspace know which CPU is this irq for? It looks to me we need to do it at different level. E.g introduce some API in sys to all

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote: On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/4 9:50 下午, Cornelia Huck wrote: On Thu, 4 Mar 2021 16:24:16 +0800 Jason Wang wrote: On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/4 4:58 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: This patch introduces a workqueue to support injecting virtqueue's interrupt asynchronously. This is mainly for performance considerations which makes sur

Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-04 Thread Jason Wang
On 2021/3/4 4:19 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 3:30 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support injecting virtqueue's interrupt to the specified cpu. How userspace know which CPU is this ir

Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-04 Thread Jason Wang
On 2021/3/4 4:05 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 2:27 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Jason Wang
On 2021/3/4 1:12 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 12:21 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: This implements a MMU-based IOMMU driver to support mapping kernel dma buffer into userspace. The basic idea behind it is treating MMU (VA->PA) as IOMMU (I

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/5 11:30 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: On 2021/3/4 4:58 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: This patch introduces a workqueue to support injecting virtqueue&#

Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-04 Thread Jason Wang
On 2021/3/5 11:37 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:11 AM Jason Wang wrote: On 2021/3/4 4:19 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 3:30 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/5 2:36 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: On 2021/3/5 11:30 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: On 2021/3/4 4:58 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: On 2021/2/23 7:50

Re: [PATCH v5 net-next] virtio-net: support XDP when not more queues

2021-03-04 Thread Jason Wang
On 2021/3/1 11:22 上午, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to allocate a separate queue for XDP_TX/XDP_REDIRECT, then xdp cannot be loaded to work, even xd

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Jason Wang
On 2021/3/5 3:13 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: On 2021/3/5 2:15 下午, Yongji Xie wrote: Sorry if I've asked this before. But what's the reason for maintaing a dedicated IOTLB here? I think we could reuse vduse_dev->iommu since the devi

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/5 3:27 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: On 2021/3/5 2:36 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: On 2021/3/5 11:30 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: On 2021/3/4 4:58 下

Re: [PATCH 1/3] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-07 Thread Jason Wang
ifcvf_vdpa_get_vendor_id(struct vdpa_device *vdpa_dev) { - return IFCVF_SUBSYS_VENDOR_ID; + struct ifcvf_adapter *adapter = vdpa_to_adapter(vdpa_dev); + struct pci_dev *pdev = adapter->pdev; + + return pdev->subsystem_vendor; } Acked-by: Jason Wang stat

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-07 Thread Jason Wang
On 2021/3/5 10:19 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA. C5000X-PL vendor id 0x1AF4, device id 0x1000, subvendor id 0x8086, sub device id 0x0001 To distinguish C5000X-PL from other ifcvf driven devices, the original ifcvf device is named

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Jason Wang
On 2021/3/5 4:12 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: On 2021/3/5 3:27 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: On 2021/3/5 2:36 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: On 2021/3/5 11:30 上午

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Jason Wang
On 2021/3/5 3:59 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: On 2021/3/5 3:13 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: On 2021/3/5 2:15 下午, Yongji Xie wrote: Sorry if I've asked this before. But what's the reason for m

Re: [PATCH v6 net-next] virtio-net: support XDP when not more queues

2021-03-07 Thread Jason Wang
Wang) 2. add note for why not lock. (suggested by Jason Wang) 3. Use variable 'flag' to record with or without locked. It is not safe to use curr_queue_pairs in "virtnet_put_xdp_sq", because it may changed after "virtnet_get_xdp_sq". v5

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Jason Wang
On 2021/3/8 11:45 上午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: On 2021/3/5 3:59 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: On 2021/3/5 3:13 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: On 2021/3/5 2:15 下午

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Jason Wang
On 2021/3/8 12:50 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: On 2021/3/5 4:12 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: On 2021/3/5 3:27 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: On 2021/3/5 2:36 下午

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Jason Wang
On 2021/3/8 1:05 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:52 AM Jason Wang wrote: On 2021/3/8 11:45 上午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: On 2021/3/5 3:59 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: On 2021/3/5 3:13 下

Re: [PATCH v6 net-next] virtio-net: support XDP when not more queues

2021-03-07 Thread Jason Wang
On 2021/3/8 1:43 下午, Xuan Zhuo wrote: On Mon, 8 Mar 2021 11:41:03 +0800, Jason Wang wrote: On 2021/3/5 6:29 下午, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Jason Wang
On 2021/3/8 3:16 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 3:02 PM Jason Wang wrote: On 2021/3/8 12:50 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: On 2021/3/5 4:12 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: On 2021/3/5 3:27 下午

Re: [PATCH v7 net-next] virtio-net: support XDP when not more queues

2021-03-08 Thread Jason Wang
(suggested by Jason Wang) v6: 1. use __netif_tx_acquire()/__netif_tx_release(). (suggested by Jason Wang) 2. add note for why not lock. (suggested by Jason Wang) 3. Use variable 'flag' to record with or without locked. It is not safe to use curr_queue_pairs in "vir

Re: [PATCH V2 1/4] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4

Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 5 + drivers/vdpa/ifcvf/ifcvf_main.c | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/vdpa

Re: [PATCH V2 3/4] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan Acked-by: Jason Wang You probably need to rename the drive

Re: [PATCH V2 4/4] vDPA/ifcvf: remove the version number string

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit removes the version number string, using kernel version is enough. Signed-off-by: Zhu Lingshan --- Acked-by: Jason Wang drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/vdpa/ifcvf

Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-08 Thread Jason Wang
On 2021/3/9 10:28 上午, Zhu, Lingshan wrote: On 3/9/2021 10:23 AM, Jason Wang wrote: On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.h | 5 +   drivers/vdpa

Re: [PATCH v7 net-next] virtio-net: support XDP when not more queues

2021-03-08 Thread Jason Wang
On 2021/3/9 10:31 上午, Xuan Zhuo wrote: On Tue, 9 Mar 2021 10:17:16 +0800, Jason Wang wrote: On 2021/3/8 4:52 下午, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible

Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-10 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: + + switch (cmd) { + case VDUSE_IOTLB_GET_FD: { + struct vduse_iotlb_entry entry; + struct vhost_iotlb_map *map; + struct vdpa_map_file *map_file; + struct file *f = NULL; + +

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this when set features. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.c | 8 drivers/vdpa/ifcvf/ifcvf_base.h | 1 + drivers/vdpa/ifcvf/ifcvf_main.c | 5

Re: [PATCH V3 1/6] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 8 drivers/vdpa/ifcvf/ifcvf_main

Re: [PATCH V3 1/6] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-10 Thread Jason Wang
On 2021/3/11 12:21 下午, Zhu Lingshan wrote: On 3/11/2021 11:23 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan

Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-10 Thread Jason Wang
On 2021/3/11 12:23 下午, Zhu Lingshan wrote: On 3/11/2021 11:25 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-o

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-10 Thread Jason Wang
On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this when set features. Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.c

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-11 Thread Jason Wang
On 2021/3/11 3:19 下午, Zhu, Lingshan wrote: On 3/11/2021 2:20 PM, Jason Wang wrote: On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this

Re: [PATCH 1/2] vhost-vdpa: fix use-after-free of v->config_ctx

2021-03-11 Thread Jason Wang
y_SYSCALL_64_after_hwframe+0x44/0xae Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") Cc: lingshan@intel.com Cc: sta...@vger.kernel.org Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa.c | 4 +++- 1 file changed, 3 insertion

Re: [PATCH 2/2] vhost-vdpa: set v->config_ctx to NULL if eventfd_ctx_fdget() fails

2021-03-11 Thread Jason Wang
is case to avoid to use an invalid pointer in other functions such as vhost_vdpa_config_put(). Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") Cc: lingshan@intel.com Cc: sta...@vger.kernel.org Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- d

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-11 Thread Jason Wang
On 2021/3/12 2:40 下午, Zhu, Lingshan wrote: On 3/12/2021 1:52 PM, Jason Wang wrote: On 2021/3/11 3:19 下午, Zhu, Lingshan wrote: On 3/11/2021 2:20 PM, Jason Wang wrote: On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu

Re: [net-next PATCH 07/10] virtio_net: Update driver to use ethtool_sprintf

2021-03-14 Thread Jason Wang
ethtool_sprintf(&p, "tx_queue_%u_%s", i, + virtnet_sq_stats_desc[j].desc); } break; } Acked-by: Jason Wang

Re: [PATCH] vhost: Fix vhost_vq_reset()

2021-03-15 Thread Jason Wang
_le(vq); vhost_disable_cross_endian(vq); And so user_be is used before being set. To fix that, reverse the lines order as there is no other dependency between them. Signed-off-by: Laurent Vivier Acked-by: Jason Wang --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue

2021-02-02 Thread Jason Wang
, Jason Wang wrote: On 2021/2/2 下午12:15, Si-Wei Liu wrote: On Mon, Feb 1, 2021 at 7:13 PM Jason Wang wrote: On 2021/2/2 上午3:17, Si-Wei Liu wrote: On Mon, Feb 1, 2021 at 10:51 AM Si-Wei Liu wrote: On Thu, Jan 28, 2021 at 5:46 AM Eli Cohen wrote: suspend_vq should only suspend the VQ on not

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-02 Thread Jason Wang
On 2021/2/2 下午10:37, Willem de Bruijn wrote: On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: On 2021/1/29 上午8:21, Wei Wang wrote: With the implementation of napi-tx in virtio driver, we clean tx descriptors from rx napi handler, for the purpose of reducing tx complete interrupts. But

Re: [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue

2021-02-03 Thread Jason Wang
On 2021/2/4 上午7:19, Si-Wei Liu wrote: On Tue, Feb 2, 2021 at 9:16 PM Jason Wang wrote: On 2021/2/3 上午1:54, Si-Wei Liu wrote: On Tue, Feb 2, 2021 at 1:23 AM Eli Cohen wrote: On Tue, Feb 02, 2021 at 12:38:51AM -0800, Si-Wei Liu wrote: Thanks Eli and Jason for clarifications. See inline

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-03 Thread Jason Wang
On 2021/2/4 上午2:28, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: On 2021/2/2 下午10:37, Willem de Bruijn wrote: On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: On 2021/1/29 上午8:21, Wei Wang wrote: With the implementation of napi-tx in virtio driver, we clean

Re: [PATCH iproute2-next v3 0/5] Add vdpa device management tool

2021-02-03 Thread Jason Wang
On 2021/2/2 下午6:35, Parav Pandit wrote: Linux vdpa interface allows vdpa device management functionality. This includes adding, removing, querying vdpa devices. vdpa interface also includes showing supported management devices which support such operations. This patchset includes kernel uapi

Re: [PATCH iproute2-next v3 0/5] Add vdpa device management tool

2021-02-04 Thread Jason Wang
On 2021/2/4 下午7:15, Adrian Moreno wrote: Sorry I have not followed this work as close as I would have wanted. Some questions below. On 2/4/21 4:16 AM, Jason Wang wrote: On 2021/2/2 下午6:35, Parav Pandit wrote: Linux vdpa interface allows vdpa device management functionality. This includes

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-04 Thread Jason Wang
ned-off-by: Eli Cohen --- v0 -> v1: Clear indices upon device reset Acked-by: Jason Wang drivers/vdpa/mlx5/net/mlx5_vnet.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 88dde3455bfd.

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-07 Thread Jason Wang
On 2021/2/5 上午4:50, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 10:06 PM Jason Wang wrote: On 2021/2/4 上午2:28, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: On 2021/2/2 下午10:37, Willem de Bruijn wrote: On Mon, Feb 1, 2021 at 10:09 PM Jason Wang wrote: On

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-07 Thread Jason Wang
On 2021/2/6 上午7:07, Si-Wei Liu wrote: On 2/3/2021 11:36 PM, Eli Cohen wrote: When a change of memory map occurs, the hardware resources are destroyed and then re-created again with the new memory map. In such case, we need to restore the hardware available and used indices. The driver failed

Re: [PATCH 2/3] mlx5_vdpa: fix feature negotiation across device reset

2021-02-07 Thread Jason Wang
reset and feature negotiation, causing frames with bogus (incomplete) checksum transmitted on the wire. Signed-off-by: Si-Wei Liu Acked-by: Jason Wang --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdp

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-07 Thread Jason Wang
ng of avail_index to until the device is to be started, i.e. until VIRTIO_CONFIG_S_DRIVER_OK is set again in set_status(). Fixes: b35ccebe3ef7 ("vdpa/mlx5: Restore the hardware used index after change map") Signed-off-by: Si-Wei Liu Acked-by: Jason Wang --- drivers/vdpa/mlx5/

Re: [PATCH 1/3] mlx5_vdpa: should exclude header length and fcs from mtu

2021-02-07 Thread Jason Wang
t includes extra lengths starting from the Ethernet header up to the FCS altogether. Fix the MTU so packets won't get dropped silently. Signed-off-by: Si-Wei Liu Acked-by: Jason Wang --- drivers/vdpa/mlx5/core/mlx5_vdpa.h | 4 drivers/vdpa/mlx5/net/mlx5_vnet.c | 15

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-08 Thread Jason Wang
On 2021/2/8 下午2:37, Eli Cohen wrote: On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote: On 2021/2/6 上午7:07, Si-Wei Liu wrote: On 2/3/2021 11:36 PM, Eli Cohen wrote: When a change of memory map occurs, the hardware resources are destroyed and then re-created again with the new

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-08 Thread Jason Wang
On 2021/2/8 下午6:04, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote: On 2021/2/8 下午2:37, Eli Cohen wrote: On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote: On 2021/2/6 上午7:07, Si-Wei Liu wrote: On 2/3/2021 11:36 PM, Eli Cohen wrote: When a change of

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-08 Thread Jason Wang
On 2021/2/9 上午3:08, Willem de Bruijn wrote: On Sun, Feb 7, 2021 at 10:29 PM Jason Wang wrote: On 2021/2/5 上午4:50, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 10:06 PM Jason Wang wrote: On 2021/2/4 上午2:28, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: On

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-08 Thread Jason Wang
On 2021/2/6 下午8:29, Si-Wei Liu wrote: While virtq is stopped, get_vq_state() is supposed to be called to get sync'ed with the latest internal avail_index from device. The saved avail_index is used to restate the virtq once device is started. Commit b35ccebe3ef7 introduced the clear_vir

Re: [PATCH RFC v2 2/4] virtio-net: support receive timestamp

2021-02-08 Thread Jason Wang
On 2021/2/9 上午2:55, Willem de Bruijn wrote: From: Willem de Bruijn Add optional PTP hardware rx timestamp offload for virtio-net. Accurate RTT measurement requires timestamps close to the wire. Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the virtio-net header is expanded

Re: [PATCH RFC v2 3/4] virtio-net: support transmit timestamp

2021-02-08 Thread Jason Wang
On 2021/2/9 上午2:55, Willem de Bruijn wrote: From: Willem de Bruijn Add optional PTP hardware tx timestamp offload for virtio-net. Accurate RTT measurement requires timestamps close to the wire. Introduce virtio feature VIRTIO_NET_F_TX_TSTAMP, the transmit equivalent to VIRTIO_NET_F_RX_TSTAMP

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-08 Thread Jason Wang
On 2021/2/9 下午2:12, Eli Cohen wrote: On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote: On 2021/2/8 下午6:04, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote: On 2021/2/8 下午2:37, Eli Cohen wrote: On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-09 Thread Jason Wang
On 2021/2/10 上午10:30, Si-Wei Liu wrote: On 2/8/2021 10:37 PM, Jason Wang wrote: On 2021/2/9 下午2:12, Eli Cohen wrote: On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote: On 2021/2/8 下午6:04, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote: On 2021/2/8

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-09 Thread Jason Wang
On 2021/2/10 上午8:26, Si-Wei Liu wrote: On 2/8/2021 7:37 PM, Jason Wang wrote: On 2021/2/6 下午8:29, Si-Wei Liu wrote: While virtq is stopped,  get_vq_state() is supposed to be  called to  get  sync'ed  with  the latest internal avail_index from device. The saved avail_index is us

Re: [PATCH RFC v2 2/4] virtio-net: support receive timestamp

2021-02-09 Thread Jason Wang
On 2021/2/9 下午9:53, Willem de Bruijn wrote: On Mon, Feb 8, 2021 at 11:13 PM Jason Wang wrote: On 2021/2/9 上午2:55, Willem de Bruijn wrote: From: Willem de Bruijn Add optional PTP hardware rx timestamp offload for virtio-net. Accurate RTT measurement requires timestamps close to the wire

Re: [PATCH RFC v2 3/4] virtio-net: support transmit timestamp

2021-02-09 Thread Jason Wang
On 2021/2/10 上午12:38, Michael S. Tsirkin wrote: On Tue, Feb 09, 2021 at 01:45:11PM +0800, Jason Wang wrote: On 2021/2/9 上午2:55, Willem de Bruijn wrote: From: Willem de Bruijn Add optional PTP hardware tx timestamp offload for virtio-net. Accurate RTT measurement requires timestamps close

Re: [PATCH RFC v2 3/4] virtio-net: support transmit timestamp

2021-02-09 Thread Jason Wang
On 2021/2/10 上午10:36, Willem de Bruijn wrote: On Tue, Feb 9, 2021 at 11:39 AM Michael S. Tsirkin wrote: On Tue, Feb 09, 2021 at 01:45:11PM +0800, Jason Wang wrote: On 2021/2/9 上午2:55, Willem de Bruijn wrote: From: Willem de Bruijn Add optional PTP hardware tx timestamp offload for virtio

Re: [PATCH V4 1/7] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions

Re: [PATCH V4 2/7] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.h | 5 + drivers/vdpa/ifcvf/ifcvf_main.c | 5 + 2 files changed, 10 insertions

Re: [PATCH V4 3/7] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan Acked-by: Jason Wang If you want to have a general driver, you proba

Re: [PATCH V4 4/7] vDPA/ifcvf: remove the version number string

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: This commit removes the version number string, using kernel version is enough. Signed-off-by: Zhu Lingshan Reviewed-by: Leon Romanovsky Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git

<    1   2   3   4   5   6   7   8   9   10   >