[PATCH] net: Removing duplicit #includes

Removing duplicit #includes for net/ Signed-off-by: Jiri Olsa [EMAIL PROTECTED] --- net/core/dst.c |1 - net/ieee80211/ieee80211_crypt_tkip.c |1 - net/ieee80211/ieee80211_crypt_wep.c |1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/net/core

[PATCH] net: Removing duplicit #includes

Removing duplicit #includes for net/ Signed-off-by: Jiri Olsa [EMAIL PROTECTED] --- net/core/dst.c |1 - net/ieee80211/ieee80211_crypt_tkip.c |1 - net/ieee80211/ieee80211_crypt_wep.c |1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/net/core

Re: [PATCH] net: Removing duplicit #includes

sorry, the patch is mangled, I will resend another Jiri Olsa wrote: Removing duplicit #includes for net/ Signed-off-by: Jiri Olsa [EMAIL PROTECTED] --- net/core/dst.c |1 - net/ieee80211/ieee80211_crypt_tkip.c |1 - net/ieee80211/ieee80211_crypt_wep.c |1

Re: [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms

On Wed, Oct 28, 2015 at 10:55:02AM +, Wang Nan wrote: SNIP > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index f820906..397fb4e 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -653,6 +653,15 @@ static void apply_config_terms(struct perf_evsel

Re: [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms

On Wed, Oct 28, 2015 at 10:42:13AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 28, 2015 at 02:21:26PM +0100, Jiri Olsa escreveu: > > On Wed, Oct 28, 2015 at 10:55:02AM +, Wang Nan wrote: > > > @@ -55,6 +56,7 @@ struct perf_evsel_config_term { > >

Re: linux-next: build failure after merge of the net tree

On Tue, Feb 14, 2017 at 07:42:21AM +0100, Ingo Molnar wrote: > > * Stephen Rothwell wrote: > > > Hi all, > > > > After merging the net tree, today's linux-next build (powerpc64le perf) > > failed like this: > > > > Warning: tools/include/uapi/linux/bpf.h differs from

Re: linux-next: build failure after merge of the net tree

On Tue, Feb 14, 2017 at 09:50:20AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > What I think Ingo meant with dependency at the build system level is to > somehow state that if file A gets changed, then tool B must be rebuilt. > > Now that samples/bpf and tools/perf/ depend on tools/lib/bpf/

Re: [PATCHv3 3/3] tools bpftool: Display license GPL compatible in prog show/list

On Thu, Apr 26, 2018 at 10:49:25PM +0200, Daniel Borkmann wrote: > On 04/26/2018 10:18 AM, Jiri Olsa wrote: > [...] > > v3 of the last patch attached, the branch is also updated > > > > thanks, > > jirka > > > > > > --- > > Display

Re: [PATCH 3/3] tools bpftool: Display license GPL compatible in prog show/list

On Wed, Apr 25, 2018 at 11:14:30PM +0200, Daniel Borkmann wrote: > On 04/25/2018 11:03 PM, Jakub Kicinski wrote: > > On Wed, 25 Apr 2018 19:41:08 +0200, Jiri Olsa wrote: > >> @@ -295,6 +297,7 @@ static void print_prog_plain(struct bpf_prog_info > >> *info,

Re: [PATCH 3/3] tools bpftool: Display license GPL compatible in prog show/list

On Wed, Apr 25, 2018 at 02:03:46PM -0700, Jakub Kicinski wrote: > On Wed, 25 Apr 2018 19:41:08 +0200, Jiri Olsa wrote: > > @@ -295,6 +297,7 @@ static void print_prog_plain(struct bpf_prog_info > > *info, int fd) > > printf("tag "); > > fprin

[PATCHv3 3/3] tools bpftool: Display license GPL compatible in prog show/list

On Thu, Apr 26, 2018 at 09:53:26AM +0200, Daniel Borkmann wrote: > On 04/26/2018 09:39 AM, Jiri Olsa wrote: > > On Wed, Apr 25, 2018 at 11:14:30PM +0200, Daniel Borkmann wrote: > >> On 04/25/2018 11:03 PM, Jakub Kicinski wrote: > >>> On Wed, 25 Apr 2018 1

[RFC 0/9] bpf: Add buildid check support

ction: # cat ./bpf-samples/bpf-stdout-example.c ... #include char _buildid[] SEC("buildid") = LINUX_BUILDID_DATA; ... where LINUX_BUILDID_DATA is defined in the generated buildid.h. please note it's an RFC ;-) any comments and suggestions are welcome thank

[PATCH 4/9] kbuild: Add filechk2 function

Adding filechk2 function that has the same semantics as filechk, but it takes the target file from the 2nd argument instead of from the '$@' as in the filechk function. This function is needed when we can't have separate target for the file, like in the following patch. Signed-off-by: Jiri Olsa

[PATCH 2/9] perf tools: Add fetch_kernel_buildid function

Adding fetch_kernel_buildid helper function to retrieve build id from running kernel. It will be used in following patches. Link: http://lkml.kernel.org/n/tip-at98orsncas8v2ito61u3...@git.kernel.org Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/perf/util/util.

[PATCH 1/9] perf tools: Make read_build_id function public

And renaming it into parse_notes_buildid to be more precise and usable in following patches. Link: http://lkml.kernel.org/n/tip-v1mz76rkdxfnbfz2v05fu...@git.kernel.org Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/perf/util/symbol-minimal.

[PATCH 8/9] libbpf: Add support to attach buildid to program load

rnel.org/n/tip-2pafwtzbyosmf9ftuf0ud...@git.kernel.org Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/bpf/bpftool/Makefile | 5 - tools/lib/bpf/bpf.c| 6 -- tools/lib/bpf/bpf.h| 5 +++-- tools/lib/bpf/libbpf.c | 46 +

[PATCH 6/9] bpf: Add CONFIG_BPF_BUILDID_CHECK option

the buildid. Kernel expose the notes section via sysfs, but there's currently no other use for kernel's buildid, so I needed to add new __init buildid_init function to parse it out. Signed-off-by: Jiri Olsa <jo...@kernel.org> --- include/uapi/linux/bpf.h | 2 ++ init/Kconfig

[PATCH 9/9] perf tools: The buildid usage in example eBPF program

The bpf-samples/bpf-stdout-example.c demonstrates how to put the buildid data into eBPF program. Link: http://lkml.kernel.org/n/tip-dq97ddil7h3qbvphbbo8p...@git.kernel.org Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/perf/bpf-samples/bpf-stdout-example.

[PATCH 7/9] libbpf: Synchronize uapi bpf.h header

Synchronize include/uapi/linux/bpf.h with tools version. Link: http://lkml.kernel.org/n/tip-gaja0nnet6oku657642nx...@git.kernel.org Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/include/uapi/linux/bpf.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/include/uapi/linux

[PATCH 5/9] bpf: Add CONFIG_BUILDID_H option

LD vmlinux SORTEX vmlinux SYSMAP System.map CHK include/generated/uapi/linux/buildid.h UPD include/generated/uapi/linux/buildid.h ... Signed-off-by: Jiri Olsa <jo...@kernel.org> --- Makefile | 12 init/Kconfig

[PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

There's no need to pass LD* arguments to link-vmlinux.sh, because they are passed as variables. The only argument the link-vmlinux.sh supports is the 'clean' argument. Signed-off-by: Jiri Olsa <jo...@kernel.org> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [RFC 0/9] bpf: Add buildid check support

On Thu, Apr 05, 2018 at 06:37:23PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 05, 2018 at 05:16:36PM +0200, Jiri Olsa wrote: > > hi, > > eBPF programs loaded for kprobes are allowed to read kernel > > internal structures. We check the provided kernel version > >

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

On Fri, Apr 06, 2018 at 09:59:59AM +0900, Masahiro Yamada wrote: > 2018-04-06 3:59 GMT+09:00 Jiri Olsa <jo...@redhat.com>: > > On Fri, Apr 06, 2018 at 12:50:00AM +0900, Masahiro Yamada wrote: > >> 2018-04-06 0:16 GMT+09:00 Jiri Olsa <jo...@kernel.org>: > >>

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

On Fri, Apr 06, 2018 at 12:50:00AM +0900, Masahiro Yamada wrote: > 2018-04-06 0:16 GMT+09:00 Jiri Olsa <jo...@kernel.org>: > > There's no need to pass LD* arguments to link-vmlinux.sh, > > because they are passed as variables. The only argument > > the link-vmlinu

Re: [PATCH 0/3] bpf: Store/dump license string for loaded program

On Mon, Apr 23, 2018 at 02:11:36PM -0600, Alexei Starovoitov wrote: > On Mon, Apr 23, 2018 at 08:59:24AM +0200, Jiri Olsa wrote: > > hi, > > sending the change to store and dump the license > > info for loaded BPF programs. It's important for > > us get the licen

[PATCH 1/3] bpf: Store license string for loaded program

Storing the license string provided loaded program, so it can be provided back when dumping the loaded programs info (added in following change). Signed-off-by: Jiri Olsa <jo...@kernel.org> --- include/linux/bpf.h | 1 + include/uapi/linux/bpf.h | 3 +++ kernel/bpf/core.c

[PATCH 0/3] bpf: Store/dump license string for loaded program

ps://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git bpf/license thanks, jirka --- Jiri Olsa (3): bpf: Store license string for loaded program tools bpf: Sync bpf.h uapi header tools bpftool: Display license in prog show/list include/linux/bpf.h| 1 + include/u

[PATCH 3/3] tools bpftool: Display license in prog show/list

t;type":"kprobe","name":"fun ... ,"license":"GPL", ... ] Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/bpf/bpftool/prog.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c

[PATCH 2/3] tools bpf: Sync bpf.h uapi header

Syncing the bpf.h uapi header with tools. Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/include/uapi/linux/bpf.h | 4 1 file changed, 4 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 7f7fbb9d0253..b7298ee177e7 100644 --- a

[PATCH 1/3] bpf: Add gpl_compatible flag to struct bpf_prog_info

space. Signed-off-by: Jiri Olsa <jo...@kernel.org> --- include/uapi/linux/bpf.h | 1 + kernel/bpf/syscall.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index e6679393b687..da8801860c7d 100644 --- a/include/uapi/linux/bpf.h

[PATCH 3/3] tools bpftool: Display license GPL compatible in prog show/list

: kprobe name func_begin tag 57cd311f2e27366b license GPL compatible loaded_at Apr 25/11:20 uid 0 xlated 16B not jited memlock 4096B # bpftool prog show --json [{"id":3,"type":"kprobe","name":"func ... ,"gpl_compati

[PATCH 2/3] tools bpf: Sync bpf.h uapi header

Syncing the bpf.h uapi header with tools. Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/include/uapi/linux/bpf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index e6679393b687..da8801860c7d 100644 --- a/tools/i

[PATCHv2 0/3] bpf: Store/dump license string for loaded program

at: https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git bpf/license thanks, jirka --- Jiri Olsa (3): bpf: Add gpl_compatible flag to struct bpf_prog_info tools bpf: Sync bpf.h uapi header tools bpftool: Display license GPL compatible in prog show/list include/uapi

Re: [PATCH 0/3] bpf: Store/dump license string for loaded program

On Wed, Apr 25, 2018 at 10:15:29AM -0600, Alexei Starovoitov wrote: > On Wed, Apr 25, 2018 at 12:17:13PM +0200, Jiri Olsa wrote: > > On Mon, Apr 23, 2018 at 02:11:36PM -0600, Alexei Starovoitov wrote: > > > On Mon, Apr 23, 2018 at 08:59:24AM +0200, Jiri Olsa wrote: > >

Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

On Thu, Mar 22, 2018 at 10:34:18AM +0100, Daniel Borkmann wrote: > On 03/21/2018 07:37 PM, Jiri Olsa wrote: > > On Wed, Mar 21, 2018 at 05:25:33PM +, Quentin Monnet wrote: > >> 2018-03-21 16:02 UTC+0100 ~ Jiri Olsa <jo...@kernel.org> > >>> We use print_bpf_

Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

On Thu, Mar 22, 2018 at 03:35:42PM +, Quentin Monnet wrote: > 2018-03-22 14:32 UTC+0100 ~ Jiri Olsa <jo...@redhat.com> > > On Thu, Mar 22, 2018 at 10:34:18AM +0100, Daniel Borkmann wrote: > >> On 03/21/2018 07:37 PM, Jiri Olsa wrote: > >>> On Wed, Mar 2

Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

On Wed, Mar 21, 2018 at 05:25:33PM +, Quentin Monnet wrote: > 2018-03-21 16:02 UTC+0100 ~ Jiri Olsa <jo...@kernel.org> > > We use print_bpf_insn in user space (bpftool and soon perf), > > so it'd be nice to keep it generic and strip it off the kernel > > struc

[PATCHv2 2/2] bpftool: Adjust to new print_bpf_insn interface

s NULL anyway. No functional change intended. Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/bpf/bpftool/xlated_dumper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/bpf/bpftool/xlated_dumper.c b/tools/bpf/bpftool/xlated_dumper.c index 20da83

[PATCH 2/2] bpftool: Adjust to new print_bpf_insn interface

Change bpftool to skip the removed struct bpf_verifier_env argument in print_bpf_insn. It was passed as NULL anyway. No functional change intended. Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/bpf/bpftool/prog.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

We use print_bpf_insn in user space (bpftool and soon perf), so it'd be nice to keep it generic and strip it off the kernel struct bpf_verifier_env argument. This argument can be safely removed, because its users can use the struct bpf_insn_cbs::private_data to pass it. Signed-off-by: Jiri Olsa

[PATCH 0/2] bpf: Change print_bpf_insn interface

hi, this patchset removes struct bpf_verifier_env argument from print_bpf_insn function (patch 1) and changes user space bpftool user to use it that way (patch 2). thanks, jirka --- Jiri Olsa (2): bpf: Remove struct bpf_verifier_env argument from print_bpf_insn bpftool: Adjust to new

[PATCH 2/2] bpftool: Adjust to new print_bpf_insn interface

Change bpftool to skip the removed struct bpf_verifier_env argument in print_bpf_insn. It was passed as NULL anyway. No functional change intended. Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/bpf/bpftool/xlated_dumper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 del

[PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

to 'verbose(void *, ...)' so no other change is needed. Signed-off-by: Jiri Olsa <jo...@kernel.org> --- kernel/bpf/disasm.c | 52 +-- kernel/bpf/disasm.h | 5 + kernel/bpf/verifier.c | 44 ++- 3 files c

Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

On Thu, Mar 22, 2018 at 05:07:48PM +0100, Daniel Borkmann wrote: SNIP > >>> + va_end(args); > >>> +} > >>> EXPORT_SYMBOL_GPL(bpf_verifier_log_write); > >>> + > >>> +__printf(2, 3) static void print_ins(void *private_data, > >>> + const char *fmt, ...) > >> > >>

Re: [PATCH 2/2] bpftool: Adjust to new print_bpf_insn interface

On Wed, Mar 21, 2018 at 04:39:09PM +, Quentin Monnet wrote: > 2018-03-21 16:02 UTC+0100 ~ Jiri Olsa <jo...@kernel.org> > > Change bpftool to skip the removed struct bpf_verifier_env > > argument in print_bpf_insn. It was passed as NULL anyway. > > > &

Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

On Fri, Oct 05, 2018 at 11:44:35AM -0700, Alexei Starovoitov wrote: > On Fri, Oct 05, 2018 at 08:14:09AM +0200, Jiri Olsa wrote: > > On Thu, Oct 04, 2018 at 03:10:15PM -0700, Alexei Starovoitov wrote: > > > On Thu, Oct 04, 2018 at 10:22:31PM +0200, Jesper Dangaard Brouer wrote:

Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

On Thu, Oct 04, 2018 at 03:10:15PM -0700, Alexei Starovoitov wrote: > On Thu, Oct 04, 2018 at 10:22:31PM +0200, Jesper Dangaard Brouer wrote: > > On Thu, 4 Oct 2018 21:41:17 +0200 Daniel Borkmann > > wrote: > > > > > On 10/04/2018 08:39 PM, Jesper Dangaard Brouer wrote: > > > > On Thu, 4 Oct

Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

On Thu, Oct 04, 2018 at 03:10:15PM -0700, Alexei Starovoitov wrote: > On Thu, Oct 04, 2018 at 10:22:31PM +0200, Jesper Dangaard Brouer wrote: > > On Thu, 4 Oct 2018 21:41:17 +0200 Daniel Borkmann > > wrote: > > > > > On 10/04/2018 08:39 PM, Jesper Dangaard Brouer wrote: > > > > On Thu, 4 Oct