Hello Johannes,
On 26 December 2015 at 10:05, João Paulo Rechi Vita <jprv...@gmail.com> wrote:
> For platform drivers to be able to correctly drive the "Airplane Mode"
> indicative LED there needs to be a RFKill LED trigger tied to the global
> state of RFKILL_TYPE_ALL
by the maintainers).
João Paulo Rechi Vita (1):
net/rfkill: Create "airplane mode" LED trigger
net/rfkill/core.c | 30 ++
1 file changed, 30 insertions(+)
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of
s, the
LED is ON when the state is blocked, and OFF otherwise.
This commit implements such a trigger, which will be used by the
asus-wireless x86 platform driver.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.c | 30 ++
1 file change
On 18 December 2015 at 19:22, Darren Hart <dvh...@infradead.org> wrote:
> On Tue, Dec 15, 2015 at 10:30:41AM -0500, João Paulo Rechi Vita wrote:
>> For platform drivers to be able to correctly drive the "Airplane Mode"
>> indicative LED there needs to be a RFKill
w contained in the platform-drivers-x86 subsystem. Thanks
Johannes for your patience and help designing and reviewing the rfkill
changes, even if not all of them made it through in the end. And
thanks everyone else involved for the feedback.
Best regards,
--
João Paulo Rechi Vita
http://about.me/jprvita
On 13 June 2016 at 17:01, Pavel Machek <pa...@ucw.cz> wrote:
> On Mon 2016-06-13 15:59:35, João Paulo Rechi Vita wrote:
>> On 13 June 2016 at 15:00, Pavel Machek <pa...@ucw.cz> wrote:
>> > Hi!
>> >
>> >> > João, that means you should send a pat
s/class/rfkill
> /sys/module/rfkill
>
If we use "rfkill" as a suffix, how do you expect userspace to be able
to differentiate between a LED that indicates airplane-mode (LED ON
when all radios are OFF) and a LED that indicates the state of a
specific radio like WiFi or Bluetooth (L
_AIRPLANE_MODE_ACQUIRE,
_AIRPLANE_MODE_RELEASE, and _AIRPLANE_MODE_CHANGE. When the airplane-mode
indicator state changes, userspace gets notifications through the RFKill
control misc device (/dev/rfkill).
The series also contains a few general fixes and improvements to the subsystem.
João Paulo Rechi Vita (9
Factor all assignments to rfkill_global_states[].cur into a single
function rfkill_update_global_state().
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.c | 38 +-
1 file changed, 17 insertions(+), 21 deletions(-)
diff
There is still quite a bit of code using this interface, so we can't
just remove it. Hopefully it will be possible in the future, but since
its scheduled removal date is past 2 years already, we are better having
the documentation reflecting the current state of things.
Signed-off-by: João Paulo
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
Documentation/rfkill.txt | 3 +++
net/rfkill/core.c| 13 +
2 files changed, 16 insertions(+)
diff --git a/Documentation/rfkill.txt b/Documentation/rfkill.txt
index aa6e014..5248812 100644
--- a/Documen
, and to LED_OFF when the changing
the state to unblocked. In the future there will be a mechanism for
userspace to override the default policy, so it can implement its own.
This trigger will be used by the asus-wireless x86 platform driver.
Signed-off-by: João Paulo Rechi Vita <j
The "claim" sysfs interface has been removed, so its documentation now
lives in the "removed" folder.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
Documentation/ABI/stable/sysfs-class-rfkill | 6 --
1 file changed, 4 insertions(+),
RFKILL_OP_AIRPLANE_MODE_RELEASE restores the default policy.
To change state of the indicator, the RFKILL_OP_AIRPLANE_MODE_CHANGE
operation is used, passing the value on "struct rfkill_event.soft". If
the caller has not acquired the airplane-mode control beforehand, the
operation fails.
Signed-off-by: João Paulo
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index a805831..ffbc375 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -282,8 +282,8 @@
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ffbc375..56d79cb 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -455,7 +455,6 @
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
Documentation/rfkill.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/rfkill.txt b/Documentation/rfkill.txt
index 2ee6ef9..1f0c270 100644
--- a/Documentation/rfkill.txt
+++ b/Documentation/rfkill.txt
@@
se see the following message from Johannes
http://www.spinics.net/lists/linux-wireless/msg146069.html and let me
know if that covers your concern.
Thanks!
--
João Paulo Rechi Vita
http://about.me/jprvita
On 8 February 2016 at 11:11, Dan Williams <d...@redhat.com> wrote:
> On Mon, 2016-02-08 at 10:41 -0500, João Paulo Rechi Vita wrote:
>> Provide an interface for the airplane-mode indicator be controlled
>> from
>> userspace. User has to first
RFKILL_OP_AIRPLANE_MODE_RELEASE restores the default policy.
To change state of the indicator, the RFKILL_OP_AIRPLANE_MODE_CHANGE
operation is used, passing the value on "struct rfkill_event.soft". If
the caller has not acquired the airplane-mode control beforehand, the
operation fails.
Signed-off-by: João Paulo
nction?
>
Yes, makes sense. This also made me notice I was assigning a negative
value to a size_t variable (count).
>> + }
>> +
>> list_del(>list);
>> +
>
> (extra line)
>
After factoring out the _RELEASE code it looks better without this
additional line.
>> mutex_unlock(_global_mutex);
>>
>> mutex_destroy(>mtx);
>
> Thanks,
>
Thanks for the review, Julian. I'm sending an updated version.
--
João Paulo Rechi Vita
http://about.me/jprvita
.
To change state of the indicator, the
RFKILL_OP_AIRPLANE_MODE_INDICATOR_CHANGE operation is used, passing the
value on "struct rfkill_event.soft". If the caller has not acquired the
airplane-mode control beforehand, the operation fails.
Signed-off-by: João Paulo Rechi Vita <jprv...
On 22 February 2016 at 12:00, Dan Williams <d...@redhat.com> wrote:
> On Mon, 2016-02-22 at 11:36 -0500, João Paulo Rechi Vita wrote:
>> This series implements an airplane-mode indicator LED trigger, which
>> can be
>> used by platform drivers. The default policy hav
Hello Jouni,
On 26 February 2016 at 12:59, Jouni Malinen <j...@w1.fi> wrote:
> On Mon, Feb 22, 2016 at 11:36:39AM -0500, João Paulo Rechi Vita wrote:
>> Using a switch to handle different ev.op values in rfkill_fop_write()
>> makes the code easier to extend, as out-of-ra
The "claim" sysfs interface has been removed, so its documentation now
lives in the "removed" folder.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
Documentation/ABI/stable/sysfs-class-rfkill | 6 --
1 file changed, 4 insertions(+),
Using a switch to handle different ev.op values in rfkill_fop_write()
makes the code easier to extend, as out-of-range values can always be
handled by the default case.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.c | 32 ++--
.
Additionally, I have a couple of patches to have this feature supported by the
userspace tool 'rfkill' [1]. Should I use a different subject prefix to help
separate those from kernel patches in linux-wireless?
[1] https://wireless.wiki.kernel.org/en/users/documentation/rfkill
João Paulo Rechi Vita
Factor all assignments to rfkill_global_states[].cur into a single
function rfkill_update_global_state().
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.c | 38 +-
1 file changed, 17 insertions(+), 21 deletions(-)
diff
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
Documentation/rfkill.txt| 3 +++
include/uapi/linux/rfkill.h | 4 ++--
net/rfkill/core.c | 13 +
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/Documentation/rfkill.txt b/Documen
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index a805831..ffbc375 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -282,8 +282,8 @@
, and to LED_OFF when the changing
the state to unblocked. In the future there will be a mechanism for
userspace to override the default policy, so it can implement its own.
This trigger will be used by the asus-wireless x86 platform driver.
Signed-off-by: João Paulo Rechi Vita <j
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
Documentation/rfkill.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/rfkill.txt b/Documentation/rfkill.txt
index 2ee6ef9..1f0c270 100644
--- a/Documentation/rfkill.txt
+++ b/Documentation/rfkill.txt
@@
There is still quite a bit of code using this interface, so we can't
just remove it. Hopefully it will be possible in the future, but since
its scheduled removal date is past 2 years already, we are better having
the documentation reflecting the current state of things.
Signed-off-by: João Paulo
RFKILL_OP_AIRPLANE_MODE_RELEASE restores the default policy.
To change state of the indicator, the RFKILL_OP_AIRPLANE_MODE_CHANGE
operation is used, passing the value on "struct rfkill_event.soft". If
the caller has not acquired the airplane-mode control beforehand, the
operation fails.
Signed-off-by: João Paulo
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ffbc375..56d79cb 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -455,7 +455,6 @
On 18 February 2016 at 15:12, Johannes Berg <johan...@sipsolutions.net> wrote:
> Hi,
>
> Sorry for the delay reviewing this.
>
No problems!
>
> On Mon, 2016-02-08 at 10:41 -0500, João Paulo Rechi Vita wrote:
>> Provide an interface for the airplane-mode i
On 18 February 2016 at 15:08, Johannes Berg <johan...@sipsolutions.net> wrote:
> On Mon, 2016-02-08 at 10:41 -0500, João Paulo Rechi Vita wrote:
>> This creates a new LED trigger to be used by platform drivers as a
>> default trigger for airplane-mode indicator LEDs.
>>
ect the
non-polemical patches of the series, so I don't need to carry them
anymore.
--
João Paulo Rechi Vita
http://about.me/jprvita
Hello Johannes,
On 1 March 2016 at 11:15, João Paulo Rechi Vita <jprv...@gmail.com> wrote:
> On 1 March 2016 at 08:43, Johannes Berg <johan...@sipsolutions.net> wrote:
>>
>> I'm fine with Jouni's change, preserving the original behaviour of
>> requiring TYPE
continue;
>
> to ignore the type entirely.
>
> I'm fine with Jouni's change, preserving the original behaviour of
> requiring TYPE_ALL or the correct type, but I'm tempted to simply
> remove the type check entirely.
>
> Thoughts?
>
I think this patch should keep the
From: João Paulo Rechi Vita <jprv...@gmail.com>
Provide an interface for the airplane-mode indicator be controlled from
userspace. User has to first acquire the control through
RFKILL_OP_AIRPLANE_MODE_INDICATOR_ACQUIRE and keep the fd open for the
whole time it wants to be in c
From: João Paulo Rechi Vita <jprv...@gmail.com>
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
Documentation/rfkill.txt| 3 +++
include/uapi/linux/rfkill.h | 4 ++--
net/rfkill/core.c | 13 +
3 files changed, 18 insertions(+), 2 deleti
From: João Paulo Rechi Vita <jprv...@gmail.com>
This creates a new LED trigger to be used by platform drivers as a
default trigger for airplane-mode indicator LEDs.
By default this trigger will fire when RFKILL_OP_CHANGE_ALL is called
for all types (RFKILL_TYPE_ALL), setting the LED brig
rfkill_wpa2_psk 0.330014 2016-04-29 12:48:59.016711
João Paulo Rechi Vita (3):
rfkill: Create "rfkill-airplane-mode" LED trigger
rfkill: Userspace control for airplane mode
rfkill: Notify userspace of airplane-mode state changes
Documentation/rfkill.txt| 15 +++
include/uapi/linu
o the warn level helps having a clean boot process.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
v2 changes:
- Set to warn level instead of info
v3 changes:
- Fix commit message typo
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++--
1 file changed, 6
o the warn level helps having a clean boot process.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
v2 changes:
- Set to warn level instead of info
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --g
Hello Luca,
On Mon, Jul 24, 2017 at 4:01 AM, Coelho, Luciano
<luciano.coe...@intel.com> wrote:
> On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote:
(...)
>> Currently these messages are presented to the user during boot if there
>> is no bootsplash covering t
yet by the time this message is shown.
Demoting it to the info level helps having a clean boot process.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
On Tue, May 1, 2018 at 10:58 PM, Pkshih <pks...@realtek.com> wrote:
> On Wed, 2018-05-02 at 05:44 +, Pkshih wrote:
>>
>> > -Original Message-----
>> > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com]
>> > Sent: Wednesday, May 02, 2018 6:
On Tue, May 8, 2018 at 1:37 AM, Pkshih <pks...@realtek.com> wrote:
> On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote:
>> On Tue, May 1, 2018 at 10:58 PM, Pkshih <pks...@realtek.com> wrote:
>> > On Wed, 2018-05-02 at 05:44 +, Pkshih wrote:
>&
Rename these functions to rfkill_global_led_trigger*, as they are going
to be extended to handle another global rfkill led trigger.
This commit does not change any functionality.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.
Creates a new trigger rfkill-none, as a complement to rfkill-any, which
drives LEDs when any radio is enabled. The new trigger is meant to turn
a LED ON whenever all radios are OFF, and turn it OFF otherwise.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
net/rfkill/core.
] Interval Transfer Bandwidth Retr
[ 4] 0.00-10.00 sec 45.9 MBytes 38.5 Mbits/sec0 sender
[ 4] 0.00-10.00 sec 45.0 MBytes 37.7 Mbits/sec receiver
iperf Done.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.
MBytes 38.5 Mbits/sec0 sender
[ 4] 0.00-10.00 sec 45.0 MBytes 37.7 Mbits/sec receiver
iperf Done.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c | 2 --
drivers/net/wi
MBytes 37.7 Mbits/sec receiver
iperf Done.
Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com>
---
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btc
On Tue, Apr 3, 2018 at 7:51 PM, Larry Finger <larry.fin...@lwfinger.net> wrote:
> On 04/03/2018 09:37 PM, João Paulo Rechi Vita wrote:
>>
>> On Tue, Apr 3, 2018 at 7:28 PM, Larry Finger <larry.fin...@lwfinger.net>
>> wrote:
>>
>> (...)
>>
>
261 8.41 0.00
v4.15+revert d8a5b801923.861.41
v4.15+revert d8a5b80189 18.691.39
Best regards,
--
João Paulo Rechi Vita
http://about.me/jprvita
strength?
Thanks for such a quick reply,
--
João Paulo Rechi Vita
http://about.me/jprvita
58 matches
Mail list logo
