pull-request: wireless-drivers-next 2015-11-25

. This unifies the directory layout as we already had few drivers already using vendor directories (especially ath and ti). Kalle Valo (27): adm80211: move under admtek vendor directory airo: move under cisco vendor

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

d still apply without issues. >> >> Will see if that is true when I merge it in our internal repo. :-p > > Just applied the pending patches using 'git am -3' and that works > fine. So when told to be smart, git is indeed smart ;-) Git is awesome :) Thanks for checking. -- Kalle

Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

Kalle Valo <kv...@qca.qualcomm.com> writes: > Brent Taylor <moto...@gmail.com> writes: > >> Signed-off-by: Brent Taylor <moto...@gmail.com> >> >> ath6kl: Use vmalloc for loading firmware using api1 method and free using >> kvfree >> --- &

Re: [PATCH v3] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

x kmalloc build error > > Changes v1 -> v2: >- simplify memory allocation > - use kvfree The commit log in v3 is even worse. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: brcm80211: Delete an unnecessary check before the function call"release_firmware"

ted by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> > Acked-by: Arend van Spriel <ar...@broadcom.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "u

Re: next-20151126 build: 3 failures 15 warnings (next-20151126)

d also worrying, any ideas why? It would be good to understand the root cause in case there's a bug in wireless drivers directory reorganisation. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: brcmfmac: constify brcmf_bus_ops structures

> The brcmf_bus_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > Acked-by: Arend van Spriel <ar...@broadcom.com> Thanks, applied to wireless

Re: rtlwifi: Delete unnecessary checks before the function call"kfree_skb"

ted by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.o

Re: [v2] libertas: check for NULL before use

> If kzalloc fails it will return NULL. Lets check for NULL first before > using the pointer. > > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscr

Re: next-20151126 build: 3 failures 15 warnings (next-20151126)

Mark Brown <broo...@kernel.org> writes: > On Thu, Nov 26, 2015 at 02:39:40PM +0200, Kalle Valo wrote: >> Mark Brown <broo...@kernel.org> writes: > >> > It looks like this was somehow triggered as part of the reorganisation >> > of the WiFi directory s

Re: next-20151126 build: 3 failures 15 warnings (next-20151126)

Mark Brown <broo...@kernel.org> writes: > On Thu, Nov 26, 2015 at 06:58:32PM +0200, Kalle Valo wrote: >> Mark Brown <broo...@kernel.org> writes: > >> > No, I didn't make much effort to check though since the use of ifdef was >> > clearly a bug wait

[PATCH v2 26/27] ath: unify Kconfig with other vendors

Change menuconfig to config to keep the Kconfig entries unified. Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- drivers/net/wireless/Kconfig |3 +-- drivers/net/wireless/Makefile|3 +-- drivers/net/wirele

[PATCH v2 27/27] mac80211_hwsim: move Kconfig entry for sorting alphabetically

mac80211_hwsim was not placed alphabetically correctly in menuconfig, fix that. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- drivers/net/wireless/Kconfig | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/wireless/Kco

[PATCH v2 16/27] zd1211rw: move under zydas vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |1 - drivers/net/wireless/Makefile

[PATCH v2 02/27] airo: move under cisco vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- drivers/net/wireless/Kconfig | 43 + drivers/net/wireless/Makefile |4 +- drivers/net/wireless/cisco/Kconfig

[PATCH v2 03/27] atmel: move under atmel vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS |2 +- drivers/net/wireless/Kconfig| 44 + drivers/net/wireless/Ma

[PATCH v2 00/27] wireless drivers vendor directories

also a git branch which I keep up-to-date: https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/log/?h=wd-reorg Please review and send comments. v2: * move all drivers Kalle Valo (27): adm80211: move under admtek vendor directory airo: move under cisco vendor di

[PATCH v2 01/27] adm80211: move under admtek vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS |2 +- drivers/net/wireless/Kconfig| 29 ++- drivers/net/wireless/Makefile

[PATCH v2 18/27] p54: move under intersil vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |1 - drivers/net/wireless/Makefile

[PATCH v2 21/27] realtek: create separate Kconfig file

Add new a Kconfig file and a vendor config for realtek. Also update MAINTAINERS which we missed to do when earlier moving rtlwifi. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS |8 drivers/net/wireless/Kconfig |5 + d

[PATCH v2 23/27] rt2x00: move under ralink vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile

[PATCH v2 20/27] prism54: move under intersil vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig | 20 drivers/net/wireless/Ma

[PATCH v2 04/27] b43: move under broadcom vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile

[PATCH v2 22/27] rsi: add vendor Kconfig entry

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile|3 +-- drivers/net/wireless/rsi/Kconfig | 15 +++ 3 files changed, 17 insertions

[PATCH v2 07/27] cw1200: move under st vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile

[PATCH v2 08/27] ipw2x00: move under intel vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile

[PATCH v2 13/27] mwifiex: move under marvell vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |1 - drivers/net/wireless/Makefile

[PATCH v2 17/27] hostap: move under intersil vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile

[PATCH v2 25/27] ti: unify Kconfig with other vendors

to WL_TI. It should not be needed as WLCORE is already under if WLAN_VENDOR_TI. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile |3 +-- drivers/net/wireless/ti/Kconfig

[PATCH v2 24/27] mediatek: unify Kconfig with other vendors

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile |3 +-- drivers/net/wireless/mediatek/Kconfig | 16 ++-- 3 files chang

[PATCH v2 19/27] orinoco: move under intersil vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |1 - drivers/net/wireless/Makefile

[PATCH v2 05/27] b43legacy: move under broadcom vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |1 - drivers/net/wireless/Makefile

[PATCH v2 06/27] brcm80211: move under broadcom vendor directory

Part of reorganising wireless drivers directory and Kconfig. Note that I had to edit Makefiles from subdirectories to use the new location. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/K

[PATCH v2 14/27] mwl8k: move under marvell vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |9 - drivers/net/wireless/Makefile |2 -- drive

[PATCH v2 12/27] libertas_tf: move under marvell vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- drivers/net/wireless/Kconfig | 19 --- drivers/net/wireless/Makefile |2 -- drivers/net/wireless/marvell/K

[PATCH v2 11/27] libertas: move under marvell vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/Makefile

[PATCH v2 09/27] iwlegacy: move under intel directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |1 - drivers/net/wireless/Makefile

[PATCH v2 15/27] zd1201: move under zydas vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS |2 +- drivers/net/wireless/Kconfig | 20 + drivers/net/wireless/Makefile |3 +-- d

[PATCH v2 10/27] iwlwifi: move under intel vendor directory

Part of reorganising wireless drivers directory and Kconfig. Signed-off-by: Kalle Valo <kv...@codeaurora.org> --- MAINTAINERS|2 +- drivers/net/wireless/Kconfig |1 - drivers/net/wireless/Makefile

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

Hauke Mehrtens <ha...@hauke-m.de> writes: > On 11/18/2015 03:45 PM, Kalle Valo wrote: >> Part of reorganising wireless drivers directory and Kconfig. Note that I had >> to >> edit Makefiles from subdirectories to use the new location. >> >> Signed-o

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

Florian Fainelli <f.faine...@gmail.com> writes: > On 18/11/15 11:19, Hauke Mehrtens wrote: >> On 11/18/2015 03:45 PM, Kalle Valo wrote: >>> Part of reorganising wireless drivers directory and Kconfig. Note that I >>> had to >>> edit Makefiles f

pull-request: wireless-drivers 2015-11-20

to hw_params ath10k: add QCA9377 hw1.0 support Emmanuel Grumbach (1): iwlwifi: bump firmware API to 19 Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2015-11-15' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge ath-current from ath.git Larry Finger (1): rtlwifi

Re: [PATCH v2 23/27] rt2x00: move under ralink vendor directory

Jakub Kicinski <moorr...@wp.pl> writes: > On Wed, 18 Nov 2015 16:46:02 +0200, Kalle Valo wrote: >> Part of reorganising wireless drivers directory and Kconfig. >> >> Signed-off-by: Kalle Valo <kv...@codeaurora.org> > > For Ralink you could probably

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

Arend van Spriel <ar...@broadcom.com> writes: > On 11/19/2015 08:48 AM, Kalle Valo wrote: >> Hauke Mehrtens <ha...@hauke-m.de> writes: >> >>> On 11/18/2015 03:45 PM, Kalle Valo wrote: >>>> Part of reorganising wireless drivers directory and Kconf

Re: [PATCH v2 00/27] wireless drivers vendor directories

Kalle Valo <kv...@codeaurora.org> writes: > Hi, > > I started to reorganise drivers/net/wireless directory and follow what > drivers/net/ethernet has. The major change is that new vendor > directories are created and most of the drivers are now under those > vendor direct

Re: ath9k gpio request

; > > and maybe a Reported-by tag is also appropriate in this case. Yeah, I add those. Thanks Sudip. -- Kalle Valo

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

atch 2/3. > Is that Ok for you or do you want me to re-resend a v3 > with only patches 1/3 and 3/3? I can drop patch 2, no need to resend. Thanks. -- Kalle Valo

Re: brcmfmac: rework function picking free BSS index

Rafał Miłecki wrote: > The old implementation was overcomplicated and slightly bugged in some > corner cases. > > Consider following state of BSS-es (limited to 6 for simplification): > drvr->iflist[0]: { bsscfgidx:0, ndev->name:wlan1, } > drvr->iflist[1]: (null) > drvr->iflist[2]: {

Re: brcmfmac: rework function picking free BSS index

Kalle Valo <kv...@codeaurora.org> writes: > Rafał Miłecki wrote: >> The old implementation was overcomplicated and slightly bugged in some >> corner cases. >> >> Consider following state of BSS-es (limited to 6 for simplification): >> drvr->iflist[0]:

Re: ath9k gpio request

ne AR9485_GPIO_MASK0x07FF >> #define AR9531_GPIO_MASK0x000F >> #define AR9550_GPIO_MASK0x000F >> #define AR9561_GPIO_MASK0x000F > > solves the problem. > >

Re: [v2] carl9170: Clarify kconfig text

Lauri Kasanen wrote: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > > Signed-off-by: Lauri

pull-request: wireless-drivers 2016-06-04

Hi Dave, few fixes for 4.7. Please let me know if you have any issues. Kalle The following changes since commit b7e7ad611e24b95b0db2998428ce78370415c086: Merge branch 'qed-fixes' (2016-05-26 12:27:33 -0700) are available in the git repository at:

Re: [PATCH] net: wireless: marvell: libertas: Remove create_workqueue

E commands 6d91ff7acc90 libertas: cleanup a variable name 0a38c8e1b592 libertas: check for NULL before use $ -- Kalle Valo

Re: ath9k gpio request

>> Tested-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> > > Done, https://patchwork.kernel.org/patch/9151847/ But the patch 9151847 is different from what Sudip tested above? Why? And if you modify something _after_ the reporter has tested the patch clearly document what you changed and why. I do not want find hidden changes like this, even more so when the patch is going to a 4.7-rc release. Sudip, could you also test patch 9151847, please? You can download the patch from the patchwork link above. -- Kalle Valo

Re: [7/7] mwifiex: fix typo

Julia Lawall wrote: > firmare -> firmware > > Signed-off-by: Julia Lawall Thanks, 1 patch applied to wireless-drivers-next.git: 47ce90f9f08a mwifiex: fix typo -- Sent by pwcli https://patchwork.kernel.org/patch/9113281/

Re: wifi: ath6kl: simplify logical condition

Heinrich Schuchardt wrote: > x <= 7 implies x < 8. > > Signed-off-by: Heinrich Schuchardt Thanks, 1 patch applied to ath.git: 93b4a09f0f30 ath6kl: simplify logical condition -- Sent by pwcli https://patchwork.kernel.org/patch/9115691/

Re: [6/7] ath6kl: fix typo

Julia Lawall wrote: > firmare -> firmware > > Signed-off-by: Julia Lawall Thanks, 1 patch applied to ath.git: 8a9a3efa9e77 ath6kl: fix typo -- Sent by pwcli https://patchwork.kernel.org/patch/9113271/

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

_ROLE_ANY); > + return mwifiex_get_tx_power(priv, dbm); > } So in patch 1 you added the patch and in patch 2 you move it to a different location? That doesn't make any sense, can't you just fold the two patches into one so that the function is added only once. -- Kalle Valo

Re: [PATCH 0/2] register-field manipulation macros

e, since the only existing user is in > drivers/net/wireless/. > > Jakub Kicinski (2): > add basic register-field manipulation macros > mt7601u: use linux/bitfield.h I guess you forgot to CC linux-wireless, adding it now, and hence I don't see these in my patchwork either. So better to resend. -- Kalle Valo

Re: [1/1] rsi: eliminate superfluous NULL check

Heinrich Schuchardt wrote: > msg is dereferenced before checking against NULL, e.g. > when assigning pad_bytes. > Remove the superfluous check in function rsi_mgmt_pkt_to_core. > > Signed-off-by: Heinrich Schuchardt Thanks, 1 patch applied to

Re: [1/1] mwiflex: avoid possible null pointer dereference

Heinrich Schuchardt wrote: > Do not dereference card before checking against NULL value. > > Signed-off-by: Heinrich Schuchardt Thanks, 1 patch applied to wireless-drivers-next.git: 141bcf099076 mwiflex: avoid possible null pointer dereference -- Sent

Re: [1/1] brcm80211: simplify assignment

Heinrich Schuchardt wrote: > Simplify assignment in wlc_phy_rxcal_gainctrl_nphy_rev5. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Arend van Spriel Thanks, 1 patch applied to wireless-drivers-next.git: 6b128a01c673

Re: [1/1] mwifiex: illegal assignment

Heinrich Schuchardt wrote: > Variable adapter is incorrectly initialized. > > Fixes: bf00dc22bc7a ("mwifiex: AMSDU Rx frame handling in AP mode") > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch

Re: [1/1] rtlwifi: rtl8723be: avoid undefined behavior

Heinrich Schuchardt wrote: > Do not return undefined value for transmission power > if the rate is invalid. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Larry Finger Thanks, 1 patch applied to wireless-drivers-next.git:

Re: [V2, 4.8, 1/2] brcmutil: add field storing control channel to the struct brcmu_chan

Rafał Miłecki wrote: > Our d11 code supports encoding/decoding channel info into/from chanspec > format used by firmware. Current implementation is quite misleading > because of the way "chnum" field is used. > When encoding channel info, "chnum" has to be filled by a caller with > *center*

Re: brcmfmac: use kmemdup

Muhammad Falak R Wani wrote: > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. > > Signed-off-by: Muhammad Falak R Wani > Acked-by:

Re: iwlegacy: avoid warning about missing braces

Arnd Bergmann wrote: > gcc-6 warns about code in il3945_hw_txq_ctx_free() being > somewhat ambiguous: > > drivers/net/wireless/intel/iwlegacy/3945.c:1022:5: warning: suggest explicit > braces to avoid ambiguous 'else' [-Wparentheses] > > This adds a set of curly braces to avoid

Re: [1/1] rtlwifi: rtl8192ee: simplify coding

Heinrich Schuchardt wrote: > Simplify _rtl92ee_phy_path_adda_on. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Larry Finger Thanks, 1 patch applied to wireless-drivers-next.git: a81605b14942 rtlwifi: rtl8192ee: simplify

ath9k gpio request

void ath9k_hw_gpio_request_in(); void ath9k_hw_gpio_request_out(); void ath9k_hw_gpio_free(); NOTE, the BSP of the SOC chips(AR9340, AR9531, AR9550, AR9561) should set the corresponding MUX registers correctly. Signed-off-by: Miaoqing Pan <miaoq...@codeaurora.org> Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> -- Kalle Valo

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

;zaj...@gmail.com> Arend, are you ok to push this to 4.7? -- Kalle Valo

pull-request: wireless-drivers 2016-06-21

crash related to printing features Colin Ian King (1): rtl8xxxu: fix typo on variable name, compare against correct variable Emmanuel Grumbach (1): iwlwifi: mvm: fix RCU splat in TKIP's update_key Johannes Berg (1): iwlwifi: mvm: fix a few firmware capability checks Kalle Valo (2

pull-request: wireless-drivers-next 2016-06-21

ifiex: use better message and error code when OF node doesn't match Julia Lawall (2): ath6kl: fix typo mwifiex: fix typo Kalle Valo (1): Merge ath-next from ath.git Lauri Kasanen (1): carl9170: Clarify kconfig text Lior David (1): wil6210: abort P2P search when stopping

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

I missed them. I did that now so they are back in my queue: https://patchwork.kernel.org/patch/9158855/ https://patchwork.kernel.org/patch/9158851/ Thanks for checking. -- Kalle Valo

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

t seems to be there for a long time. Also > applying it to -next will allow avoiding merge conflicts and immediate > development work on -next. Exactly, there is a cost when taking patches to wireless-drivers.git and that's why I try to keep the bar high. Regressions and user reported bugs take priority, other fixes are handled case by case. > I'll resend this patch rebased on -next soon. Thanks. -- Kalle Valo

Re: mwifiex: fix link error against sdio

Arnd Bergmann wrote: > Calling sdio_claim_host() from the interface independent part of > the mwifiex driver is not only a layering violation, but also causes > a link error if MMC support is disabled, or if CONFIG_MMC=m > and CONFIG_MWIFIEX=y: > > drivers/net/built-in.o: In

Re: [PATCH 0/3] *** Mesh Path Selection Metric Calculation ***

Peter Oh <p...@codeaurora.org> writes: > where is 2/3 ? You can find the patches from patchwork: https://patchwork.kernel.org/patch/9187367/ https://patchwork.kernel.org/patch/9187361/ https://patchwork.kernel.org/patch/9187355/ -- Kalle Valo

Re: [1/8] mwifiex: only call mwifiex_sdio_probe_of() if dev has an OF node

Javier Martinez Canillas wrote: > SDIO is an auto enumerable bus so the SDIO devices are matched using the > sdio_device_id table and not using compatible strings from a OF id table. > > However, commit ce4f6f0c353b ("mwifiex: add platform specific wakeup > interrupt

Re: brcmfmac: include required headers in cfg80211.h

Rafał Miłecki wrote: > Without this including cfg80211.h in a wrong order could result in: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h:122:24: error: > array type has incomplete element type > struct brcmf_wsec_key key[BRCMF_MAX_DEFAULT_KEYS]; > ^ >

Re: wl3501_cs: avoid bogus gcc-6 warning

Arnd Bergmann wrote: > gcc-6 on x86 started warning about wl3501_get_encode when building > with -O2: > > drivers/net/wireless/wl3501_cs.c: In function ‘wl3501_get_encode’: > drivers/net/wireless/wl3501_cs.c:1769:5: warning: ‘implemented’ may be used > uninitialized in this

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

ed to merge in the changes. Patch failed at 0001 brcmfmac: fix lockup when removing P2P interface after event timeout -- Kalle Valo

Re: libertas_tf: Drop unused variable and define

Guenter Roeck wrote: > gcc-6 reports: > > drivers/net/wireless/marvell/libertas_tf/main.c:30:19: error: > 'lbtf_driver_version' defined but not used > > with -Werror=unused-const-variable=. > > Reported-by: Fengguang Wu [0-day test robot] >

Re: rtlwifi: fix error handling in *_read_adapter_info()

Arnd Bergmann wrote: > There are nine copies of the _rtl88ee_read_adapter_info() function, > and most but not all of them cause a build warning in some configurations: > > rtl8192de/hw.c: In function '_rtl92de_read_adapter_info': > rtl8192de/hw.c:1767:12: error: 'hwinfo' may be

Re: [v3,1/2] b43: Remove unused phy_a code

Guenter Roeck wrote: > gcc-6 reports the following error with -Werror=unused-const-variable. > > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: > 'b43_phyops_a' defined but not used > > Per Michael Büsch: "All a-phy code is usused", so remove it all, > and

Re: brcmfmac: drop unused pm_block vif attribute

Rafał Miłecki wrote: > This attribute was added 3 years ago by > commit 3eacf866559c ("brcmfmac: introduce brcmf_cfg80211_vif structure") > but it remains unused since then. It seems we can safely drop it. > > Signed-off-by: Rafał Miłecki Thanks, 1 patch applied to

Re: [V2] brcmfmac: fix setting AP channel with new firmwares

Rafał Miłecki wrote: > Firmware for new chipsets is based on a new major version of code > internally maintained at Broadcom. E.g. brcmfmac4366b-pcie.bin (used for > BCM4366B1) is based on 10.10.69.3309 while brcmfmac43602-pcie.ap.bin was > based on 7.35.177.56. > > Currently setting AP 5 GHz

Re: [V2, next] brcmfmac: don't remove interface on link down firmware event

Rafał Miłecki wrote: > There are two firmware events we handle similarly in brcmfmac: > BRCMF_E_LINK and BRCMF_E_IF. The difference from firmware point of view > is that the first one means BSS remains present in the firmware. Trying > to (re)create it (e.g. when adding new virtual interface) will

Re: libertas: Remove create_workqueue

Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > In if_sdio.c, the workqueue card->workqueue has workitem > >packet_worker, which is mapped to if_sdio_host_to_card_worker. > The workitem is involved in sending packets to firmware.

Re: [v3,1/2] b43: Remove unused phy_a code

Michael Büsch <m...@bues.ch> writes: > On Thu, 16 Jun 2016 15:23:37 + (UTC) > Kalle Valo <kv...@codeaurora.org> wrote: > >> Guenter Roeck <li...@roeck-us.net> wrote: >> > gcc-6 reports the following error with -Werror=unused-const-variable. >> &

Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

Rafał Miłecki <zaj...@gmail.com> writes: > On 16 June 2016 at 17:10, Kalle Valo <kv...@codeaurora.org> wrote: >> Rafał Miłecki <zaj...@gmail.com> writes: >> >>> Removing P2P interface is handled by sending a proper request to the >>> firmware.

Re: [PATCH] wlcore: Fix regression in wlcore_set_partition()

regarding write of the last partition size > brings the module back to it's functional state. > > Reported-by: Ross Green <rgker...@gmail.com> > Signed-off-by: Emil Goode <emil@goode.io> A proper "Fixes:" line is good to have, but I can add it. I'm planning to queue this to 4.5. -- Kalle Valo

Re: [2/3] net: wireless: rt2x00: Pointer issue

> Code Style: pointer is declared wrong > > Signed-off-by: Paul McQuade > Acked-by: Helmut Schaa This patch didn't apply, so please resend. Kalle

Re: [1/3] net: wireless: rt2x00: Space issue

451715e94d net: wireless: rt2x00: Space Required 1 patches skipped: [2/3] net: wireless: rt2x00: Pointer issue Kalle Valo

Re: net: wireless: rt2x00: Fixed Spacing issues

> Removed empty spaces before/after parenthesis > > Signed-off-by: Paul McQuade <paulmcq...@gmail.com> > Acked-by: Helmut Schaa <helmut.sc...@googlemail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [v2] hostap: avoid uninitialized variable use in hfa384x_get_rid

.len) == 0) { > > This restructures the function as suggested by Russell King, to > make it more readable and get more reliable error handling, by > handling each failure mode using a goto. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: brcmfmac: sdio: Increase the default timeouts a bit

cal...@gmail.com> > Acked-by: Arend van Spriel <ar...@broadcom.com> > Reviewed-by: Douglas Anderson <diand...@chromium.org> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: wlcore: Fix regression in wlcore_set_partition()

Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") > Reported-by: Ross Green <rgker...@gmail.com> > Signed-off-by: Emil Goode <emil@goode.io> > [kv...@codeaurora.org: improved commit log] Thanks, applied to wireless-drivers.git. Kalle Valo

pull-request: wireless-drivers-next 2016-02-12

iwlwifi: mvm: fix debugfs signedness warning iwlwifi: mvm: track low-latency sources separately iwlwifi: mvm: support setting minimum quota from debugfs iwlwifi: treat iwl_parse_nvm_data() MAC addr as little endian Kalle Valo (1): Merge tag 'iwlwifi-next-for-kalle-2016-01

pull-request: wireless-drivers 2016-01-29

: add missing include ath9k_hw: ignore eeprom magic mismatch on flash based devices Gregory Greenman (1): iwlwifi: mvm: rs: fix TPC statistics handling Hante Meuleman (1): brcmfmac: fix sdio sg table alloc crash Kalle Valo (2): Merge ath-current from ath.git Merge tag

Re: wlcore: fix error handling in wlcore_event_fw_logger

.linux.kernel/2120705 > > Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH] ath9k: Drop useless const on chanctx_event_delta() return type

Geert Uytterhoeven <ge...@linux-m68k.org> writes: > drivers/net/wireless/ath/ath9k/channel.c:230: warning: type qualifiers > ignored on function return type > > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Applied to ath.git, thanks. -- Kalle Valo

<    1   2   3   4   5   6   7   8   9   10   >