Re: [PATCH] mac80211: fix memory leak

i sent reached all the list subscriber from a different > server than our designated server, and as a result it is marked as spam > in many places and I have already received a few complaints regarding > that." You can add a separate "From:" line to the beginning of the commit log and git will use it then commiting the patch. I didn't find any documention but it's easy to do and should solve this. -- Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

guration has to go through cfg80211. Instead of waiting two years you could have added it yourself. -- Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

oex from within the driver itself. >> >> This aint no debugging feature. > > Right, bt-coex is not for debugging purpose, but for normal usage, when > user want to use together bluetooth and wifi or just one of those. I think most of other drivers have a debugfs interface for btcoex, I guess mostly for testing purposes. But this really should be added to cfg80211. -- Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

Pali Rohár <pali.ro...@gmail.com> writes: > On Thursday 21 January 2016 15:48:14 Kalle Valo wrote: >> Pali Rohár <pali.ro...@gmail.com> writes: >> >> > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote: >> >> On Wed 2016-01-13 23:32:47, Are

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

single variable on a non-critical path? > > Most of the kernel code is not performance critical at the level of a > single if test. So the goal should be for the code to be easy to > understand and robust to change. The code that is performance critical, > you should probably not touch, ever. The people who wrote it knew what > was important and what was not. Very well said! Only optimise something you can measure. I'm dropping this patch. -- Kalle Valo

Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

the whole code style cleanup series? Actually git should be manage that automatically, it's so awesome :) I can also fix the title and remove the unnecessary "net: wireless:" prefix. -- Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

What I suggest is that you add this yourself to cfg80211 and mac80211. It's not that hard and I think you could use NL80211_CMD_SET_POWER_SAVE as an example. -- Kalle Valo

Re: wlcore: Fix regression in wlcore_set_partition()

Ross Green <rgker...@gmail.com> writes: > On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <kv...@codeaurora.org> wrote: >> >>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a >>> regression causing the wlcore to time out and

pull-request: wireless-drivers 2016-02-18

: fix erroneous return value Emil Goode (1): wlcore: Fix regression in wlcore_set_partition() Emmanuel Grumbach (2): iwlwifi: dvm: remove a wrong dependency on m iwlwifi: pcie: fix RF-Kill vs. firmware load race Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-02-15

Re: [PATCH] b43: fix memory leak

end] b43: Fix memory leaks in b43_bus_dev_ssb_init and > b43_bus_dev_bcma_init > > Please test that patch instead, so we can finally apply it. > > It needs to be tested on both ssb and bcma. Come on. This isn't too > hard. :) Please somebody with any hardware test it. (I currently don't > have any b43 hardware) And the patch can be downloaded from patchwork: https://patchwork.kernel.org/patch/8049041/ -- Kalle Valo

Re: libertas: fix an error code in probe

> We accidentally return success instead of a negative error code. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

bcma_remove and error handling code of b43_bcma_probe. > > Thanks Michael for his suggestion. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> > Acked-by: Michael Büsch <m...@bues.ch> > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> If no objections I'm planning to queue this to 4.6-rc2. -- Kalle Valo

pull-request: wireless-drivers-next 2016-03-14

(1): iwlwifi: mvm: don't try to offload AES-CMAC in AP/IBSS modes Kalle Valo (1): Merge tag 'iwlwifi-next-for-kalle-2016-03-09_2' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Luca Coelho (1): iwlwifi: pcie: forbid RTPM on device removal Matti Gottlieb (1): iwlwifi

Re: pull-request: wireless-drivers-next 2016-03-14

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Mon, 14 Mar 2016 10:31:48 +0200 > >> I know I'm late now that merge window was opened yesterday but here's >> one more set of patches I would like to get to 4

pull-request: wireless-drivers-next 2016-03-09

b9a9693fd9aea43f50b107dfc8cbaea317f95a79 Author: Kalle Valo <janusz.dzied...@tieto.com> Date: Fri Nov 27 09:37:14 2015 +0100 ath9k: request NOA update when chanctx active Please let me know if you have any problems. Kalle The following changes since commit 00a1f0a93dea3cf1c141df79bfd06e7c9ee54162:

Re: [RFC 5/7] wlcore: avoid fragile snprintf use

t; Signed-off-by: Rasmus Villemoes <li...@rasmusvillemoes.dk> Should I take this or what's the plan? -- Kalle Valo

Re: [PATCH] rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

this makes the patchwork page for the patch really hard to read: https://patchwork.kernel.org/patch/8615131/ -- Kalle Valo

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

Joe Perches <j...@perches.com> writes: > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >> Joe Perches <j...@perches.com> writes: >> > Using the normal kernel logging mechanisms makes this code >> > a bit more like other wireless drivers. >> Pers

Re: brcmfmac: sdio: remove unused variable retry_limit

<julian.cal...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [v2] mwifiex: advertise low priority scan feature

org> > Tested-by: Wei-Ning Huang <wnhu...@chromium.org> > Acked-by: Amitkumar Karwar <akar...@marvell.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

Falling back to patching base and 3-way merge... Auto-merging drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h Auto-merging drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c Auto-merging drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c Kalle Valo

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

"Machani, Yaniv" <yani...@ti.com> writes: > More than that, wl1251 family is not officially supported via the > mainline Linux. I guess you mean not officially supported by TI? Because wl1251 driver has been in mainline for ages and reportedly working. -- Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

rnel.org; >> netdev@vger.kernel.org; linux-ker...@vger.kernel.org >> Cc: Reizer, Eyal >> Subject: [PATCH] wlcore: spi: add wl18xx support Please edit your quotes and don't top most. A oneliner and then followed by almost 400 lines unnecessary text for example makes it harder to use patchwork: https://patchwork.kernel.org/patch/8696181/ -- Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

;, .data = _data}, >> >{ } >> >> Shouldn't you also update bindings/net/wireless/ti,wlcore,spi.txt? Now it >> only >> mentions about ti,wl1271 and not anything about the rest. > > You are right! Will be fixed in v2 Thanks. Also remember to CC devicetree list. -- Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

805", .data = _data}, > + { .compatible = "ti,wl1807", .data = _data}, > + { .compatible = "ti,wl1831", .data = _data}, > + { .compatible = "ti,wl1835", .data = _data}, > + { .compatible = "ti,wl1837", .data = _data}, > { } Shouldn't you also update bindings/net/wireless/ti,wlcore,spi.txt? Now it only mentions about ti,wl1271 and not anything about the rest. Adding devicetree list for further comments. -- Kalle Valo

Re: wl12xx: remove redundant null check on wl->scan.ssid

> From: Colin Ian King <colin.k...@canonical.com> > > ssid is an array of u8, so it can never be null, so the null check on > wl->scan.ssid is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: mwifiex: ie_list is an array, so no need to check if NULL

Thanks, applied to wireless-drivers-next.git. Kalle Valo

pull-request: wireless-drivers-next 2016-04-11

on for compaq c700 laptop Julian Calaby (1): iwl4965: Fix more memory leaks in __il4965_up() Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2016-03-30' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Larry Finger (11): rtlwifi: rtl8723be

Re: [PATCH 3/5] ath9k: fix buffer overrun for ar9287

es all three > instances to use that variable. The other two instances were > already correct, but it's more consistent this way. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 940cd2c12ebf ("ath9k_hw: merge the ar9287 version of > ath9k_hw_get_gain_boundaries_pdadcs") Dave already applies this so I can skip this. -- Kalle Valo

Re: [PATCH 4/5] ath9k: fix misleading indentation

d-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 499afaccf6f3 ("ath9k: Isolate ath9k_use_chanctx module parameter") > Fixes: eb61f9f623f7 ("ath9k: advertise p2p dev support when chanctx") Dave already applied this so I can skip this. -- Kalle Valo

Re: [PATCH] mwifiex: advertise low priority scan feature

The From line states that this is written by Amitkumar but there's no Signed-off-By line from him. I can't take this without that, please resend. (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.) -- Kalle Valo

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

, can you help? It's a long time ago but IIRC wl1251 has not ever supported AP mode and wl1271 was the first one to support it. But I might be wrong of course. -- Kalle Valo

Re: b43: Fix memory leaks in b43_bus_dev_ssb_init andb43_bus_dev_bcma_init

; > Thanks Michael for his suggestion. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> > Acked-by: Michael Büsch <m...@bues.ch> > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Thanks, applied to wireless-drivers.git. Kalle Valo

Re: rtlwifi: fix gcc-6 indentation warning

-off-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers.git. Kalle Valo

Re: mwifiex: Use to_delayed_work()

iner_of(a, struct delayed_work, work) > + to_delayed_work(a) > // > > Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [V2] rtlwifi: pass struct rtl_stats by reference as it is moreefficient

change just affects just the rx_command_packet calls. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

> Add USB ID 0411:01fd for Buffalo WLI-UC-G450 wireless adapter, > RT chipset 3593 > > Signed-off-by: Anthony Wong <anthony.w...@ubuntu.com> > Cc: sta...@vger.kernel.org > Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [V3] mt7601u: do not free dma_buf when ivp allocation fails

a fields are free'd. Fix this by not free'ing the > dma_buf if the ivp allocation fails. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [10/14] wireless: cw1200: use __maybe_unused to hide pm functions_

n use an IS_ENABLED() check > to avoid defining the structure when CONFIG_PM is not set without > the #ifdef. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH RFC/RFT 1/2] ath9k: rename struct ath_txq to struct ath_hwq

to both patches in case someone else wants to work with these. -- Kalle Valo

Re: pull-request: wireless-drivers 2016-02-18

(Adding Larry) Geert Uytterhoeven <ge...@linux-m68k.org> writes: > On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo <kv...@codeaurora.org> wrote: > >> rtlwifi >> >> * fix broken VHT (802.11ac) support, reported by Linus > > That's commit d76d65fd269514

pull-request: wireless-drivers 2016-03-04

(1): ssb: host_soc depends on sprom Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-02-25' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Liad Kaufman (1): iwlwifi: mvm: inc pending frames counter also when txing non-sta Matti Gottlieb (1): iwlwifi: mvm: Fix paging

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

t and that's I'm not thrilled to take big patches like this for dormant drivers. -- Kalle Valo

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

ing Huang <wnhu...@chromium.org> Is this really a proper way to fix the issue? This is the first time I'm hearing about the flag and there isn't even a single user in drivers/net. I would like to get confirmation from others that __GFP_REPEAT is really ok to use in a wireless driver before I can take this. -- Kalle Valo

Re: [PATCH] ath5k: Change led pin configuration for compaq c700 laptop

b8d ("ath5k: add led pin > configuration for compaq c700 laptop") > > Signed-off-by: Joseph Salisbury <joseph.salisb...@canonical.com> > Cc: sta...@vger.kernel.org Applied to ath.git, thanks. I just fixed the Fixes line to be one continuous line. -- Kalle Valo

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

7, that introduces this > helper function. Do you want me to resend, or can you apply the patches > out of order? It's better that you resend the whole patchset as v2. -- Kalle Valo

Re: [PATCH v3 00/18] wcn36xx fixes

ex instead of hard coded > wcn36xx: Clear encrypt_type when deleting bss key > wcn36xx: Track association state > wcn36xx: Implement multicast filtering > wcn36xx: Use correct command struct for EXIT_BMPS_REQ All applied, thanks. -- Kalle Valo

pull-request: wireless-drivers 2016-04-25

Ayala Beker (1): iwlwifi: mvm: avoid to WARN about gscan capabilities Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-04-12_2' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Matti Gottlieb (1): iwlwifi: mvm: fix accessing Null pointer during fw dump

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

macros, SHOW_*, pc_debug, maybe >> more) as well. > > Seems reasonable. > > Maybe we should Cc the maintainer, but I suspect that since the driver > is marked Obsolete anyway Luis won't care either :) I'm planning to apply this patch anyway, the debugging infrastructure removal can be a followup patch. But please let me know if I should drop this instead. -- Kalle Valo

Re: [PATCH 1/5] ti: Convert wl1271_ logging macros to dev_ or pr_

vers/net/wireless/ti/wl18xx/event.c Auto-merging drivers/net/wireless/ti/wl18xx/debugfs.c Auto-merging drivers/net/wireless/ti/wl18xx/cmd.c Auto-merging drivers/net/wireless/ti/wl12xx/scan.c Auto-merging drivers/net/wireless/ti/wl12xx/main.c Failed to merge in the changes. -- Kalle Valo

Re: [v3] prism54: isl_38xx: Replace 'struct timeval'

<a...@arndb.de> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH] wcn36xx: Set SMD timeout to 10 seconds

gt; > Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> Applied, thanks. -- Kalle Valo

Re: [GIT] Networking

"Coelho, Luciano" <luciano.coe...@intel.com> writes: > Kalle, David, what is the status with the fix that is on the way via > your trees? It would be best if you could send a patch either directly to Dave or Linus to resolve this quickly. -- Kalle Valo

Re: [GIT] Networking

Linus Torvalds <torva...@linux-foundation.org> writes: > On Wed, May 18, 2016 at 11:58 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> >> It would be best if you could send a patch either directly to Dave or >> Linus to resolve this quickly. > > I'm comm

pull-request: wireless-drivers-next 2016-05-13 (take two)

: rtl818x: constify rtl_intf_ops structures Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2016-05-10' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Liad Kaufman (4): iwlwifi: mvm: allocate queue for probe response in dqa mode iwlwifi: mvm

Re: [PATCH 0/7] fix typo

know in advance what tree you are planning to submit these for. For example, should I take ath6kl and mwifiex patches or someone else? -- Kalle Valo

Re: [PATCH 0/7] fix typo

Julia Lawall <julia.law...@lip6.fr> writes: > On Tue, 17 May 2016, Kalle Valo wrote: > >> Julia Lawall <julia.law...@lip6.fr> writes: >> >> > firmare -> firmware >> > >> > --- >> > >> > drivers/media/dvb-frontends/mn88

Re: pull-request: wireless-drivers-next 2016-05-13

Hi Dave, Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Kalle Valo <kv...@codeaurora.org> writes: >> >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.gi

Re: pull-request: wireless-drivers-next 2016-05-13

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Tue, 17 May 2016 09:43:34 +0300 > >> I noticed that you had marked this as Superseded in pathwork[1]. I was >> actually hoping that you would pull this with the instru

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

(uintptr_t)skb_info->driver_data[0]); tx_cmd->life_time = cpu_to_le32(TX_CMD_LIFE_TIME_INFINITE); tx_cmd->sta_id = sta_id; I'm going to propose this to Dave in my pending pull request[1]. But I would appreciate if someone else would double check this. [1] https://patchwork.ozlabs.org/patch/621953/ -- Kalle Valo

Re: pull-request: wireless-drivers-next 2016-05-13

Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> The following changes since commit ede00a5ceb4d903a8c137a52bb77d574baaef8bd: >> >> Merge tag 'wireless-drivers-next-for-davem-2016-05-02' of >> git://git

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

tx_cmd->life_time = cpu_to_le32(TX_CMD_LIFE_TIME_INFINITE); tx_cmd->sta_id = sta_id; I wasn't expecting that skb_info variable is removed. Do we now have merge damage somewhere? Luca, what do you think? -- Kalle Valo

Re: pull-request: wireless-drivers-next 2016-05-13

Hi Dave, Kalle Valo <kv...@codeaurora.org> writes: > this is the last pull request to net-next for 4.7. Nothing really out of > ordinary, the signed tag below contains more info. Please let me know if > there are any issues. > > Kalle > > > The

pull-request: wireless-drivers-next 2016-05-13

iwlwifi: pcie: avoid msleep() with short timeout Julia Lawall (1): rtlwifi: rtl818x: constify rtl_intf_ops structures Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2016-05-10' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Liad Kaufman (4

Re: [v2] rtlwifi: Fix logic error in enter/exit power-save mode

wang yanqing wrote: > In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and > rtl_lps_enter() to use work queue"), the tests for enter/exit > power-save mode were inverted. With this change applied, the > wifi connection becomes much more stable. > > Fixes:

Re: [v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb inrtl_pci_reset_trx_ring

wang yanqing wrote: > We can't use kfree_skb in irq disable context, because spin_lock_irqsave > make sure we are always in irq disable context, use dev_kfree_skb_irq > instead of kfree_skb is better than dev_kfree_skb_any. > > This patch fix below kernel warning: > [

Re: rtlwifi: rtl818x: constify rtl_intf_ops structures

Julia Lawall wrote: > The rtl_intf_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks, 1 patch applied to wireless-drivers-next.git: 1bfcfdcca142 rtlwifi:

Re: [v2] rtlwifi: Remove double check for cnt_after_linked

wang yanqing wrote: > rtl_lps_enter does two successive check for cnt_after_linked > to make sure some time has elapsed after linked. The second > check isn't necessary, because if cnt_after_linked is bigger > than 5, it is bigger than 2 of course! > > This patch remove the

Re: rtlwifi: rtl818x: silence uninitialized variable warning

Dan Carpenter wrote: > What about if "rtlphy->pwrgroup_cnt" is 2? In that case we would use an > uninitialized "chnlgroup" variable and probably crash. Maybe that can't > happen for some reason which is not obvious but in that case this patch > is harmless. > >

Re: linux-next: manual merge of the net-next tree with the wireless-drivers tree

to fix this by merging wireless-drivers to wireless-drivers-next later today and most likely tomorrow send a wireless-drivers-next pull request to Dave. -- Kalle Valo

pull-request: wireless-drivers-next 2016-05-02

rtl8723b_channel_to_group() rtl8xxxu: Rename rtl8723bu_simularity_compare() rtl8xxxu: Rename rtl8723au_iqk_phy_iq_bb_reg Jia-Ju Bai (1): rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring Kalle Valo (14): ath10k: fix checkpatch warnings related to spaces ath10k: prefer kernel

Re: [PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

t; > Have you picked up these patches yet? > > As I was debugging a firmware crash when trying to start hostap on the > DragonBoard410c I found an issue with this patch, would like to know if > I should send an incremental patch or resend this one. I haven't applied these yet, so please resend the whole series as v3. -- Kalle Valo

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

Patch failed at 0001 rtlwifi: Fix reusable codes in core.c Please rebase and resend. -- Kalle Valo

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

Julian Calaby <julian.cal...@gmail.com> writes: > Hi Kalle, > > On Sat, Apr 16, 2016 at 4:25 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Byeoungwook Kim <quddnr...@gmail.com> writes: >> >>> rtl_*_delay() functions were reused same co

Re: [PATCH v2] carl9170: Clarify kconfig text

Christian Lamparter <chunk...@googlemail.com> writes: > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> Lauri Kasanen <c...@gmx.com> writes: >> >> > --- a/drivers/net/wireless/ath/carl9170/Kconfig >> > +++ b/drivers/net/wireless/ath/c

Re: [PATCH] ath9k: remove duplicate assignment of variable ah

Colin King <colin.k...@canonical.com> writes: > From: Colin Ian King <colin.k...@canonical.com> > > ah is written twice with the same value, remove one of the > redundant assignments to ah. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Applied, thanks. -- Kalle Valo

Re: [PATCH] rtl8xxxu: hide unused tables

into device specific >> functions") >> --- >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 >> 1 file changed, 4 insertions(+) > > I'll apply it to my tree! Actually I would prefer to apply this directly to wireless-drivers-next so that the warnings are quickly fixed. -- Kalle Valo

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

Replace an explicit initialisation for one local variable at the beginning >> by a conditional assignment. >> >> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> > > This looks sane to me. > > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Applied, thanks. -- Kalle Valo

Re: [PATCH v2] carl9170: Clarify kconfig text

Christian Lamparter <chunk...@googlemail.com> writes: > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: >> Christian Lamparter <chunk...@googlemail.com> writes: >> >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> > >> >

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

Eliad Peller <el...@wizery.com> writes: > On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches <j...@perches.com> wrote: >> On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: >>> Joe Perches <j...@perches.com> writes: >>> > On Wed, 2016-03-30 at 14:51

Re: rtl8xxxu: hide unused tables

"rtl8xxxu: Add TX power base values for gen1 parts") > Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device specific > functions") Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH v2] carl9170: Clarify kconfig text

s/Drivers/carl9170> Why even mention anything about a "special firmware" as the firmware is already available from linux-firmware.git? That's default location for all firmware images and I think most, if not all, distros should have it available. So wouldn't it be better not to mention anything about firmware at all? -- Kalle Valo

pull-request: wireless-drivers 2016-04-13

Grumbach (1): iwlwifi: pcie: lower the debug level for RSA semaphore access Jia-Ju Bai (1): b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-03-30' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Matti

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

.cal...@gmail.com> Before I commit I'll just change the commit title to: ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() -- Kalle Valo

pull-request: wireless-drivers 2016-05-09

) Emmanuel Grumbach (1): iwlwifi: mvm: don't override the rate with the AMSDU len Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-05-04' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes drivers/net/wireless/intel/iwlwifi/mvm

pull-request: wireless-drivers-next 2016-07-22

if dma_mapping_error() fails in dma_rxfill brcmsmac: Initialize power in brcms_c_stf_ss_algo_channel_get() Kalle Valo (3): Merge tag 'iwlwifi-next-for-kalle-2016-07-11' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from git://git.kernel.org/.../kvalo/ath.git

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

>> consistently). >> >> Regards, >> Christian > > I wonder if this is something that is only affecting certain NIC's? > For example, it see this issue on sun4u boxes with tigon3 and hme > interfaces. But on my sun4v boxes that have e1000 interfaces > everything works fine. Kernel configuration might also make a difference. Trying to find an Kconfig option which affects this could be useful. -- Kalle Valo

Re: [PATCH] wlcore/wl18xx: mesh: added initial mesh support for wl8

>> opposed to current implementation that handles STA only). >> 5. Bumped the firmware version to support new Mesh functionality >> >> Signed-off-by: Maital Hahn <mait...@ti.com> >> Signed-off-by: Yaniv Machani <yani...@ti.com> >> --- > > Any comments on this patch ? Can this be pulled ? I'm away this week, will look at it next week. But it's on my queue: https://patchwork.kernel.org/patch/9202707/ -- Kalle Valo

Re: [PATCHv5 wl-drv-next 0/2] register-field manipulation macros

see an ack from someone else like Andrew Morton or Dave Miller. I don't feel comfortable adding new files to include/ without some sort of support from others. Or maybe Andrew could even take these directly to his tree? -- Kalle Valo

Re: [PATCH 1/1] mwifiex: remove superfluous condition (2)

u can use function names or something else. Adding "(2)" is not the way to do that. -- Kalle Valo

Re: [PATCH 1/1 v2] rtlwifi: remove superfluous condition

ry Finger <larry.fin...@lwfinger.net> > --- > drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The change log goes under the "---" line so that git can automatically strip it away while committing the patch. I can fix it this time but please keep this in mind in the future. -- Kalle Valo

Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

alle: I'm acking this as bugfix for 4.8 release. Ok. I'll wait few days for more comments before I apply this. (I assume you are talking only about patch 1) -- Kalle Valo

pull-request: wireless-drivers-next 2016-07-13

Q code iwlwifi: remove useless enum values iwlwifi: change fw.mvm_fw to fw.type iwlwifi: remove iwl_ht_params.smps_mode iwlwifi: store cipher scheme independent of mac80211 iwlwifi: tracing: decouple from mac80211 iwlwifi: decouple PCIe transport from mac80211 Kalle V

Re: iwlwifi: add missing type declaration

Arnd Bergmann wrote: > The iwl-debug.h header relies in implicit inclusion of linux/device.h and > we get a lot of warnings without that: > > drivers/net/wireless/intel/iwlwifi/iwl-debug.h:44:23: error: 'struct device' > declared inside parameter list will not be visible outside

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

d like a good idea. I would rather try to fix the thermal interface to handle the cases when the measurement is not available. -- Kalle Valo

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Prarit Bhargava <pra...@redhat.com> writes: > On 07/13/2016 02:50 AM, Kalle Valo wrote: >> Prarit Bhargava <pra...@redhat.com> writes: >> >>>> We implement thermal zone because we do support it, but the problem is >>>> that we need t

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

out. It looks like just moving some code around.] Another option, but still a bad one I don't like, is that you change the kernel interface to ignore all errors from drivers (like iwlwifi). This way drivers don't need to make ugly workarounds. > The bottom line is that lm-sensors is currently broken with this change in > iwlwifi. AFAICT, no other thermal device returns an error this way, and IMO > that means the iwlwifi driver is doing something new and unexpected wrt to > userspace. I haven't checked but I suspect ath10k has a similar problem when interface is down. -- Kalle Valo

Re: [PATCH] wlcore: spi: fix build warning caused by redundant variable

"Reizer, Eyal" <ey...@ti.com> writes: > The ret variable is unused in wlcore_probe_of() > Remove it for fixing build warning. > > Fixes: 01efe65aba65 ("wlcore: spi: add wl18xx support") > Signed-off-by: Eyal Reizer <ey...@ti.com> Applied to wireless-drivers-next, thanks. -- Kalle Valo

Re: [PATCH v5] wlcore: spi: add wl18xx support

; v5 is corrupted somehow in patchwork: https://patchwork.kernel.org/patch/9233597/ The "former" v5 again looks ok: https://patchwork.kernel.org/patch/9222403/ I can't immeaditely see why that happened, but please resend. -- Kalle Valo

Re: [PATCH] wlcore/wl18xx: mesh: added initial mesh support for wl8

mentation that handles STA only). > 5. Bumped the firmware version to support new Mesh functionality > > Signed-off-by: Maital Hahn <mait...@ti.com> > Signed-off-by: Yaniv Machani <yani...@ti.com> Does this depend on any mac80211 patches? To not break anything I can't apply this until all the dependencies are in my tree. -- Kalle Valo

<    1   2   3   4   5   6   7   8   9   10   >