Re: wlcore/wl18xx: mesh: added initial mesh support for wl8

"Machani, Yaniv" wrote: > From: Maital Hahn > > 1. Added support for interface and role of mesh type. > 2. Enabled enable/start of mesh-point role, >and opening and closing a connection with a mesh peer. > 3. Added multirole combination of mesh and ap >

Re: brcmfmac: respect hidden_ssid for AP interfaces

Rafał Miłecki wrote: > This was succesfully tested with 4366B1. A small workaround is needed > for the main interface otherwise it would stuck at the hidden state. > > Signed-off-by: Rafał Miłecki Thanks, 1 patch applied to wireless-drivers-next.git: c940de10d45e brcmfmac:

Re: [PATCH v7] wlcore: spi: add wl18xx support

patchwork.kernel.org/patch/9235983/ Because you used ti.com in S-o-b I assume From should also use ti.com. I can fix that before I apply but please confirm that's really the case? -- Kalle Valo

Re: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

icked up, and what I have > left now is > > a281bfa5713a [SUBMITTED 20160615] [EXPERIMENTAL] Kbuild: enable > -Wmissing-include-dirs by default > 83934921e68e [SUBMITTED 20160615] rtlwifi: don't add include path for > rtl8188ee Apparently[1] you didn't CC linux-wireless and that's why I didn't see the rtlwifi patch in wireless patchwork. Care to resend? [1] https://patchwork.kernel.org/patch/9178861/ -- Kalle Valo

Re: [v7] wlcore: spi: add wl18xx support

Eyal Reizer wrote: > From: Eyal Reizer > > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. > extra clock cycles should be sent after the spi init command while the > cs pin is

Re: [1/3] rtlwifi: don't add include path for rtl8188ee

Arnd Bergmann wrote: > For rtl8188ee, we pass -Idrivers/net/wireless/rtlwifi/ to gcc, > however that directy no longer exists, so evidently this option > is no longer required here and can be removed to avoid a warning > when building with 'make W=1' or 'gcc -Wmissing-include-dirs'

Re: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

e two as a combined patch along with a third one that > turned out to be unnecessary. Greg applies drivers/staging patches to his staging tree, but I'll take the rtlwifi patch. -- Kalle Valo

Re: [PATCHv8] wlcore: spi: add wl18xx support

mismatch in wl1271 example > v4->v5: Rebase on top of head of wireless-drivers-next > v5->v6: Add ACKs > v6->v7: Mail format issues > v7->v8: Remove redundant varaible from wlcore_probe_of I have already applied this patch, it's too late to send a new version. Now you need to send a new patch, on top of wireless-drivers-next, which removes the redundant variable. -- Kalle Valo

Re: pull-request: wireless-drivers-next 2016-07-13

> https://github.com/0day-ci/linux/commits/Kalle-Valo/pull-request-wireless-drivers-next-2016-07-13/20160714-023750 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git > master > config: sparc64-allmodconfig (attached as .config) > compil

Re: pull-request: wireless-drivers-next 2016-07-13

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Wed, 13 Jul 2016 21:29:13 +0300 > >> here's a pull request for net-next. This time there are few conflicts >> due to the cfg80211 scan API changes, and one of them is eas

Re: [PATCH] libertas_tf: Remove create_workqueue

Bhaktipriya Shridhar <bhaktipriy...@gmail.com> writes: > Ping! I'm lagging behind, the patch is still on my queue: https://patchwork.kernel.org/patch/9162447/ Please don't top most, it's annoying. -- Kalle Valo

Re: [PATCHv4 wl-drv-next 2/2] mt7601u: use linux/bitfield.h

uld just remove it entirely. But you can do that in a follow up patch. -- Kalle Valo

Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

ed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> The fixes line should be: Fixes: 7311ea850079 ("mwifiex: fix AP start problem for newly added interface") I can fix that before I apply the patch. -- Kalle Valo

Re: [PATCHv4 wl-drv-next 0/2] register-field manipulation macros

w Morton (CCed). Full patches here: https://patchwork.kernel.org/patch/9214129/ https://patchwork.kernel.org/patch/9214135/ -- Kalle Valo

Re: [v2, 1/3] mwifiex: add a cfg80211 .get_tx_power operation callback

Javier Martinez Canillas wrote: > The mwifiex driver implements a cfg80211 .set_tx_power operation handler > but doesn't have the inverse .get_tx_power callback. > > This not only has the effect that the Tx power can't be reported to user > space tools such as iwconfig

Re: [PATCH] mwifiex: mask PCIe interrupts before removal

with it, or see it merged. It's on my queue for 4.8: https://patchwork.kernel.org/patch/9209027/ -- Kalle Valo

Re: [linux-next] rtlwifi: Fix typo in printk

Masanari Iida wrote: > This patch fix spelling typos found in drivers/net/wireless/realtek. > > Signed-off-by: Masanari Iida > Reviewed-by: Julian Calaby Thanks, 1 patch applied to wireless-drivers-next.git: 8a1902374fa0

Re: wcn36xx: Silence error about unsupported smd event 188

Bjorn Andersson wrote: > Sometimes the firmware sends a HAL_DEL_BA_IND, the prima driver silently > ignore this message so let's do the same to silence the error message. > > Cc: Nicolas Dechesne > Signed-off-by: Bjorn Andersson

Re: mwifiex: mask PCIe interrupts before removal

Brian Norris wrote: > The PCIe driver didn't mask the host interrupts before trying to tear > down. This causes lockups at reboot or rmmod when using MSI-X on 8997, > since the MSI handler gets confused and locks up the system. > > Also tested on 8897, which does not

Re: [1/2] brcmfmac: delete interface directly in code that sent fw request

Rafał Miłecki wrote: > So far when receiving event about in-firmware-interface removal our > event worker was notifying listener and afterwards it was removing Linux > interface. > > First of all it was resulting in slightly unexpected order. The listener > (del_virtual_intf callback) was

Re: [1/6] wcn36xx: Fold indication payload into message header

Bjorn Andersson wrote: > From: Bjorn Andersson > > Merge the two allocation instead of separately allocating room for the > indication payload. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn

Re: [1/2] ath10k: remove unused

Chaehyun Lim wrote: > is not used anymore, so just remove it. > > Signed-off-by: Chaehyun Lim Thanks, 1 patch applied to ath-next branch of ath.git: a3dadad73324 ath10k: remove unused -- Sent by pwcli

Re: rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

Joe Perches wrote: > This debugging macro can expand to a lot of code. > Make it a function to reduce code size. > > (x86-64 defconfig w/ all rtlwifi drivers and allyesconfig) > $ size drivers/net/wireless/realtek/rtlwifi/built-in.o* >text data bss dec

Re: [PATCH v4] wlcore: spi: add wl18xx support

.c Failed to merge in the changes. Patch failed at 0001 wlcore: spi: add wl18xx support -- Kalle Valo

Re: rtlwifi: Add missing newlines to RT_TRACE calls

Joe Perches wrote: > RT_TRACE does not add a newline to the end of a message and always > emits at KERN_DEBUG so these are susceptible to message interleaving > from other processes without the newline. > > Signed-off-by: Joe Perches Thanks, 1 patch applied

Re: [v2] wlcore: time sync : add support for 64 bit clock

"Machani, Yaniv" wrote: > Changed the configuration to support 64bit instead of 32bit > this in order to offload the driver from handling a wraparound. > > Signed-off-by: Yaniv Machani Thanks, 1 patch applied to wireless-drivers-next.git: 585dfe813fa5 wlcore:

Re: mwifiex: fix unconditional error return in .add_virtual_intf callback

Javier Martinez Canillas wrote: > The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") attempted to fix an issue when a new AP interface is added. > > But the patch didn't check the return value of the functions doing the > firmware calls

Re: brcmfmac: slightly simplify building interface combinations

Rafał Miłecki wrote: > This change reorders some operations in brcmf_setup_ifmodes in hope to > make it simpler: > 1) It allocates arrays right before filling them. This way it's easier >to follow requested array length as it's immediately followed by >code filling it. It's easier to check

Re: libertas_tf: Remove create_workqueue

Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem (viz > >cmd_work per priv, which maps to lbtf_cmd_work) is involved in > actual command processing and may be used on a memory

Re: libertas: Add spinlock to avoid race condition

Pavel Andrianov wrote: > lbs_mac_event_disconnected may free priv->currenttxskb > while lbs_hard_start_xmit accesses to it. > The patch adds a spinlock for mutual exclusion. > > Tested on OLPC XO-1 (usb8388) and XO-1.5 (sd8686) with v4.7-rc3. > > Confirmed that

Re: wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq

Bruno Herrera wrote: > pdev_data pointer is being freed with kfree but the pointer is not dynamic > allocated. > > Signed-off-by: Bruno Herrera Thanks, 1 patch applied to wireless-drivers-next.git: 6edc119ed3b5 wlcore: sdio: Fix crash on

Re: [v2] rtlwifi: use s8 instead of char

Arnd Bergmann wrote: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited > range of data type

Re: [1/8] wireless: airo: rename 'register' variable

Arnd Bergmann wrote: > 'register' is a keyword in C and cannot be used in place of a > variable name, as shown by this -Wextra warning: > > drivers/net/wireless/cisco/airo.c:1105:29: error: 'register' is not at > beginning of declaration [-Werror=old-style-declaration] > > This

Re: [REBASED] brcmfmac: fix lockup when removing P2P interface after event timeout

Rafał Miłecki wrote: > Removing P2P interface is handled by sending a proper request to the > firmware. On success firmware triggers an event and driver's handler > removes a matching interface. > > However on event timeout we remove interface directly from the cfg80211 > callback. Current code

Re: brcmfmac: use const char * for interface name in brcmf_add_if

Rafał Miłecki wrote: > This function can work just fine with const pointer, it only calls > alloc_netdev which take const as well. Moreover it makes this function > more flexible as some cfg80211 callback may provide const char * as > well, e.g. add_virtual_intf. This will be needed for more

Re: brcmfmac: add missing break when deleting P2P_DEVICE

Rafał Miłecki wrote: > We obviously don't want to fall through in that switch. With this change > 1) We wait for event (triggered by p2p_disc) as expected > 2) We remove interface manually on timeout > 3) We return 0 on success instead of -ENOTSUPP > > Signed-off-by: Rafał Miłecki

Re: brcmfmac: include also core.h header in cfg80211.h

Rafał Miłecki wrote: > This header provides two inline functions using struct brcmf_if so we > need core.h to avoid: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h: In function > ‘ndev_to_prof’: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h:368:13: error: >

Re: [PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

module_platform_driver(ath_ahb_driver); > ^ > include/linux/device.h:1459:19: note: in definition of macro 'module_driver' > static int __init __driver##_init(void) \ >^~~~ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion

pull-request: wireless-drivers-next 2017-02-01

ph() void iwlwifi: allow memory debug TLV to specify the memory type iwlwifi: mvm: properly check for transport data in dump Jürg Billeter (1): iwlwifi: fix MODULE_FIRMWARE for 6030 Kalle Valo (3): ath10k: refactor ath10k_peer_assoc_h_phymode() Merge tag 'iwlwifi-ne

Re: wcn36xx: Implement cancel_hw_scan

Bjorn Andersson wrote: > In the event that the wcn36xx interface is brought down while a hw_scan > is active we must abort and wait for the ongoing scan to signal > completion to mac80211. > > Reported-by: Mart Raudsepp > Fixes: 886039036c20

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

file needs linux/module.h included. Johannes already fixed a similar (or same) problem in my tree: wil6210: include moduleparam.h https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b I'm planning to send you a pull request tomorrow which contains that one. -- Kalle Valo

pull-request: wireless-drivers 2017-02-06

Hi Dave, one more fix I still would like to get to 4.10 if possible. Please let me know if there are any problems. Kalle The following changes since commit 2b1d530cb3157f828fcaadd259613f59db3c6d1c: MAINTAINERS: ath9k-devel is closed (2017-01-28 09:15:50 +0200) are available in the git

Re: [1/3] ath10k: remove multiple defines of DIAG_TRANSFER_LIMIT

Srinivas Kandagatla wrote: > DIAG_TRANSFER_LIMIT is redefined with same value and comments > just below this entry, remove this duplicate entry. > > Signed-off-by: Srinivas Kandagatla 3 patches applied to ath-next branch of

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

Tony Lindgren <t...@atomide.com> writes: > * Pavel Machek <pa...@ucw.cz> [170127 11:41]: >> On Fri 2017-01-27 17:23:07, Kalle Valo wrote: >> > Pali Rohár <pali.ro...@gmail.com> writes: >> > >> > > On Friday 27 January 2017 14:26:22 K

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

t; - ret = request_firmware(, WL1251_NVS_NAME, dev); > + ret = request_firmware_prefer_user(, WL1251_NVS_NAME, dev); I don't see the need for this. Just remove the default nvs file from filesystem and the fallback user helper will be always used, right? Like we discussed earlier, the default nvs file should not be used by normal users. -- Kalle Valo

Re: [PATCH 5/6] wl1251: Parse and use MAC address from supplied NVS data

MAC is stored in reverse order */ > + for (i = 0; i < ETH_ALEN; i++) > + mac[i] = wl->nvs[0x1c + ETH_ALEN - i - 1]; No magic numbers, please. Replace all nvs offsets with proper defines to make the code more readable. -- Kalle Valo

Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data

es. > > Signed-off-by: Pali Rohár <pali.ro...@gmail.com> Why? What issue does this fix? -- Kalle Valo

Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data

Pali Rohár <pali.ro...@gmail.com> writes: > On Friday 27 January 2017 09:56:09 Kalle Valo wrote: >> Pali Rohár <pali.ro...@gmail.com> writes: >> >> > In case there is no valid MAC address kernel generates random one. This >> > patch propagate this

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

oses. We should not courage users using example calibration data. The simple fix is to rename the NVS file in linux-firmware to something like wl1251-nvs.bin.example, no need to workaround this in kernel. If you send a patch to linux-firmware I'm happy to ack that. -- Kalle Valo

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

Pali Rohár <pali.ro...@gmail.com> writes: > On Friday 27 January 2017 13:49:03 Kalle Valo wrote: >> Pali Rohár <pali.ro...@gmail.com> writes: >> >> >> So >> >> for those other platforms there will be a delay waiting for user-mode >> &

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

Pali Rohár <pali.ro...@gmail.com> writes: > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: >> Pali Rohár <pali.ro...@gmail.com> writes: >> >> > 2) It was already tested that example NVS data can be used for N900 e.g. >> > for SSH conne

pull-request: wireless-drivers 2017-01-29

. Jens Axboe (1): iwlwifi: fix kernel crash when unregistering thermal zone Johannes Berg (1): iwlwifi: mvm: avoid crash on restart w/o reserved queues Jürg Billeter (1): iwlwifi: fix double hyphen in MODULE_FIRMWARE for 8000 Kalle Valo (2

Re: [PATCH 3/3] mwifiex: wake system up when receives a wake irq

need to abort system suspend to avoid that. > > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> I only see patch 3 in patchwork. Where are patches 1 and 2? -- Kalle Valo

[PATCH] Revert "ath10k: Search SMBIOS for OEM board file extension"

cgi?id=185621#c9 Fixes: f2593cb1b291 ("ath10k: Search SMBIOS for OEM board file extension") Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> --- Dave, please take this directly if you can. drivers/net/wireless/ath/ath10k/core.c | 84 ++ drivers/n

Re: ath6kl: Use net_device_stats from struct net_device

Tobias Klauser wrote: > Instead of using a private copy of struct net_device_stats in struct > ath6kl_vif, use stats from struct net_device. Also remove the now > unnecessary .ndo_get_stats function. > > Signed-off-by: Tobias Klauser Patch applied to

Re: [1/3] ath10k: remove ath10k_vif_to_arvif()

Amadeusz Sławiński wrote: > it adds unnecessary level of indirection, while we just access structure > field > > Signed-off-by: Amadeusz Sławiński 3 patches applied to ath-next branch of ath.git, thanks. 56ac13bfc703 ath10k: remove ath10k_vif_to_arvif()

Re: ath9k: Access rchan::buf only with per_cpu helper

Sven Eckelmann wrote: > The relayfs was changed to use per CPU constructs to handle the rchan > buffers. But the users of the rchan buffers in other parts of the kernel > were not modified. This caused crashes like > > BUG: unable to handle kernel paging request at

Re: [PATCH] rt2500usb: don't mark register accesses as inline

, offset, > - value, length); > -} > - I guess you removed this because it was not actually used anywhere? Just checking. -- Kalle Valo

Re: rtlwifi: btcoexist: fix semicolon.cocci warnings

Julia Lawall wrote: > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > CC: Larry Finger > Signed-off-by: Julia Lawall > Signed-off-by: Fengguang Wu >

Re: orinoco: Use net_device_stats from struct net_device

Tobias Klauser wrote: > Instead of using a private copy of struct net_device_stats in > struct orinoco_private, use stats from struct net_device. Also remove > the now unnecessary .ndo_get_stats function. > > Signed-off-by: Tobias Klauser Patch applied

Re: brcmfmac: Use net_device_stats from struct net_device

Tobias Klauser wrote: > Instead of using a private copy of struct net_device_stats in struct > brcm_if, use stats from struct net_device. Also remove the now > unnecessary .ndo_get_stats function. > > Signed-off-by: Tobias Klauser > Acked-by: Arend van

Re: rt2500usb: don't mark register accesses as inline

Arnd Bergmann wrote: > When CONFIG_KASAN is set, we get a rather large stack here: > > drivers/net/wireless/ralink/rt2x00/rt2500usb.c: In function > 'rt2500usb_set_device_state': > drivers/net/wireless/ralink/rt2x00/rt2500usb.c:1074:1: error: the frame size > of 3032 bytes is

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

ommit/?id=949c2d0096753d518ef6e0bd8418c8086747196b >> >> I'm planning to send you a pull request tomorrow which contains that >> one. > > Thanks Kalle! > > David, can you hold on this series until Kalle's pull request gets > submitted? Past this error, allmodconfig builds fine with this patch > series (just tested). Thanks! Just submitted the pull request: https://patchwork.ozlabs.org/patch/726133/ -- Kalle Valo

pull-request: wireless-drivers-next 2017-02-09

iwlwifi: pcie: fix another RF-kill race mwifiex: don't include mac80211.h wil6210: include moduleparam.h ath10k: select WANT_DEV_COREDUMP Kalle Valo (6): Merge tag 'iwlwifi-next-for-kalle-2017-02-06' of git://git.kernel.org/.../iwlwifi/iwlwifi-next ath10k: prefer

pull-request: wireless-drivers-next 2017-02-17

semicolon.cocci warnings Kalle Valo (4): ath10k: fix napi crash during rmmod when probe firmware fails ath10k: add directory to board data error message ath10k: convert warning about non-existent OTP board id to debug message Merge ath-next from git://git.kernel.org/.../kvalo/ath.git

Re: libertas: fix improper return value

Pan Bian wrote: > Function lbs_cmd_802_11_sleep_params() always return 0, even if the call > to lbs_cmd_with_response() fails. In this case, the parameter @sp will > keep uninitialized. Because the return value is 0, its caller (say > lbs_sleepparams_read()) will not detect

Re: mwifiex: fix uninitialized variable access in pcie_remove

Arnd Bergmann wrote: > Checking the firmware status from PCIe register only works > if the register is available, otherwise we end up with > random behavior: > > drivers/net/wireless/marvell/mwifiex/pcie.c: In function > 'mwifiex_pcie_remove': >

Re: [1/1] net: wireless: marvell: fix improper return value

Pan Bian wrote: > Function lbs_cmd_802_11_sleep_params() always return 0, even if the call > to lbs_cmd_with_response() fails. In this case, the parameter @sp will > keep uninitialized. Because the return value is 0, its caller (say > lbs_sleepparams_read()) will not detect

Re: [1/5] ath10k: Remove unused 'buf_len' variable

kernel. > > Fixes: 32653cf19554 ("ath10k: implement intermediate event args") > Cc: Michal Kazior <michal.kaz...@tieto.com> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org> These patches seem to be corrupt

Re: [PATCH] net: ethtool: avoid allocation failure for dump_regs

r using it years back with something else than at76c50x-usb. But is the number more than one, I don't know :) >> Possible solutions: >> >> -- break userland ethtool for at76c50x-usb >> -- avoid 0-len allocation attempt (David Arcari's patch) >> -- make allocator accept a 0 length value w/o oops'ing >> -- change mac8011 code to return non-zero from get_regs_len() >> >> Thoughts? The last option holds a certain attraction, but I'm not >> sure how to make it useful...? If it were only about at76c50x-usb I would say go for it, nobody sane should use that device anymore. But on the other hand I'm worried that this interface might be used by other (proprietary) user space tools with other, more important, drivers. A difficult situation. -- Kalle Valo

Re: [PATCH] net: ethtool: avoid allocation failure for dump_regs

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Thu, 19 Jan 2017 20:08:30 +0200 > >> "John W. Linville" <linvi...@tuxdriver.com> writes: >> >>> I forgot to Cc Johannes and Kalle... >> &

Re: [PATCH 0/3] hostap: Fine-tuning for a few functions

not really sure what to do with these obsolete drivers like hostap, ray_cs and wl3501. -- Kalle Valo

pull-request: wireless-drivers 2017-03-02

extension drivers/net/wireless/ath/ath10k/core.c | 101 - drivers/net/wireless/ath/ath10k/core.h | 19 +++ 2 files changed, 117 insertions(+), 3 deletions(-) -- Kalle Valo

Re: [2/2] ath10k: use complete() instead complete_all()

Daniel Wagner wrote: > From: Daniel Wagner > > There is only one waiter for the completion, therefore there > is no need to use complete_all(). Let's make that clear by > using complete() instead of complete_all(). > > The usage pattern of the

Re: [PATCH v3 1/2] wcn36xx: Transition driver to SMD client

Is there any way we could continue build testing wcn36xx on x86 (or all) platforms? Also what about older platforms? Earlier I used wcn36xx on my Nexus 4 with help of backports project. I can't do that anymore, right? -- Kalle Valo

Re: ath10k: replace config_enabled() with IS_REACHABLE()

Masahiro Yamada wrote: > Commit 97f2645f358b ("tree-wide: replace config_enabled() with > IS_ENABLED()") mostly did away with config_enabled(). > > This is one of the postponed TODO items as config_enabled() is used > for a tristate option here. Theoretically,

Re: ath10k: fix spelling mistake "montior" -> "monitor"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in ath10k_warn message. > > Signed-off-by: Colin Ian King > Reviewed-by: Julian Calaby Thanks, 1 patch

Re: [v2] ath9k: mark ath_fill_led_pin() static

Baoyou Xie wrote: > We get 1 warning about global functions without a declaration > in the ath9k gpio driver when building with W=1: > drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype > for 'ath_fill_led_pin' [-Wmissing-prototypes] > > In fact,

Re: [PATCH v3 1/2] wcn36xx: Transition driver to SMD client

Bjorn Andersson <bjorn.anders...@linaro.org> writes: > On Fri 02 Sep 09:24 PDT 2016, Kalle Valo wrote: > >> Bjorn Andersson <bjorn.anders...@linaro.org> writes: >> >> > --- a/drivers/net/wireless/ath/wcn36xx/Kconfig >> > +++ b/drivers/ne

Re: zd1211rw: fix spelling mistake "firmeware" -> "firmware"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err message. > > Signed-off-by: Colin Ian King > Reviewed-by: Julian Calaby Thanks, 1 patch applied

Re: wcn36xx: Implement print_reg indication

Bjorn Andersson wrote: > Some firmware versions sends a "print register indication", handle this > by printing out the content. > > Cc: Nicolas Dechesne > Signed-off-by: Bjorn Andersson This doesn't apply anymore, please

Re: [v2,1/1] brcmfmac: fix pmksa->bssid usage

Nicolas Iooss wrote: > The struct cfg80211_pmksa defines its bssid field as: > > const u8 *bssid; > > contrary to struct brcmf_pmksa, which uses: > > u8 bssid[ETH_ALEN]; > > Therefore in brcmf_cfg80211_del_pmksa(), >bssid takes the address > of this field

Re: ath9k: bring back direction setting in ath9k_{start_stop}

well. > > Cc: Miaoqing Pan <miaoq...@codeaurora.org> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> I'm planning to queue this to 4.8 if no objections. -- Sent by pwcli https://patchwork.kernel.org/patch/9309829/

Re: ath9k: bring back direction setting in ath9k_{start_stop}

Kalle Valo <kv...@qca.qualcomm.com> writes: > Giedrius Statkevi?ius <giedrius.statkevic...@gmail.com> wrote: >> A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup >> led_pin initial") that broken the WLAN status led on my laptop with &g

Re: ath9k: bring back direction setting in ath9k_{start_stop}

well. > > Cc: Miaoqing Pan <miaoq...@codeaurora.org> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> Thanks, 1 patch applied to ath-next branch of ath.git: 088a

Re: ath9k: bring back direction setting in ath9k_{start_stop}

well. > > Cc: Miaoqing Pan <miaoq...@codeaurora.org> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> Thanks, 1 patch applied to ath-current branch of ath.git:

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

les changed, 86 insertions(+), 66 deletions(-) So I don't actually need to enable COMPILE_TEST anymore? Nice, thanks. -- Kalle Valo

Re: [PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

;> 1 file changed, 13 insertions(+) >> > > This is fine. > > Acked-by: Andy Gross <andy.gr...@linaro.org> Thanks. I'll then apply this to my ath.git tree and it will go to Linus via net-next. -- Kalle Valo

pull-request: wireless-drivers 2016-09-08

iwlwifi: mvm: don't use ret when not initialised Giedrius Statkevičius (1): ath9k: bring back direction setting in ath9k_{start_stop} Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2016-08-29' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge ath-current from ath.git

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

om_smd_set_drvdata(struct qcom_smd_channel *channel, void *data) +static inline void qcom_smd_set_drvdata(struct qcom_smd_channel *channel, void *data) { /* This shouldn't be possible */ WARN_ON(1); -- Kalle Valo

Re: rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in dev_dbg message. > > Signed-off-by: Colin Ian King > Reviewed-by: Julian Calaby I assume Jes will take

Re: wl3501_cs: Add spinlock to wl3501_reset

Pavel Andrianov wrote: > Likely wl3501_reset should acquire spinlock as wl3501_{open, close}. > One of calls of wl3501_reset has been already protected. > The others were unprotected and might lead to a race condition. > The patch adds spinlock into the wl3501_reset and

Re: [1/1,v2] rtlwifi: remove superfluous condition

Heinrich Schuchardt wrote: > If sta == NULL, the changed line will not be reached. > So no need to check that sta != NULL here. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Larry Finger Thanks, 1 patch applied to

Re: mwifiex: fix missing break on IEEE80211_STYPE_ACTION case

Colin Ian King wrote: > From: Colin Ian King > > The IEEE80211_STYPE_ACTION case is missing a break in the switch > statement, causing it to fall through to the default case that > reports a debug message about an unknown frame subtype. Fix

Re: fix:rtl8xxxu_core: mark symbols static where possible

Baoyou Xie wrote: > We get 1 warning about global functions without a declaration > in the rtl8xxxu rtl8xxxu_core.c when building with W=1: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: warning: no > previous prototype for 'rtl8xxxu_gen1_h2c_cmd'

Re: [1/2] mwifiex: fix the length parameter of a memset

Christophe Jaillet wrote: > In 'mwifiex_get_ver_ext', we have: >struct mwifiex_ver_ext ver_ext; > >memset(_ext, 0, sizeof(struct host_cmd_ds_version_ext)); > > This is likely that memset'ing sizeof(struct mwifiex_ver_ext) was expected. > Remove the

Re: [1/1] mwifiex: key_material_v2 remove superfluous condition

Heinrich Schuchardt wrote: > We are using mac as source address in a memcpy. > In the lines below we can assume mac is not NULL. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch applied to

Re: [v4] brcmfmac: add missing header dependencies

Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: > no previous prototype for '__brcmf_err' [-Wmissing-prototypes] > > In fact, this function is declared in

Re: [1/1] mwifiex: remove superfluous condition

Heinrich Schuchardt wrote: > for_each_property_of_node is only executed if the > property prop is not NULL. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch applied to wireless-drivers-next.git:

Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. > > Signed-off-by: Javier Martinez Canillas What's the

<    1   2   3   4   5   6   7   8   9   10   >