Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

Johan Hovold <jo...@kernel.org> writes: > On Mon, Apr 03, 2017 at 01:02:28PM +0000, Kalle Valo wrote: >> Kalle Valo <kv...@codeaurora.org> writes: >> >> > Johan Hovold <jo...@kernel.org> writes: >> > >> >> On Mon, Mar 13, 2017 at

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

Kalle Valo <kv...@codeaurora.org> writes: > Johan Hovold <jo...@kernel.org> writes: > >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >>> Make sure to check the number of endpoints to avoid dereferencing a >>> NULL-pointer or accessi

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

, I'm just lacking behing: https://patchwork.kernel.org/patch/9620723/ > As I mentioned earlier, I should have added a > > Cc: stable <sta...@vger.kernel.org> # 2.6.39 > > but left it out as I mistakingly thought the net recommendations to do > so applied also to wireless. Ok, I'll add that. -- Kalle Valo

Re: [PATCH net-next v5 4/5] netlink: pass extended ACK struct to parsing functions

e a reason you ignore my comments about > narrow descriptions? Why don't you use the whole line? Seriously, you ask that with totally unnecessary 3800 lines of quotes? (Or at least I assume so, I didn't bother to check if you had any comments there as it would have taken forever to find them.) -- Kalle Valo

Re: [PATCH] mwifiex: MAC randomization should not be persistent

romium.org> > --- > Should this be tagged for -stable? IMHO yes. -- Kalle Valo

Re: ath9k: Add cast to u8 to FREQ2FBIN macro

Matthias Kaehlcke wrote: > The macro results are assigned to u8 variables/fields. Adding the cast > fixes plenty of clang warnings about "implicit conversion from 'int' to > 'u8'". > > Signed-off-by: Matthias Kaehlcke Patch applied to ath-next branch of

pull-request: wireless-drivers-next 2017-04-21

/lower_32_bits where appropriate iwlwifi: pcie: use iwl_get_dma_hi_addr() iwlwifi: pcie: fix mutex leak in gen2 start iwlwifi: pcie: free context info in case of failures Kalle Valo (3): Merge tag 'iwlwifi-next-for-kalle-2017-04-13' of git://git.kernel.org/.../iwlwifi/iwlwifi-next

Re: [PATCH] mwifiex: MAC randomization should not be persistent

Brian Norris <briannor...@chromium.org> writes: > On Thu, Apr 06, 2017 at 07:02:15AM +0300, Kalle Valo wrote: >> Brian Norris <briannor...@chromium.org> writes: >> >> > nl80211 provides the NL80211_SCAN_FLAG_RANDOM_ADDR for every scan >> > r

Re: ath6kl: Add __printf verification to ath6kl_dbg

Joe Perches wrote: > Fix fallout too. > > Signed-off-by: Joe Perches > Reviewed-by: Steve deRosier Patch applied to ath-next branch of ath.git, thanks. 169345d40d0f ath6kl: add __printf verification to ath6kl_dbg --

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

s.hug...@raspberrypi.org> You should also CC linux-wireless, otherwise patchwork won't see it. -- Kalle Valo

Re: [PATCH net-next] brcmfmac: fix build without CONFIG_BRCMFMAC_PROTO_BCDC

a from struct > brcmf_pub") > Signed-off-by: Arnd Bergmann <a...@arndb.de> The fix is actually for wireless-drivers-next, acf8ac41dd73 is not in net-next yet. And I already applied an identical fix from Arend: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=26ecfe01790381c4caa65ec9cce484c623f092c4 -- Kalle Valo

Re: mwifiex: MAC randomization should not be persistent

Brian Norris wrote: > nl80211 provides the NL80211_SCAN_FLAG_RANDOM_ADDR for every scan > request that should be randomized; the absence of such a flag means we > should not randomize. However, mwifiex was stashing the latest > randomization request and *always* using it

Re: wireless/atmel: remove time_t usage

Alexandre Belloni <alexandre.bell...@free-electrons.com> writes: > Hi, > > On 08/03/2017 at 15:13:40 +0000, Kalle Valo wrote: >> Alexandre Belloni <alexandre.bell...@free-electrons.com> wrote: >> > last_qual never really holds a time. It only holds jiffies. M

Re: wcn36xx: Fix error handling

Christophe Jaillet wrote: > Reorder 'out_free_dxe_pool' and 'out_free_dxe_ctl' error handling labels > in order to match the way resources have been allocated. > > Signed-off-by: Christophe JAILLET Patch applied to ath-next branch

Re: rtlwifi: fix spelling mistake: "conuntry" -> "country"

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 3e062eb21df8 rtlwifi: fix

Re: wireless/atmel: remove time_t usage

Alexandre Belloni wrote: > last_qual never really holds a time. It only holds jiffies. Make it the > same type as jiffies. > > Signed-off-by: Alexandre Belloni The title should start with "atmel:", I can fix that

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

ables as >> 'static const' as I can without changing the actual code. > > Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Arnd, via which tree are you planning to submit these? I'm not sure what I should do with the wireless drivers patches from this series. -- Kalle Valo

Re: [PATCH 10/26] brcmsmac: reindent split functions

c| 1507 >> +--- >> 1 file changed, 697 insertions(+), 810 deletions(-) >> Arend, please edit your quotes. Leaving 1000 lines of unnecessary quotes in your reply makes my use of patchwork horrible: https://patchwork.kernel.org/patch/9601155/ -- Kalle Valo

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

Arnd Bergmann <a...@arndb.de> writes: > On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo <kv...@codeaurora.org> wrote: >> Arend Van Spriel <arend.vanspr...@broadcom.com> writes: >> >>> On 2-3-2017 17:38, Arnd Bergmann wrote: >>>> With KASAN and

Re: [PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

UD, >> - " ===> althougth Path A, we load radiob.txt\n"); >> + " ===> though Path A, we load radiob.txt\n"); Wasn't this supposed to be "through"? Or did I miss something? -- Kalle Valo

Re: pull-request: wireless-drivers-next 2017-04-03

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Tue, 04 Apr 2017 20:48:35 +0300 > >> David Miller <da...@davemloft.net> writes: >> >>> From: Kalle Valo <kv...@codeaurora.org> >>> Date:

Re: [PATCH 1/7] Documentation: dt: net: Update the ath9k binding for SoC devices

'm just guessing. > Signed-off-by: Alban <al...@free.fr> Please use your full name both in From and S-o-b lines. -- Kalle Valo

Re: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t

), 7 deletions(-) >> >> The prefix should be "orinoco_usb:", I'll fix that. > > Thanks for both! Will you take the patches in? You mean patches 15 and 16? I didn't even look rest of the patches. But not sure yet because Dave doesn't seem to like the interface and I want to follow the discussion first. -- Kalle Valo

Re: [V2] wlcore: fix spelling mistakes in wl1271_warning

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistakes in wl1271_warning error message, change > iligal to invalid and opperation to operation. > > Signed-off-by: Colin Ian King Patch

pull-request: wireless-drivers-next 2017-04-07

print the firmware version as an error brcmfmac: Do not complain about country code "00" brcmfmac: Handle status == BRCMF_E_STATUS_ABORT in cfg80211_escan_handler Jeffy Chen (1): mwifiex: wake system up when receives a wake irq Johan Hovold (1): zd1211rw: fi

pull-request: wireless-drivers-next 2017-07-28

Hi Dave, here's a pull request for net, more info the signed tag below. Please let me know if there are any problems. Kalle The following changes since commit d755cbc26e8295ae8e5d30425364e093b4247a85: Merge tag 'iwlwifi-for-kalle-2017-07-21' of

Re: pull-request: wireless-drivers-next 2017-07-28

Kalle Valo <kv...@codeaurora.org> writes: > Hi Dave, > > here's a pull request for net, more info the signed tag below. Please > let me know if there are any problems. > > Kalle > > The following changes since commit d755cbc26e8295ae8e5d30425364e093b4247a85: >

Re: zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate'

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in PDEBUG debug message. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. af643fe9bbe0

Re: [v3,04/10] ipw2200: constify attribute_group structures

Kalle Valo <kv...@codeaurora.org> writes: > Arvind Yadav <arvind.yadav...@gmail.com> wrote: > >> attribute_group are not supposed to change at runtime. All functions >> working with attribute_group provided by work >> with const attribute_group. So

Re: mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in mwifiex_dbg debug message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 17830147c40a

Re: wl3501_cs: fix spelling mistake: "Insupported" -> "Unsupported"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in printk message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. fcc870d76a2c wl3501_cs: fix

Re: [v3,04/10] ipw2200: constify attribute_group structures

Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Arvind Yadav <arvind.yadav...@gmail.com> wrote: >> >>> attribute_group are not supposed to change at runtime. All functions >>> working with attribute_

Re: mwifiex: usb: fix spelling mistake: "aggreataon"-> "aggregation"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in aggr_ctrl module parameter > message text. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

Re: [v3,04/10] ipw2200: constify attribute_group structures

Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work > with const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: [v2] mwifiex: uninit wakeup info in the error handling

Jeffy Chen wrote: > We inited wakeup info at the beginning of mwifiex_add_card, so we need > to uninit it in the error handling. > > It's much the same as what we did in: > 36908c4 mwifiex: uninit wakeup info when removing device > > Signed-off-by: Jeffy Chen

Re: [11/11] brcmfmac: constify pci_device_id

Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav >

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

pery slope and best to clean that up before adding any new API. > > That and also Greg recently stated he would like to see at least 3 users of > a feature before adding it. Although I think that's pretty arbitrary, and > considering that request_firmware_into_buf() only has *one* user -- its what > he wishes. ath10k at least needs a way to silence the warning for missing firmware and I think iwlwifi also. -- Kalle Valo

Re: qtnfmac: Tidy up DMA mask setting

Robin Murphy wrote: > As the only caller of dma_supported() outside of DMA API internals, the > qtfnmac driver stands out and invites scrutiny. Thankfully, it's not > being used for evil, but it is entirely redundant, since it open-codes a > check that the DMA mask setting

Re: [01/11] rtlwifi: rtl8192de: constify pci_device_id.

Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > File size before: >text data bss dec

Re: [net] hostap: Fix outdated comment about dev->destructor

Stefano Brivio wrote: > After commit cf124db566e6 ("net: Fix inconsistent teardown and > release of private netdev state."), setting > 'dev->needs_free_netdev' ensures device data is released, and > 'dev->destructor' is not used anymore. > > Fixes: cf124db566e6 ("net: Fix

Re: qtfnmac: Tidy up DMA mask setting

Robin Murphy wrote: > As the only caller of dma_supported() outside of DMA API internals, the > qtfnmac driver stands out and invites scrutiny. Thankfully, it's not > being used for evil, but it is entirely redundant, since it open-codes a > check that the DMA mask setting

Re: [10/11] net: qtnfmac: constify pci_device_id.

Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav >

pull-request: wireless-drivers 2017-08-15

race happens in A-MPDU Gregory Greenman (2): iwlwifi: mvm: set A-MPDU bit upon empty BA notification from FW iwlwifi: mvm: rs: fix TLC statistics collection Haim Dreyfuss (1): iwlwifi: fix fw_pre_next_step to apply also for C step Kalle Valo (2): Merge tag 'iwlwifi-for-kalle

Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

release. -- Kalle Valo

Re: [v2,01/20] ar5523: constify usb_device_id

Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav 17

Re: [v2,06/20] brcm80211: constify usb_device_id

Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

he patch submission and that's why I'm asking. -- Kalle Valo

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

Kalle Valo <kv...@codeaurora.org> writes: > Andreas Born <futur.a...@googlemail.com> writes: > >> Earlier today I submitted the patch (bonding: require speed/duplex >> only for 802.3ad, alb and tlb) [2] that only partially reverts what is >> a regressi

Re: [v2,02/20] ath6kl: constify usb_device_id

rvind.yadav...@gmail.com> > Reviewed-by: Steve deRosier <deros...@gmail.com> > Tested-by: Steve deRosier <deros...@gmail.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> 2 patches applied to ath-next branch of ath.git, thanks. e881a6584941 ath6kl: constify us

Re: [v3,06/20] brcm80211: constify usb_device_id

Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: ath10k: ret used but uninitialized

* through the loop again due to updated lookaheads. Set @@ -721,11 +725,7 @@ static int ath10k_sdio_mbox_rxmsg_pending_handler(struct ath10k *ar, *done = false; } - if (ret && (ret != -ECANCELED)) - ath10k_warn(ar, "failed to get pending recv messages: %d\n", - ret); - - return ret; + return 0; } static int ath10k_sdio_mbox_proc_dbg_intr(struct ath10k *ar) -- Kalle Valo

Re: [Patch net] wl1251: add a missing spin_lock_init()

, .owner: /-1, >> .owner_cpu: 0 > ... >> by adding the missing spin_lock_init(). >> >> Reported-by: Pavel Machek <pa...@ucw.cz> >> Cc: Kalle Valo <kv...@codeaurora.org> >> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> > >

Re: [PATCH] mwifiex: fix compile warning of unused variable

h accordingly. (W=1 warnings are not that important so they go automatically to -next) -- Kalle Valo

Re: [PATCH v2 00/10] Constify attribute_group structures

structures. > [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures. Via which tree were you planning to push these? Is it ok if I take the wireless patches to my tree? -- Kalle Valo

Re: [PATCH] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

ed. > + - interrupts : specifies attributes for the out-of-band interrupt > (host-wake). > + When not specified the device will use in-band SDIO interrupts. Where is the driver which uses this? I don't see it in drivers/net/wireless but I guess that's not a blocker for the bindings? -- Kalle Valo

Re: [-next] rtlwifi: kfree entry until after entry->bssid has been accessed

Colin Ian King wrote: > From: Colin Ian King > > The current code kfree's entry and then dereferences it by accessing > entry->bssid. Avoid the dereference-after-free by moving the kfree > after the access to entry->bssid. > > Detected by

Re: [net] wl1251: add a missing spin_lock_init()

start_xmit+0x454/0x8c8) > [ 5668.776824] [] (__ieee80211_subif_start_xmit) from > [] (ieee80211_subif_start_xmit+0x30/0x2fc) > [ 5668.777343] [] (ieee80211_subif_start_xmit) from > [] (dev_hard_start_xmit+0x80/0x118) > ... > > by adding the missing spin_lock_init(). > >

pull-request: wireless-drivers 2017-07-21

dereference of error in recovery iwlwifi: fix tracing when tx only is enabled Johannes Berg (1): iwlwifi: mvm: defer setting IWL_MVM_STATUS_IN_HW_RESTART Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2017-07-21' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Larry Finger (1

Re: cw1200: add const to hwbus_ops structures

Bhumika Goyal wrote: > Declare hwbus_ops structures as const as they are only passed as an > argument to the function cw1200_core_probe. This argument is of type > const. So, make these structures const. > > Signed-off-by: Bhumika Goyal Patch applied to

Re: wl18xx: add checks on wl18xx_top_reg_write() return value

"Gustavo A. R. Silva" wrote: > Check return value from call to wl18xx_top_reg_write(), > so in case of error jump to goto label out and return. > > Also, remove unnecessary value check before goto label out. > > Addresses-Coverity-ID: 1226938 > Signed-off-by: Gustavo

Re: mwifiex: fix spelling mistake: "secuirty" -> "security"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in mwifiex_dbg message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 3334c28ec56c mwifiex:

pull-request: wireless-drivers-next 2017-06-30

iwlwifi: document transmit buffer bits better iwlwifi: pcie: make iwl_pcie_apm_stop_master() return void iwlwifi: pcie: work around suspend/resume issue Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2017-06-28' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next fro

Re: WARN_ON_ONCE(work > weight) in napi_poll()

loads is preferred. As you are using XPS 13 I'm guessing it's one of QCA6174 family. -- Kalle Valo

pull-request: wireless-drivers-next 2017-07-03

client mode special case iwlwifi: mvm: quietly accept non-sta disassoc frames Kalle Valo (1): Merge tag 'iwlwifi-next-for-kalle-2017-06-30' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Liad Kaufman (3): iwlwifi: mvm: support aggs of 64 frames in A000 family iwlwifi: mvm: su

Re: [PATCH] mwifiex: fix compile warning of unused variable

; is probably dead. I don't see that warning, any ideas why? My compiler: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 -- Kalle Valo

Re: [v2] brcmfmac: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

Christophe Jaillet wrote: > If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error > handling path to free it in such a case. > > Cc: sta...@vger.kernel.org > Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") > Signed-off-by:

Re: ath9k: remove useless variable assignment in ath_mci_intr()

-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 6788a3832c70 ath9k: remove useless variable assignment in ath_mci_intr() -- https://patchwork.kernel.org/patch/9810609/ https://wirele

Re: ath10k: add const to thermal_cooling_device_ops structure

off-by: Bhumika Goyal <bhumi...@gmail.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 1cdb6c9fd433 ath10k: add const to thermal_cooling_device_ops structure -- https://patchwork.kernel.org/patch/9801291/ https://wi

Re: [PATCH] rsi: add in missing RSI_FSM_STATES into array fsm_state

common device configuration") Fixes: 015e367494c1 ("rsi: Register interrupt handler before firmware load") Documentation/process/submitting-patches.rst contains a nice tip how you can get that automatically with git: [core] abbrev = 12 [pretty] fixes = Fixes: %h (\"%s\") -- Kalle Valo

Re: ti: wl18xx: add checks on wl18xx_top_reg_write() return value

"Gustavo A. R. Silva" wrote: > Check return value from call to wl18xx_top_reg_write(), > so in case of error jump to goto label out and return. > > Also, remove unnecessary value check before goto label out. > > Addresses-Coverity-ID: 1226938 > Signed-off-by: Gustavo

Re: [-next] ath10k: fix a bunch of spelling mistakes in messages

Colin Ian King <colin.k...@canonical.com> wrote: > Fix the following spelling mistakes in messages: > syncronise -> synchronize > unusally -> unusually > addrress -> address > inverval -> interval > > Signed-off-by: Colin Ian King <colin.k...@

Re: [net-next] qtnfmac: fix uninitialized return code in ret

Colin Ian King wrote: > From: Colin Ian King > > The return value ret is unitialized and garbage is being returned > for the three different error conditions when setting up the PCIe > BARs. Fix this by initializing ret to -ENOMEM to

Re: rsi: add in missing RSI_FSM_STATES into array fsm_state

Colin Ian King wrote: > From: Colin Ian King > > Two recent commits added new RSI_FSM_STATES (namely FSM_FW_NOT_LOADED > and FSM_COMMON_DEV_PARAMS_SENT) and the corresponding table fsm_state > was not updated to match. This can lead to an

Re: [v3] brcmfmac: Make skb header writable before use

James Hughes wrote: > The driver was making changes to the skb_header without > ensuring it was writable (i.e. uncloned). > This patch also removes some boiler plate header size > checking/adjustment code as that is also handled by the > skb_cow_header function used

Re: orinoco: fix spelling mistake: "Registerred" -> "Registered"

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in dbg_dbg message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. bea35f90dbb1 orinoco: fix

Re: orinoco_usb: Fix buffer on stack

Maksim Salau wrote: > Allocate buffer on HEAP instead of STACK for a local variable > that is to be sent using usb_control_msg(). > > Signed-off-by: Maksim Salau Patch applied to wireless-drivers-next.git, thanks. 2f6ae79cb04b orinoco_usb: Fix

Re: [1/1] rndis_wlan: add return value validation

Pan Bian wrote: > From: Pan Bian > > Function create_singlethread_workqueue() will return a NULL pointer if > there is no enough memory, and its return value should be validated > before using. However, in function rndis_wlan_bind(), its return value

Re: [v2] brcmfmac: Ensure pointer correctly set if skb data location changes

James Hughes wrote: > The incoming skb header may be resized if header space is > insufficient, which might change the data adddress in the skb. > Ensure that a cached pointer to that data is correctly set by > moving assignment to after any possible changes. > >

Re: [1/1] mt7601u: check return value of alloc_skb

Pan Bian wrote: > Function alloc_skb() will return a NULL pointer if there is no enough > memory. However, in function mt7601u_mcu_msg_alloc(), its return value > is not validated before it is used. This patch fixes it. > > Signed-off-by: Pan Bian >

Re: [1/1] libertas: check return value of alloc_workqueue

Pan Bian wrote: > From: Pan Bian > > Function alloc_workqueue() will return a NULL pointer if there is no > enough memory, and its return value should be validated before using. > However, in function if_spi_probe(), its return value is not checked. >

pull-request: wireless-drivers-next 2017-04-27

le loading failure message iwlwifi: pcie: apply no-reclaim logic only to group 0 Kalle Valo (1): Merge tag 'iwlwifi-next-for-kalle-2017-04-26' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Larry Finger (1): rtlwifi: rtl8821ae: setup 8812ae RFE according to device type Liad

Re: [PATCH v2] brcmfmac: Make skb header writable before use

ix. Probably will have to wait until after >> the merge window before it can get in the wireless-drivers repo. > > Hi Kalle, > > I should have checked kernel mailing list first as Linus added another > rc cycle. So can this patch still go in wireless-drivers-next for 4.12 > kernel. Yup, I'll queue it for 4.12. > I want it for stable as well, but I will look at that when it lands > upstream. Ok, so I don't add any stable tag during commit. -- Kalle Valo

Re: mwifiex: fix compile warning of unused variable

Shawn Lin wrote: > We got a compile warning shows below: > > drivers/net/wireless/marvell/mwifiex/sdio.c: In function > 'mwifiex_sdio_remove': > drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable > 'ret' set but not used [-Wunused-but-set-variable] >

Re: rt2x00: make const array glrt_table static

Colin Ian King wrote: > From: Colin Ian King > > Don't populate array glrt_table on the stack but make it static. > Makes the object code a smaller by over 670 bytes: > > Before: >text data bss dec hex filename >

Re: rt2x00: make const array glrt_table static

Kalle Valo <kv...@codeaurora.org> writes: > Colin Ian King <colin.k...@canonical.com> wrote: > >> From: Colin Ian King <colin.k...@canonical.com> >> >> Don't populate array glrt_table on the stack but make it static. >> Makes the object code a smal

Re: ath9k: make ath_ps_ops structures as const

Bhumika Goyal <bhumi...@gmail.com> wrote: > ath_ps_ops structures are only stored as a reference in the ps_ops > field of a ath_common structure. This field is of type const, so make > the structures as const. > > Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> >

Re: wcn36xx: Introduce mutual exclusion of fw configuration

to be ensured with > sta_remove(). > > This is done by introducing a mutex to cover firmware configuration > changes, which is made to also ensure mutual exclusion between other > operations changing the state or configuration of the firmware. With > this we can drop the rcu r

Re: [PATCH 00/35] constify net usb_device_id

[PATCH 16/35] ar5523: constify usb_device_id [PATCH 17/35] ath6kl: constify usb_device_id [PATCH 18/35] ath9k: constify usb_device_id Please resubmit the wireless patches separately in their own patchset. -- Kalle Valo

Re: [1/2] wlcore: add const to bin_attribute structure

Bhumika Goyal wrote: > Add const to bin_attribute structure as it is only passed to the > functions sysfs_{remove/create}_bin_file. The corresponding arguments > are of type const, so declare the structure to be const. > > Signed-off-by: Bhumika Goyal

Re: [v2] rtlwifi: constify rate_control_ops structure

Bhumika Goyal wrote: > rate_control_ops structure is only passed as an argument to the > function ieee80211_rate_control_{register/unregister}. This argument > is of type const, so declare the structure as const. > > Signed-off-by: Bhumika Goyal Patch

Re: [v3] ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg()

k_dbg() here too. > > Signed-off-by: Gabriel Craciunescu <nix.or....@gmail.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 984eb9053280 ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg() -- https://patchwork.kerne

pull-request: wireless-drivers-next 2017-08-07

lwifi: mvm: require AP_LINK_PS for TVQM iwlwifi: mvm: simplify bufferable MMPDU check iwlwifi: mvm: remove non-DQA mode Kalle Valo (3): ath10k: fix indenting in ath10k_wmi_update_noa() Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Merge tag 'iwlwif

Re: [049/102] ath10k: explicitly request exclusive reset control

t; control behavior. Convert all drivers requesting exclusive resets to the > explicit API call so the temporary transition helpers can be removed. > > No functional changes. > > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: ath...@lists.infradead.org > Cc: linux-wirel..

Re: [PATCH v12 7/8] wireless: ipw2200: Replace PCI pool old API

hence it's not on my queue. Please resend. [1] https://patchwork.kernel.org/project/linux-wireless/list/ -- Kalle Valo

Re: [PATCH] drivers: net: wireless: atmel: check memory allocation failure

tation/submittingpatches#commit_title_is_wrong -- Kalle Valo

Re: [PATCH 3/3 v2] net: netlink: constify genl_ops

1da tipc: fix nametbl deadlock at tipc_nametbl_unsubscribe cdfbabfb2f0c net: Work around lockdep limitation in sockets that use sockets 174cd4b1e5fb sched/headers: Prepare to move signal wakeup & sigpending methods from into -- Kalle Valo

Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops

l.com> > --- > net/tipc/netlink_compat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Using the prefix "rsi:" looks wrong for this patch. -- Kalle Valo

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

n_missing https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing -- Kalle Valo

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

Arend van Spriel <arend.vanspr...@broadcom.com> writes: > On 5/12/2017 10:19 AM, Kalle Valo wrote: >> Xie Qirong <cheerx1...@gmail.com> writes: >> >>> The combination of init_timer and setting up the data and function field >>> manually is equiva

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

output. :-p Sure, I can add that. Thanks to my patchwork script it's actually pretty easy to edit commit logs before it commits them. If only I had time to implement a proper GTK interface for the script... -- Kalle Valo

<    1   2   3   4   5   6   7   8   9   10   >