Re: net: ath: tx99: fixed a spelling issue

Thu Apr 27 19:31:37 2017 +0300 ath9k: fix spelling in ath9k_tx99_init() It's spelled hardware, not harware. Signed-off-by: Ammly Fredrick <amm...@gmail.com> [kv...@qca.qualcomm.com: improve commit log] Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com>

Re: [PATCH] libertas: Avoid reading past end of buffer

t grep -w lbs_deb_leave | wc -l > 71 > > One would expect these numbers to be the same. > > Another option would be to delete all these > calls as ftrace function tracing works well. Yeah, deleting all the enter/exit calls would be better. -- Kalle Valo

Re: [PATCH] wcn36xx: Close SMD channel on device removal

close the channel. > > But "Option 3" describes the situation, thanks for the reference. I'll > try to find the time to verify the patch on v4.11 and send it to > stable@. Great, thanks. This seems to be that serious that better to fix this also in older releases. -- Kalle Valo

Re: [PATCH] wcn36xx: Close SMD channel on device removal

is is an older bug (didn't quite understand your description though) should there be a separate patch for stable releases? -- Kalle Valo

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

Silva <garsi...@embeddedor.com> I don't understand the commit log, especially what does "The name of an array used by itself" mean? -- Kalle Valo

Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code

ta); > - else if (pdata && !pdata->use_eeprom && pdata->eeprom_data) > + else if (pdata && !pdata->use_eeprom) > ret = ath9k_hw_nvram_read_pdata(pdata, off, data); > else > ret = common->bus_ops->eeprom_read(common, off, data); The patch may very well be valid (didn't check yet) but the commit log is gibberish for me. -- Kalle Valo

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

Arend Van Spriel <arend.vanspr...@broadcom.com> writes: > On 9-5-2017 7:33, Kalle Valo wrote: >> "Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: >> >>> The name of an array used by itself will always return the array's address. &g

Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code

"Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: > Hi Kalle, > > Quoting Kalle Valo <kv...@qca.qualcomm.com>: > >> "Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: >> >>> The name of an array used by itse

pull-request: wireless-drivers-next 2017-06-12

SDIO support Geliang Tang (2): wlcore: use memdup_user wil6210: use memdup_user Gustavo A. R. Silva (1): ath9k: remove unnecessary code Igor Mitsyanko (1): qtnfmac: introduce new FullMAC driver for Quantenna chipsets Johan Hovold (1): mwifiex: add missing US

Re: [PATCH 07/11] wireless: ipw2x00: convert to use DRIVER_ATTR_RW

Greg Kroah-Hartman <gre...@linuxfoundation.org> writes: > We are trying to get rid of DRIVER_ATTR(), and the ipw2x00 driver's > attributes can be trivially changed to use DRIVER_ATTR_RW(). > > Cc: Stanislav Yakovlev <stas.yakov...@gmail.com> > Cc: Kalle Valo <kv..

Re: [PATCH] wireless: wlcore: spi: remove unnecessary variable

"Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: > Remove unnecessary variable and refactor the code. > > Addresses-Coverity-ID: 1365000 > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> I'll remove "wireless:" from the prefix. -- Kalle Valo

Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

gned-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> The prefix should be "brcmfmac:", like in the commit you are fixing. "cfg80211:" is very misleading. -- Kalle Valo

Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

a > very low level of consideration for the implications of the change > you are making. > > This isn't like making whitespace fixes, sorry... We already tried to explain this to Jia-Ju during review of a wireless patch: https://patchwork.kernel.org/patch/9756585/ Jia-Ju, you should listen to feedback. If you continue submitting random patches like this makes it hard for maintainers to trust your patches anymore. -- Kalle Valo

pull-request: wireless-drivers 2017-06-20

Hi Dave, here's a pull request to net tree, few important fixes still I would like to have in 4.12. Please let me know if there are any problems. Kalle The following changes since commit dc89481bb4c9af0700423e21c8371379d3d943b1: Merge tag 'iwlwifi-for-kalle-2017-06-05' of

Re: linux-next: manual merge of the net-next tree with the pci tree

ix looks good to me. I guess there's nothing I can do at the moment and Linus needs to fix this when he pulls from Dave (or Bjorn, whichever is the last)? -- Kalle Valo

Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

Jia-Ju Bai <baijiaju1...@163.com> writes: > On 06/21/2017 02:11 PM, Kalle Valo wrote: >> David Miller<da...@davemloft.net> writes: >> >>> From: Jia-Ju Bai<baijiaju1...@163.com> >>> Date: Mon, 19 Jun 2017 10:48:53 +0800 >>> >>>

pull-request: wireless-drivers-next 2017-06-25

iwlwifi: mvm: remove SCAN_GROUP Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2017-06-06' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Kevin Lo (1): rtlwifi: fix REG_USTIME_TSF register definition Liad Kaufma

Re: mwifiex: debugfs: remove redunant check of mwifiex_dfs_dir

Shawn Lin wrote: > debugfs_remove already check mwifiex_dfs_dir, so remove it. > > Signed-off-by: Shawn Lin Patch applied to wireless-drivers-next.git, thanks. 7c26029f87a3 mwifiex: debugfs: remove redunant check of mwifiex_dfs_dir --

Re: [v2] mwifiex: fixes the unexpected be printed log by default

Caesar Wang wrote: > This patch uses WARN level is not printed by default. > > In some cases, some boards have always met the unused log be printed as > follows. > ... > [23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp: > cannot find cfp by band 2& channel=13

Re: wlcore: use memdup_user

Geliang Tang wrote: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang Patch applied to wireless-drivers-next.git, thanks. 6a01d48d47c8 wlcore: use memdup_user --

Re: rtlwifi: fix spelling mistake: "Pairwiase" -> "Pairwise"

Colin Ian King wrote: > From: Colin Ian King > > trivial fixes to spelling mistakes in RT_TRACE messages. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 6b9e6f62552e rtlwifi:

Re: rtlwifi: rtl8723ae: fix spelling mistake: "Coexistance" -> "Coexistence"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. e8dc072dd50d rtlwifi:

Re: [v2] ath10k: remove unnecessary code

"Gustavo A. R. Silva" <garsi...@embeddedor.com> wrote: > The array fields in struct wmi_start_scan_arg that are checked here are > fixed size arrays so they can never be NULL. > > Addresses-Coverity-ID: 1260031 > Cc: Arend Van Spriel <arend.vanspr...@

Re: wcn36xx: Close SMD channel on device removal

Bjorn Andersson wrote: > The SMD channel is not the primary WCNSS channel and must explicitly be > closed as the device is removed, or the channel will already by open on > a subsequent probe call in e.g. the case of reloading the kernel module. > > This issue was

Re: rsi: rsi_91x_core: Use time_after time comparison

Karim Eshapa wrote: > Use time_after kernel macro for time comparison. > > Signed-off-by: Karim Eshapa Patch applied to wireless-drivers-next.git, thanks. c07036f18d93 rsi: rsi_91x_core: Use time_after time comparison --

Re: [v3] libertas: Avoid reading past end of buffer

Kees Cook wrote: > Using memcpy() from a string that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. Instead, redefine the stat strings to be ETH_GSTRING_LEN > sizes, like other drivers.

Re: libertas: Remove function entry/exit debugging

perches.com> > Suggested-by: Kalle Valo <kv...@codeaurora.org> > Signed-off-by: Kees Cook <keesc...@chromium.org> Patch applied to wireless-drivers-next.git, thanks. 4bc606af9fab libertas: Remove function entry/exit debugging -- https://patchwork.kernel.org/patch/9728087/ h

Re: [v2, 01/10] rt2x00: change function pointers for register accessors

Arnd Bergmann wrote: > This prepares the driver for changing all the 'read' register accessors > to return the value instead of passing it by reference. Since a lot > of them are used in callbacks, this takes care of the callbacks first, > adding a couple of helpers that will be

Re: wlcore: fix 64K page support

Arnd Bergmann wrote: > In the stable linux-3.16 branch, I ran into a warning in the > wlcore driver: > > drivers/net/wireless/ti/wlcore/spi.c: In function 'wl12xx_spi_raw_write': > drivers/net/wireless/ti/wlcore/spi.c:315:1: error: the frame size of 12848 > bytes is larger than

Re: [PATCHv4] wlcore: add wl1285 compatible

r...@kernel.org> > Acked-by: Kalle Valo <kv...@codeaurora.org> > Acked-by: Tony Lindgren <t...@atomide.com> > Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> My understanding is that there will be a new version. Please let me know if I misu

Re: [PATCHv4] wlcore: add wl1285 compatible

r...@kernel.org> > Acked-by: Kalle Valo <kv...@codeaurora.org> > Acked-by: Tony Lindgren <t...@atomide.com> > Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> > --- > Hi Dave, > > I previously send this in two patches, but its hard to a

Re: [PATCHv4] wlcore: add wl1285 compatible

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Mon, 22 May 2017 12:28:20 +0300 > >> Sebastian Reichel <sebastian.reic...@collabora.co.uk> writes: >> >>> Motorola Droid 4 uses a WL1285C. With differen

Re: [15/16] hostap: convert hostap_cmd_queue.usecnt from atomic_t to refcount_t

Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > >

Re: [PATCHv4] wlcore: add wl1285 compatible

r...@kernel.org> > Acked-by: Kalle Valo <kv...@codeaurora.org> > Acked-by: Tony Lindgren <t...@atomide.com> > Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> A note to patchwork: this is for 4.12 -- https://patchwork.kernel.org/patch/9713645/ https:

Re: ray_cs: Avoid reading past end of buffer

Kees Cook wrote: > Using memcpy() from a buffer that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. In this case, the source was made longer, since it did not > match the destination

Re: [v4] brcmfmac: btcoex: replace init_timer with setup_timer

Xie Qirong wrote: > setup_timer.cocci suggested the following improvement: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use > setup_timer function for function on line 384. > > The combination of init_timer and setting up the data and function field

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

gt; have a consistent state across all the register access functions. Can these all go to 4.13 or would you prefer me to push the first two 4.12? Or what? -- Kalle Valo

Re: mwifiex: add missing USB-descriptor endianness conversion

Johan Hovold wrote: > Add the missing endianness conversions to a debug statement printing > the USB device-descriptor bcdUSB field during probe. > > Signed-off-by: Johan Hovold Patch applied to wireless-drivers-next.git, thanks. a1ad7198202f mwifiex: add

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

r than > sleeping with a lock held. Sure, but IMHO in general I think the practise of releasing the lock like this in a middle of function is dangerous as one can easily miss that upper and lower halves of the function are not actually atomic anymore. And in this case that it's under a conditional makes it even worse. -- Kalle Valo

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

ently. So I recommend that you also mention your tool in the commit log, makes understanding the background of the patch easier. -- Kalle Valo

Re: cw1200: Fix a sleep-in-atomic bug in cw1200_tx_confirm_cb and cw1200_cqm_bssloss_sm

Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > cw1200_tx_confirm_cb (acquire the lock by spin_lock) > __cw1200_cqm_bssloss_sm > cancel_work_sync --> may sleep > > cw1200_cqm_bssloss_sm > __cw1200_cqm_bssloss_sm >

Re: mwifiex: simplify the code around ra_list

Shawn Lin wrote: > We don't need to check if the list is empty separately > as we could use list_first_entry_or_null to cover it. > > Signed-off-by: Shawn Lin > Reviewed-by: Brian Norris Patch applied to

Re: [net-next] qtnfmac: remove duplicated assignment to mac

Colin Ian King wrote: > From: Colin Ian King > > mac is being assigned twice, remove redundant 2nd assignment. > > Detected by CoverityScan, CID#1437554 ("Incorrect expression") > > Signed-off-by: Colin Ian King >

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

> + spin_lock_irqsave(>irq_lock, flags); To me this looks like a fragile workaround and not a real fix. You can easily add new race conditions with releasing the lock like this. -- Kalle Valo

Re: linux-next: build failure after merge of the wireless-drivers-next tree

ons are required, correct? > > Dave Miller will need to apply that patch (or something similar) when > he merges the wireless-drivers-next tree into the net-next tree. I > will keep applying the patch each day until then. Thanks, I'll remind Dave about this when i submit the pull request (very soon now). -- Kalle Valo

Re: [PATCH] mwifiex: fixes the trivial print

Caesar Wang <w...@rock-chips.com> writes: > 在 2017年06月13日 15:04, Kalle Valo 写道: >> Caesar Wang <w...@rock-chips.com> writes: >> >>> Kalle, >>> >>> 在 2017年06月13日 14:28, Kalle Valo 写道: >>>> Caesar Wang <w...@rock-chips

Re: ath6kl: fix spelling mistake: "Indicat" -> "Indicate"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in ath6kl_dbg debug message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Reviewed-by: Steve deRosier <deros...@gmail.com> > Signed-off-by: Kalle Valo <kv

Re: [PATCH v2 08/11] brcmsmac: make some local variables 'static const' to reduce stack size

arend.vanspr...@broadcom.com> > Signed-off-by: Arnd Bergmann <a...@arndb.de> I found the cover letter from lkml and apparently the plan is that Andrew will pick these three brcmsmac patches, so I'll drop them in wireless patchwork. -- Kalle Valo

Re: [PATCH] mwifiex: fixes the trivial print

"& channel=%d freq=%d\n", > __func__, band, channel, freq); I don't see how this fixes anything, care to explain? And the title is quite vague. And I would rather fix the root cause, mwifiex folks please comment. -- Kalle Valo

Re: [wireless-next] qtnfmac: check band before allocating cmd_skb to avoid resource leak

Colin Ian King wrote: > From: Colin Ian King > > The current code allocates cmd_skb and then will leak this if band->band > is an illegal value. It is simpler to sanity check the band first before > allocating cmd_skb so that we don't have to

Re: [-next] mwifiex: make function mwifiex_ret_pkt_aggr_ctrl static

Colin Ian King wrote: > From: Colin Ian King > > function mwifiex_ret_pkt_aggr_ctrl can be made static as it does not > need to be in global scope. > > Cleans up sparse warning: "symbol 'mwifiex_ret_pkt_aggr_ctrl' was not > declared. Should

Re: [PATCHv5] wlcore: add wl1285 compatible

r...@kernel.org> > Acked-by: Kalle Valo <kv...@codeaurora.org> > Acked-by: Tony Lindgren <t...@atomide.com> > Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Patch applied to wireless-drivers-next.git, thanks. 078b30da3f07 wlcore: add wl1285 comp

Re: mwifiex: Replace semaphore async_sem with mutex

Binoy Jayan wrote: > The semaphore 'async_sem' is used as a simple mutex, so > it should be written as one. Semaphores are going away in the future. > > Signed-off-by: Binoy Jayan > Reviewed-by: Arnd Bergmann Patch applied to

Re: [PATCH] mwifiex: fixes the trivial print

Caesar Wang <w...@rock-chips.com> writes: > Kalle, > > 在 2017年06月13日 14:28, Kalle Valo 写道: >> Caesar Wang <w...@rock-chips.com> writes: >> >>> We have always met the unused log be printed as following. >>> >>> ... >>> [23193.52

Re: wlcore: spi: remove unnecessary variable

"Gustavo A. R. Silva" wrote: > Remove unnecessary variable and refactor the code. > > Addresses-Coverity-ID: 1365000 > Signed-off-by: Gustavo A. R. Silva Patch applied to wireless-drivers-next.git, thanks. c48c281e7236 wlcore: spi: remove

Re: brcmfmac: Fix kernel oops on resume when request firmware fails.

Enric Balletbo i Serra wrote: > When request firmware fails, brcmf_ops_sdio_remove is being called and > brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle > the kernel hangs on resume due a NULL pointer dereference in resume > function. > >

Re: [PATCH 0/6] Constant Time Memory Comparisons Are Important

nters where I could learn more about this? -- Kalle Valo

Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()

- but I'm likely > missing something. > >> As it is with your patch, it'll go and report the TX status without any >> TX status information - which is handled in wcn36xx_dxe_tx_ack_ind() >> for those frames needing it. >> > > Right, it doesn't sound desired. However, during normal operation I'm > not seeing IEEE80211_TX_CTL_REQ_TX_STATUS being set and as such > ieee80211_led_tx() is never called. So what's the conclusion? How do we get leds working? -- Kalle Valo

Re: new warning at net/wireless/util.c:1236

211] As this is with iwlwifi adding also Luca. There were some rate handling changes in iwlwifi, like commit 77e409455f41, but don't know if that could cause this. -- Kalle Valo

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

at are in your tree but not yet in linux-next, as I don't > see > the warning and also see no reference to rt2800_bbp_read in rt2800lib.h I did a test build with current wireless-drivers-next and I also don't see any warnings. -- Kalle Valo

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

Arnd Bergmann <a...@arndb.de> writes: > On Fri, May 19, 2017 at 7:18 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Arnd Bergmann <a...@arndb.de> writes: >> >>> I've managed to split up my long patch into a series of reasonble >>> steps now. >

Re: net: ath: tx99: fixed a spelling issue

ammly wrote: > Fixed a spelling issue. > > Signed-off-by: Ammly Fredrick Patch applied to ath-next branch of ath.git, thanks. c46e2a848f29 ath9k: fix spelling in ath9k_tx99_init() -- https://patchwork.kernel.org/patch/9703211/

Re: ath5k: fix memory leak on buf on failed eeprom read

Colin Ian King wrote: > From: Colin Ian King > > The AR5K_EEPROM_READ macro returns with -EIO if a read error > occurs causing a memory leak on the allocated buffer buf. Fix > this by explicitly calling ath5k_hw_nvram_read and exiting on > the

Re: wil6210: use memdup_user

Geliang Tang wrote: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang Patch applied to ath-next branch of ath.git, thanks. 9a49290919e1 wil6210: use memdup_user --

Re: [v2] ath9k: remove unnecessary code

"Gustavo A. R. Silva" <garsi...@embeddedor.com> wrote: > The array field eeprom_data in struct th9k_platform_data > is a fixed size array so it can never be NULL. > > Addresses-Coverity-ID: 1364903 > Cc: Arend Van Spriel <arend.vanspr...@broadcom.com> >

pull-request: wireless-drivers 2017-06-06

Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2017-06-05' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Liad Kaufman (1): iwlwifi: mvm: support ibss in dqa mode Luca Coelho (3): iwlwifi: pcie: only use d0i3 in suspend/resume if system_pm is set to d0i3 iwlwifi: mvm

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

committing the patch. Yeah, I'll fix that when I commit this. But very good that you pointed it out, I might miss stuff like this. I'll also remove the "wireless:" prefix from the title. -- Kalle Valo

Re: [PATCH] ath10: mark PM functions as __maybe_unused

the #ifdef, this just marks both functions > as __maybe_unused, which is a more robust way to do this. > > Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Applied to ath-current branch in ath.git, thanks. (Having problems with my patchwork script so sending this manually) -- Kalle Valo

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

ing > CONFIG_INTEL_IOMMU_DEFAULT_ON also breaks my system. But not all systems have iommu so check from dmesg that iommu is really enabled. -- Kalle Valo

Re: rsi: fix a dereference on adapter before it has been null checked

Colin Ian King wrote: > From: Colin Ian King > > The assignment of dev is dereferencing adapter before adapter has > been null checked, potentially leading to a null pointer dereference. > Fix this by simply moving the assignment of dev to a

Re: mwifiex: remove unnecessary call to memset

Himanshu Jha wrote: > call to memset to assign 0 value immediately after allocating > memory with kzalloc is unnecesaary as kzalloc allocates the memory > filled with 0 value. > > Semantic patch used to resolve this issue: > > @@ > expression e,e2; constant c; >

Re: [1/2] b43: fix unitialized reads of ret by initializing the array to zero

Colin Ian King wrote: > From: Colin Ian King > > The u8 char array ret is not being initialized and elements outside > the range start to end contain just garbage values from the stack. > This results in a later scan of the array to read

Re: mwifiex: make const arrays static to shink object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack, instead make them static > Makes the object code smaller by nearly 300 bytes: > > Before: >text data bss dec hex filename >

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

; >>> > >>> > 于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo <kv...@codeaurora.org> >>写到: >>> > > Icenowy Zheng <icen...@aosc.io> writes: >>> > > >>> > > > Allwinner XR819 is a SDIO Wi-Fi chip, which ha

Re: [PATCH] mwifiex: Use put_unaligned_le32

oplevel header file which includes header files based on arch configuration. Also grepping the sources support that, nobody from drivers/ include access_ok.h directly. But I can't say that I fully understand how the header files work so please do correct me if I have mistaken. -- Kalle Valo

Re: [PATCH] mwifiex: Use put_unaligned_le32

vers/net/wireless/marvell/mwifiex/cmdevt.c > index 0edc5d6..e28e119 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c > +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c > @@ -17,6 +17,7 @@ > * this warranty disclaimer. > */ > > +#include I don't think this is correct. Should it be asm/unaligned.h? -- Kalle Valo

Re: [PATCH] mwifiex: Use put_unaligned_le32

n this case, the key is CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. It >> seems that asm-generic/unaligned.h is set up to include different >> headers, based on the expected architecture behavior. >> > Yes, asm-generic/unaligned.h looks more appopriate and is most generic >

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

ere is no upstream xr819 wireless driver in drivers/net/wireless directory. Do we still accept bindings like this for out-of-tree drivers? -- Kalle Valo

Re: ath9k: make const array reg_hole_list static, reduces object code size

18 15248 0 72766 11c3e debug.o > > After: >text data bss dec hex filename > 57218 15344 0 72562 11b72 debug.o > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv.

Re: net/wireless/ray_cs: Convert timers to use

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@codeauror

Re: [v2] p54: don't unregister leds when they are not initialized

Andrey Konovalov wrote: > ieee80211_register_hw() in p54_register_common() may fail and leds won't > get initialized. Currently p54_unregister_common() doesn't check that and > always calls p54_unregister_leds(). The fix is to check priv->registered > flag before calling

Re: [PATCH] ath9k: debug: Simplify error checking

ul(buf, 0, ) || val > 1) > return -EINVAL; Same as with the ath10k patch, please keep the two if statements separate. -- Kalle Valo

Re: [v2] mwifiex: Use put_unaligned_le32

Himanshu Jha wrote: > Use put_unaligned_le32 rather than using byte ordering function and > memcpy which makes code clear. > Also, add the header file where it is declared. > > Done using Coccinelle and semantic patch used is : > > @ rule1 @ > identifier tmp;

Re: usb/net/rt2x00: warning in rt2800_eeprom_word_index

automated Linux kernel testing. That's an important > capability. Not really following you. Are you saying that using WARN() prevents automated Linux kernel testing? -- Kalle Valo

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

s a specified variant of cw1200 family) >> >> Ah, so the upstream cw1200 driver supports xr819? Has anyone tested >> that? Or does cw1200 more changes than just adding the DT support? > > The support of XR819 in CW1200 driver is far more difficult than I > imagined -- the codedrop used in the mainlined CW1200 driver seems to > be so old that it's before XR819 (which seems to be based on CW1160), > and there's a large number of problems to adapt it to a modern CW1200 > variant. > > P.S. could you apply this device tree binding patch now? As I haven't seen any consensus that applying bindings document for out-of-tree drivers is ok so at least I'm not taking this. Though not sure what DT maintainers are planning to do. -- Kalle Valo

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

be bad). The thing is that I really do not have time to figure out for every patch via which tree it's supposed to go. For now I'll just drop all your timer_setup() related patches from my queue and I'll assume Dave will take those. Ok? [1] https://patchwork.kernel.org/project/linux-wireless/list/ -- Kalle Valo

Re: rsi: fix integer overflow warning

Arnd Bergmann wrote: > gcc produces a harmless warning about a recently introduced > signed integer overflow: > > drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_prepare_mgmt_desc': > include/uapi/linux/swab.h:13:15: error: integer overflow in expression >

Re: [PATCH] ath10k: spectral: Simplify error checking

f (kstrtoul(buf, 0, ) || val > 255) > return -EINVAL; Removing the check for negative is correct but I don't think you are simplifying anything, on the contrary it's harder to read. Please keep the two if statements separate. -- Kalle Valo

Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

at one. Kalle can you please include > this in a v4.14-rc pull request? > > > : > > Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw > configuration") > >> Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> > > Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org> Ok, I'll queue this to 4.14. -- Kalle Valo

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

like pointless patch churn > for zero gain and it's just ugly. In general I find it useful to mark fall through cases. And it's just a comment with two words, so they cannot hurt your eyes that much. -- Kalle Valo

pull-request: wireless-drivers 2017-10-13

): iwlwifi: stop dbgc recording before stopping DMA Johannes Berg (1): iwlwifi: nvm-parse: unify channel flags printing Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2017-10-06' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Kevin Cernekee (1): brcmfmac: Add check for short

Re: rtlwifi: Remove unused cur_rfstate variables

Christos Gkekas wrote: > Clean up unused cur_rfstate variables in rtl8188ee, rtl8723ae, rtl8723be > and rtl8821ae. > > Signed-off-by: Christos Gkekas Patch applied to wireless-drivers-next.git, thanks. 76d7b12cbbe2 rtlwifi: Remove unused

Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

<luciano.coe...@intel.com> Linus, do you want to apply this directly or should we take it via the normal route (wireless-drivers -> net)? If your prefer the latter when I'm planning to submit this to Dave in a day or two and expecting it to get to your tree in about a week, depending of course what is Dave's schedule. -- Kalle Valo

Re: [PATCH] ath10: mark PM functions as __maybe_unused

the #ifdef, this just marks both functions > as __maybe_unused, which is a more robust way to do this. > > Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks. But the title should have "ath10k:", I'll fix that. -- Kalle Valo

pull-request: wireless-drivers 2017-09-08

Hi Dave, few fixes to net tree for 4.14. Note that this pull request contains the iwlwifi fix Linus hopes to have by end of the merge window. Please let me know if there are any problems. Kalle The following changes since commit 8e0deed92406d93ae0365cb8a6134db5721e7aca: tipc: remove

Re: rsi: remove memset before memcpy

Himanshu Jha wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Signed-off-by: Himanshu Jha Patch applied to wireless-drivers-next.git, thanks. 66a3479e1217 rsi: remove memset

Re: [GIT] Networking

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Wed, 30 Aug 2017 17:45:31 +0300 > >> Pavel Machek <pa...@ucw.cz> writes: >> >>> Could we get this one in? >>> >>> wl1251 miss

Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

Linus Torvalds <torva...@linux-foundation.org> writes: > On Thu, Sep 7, 2017 at 5:39 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> >> Linus, do you want to apply this directly or should we take it via the >> normal route (wireless-drivers -> net)? If your pr

Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it

Luciano Coelho wrote: > From: Luca Coelho > > The LEDS_CMD command is only supported in some newer FW versions > (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions > (such as iwlwifi-8000C-27.ucode). > > To fix this, check for a new

Re: brcmsmac: make const array ucode_ofdm_rates static, reduces object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ucode_ofdm_rates on the stack, instead make it > static. Makes the object code smaller by 100 bytes: > > Before: >text data bss dec hex

<    2   3   4   5   6   7   8   9   10   >