Re: [v2] rtl8xxxu: Don't printk raw binary if serial number is not burned in.

Adam Borowski wrote: > I assume that a blank efuse comes with all ones, thus I did not bother > recognizing other possible junk values. This matches 100% of dongles > I've seen (a single Gembird 8192eu). > > Signed-off-by: Adam Borowski Patch applied

Re: mwifiex: make const array tos_to_ac static, reduces object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate the read-only const array tos_to_ac on the stack, > instead make it static. Makes the object code smaller by 250 bytes: > > Before: >text data bss dec

Re: b43: make const arrays static, reduces object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack, instead make them static. > Makes the object code smaller by over 60 bytes: > > Before: >text data bss dec hex filename >

Re: iwlegacy: make const array static to shink object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ac_to_fifo on the stack in an inlined > function, instead make it static. Makes the object code smaller > by over 800 bytes: > >text data bss

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

rnel.org/r/20170925041153.26574-1-dr...@endlessm.com -- Kalle Valo

Re: [PATCH 05/18] net: use ARRAY_SIZE

13 files changed, 177 insertions(+), 413 deletions(-) We have a tree for wireless so usually it's better to submit wireless changes on their own but here I assume Dave will apply this to his tree. If not, please resubmit the wireless part in a separate patch. -- Kalle Valo

Re: [v4, 1/9] brcmsmac: make some local variables 'static const' to reduce stack size

Arnd Bergmann wrote: > With KASAN and a couple of other patches applied, this driver is one > of the few remaining ones that actually use more than 2048 bytes of > kernel stack: > > broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function > 'wlc_phy_workarounds_nphy_gainctrl': >

Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy

Arnd Bergmann wrote: > The stack consumption in this driver is still relatively high, with one > remaining warning if the warning level is lowered to 1536 bytes: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: > the frame size of 1880 bytes is

Re: usb/wireless/rsi_91x: use-after-free write in __run_timers

setup. Apparently you are running syzkaller on QEMU but what I don't understand is how the rsi device comes into the picture. Did you have a rsi usb device connected to the virtual machine or what? Or does syzkaller do some kind of magic here? -- Kalle Valo

Re: ath10k: make ath10k_hw_ce_regs const

l <bhumi...@gmail.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 496cbf3ebb6b ath10k: make ath10k_hw_ce_regs const -- https://patchwork.kernel.org/patch/9951901/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

pull-request: wireless-drivers 2017-09-25

Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2017-09-15' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge ath-current from ath.git Luca Coelho (4): iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD iwlwifi: mvm: handle FIF_ALLMULTI when setting multicast

Re: [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size

Arend van Spriel <arend.vanspr...@broadcom.com> writes: > Please use 'brcmsmac:' as prefix instead of 'brcm80211:'. I can fix that. -- Kalle Valo

Re: [8/10] ath9k: Use ARRAY_SIZE macro

s*\[\s*0\s*\]\s*\) > /ARRAY_SIZE(\1)/g' and manual check/verification. > > Signed-off-by: Thomas Meyer <tho...@m3y3r.de> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 896cbefadf62 ath9k: Use ARRAY_SIZE

Re: [PATCH v4 1/9] brcmsmac: make some local variables 'static const' to reduce stack size

ble backports. > > The other two patches do not need to be backported. > > Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Arnd Bergmann <a...@arndb.de> I'll queue this and the two following brcmsmac patches for 4.14. Also I'll add (only for this patch): Cc: <sta...@vger.kernel.org> -- Kalle Valo

Re: [2/2] ath9k: Avoid a potential deadlock

816] > [ 19.096816] do_IRQ+0x5c/0x120 > [ 19.096816] common_interrupt+0x36/0x3c > [ 19.096816] EIP: _raw_spin_unlock_irqrestore+0x57/0x70 > [ 19.096816] EFLAGS: 0286 CPU: 0 > [ 19.096816] EAX: f60a3600 EBX: 0286 ECX: 0006 EDX: 0001 > [ 19.096816] ESI: f46c9e6

Re: usb/wireless/rsi_91x: use-after-free write in __run_timers

Andrey Konovalov <andreyk...@google.com> writes: > On Mon, Sep 25, 2017 at 6:26 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Andrey Konovalov <andreyk...@google.com> writes: >> >>> I've got the following report while fuzzing th

pull-request: wireless-drivers-next 2017-08-28

useless condition in LED code iwlwifi: mvm: use firmware LED command where applicable João Paulo Rechi Vita (1): iwlwifi: Demote messages about fw flags size to info Kalle Valo (4): Merge tag 'iwlwifi-next-for-kalle-2017-08-11' of git://git.kernel.org/.../iwlwifi/iwlwifi-next

Re: [PATCH v2] at76c50x-usb: check memory allocation failure

ges and the current error handling looks the correct approach. There is not much anything else we can do than just skip the message printout. -- Kalle Valo

Re: rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

"Gustavo A. R. Silva" wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1415177 > Signed-off-by: Gustavo A. R. Silva Patch applied

Re: [v2] mt7601u: check memory allocation failure

Christophe Jaillet wrote: > Check memory allocation failure and return -ENOMEM in such a case, as > already done a few lines below. > > As 'dev->tx_q' can be NULL, we also need to check for that in > 'mt7601u_free_tx()', and return early. > > Signed-off-by:

Re: rtlwifi: rtl8821ae: fix spelling mistake: "faill" -> "failed"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 2cc8918eb987 rtlwifi:

Re: [RESEND,v12,7/8] wireless: ipw2200: Replace PCI pool old API

Romain Perier wrote: > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Reviewed-by: Peter Senna Tschudin

Re: [1/3] net: rtlwifi: constify rate_control_ops

Arvind Yadav wrote: > rate_control_ops are not supposed to change at runtime. All functions > working with rate_control_ops provided by work with > const rate_control_ops. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: wireless: ipw2x00: make iw_handler_def const

Bhumika Goyal wrote: > Make these const as they are only stored in the const field of a > net_device structure. > > Signed-off-by: Bhumika Goyal Patch applied to wireless-drivers-next.git, thanks. 2c1dca3c6b22 wireless: ipw2x00: make iw_handler_def

pull-request: wireless-drivers 2017-08-25

Hi Dave, here's pull request to net tree for 4.13, more info in the signed tag below. Please let me know if there are any problems. Kalle The following changes since commit e9bf53ab1ee34bb05c104bbfd2b77c844773f8e6: brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices

Re: rtlwifi: rtl8723be: fix duplicated code for different branches

"Gustavo A. R. Silva" wrote: > Refactor code in order to avoid identical code for different branches. > > Addresses-Coverity-ID: 1248728 > Signed-off-by: Gustavo A. R. Silva > Acked-by: Larry Finger Patch applied to

Re: [GIT] Networking

(Adding linux-wireless) Pavel Machek <pa...@ucw.cz> writes: > On Thu 2017-08-31 07:44:58, Kalle Valo wrote: >> David Miller <da...@davemloft.net> writes: >> >> > From: Kalle Valo <kv...@codeaurora.org> >> > Date: Wed, 30 Aug 2017 20:3

pull-request: wireless-drivers-next 2017-09-01

memcpy Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2017-08-30' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Lazar Alexei (1): wil6210: align to latest auto generated wmi.h Liad Kaufman (1): iwlwifi: fix

stable-kernel-rules: wireless and netdev-FAQ

(adding netdev and lkml) Stanislaw Gruszka <sgrus...@redhat.com> writes: > On Fri, Sep 01, 2017 at 05:31:57PM +0300, Kalle Valo wrote: >> Stanislaw Gruszka <sgrus...@redhat.com> writes: >> >> > On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote

Re: [GIT] Networking

ext and will be in 4.14-rc1: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=6e9aae179f290f1a44fce7ef8e9a8e2dd68ed1e4 -- Kalle Valo

Re: [GIT] Networking

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Wed, 30 Aug 2017 20:31:31 +0300 > >> AFAICS the bug was introduced by 9df86e2e702c6 back in 2010. If the bug >> has been there for 7 years so waiting for a

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

Jes Sorensen <jes.soren...@gmail.com> writes: > On 10/11/2017 04:41 AM, Kalle Valo wrote: >> Jes Sorensen <jes.soren...@gmail.com> writes: >> >>> On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote: >>>> In preparation to enabling -Wimpli

pull-request: wireless-drivers-next 2017-10-18

to the WRT dump flow Johannes Berg (4): iwlwifi: nvm-parse: unify channel flags printing iwlwifi: fw: api: remove excess enum value documentation iwlwifi: fix indentation in a000 family configuration iwlwifi: mvm: warn on invalid statistics size Kalle Valo (3): Merge ta

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> writes: > On Tue, Oct 17, 2017 at 7:18 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> + linux-wireless >> >> Hi Kees, >> >> Kees Cook <keesc...@chromium.org> writes: >> >>> This is the curren

Re: [PATCH] wcn36xx: fix iris child-node lookup

I'll remove it. > Cc: Loic Poulain <loic.poul...@linaro.org> > Signed-off-by: Johan Hovold <jo...@kernel.org> Thanks, I'll queue this to v4.15. -- Kalle Valo

pull-request: wireless-drivers 2017-11-22

Johan Hovold (1): wcn36xx: fix iris child-node lookup Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2017-11-19' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge ath-current from git://git.kernel.org/.../kvalo/ath.git

Re: [v1] brcmfmac: Avoid build error with make W=1

Andy Shevchenko wrote: > When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for > the first run, all next ones are okay. > > CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o >

Re: [1/1] rtlwifi: always initialize variables given to RT_TRACE()

Nicolas Iooss wrote: > In rtl_rx_ampdu_apply(), when rtlpriv->cfg->ops->get_btc_status() > returns false, RT_TRACE() is called with the values of variables > reject_agg and agg_size, which have not been initialized. > > Always initialize these variables in order to

Re: brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events

Colin Ian King wrote: > From: Colin Ian King > > Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine > size of the array. Improvement suggested by coccinelle. > > Signed-off-by: Colin Ian King >

Re: wcn36xx: Reduce spinlock in indication handler

t; worker function. > > By removing items from the queue early we don't need to hold the lock > throughout the indication worker, allowing the individual handlers to > sleep. > > Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> > Signed-off-by: Kalle Valo <kv...@qca

Re: wlcore: fix unused function warning

Arnd Bergmann wrote: > The newly added wlcore_fw_sleep function is called conditionally, > which causes a warning without CONFIG_PM: > > drivers/net/wireless/ti/wlcore/main.c:981:12: error: 'wlcore_fw_sleep' > defined but not used [-Werror=unused-function] > > Instead of trying

Re: [PATCH] wil6210: fix build warnings without CONFIG_PM

file as well for consistency. > > Fixes: 94162666cd51 ("wil6210: run-time PM when interface down") > Signed-off-by: Arnd Bergmann <a...@arndb.de> A note to myself (unfortunately patchwork doesn't have any way to add notes to patches): 94162666cd51 is in wireless-drivers-next so this patch should also go to -next. -- Kalle Valo

pull-request: wireless-drivers-next 2017-12-18

mac: Remove repeated calls to brcmf_chip_get_core() Johannes Berg (3): iwlwifi: mvm: remove TCP wakeup support iwlwifi: mvm: remove superfluous flush_work() iwlwifi: mvm: request statistics when reading debugfs Jérémy Lefaure (1): wireless: use ARRAY_SIZE Kalle Valo (3): Merge tag 'i

Re: pull-request: wireless-drivers-next 2017-11-11

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Sat, 11 Nov 2017 15:03:14 +0200 > >> some more patches to net-next for v4.15. Even though I applied the last >> patch only on Saturday morning, all these have been tested

pull-request: wireless-drivers-next 2017-11-11

and qtnfmac: pass all CONNECT cmd params to wireless card for processing Ihab Zhaika (3): iwlwifi: add new cards for 8260 series iwlwifi: add new cards for 8265 series iwlwifi: add new cards for a000 series Kalle Valo (1): Merge tag 'iwlwifi-next-for-kalle-2017-11-03' of

Re: [PATCH] wcn36xx: Set BTLE coexistence related configuration values to defaults

in.c > +++ b/drivers/net/wireless/ath/wcn36xx/main.c > @@ -27,7 +27,7 @@ > #include > #include "wcn36xx.h" > > -unsigned int wcn36xx_dbg_mask; > +unsigned int wcn36xx_dbg_mask = WCN36XX_DBG_NONE; And this looks unrelated to the title? -- Kalle Valo

Re: [PATCH] wcn36xx: Set BTLE coexistence related configuration values to defaults

Ramon Fried <rfr...@codeaurora.org> writes: > From: Eyal Ilsar <eil...@codeaurora.org> > > Signed-off-by: Eyal Ilsar <eil...@codeaurora.org> > Signed-off-by: Ramon Fried <rfr...@codeaurora.org> Why? No empty commit logs, please. -- Kalle Valo

Re: [PATCH] wcn36xx: Set BTLE coexistence related configuration values to defaults

tches#patch_version_missing So after fixing Bjorn's comments the next version should be v3. -- Kalle Valo

Re: wcn36xx: fix iris child-node lookup

ely freed. > > Fixes: fd52bdae9ab0 ("wcn36xx: Disable 5GHz for wcn3620") > Cc: Loic Poulain <loic.poul...@linaro.org> > Signed-off-by: Johan Hovold <jo...@kernel.org> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-current branc

Re: [PATCH] mac80211: mwl8k: Expand non-DFS 5G channels

version_missing > drivers/net/wireless/marvell/mwl8k.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) You should use "mac80211:" prefix only with patches touching net/mac80211. So for this one "mwl8k:" is enough. -- Kalle Valo

pull-request: wireless-drivers-next 2017-11-03

wil6210: remove SSID debugfs libertas: don't write wdev->ssid/_len Kalle Valo (3): Merge tag 'iwlwifi-next-for-kalle-2017-10-18' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Merge ath-next from git://git.kernel.

Re: [PATCH] ath10k: move pci suspend/resume functions

t;ath10k: mark PM functions as __maybe_unused") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Brian has already fixed this, please check that: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next=20665a9076d48e9abd9a2db13d307f58f7ef6647 But apparently

Re: [PATCH] rsi: sdio: fix building without CONFIG_PM

Arnd Bergmann <a...@arndb.de> writes: > On Thu, Nov 2, 2017 at 3:57 PM, Kalle Valo <kv...@codeaurora.org> wrote: >> Arnd Bergmann <a...@arndb.de> writes: >> >>> The addition of the WoWLAN support has caused a number of new >>> build errors whe

Re: rt2x00: use monotonic timestamps for frame dump

Arnd Bergmann wrote: > rt2x00 uses the deprecated do_gettimeofday() function to get a timestamp > for its debugfs "dump" file interface. > > The timestamp is using an unsigned 32-bit value, so we could make it > work until 2106 by using ktime_get_real_ts64(), but it seems better

Re: rsi: rsi_91x_ps: remove redundant code in str_psstate

"Gustavo A. R. Silva" wrote: > "INVALID_STATE" is already being returned in the default case and this > code cannot be reached. > > Addresses-Coverity-ID: 1398384 > Signed-off-by: Gustavo A. R. Silva Patch applied to wireless-drivers-next.git,

Re: iwlegacy: remove redundant pointer sta_priv

Colin Ian King wrote: > From: Colin Ian King > > Pointer sta_priv is assigned but never read, hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/wireless/intel/iwlegacy/4965-rs.c:2163:2: warning: Value >

Re: [1/3] rtlwifi: fix uninitialized rtlhal->last_suspend_sec time

Arnd Bergmann wrote: > We set rtlhal->last_suspend_sec to an uninitialized stack variable, > but unfortunately gcc never warned about this, I only found it > while working on another patch. I opened a gcc bug for this. > > Presumably the value of rtlhal->last_suspend_sec is not

Re: rtlwifi: remove redundant initialization to cfg_cmd

Colin Ian King wrote: > From: Colin Ian King > > cfg_cmd is initialized to zero and this value is never read, instead > it is over-written in the start of a do-while loop. Remove the > redundant initialization. Cleans up clang warning: > >

Re: zd1201: remove unused variable framelen

Colin Ian King wrote: > From: Colin Ian King > > Variable framelen is assigned but never read, hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/wireless/zydas/zd1201.c:234:3: warning: Value stored > to

Re: orinoco_usb: remove redundant pointer dev

Colin Ian King wrote: > From: Colin Ian King > > The pointer dev is assigned but never read, hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/wireless/intersil/orinoco/orinoco_usb.c:1468:2: warning: >

Re: rtlwifi: remove redundant pointer tid_data

Colin Ian King wrote: > From: Colin Ian King > > tid_data is assigned but never read, hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/wireless/realtek/rtlwifi/base.c:1581:2: warning: Value > stored to

Re: [PATCH] rsi: sdio: fix building without CONFIG_PM

Bergmann <a...@arndb.de> Amit already submitted two patches to fix this problem: https://patchwork.kernel.org/patch/10036297/ https://patchwork.kernel.org/patch/10036299/ I applied them to my pending branch yesterday, and at least buildbot seems to be happy, so I'm planning take apply those instead. Please let me know if that's a problem. -- Kalle Valo

pull-request: wireless-drivers 2017-12-08

for MONITOR vif type iwlwifi: mvm: fix packet injection Ihab Zhaika (1): iwlwifi: add new cards for 9260 and 22000 series Johannes Berg (1): iwlwifi: mvm: flush queue before deleting ROC Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2017-11-28' of git://git.kernel.org/.../iwlwifi

Re: ath9k: dfs: use swap macro in ath9k_check_chirping

R. Silva <garsi...@embeddedor.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 626ab6707abe ath9k: dfs: use swap macro in ath9k_check_chirping -- https://patchwork.kernel.org/patch/10041197/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [v4] wcn36xx: Set default BTLE coexistence config

yal Ilsar <eil...@codeaurora.org> > Signed-off-by: Ramon Fried <rfr...@codeaurora.org> > Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 4119b6160a35 wcn36

Wireless regressions in v4.15-rc1

: 5d 41 5e 41 5f c3 c7 04 24 03 00 00 00 e9 dc fe ff ff 48 8d bf 58 09 00 00 be ff ff ff ff e8 dd 36 90 e7 85 c0 0f 85 a8 fe ff ff <0f> ff e9 a1 fe ff ff 4c 89 f7 e8 76 [ 133.182798] ---[ end trace fb3fb3b808e4ce1b ]--- -- Kalle Valo

Re: [PATCH v2] mwl8k: Expand non-DFS 5G channels

; You don't need to copy the code from the patch to the commit log, I'll remove that when I commit this. -- Kalle Valo

Re: [PATCH INTERNAL V2 1/1] brcmfmac: add console log support with configurable read size

iewed-by: Ray Jui <ray@broadcom.com> > Reviewed-by: Scott Branden <scott.bran...@broadcom.com> > Signed-off-by: Li Jin <li@broadcom.com> Arend, am I supposed to apply this even if there's this "INTERNAL" tag in the Subject? -- Kalle Valo

Re: [v1] brcmfmac: Avoid build error with make W=1

Andy Shevchenko wrote: > When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for > the first run, all next ones are okay. > > CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o >

Re: [2/3] ath9k: move spectral scan support under a separate config symbol

el. > > Having debugfs support in ath9k is often useful even on very small embedded > routers, where we'd rather like to avoid the code size and RAM usage of the > relay support. > > Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> > Signed-off-by: Kall

Re: ath10k: use 64-bit crash dump timestamps

; > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. dafa42036012 ath10k: use 64-bit crash dump timestamps -- https://patchwork.kernel.org/patch/10076697/ https://wireless.w

Re: [PATCH 1/3] ath9k: remove stray backslash in Makefile

on-beacon.o >> > > It's not necessarily stray, there is nothing on the next line so it's > OK, and if you add \ at the end of all lines, you don't have to touch > the last line every time you add/remove something. Sort of like > putting a , after last enum value. I agree with Jakub, I think the backslash is there on purpose so I dropped this patch. -- Kalle Valo

Re: [V2] wlcore, wl1251: fix spelling: "Couldnt" -> "Couldn't" and remove error on -ENOMEM

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in error message text. Also remove the > error message on an kzalloc failure as this is redundant. > > Signed-off-by: Colin Ian King

Re: wlcore: allow elp during wowlan suspend

"Reizer, Eyal" wrote: > when enabling wowlan and entering suspend the last write to the firmware > allowing it to go into elp mode was not completing before suspend, leaving > the firmware running in full active mode consuming high power. > Use an immediate call instead of a work

Re: wlcore: use boottime for fw time sync

Arnd Bergmann wrote: > Using getnstimeofday()/timespec_to_ns() causes an overflow on 32-bit > architectures in 2038, and may suffer from time jumps due to > settimeofday() or leap seconds. > > I don't see a reason why this needs to be UTC, so either monotonic > or boot time would

Re: rtlwifi: rtl818x: remove redundant check for cck_power > 15

Colin Ian King wrote: > From: Colin Ian King > > cck_poweri cannot be greated than 15 as is derived from the bottom 4 bits > from riv->channels[channel - 1].hw_value & 0xf. Hence the check for it > being greater than 15 is redundant and can

Re: rsi: fix memory leak on buf and usb_reg_buf

Colin Ian King wrote: > From: Colin Ian King > > In the cases where len is too long, the error return path fails to > kfree allocated buffers buf and usb_reg_buf. The simplest fix is to > perform the sanity check on len before the

Re: linux-next: build failure after merge of the mac80211-next tree

re noise next time when I'm applying a new driver. [1] https://lkml.kernel.org/r/87wp22jzzb@purkki.adurom.net -- Kalle Valo

pull-request: wireless-drivers 2017-10-31

rcu_read_unlock in wcn36xx_bss_info_changed Kalle Valo (2): Revert "ath10k: fix napi_poll budget overflow" Merge ath-current from ath.git Vasanthakumar Thiagarajan (1): ath10k: rebuild crypto header in rx data frames drivers/net/wireless/ath/ath10k/htt_r

Re: [PATCH 09/18] net: mac80211.h: fix a bad comment line

ted a similar patch: https://patchwork.kernel.org/patch/10367275/ But it seems Johannes has not applied that yet. -- Kalle Valo

Re: mwifiex: delete unneeded include

Julia Lawall wrote: > Nothing that is defined in 11ac.h is referenced in cmdevt.c. > > Signed-off-by: Julia Lawall Patch applied to wireless-drivers-next.git, thanks. 4793e5a954fa mwifiex: delete unneeded include --

Re: ath10k: sdio: jump to correct label in error handling path

t;ath10k: sdio: fix memory > leak for probe allocations"). > However, the bug was originally introduced in commit d96db25d2025 > ("ath10k: add initial SDIO support"). > > Fixes: d96db25d2025 ("ath10k: add initial SDIO support") > Signed-off-by: Nik

Re: [next] ath10k: fix spelling mistake: "servive" -> "service"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in ath10k_warn warning message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-

Re: ath6kl: fix ath6kl_data_tx()'s return type

iver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 378b1d65070f ath6kl: fix ath6kl_data_tx()'s return type -- https://p

Re: rsi: fix spelling mistake: "thead" -> "thread"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in rsi_dbg debug message text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. b41c39367669

Re: [PATCH] net: wireless: ath: ath9k: Fix a possible data race in ath_chanctx_set_next

t;next_chan". > > To fix this data race, the read operation to "sc->next_chan" > should be also protected by the lock. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com> I need this reviewed by someone else before I'm willing to take it. -- Kalle Valo

Re: rtlwifi: fix spelling mistake: "dismatch" -> "mismatch"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE message text. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 070fc356e21a

Re: ipw2200: fix spelling mistake: "functionalitis" -> "functionalities"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in module parameter description text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

pull-request: wireless-drivers-next 2018-05-17

iwlwifi: move timestamp functions from debugfs.h to dbg.h Jia-Ju Bai (1): net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment Johannes Berg (3): iwlwifi: mvm: detect U-APSD breaking aggregation iwlwifi: mvm: clean up scan capability checks

Re: [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare

ree, not to net-next. So adding net-next to the subject is wrong, but no need to resend just because of that. -- Kalle Valo

pull-request: wireless-drivers 2018-05-22

and b44 drivers * try again fixing a MIPS linker error bcma * fix truncated info log messages Kalle Valo (3): MAINTAINERS: update Kalle's email address MAINTAINERS: change Kalle as ath.ko maintainer MAINTAINERS

Re: [PATCH v2] wcn36xx: Add support for Factory Test Mode (FTM)

/ath/wcn36xx/testmode.c:122:5: warning: 'msg' may be used uninitialized in this function [-Wmaybe-uninitialized] -- Kalle Valo

Re: [v8, bpf-next, 4/9] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint

$ scripts/get_maintainer.pl --no-rolestats --no-git -f drivers/net/wireless/intel/iwlwifi/dvm/main.c Johannes Berg <johannes.b...@intel.com> Emmanuel Grumbach <emmanuel.grumb...@intel.com> Luca Coelho <luciano.coe...@intel.com> Intel Linux Wireless <linuxw...@intel.com> Kalle Valo <

Re: [v3] wcn36xx: Add support for Factory Test Mode (FTM)

2) > 5) Add generic handling for all PTT_MSG packets > > Signed-off-by: Eyal Ilsar <eil...@codeaurora.org> > Signed-off-by: Ramon Fried <ramon.fr...@linaro.org> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 87f

Re: [net-next] ath10k: Remove useless test before clk_disable_unprepare

YueHaibing <yuehaib...@huawei.com> wrote: > clk_disable_unprepare() already checks that the clock pointer is valid. > No need to test it before calling it. > > Signed-off-by: YueHaibing <yuehaib...@huawei.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org>

Re: [PATCH] ath6kl: mark expected switch fall-throughs

/* fall through */ >> case WMI_11AG_CAP: >> band_2gig = true; >> band_5gig = true; > >Hm, typically such comments are done on a line of their own, have > never seen this style... Yeah, I was wondering the same. Was there a particular reason for this? -- Kalle Valo

Re: [PATCH] ath6kl: mark expected switch fall-throughs

"Gustavo A. R. Silva" <gust...@embeddedor.com> writes: > On 05/25/2018 08:30 AM, Kalle Valo wrote: >> Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes: >> >>> On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote: >>> >>>> I

Re: [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode

/testmode.c: C source, UTF-8 Unicode > (with BOM) text > > and after: > > drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text > > Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)") > Signed-off-by: Geert Uytterhoeven I'll queue this for 4.18. -- Kalle Valo

Re: mwifiex: fix mwifiex_hard_start_xmit()'s return type

Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > >

Re: qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type

Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > >

<    3   4   5   6   7   8   9   10   >