Re: rsi_91x: fix structurally dead code

"Gustavo A. R. Silva" wrote: > Function rsi_hal_key_config returns before reaching code at line > 922 if (status), hence this code is structurally dead. > > Fix this by storing the value returned by rsi_hal_load_key > into _status_ for its further evaluation and use. >

Re: rsi_91x: fix uninitialized variable

"Gustavo A. R. Silva" wrote: > There is a potential execution path in which variable ret is returned > without being properly initialized previously. > > Fix this by storing the value returned by function > rsi_usb_master_reg_write into _ret_. > > Addresses-Coverity-ID:

Re: rt2x00: fix spelling mistake in various macros, UKNOWN -> UNKNOWN

Colin Ian King wrote: > From: Colin Ian King > > Rename several macros that contain mispellings of UNKNOWN > > Signed-off-by: Colin Ian King > Acked-by: Stanislaw Gruszka Patch applied to

Re: mwifiex: fix spelling mistake: "capabilties" -> "capabilities"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in function names and text strings > > Signed-off-by: Colin Ian King Failed to apply: error: patch failed:

Re: net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment

Jia-Ju Bai wrote: > dma_tx_fragment() is never called in atomic context. > > dma_tx_fragment() is only called by b43legacy_dma_tx(), which is > only called by b43legacy_tx_work(). > b43legacy_tx_work() is only set a parameter of INIT_WORK() in >

Re: ipw2100: fix spelling mistake: "decsribed" -> "described"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in comment and in the ord_data text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

pull-request: wireless-drivers 2018-04-26

Hi Dave, here's a pull request to net tree, more info below. Please let me know if you have any problems. Kalle The following changes since commit 4608f064532c28c0ea3c03fe26a3a5909852811a: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next (2018-04-03 14:08:58 -0700) are

Re: drivers/wireless: ath: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@qca.q

Re: qtnfmac: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@co

Re: rtlwifi: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@cod

Re: drivers/wireless: rsi: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@codeaur

Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy

Arnd Bergmann wrote: > The stack consumption in this driver is still relatively high, with one > remaining warning if the warning level is lowered to 1536 bytes: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: > the frame size of 1880 bytes is

Re: rtlwifi: rtl8821ae: Fix typo in variable name

Nik Nyby wrote: > In _rtl8821ae_dbi_write(), wrtie_addr should be write_addr. > > Signed-off-by: Nik Nyby Patch applied to wireless-drivers-next.git, thanks. 62689167261d rtlwifi: rtl8821ae: Fix typo in variable name --

Re: cw1200: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Solomon Peachy <pi...@s

Re: atmel: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Simon Kelley <si...@thekel

Re: rtlwifi: Remove seq_number from rtl_tid_data

Ping-Ke Shih wrote: > From: Ping-Ke Shih > > Since mac80211 maintains the sequence number for each STA/TID, > driver doesn't need to maintain a copy. > > Signed-off-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git,

Re: [08/58] net/wireless/ray_cs: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@codeauror

Re: libertas: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@code

Re: mwifiex: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@codeaur

Re: iwlegacy: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@codeaur

Re: ath10k: spectral: Remove redundant check

Christos Gkekas <chris.ge...@gmail.com> wrote: > Variable val is unsigned, so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas <chris.ge...@gmail.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to a

Re: drivers/wireless: ath: Convert timers to use timer_setup()

Kees Cook <keesc...@chromium.org> wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo <kv...@qca.q

Re: wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

Jia-Ju Bai <baijiaju1...@163.com> wrote: > No rcu_read_lock is called, but rcu_read_unlock is still called. > Thus rcu_read_unlock should be removed. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> > Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org>

Re: ath9k: debug: Remove redundant check

Christos Gkekas <chris.ge...@gmail.com> wrote: > Variable val is unsigned, so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas <chris.ge...@gmail.com> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to a

Re: [PATCH] ath9k: add a quirk to set use_msi automatically

rtlwifi have similar situation that with certain laptops users were required to enable a module parameter to get the device working? I think rtlwifi should do the same as AceLan does here as then the user would not need to manually set the module parameter. -- Kalle Valo

Re: wl1251: check return from call to wl1251_acx_arp_ip_filter

Colin Ian King wrote: > From: Colin Ian King > > Currently the less than zero error check on ret is incorrect > as it is checking a far earlier ret assignment rather than the > return from the call to wl1251_acx_arp_ip_filter. Fix this by >

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

Larry Finger <larry.fin...@lwfinger.net> writes: > On 01/08/2018 10:21 AM, Kalle Valo wrote: >> Jia-Ju Bai <baijiaju1...@gmail.com> wrote: >> >>> b43_radio_2057_init_post is not called in an interrupt handler >>> nor holding a spinlock. >>>

Re: brcmfmac: Use zeroing memory allocator than allocator/memset

Himanshu Jha wrote: > Use dma_zalloc_coherent for allocating zeroed > memory and remove unnecessary memset function. > > Done using Coccinelle. > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > 0-day tested with no failures. > > Suggested-by: Luis

Re: mt76: fix memcpy to potential null pointer on failed allocation

Colin Ian King wrote: > From: Colin Ian King > > Currently if the allocation of skb fails and returns NULL then the > call to skb_put will cause a null pointer dereference. Fix this by > checking for a null skb and returning NULL. Note that

Re: [V2] wcn36xx: fix incorrect assignment to msg_body.min_ch_time

orrect. > > Detected by CoverityScan, CID#1463042 ("Unused Value") > > Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org> > S

pull-request: wireless-drivers 2018-01-09

* fix dynamic power save which has been broken since the driver was commited Emmanuel Grumbach (1): iwlwifi: pcie: fix DMA memory mapping / unmapping Kalle Valo (1): Merge ath-current from git://git.kernel.org/.../kvalo

Re: rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 29 Dec 2017 22:11:42 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > >

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

Jia-Ju Bai wrote: > b43_radio_2057_init_post is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai You submitted an identical

pull-request: wireless-drivers 2018-01-17

Hi Dave, here are few more important fixes to the net tree for 4.15, I hope they still make it. Please let me know if there are any problems. Kalle The following changes since commit 49fdde89e2b8574cb55f99b57b7798f44567bc4b: Merge ath-current from

Re: [PATCH] [wireless-next] mt76: fix building without CONFIG_LEDS_CLASS

rate Kconfig option for the LED support, this will be available > whenever it will link, and otherwise the respective code gets left out from > the driver object. > > Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets") > Signed-off-by: Arnd Bergmann <a...@arndb.de> I'm planning to queue this for 4.16. -- Kalle Valo

Re: ath9k: add a quirk to set use_msi automatically

ron 24-3460 >Dell Inspiron 3472 >Dell Inspiron 14-3473 >Dell Vostro 3262 >Dell Vostro 15-3572 > > Signed-off-by: AceLan Kao <acelan....@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, t

Re: [next] rtlwifi: btcoexist: remove redundant variable fw_ps_state

Colin Ian King wrote: > From: Colin Ian King > > Variable fw_ps_state is assigned a value but it is never read, hence > it is redundant and can be removed. > > Cleans up clang warning: >

pull-request: wireless-drivers-next 2018-01-19

ant -ve check against u32 integer size rtlwifi: btcoexist: remove redundant variable fw_ps_state Kalle Valo (2): ath10k: fix recently introduced checkpatch warnings Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Larry Finger (1): rtlwifi: btcoex: Remove typede

Re: wcn36xx: release resources in case of error

Ramon Fried wrote: > wcn36xx_dxe_init() doesn't check for the return value > of wcn36xx_dxe_init_descs(). > This patch releases the resources in case an error ocurred. > > Signed-off-by: Ramon Fried This is a duplicate. Patch set to Superseded.

Re: wcn36xx: release resources in case of error

Ramon Fried wrote: > wcn36xx_dxe_init() doesn't check for the return value > of wcn36xx_dxe_init_descs(). > This patch releases the resources in case an error ocurred. > > Signed-off-by: Ramon Fried This is a duplicate. Patch set to Superseded.

Re: wcn36xx: release resources in case of error

Ramon Fried wrote: > wcn36xx_dxe_init() doesn't check for the return value > of wcn36xx_dxe_init_descs(). > This patch releases the resources in case an error ocurred. > > Signed-off-by: Ramon Fried Doesn't compile:

pull-request: wireless-drivers 2018-01-26

Hi Dave, this is a pull request to the net tree for 4.15. I hate to do late pull requests like this but today Sven Joachim found a serious regression in one of ssb patches, I hope there's still enough time to get this to 4.15. But if it's too late, just let me know and I'll queue this for 4.16.

Re: pull-request: wireless-drivers 2018-01-26

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Fri, 26 Jan 2018 18:33:33 +0200 > >> this is a pull request to the net tree for 4.15. I hate to do late pull >> requests like this but today Sven Joachim found a se

pull-request: wireless-drivers-next 2018-01-26

cid to the core for multicast rx mt76: validate rx CCMP PN Igor Mitsyanko (2): qtnfmac: do not use mutexes in timer context qtnfmac: do not use bus mutex for events processing Kalle Valo (1): Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Lior David

Re: [next] ath10k: fix spelling mistake: "addrress" -> "address"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in warning message text. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git

Re: ath10k: remove redundant -ve check against u32 integer size

) > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 95f27a51ee02 ath10k: remove redundant -ve check against u32 integer size -- https://patchwork.kernel.org/

Re: [v2] wcn36xx: release resources in case of error

Ramon Fried <rfr...@codeaurora.org> wrote: > wcn36xx_dxe_init() doesn't check for the return value of > wcn36xx_dxe_init_descs(), release the resources in case an error ocurred. > > Signed-off-by: Ramon Fried <rfr...@codeaurora.org> > Signed-off-by: Kalle Valo &l

Re: [v2] brcmfmac: Use zeroing memory allocator than allocator/memset

Himanshu Jha wrote: > Use dma_zalloc_coherent for allocating zeroed > memory and remove unnecessary memset function. > > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > > Suggested-by: Luis R. Rodriguez > Signed-off-by:

Re: [v2] b43: Replace mdelay with usleep_range in b43_radio_2057_init_post

Jia-Ju Bai wrote: > b43_radio_2057_init_post is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with usleep_range, > to reduce busy wait. > > Signed-off-by: Jia-Ju Bai > Acked-by: Larry

pull-request: wireless-drivers-next 2018-01-13

NULL in MGMT_TX command qtnfmac: modify GET_STA_STATS cmd format for back/forward compatibility qtnfmac: keeping track of "generation" for STA info Jia-Ju Bai (1): b43: Replace mdelay with usleep_range in b43_radio_2057_init_post Kalle Valo (8): ath10k: remove depr

pull-request: wireless-drivers-next 2018-02-08

Felix Fietkau (4): mt76: implement AP_LINK_PS mt76: implement processing of BlockAckReq frames mt76: avoid re-queueing A-MPDU rx reorder work if no frames are pending mt76: do not set status->aggr for NULL data frames Kalle Valo (2): Merge git://git.kernel.org/.../kv

Re: [PATCH] ath9k: turn on btcoex_enable as default

. And bluetooth peripherals are more than ever now, so it > would be great to use BT out of the box. Sure, but we have to make sure that we don't create regressions on existing systems. For example, did you test this with any system which don't support btcoex? (just asking, haven't tested this myself) -- Kalle Valo

Re: [PATCH v2 0/6] wl1251: Fix MAC address for Nokia N900

i! Are there any comments for first 4 patches? If not, could they be >> > accepted and merged? >> >> Since the first 4 patches do not touch the firmware API they seem fine to me >> so >> long as the maintainer accepts them. Maybe resend and clarify you have >> dropped >> the other ones and amend with the new tags. > > According to get_maintainer.pl, Kalle Valo is maintainer. > > Kalle Valo, if you do not have any other comments, can you accept first > 4 patches? Or do you really need to resent first 4 patches again? The first 4 patches are now in my queue, I should get to them in the next few days. -- Kalle Valo

Re: [next] ath10k: wmi: remove redundant integer fc

Colin Ian King <colin.k...@canonical.com> wrote: > Variable fc is being assigned but never used, so remove it. Cleans > up the clang warning: > > warning: Value stored to 'fc' is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> &

Re: wil6210: fix build warnings without CONFIG_PM

ile as well for consistency. > > Fixes: 94162666cd51 ("wil6210: run-time PM when interface down") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 203dab8395d9 wil621

Re: [PATCH v2] qrtr: add MODULE_ALIAS macro to smd

a part of a patchset. > --- > net/qrtr/smd.c | 1 + > 1 file changed, 1 insertion(+) The change log should be after "---" line so that git-am can discard it automatically. Now the changelog would be part of git commit log and we don't want that. So please submit v3. -- Kalle Valo

Re: [PATCH] net: wireless: ath: Convert to using %pOFn instead of device_node.name

Rob Herring writes: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: linux-wirel...@vger.kernel.org > Cc: netdev@vger.kernel.o

Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings

"H. Nikolaus Schaller" writes: > wl1271_warning() already appends a \n to the format, > so adding one to the warning string gives empty lines in the log. > > Signed-off-by: H. Nikolaus Schaller "drivers: net:" in the title is unnecessary, but I can remove that. -- Kalle Valo

Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings

"H. Nikolaus Schaller" writes: >> Am 25.07.2018 um 08:40 schrieb Kalle Valo : >> >> "H. Nikolaus Schaller" writes: >> >>> wl1271_warning() already appends a \n to the format, >>> so adding one to the warning string gives empty

Re: [PATCH v2] wcn36xx: release resources in case of error

y are called from. It's easier to manage the labels that way. But as this is a style issue I didn't change it. -- Kalle Valo

Re: rtl8xxxu: Fix trailing semicolon

Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt > Acked-by: Jes Sorensen Patch applied to

Re: [RESEND] rsi: Remove stack VLA usage

tcharding wrote: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to maximum

Re: wireless: zd1211rw: remove redundant assignment of pointer 'q'

Colin Ian King wrote: > From: Colin Ian King > > Pointer q is initialized and then almost immediately afterwards being > re-assigned the same value. Remove the second redundant assignment. > > Cleans up clang warning: >

Re: ath5k: remove duplicated re-assignment to pointer 'tq'

ireless/ath/ath5k/qcu.c:326:25: warning: Value stored > to 'tq' during its initialization is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks.

Re: [v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

Matthias Kaehlcke wrote: > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > is assigned to itself in an if ... else statement, apparently only to > document that the branch condition is handled and that a previously read > value should be returned

Re: rtlwifi: rtl8192cu: remove pointless memcpy

Arnd Bergmann wrote: > gcc-8 points out that source and destination of the memcpy() are > always the same pointer, so the effect of memcpy() is undefined > here (its arguments must not overlap): > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In function >

Re: brcmsmac: remove duplicated bit-wise or of IEEE80211_CHAN_NO_IR

Colin Ian King wrote: > From: Colin Ian King > > Bit pattern IEEE80211_CHAN_NO_IR is being bit-wise or'd twice; > remove the redundant 2nd IEEE80211_CHAN_NO_IR > > Signed-off-by: Colin Ian King Patch applied to

Re: net/wireless: fix spaces and grammar copy/paste in vendor Kconfig help text

dropping one of those spaces, it also needs some other word > inserted there. Instead of putting each vendor's name there, I chose > to say "these" cards in all of the Kconfig help text. > > Cc: Kalle Valo <kv...@codeaurora.org> > Signed-off-by: Randy Dunlap <

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" wrote: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to

Re: [RESEND] rsi: Remove stack VLA usage

.cc> wrote: >> > On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote: >> >> On Tue, Mar 13, 2018 at 10:17 PM, tcharding <m...@tobin.cc> wrote: >> >> > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: >> >> >> tchard

Re: [RESEND] rsi: Remove stack VLA usage

tcharding <m...@tobin.cc> writes: > On Mon, Mar 12, 2018 at 09:46:06AM +0000, Kalle Valo wrote: >> tcharding <m...@tobin.cc> wrote: >> >> > The kernel would like to have all stack VLA usage removed[1]. rsi uses >> > a VLA based on 'blksize'.

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" <m...@tobin.cc> writes: > On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote: >> On Tue, Mar 13, 2018 at 10:17 PM, tcharding <m...@tobin.cc> wrote: >> > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: >>

Re: [PATCH] [v2] Bluetooth: btrsi: rework dependencies

>> --- >>> drivers/bluetooth/Kconfig| 4 +--- >>> drivers/net/wireless/rsi/Kconfig | 4 +++- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> Acked-by: Marcel Holtmann <mar...@holtmann.org> >> >> Since I think Kalle still has to take it through his tree until the >> btrsi driver makes it into net-next. Yes, I have to take this as I haven't sent the original patch to Dave yet. > Kalle, please wait for v3 though, I just ran into another build > failure caused by a typo in v2. Ok, I saw it. -- Kalle Valo

Re: [PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs

ers/net/wireless/cisco/Kconfig | 2 +- Acked-by: Kalle Valo <kv...@codeaurora.org> -- Kalle Valo

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" <m...@tobin.cc> writes: > On Wed, Mar 14, 2018 at 11:19:53AM +0200, Kalle Valo wrote: >> "Tobin C. Harding" <m...@tobin.cc> writes: >> >> > Added Konstantin in case he is in charge of administering >> > patchwo

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

Arend van Spriel <arend.vanspr...@broadcom.com> writes: > On 3/14/2018 5:10 PM, Kalle Valo wrote: >> Rafał Miłecki <ra...@milecki.pl> writes: >> >>>>> + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; >>>>> +#if !defined(

Re: [PATCH] rsi: Remove stack VLA usage

nstant and declare the array to maximum size. We add a check before > accessing the array in case of programmer error. > > [1]: https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Tobin C. Harding <m...@tobin.cc> Please CC linux-wireless list, otherwise patchwork won't see the patch and I can't apply it. -- Kalle Valo

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

rs/net/wireless/ath/ath9k/dfs.c > 626ab67 ath9k: dfs: use swap macro in ath9k_check_chirping > 50c8cd4 ath9k: remove cast to void pointer > 8fc2b61 ath9k: DFS - add pulse chirp detection for FCC > Yeah, just "ath9k:" is enough as the prefix, no need to have full directory path in the title. -- Kalle Valo

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing -- Kalle Valo

pull-request: wireless-drivers 2018-03-08

Ilan Peer (2): iwlwifi: mvm: Direct multicast frames to the correct station iwlwifi: mvm: Correctly set the tid for mcast queue Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2018-02-16-2' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge tag 'iwlwifi-for-kalle-2018

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

> good exceuse? Could it be there any some good reason for #if defined()? Don't know, maybe just a matter of taste? But it would be nice to know the background behind #ifdef vs #if defined(), never figured it out why two different forms. -- Kalle Valo

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

Arend van Spriel <arend.vanspr...@broadcom.com> writes: > On 3/14/2018 3:24 PM, Kalle Valo wrote: >>> +config BRCMFMAC_IAPP >>> >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >>> >+ depends on BRCMFMAC >>> &

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

data; > + const u16 *b = (const u16 *)iapp_l2_update_packet; > +#endif > + > + if (skb->len - skb->mac_len != 6 || > + !is_multicast_ether_addr(eth_hdr(skb)->h_dest)) > + return false; > + > +#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) #ifdef? -- Kalle Valo

Re: [next] wil6210: fix potential null dereference of ndev before null check

rityScan, CID#1467010 ("Dereference before null check") > > Fixes: e00243fab84b ("wil6210: infrastructure for multiple virtual > interfaces") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Reviewed-by: Maya Erez <me...@codeaurora.org> > Sign

Re: ath10k: fix spelling mistake: "tiggers" -> "triggers"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, tha

Re: ath10k: avoid possible string overflow

low, using strlcat() instead of strncat() avoids the warning and > makes the code more robust. > > Fixes: bc64d05220f3 ("ath10k: debugfs support to get final TPC stats for 10.4 > variants") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Kalle Valo &l

Re: ath9k: dfs: remove accidental use of stack VLA

t; "const"). This just replaces it with a #define. > > Also, fixed as part of the directive to remove all VLAs from > the kernel: https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> > Signed-off-by: Kalle Valo <kv...@

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

Kalle Valo <kv...@codeaurora.org> writes: > Joe Perches <j...@perches.com> writes: > >> Use the new ether_broadcast_addr global instead to save some object code. >> >> Signed-off-by: Joe Perches <j...@perches.com> >> --- >> drivers/net/wirel

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

Ulf Hansson <ulf.hans...@linaro.org> writes: > On 20 March 2018 at 10:55, Kalle Valo <kv...@codeaurora.org> wrote: >> Arend van Spriel <arend.vanspr...@broadcom.com> writes: >> >>>>> If I get it right, you mean something like this: >>>>

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

to what tree the patches are meant for. Otherwise I, and other maintainers as well, need to waste time trying to guess what's your plan. I will now drop the four wireless patches from my queue. So if you want to me to take them please resubmit. -- Kalle Valo

Re: ath6kl: fix spelling mistake: "chache" -> "cache"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, tha

Re: mt7601u: phy: mark expected switch fall-through

"Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > Acked-by: Jakub Kicinski Patch applied to

Re: cw1200: fix spelling mistake: "Mailformed" -> "Malformed"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in wiphy_warn warning message text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

Re: [PATCH v3] ath9k: dfs: Remove VLA usage

fine FFT_NUM_SAMPLES (NUM_DIFFS + 1) I have already applied an almost identical patch: ath9k: dfs: remove accidental use of stack VLA https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next=9c27489a34548913baaaf3b2776e05d4a9389e3e -- Kalle Valo

Re: brcmsmac: phy_lcn: remove duplicate code

"Gustavo A. R. Silva" wrote: > Remove and refactor some code in order to avoid having identical code > for different branches. > > Notice that this piece of code hasn't been modified since 2011. > > Addresses-Coverity-ID: 1226756 ("Identical code for different

Re: [1/2] net: wireless: zydas: Replace mdelay with msleep in zd1201_probe

Jia-Ju Bai wrote: > zd1201_probe() is never called in atomic context. > > zd1201_probe() is only set as ".probe" in struct usb_driver. > > Despite never getting called from atomic context, zd1201_probe() > calls mdelay() to busily wait. > This is not necessary and can

Re: qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler

"Gustavo A. R. Silva" wrote: > In case memory resources for fw were succesfully allocated, release > them before jumping to fw_load_fail. > > Addresses-Coverity-ID: 1466092 ("Resource leak") > Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") >

Re: [v3] Bluetooth: btrsi: rework dependencies

Arnd Bergmann wrote: > The linkage between the bluetooth driver and the wireless > driver is not defined properly, leading to build problems > such as: > > warning: (BT_HCIRSI) selects RSI_COEX which has unmet direct dependencies > (NETDEVICES && WLAN && WLAN_VENDOR_RSI &&

Re: [v2] rsi: Remove stack VLA usage

"Tobin C. Harding" wrote: > The use of stack Variable Length Arrays needs to be avoided, as they > can be a vector for stack exhaustion, which can be both a runtime bug > (kernel Oops) or a security flaw (overwriting memory beyond the > stack). Also, in general, as code evolves it

Re: [next] rsi: remove redundant duplicate assignment of buffer_size

Colin Ian King wrote: > From: Colin Ian King > > Variable buffer_size is re-assigned the same value, this duplicated > assignment is redundant and can be removed. > > Cleans up clang warning: > drivers/net/wireless/rsi/rsi_91x_usb.c:140:4:

<    4   5   6   7   8   9   10   >