Re: rtlwifi: rtl8821ae: fix spelling mistake: "Aboslute" -> "Absolute"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE message text. > > Signed-off-by: Colin Ian King > Acked-by: Larry Finger

Re: [2/4] wireless: Use octal not symbolic permissions

Joe Perches wrote: > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > > Signed-off-by: Joe Perches

Re: [PATCH][next] wil6210: fix potential null dereference of ndev before null check

; Signed-off-by: Colin Ian King <colin.k...@canonical.com> [...] > Reviewed-by: Maya Erez <me...@codeaurora.org> Maya, as you are the wil6210 maintainer you can actually use Acked-by instead of Reviewed-by. Not that it really matters which one you use, both of them indicate me that you have checked and agree the patch, but wanted to point out this anyway :) -- Kalle Valo

Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610

quot;)) > + wcn->rf_id = RF_IRIS_WCN3610; > of_node_put(iris_node); > } Should we document qcom,wcn3610 just like wcn3620 is: Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt: "qcom,wcn3620", -- Kalle Valo

Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610

(really adding Bjorn) Ramon Fried <rfr...@codeaurora.org> writes: > (adding Bjorn Andersson) > > > On 3/29/2018 10:15 AM, Kalle Valo wrote: >> (adding devicetree list) >> >> Ramon Fried <rfr...@codeaurora.org> writes: >> >>> wcn

Re: ath: Remove unnecessary ath_bcast_mac and use eth_broadcast_addr

Joe Perches <j...@perches.com> wrote: > Remove the static array and use the generic routine to set the > Ethernet broadcast address. > > Signed-off-by: Joe Perches <j...@perches.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to a

pull-request: wireless-drivers-next 2018-03-29

hannes Berg (1): iwlwifi: mvm: fix error checking for multi/broadcast sta Kalle Valo (7): Merge tag 'iwlwifi-for-kalle-2018-03-16' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge tag 'iwlwifi-for-kalle-2018-03-19' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merg

Re: [V2] brcmfmac: drop Inter-Access Point Protocol packets by default

Rafał Miłecki wrote: > From: Rafał Miłecki > > Testing brcmfmac with more recent firmwares resulted in AP interfaces > not working in some specific setups. Debugging resulted in discovering > support for IAPP in Broadcom's firmwares. > > Older firmwares were only generating

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

ubmitter was proposing to have a bounce buffer in ath10k to workaround that. I don't remember the details anymore, they are on the ath10k mailing list archive if anyone is curious to know, but I would not be surprised if they are similar as here. So there might be a need to solve this in a generic way (but not sure of course as I haven't checked the details). -- Kalle Valo

Re: [PATCH net-next v2 1/2] brcmfmac: add new dt entries for SG SDIO settings

/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) Why net-next? To me it looks like this should go to wireless-drivers-next. -- Kalle Valo

pull-request: wireless-drivers-next 2018-03-24

Hi Dave, here's the first pull request to net-next for 4.17. What's special here is the addition of a new bluetooth driver, but that's been acked by Marcel. Also we add a new include file to include/net because of that. Please let me know if you have any problems. Kalle The following changes

pull-request: wireless-drivers 2018-03-24

): iwlwifi: mvm: fix error checking for multi/broadcast sta Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2018-03-16' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge tag 'iwlwifi-for-kalle-2018-03-19' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Luca Coelho (1

Re: [next] wil6210: fix spelling mistake: "preperation"-> "preparation"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in debug error message text. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of

Re: [v2,1/6] wl1251: Update wl->nvs_len after wl->nvs is valid

Pali Rohár wrote: > If kmemdup fails, then wl->nvs_len will contain invalid non-zero size. > > Signed-off-by: Pali Rohár > Acked-by: Pavel Machek 4 patches applied to wireless-drivers-next.git, thanks. f63b4c971f5f wl1251: Update wl->nvs_len after wl->nvs

Re: brcm80211: remove duplicated bit-wise or of IEEE80211_CHAN_NO_IR

Colin Ian King wrote: > From: Colin Ian King > > Bit pattern IEEE80211_CHAN_NO_IR is being bit-wise or'd twice; > remove the redundant 2nd IEEE80211_CHAN_NO_IR > > Signed-off-by: Colin Ian King The prefix should

Re: rtl8187: Fix NULL pointer dereference in priv->conf_mutex

Sudhir Sreedharan wrote: > This can be reproduced by bind/unbind the driver multiple times > in AM3517 board. > > Analysis revealed that rtl8187_start() was invoked before probe > finishes(ie. before the mutex is initialized). > > INFO: trying to register non-static

Re: [PATCH] qtnfmac: avoid uninitialized variable access

tool > warning. It looks like the patch from Arnd does not cover both cases. > So we will take a closer look and send a combined fix later. Ok, I'll drop this from my queue. Please resend whatever patch I need to apply. -- Kalle Valo

Re: [PATCH][next] ath10k: fix out of bound read on array ath10k_rates

Colin King wrote: > From: Colin Ian King > > An out-of-bounds read on array ath10k_rates is occurring because > the maximum number of elements is currently based on the size of > the array and not the number of elements in the array. Fix this > by using ARRAY_SIZE instead of sizeof. > >

<    5   6   7   8   9   10