[PATCH V2 net 1/4] net: hns: fix a bug for cycle index

2016-03-11 Thread Lisheng
From: Qianqian Xie The cycle index should be varied while the variable j is a fixed value. The patch will fix this bug. Signed-off-by: Qianqian Xie --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 12 ++-- 1 file changed, 6

[PATCH V2 net 2/4] net: hns: bug fix for format string

2016-03-11 Thread Lisheng
From: Qianqian Xie There is not a format string in function snprinf(). This patch will fix it. Signed-off-by: Qianqian Xie --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH V2 net 4/4] net: hns: remove useless head=ring->next_to_clean

2016-03-11 Thread Lisheng
From: Qianqian Xie The variable head in hns_nic_tx_fini_pro has read a value, but the value is not used. The patch will solve it. The bug-fixed comment is for the function pointer ring_data->fini_process,that is called in function hns_nic_common_poll.The comment should

[PATCH V2 net 0/4] net: hns: bugs fix about hns driver

2016-03-11 Thread Lisheng
From: Qianqian Xie There is some inappropriate application of values in hns driver, such as cycle index, returned value, format string, useless citation. This patch set will solve it. --- change log: PATCH v2: - This patchset fixes the comments provided by Andy

[PATCH V2 net 3/4] net: hns: bug fix for return values

2016-03-11 Thread Lisheng
From: Qianqian Xie The return values in the first two functions mdiobus_write() are ignored. The patch will fix it. Signed-off-by: Qianqian Xie --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH net 4/4] net: hns: remove useless head=ring->next_to_clean

2016-03-07 Thread Lisheng
From: Qianqian Xie The variable head in hns_nic_tx_fini_pro has read a value, but the value is not used. The patch will solve it. Signed-off-by: Qianqian Xie --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 +--- 1 file changed, 1

[PATCH net 3/4] net: hns: bug fix for return values

2016-03-07 Thread Lisheng
From: Qianqian Xie The return values in the first two functions mdiobus_write() are ignored. The patch will fix it. Signed-off-by: Qianqian Xie --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH net 1/4] net: hns: fix a bug for cycle index

2016-03-07 Thread Lisheng
From: Qianqian Xie The cycle index should be varied while the variable j is a fixed value. The patch will fix this bug. Signed-off-by: Qianqian Xie --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 12 ++-- 1 file changed, 6

[PATCH net 0/4] net: hns: bugs fix about hns driver

2016-03-07 Thread Lisheng
From: Qianqian Xie There is some inappropriate application of values in hns driver, such as cycle index, returned value, format string, useless citation. This patch set will solve it. Qianqian Xie (4): net: hns: fix a bug for cycle index net: hns: bug fix for format

[PATCH net 2/4] net: hns: bug fix for format string

2016-03-07 Thread Lisheng
From: Qianqian Xie There is not a format string in function snprinf(). This patch will fix it. Signed-off-by: Qianqian Xie --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH net] net: hns: set xge statistic reg as read only

2016-03-07 Thread Lisheng
From: Qianqian Xie As the user manual describs, XGE_DFX_CTRL_CFG.xge_dfx_ctrl_cfg should be configed as zero if we want xge statistic reg to be read only. But the older hisilicon arm64 process gets the other meanings. So it seems that we need to identify the process and

[PATCH net 3/3] net: hns: fixed set-coalesce-usecs return void bug

2016-03-03 Thread Lisheng
Seting coalesce time maybe return err, and ethtool should process the err. Signed-off-by: Lisheng <lisheng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.h | 2 +- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 6 +++--- drivers/net/ethernet/hisilicon/hns/hns_eth

[PATCH net 2/3] net: hns: modified dump overtime regs

2016-03-03 Thread Lisheng
In V2 chip, the timeover reg_addr is different from V1; And there are 6 regs for service ports,that is different from V1. In dump regs function, should also fix this change. Signed-off-by: Lisheng <lisheng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.

[PATCH net 0/3] net: hns: fixed the setting overtime bug

2016-03-03 Thread Lisheng
In V2 chip,we can set overtime reg is for each port, that is differents from for all port in V1. This patch will modify some functions: set/get the reg. Lisheng (3): net: hns: fixed the setting overtime bug net: hns: modified dump overtime regs net: hns: fixed set-coalesce-usecs return void

[PATCH net 2/2] net: hns: update pause regs to dump function

2016-03-03 Thread Lisheng
Add two new regs to dump and stats function: DSAF_PAUSE_CFG_REG DSAFV2_INODE_FINAL_IN_PAUSE_NUM_0_REG. Signed-off-by: Lisheng <lisheng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 22 +- 1 file changed, 17 insertions(+), 5 del

[PATCH net 1/2] net: hns: fixed the pause ctl bug

2016-03-03 Thread Lisheng
The patch is support pause in V2 chip, that are forbidden in V1 chip: 1) service ports can disable rx pause frame. 2) debug ports can open tx/rx pause frame. Signed-off-by: Lisheng <lisheng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c

[PATCH net 0/2] net: hns: fixed the pause ctl bug

2016-03-03 Thread Lisheng
The change is for supporting pause in V2 chip: service ports can close pause-rx; debug ports can open pause-rx/tx. Lisheng (2): net: hns: fixed the pause ctl bug net: hns: update pause regs to dump function drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 20

[PATCH net 1/3] net: hns: fixed the setting overtime bug

2016-03-03 Thread Lisheng
In V2 chip,we can set overtime reg is for each port, that is differents from for all port in V1. This patch will modify some functions: set/get the reg. Signed-off-by: Lisheng <lisheng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 60 +++- drivers/net/et