Re: [PATCH 00/21] ARCNET: Defibrillation

2015-04-24 Thread Marc Kleine-Budde
hardware...and a lot of these machines still talk ARCNET :) Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686

pull-request: can 2015-05-01

2015-05-01 Thread Marc Kleine-Budde
Hello David, this is a pull request of a single patch for net/master. The patch is contributed by Jeppe Ledet-Pedersen, it fixes the extended frame handling in the xilinx driver. regards, Marc --- The following changes since commit e813bb2b955d9f72c94be7d592746b49929a499b: net: fec: Fix

Re: [PATCH] net: can: xilinx_can: fix extended frame handling

2015-05-01 Thread Marc Kleine-Budde
. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc

Re: [PATCH v2] can: mcp251x: not correct register address

2015-06-09 Thread Marc Kleine-Budde
-by: Tomas Krcka tomas.kr...@nkgroup.cz Applied to can-next. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA

pull-request: can-next 2015-05-06

2015-06-09 Thread Marc Kleine-Budde
+++--- include/uapi/linux/can/gw.h | 5 net/can/gw.c | 68 +++ 3 files changed, 66 insertions(+), 16 deletions(-) -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826

[PATCH] can: fix loss of CAN frames in raw_rcv

2015-06-21 Thread Marc Kleine-Budde
timestamp set. Maybe there's a better solution in the future but this patch fixes the CAN frame loss so far. Reported-by: Manfred Schlaegl manfred.schla...@gmx.at Signed-off-by: Oliver Hartkopp socket...@hartkopp.net Cc: linux-stable sta...@vger.kernel.org Signed-off-by: Marc Kleine-Budde m

pull-request: can 2015-06-21

2015-06-21 Thread Marc Kleine-Budde
Hello David, this is a, probably too late, pull request for v4.1. Oliver Hartkopp fixed a bug in the generic CAN frame handling code, which may lead to loss of CAN frames. It was introduced during v4.1 development. Please queue via net/master if possible, net-next/master otherwise. I've added

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-21 Thread Marc Kleine-Budde
if this doesn't make it into v4.1 anymore. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http

Re: [PATCH 2/3] rcar_can: print signed IRQ #

2015-06-20 Thread Marc Kleine-Budde
added in a previous patch. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de

Re: [PATCH 0/2] Error message clean-ups for Renesas R-Car CAN driver

2015-07-01 Thread Marc Kleine-Budde
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description

Re: [PATCH] can: flexcan: demote register output to debug level

2015-08-20 Thread Marc Kleine-Budde
...@pengutronix.de Added to can-next. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http

pull-request: can-next 2015-05-06

2015-08-20 Thread Marc Kleine-Budde
: flexcan: demote register output to debug level Nik Nyby (1): can: gs_usb: Fix typo in function name drivers/net/can/flexcan.c| 2 +- drivers/net/can/usb/gs_usb.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) -- Pengutronix e.K. | Marc Kleine-Budde

[PATCH] can: pcan_usb: don't provide CAN FD bittimings by non-FD adapters

2015-08-24 Thread Marc Kleine-Budde
...@hartkopp.net Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/usb/peak_usb/pcan_usb.c | 24 +++ drivers/net/can/usb/peak_usb/pcan_usb_core.c | 4 +- drivers/net/can/usb/peak_usb/pcan_usb_core.h | 4 +- drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 96

pull-request: can 2015-08-24

2015-08-24 Thread Marc Kleine-Budde
by non-FD adapters (2015-08-24 11:15:10 +0200) linux-can-fixes-for-4.2-20150824 Marc Kleine-Budde (1): can: pcan_usb: don't provide CAN FD bittimings by non-FD

[PATCH 1/2] can: mcp251x: fix resume when device is down

2015-07-16 Thread Marc Kleine-Budde
was running Fixes: bf66f3736a94 (can: mcp251x: Move to threaded interrupts instead of workqueues.) Signed-off-by: Stefan Agner ste...@agner.ch Cc: linux-stable sta...@vger.kernel.org Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/spi/mcp251x.c | 13 ++--- 1 file changed

pull-request: can 2015-07-16

2015-07-16 Thread Marc Kleine-Budde
Hello David, this is a pull request of 2 patches by Stefan Agner. He fixes the resume operation in the mcp251x driver. regards, Marc --- The following changes since commit 15afb10df4a3f1bd781373ffd968e70cc4b21a42: Merge branch 'for-upstream' of

[PATCH 2/2] can: mcp251x: get regulators optionally

2015-07-16 Thread Marc Kleine-Budde
Agner ste...@agner.ch Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/spi/mcp251x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c index 3b2f34e6ba9b..b7e83c212023 100644 --- a/drivers/net

[PATCH 09/12] can: esd_usb2: don't touch skb after netif_rx()

2015-07-15 Thread Marc Kleine-Budde
-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/usb/esd_usb2.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c index 411c1af92c62..0e5a4493ba4f 100644 --- a/drivers/net/can/usb/esd_usb2.c

[PATCH 12/12] can: pcan_usb: don't touch skb after netif_rx()

2015-07-15 Thread Marc Kleine-Budde
-system.com Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/usb/peak_usb/pcan_usb.c | 7 +++ drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/can/usb/peak_usb/pcan_usb.c b/drivers/net/can/usb

[PATCH 08/12] can: sja1000: don't touch skb after netif_rx()

2015-07-15 Thread Marc Kleine-Budde
: Oliver Hartkopp socket...@hartkopp.net Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/sja1000/sja1000.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c index 32bd7f451aa4

[PATCH 03/12] can: bfin_can: don't touch skb after netif_rx()

2015-07-15 Thread Marc Kleine-Budde
-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/bfin_can.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/bfin_can.c b/drivers/net/can/bfin_can.c index 27ad312e7abf..57dadd52b428 100644 --- a/drivers/net/can/bfin_can.c +++ b/drivers/net/can

[PATCH 07/12] can: cc770: don't touch skb after netif_rx()

2015-07-15 Thread Marc Kleine-Budde
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/cc770/cc770.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/cc770/cc770.c b/drivers/net/can/cc770/cc770.c index c11d44984036..70a8cbb29e75 100644 --- a/drivers/net/can/cc770/cc770.c

[PATCH 11/12] can: usb_8dev: don't touch skb after netif_rx()

2015-07-15 Thread Marc Kleine-Budde
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/usb/usb_8dev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/usb/usb_8dev.c b/drivers/net/can/usb/usb_8dev.c index dd52c7a4c80d..de95b1ccba3e 100644 --- a/drivers/net/can/usb/usb_8dev.c

[PATCH 10/12] can: ems_usb: don't touch skb after netif_rx()

2015-07-15 Thread Marc Kleine-Budde
-wuensche.com Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/usb/ems_usb.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c index 866bac0ae7e9..2d390384ef3b 100644 --- a/drivers/net/can/usb

[PATCH 01/12] can: at91_can: don't touch skb after netif_receive_skb()/netif_rx()

2015-07-15 Thread Marc Kleine-Budde
There is no guarantee that the skb is in the same state after calling net_receive_skb() or netif_rx(). It might be freed or reused. Not really harmful as its a read access, except you turn on the proper debugging options which catch a use after free. Signed-off-by: Marc Kleine-Budde m

[PATCH 06/12] can: ti_heccn: don't touch skb after netif_rx()

2015-07-15 Thread Marc Kleine-Budde
-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/ti_hecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c index e95a9e1a889f..cf345cbfe819 100644 --- a/drivers/net/can/ti_hecc.c +++ b/drivers/net/can/ti_hecc.c

[PATCH 02/12] can: flexcan: don't touch skb after netif_receive_skb()

2015-07-15 Thread Marc Kleine-Budde
There is no guarantee that the skb is in the same state after calling net_receive_skb() or netif_rx(). It might be freed or reused. Not really harmful as its a read access, except you turn on the proper debugging options which catch a use after free. Signed-off-by: Marc Kleine-Budde m

[PATCH 05/12] can: slcan: don't touch skb after netif_rx_ni()

2015-07-15 Thread Marc Kleine-Budde
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/slcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c index a23a7af8eb9a..9a3f15cb7ef4 100644 --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c

pull-request: can 2015-07-15

2015-07-15 Thread Marc Kleine-Budde
netif_rx() (2015-07-15 09:04:28 +0200) linux-can-fixes-for-4.2-20150715 Marc Kleine-Budde (12): can: at91_can: don't touch skb after netif_receive_skb()/netif_rx

[PATCH 04/12] can: grcan: don't touch skb after netif_rx()

2015-07-15 Thread Marc Kleine-Budde
-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/grcan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c index e3d7e22a4fa0..db9538d4b358 100644 --- a/drivers/net/can/grcan.c +++ b/drivers/net/can/grcan.c

[PATCH 7/8] ARM: dts: dra7x-evm: Prevent glitch on DCAN1 pinmux

2015-07-12 Thread Marc Kleine-Budde
is avoided. Add a new active state that is used by the driver when CAN is actually active. Signed-off-by: Roger Quadros rog...@ti.com Cc: linux-stable sta...@vger.kernel.org Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- arch/arm/boot/dts/dra7-evm.dts | 5 +++-- arch/arm/boot/dts/dra72-evm.dts

[PATCH 8/8] can: replace timestamp as unique skb attribute

2015-07-12 Thread Marc Kleine-Budde
with zero in out-of-tree drivers which are not using alloc_can{,fd}_skb() too. Signed-off-by: Oliver Hartkopp socket...@hartkopp.net Cc: linux-stable sta...@vger.kernel.org Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/dev.c | 7 ++- drivers/net/can/slcan.c | 2

pull-request: can 2015-07-12

2015-07-12 Thread Marc Kleine-Budde
Hello David, this is a pull request of 8 patchs for net/master. Sergei Shtylyov contributes 5 patches for the rcar_can driver, fixing the IRQ check and several info and error messages. There are two patches by J.D. Schroeder and Roger Quadros for the c_can driver and dra7x-evm device tree, which

[PATCH 3/8] can: rcar_can: fix typo in error message

2015-07-12 Thread Marc Kleine-Budde
...@cogentembedded.com Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/rcar_can.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/rcar_can.c b/drivers/net/can/rcar_can.c index 2f9ebad4ff56

[PATCH 2/8] can: rcar_can: print signed IRQ #

2015-07-12 Thread Marc Kleine-Budde
: fd1159318e55 (can: add Renesas R-Car CAN driver) Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/rcar_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/rcar_can.c b

[PATCH 4/8] can: rcar_can: print request_irq() error code

2015-07-12 Thread Marc Kleine-Budde
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Also print the error code when the request_irq() call fails in rcar_can_open(), rewording the error message... Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Signed-off-by: Marc Kleine-Budde m...@pengutronix.de

[PATCH 6/8] can: c_can: Fix default pinmux glitch at init

2015-07-12 Thread Marc Kleine-Budde
-by: Grygorii Strashko grygorii.stras...@ti.com Cc: linux-stable sta...@vger.kernel.org Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/c_can/c_can.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can

[PATCH 1/8] can: rcar_can: fix IRQ check

2015-07-12 Thread Marc Kleine-Budde
) Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Cc: linux-stable sta...@vger.kernel.org Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/rcar_can.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/rcar_can.c b/drivers/net

[PATCH 5/8] can: rcar_can: unify error messages

2015-07-12 Thread Marc Kleine-Budde
Kleine-Budde m...@pengutronix.de --- drivers/net/can/rcar_can.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/rcar_can.c b/drivers/net/can/rcar_can.c index 5e81afffc073..7bd54191f962 100644 --- a/drivers/net/can/rcar_can.c +++ b/drivers/net/can/rcar_can.c

Re: [PATCH 1/2] can: mcp251x: fix resume when device is down

2015-07-15 Thread Marc Kleine-Budde
On 07/15/2015 03:05 PM, Stefan Agner wrote: Hi Marc, hi Wolfgang, Any comment on this two patches? I don't think these have made it in any tree... Sorry - Should I add stable in Cc for 1/2 or even both? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial

Re: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

2015-10-22 Thread Marc Kleine-Budde
; perform any DMA, but be aware that there is no big-endian version of > writel_relaxed() at the moment. We don't have DMA in CAN drivers, but usually a certain write triggers sending. Do we need a barrier before triggering the sending? Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [PATCH v7] can: xilinx: Convert to runtime_pm

2015-10-25 Thread Marc Kleine-Budde
SK) { > priv->write_reg = xcan_write_reg_be; > priv->read_reg = xcan_read_reg_be; > @@ -1141,22 +1169,23 @@ static int xcan_probe(struct platform_device *pdev) > ret = register_candev(ndev); > if (ret) { > dev_err(>dev, &q

Re: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

2015-10-25 Thread Marc Kleine-Budde
side, that last write() could remain a writel() instead > of writel_relaxed(), and that would be guaranteed to work on all > architectures even if they end relax the ordering between MMIO writes. > If there is a measurable performance difference, just use writel_relaxed() > and add a com

Re: [PATCH v8] can: xilinx: Convert to runtime_pm

2015-11-10 Thread Marc Kleine-Budde
mantainable. > > Signed-off-by: Kedareswara rao Appana <appa...@xilinx.com> Applied to can-next. thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax

Re: [PATCH 1/1] can: sja1000: clear interrupts on start

2015-11-11 Thread Marc Kleine-Budde
problem and reporting it to me. I'll add a Reported-by: Christian Magnusson <christian.magnus...@semcon.com> to the patch. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/1] can: sja1000: clear interrupts on start

2015-11-11 Thread Marc Kleine-Budde
ite_reg(priv, SJA1000_RXERR, 0x0); > priv->read_reg(priv, SJA1000_ECC); > > + /* clear interrupt flags */ > + priv->read_reg(priv, SJA1000_IR); > + > /* leave reset mode */ > set_normal_mode(dev); > } > Marc -- Pengutronix e.K

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-03 Thread Marc Kleine-Budde
maintainability wise. > Maybe the issue here is that the original patch is too CAN-like while > it shouldn't be, don't know. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/D

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-03 Thread Marc Kleine-Budde
fix problems in one stack you have to adopt the other, too. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HR

[PATCH] can: Use correct type in sizeof() in nla_put()

2015-10-30 Thread Marc Kleine-Budde
vger.kernel.org Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index aede704605c6..141c2a42d7ed 1006

pull-request: can 2015-10-30

2015-10-30 Thread Marc Kleine-Budde
Hello David, this is a pull request for the upcoming v4.3 release. Marek Vasut provides a patch to use the correct attrlen in the nla_put() in the can_fill_info() function. regards, Marc --- The following changes since commit 89bc7848a91bc99532f5c21b2885472ba710f249: ipv6: protect mtu

Re: [PATCH] can: Use correct type in sizeof() in nla_put()

2015-10-30 Thread Marc Kleine-Budde
andegger.com> > Cc: Marc Kleine-Budde <m...@pengutronix.de> > Cc: netdev@vger.kernel.org Applies to can and added stable on Cc. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertret

Re: [PATCH] can: Use correct type in sizeof() in nla_put()

2015-10-30 Thread Marc Kleine-Budde
On 10/30/2015 03:01 PM, Marek Vasut wrote: > On Friday, October 30, 2015 at 02:40:26 PM, Marc Kleine-Budde wrote: >> On 10/30/2015 01:48 PM, Marek Vasut wrote: >>> The sizeof() is invoked on an incorrect variable, likely due to some >>> copy-paste error, and this might

Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

2015-11-02 Thread Marc Kleine-Budde
ides a different MTU? The CAN stack is already capable to handle CAN and CAN-FD frames. Would it make sense to integrate the ARINC-429 into the existing CAN stack? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-19 Thread Marc Kleine-Budde
ruct net_device *ndev = (struct net_device *)0; > struct ti_hecc_priv *priv; > - struct ti_hecc_platform_data *pdata; > + const struct ti_hecc_platform_data *pdata; > struct resource *mem, *irq; > void __iomem *addr; > int err = -ENODEV; > > - pdata =

Re: [PATCH] net, can, ti_hecc: fix a run time warn_on.

2015-10-19 Thread Marc Kleine-Budde
dev_err(>dev, "register_candev() failed\n"); > -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-19 Thread Marc Kleine-Budde
ti,hecc_ram_offset = <0x3000>; >>> + ti,hecc_mbx_offset = <0x2000>; >>> + ti,hecc_int_line = <0>; >>> + ti,hecc_version = <1>; >> >> Versioning in the OF world is done via the compatible. Are the offsets a >

Re: [PATCH v2] net, can, ti_hecc: fix a run time warn_on.

2015-10-20 Thread Marc Kleine-Budde
uct net_device *dev = platform_get_drvdata(pdev); > struct ti_hecc_priv *priv = netdev_priv(dev); > > - clk_enable(priv->clk); > + clk_prepare_enable(priv->clk); please add error checking. > > hecc_clear_bit(priv, HECC_CANMC, HECC_CANMC_PDR); >

Re: [PATCH v2] net, can, ti_hecc: fix a run time warn_on.

2015-10-20 Thread Marc Kleine-Budde
g? I'm confused here, because in > so many drivers > there is no checking err after clk_enable or clk_prepare_enable. Maybe I > missed something... > Could you clarify this part please? I wouldn't call it a bug in the original driver, it probably slipped through the review or I

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Marc Kleine-Budde
do you mean available? I know only that HECC appear in AM3505 and > AM3517. Nowhere else. Available on the market. Which one was produced first or was soldered first to some PCB? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions|

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 05:18 PM, Marc Kleine-Budde wrote: > On 10/20/2015 05:09 PM, Anton.Glukhov wrote: >>>> It's OMAP3 based arch, but HECC is implemented only in AM3505 and AM3517 >>>> SoCs. >>>> So, I'm confused about what's "name" should I

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 04:57 PM, Anton.Glukhov wrote: > Hello Marc, Heiko! > I'm sorry for the delay! > > On 19.10.2015 10:31, Marc Kleine-Budde wrote: >> On 10/19/2015 09:27 AM, Heiko Schocher wrote: >>>>> .../devicetree/bindings/net/can/ti_hecc-can.txt| 20 +++

Re: [PATCH 4/9] net/can: can_dropped_invalid_skb can be boolean

2015-10-09 Thread Marc Kleine-Budde
On 10/08/2015 03:28 PM, Yaowei Bai wrote: > This patch makes can_dropped_invalid_skb return bool due to this > particular function only using either one or zero as its return > value. > > No functional change. > > Signed-off-by: Yaowei Bai <bywxiao...@163.com> Ack

Re: [PATCH 4/9] net/can: can_dropped_invalid_skb can be boolean

2015-10-12 Thread Marc Kleine-Budde
apply it in one go. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de

Re: [PATCH 12/12] [RFC] can: avoid using timeval for uapi

2015-10-06 Thread Marc Kleine-Budde
might be using this interface, which is likely >>> not acceptable. >> >> Indeed. >> >>> Signed-off-by: Arnd Bergmann <a...@arndb.de> >>> Cc: Oliver Hartkopp <socket...@hartkopp.net> >> >> Thanks for your good suggestion to make the BCM API y203

Re: [PATCH 12/12] [RFC] can: avoid using timeval for uapi

2015-10-06 Thread Marc Kleine-Budde
On 10/06/2015 11:18 AM, Arnd Bergmann wrote: >> Acked-by: Marc Kleine-Budde <m...@pengutronix.de> >> >> add upstream the 2038 fixes as a block. > > Davem already picked up the first 10 of the series. If you don't > mind, I'd prefer if you could take this one int

pull-request: can-next 2015-09-17

2015-10-13 Thread Marc Kleine-Budde
(-) -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description

pull-request: can 2015-08-25

2015-08-25 Thread Marc Kleine-Budde
bittimings by non-FD adapters (2015-08-25 08:50:00 +0200) linux-can-fixes-for-4.2-20150825 Marc Kleine-Budde (1): can: pcan_usb: don't provide CAN FD bittimings

[PATCH] can: pcan_usb: don't provide CAN FD bittimings by non-FD adapters

2015-08-25 Thread Marc Kleine-Budde
. Cc: linux-stable sta...@vger.kernel.org # = 4.0 Reported-by: Oliver Hartkopp socket...@hartkopp.net Tested-by: Oliver Hartkopp socket...@hartkopp.net Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/net/can/usb/peak_usb/pcan_usb.c | 24 +++ drivers/net/can/usb/peak_usb

Re: pull-request: can 2015-08-24

2015-08-25 Thread Marc Kleine-Budde
On 08/24/2015 11:20 AM, Marc Kleine-Budde wrote: Hello David, this is a pull request of one patch by me for the peak_usb driver. It fixes the driver, so that non FD adapters don't provide CAN FD bittimings. As there are some typos in the commit message I'll send an updated pull request

Re: [PATCH v6 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings

2015-09-14 Thread Marc Kleine-Budde
> + reg = <0x01c2bc00 0x400>; > + interrupts = <0 26 4>; > + clocks = <_gates 4>; > + status = "disabled"; > + }; > + > +Board specific .dts file: > + > + can0: can 01c2bc00 { can0

Re: [PATCH v6 2/3] can: Allwinner A10/A20 CAN Controller support - Defconfigs

2015-09-14 Thread Marc Kleine-Budde
On 09/14/2015 02:54 PM, Gerhard Bertelsmann wrote: You might want to add a commit message here. :D > Signed-off-by: Gerhard Bertelsmann <i...@gerhard-bertelsmann.de> Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone

Re: [PATCH v6 3/3] can: Allwinner A10/A20 CAN Controller support - Kernel module

2015-09-14 Thread Marc Kleine-Budde
; + can_led_event(dev, CAN_LED_EVENT_STOP); > + > + return 0; > +} > + > +static const struct net_device_ops sunxican_netdev_ops = { > + .ndo_open = sunxican_open, > + .ndo_stop = sunxican_close, > + .ndo_start_xmit = sunxican_start_xmit, > +}; >

Re: [PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings

2015-09-17 Thread Marc Kleine-Budde
quot;; > + reg = <0x01c2bc00 0x400>; > + interrupts = <0 26 4>; > + clocks = <_gates 4>; > + status = "disabled"; > + }; What about adding this snippet to SoC where the CAN core is available? Maxime, what's the pol

pull-request: can-next 2015-09-17

2015-09-17 Thread Marc Kleine-Budde
| 857 + 4 files changed, 904 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/sun4i_can.txt create mode 100644 drivers/net/can/sun4i_can.c -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux

Re: [PATCH v8 0/4] can: Allwinner A10/A20 CAN Controller support - Summary

2015-09-17 Thread Marc Kleine-Budde
ent Kernel versions (4.x, next etc.). > > [PATCH v8 1/4] Device Tree Binding Documentation > [PATCH v8 2/4] Defconfig multi_v7 > [PATCH v8 3/4] Defconfig sunxi > [PATCH v8 4/4] Kernel Module Applies 1 and 4 with maxime's Ack to linux-can-next. Thanks, Marc -- Pengutronix e.

Re: [PATCH v7 3/3] can: Allwinner A10/A20 CAN Controller support - Kernel module

2015-09-15 Thread Marc Kleine-Budde
>> +goto exit_clock; >> +} >> + >> +err = sunxi_can_start(dev); >> +if (err) { >> +netdev_err(dev, "could not start CAN peripheral\n"); >> +goto exit_can_start; >> +} >> + >>

[PATCH] can: peak_pci: add unused device id. in devices table

2015-09-30 Thread Marc Kleine-Budde
er too. Signed-off-by: Stephane Grosjean <s.grosj...@peak-system.com> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/sja1000/peak_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/sja1000/peak_pci.c b/drivers/net/can/sja1000/peak_pci.c

pull-request: can-next 2015-09-17

2015-09-21 Thread Marc Kleine-Budde
interrupts atomically at the end of flexcan_chip_start() (2015-09-21 08:38:23 +0200) linux-can-next-for-4.4-20150921 Marc Kleine-Budde (8): can: flexcan: cleanup coding

Re: [PATCH 2/2] can: sja1000: of: add compatibility with Technologic Systems version

2015-12-18 Thread Marc Kleine-Budde
through */ > default: > @@ -244,6 +269,7 @@ static int sp_remove(struct platform_device *pdev) > > static const struct of_device_id sp_of_table[] = { > {.compatible = "nxp,sja1000"}, > + {.compatible = "technologic,sja1000"}, > {}, > }; > MODULE_DEVICE_TABLE(of, sp_of_table); > -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature

Re: [PATCH 2/2] can: sja1000: of: add compatibility with Technologic Systems version

2015-12-18 Thread Marc Kleine-Budde
On 12/18/2015 10:02 PM, Damien Riegel wrote: > On Fri, Dec 18, 2015 at 09:41:47PM +0100, Marc Kleine-Budde wrote: >> On 12/18/2015 09:17 PM, Damien Riegel wrote: >>> Technologic Systems provides an IP compatible with the SJA1000, >>> instantiated in an FPGA. Becau

Re: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted

2015-11-18 Thread Marc Kleine-Budde
riv, M_CAN_CCCR); > - u32 timeout = 10; > + u32 timeout = 1000; > u32 val = 0; > > if (enable) { > Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/D

Re: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support

2015-11-18 Thread Marc Kleine-Budde
} > + > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "m_can"); > addr = devm_ioremap_resource(>dev, res); > irq = platform_get_irq_byname(pdev, "int0"); > regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde

pull-request: can-next 2015-11-23

2015-11-23 Thread Marc Kleine-Budde
+-- 1 file changed, 101 insertions(+), 75 deletions(-) -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim

pull-request: can 2015-11-23

2015-11-23 Thread Marc Kleine-Budde
Hello David, this is a pull request of three patches for the upcoming v4.4 release. The first patch is by Mirza Krak, it fixes a problem with the sja1000 driver after resuming from suspend to disk, by clearing all outstanding interrupts. Oliver Hartkopp contributes two patches targeting almost

[PATCH 3/3] can: remove obsolete assignment for CAN protocol error type

2015-11-23 Thread Marc Kleine-Budde
'cf->data[2] = CAN_ERR_PROT_UNSPEC' correctly or we can remove the obsolete OR operation entirely. Signed-off-by: Oliver Hartkopp <socket...@hartkopp.net> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/bfin_can.c| 2 -- drivers/net/can/c_can/c_can.c

[PATCH 1/3] can: sja1000: clear interrupts on start

2015-11-23 Thread Marc Kleine-Budde
y reading the IR register on start we will clear any previous conditions that could be present. Signed-off-by: Mirza Krak <mirza.k...@hostmobility.com> Reported-by: Christian Magnusson <christian.magnus...@semcon.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-o

[PATCH 2/3] can: fix assignment of error location in CAN error messages

2015-11-23 Thread Marc Kleine-Budde
value which points to a location inside the CAN frame on the wire. This patch fixes the assignments for the error locations in error messages. Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Oliver Hartkopp <socket...@hartkopp.net> Signed-off-by: Marc Kleine-Budde &l

Re: [[RESEND]PATCH v7 0/2] Add CAN FD driver support to r8a7795 SoC

2016-06-17 Thread Marc Kleine-Budde
On 06/17/2016 10:30 AM, Marc Kleine-Budde wrote: > On 06/17/2016 10:20 AM, Ramesh Shanmugasundaram wrote: >>Would it be possible for you to consider this patch please? >> >>This patch set has undergone multiple reviews as in the change history >>below. We wou

Re: [PATCH] can: tscan1: Utilize the module_isa_driver macro

2016-06-17 Thread Marc Kleine-Budde
elm.g...@gmail.com> Applied to can-next. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http

[PATCH 2/3] can: at91_can: RX queue could get stuck at high bus load

2016-06-20 Thread Marc Kleine-Budde
interrupts remain disabled. Signed-off-by: Wolfgang Grandegger <w...@grandegger.com> Tested-by: Amr Bekhit <amrbek...@gmail.com> Cc: <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/at91_can.c | 5 +++-- 1 file changed, 3

pull-request: can 2016-06-20

2016-06-20 Thread Marc Kleine-Budde
Hello David, this is a pull request of 3 patches for the upcoming linux-4.7 release. The first patch is by Thor Thayer for the c_can/d_can driver. It fixes the registar access on Altera Cyclone devices, which caused CAN frames to have 0x0 in the first two bytes incorrectly. Wolfgang Grandegger's

[PATCH 3/3] can: gs_usb: Add Basic support for the bytewerk.org candleLight interface

2016-06-20 Thread Marc Kleine-Budde
net> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/usb/Kconfig | 3 ++- drivers/net/can/usb/gs_usb.c | 14 +++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/usb/Kconfig b/drivers/net/can/usb/Kconfig index bcb272f6c

[PATCH 1/3] can: c_can: Update D_CAN TX and RX functions to 32 bit - fix Altera Cyclone access

2016-06-20 Thread Marc Kleine-Budde
c: <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/c_can/c_can.c | 38 +++--- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c i

[PATCH 1/3] can: fix handling of unmodifiable configuration options fix

2016-06-23 Thread Marc Kleine-Budde
lidate the content without taking into account that there's totally no content. This patch adds a check for missing content. Reported-by: ajneu <ajn...@gmail.com> Signed-off-by: Oliver Hartkopp <socket...@hartkopp.net> Cc: <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Bu

[PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Marc Kleine-Budde
driver interface that does just nothing. It's a follow up to commit 993e6f2fd ("can: fix oops caused by wrong rtnl newlink usage") but for dellink. Reported-by: ajneu <ajn...@gmail.com> Signed-off-by: Oliver Hartkopp <socket...@hartkopp.net> Cc: <sta...@vger.kernel.org> S

pull-request: can 2016-06-23

2016-06-23 Thread Marc Kleine-Budde
Hello David, this is a pull request of 3 patches for the upcoming linux-4.7 release. The first two patches are by Oliver Hartkopp fixing oopes in the generic CAN device netlink handling. Jimmy Assarsson's patch for the kvaser_usb driver adds support for more devices by adding their USB product

pull-request: can-next 2016-06-17

2016-06-23 Thread Marc Kleine-Budde
/mcp251x.c | 7 +- net/can/af_can.c | 22 +- net/can/af_can.h | 11 - 5 files changed, 328 insertions(+), 162 deletions(-) -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux

[PATCH 3/3] can: kvaser_usb: Add support for more Kvaser Leaf v2 devices

2016-06-23 Thread Marc Kleine-Budde
From: Jimmy Assarsson <jimmyassars...@gmail.com> This patch adds support for Kvaser Leaf Light HS v2 OEM, Mini PCI Express 2xHS and USBcan Light 2xHS. Signed-off-by: Jimmy Assarsson <jimmyassars...@gmail.com> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/n

Re: [PATCH] can: only call can_stat_update with procfs

2016-06-22 Thread Marc Kleine-Budde
> Fixes: a20fadf85312 ("can: build proc support only if CONFIG_PROC_FS is > activated") Applied to can-next. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund

pull-request: can-next 2016-06-17

2016-06-17 Thread Marc Kleine-Budde
Geert Uytterhoeven (1): MAINTAINERS: Add file patterns for can device tree bindings Marc Kleine-Budde (1): can: dev: can-calc-bit-timing(): better sample point calculation Marek Vasut (1): can: slcan: Replace sizeof struct can_frame with CAN_MTU Maximilian Schneider (2): can

  1   2   3   4   5   >