Re: [PATCH] ipv6: Fixed source specific default route handling.

On 05/05/2015 12:36 PM, Markus Stenberg wrote: If there are only IPv6 source specific default routes present, the host gets -ENETUNREACH on e.g. connect() because ip6_dst_lookup_tail calls ip6_route_output first, and given source address any, it fails, and ip6_route_get_saddr is never called.

Re: [PATCH] ipv6: Fixed source specific default route handling.

On 06/22/2015 07:58 AM, Steven Barth wrote: On 22.06.2015 00:35, Matthias Schiffer wrote: Could you explain in detail what you mean with If you want specific SA, add same route with higher metric and/or (more) specific src match.? Routes aren't bound to specific addresses except via the src

[PATCH net] ipv6: fix crash on ICMPv6 redirects with prohibited/blackholed source

with rt->rt6i_table == NULL in these cases, making the kernel crash. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- This bug exists pretty much forever, please queue up for all -stable kernels. net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 net] ipv6: fix crash on ICMPv6 redirects with prohibited/blackholed source

with rt->rt6i_table == NULL in these cases, making the kernel crash. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: remove now unused variable net net/ipv6/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv

Re: RESEND: Easily reproducible kernel panic due to netdev all_adj_list refcnt handling

On 03/25/2016 11:10 PM, Andrew Collins wrote: > On 03/25/2016 02:43 PM, Matthias Schiffer wrote: >> We've tried your patch, and it changes the symptoms a bit, but doesn't fix >> the panic. I've attached kernel logs of the crash both before and after >> applying the patch.

Re: RESEND: Easily reproducible kernel panic due to netdev all_adj_list refcnt handling

On 02/23/2016 11:29 PM, Andrew Collins wrote: > I'm running into a relatively easily reproducible kernel panic related to > the all_adj_list handling for netdevs > in recent kernels. > > The following sequence of commands will reproduce the issue: > > ip link add link eth0 name eth0.100 type

[PATCH net] vxlan: correctly validate VXLAN ID against VXLAN_VID_MASK

The incorrect check caused an off-by-one error: the maximum VID 0xff was unusable. Fixes: d342894c5d2f ("vxlan: virtual extensible lan") Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID

The incorrect check caused an off-by-one error: the maximum VID 0xff was unusable. Fixes: d342894c5d2f ("vxlan: virtual extensible lan") Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: check against VXLAN_N_VID instead of changing operator drivers

Re: [PATCH net-next 3/3] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

On 03/14/2017 04:28 PM, Jiri Benc wrote: > On Fri, 10 Mar 2017 23:39:44 +0100, Matthias Schiffer wrote: >> @@ -233,17 +234,30 @@ static struct vxlan_dev *vxlan_vs_find_vni(struct >> vxlan_sock *vs, __be32 vni) >> vni = 0; >> >> hlist_for_each_

Re: [PATCH net-next 3/3] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

On 03/15/2017 04:22 PM, Jiri Benc wrote: > On Wed, 15 Mar 2017 15:29:29 +0100, Matthias Schiffer wrote: >> While ensuring that the destination address is link-local iff the source >> address is would also be an option, it didn't seem too useful as the >> destination addres

[PATCH net-next v2 3/6] vxlan: improve validation of address family configuration

Address families of source and destination addresses must match, and changelink operations can't change the address family. In addition, always use the VXLAN_F_IPV6 to check if a VXLAN device uses IPv4 or IPv6. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: new

[PATCH net-next v2 2/6] vxlan: get rid of redundant vxlan_dev.flags

There is no good reason to keep the flags twice in vxlan_dev and vxlan_config. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: new patch drivers/net/vxlan.c | 76 +-- include/net/vxlan.h | 1

[PATCH net-next v2 0/6] vxlan: cleanup and IPv6 link-local support

over IPv6 link-local work, and allow multiple VXLANs wit the same VNI and port, as long as link-local addresses on different interfaces are used. As suggested, I now store in the flags field if the VXLAN uses link-local addresses or not. Matthias Schiffer (6): vxlan: refactor verification

[PATCH net-next v2 1/6] vxlan: refactor verification and application of configuration

set in vxlan_setup before. This caused VXLAN-GPE to use the same default port as other VXLAN sockets instead of the intended IANA-assigned 4790. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: new patch drivers/net/vxlan.c | 202 +

[PATCH net-next v2 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

to respect the ifindex when link-local IPv6 addresses are used, so using the same VNI on multiple interfaces can actually work. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: use VXLAN_F_IPV6_LINKLOCAL in vxlan_vs_find_vni; rebase. drivers/net/vxlan.

[PATCH net-next v2 5/6] vxlan: fix snooping for link-local IPv6 addresses

If VXLAN is run over link-local IPv6 addresses, it is necessary to store the ifindex in the FDB entries. Otherwise, the used interface is undefined and unicast communication will most likely fail. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: use u32 instead of

[PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

are used for the follow-up patches that actually make VXLAN over link-local IPv6 work. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: was "vxlan: don't allow link-local IPv6 local/remote addresses without interface" before. v2 does a lot more

Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

On 04/14/2017 07:27 PM, Sergei Shtylyov wrote: > On 04/14/2017 07:44 PM, Matthias Schiffer wrote: > >> * Multicast addresses are never valid as local address >> * Link-local IPv6 unicast addresses may only be used as remote when the >> local address is link-local as we

Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

On 04/14/2017 07:36 PM, Stephen Hemminger wrote: > On Fri, 14 Apr 2017 18:44:44 +0200 > Matthias Schiffer <mschif...@universe-factory.net> wrote: > >> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >> index 07f89b037681..95a71546e8f2 100644 >> --- a/dri

Re: [PATCH net-next v2 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

On 04/14/2017 07:38 PM, Stephen Hemminger wrote: > On Fri, 14 Apr 2017 18:44:46 +0200 > Matthias Schiffer <mschif...@universe-factory.net> wrote: > >> As link-local addresses are only valid for a single interface, we can allow >> to use the same VNI for multiple

[PATCH net-next 1/3] vxlan: don't allow link-local IPv6 local/remote addresses without interface

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/net/vxlan.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e375560cc74e..cc0ace73d02e 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/v

[PATCH net-next 3/3] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

to respect the ifindex when link-local IPv6 addresses are used, so using the same VNI on multiple interfaces can actually work. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/net/vxlan.c | 88 - 1 file chang

[PATCH net-next 2/3] vxlan: fix snooping for link-local IPv6 addresses

If VXLAN is run over link-local IPv6 addresses, it is necessary to store the ifindex in the FDB entries. Otherwise, the used interface is undefined and unicast communication will most likely fail. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/net/vxlan.

[PATCH net-next 0/3] VXLAN over IPv6 link-local

. The final patch lifts the limitation of not allowing multiple VXLANs with the same VNI and port, as long as link-local IPv6 addresses are used and different interfaces are specified. Again, this brings VXLAN a bit closer to VLANs feature-wise. Matthias Schiffer (3): vxlan: don't allow link-local

Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

On 08/11/2017 06:19 PM, Roopa Prabhu wrote: > On Thu, Aug 10, 2017 at 2:16 PM, Girish Moodalbail > wrote: >> >> if (!is_valid_ether_addr(nla_data(tb[IFLA_ADDRESS]))) { >> - pr_debug("invalid all zero ethernet address\n"); >> +

Re: [PATCH net-next] vxlan: correctly set vxlan->net when creating the device in a netns

; > Fixes: a985343ba906 ("vxlan: refactor verification and application of > configuration") > Signed-off-by: Sabrina Dubroca <s...@queasysnail.net> Thanks for fixing this up, I really didn't expect dev_net() not to return the correct net in setup(). Reviewed-by: Matthias Schiffer &l

[PATCH net-next 2/2] vxlan: add back error messages to vxlan_config_validate() as extended netlink acks

When refactoring the vxlan config validation, some kernel log messages were removed. This brings them back using the new netlink_ext_ack support, and adds some more in the recently added code handling link-local IPv6 addresses. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.

[PATCH net-next 1/2] vxlan: change vxlan_validate() to use netlink_ext_ack for error reporting

addresses), and add messages for the remaining attributes. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/net/vxlan.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index fd0ff9

Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

On 06/26/2017 03:33 PM, David Ahern wrote: > On 6/26/17 2:43 AM, Matthias Schiffer wrote: >> On 06/26/2017 06:08 AM, David Ahern wrote: >>> On 6/25/17 10:04 PM, David Ahern wrote: >>>> On 6/25/17 3:56 PM, Matthias Schiffer wrote: >>>>> Add support for

[PATCH net-next v2 1/5] net: add netlink_ext_ack argument to rtnl_link_ops.newlink

Add support for extended error reporting. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 3 ++- drivers/net/bonding/bond_netlink.c | 3 ++- drivers/net/caif/caif_hsi.c | 3 ++- drivers/net/can

[PATCH net-next v2 0/5] net: add netlink_ext_ack support to rtnl_link_ops

Same changes as http://patchwork.ozlabs.org/patch/780351/ , split into separate patches for each rtnl_link_ops field as requested. Matthias Schiffer (5): net: add netlink_ext_ack argument to rtnl_link_ops.newlink net: add netlink_ext_ack argument to rtnl_link_ops.changelink net: add

[PATCH net-next v2 3/5] net: add netlink_ext_ack argument to rtnl_link_ops.validate

Add support for extended error reporting. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/net/bonding/bond_netlink.c | 3 ++- drivers/net/can/dev.c | 3 ++- drivers/net/dummy.c| 3 ++- drivers/net/geneve.c | 3 ++- d

[PATCH net-next v2 5/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_validate

Add support for extended error reporting. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- include/net/rtnetlink.h | 3 ++- net/core/rtnetlink.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.h

[PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

Add support for extended error reporting. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/net/bonding/bond_netlink.c | 3 ++- include/net/rtnetlink.h| 3 ++- net/bridge/br_netlink.c| 3 ++- net/core/rtnetlink.c | 3 ++- 4

[PATCH net-next v2 2/5] net: add netlink_ext_ack argument to rtnl_link_ops.changelink

Add support for extended error reporting. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 7 --- drivers/net/bonding/bond_netlink.c | 7 --- drivers/net/caif/caif_hsi.c | 3 ++- drive

Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

On 06/26/2017 06:08 AM, David Ahern wrote: > On 6/25/17 10:04 PM, David Ahern wrote: >> On 6/25/17 3:56 PM, Matthias Schiffer wrote: >>> Add support for extended error reporting. >>> >>> Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> &g

[PATCH net-next] net: add netlink_ext_ack support to rtnl_link_ops

The following functions are extended with a netlink_ext_ack argument to allow extended error reporting: * validate * newlink * changelink * slave_validate * slave_changelink Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- Checkpatch is unhappy about the long

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

On 06/23/2017 10:52 AM, Jiri Benc wrote: > This patchset looks good overall (would send my Acked-by for most of > this but I'm late). > > On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote: >> Log messages in these >> functions are removed, as it is generally

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

On 06/23/2017 12:23 PM, Johannes Berg wrote: > On Fri, 2017-06-23 at 12:13 +0200, Matthias Schiffer wrote: >> >> I was told the extended netlink error facilities were not ready yet, >> has that changed since the last release? > > Yes, the facility is in the kernel

Re: [PATCH net-next v2 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

On 04/16/2017 05:15 PM, Matthias Schiffer wrote: > On 04/14/2017 07:38 PM, Stephen Hemminger wrote: >> On Fri, 14 Apr 2017 18:44:46 +0200 >> Matthias Schiffer <mschif...@universe-factory.net> wrote: >> >>> As link-local addresses are only valid for a singl

[PATCH net-next v3 4/6] vxlan: check valid combinations of address scopes

are used for the follow-up patches that actually make VXLAN over link-local IPv6 work. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- Notes: v2: was "vxlan: don't allow link-local IPv6 local/remote addresses without interface" before. v2 does a lot more

[PATCH net-next v3 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

to respect the ifindex when link-local IPv6 addresses are used, so using the same VNI on multiple interfaces can actually work. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- Notes: v2: use VXLAN_F_IPV6_LINKLOCAL in vxlan_vs_find_vni; rebase v3: rebase drive

[PATCH net-next v3 3/6] vxlan: improve validation of address family configuration

Address families of source and destination addresses must match, and changelink operations can't change the address family. In addition, always use the VXLAN_F_IPV6 to check if a VXLAN device uses IPv4 or IPv6. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- Notes:

[PATCH net-next v3 5/6] vxlan: fix snooping for link-local IPv6 addresses

as well defined as for IPv6, and there doesn't seem to be much interest in having the support, it's not implemented for now. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- Notes: v2: use u32 instead of __u32 v3: rebase, add note about IPv4 to commit message drive

[PATCH net-next v3 2/6] vxlan: get rid of redundant vxlan_dev.flags

There is no good reason to keep the flags twice in vxlan_dev and vxlan_config. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- Notes: v2: new patch v3: rebase drivers/net/vxlan.c | 76 +-- include/net/v

[PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

fault port as other VXLAN sockets instead of the intended IANA-assigned 4790. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- Notes: v2: new patch v3: remove kernel log messages drivers/net/vxlan.c | 208

[PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support

(as it is very unusual for errors in netlink requests to be printed to the kernel log.) The commit message of patch 5 has been extended to add a note about IPv4. Matthias Schiffer (6): vxlan: refactor verification and application of configuration vxlan: get rid of redundant vxlan_dev.flags vxlan

[PATCH net-next] vxlan: fix incorrect nlattr access in MTU check

The access to the wrong variable could lead to a NULL dereference and possibly other invalid memory reads in vxlan newlink/changelink requests with a IFLA_MTU attribute. Fixes: a985343ba906 "vxlan: refactor verification and application of configuration" Signed-off-by: Matthias Schiff

[PATCH 1/3] ath9k: remove stray backslash in Makefile

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/net/wireless/ath/ath9k/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile index 36a40ffdce15..90e4a3

[PATCH 2/3] ath9k: move spectral scan support under a separate config symbol

routers, where we'd rather like to avoid the code size and RAM usage of the relay support. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- drivers/net/wireless/ath/ath9k/Kconfig | 14 ++ drivers/net/wireless/ath/ath9k/Makefile | 4 ++-- d

[PATCH 3/3] ath10k: move spectral scan support under a separate config symbol

hardware. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- checkpatch.pl wants me to write a more meaningful description for ATH10K_SPECTRAL, but I don't actually know enough about the spectral scan feature to do so... drivers/net/wireless/ath/ath10k/Kconfig

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

On 12/13/2017 11:37 PM, Stefano Brivio wrote: > Commit a985343ba906 ("vxlan: refactor verification and > application of configuration") introduced a change in the > behaviour of initial MTU setting: earlier, the MTU for a link > created on top of a given lower device, without an initial MTU >

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

On 12/14/2017 01:10 AM, Stefano Brivio wrote: > On Thu, 14 Dec 2017 00:57:32 +0100 > Matthias Schiffer <mschif...@universe-factory.net> wrote: > >> As you note, there is another occurrence of this calculation in >> vxlan_config_apply(): >> &g

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

On 12/14/2017 01:31 AM, Stefano Brivio wrote: > On Thu, 14 Dec 2017 01:25:40 +0100 > Matthias Schiffer <mschif...@universe-factory.net> wrote: > >> On 12/14/2017 01:10 AM, Stefano Brivio wrote: >>> On Thu, 14 Dec 2017 00:57:32 +0100 >>> Matthias Schiffer

[PATCH iproute2] devlink, rdma, tipc: properly define TARGETS without HAVE_MNL

Leaving a variable with a generic name such as TARGETS undefined would lead to Make picking up its value from the environment. Avoid this by always defining TARGETS in the Makefiles. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- I also noticed that many Makefiles

[PATCH net-next] ipv6: provide Kconfig switch to disable accept_ra by default

, as disabling all.accept_ra would preclude users from explicitly enabling accept_ra on individual interfaces. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- net/ipv6/Kconfig| 12 net/ipv6/addrconf.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-)

[PATCH RESEND net-next] ipv6: provide Kconfig switch to disable accept_ra by default

, as disabling all.accept_ra would preclude users from explicitly enabling accept_ra on individual interfaces. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- net/ipv6/Kconfig| 12 net/ipv6/addrconf.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-)