[PATCH net-next 3/7] bnxt_en: don't fake firmware response success when PCI is disabled

2021-03-22 Thread Michael Chan
, the pci_disable_device() when firmware is fatally wounded in bnxt_fw_reset_close() does not need to be addressed, as subsequent commands are already expected to fail due to the BNXT_NO_FW_ACCESS() check in bnxt_hwrm_do_send_msg(). Reviewed-by: Scott Branden Signed-off-by: Edwin Peer Signed-off-by: Michael

[PATCH net-next 5/7] bnxt_en: Set BNXT_STATE_FW_RESET_DET flag earlier for the RDMA driver.

2021-03-22 Thread Michael Chan
RDMA driver. The RDMA driver's stop sequence is different if firmware has gone through a reset. Reviewed-by: Pavan Chebbi Reviewed-by: P B S Naresh Kumar Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH net-next 4/7] bnxt_en: check return value of bnxt_hwrm_func_resc_qcaps

2021-03-22 Thread Michael Chan
From: Scott Branden Check return value of call to bnxt_hwrm_func_resc_qcaps in bnxt_hwrm_if_change and return failure on error. Reviewed-by: Edwin Peer Signed-off-by: Scott Branden Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 - 1 file changed, 4

[PATCH net-next 7/7] bnxt_en: Enhance retry of the first message to the firmware.

2021-03-22 Thread Michael Chan
to retry for this case as well. Reviewed-by: Edwin Peer Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++-- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt

[PATCH net-next 6/7] bnxt_en: Remove the read of BNXT_FW_RESET_INPROG_REG after firmware reset.

2021-03-22 Thread Michael Chan
value due to the above reason. Reading this register is for information purpose only so remove it. Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 31 --- 1 file changed, 11 insertions

Re: [PATCH next 0/3] blackhole device to invalidate dst

2019-06-24 Thread Michael Chan
On Fri, Jun 21, 2019 at 5:45 PM Mahesh Bandewar wrote: > Well, I'm not a TCP expert and though we have experienced > these corner cases in our environment, I could not reproduce > this case reliably in my test setup to try this fix myself. > However, Michael Chan had a setup &g

Re: [PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-04-28 Thread Michael Chan
On Fri, Apr 27, 2018 at 8:15 PM, Zumeng Chen wrote: > diff --git a/drivers/net/ethernet/broadcom/tg3.h > b/drivers/net/ethernet/broadcom/tg3.h > index 3b5e98e..6727d93 100644 > --- a/drivers/net/ethernet/broadcom/tg3.h > +++ b/drivers/net/ethernet/broadcom/tg3.h > @@ -3352,6 +3352,7 @@ struct tg

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-01 Thread Michael Chan
On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: > diff --git a/drivers/net/ethernet/broadcom/tg3.h > b/drivers/net/ethernet/broadcom/tg3.h > index 3b5e98e..c61d83c 100644 > --- a/drivers/net/ethernet/broadcom/tg3.h > +++ b/drivers/net/ethernet/broadcom/tg3.h > @@ -3102,6 +3102,7 @@ enum TG3_F

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-02 Thread Michael Chan
On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote: > On 2018年05月02日 13:12, Michael Chan wrote: >> >> On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: >> >>> diff --git a/drivers/net/ethernet/broadcom/tg3.h >>> b/drivers/net/ethernet/broadcom/tg3.h >

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-02 Thread Michael Chan
On Wed, May 2, 2018 at 5:30 PM, Zumeng Chen wrote: > On 2018年05月03日 01:32, Michael Chan wrote: >> >> On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote: >>> >>> On 2018年05月02日 13:12, Michael Chan wrote: >>>> >>>> On Tue, May 1, 2018 at

[PATCH net] tg3: Fix vunmap() BUG_ON() triggered from tg3_free_consistent().

2018-05-03 Thread Michael Chan
;) Reported-by: Zumeng Chen Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/tg3.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 08bbb63..9f59b12 100644 --- a/drivers/net/e

[PATCH net-next 3/4] bnxt_en: Read phy eeprom A2h address only when optical diagnostics is supported.

2018-05-08 Thread Michael Chan
the offset and read it from location 0. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 +-- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 20 2 files changed, 9 insertions(+), 14 deletions(-) diff

[PATCH net-next 2/4] bnxt_en: Check unsupported speeds in bnxt_update_link() on PF only.

2018-05-08 Thread Michael Chan
Only non-NPAR PFs need to actively check and manage unsupported link speeds. NPAR functions and VFs do not control the link speed and should skip the unsupported speed detection logic, to avoid warning messages from firmware rejecting the unsupported firmware calls. Signed-off-by: Michael Chan

[PATCH net-next 1/4] bnxt_en: Fix firmware message delay loop regression.

2018-05-08 Thread Michael Chan
time. Fixes: 9751e8e71487 ("bnxt_en: reduce timeout on initial HWRM calls") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 12 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 7 +++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/d

[PATCH net-next 4/4] bnxt_en: Always forward VF MAC address to the PF.

2018-05-08 Thread Michael Chan
be the PF assigned MAC address and so we need to make sure we approve it for this case. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/d

[PATCH net-next 0/4] bnxt_en: Fixes for net-next.

2018-05-08 Thread Michael Chan
This series includes a bug fix for a regression in firmware message polling introduced recently on net-next. There are 3 additional minor fixes for unsupported link speed checking, VF MAC address handling, and setting PHY eeprom length. Michael Chan (3): bnxt_en: Fix firmware message delay

[PATCH net-next RFC 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-09 Thread Michael Chan
ethtool -L. Signed-off-by: Michael Chan --- include/linux/if_link.h | 4 include/linux/netdevice.h| 6 ++ include/uapi/linux/if_link.h | 9 + net/core/rtnetlink.c | 28 +--- 4 files changed, 44 insertions(+), 3 deletions(-) diff --git a/inc

[PATCH net-next RFC 2/3] bnxt_en: Store min/max tx/rx rings for individual VFs.

2018-05-09 Thread Michael Chan
With new infrastructure to configure queues differently for each VF, we need to store the current min/max rx/tx rings for each VF. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 + drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 23

[PATCH net-next RFC 3/3] bnxt_en: Implement .ndo_set_vf_queues().

2018-05-09 Thread Michael Chan
Implement .ndo_set_vf_queues() on the PF driver to configure the queues parameters for individual VFs. This allows the admin. on the host to increase or decrease queues for individual VFs. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + drivers/net

[PATCH net-next RFC 0/3] net: Add support to configure SR-IOV VF queues.

2018-05-09 Thread Michael Chan
t; command will subsequently be patched to support the new operation. Michael Chan (3): net: Add support to configure SR-IOV VF minimum and maximum queues. bnxt_en: Store min/max tx/rx rings for individual VFs. bnxt_en: Implement .ndo_set_vf_queues(). drivers/net/ethernet/broadcom/bnxt/bnxt.c

Re: [PATCH net-next RFC 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-09 Thread Michael Chan
On Wed, May 9, 2018 at 4:15 PM, Jakub Kicinski wrote: > On Wed, 9 May 2018 07:21:41 -0400, Michael Chan wrote: >> VF Queue resources are always limited and there is currently no >> infrastructure to allow the admin. on the host to add or reduce queue >> resources for any

Re: [PATCH net-next RFC 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-09 Thread Michael Chan
On Wed, May 9, 2018 at 6:10 PM, Jakub Kicinski wrote: > On Wed, 9 May 2018 17:22:50 -0700, Michael Chan wrote: >> On Wed, May 9, 2018 at 4:15 PM, Jakub Kicinski wrote: >> > On Wed, 9 May 2018 07:21:41 -0400, Michael Chan wrote: >> >> VF Queue resources are always

Re: [PATCH bpf-next v3 04/11] bpf: make bnxt compatible w/ bpf_xdp_adjust_tail

2018-04-18 Thread Michael Chan
ze. > for bnxt driver we will just calculate packet's length unconditionally > > Acked-by: Alexei Starovoitov > Signed-off-by: Nikita V. Shirokov Acked-by: Michael Chan

[PATCH net] bnxt_en: Fix memory fault in bnxt_ethtool_init()

2018-04-19 Thread Michael Chan
ned-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 49 -- drivers/net/ethernet/broadcom/bnxt/bnxt_nvm_defs.h | 2 - 2 files changed, 27 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt

[PATCH net-next 08/14] bnxt_en: Increase RING_IDLE minimum threshold to 50

2018-04-25 Thread Michael Chan
From: Andy Gospodarek This keeps the RING_IDLE flag set in hardware for higher coalesce settings by default and improved latency. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH net-next 00/14] bnxt_en: Net-next updates.

2018-04-25 Thread Michael Chan
of VFs with more limited resources. There are some additional minor improvements and a new function level discard counter. Andy Gospodarek (3): bnxt_en: Increase RING_IDLE minimum threshold to 50 bnxt_en: reduce timeout on initial HWRM calls bnxt_en: add debugfs support for DIM Michael Chan

[PATCH net-next 13/14] bnxt_en: Reserve RSS and L2 contexts for VF.

2018-04-25 Thread Michael Chan
For completeness and correctness, the VF driver needs to reserve these RSS and L2 contexts. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 10 +- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h

[PATCH net-next 02/14] bnxt_en: Remap TC to hardware queues when configuring PFC.

2018-04-25 Thread Michael Chan
open the NIC for the new mapping to take effect. We also need to reprogram all ETS parameters. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 101 +++--- 1 file changed, 60 insertions(+), 41 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next 12/14] bnxt_en: Don't reserve rings on VF when min rings were not provisioned by PF.

2018-04-25 Thread Michael Chan
. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index a45e692..0884e49 100644 --- a

[PATCH net-next 04/14] bnxt_en: Do not set firmware time from VF driver on older firmware.

2018-04-25 Thread Michael Chan
Older firmware will reject this call and cause an error message to be printed by the VF driver. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers

[PATCH net-next 03/14] bnxt_en: Check the lengths of encapsulated firmware responses.

2018-04-25 Thread Michael Chan
guardrails to avoid data corruption. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 9 + drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h | 12 2 files changed, 21 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b

[PATCH net-next 10/14] bnxt_en: add debugfs support for DIM

2018-04-25 Thread Michael Chan
. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/Makefile | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 + drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c | 124

[PATCH net-next 14/14] bnxt_en: Reserve rings at driver open if none was reserved at probe time.

2018-04-25 Thread Michael Chan
: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index fee1c0d..efe5c72 100644 --- a/drivers/net/ethernet/broadcom/bnxt

[PATCH net-next 01/14] bnxt_en: Add TC to hardware QoS queue mapping logic.

2018-04-25 Thread Michael Chan
opened for the new TC to hardware queues to take effect. This patch only adds the basic mapping logic. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 65

[PATCH net-next 05/14] bnxt_en: Simplify ring alloc/free error messages.

2018-04-25 Thread Michael Chan
Replace switch statements printing different messages for every ring type with a common message. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 43 +-- 1 file changed, 6 insertions(+), 37 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next 11/14] bnxt_en: Reserve rings in bnxt_set_channels() if device is down.

2018-04-25 Thread Michael Chan
rings are reserved ahead of time. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index a699ca54..ad98b78

[PATCH net-next 09/14] bnxt_en: reduce timeout on initial HWRM calls

2018-04-25 Thread Michael Chan
the overall latency of firmware calls on newer Intel processors. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 +++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 6 ++ 2 files changed, 29 insertions(+), 3

[PATCH net-next 06/14] bnxt_en: Display function level rx/tx_discard_pkts via ethtool

2018-04-25 Thread Michael Chan
From: Vasundhara Volam Add counters to display sum of rx/tx_discard_pkts of all rings as function level statistics via ethtool. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 33 +++ 1 file changed, 33

[PATCH net-next 07/14] bnxt_en: Do not allow VF to read EEPEOM.

2018-04-25 Thread Michael Chan
Firmware does not allow the operation and would return failure, causing a warning in dmesg. So check for VF and disallow it in the driver. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net

Re: [PATCH net-next 07/14] bnxt_en: Do not allow VF to read EEPEOM.

2018-04-25 Thread Michael Chan
On Wed, Apr 25, 2018 at 6:38 PM, Andrew Lunn wrote: > On Wed, Apr 25, 2018 at 08:40:50PM -0400, Michael Chan wrote: > > Hi Michael > > You have a typO in the Subject. > Thanks. I will wait a day or so for any additional comments before sending v2 to fix the typo.

[PATCH net-next v2 01/14] bnxt_en: Add TC to hardware QoS queue mapping logic.

2018-04-26 Thread Michael Chan
opened for the new TC to hardware queues to take effect. This patch only adds the basic mapping logic. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 65

[PATCH net-next v2 00/14] bnxt_en: Net-next updates.

2018-04-26 Thread Michael Chan
bnxt_en: add debugfs support for DIM Michael Chan (10): bnxt_en: Add TC to hardware QoS queue mapping logic. bnxt_en: Remap TC to hardware queues when configuring PFC. bnxt_en: Check the lengths of encapsulated firmware responses. bnxt_en: Do not set firmware time from VF driver on older

[PATCH net-next v2 13/14] bnxt_en: Reserve RSS and L2 contexts for VF.

2018-04-26 Thread Michael Chan
For completeness and correctness, the VF driver needs to reserve these RSS and L2 contexts. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 10 +- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h

[PATCH net-next v2 11/14] bnxt_en: Reserve rings in bnxt_set_channels() if device is down.

2018-04-26 Thread Michael Chan
rings are reserved ahead of time. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index a699ca54..ad98b78

[PATCH net-next v2 12/14] bnxt_en: Don't reserve rings on VF when min rings were not provisioned by PF.

2018-04-26 Thread Michael Chan
. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index a45e692..0884e49 100644 --- a

[PATCH net-next v2 14/14] bnxt_en: Reserve rings at driver open if none was reserved at probe time.

2018-04-26 Thread Michael Chan
: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index fee1c0d..efe5c72 100644 --- a/drivers/net/ethernet/broadcom/bnxt

[PATCH net-next v2 06/14] bnxt_en: Display function level rx/tx_discard_pkts via ethtool

2018-04-26 Thread Michael Chan
From: Vasundhara Volam Add counters to display sum of rx/tx_discard_pkts of all rings as function level statistics via ethtool. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 33 +++ 1 file changed, 33

[PATCH net-next v2 05/14] bnxt_en: Simplify ring alloc/free error messages.

2018-04-26 Thread Michael Chan
Replace switch statements printing different messages for every ring type with a common message. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 43 +-- 1 file changed, 6 insertions(+), 37 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next v2 10/14] bnxt_en: add debugfs support for DIM

2018-04-26 Thread Michael Chan
. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/Makefile | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 + drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c | 124

[PATCH net-next v2 04/14] bnxt_en: Do not set firmware time from VF driver on older firmware.

2018-04-26 Thread Michael Chan
Older firmware will reject this call and cause an error message to be printed by the VF driver. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers

[PATCH net-next v2 09/14] bnxt_en: reduce timeout on initial HWRM calls

2018-04-26 Thread Michael Chan
the overall latency of firmware calls on newer Intel processors. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 +++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 6 ++ 2 files changed, 29 insertions(+), 3

[PATCH net-next v2 03/14] bnxt_en: Check the lengths of encapsulated firmware responses.

2018-04-26 Thread Michael Chan
guardrails to avoid data corruption. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 9 + drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h | 12 2 files changed, 21 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b

[PATCH net-next v2 02/14] bnxt_en: Remap TC to hardware queues when configuring PFC.

2018-04-26 Thread Michael Chan
open the NIC for the new mapping to take effect. We also need to reprogram all ETS parameters. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 101 +++--- 1 file changed, 60 insertions(+), 41 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next v2 08/14] bnxt_en: Increase RING_IDLE minimum threshold to 50

2018-04-26 Thread Michael Chan
From: Andy Gospodarek This keeps the RING_IDLE flag set in hardware for higher coalesce settings by default and improved latency. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH net-next v2 07/14] bnxt_en: Do not allow VF to read EEPROM.

2018-04-26 Thread Michael Chan
Firmware does not allow the operation and would return failure, causing a warning in dmesg. So check for VF and disallow it in the driver. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net

Re: [PATCH v6 6/6] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

2018-03-23 Thread Michael Chan
On Fri, Mar 23, 2018 at 3:23 PM, Sinan Kaya wrote: > Code includes wmb() followed by writel(). writel() already has a barrier on > some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Create a new wrapper function with r

Re: [PATCH v7 6/7] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

2018-03-25 Thread Michael Chan
line in the patch description is not needed anymore. Other than that, Acked-by: Michael Chan Thanks. > > Signed-off-by: Sinan Kaya

Re: [PATCHv2 next 0/3] blackhole device to invalidate dst

2019-06-28 Thread Michael Chan
On Thu, Jun 27, 2019 at 12:42 PM Mahesh Bandewar wrote: > However, Michael Chan had a setup > where these fixes helped him mitigate the issue and not cause > the crash. > Our lab has finished testing these patches. The patches work in the sense that no oversize packets are now p

[PATCH net 1/5] bnxt_en: Disable bus master during PCI shutdown and driver unload.

2019-06-29 Thread Michael Chan
will generate PCI fatal error. Similarly, in the driver remove method, the context memory should only be freed after DMA has been shutdown for correctness. Fixes: 98f04cf0f1fc ("bnxt_en: Check context memory requirements from firmware.") Signed-off-by: Michael Chan --- drivers/ne

[PATCH net 3/5] bnxt_en: Fix statistics context reservation logic for RDMA driver.

2019-06-29 Thread Michael Chan
changing ethtool rings on the network side. Fix the statistics reservation logic accordingly. Fixes: 780baad44f0f ("bnxt_en: Reserve 1 stat_ctx for RDMA driver.") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 17 +++-- 1 file changed, 11 insert

[PATCH net 2/5] bnxt_en: Fix ethtool selftest crash under error conditions.

2019-06-29 Thread Michael Chan
Fixes: 67fea463fd87 ("bnxt_en: Add interrupt test to ethtool -t selftest.") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/d

[PATCH net 5/5] bnxt_en: Suppress error messages when querying DSCP DCB capabilities.

2019-06-29 Thread Michael Chan
Some firmware versions do not support this so use the silent variant to send the message to firmware to suppress the harmless error. This error message is unnecessarily alarming the user. Fixes: afdc8a84844a ("bnxt_en: Add DCBNL DSCP application protocol support.") Signed-off-by: Mi

[PATCH net 0/5] bnxt_en: Bug fixes.

2019-06-29 Thread Michael Chan
. Michael Chan (5): bnxt_en: Disable bus master during PCI shutdown and driver unload. bnxt_en: Fix ethtool selftest crash under error conditions. bnxt_en: Fix statistics context reservation logic for RDMA driver. bnxt_en: Cap the returned MSIX vectors to the RDMA driver. bnxt_en: Suppress

[PATCH net 4/5] bnxt_en: Cap the returned MSIX vectors to the RDMA driver.

2019-06-29 Thread Michael Chan
driver. This is no longer true and we may return more MSIX vectors than requested, causing inconsistency. Fix it by capping the value. Fixes: 01989c6b69d9 ("bnxt_en: Improve NQ reservations.") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 4 +++- 1 file

Re: [PATCHv3 next 2/3] blackhole_netdev: use blackhole_netdev to invalidate dst entries

2019-07-01 Thread Michael Chan
On Mon, Jul 1, 2019 at 2:39 PM Mahesh Bandewar wrote: > > Use blackhole_netdev instead of 'lo' device with lower MTU when marking > dst "dead". > > Signed-off-by: Mahesh Bandewar Tested-by: Michael Chan

[PATCH net-next 1/4] bnxt_en: rename some xdp functions

2019-07-06 Thread Michael Chan
From: Andy Gospodarek Renaming bnxt_xmit_xdp to __bnxt_xmit_xdp to get ready for XDP_REDIRECT support and reduce confusion/namespace collision. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- drivers/net/ethernet

[PATCH net-next 2/4] bnxt_en: Refactor __bnxt_xmit_xdp().

2019-07-06 Thread Michael Chan
__bnxt_xmit_xdp() is used by XDP_TX and ethtool loopback packet transmit. Refactor it so that it can be re-used by the XDP_REDIRECT logic. Restructure the TX interrupt handler logic to cleanly separate XDP_TX logic in preparation for XDP_REDIRECT. Acked-by: Andy Gospodarek Signed-off-by: Michael

[PATCH net-next 3/4] bnxt_en: optimized XDP_REDIRECT support

2019-07-06 Thread Michael Chan
From: Andy Gospodarek This adds basic support for XDP_REDIRECT in the bnxt_en driver. Next patch adds the more optimized page pool support. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 ++- drivers/net/ethernet

[PATCH net-next 0/4] bnxt_en: Add XDP_REDIRECT support.

2019-07-06 Thread Michael Chan
This patch series adds XDP_REDIRECT support by Andy Gospodarek. Andy Gospodarek (3): bnxt_en: rename some xdp functions bnxt_en: optimized XDP_REDIRECT support bnxt_en: add page_pool support Michael Chan (1): bnxt_en: Refactor __bnxt_xmit_xdp(). drivers/net/ethernet/broadcom/Kconfig

[PATCH net-next 4/4] bnxt_en: add page_pool support

2019-07-06 Thread Michael Chan
the standard page allocator. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/Kconfig | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt.c | 40 +++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 ++ drivers/net

[PATCH net-next v2 2/4] bnxt_en: Refactor __bnxt_xmit_xdp().

2019-07-08 Thread Michael Chan
__bnxt_xmit_xdp() is used by XDP_TX and ethtool loopback packet transmit. Refactor it so that it can be re-used by the XDP_REDIRECT logic. Restructure the TX interrupt handler logic to cleanly separate XDP_TX logic in preparation for XDP_REDIRECT. Acked-by: Andy Gospodarek Signed-off-by: Michael

[PATCH net-next v2 3/4] bnxt_en: optimized XDP_REDIRECT support

2019-07-08 Thread Michael Chan
From: Andy Gospodarek This adds basic support for XDP_REDIRECT in the bnxt_en driver. Next patch adds the more optimized page pool support. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 ++- drivers/net/ethernet

[PATCH net-next v2 0/4] bnxt_en: Add XDP_REDIRECT support.

2019-07-08 Thread Michael Chan
This patch series adds XDP_REDIRECT support by Andy Gospodarek. Andy Gospodarek (3): bnxt_en: rename some xdp functions bnxt_en: optimized XDP_REDIRECT support bnxt_en: add page_pool support Michael Chan (1): bnxt_en: Refactor __bnxt_xmit_xdp(). drivers/net/ethernet/broadcom/Kconfig

[PATCH net-next v2 4/4] bnxt_en: add page_pool support

2019-07-08 Thread Michael Chan
the standard page allocator. v2: Fix up the error path from XDP registration, noted by Ilias Apalodimas. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/Kconfig | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt.c | 47

[PATCH net-next v2 1/4] bnxt_en: rename some xdp functions

2019-07-08 Thread Michael Chan
From: Andy Gospodarek Renaming bnxt_xmit_xdp to __bnxt_xmit_xdp to get ready for XDP_REDIRECT support and reduce confusion/namespace collision. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- drivers/net/ethernet

[PATCH net-next] bnxt_en: Add page_pool_destroy() during RX ring cleanup.

2019-07-09 Thread Michael Chan
_pool_free() can now be removed. bnxt_free_rx_rings() will always be called during normal shutdown or any error paths. Fixes: 322b87ca55f2 ("bnxt_en: add page_pool support") Cc: Ilias Apalodimas Cc: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Michael Chan
On Mon, Aug 21, 2017 at 12:25 PM, Jesper Dangaard Brouer wrote: > > I'be been playing with the latest XDP_REDIRECT feature, that was > accepted in net-next (for ixgbe), see merge commit[1]. > [1] https://git.kernel.org/davem/net-next/c/6093ec2dc31 > Just catching on XDP_REDIRECT and I have a ver

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Michael Chan
On Tue, Aug 22, 2017 at 11:30 AM, Duyck, Alexander H wrote: > On Tue, 2017-08-22 at 11:17 -0700, John Fastabend wrote: >> On 08/22/2017 11:02 AM, Michael Chan wrote: >> > On Mon, Aug 21, 2017 at 12:25 PM, Jesper Dangaard Brouer >> > wrote: >> > > &

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Michael Chan
On Tue, Aug 22, 2017 at 6:06 PM, Alexander Duyck wrote: > On Tue, Aug 22, 2017 at 1:04 PM, Michael Chan > wrote: >> >> Right, but it's conceivable to add an API to "return" the buffer to >> the input device, right? > > You could, it is just added

[PATCH net 0/3] bnxt_en: bug fixes.

2017-08-23 Thread Michael Chan
3 bug fixes related to XDP ring accounting in bnxt_setup_tc(), freeing MSIX vectors when bnxt_re unregisters, and preserving the user-administered PF MAC address when disabling SRIOV. Michael Chan (3): bnxt_en: Fix .ndo_setup_tc() to include XDP rings. bnxt_en: Free MSIX vectors when

[PATCH net 1/3] bnxt_en: Fix .ndo_setup_tc() to include XDP rings.

2017-08-23 Thread Michael Chan
When the number of TX rings is changed in bnxt_setup_tc(), we need to include the XDP rings in the total TX ring count. Fixes: 38413406277f ("bnxt_en: Add support for XDP_TX action.") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + 1 file changed, 1

[PATCH net 3/3] bnxt_en: Do not setup MAC address in bnxt_hwrm_func_qcaps().

2017-08-23 Thread Michael Chan
will overwrite it. Separate the logic that sets up the default MAC address into a new function bnxt_init_mac_addr() that is only called during probe time. Fixes: 4a21b49b34c0 ("bnxt_en: Improve VF resource accounting.") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/b

[PATCH net 2/3] bnxt_en: Free MSIX vectors when unregistering the device from bnxt_re.

2017-08-23 Thread Michael Chan
Take back ownership of the MSIX vectors when unregistering the device from bnxt_re. Fixes: a588e4580a7e ("bnxt_en: Add interface to support RDMA driver.") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH net-next v2] tg3: Be drop monitor friendly

2017-08-24 Thread Michael Chan
cleanup. Use dev_consume_skb_any() for > these 3 locations to be SKB drop monitor friendly. > > Signed-off-by: Florian Fainelli Acked-by: Michael Chan > --- > Changes in v2: > > - also included tg3_tso_bug() as indicated by Michael >

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-24 Thread Michael Chan
On Wed, Aug 23, 2017 at 1:29 AM, Jesper Dangaard Brouer wrote: > On Tue, 22 Aug 2017 23:59:05 -0700 > Michael Chan wrote: > >> On Tue, Aug 22, 2017 at 6:06 PM, Alexander Duyck >> wrote: >> > On Tue, Aug 22, 2017 at 1:04 PM, Michael Chan >> > wrote: >

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-25 Thread Michael Chan
On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend wrote: > On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: >> On Thu, 24 Aug 2017 20:36:28 -0700 >> Michael Chan wrote: >> >>> On Wed, Aug 23, 2017 at 1:29 AM, Jesper Dangaard Brouer >>> wrote:

[PATCH net-next 01/11] bnxt_en: Update firmware interface spec. to 1.8.1.4.

2017-08-28 Thread Michael Chan
Flow APIs are added in this firmware interface. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 186 +- 1 file changed, 181 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h b/drivers/net/ethernet

[PATCH net-next 06/11] bnxt_en: Improve -ENOMEM logic in NAPI poll loop.

2017-08-28 Thread Michael Chan
towards the NAPI budget. Cc: Martin KaFai Lau Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 1afb408..a34fcdd 100644

[PATCH net-next 00/11] bnxt_en: Updates.

2017-08-28 Thread Michael Chan
. Michael Chan (4): bnxt_en: Update firmware interface spec. to 1.8.1.4. bnxt_en: Improve tx ring reservation logic. bnxt_en: Improve -ENOMEM logic in NAPI poll loop. bnxt_en: Reduce default rings on multi-port cards. Ray Jui (1): bnxt: Add PCIe device IDs for bcm58802/bcm58808 Sathya

[PATCH net-next 03/11] bnxt_en: assign CPU affinity hints to bnxt_en IRQs

2017-08-28 Thread Michael Chan
-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 - drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +++- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt

[PATCH net-next 08/11] bnxt_en: fix clearing devlink ptr from bnxt struct

2017-08-28 Thread Michael Chan
bp->dl by passing a NULL dl ptr. Fixes: 4ab0c6a8ffd7 ("bnxt_en: add support to enable VF-representors") Signed-off-by: Sathya Perla Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 4 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.h | 14 +++

[PATCH net-next 11/11] bnxt_en: add code to query TC flower offload stats

2017-08-28 Thread Michael Chan
From: Sathya Perla This patch adds code to implement TC_CLSFLOWER_STATS TC-cmd and the required FW code to query the stats from the HW. Signed-off-by: Sathya Perla Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 95 1 file changed

[PATCH net-next 07/11] bnxt_en: Reduce default rings on multi-port cards.

2017-08-28 Thread Michael Chan
Reduce default rings from 8 to 4 on multi-port cards to reduce memory usage. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 13 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH net-next 09/11] bnxt_en: bnxt: add TC flower filter offload support

2017-08-28 Thread Michael Chan
roduced in a subsequent patch. Signed-off-by: Sathya Perla Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/Kconfig | 9 + drivers/net/ethernet/broadcom/bnxt/Makefile | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 39 +- drivers/net/ethernet/broadcom/b

[PATCH net-next 10/11] bnxt_en: add TC flower offload flow_alloc/free FW cmds

2017-08-28 Thread Michael Chan
From: Sathya Perla This patch adds the hwrm_cfa_flow_alloc/free() routines that are needed to issue the FW cmds needed for TC flower offload. Signed-off-by: Sathya Perla Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 141 ++- 1 file

[PATCH net-next 02/11] bnxt_en: Improve tx ring reservation logic.

2017-08-28 Thread Michael Chan
and reserve again. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 46 +++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 ++- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 +- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c

[PATCH net-next 04/11] bnxt: Add PCIe device IDs for bcm58802/bcm58808

2017-08-28 Thread Michael Chan
From: Ray Jui Add PCIe device ID for bcm58802 and bcm58808. Also add chip number update to declare bcm588xx as chip class phase 4 and later Signed-off-by: Ray Jui Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +++- drivers/net/ethernet/broadcom/bnxt/bnxt.h

[PATCH net-next 05/11] bnxt: initialize board_info values with proper enums

2017-08-28 Thread Michael Chan
From: Scott Branden initialize board_info values with proper enums for defensive programming purposes. This will avoid any errors of the enums being declared not lining up with the board_info array. Signed-off-by: Scott Branden Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom

[PATCH net 3/6] bnxt_en: Fix handling FRAG_ERR when NVM_INSTALL_UPDATE cmd fails

2019-08-16 Thread Michael Chan
("bnxt_en: Retry failed NVM_INSTALL_UPDATE with defragmentation flag enabled.") Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/ne

[PATCH net 2/6] bnxt_en: Improve RX doorbell sequence.

2019-08-16 Thread Michael Chan
("bnxt_en: Re-structure doorbells.") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 1ef224

<    1   2   3   4   5   6   7   8   9   10   >